Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-19 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review87050
---



src/kdropwidgetdecorator.h (line 37)


Indeed this isn't a decorator (unlike KDragWidgetDecorator), and there's 
nothing specific about QTabBar in this code (other than the docu).

In fact I don't understand how one is supposed to use this widget in the 
first place... in a stacked widget? or?

Please add usage documentation (or tell us here), then I might have some 
feedback on the naming and/or on the design ;-)


- David Faure


On Oct. 10, 2015, 10:55 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125521/
> ---
> 
> (Updated Oct. 10, 2015, 10:55 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Christoph Feck, and 
> David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
> from GPL 2+ to LGPL 2+ with author's permission.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kdropwidgetdecorator.h PRE-CREATION 
>   src/kdropwidgetdecorator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125521/diff/
> 
> 
> Testing
> ---
> 
> It builds, the headers I expect are in the right places, etc. I just noticed 
> I'm not exporting the class though, will fix that and reupload.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-10 Thread Christoph Feck 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review86638
---



src/kdropwidgetdecorator.h (lines 34 - 35)


Can this be fixed in Qt?


- Christoph Feck


On Oct. 10, 2015, 10:55 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125521/
> ---
> 
> (Updated Oct. 10, 2015, 10:55 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Christoph Feck, and 
> David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
> from GPL 2+ to LGPL 2+ with author's permission.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kdropwidgetdecorator.h PRE-CREATION 
>   src/kdropwidgetdecorator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125521/diff/
> 
> 
> Testing
> ---
> 
> It builds, the headers I expect are in the right places, etc. I just noticed 
> I'm not exporting the class though, will fix that and reupload.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/
---

Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
---

Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
from GPL 2+ to LGPL 2+ with author's permission.


Diffs
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kdropwidgetdecorator.h PRE-CREATION 
  src/kdropwidgetdecorator.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125521/diff/


Testing
---

It builds, the headers I expect are in the right places, etc. I just noticed 
I'm not exporting the class though, will fix that and reupload.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/
---

(Updated Oct. 4, 2015, 1:43 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Added exporting the class.


Repository: kwidgetsaddons


Description
---

Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
from GPL 2+ to LGPL 2+ with author's permission.


Diffs (updated)
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kdropwidgetdecorator.h PRE-CREATION 
  src/kdropwidgetdecorator.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125521/diff/


Testing
---

It builds, the headers I expect are in the right places, etc. I just noticed 
I'm not exporting the class though, will fix that and reupload.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review86352
---



src/kdropwidgetdecorator.h (line 37)


This isn't really a decorator pattern. It's just a widget.

A decorator would probably take a QTabBar as an argument and then create 
and show this widget as needed depending on how many tabs that tabbar had.



src/kdropwidgetdecorator.cpp (line 41)


if nothing is connected, or it's a queuedconnection then b is uninitialised.

For what this is trying to do, a function pointer might work better.


- David Edmundson


On Oct. 4, 2015, 7:43 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125521/
> ---
> 
> (Updated Oct. 4, 2015, 7:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
> from GPL 2+ to LGPL 2+ with author's permission.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kdropwidgetdecorator.h PRE-CREATION 
>   src/kdropwidgetdecorator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125521/diff/
> 
> 
> Testing
> ---
> 
> It builds, the headers I expect are in the right places, etc. I just noticed 
> I'm not exporting the class though, will fix that and reupload.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel