Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/ --- (Updated Aug. 1, 2016, 5:12 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Edmundson, David Faure, and Marco Martin. Changes --- Submitted with commit 19568657af443b085e4e534f1be96410e75155b3 by Martin Kostolný to branch master. Repository: kio Description --- We have an option called "Mark partially uploaded files" in System Settings -> Network: Settings -> Connection Preferences -> FTP Options. This one toggles adding ".part" extension to partially transferred files through FTP protocol. Other KIO slaves (such as SMB, SFTP) has already working code that supports MarkPartial property read from kioslaverc. This patch is just exposing the property from GUI, specifically I've created "Global Options" section (with one checkbox) above existing "FTP Options" section. Originally I've created a bug report for this: https://bugs.kde.org/show_bug.cgi?id=359636 Diffs - src/kcms/kio/kioslave.kcfg d34b691 src/kcms/kio/netpref.h f7a0abc src/kcms/kio/netpref.cpp 24273a3 Diff: https://git.reviewboard.kde.org/r/127154/diff/ Testing --- Tested toggling MarkPartial on SMB, SFTP slaves. FISH slave was and still is ignoring it (no .part extension). I didn't test NFS and others. Thanks, Martin Kostolný ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review97898 --- Ship it! Ship It! - David Faure On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss this. > > My use-case is indeed the (one specific) remote SMB server has problems > with renaming and it breaks the upload. So I'd like to offer an option to > disable this otherwise very useful ".part" functionality. > > I agree that global-mark-partial-option is not a good idea but I think we > should come up with something. So here is my first proposal: I'm up for the > overblown configuration dialog which would be hidden behind "Avanced upload > options..." button placed in Connection Preferences. Here is one wireframe > (warning - very unfinished! I had little time...): > https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options > would be moved to mentioned configuration dialog as well (to their dedicated > tab). > > As I'm looking to the configuration dialog it is really overblown. Second > proposal: maybe we could use an entirelly different approach like a runtime > option to temporarily but globally disable MarkPartial. Something similar to > "Enable Power Management" button available in expanded battery plasmoid. > > Martin Kostolný wrote: > One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to > be used (in KIO::file_copy(..) etc.) in various file managers. That way we > can delegate this settings to be picked up by file managers like krusader, > dolphin or other tools using KIO. > > David Faure wrote: > We can't delegate the setting to the app. All KIO-based apps use this, > not just file managers. If you save a document in calligra onto an FTP > server, kio_ftp is used, and needs to know whether to use MarkPartial. > > Not sure if I prefer the global option switched on/off temporarily, or > the precise per-host per-protocol setting. Maybe the VDG (visual design > group) has an opinion and/or other ideas... > > Martin Kostolný wrote: > Sorry about this rookie question - what is the right procedure to present > this problem to VDG? Is there such a group to add as reviewers or should I > ask the question on a forum? > > David Faure wrote: > https://vdesign.kde.org/how.html says forum.kde.org Thanks! Sorry it took so long, I've post it here: https://forum.kde.org/viewtopic.php?f=83=132958 - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > >
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On March 23, 2016, 10:51 a.m., Marco Martin wrote: > > Ship It! (as in, ignore my comment about the option, I'm fine with the added option now) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- Ship it! Ship It! - Marco Martin On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss this. > > My use-case is indeed the (one specific) remote SMB server has problems > with renaming and it breaks the upload. So I'd like to offer an option to > disable this otherwise very useful ".part" functionality. > > I agree that global-mark-partial-option is not a good idea but I think we > should come up with something. So here is my first proposal: I'm up for the > overblown configuration dialog which would be hidden behind "Avanced upload > options..." button placed in Connection Preferences. Here is one wireframe > (warning - very unfinished! I had little time...): > https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options > would be moved to mentioned configuration dialog as well (to their dedicated > tab). > > As I'm looking to the configuration dialog it is really overblown. Second > proposal: maybe we could use an entirelly different approach like a runtime > option to temporarily but globally disable MarkPartial. Something similar to > "Enable Power Management" button available in expanded battery plasmoid. > > Martin Kostolný wrote: > One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to > be used (in KIO::file_copy(..) etc.) in various file managers. That way we > can delegate this settings to be picked up by file managers like krusader, > dolphin or other tools using KIO. > > David Faure wrote: > We can't delegate the setting to the app. All KIO-based apps use this, > not just file managers. If you save a document in calligra onto an FTP > server, kio_ftp is used, and needs to know whether to use MarkPartial. > > Not sure if I prefer the global option switched on/off temporarily, or > the precise per-host per-protocol setting. Maybe the VDG (visual design > group) has an opinion and/or other ideas... > > Martin Kostolný wrote: > Sorry about this rookie question - what is the right procedure to present > this problem to VDG? Is there such a group to add as reviewers or should I > ask the question on a forum? https://vdesign.kde.org/how.html says forum.kde.org - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff:
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Úno. 27, 2016, 11:11 dop., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss this. > > My use-case is indeed the (one specific) remote SMB server has problems > with renaming and it breaks the upload. So I'd like to offer an option to > disable this otherwise very useful ".part" functionality. > > I agree that global-mark-partial-option is not a good idea but I think we > should come up with something. So here is my first proposal: I'm up for the > overblown configuration dialog which would be hidden behind "Avanced upload > options..." button placed in Connection Preferences. Here is one wireframe > (warning - very unfinished! I had little time...): > https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options > would be moved to mentioned configuration dialog as well (to their dedicated > tab). > > As I'm looking to the configuration dialog it is really overblown. Second > proposal: maybe we could use an entirelly different approach like a runtime > option to temporarily but globally disable MarkPartial. Something similar to > "Enable Power Management" button available in expanded battery plasmoid. > > Martin Kostolný wrote: > One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to > be used (in KIO::file_copy(..) etc.) in various file managers. That way we > can delegate this settings to be picked up by file managers like krusader, > dolphin or other tools using KIO. > > David Faure wrote: > We can't delegate the setting to the app. All KIO-based apps use this, > not just file managers. If you save a document in calligra onto an FTP > server, kio_ftp is used, and needs to know whether to use MarkPartial. > > Not sure if I prefer the global option switched on/off temporarily, or > the precise per-host per-protocol setting. Maybe the VDG (visual design > group) has an opinion and/or other ideas... Sorry about this rookie question - what is the right procedure to present this problem to VDG? Is there such a group to add as reviewers or should I ask the question on a forum? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Úno. 24, 2016, 11:52 odp., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Úno. 24, 2016, 11:52 odp.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB,
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss this. > > My use-case is indeed the (one specific) remote SMB server has problems > with renaming and it breaks the upload. So I'd like to offer an option to > disable this otherwise very useful ".part" functionality. > > I agree that global-mark-partial-option is not a good idea but I think we > should come up with something. So here is my first proposal: I'm up for the > overblown configuration dialog which would be hidden behind "Avanced upload > options..." button placed in Connection Preferences. Here is one wireframe > (warning - very unfinished! I had little time...): > https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options > would be moved to mentioned configuration dialog as well (to their dedicated > tab). > > As I'm looking to the configuration dialog it is really overblown. Second > proposal: maybe we could use an entirelly different approach like a runtime > option to temporarily but globally disable MarkPartial. Something similar to > "Enable Power Management" button available in expanded battery plasmoid. > > Martin Kostolný wrote: > One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to > be used (in KIO::file_copy(..) etc.) in various file managers. That way we > can delegate this settings to be picked up by file managers like krusader, > dolphin or other tools using KIO. We can't delegate the setting to the app. All KIO-based apps use this, not just file managers. If you save a document in calligra onto an FTP server, kio_ftp is used, and needs to know whether to use MarkPartial. Not sure if I prefer the global option switched on/off temporarily, or the precise per-host per-protocol setting. Maybe the VDG (visual design group) has an opinion and/or other ideas... - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss this. > > My use-case is indeed the (one specific) remote SMB server has problems > with renaming and it breaks the upload. So I'd like to offer an option to > disable this otherwise very useful ".part" functionality. > > I agree that global-mark-partial-option is not a good idea but I think we > should come up with something. So here is my first proposal: I'm up for the > overblown configuration dialog which would be hidden behind "Avanced upload > options..." button placed in Connection Preferences. Here is one wireframe > (warning - very unfinished! I had little time...): > https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options > would be moved to mentioned configuration dialog as well (to their dedicated > tab). > > As I'm looking to the configuration dialog it is really overblown. Second > proposal: maybe we could use an entirelly different approach like a runtime > option to temporarily but globally disable MarkPartial. Something similar to > "Enable Power Management" button available in expanded battery plasmoid. One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to be used (in KIO::file_copy(..) etc.) in various file managers. That way we can delegate this settings to be picked up by file managers like krusader, dolphin or other tools using KIO. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an inconsistency which will lead to more bug reports down the line. > > Either we should just have the global option, or it should be per protocol. > > > > Can you tell me more about your use case for this option, so we can > > understand better the reason for all this? > > > > In general I find that .part is good, it 1) tells me that the file isn't > > ready to be used yet, 2) enables the resuming feature in case the > > connection drops. > > > > I can very well imagine that some servers disable renaming and then the > > feature breaks the upload in the first place. Is this is the issue here? > > But then it's not even per-protocol, it's per-protocol-and-host which > > might lead to an overblown configuration dialog. But the alternative is for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) Sorry for my late response. I agree with every word you said, David. :-) Thanks for taking your time to discuss this. My use-case is indeed the (one specific) remote SMB server has problems with renaming and it breaks the upload. So I'd like to offer an option to disable this otherwise very useful ".part" functionality. I agree that global-mark-partial-option is not a good idea but I think we should come up with something. So here is my first proposal: I'm up for the overblown configuration dialog which would be hidden behind "Avanced upload options..." button placed in Connection Preferences. Here is one wireframe (warning - very unfinished! I had little time...): https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options would be moved to mentioned configuration dialog as well (to their dedicated tab). As I'm looking to the configuration dialog it is really overblown. Second proposal: maybe we could use an entirelly different approach like a runtime option to temporarily but globally disable MarkPartial. Something similar to "Enable Power Management" button available in expanded battery plasmoid. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On March 2, 2016, 2:26 p.m., Marco Martin wrote: > > I find a bit baffling that an option is needed for this... You are not exactly suggesting a better solution, though. Options are not needed when we can make everything work magically out of the box. However FTP servers are not exactly under our control, so it's hard to make it all work magically. Reading directory permissions is unreliable, not all FTP servers run on Unix, so others emulate stuff (and there might be ACLs, which you don't see in ls -l). kio_ftp can't just test if the renaming will be allowed by trying to create a fake file and rename it, because then what? if it fails and the server doesn't allow deletion either, it made a mess that it can't clean up So yeah, a way for people to turn off resuming support so that basic upload actually works on permission-restricted servers makes sense. Look at the number of options in actual FTP clients BTW - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93075 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93075 --- I find a bit baffling that an option is needed for this... - Marco Martin On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- It seems weird to have a setting for FTP on one side, and a setting for "SMB and SFTP and any slave where this is implemented in the future". I understand that it was the path of least code changes, but I fear this creates an inconsistency which will lead to more bug reports down the line. Either we should just have the global option, or it should be per protocol. Can you tell me more about your use case for this option, so we can understand better the reason for all this? In general I find that .part is good, it 1) tells me that the file isn't ready to be used yet, 2) enables the resuming feature in case the connection drops. I can very well imagine that some servers disable renaming and then the feature breaks the upload in the first place. Is this is the issue here? But then it's not even per-protocol, it's per-protocol-and-host which might lead to an overblown configuration dialog. But the alternative is for the user to turn off some global setting (like the one you just added) and then (forget to) turn it back on. Right? :-) - David Faure On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
