Re: Review Request 127887: Improve usage of Qt APIs

2016-05-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/
---

(Updated May 23, 2016, 10:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

Submitted with commit c685fb5098e4e37bf3aae933a0ae09e0f798ffc5 by Aleix Pol to 
branch master.


Repository: knewstuff


Description
---

Mostly clazy fixes, few cleanups


Diffs
-

  src/core/installation.cpp 1887d0f 
  src/kmoretools/kmoretools.h 32da22c 
  src/kmoretools/kmoretools.cpp 8bd6751 
  src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
  src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
  src/kmoretools/kmoretoolspresets.cpp 679e849 
  src/staticxml/staticxmlprovider.cpp 541bf57 
  src/ui/itemsviewdelegate.cpp 7001be2 
  tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 

Diff: https://git.reviewboard.kde.org/r/127887/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-18 Thread Aleix Pol Gonzalez 


> On May 17, 2016, 10:46 p.m., Gregor Mi wrote:
> > src/core/installation.cpp, line 383
> > 
> >
> > I don't know if this does the same but also didn't test.

It uses QStandardPaths to actively look-up instead of taking a random first 
directory. This will return the `GenericDataLocation` directory named 
`targetDirectory` as requested.


> On May 17, 2016, 10:46 p.m., Gregor Mi wrote:
> > src/kmoretools/kmoretoolsconfigdialog_p.cpp, line 201
> > 
> >
> > I wonder why here "for" is better than Q_FOREACH.

Because notInstalledServices is not a Qt container and `foreach` doesn't deal 
well with them.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95561
---


On May 12, 2016, 1:01 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> ---
> 
> (Updated May 12, 2016, 1:01 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.h 32da22c 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-17 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95562
---



Looks fine to me. I opened two issues but these are just questions.

- Gregor Mi


On May 11, 2016, 11:01 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> ---
> 
> (Updated May 11, 2016, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.h 32da22c 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-17 Thread Gregor Mi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95561
---




src/core/installation.cpp (line 382)


I don't know if this does the same but also didn't test.



src/kmoretools/kmoretoolsconfigdialog_p.cpp (line 201)


I wonder why here "for" is better than Q_FOREACH.


- Gregor Mi


On May 11, 2016, 11:01 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> ---
> 
> (Updated May 11, 2016, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.h 32da22c 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-12 Thread Jeremy Whiting 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95428
---



The knewstuff (non moretools) side looks good to me.

- Jeremy Whiting


On May 11, 2016, 5:01 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> ---
> 
> (Updated May 11, 2016, 5:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.h 32da22c 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/
---

(Updated May 12, 2016, 1:01 a.m.)


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

Address most Kai issues.


Repository: knewstuff


Description
---

Mostly clazy fixes, few cleanups


Diffs (updated)
-

  src/core/installation.cpp 1887d0f 
  src/kmoretools/kmoretools.h 32da22c 
  src/kmoretools/kmoretools.cpp 8bd6751 
  src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
  src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
  src/kmoretools/kmoretoolspresets.cpp 679e849 
  src/staticxml/staticxmlprovider.cpp 541bf57 
  src/ui/itemsviewdelegate.cpp 7001be2 
  tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 

Diff: https://git.reviewboard.kde.org/r/127887/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-10 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95365
---




src/core/installation.cpp (line 382)


+ QLatin1Char('/')



src/kmoretools/kmoretools.cpp (line 51)


qDeleteAll?



src/kmoretools/kmoretoolsmenufactory.cpp (line 290)


Range-for? groupingNames is const



src/kmoretools/kmoretoolspresets.cpp (lines 153 - 154)


constFind


- Kai Uwe Broulik


On Mai 10, 2016, 1:37 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> ---
> 
> (Updated Mai 10, 2016, 1:37 nachm.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127887: Improve usage of Qt APIs

2016-05-10 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Mostly clazy fixes, few cleanups


Diffs
-

  src/core/installation.cpp 1887d0f 
  src/kmoretools/kmoretools.cpp 8bd6751 
  src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
  src/kmoretools/kmoretoolspresets.cpp 679e849 
  src/staticxml/staticxmlprovider.cpp 541bf57 
  src/ui/itemsviewdelegate.cpp 7001be2 
  tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 

Diff: https://git.reviewboard.kde.org/r/127887/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel