Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review100195 --- So is this commited and should this be closed? or? - Albert Astals Cid On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > >
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
> On Aug. 13, 2014, 8:58 a.m., David Faure wrote: > > src/kcms/webshortcuts/main.cpp, line 112 > > <https://git.reviewboard.kde.org/r/119280/diff/2/?file=290236#file290236line112> > > > > The indentation seems wrong. Can you run astyle-kdelibs on the whole > > thing? It will also remove these pesky spaces inside parentheses. http://commits.kde.org/kio/55d5a1d8b9786ee381353ea99a5c7415bb83b50f > On Aug. 13, 2014, 8:58 a.m., David Faure wrote: > > src/kcms/webshortcuts/main.cpp, line 52 > > <https://git.reviewboard.kde.org/r/119280/diff/2/?file=290236#file290236line52> > > > > Maybe it's time to update this example, altavista is gone... http://commits.kde.org/kio/7aae5264711c79576ecfc96034dafa5fd0fc04df > On Aug. 13, 2014, 8:58 a.m., David Faure wrote: > > src/kcms/webshortcuts/main.cpp, line 54 > > <https://git.reviewboard.kde.org/r/119280/diff/2/?file=290236#file290236line54> > > > > (the word 'shortcut' is used twice for two different things here... > > prepend "keyboard" before the first one?) http://commits.kde.org/kio/7aae5264711c79576ecfc96034dafa5fd0fc04df - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review64436 --- On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
> On Aug. 13, 2014, 8:58 a.m., David Faure wrote: > > So I just realized I screwed up last week-ish and actually pushed this into kio.git already when I pushed the KFPG/KAVA fixes -- I didn't realize I had this on the same branch. I'll do the fixes asked for below and reply with the commit hashes. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review64436 --- On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review64436 --- src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45020> Maybe it's time to update this example, altavista is gone... src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45021> (the word 'shortcut' is used twice for two different things here... prepend "keyboard" before the first one?) src/kcms/webshortcuts/main.cpp <https://git.reviewboard.kde.org/r/119280/#comment45019> The indentation seems wrong. Can you run astyle-kdelibs on the whole thing? It will also remove these pesky spaces inside parentheses. - David Faure On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
> On July 15, 2014, 6:27 a.m., Kevin Ottens wrote: > > Note that as mentioned in the "Web Shortcuts KCM" thread, I'm very much not > > in favor of such a code move. kde-frameworks-devel ended up discussing this extensively and in the end things seemed to settle on "it's a go" -- David, can I get a ship it? - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62372 --- On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
> On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote: > > The code is GPLv2+ - is that allowed in frameworks? > > Jonathan Riddell wrote: > Yes. From licence policy: "Source files that are part of a library with > a public API which is part of the KDE Platform" but a kcm isn't part of a > public API And it seems there are other GPL'd KCMs in kio already (as pointed out by Riddell). - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62370 --- On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
> On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote: > > The code is GPLv2+ - is that allowed in frameworks? Yes. From licence policy: "Source files that are part of a library with a public API which is part of the KDE Platform" but a kcm isn't part of a public API - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62370 --- On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 08/11/2014 09:45 AM, David Faure wrote: In any case you could ask the contributors for relicensing, before you spend a lot of time rewriting it (you "can", but it's such a waste - and a risk for regressions / missing features) I'll try to track them down. Maybe Riddell can help me actually, he has experience with this sort of thing ... AFAIUI we do need it for plugin loading, yeah ... Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday 06 August 2014 08:58:07 Eike Hein wrote: > On 08/04/2014 10:09 AM, David Faure wrote: > > So yep, that's not going away any time soon ;) > > Alright, so that leaves the licensing problem, right? Do I > need to rewrite the KCM? Can I even? Do we contact Yves > Arrouye for relicensing? I seem to have missed something. What's the licensing problem exactly? The fact that the KCM is GPL? But if it's launched via kcmshell5 that should be fine, no? Not sure about the case where it's dynamically loaded by the app process though. In any case you could ask the contributors for relicensing, before you spend a lot of time rewriting it (you "can", but it's such a waste - and a risk for regressions / missing features) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 08/04/2014 10:09 AM, David Faure wrote: So yep, that's not going away any time soon ;) Alright, so that leaves the licensing problem, right? Do I need to rewrite the KCM? Can I even? Do we contact Yves Arrouye for relicensing? Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Saturday 02 August 2014 12:48:43 Kevin Ottens wrote: > On Saturday 02 August 2014 11:50:17 David Faure wrote: > > Then let's go more "bare bones" in frameworks that can't afford the > > KConfigWidgets dependency, but let's provide the more convenient and more > > usable "out of the box" solution in frameworks that can provide it, such > > as > > KIO? > > Well, if you see no problem in growing your dependency on KConfigWidgets > sure. You're maintaining KIO after all. In fact there are already two KCMs in KIO, inside src/urifilters/ikws/ given that the API for uri filters includes a virtual KCModule *configModule(...) So yep, that's not going away any time soon ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Saturday 02 August 2014 11:50:17 David Faure wrote: > Then let's go more "bare bones" in frameworks that can't afford the > KConfigWidgets dependency, but let's provide the more convenient and more > usable "out of the box" solution in frameworks that can provide it, such as > KIO? Well, if you see no problem in growing your dependency on KConfigWidgets sure. You're maintaining KIO after all. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday 16 July 2014 21:12:25 Kevin Krammer wrote: > On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlying platform for the other ones). > > > > I don't want users to have to configure their search engines in 10 KDE > > apps > > one after the other by hand. > > A centralized configuration is much more convenient. > > Hmm, what if KDE applications outside a KDE workspace are seen as separate > entities by users of those other workspaces? Then they will not have configurable web-shortcuts, or if we really want that, we need a widget for doing so, but not if it means making things more difficult for the "regular KDE workspace user". I.e. the app-specific configuration should sit on top of the global configuration, so that KDE-worskpace users can set things globally and standalone-app users can set things from within the app. This is the "solution that makes everyone happy" by making things over- configurable. The alternative, web shortcuts not being configurable unless you use a KDE workspace, is IMHO valid too. But worsening the experience for our primary target audience in order to possibly improve the experience of our secondary target audience is IMHO a bad move. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Friday 18 July 2014 00:37:02 Kevin Ottens wrote: > On Thursday 17 July 2014 10:37:45 David Faure wrote: > > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > > (ie at most a > > > > > > > > > > widget would be enough for the app related settings, we should talk > > > > > to > > > > > the > > > > > underlying platform for the other ones). > > > > > > > > I don't want users to have to configure their search engines in 10 KDE > > > > apps > > > > one after the other by hand. > > > > A centralized configuration is much more convenient. > > > > > > Maybe I was unclear, but I didn't mean to imply that for something like > > > the > > > web shortcuts having a centralized configuration was wrong. I think that > > > shipping a KCM is wrong. But I'm fine with a widget which provide mean > > > to > > > save in a centralized configuration. > > > > OK, then what is the difference with making that widget inherit from > > KCModule so that it's also available in systemsettings - as long as the > > applications also show that KCModule directly in the application, like > > konqueror does when you use "Configure Konqueror" ? > > In the general case, as a potential pattern (I'm not thinking KIO only) it'd > mean bringing a dependency on KConfigWidgets. > In the case of KIO it's less of a concern since the dependency is already > there. But it means bringing dependencies on the auth system and > KCMModuleProxy, on the buttons, on about data, on KConfigDialogManager. To > me it shouts forcing all that on user code even when not needed. Then let's go more "bare bones" in frameworks that can't afford the KConfigWidgets dependency, but let's provide the more convenient and more usable "out of the box" solution in frameworks that can provide it, such as KIO? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
Can you two give me a decision on this? Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Friday 18 July 2014 00:37:02 Kevin Ottens wrote: > On Thursday 17 July 2014 10:37:45 David Faure wrote: > > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > > (ie at most a > > > > > > > > > > widget would be enough for the app related settings, we should talk > > > > > to > > > > > the > > > > > underlying platform for the other ones). > > > > > > > > I don't want users to have to configure their search engines in 10 KDE > > > > apps > > > > one after the other by hand. > > > > A centralized configuration is much more convenient. > > > > > > Maybe I was unclear, but I didn't mean to imply that for something like > > > the > > > web shortcuts having a centralized configuration was wrong. I think that > > > shipping a KCM is wrong. But I'm fine with a widget which provide mean > > > to > > > save in a centralized configuration. > > > > OK, then what is the difference with making that widget inherit from > > KCModule so that it's also available in systemsettings - as long as the > > applications also show that KCModule directly in the application, like > > konqueror does when you use "Configure Konqueror" ? > > In the general case, as a potential pattern (I'm not thinking KIO only) it'd > mean bringing a dependency on KConfigWidgets. > In the case of KIO it's less of a concern since the dependency is already > there. But it means bringing dependencies on the auth system and > KCMModuleProxy, on the buttons, on about data, on KConfigDialogManager. To > me it shouts forcing all that on user code even when not needed. And of course I forgot the big issue of adding a plugin vs adding a class to a librarie. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Thursday 17 July 2014 10:37:45 David Faure wrote: > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > (ie at most a > > > > > > > > widget would be enough for the app related settings, we should talk to > > > > the > > > > underlying platform for the other ones). > > > > > > I don't want users to have to configure their search engines in 10 KDE > > > apps > > > one after the other by hand. > > > A centralized configuration is much more convenient. > > > > Maybe I was unclear, but I didn't mean to imply that for something like > > the > > web shortcuts having a centralized configuration was wrong. I think that > > shipping a KCM is wrong. But I'm fine with a widget which provide mean to > > save in a centralized configuration. > > OK, then what is the difference with making that widget inherit from > KCModule so that it's also available in systemsettings - as long as the > applications also show that KCModule directly in the application, like > konqueror does when you use "Configure Konqueror" ? In the general case, as a potential pattern (I'm not thinking KIO only) it'd mean bringing a dependency on KConfigWidgets. In the case of KIO it's less of a concern since the dependency is already there. But it means bringing dependencies on the auth system and KCMModuleProxy, on the buttons, on about data, on KConfigDialogManager. To me it shouts forcing all that on user code even when not needed. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlying platform for the other ones). > > > > I don't want users to have to configure their search engines in 10 KDE > > apps > > one after the other by hand. > > A centralized configuration is much more convenient. > > Maybe I was unclear, but I didn't mean to imply that for something like the > web shortcuts having a centralized configuration was wrong. I think that > shipping a KCM is wrong. But I'm fine with a widget which provide mean to > save in a centralized configuration. OK, then what is the difference with making that widget inherit from KCModule so that it's also available in systemsettings - as long as the applications also show that KCModule directly in the application, like konqueror does when you use "Configure Konqueror" ? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 07/16/2014 10:08 PM, Kevin Ottens wrote: My opinion is that for the time being it should be shipped by the workspace. Once the widget I mentioned in that thread would be available then the KCM could be ported to use it, and Konversation would be able to use said widget directly. I'd like to hear back from David before considering resubmitting to workspace. Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Tuesday 15 July 2014 16:59:29 Eike Hein wrote: > On 07/15/2014 03:16 PM, Kevin Ottens wrote: > > Well, for a single entry menu, really? :-) > > Yeah, I do care about every single menu entry not being broken, no > matter where users use my app :). Sorry, I was unclear there. I meant having to deal with a single menu entry to kick out if running outside of a plasma session. > Of course admittedly the situation in KDE 4 wasn't good either since it > actually meant a runtime dep on kde-baseapps. Indeed. > I'm OK with spawning our own dialog and using a widget class, but > I don't have time to work on that personally (I'm busy with Plasma > and Konversation). > > This is a roadblock to keeping feature continuity in KF5 releases, > so we do need to ship the KCM for now. > > Let me know where you guys want it put in the end. My opinion is that for the time being it should be shipped by the workspace. Once the widget I mentioned in that thread would be available then the KCM could be ported to use it, and Konversation would be able to use said widget directly. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday 16 July 2014 10:33:43 David Faure wrote: > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > (ie at most a > > > > widget would be enough for the app related settings, we should talk to the > > underlying platform for the other ones). > > I don't want users to have to configure their search engines in 10 KDE apps > one after the other by hand. > A centralized configuration is much more convenient. Maybe I was unclear, but I didn't mean to imply that for something like the web shortcuts having a centralized configuration was wrong. I think that shipping a KCM is wrong. But I'm fine with a widget which provide mean to save in a centralized configuration. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday 16 July 2014 21:12:25 Kevin Krammer wrote: > On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlying platform for the other ones). > > > > I don't want users to have to configure their search engines in 10 KDE > > apps > > one after the other by hand. > > A centralized configuration is much more convenient. > > Hmm, what if KDE applications outside a KDE workspace are seen as separate > entities by users of those other workspaces? Exactly... They definitely are in such a case. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > (ie at most a > > > > widget would be enough for the app related settings, we should talk to the > > underlying platform for the other ones). > > I don't want users to have to configure their search engines in 10 KDE apps > one after the other by hand. > A centralized configuration is much more convenient. Hmm, what if KDE applications outside a KDE workspace are seen as separate entities by users of those other workspaces? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > (ie at most a > widget would be enough for the app related settings, we should talk to the > underlying platform for the other ones). I don't want users to have to configure their search engines in 10 KDE apps one after the other by hand. A centralized configuration is much more convenient. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 07/15/2014 03:16 PM, Kevin Ottens wrote: Well, for a single entry menu, really? :-) Yeah, I do care about every single menu entry not being broken, no matter where users use my app :). Of course admittedly the situ- ation in KDE 4 wasn't good either since it actually meant a runtime dep on kde-baseapps. I'm OK with spawning our own dialog and using a widget class, but I don't have time to work on that personally (I'm busy with Plasma and Konversation). This is a roadblock to keeping feature continuity in KF5 releases, so we do need to ship the KCM for now. Let me know where you guys want it put in the end. Regards. Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Tuesday 15 July 2014 14:59:43 Eike Hein wrote: > On 07/15/2014 10:24 AM, Kevin Ottens wrote: > > Which applications? I experience that mostly in krunner and the browsers. > > As a user I don't think I get to type those anywhere else. > > It's not just typing. Konversation, Okular and Konsole let you > select text, right-click it and search it using one of your pre- > ferred Web Shortcuts. You can also see the KCM entry point there: > > http://wstaw.org/m/2014/07/15/webshortcuts.png Ah I see. Never ever used that for some reason. :-) > And yes, we do care about having this work outside the KDE work- > space, if only because it'd be annoying to keep track of "users > cannot configure this anyway, find a way to figure out if we're > in KDE or not and hide this at runtime if not". It makes app > code more complex. Well, for a single entry menu, really? :-) Anyway, I think the rest of my previous email still stands (ie at most a widget would be enough for the app related settings, we should talk to the underlying platform for the other ones). Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 07/15/2014 10:24 AM, Kevin Ottens wrote: Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. It's not just typing. Konversation, Okular and Konsole let you select text, right-click it and search it using one of your pre- ferred Web Shortcuts. You can also see the KCM entry point there: http://wstaw.org/m/2014/07/15/webshortcuts.png And yes, we do care about having this work outside the KDE work- space, if only because it'd be annoying to keep track of "users cannot configure this anyway, find a way to figure out if we're in KDE or not and hide this at runtime if not". It makes app code more complex. Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
Hello, On Tuesday 15 July 2014 10:01:50 David Faure wrote: > On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > > Honestly to me it looks like a wrong move. A better move would be to have > > the framework (e.g. KIO) read the settings from the platform for its > > settings (e.g. proxies). > > OK about proxies, but web shortcuts is a KIO-specific thing, you won't find > any platform settings for these. > > I see nothing workspace-related or platform-related in web shortcuts. > You type "gg:foo" in a KDE app, Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. > you get a google search - this requires a GUI for configuration, and I can't > see why that configuration should be only available in a plasma workspace or > on Unix. I have to admit I would have no problem having this kind of "extra" only controllable in our own workspace. I mean, it makes only a difference for end users, and I've no problem pointing them to our workspace if they want to get it in full. > Nor do we want to see each one of the 10 apps that support web shortcuts to > have to come up with their own GUI for configuring this At the same time they don't need a full fledged KCM either. A pre-made piece of GUI they can hook up is a much leaner answer to the problem which won't mandate a lot of dependencies. That could just be a widget in kio/widgets for instance. Then it would be usable by our browser and the workspace KCM. As I mentioned in the thread, some of those settings we're struggling with should be: - either application settings for with a widget can be more than enough (e.g. web shortcuts), I'm not even sure we want a widget in every cases (if considered power user could be just in the files with no pre-made GUI); - or workspace settings for which the frameworks should read them from the platform instead of by-passing them (e.g. proxies). In any case that doesn't ask for a KCM in a framework IMO. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > Honestly to me it looks like a wrong move. A better move would be to have > the framework (e.g. KIO) read the settings from the platform for its > settings (e.g. proxies). OK about proxies, but web shortcuts is a KIO-specific thing, you won't find any platform settings for these. I see nothing workspace-related or platform-related in web shortcuts. You type "gg:foo" in a KDE app, you get a google search - this requires a GUI for configuration, and I can't see why that configuration should be only available in a plasma workspace or on Unix. Nor do we want to see each one of the 10 apps that support web shortcuts to have to come up with their own GUI for configuring this -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62372 --- Note that as mentioned in the "Web Shortcuts KCM" thread, I'm very much not in favor of such a code move. - Kevin Ottens On July 14, 2014, 8:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Monday 14 July 2014 13:15:32 John Layt wrote: > Over on the Windows list we've been discussing about KCM's for > configuring common services/frameworks like this when running apps > under non-Plasma desktops, including Gnome, Windows, Mac, etc. > General gist is that we don't want to have systemsettings installed in > non-Plasma platforms to gain access to them, so they need to be > accessed through the apps config dialog or help menu instead. This > implies a few things: > > 1) That the KCM's are located somewhere easily packaged for > stand-alone app installers to include > 2) That an app can figure out what KCM's it needs access to when > running non-native > 3) That at runtime the app can detect it is running in non-native mode > and find and load the required external KCMs that it needs > [...] > Thoughts? Or maybe it is that an application which depends on such a KCM to be present to be configured is not portable? After all, it is a sign of a direct dependency on a low level setting from the application. Maybe that's fine, maybe not all applications are meant to run outside of a Plasma workspace. What's not fine IMO is to turn a framework into a bit of workspace with UI to workaround that. From what I kept above, I got that feeling that we end up in that situation mainly because: we got some settings which should be application settings but end up appearing in systemsettings instead and we got applications/frameworks reading settings from our low level settings unconditionally while they should read from the platform settings instead (Plasma being one among several). Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
Hello, On Monday 14 July 2014 12:46:15 David Faure wrote: > On Monday 14 July 2014 12:34:44 Eike Hein wrote: > > I'd like to port the ebrowsing KCM and move it to > > plasma-desktop or -workspace, since it has plenty > > of users outside of Konq (e.g. Konvi, Konsole and > > Okular, the first two of which have ports now). > > > > Thoughts? > > The whole split between workspace and applications seems to generate more > issues than we thought. we're going to miss a place for shared runtime > deps. > > If someone uses konvi, konsole, okular, or konqueror outside of plasma- > workspace, (e.g. in gnome, Mac or Windows), then they are not going to be > able to configure cookies, internet keywords, useragent, proxies . if > these things are part of the workspace. And as such shall be configured in the workspace no? I mean... cookies, proxies and so on, that looks wrong if they are configured by some runtime bits provided by a framework knowing the platforms have such settings. I also kills all hopes to see something like KIO have a lower tier for instance. > Given that the kurifilter plugins themselves are in KIO for this same > reason, maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs > should go into KIO as well? Honestly to me it looks like a wrong move. A better move would be to have the framework (e.g. KIO) read the settings from the platform for its settings (e.g. proxies). We ought to treat our workspaces like one of the platforms our frameworks can be used with, not try to bring workspace bits in our frameworks. That would go counter to our initial goals. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62370 --- The code is GPLv2+ - is that allowed in frameworks? - Martin Gräßlin On July 14, 2014, 10:36 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 10:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it > configures resides as well. This makes more sense than stuffing it into > workspace, since Web Shortcuts have many app level downstreams (e.g. > Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and > may not be running inside Plasma Desktop at the time. > > I've lightly modified the code to make it build, and made the naming more > consistent - "webshortcuts" is now used throughout where previously was a mix > of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only > contains a single string. More importantly it means apps calling the KCM via > kcmshell5 need to be changed to use the new name - I promise to take care of > that. > > I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN > redefinition, so I'd be happy for review. > > Note the categorization is already what the recategorization effort > proscribed for this KCM. > > > Diffs > - > > src/CMakeLists.txt 6f8373f > src/kcms/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION > src/kcms/webshortcuts/Messages.sh PRE-CREATION > src/kcms/webshortcuts/main.h PRE-CREATION > src/kcms/webshortcuts/main.cpp PRE-CREATION > src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION > src/urifilters/ikws/CMakeLists.txt 4efe24e > > Diff: https://git.reviewboard.kde.org/r/119280/diff/ > > > Testing > --- > > > Thanks, > > Eike Hein > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ --- (Updated July 14, 2014, 8:36 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Sorry for the spam :/. This update also gets rid of the nebulous "enhanced browsing" in the kcmshell5 title for the KCM. Repository: kio Description --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time. I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only contains a single string. More importantly it means apps calling the KCM via kcmshell5 need to be changed to use the new name - I promise to take care of that. I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review. Note the categorization is already what the recategorization effort proscribed for this KCM. Diffs (updated) - src/CMakeLists.txt 6f8373f src/kcms/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/Messages.sh PRE-CREATION src/kcms/webshortcuts/main.h PRE-CREATION src/kcms/webshortcuts/main.cpp PRE-CREATION src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION src/urifilters/ikws/CMakeLists.txt 4efe24e Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ --- (Updated July 14, 2014, 8:30 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Clarify rename implications. Repository: kio Description (updated) --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time. I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only contains a single string. More importantly it means apps calling the KCM via kcmshell5 need to be changed to use the new name - I promise to take care of that. I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review. Note the categorization is already what the recategorization effort proscribed for this KCM. Diffs - src/kcms/webshortcuts/main.cpp PRE-CREATION src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION src/urifilters/ikws/CMakeLists.txt 4efe24e src/CMakeLists.txt 6f8373f src/kcms/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/Messages.sh PRE-CREATION src/kcms/webshortcuts/main.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ --- (Updated July 14, 2014, 8:22 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Added note on categorization. Repository: kio Description (updated) --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time. I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This does also mean the .po name changed, but the KCM only contains a single string. I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review. Note the categorization is already what the recategorization effort proscribed for this KCM. Diffs - src/kcms/webshortcuts/main.cpp PRE-CREATION src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION src/urifilters/ikws/CMakeLists.txt 4efe24e src/CMakeLists.txt 6f8373f src/kcms/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/Messages.sh PRE-CREATION src/kcms/webshortcuts/main.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ --- (Updated July 14, 2014, 8:20 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Oops, used wrong group. Repository: kio Description --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time. I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This does also mean the .po name changed, but the KCM only contains a single string. I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review. Diffs - src/kcms/webshortcuts/main.cpp PRE-CREATION src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION src/urifilters/ikws/CMakeLists.txt 4efe24e src/CMakeLists.txt 6f8373f src/kcms/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION src/kcms/webshortcuts/Messages.sh PRE-CREATION src/kcms/webshortcuts/main.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing --- Thanks, Eike Hein ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 14 July 2014 11:46, David Faure wrote: > On Monday 14 July 2014 12:34:44 Eike Hein wrote: >> Hi David, >> >> I'd like to port the ebrowsing KCM and move it to >> plasma-desktop or -workspace, since it has plenty >> of users outside of Konq (e.g. Konvi, Konsole and >> Okular, the first two of which have ports now). >> >> Thoughts? > > The whole split between workspace and applications seems to generate more > issues than we thought. we're going to miss a place for shared runtime > deps. > > If someone uses konvi, konsole, okular, or konqueror outside of plasma- > workspace, (e.g. in gnome, Mac or Windows), then they are not going to be able > to configure cookies, internet keywords, useragent, proxies . if these > things are part of the workspace. > > Given that the kurifilter plugins themselves are in KIO for this same reason, > maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs should go > into KIO as well? Over on the Windows list we've been discussing about KCM's for configuring common services/frameworks like this when running apps under non-Plasma desktops, including Gnome, Windows, Mac, etc. General gist is that we don't want to have systemsettings installed in non-Plasma platforms to gain access to them, so they need to be accessed through the apps config dialog or help menu instead. This implies a few things: 1) That the KCM's are located somewhere easily packaged for stand-alone app installers to include 2) That an app can figure out what KCM's it needs access to when running non-native 3) That at runtime the app can detect it is running in non-native mode and find and load the required external KCMs that it needs Preferably this would all be as automated as possible. The obvious place for the KCM's to live would be in the Framework that they configure, but we have to think how that would affect the dependency tree. Tier 1 is fine, as it can't use KConfig anyway (but how then do they handle config, if any need to?). Tier 3 is fine, as it can depend on KConfigWidgets/KCMUtils, albeit at the cost of a more complicated dependency diagram. Tier 2 could be an issue, as it cannot depend on KConfigWidgets/KCMUtils. For those we'd need separate repos (yet more repos?) or one shared repo (at the expense of more dependencies and installing extra stuff you may not need for your app), or perhaps a configure flag that enables building the KCM if you need it (a disable flag may be a good idea at Tier 3?). Thoughts? John. P.S. This and other cross-platform issues that need work are listed at https://community.kde.org/KDE_Applications/Cross_Platform_Issues ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On 07/14/2014 12:46 PM, David Faure wrote: Given that the kurifilter plugins themselves are in KIO for this same reason, maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs should go into KIO as well? Sorry, I missed this because it got filtered into k-f-d due to the CC :). I had already written David a follow-up mail by that time to suggest putting the KCM into KIO (as also suggested by #plasma), so it seems we're all in agreement. I'll be doing the port and throwing it at RB. Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Web Shortcuts KCM
On Monday 14 July 2014 12:34:44 Eike Hein wrote: > Hi David, > > I'd like to port the ebrowsing KCM and move it to > plasma-desktop or -workspace, since it has plenty > of users outside of Konq (e.g. Konvi, Konsole and > Okular, the first two of which have ports now). > > Thoughts? The whole split between workspace and applications seems to generate more issues than we thought. we're going to miss a place for shared runtime deps. If someone uses konvi, konsole, okular, or konqueror outside of plasma- workspace, (e.g. in gnome, Mac or Windows), then they are not going to be able to configure cookies, internet keywords, useragent, proxies . if these things are part of the workspace. Given that the kurifilter plugins themselves are in KIO for this same reason, maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs should go into KIO as well? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
