D25340: Added background colors to active and inactive icon view

[Filip Fila]

filipf added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  A similar issue still exists, but it does apply against master.
  
  Gave this is a quick spin and it definitely looks like an improvement.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf added a comment.


  In D25699#573713 , @fvogt wrote:
  
  > The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  >
  > The labels are visible again with just the `control.flat` condition, but 
the prefix one might be needed as well for non-breeze themes.
  >
  > There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(
  
  
  Thanks for looking into the patch.
  
  Yeah, the triangle seems to be missing :/ possibly because PC2 has a menu 
property and PC3 doesn't... I will investigate further.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Filip Fila]

filipf added a comment.


  I think this is useful. Every once in a while we get opinionated people who 
think light separators are awful in the Breeze Dark scheme (I would hate dark 
ones on the other hand) or even some ricer people who want to turn off 
separators (which they could do now by matching it with window color I guess).
  
  Implementation-wise there definitely always needs to be a fallback value so 
we don't break third-party color-schemes.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25820: SimpleScreenRecorder icon added

[Filip Fila]

filipf added a comment.


  I agree, I think brighter and slightly less saturated colors would look nice.
  
  Thank you for adding this btw, the old icon doesn't fit in.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: filipf, ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf added subscribers: davidedmundson, mart.
filipf added a comment.


  Yeah, PC2 ToolButton has this so it loads the arrow: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110
  
  For PC3 I guess we would have to hack it in in the sddm-theme code...
  
  @mart and @davidedmundson are there plans for PC3 to have a menu property 
like PC2?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25822: Add manual test for changing colorscope in components

[Filip Fila]

filipf added a comment.


  Thanks! It will be easier to test now.
  
  I noticed some issues with certain tests, although most seem to have already 
existed:
  
  - busyindicator3.qml -> loads, but complains about a binding loop detected 
for `implicitHeight`
  - button3.qml -> doesn't load, says `Label` is not a type
  - checkbox3.qml -> doesn't load, says `Label `is not a type
  - **combobox.qml -> doesn't load, says it cannot assign object to list 
property `children` **
  - **progressbar.qml -> loads but complains that `root` is not defined **
  - **progressbar3.qml -> loads but complains that `barSvg` is not defined**
  - **radiobutton.qml -> doesn't load, say it expects token `,` at line 9**
  - radiobutton3.qml -> doesn't load, says `Label` is not a type
  
  The ones in bold seem to be related to this patch, but I can fix all of this 
in a separate patch after this one.

INLINE COMMENTS

> radiobutton.qml:8
> +ComponentBase {
>  {
>  Grid {

Two curly braces.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25822: Add manual test for changing colorscope in components

[Filip Fila]

filipf added a comment.


  In D25822#574271 , @ngraham wrote:
  
  > Nice. Does this fix or obsolete D25699 ?
  
  
  No, this just for easier testing of all the components with the complementary 
theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25822: Add manual test for changing colorscope in components

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Thanks again :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Filip Fila]

filipf added a comment.


  In D25814#574389 , @ngraham wrote:
  
  > In D25814#574380 , @ndavis wrote:
  >
  > > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as 
many icons as we do. F7806761: Screenshot_20191209_155912.png 

  >
  >
  > To me, this image really shows how good the dark separators look. I don't 
think the fact that our UIs are more icon-heavy is a significant factor here. 
Unlike GNOME, we tend to use ToolButtons, which have no outline until hovered 
over. So in fact there are probably fewer lines with the separator color in our 
Toolbutton-heavy UIs compared to GNOME.
  
  
  Already asked in VDG, but repeating here: how would we handle dark separators 
on really dark color schemes?
  
  This is the most downloaded color scheme and it won't work well with dark 
separators: https://store.kde.org/p/1294011/

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the summary of this revision.
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into 
account complementary color schemes (authored by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25699?vs=70789&id=71268

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf added a comment.


  Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf added a comment.


  In D25699#576444 , @fvogt wrote:
  
  > This fixed the button label, but the menu itself is unsuable due to a black 
text on dark background: 
https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21
  
  
  We've had several bugs due to the QQC2 and PC3 port and with the (LTS) 
release date being closer, we've reverted that port for now.
  
  We'll have to figure this out at some point in the future though.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25926

To: davidedmundson, #plasma, filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25927: [PC3] Complete plasma progress bar animation

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25927

To: davidedmundson, filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

[Filip Fila]

filipf added a dependent revision: D25785: [Plasma Style KCM] Add a color-wheel 
sign denoting the theme supports the system color scheme.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

[Filip Fila]

filipf added a comment.


  Thanks, I'll tweak my patch to use this.
  
  Does the implementation increase the horizontal spacing between delegates 
even if there are no subtitles present?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

[Filip Fila]

filipf added a comment.


  In D25999#577780 , @ngraham wrote:
  
  > It does, because we can't know in advance whether or not any delegates will 
set a subtitle. Actually... can we know this?
  
  
  Yeah if we could it wouldn't be bad to add a condition.
  
  Although honestly after testing this live I don't really mind the added 
padding from a visual POV.
  
  There's a content overflow problem in the colors KCM now though:
  
  F7818412: image.png 
  
  It's only related to the change in GridViewInternal.qml.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

[Filip Fila]

filipf added a comment.


  ^ No, it seems to be GridDelegate actually.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:35351ba3f299: Update breeze theme shadows (authored by 
niccolove, committed by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=74153&id=74206

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Filip Fila]

filipf added a comment.


  I really like this all in all, and the light version looks ready to go.
  
  The transparency in the dark one if fine IMO, it's just that the Breeze Dark 
color scheme should be somewhat darker and then the Plasma theme would also be 
darker.
  
  What's more important is we try to blend in the panel with the popup like in 
the light version.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove
Cc: filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ndavis, 
ZrenBot, firef, bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Filip Fila]

filipf added a comment.


  Arcpatched and compiled and I was getting an overly transparent Breeze Dark:
  
  F8094138: image.png 
  
  It was only when I turned Contrast Effect off and then on again that I was 
seeing what's in the test plan.
  
  We should still investigate this because I also reproduced it in a different 
install.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Filip Fila]

filipf added a comment.


  Right, I also noticed the color-aware theme now has somewhat more pronounced 
discrepancy between the panel and the popups when dark color schemes are used.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27299: Vertically center tooltip icon/image

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns