Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Wednesday 20 August 2008 08:53:52 pm David Johnson wrote: On Saturday 16 August 2008 03:20:41 pm David Schultz wrote: I looked at the kcalc source, and the whole thing is so broken that you are better off just turning off HAVE_L_FUNCS regardless of anything. KCalc casts the input and output of each libm function it calls to double precision even if it's calling the long double version. This means that it actually achieves *worse* accuracy by using the long double functions, due to rounding twice. I'm going to *try* to get that stuff out of kcalc. It may take a while however. Hmmm, it's not going to be as hard as I thought. There's not much that uses that macro, and many of the defines dependent on it aren't even being used. -- David Johnson ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks Daniel patch works. - - Martin - -- +---+---+ | PGP: 0x05682353 | Jabber : miwi(at)BSDCrew.de | | ICQ: 169139903 | Mail : miwi(at)FreeBSD.org | +---+---+ | Mess with the Best, Die like the Rest! | +---+---+ -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkimoXYACgkQFwpycAVoI1MTFQCgkm2n1U/vmV3UScFwyTSKux6C R38AoI7m4D7sxlyRyfCXK3ghrHi2bIuf =NRjE -END PGP SIGNATURE- ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
[ Some history for das... Additions of some (and not all) long functions have been breaking ports that just perform cursory checks for a couple of long functions and then think they have access to them all. ] On Sat, 16 Aug 2008, Martin Wilke wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks Daniel patch works. No problem. I wish there was an easier way to check for all the needed functions. In a perfect world, I suppose kdeutils would check for all the long functions instead of just for asinl() and sqrtl(), but that seems kind of tedious. Unfortunately, we (FreeBSD) are implementing these functions piecemeal instead of getting them all at once. When we do get the full set of these long functions, I guess we'll have to come back and revisit this patch again. It might be interesting to see how kdeutils handles this in KDE4 - does the same problem exist there? -- DE ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Sat, Aug 16, 2008, Daniel Eischen wrote: [ Some history for das... Additions of some (and not all) long functions have been breaking ports that just perform cursory checks for a couple of long functions and then think they have access to them all. ] KDE is wrong to do this, but I understand that this is a problem nevertheless. The problem actually used to be worse back when gcc would sporadically supply built-in versions of functions we didn't have. If there are particular missing functions whose implementation would fix many ports, I'd be happy to see what I can do. I could also suggest dummy implementations of some of the functions that could be put in a shim, and would be good enough to fool most applications but not good enough to commit to libm. Just let me know what's needed. Unfortunately, I may not be able to do much in the short term. I'm flying to Toronto tomorrow, and I will be out of town for the next two weeks, and likely busy after that. The last time this issue was brought to my attention, the problem port was also a part of KDE, by the way. It might be a good idea to talk to the KDE developers about it so they don't keep replicating the same mistake. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Saturday 16 August 2008, David Schultz wrote: On Sat, Aug 16, 2008, Daniel Eischen wrote: Additions of some (and not all) long functions have been breaking ports that just perform cursory checks for a couple of long functions and then think they have access to them all. The last time this issue was brought to my attention, the problem port was also a part of KDE, by the way. It might be a good idea to talk to the KDE developers about it so they don't keep replicating the same mistake. Agreed. The checks have traditionally assumed the presence of all the functions in a family of *l-suffixed ones. Whenever I've noticed, I've added checks upstream. Please do submit a bug report at bugs.kde.org with the OS set to FreeBSD - I check those periodically and clean up / fix up what's needed. -- These are your friends - Adem GPG: FEA2 A3FE Adriaan de Groot signature.asc Description: This is a digitally signed message part. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Mon, 2 Jun 2008 21:40:53 -0400 (EDT), Daniel Eischen wrote: On Mon, 2 Jun 2008, John Baldwin wrote: Perhaps by recent libm changes that trick autoconf into think we implement an entire batch of floating point ops when we only do a subset: /bin/sh /usr/local/bin/libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I.. -I./knumber -D_ISOC99_SOURCE -I/usr/local/include -I/usr/local/include -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE -Wno-long-long -Wundef -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -O2 -pipe -march=pentium-m -fno-strict-aliasing -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT kcalc_core.lo -MD -MP -MF .deps/kcalc_core.Tpo -c -o kcalc_core.lo kcalc_core.cpp kcalc_core.cpp: In member function 'void CalcEngine::ArcCosDeg(KNumber)': kcalc_core.cpp:252: error: 'acosl' was not declared in this scope [ snipped ] Yes, it's been broken since at least the beginning of April and ignored - mostly. I posted a patch last week and was going to commit it soon if I didn't hear anything. Looks like HAVE_L_FUNCS gets turned on because we have sqrtl in libm in HEAD and that is why it breaks. You can try http://people.freebsd.org/~deischen/patch-configure and adding that to misc/kdeutils3/files. I'm trying to get an amd64 system built with KDE but being hampered by other unrelated things; my intent was to commit it after everything else was built. kdeutils3 is broken (again?). Could you check that your patch is still working? Thanks. http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8.20080811153717/kdeutils-3.5.8.log ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Monday 02 June 2008 09:40:53 pm Daniel Eischen wrote: On Mon, 2 Jun 2008, John Baldwin wrote: Perhaps by recent libm changes that trick autoconf into think we implement an entire batch of floating point ops when we only do a subset: /bin/sh /usr/local/bin/libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I.. -I./knumber -D_ISOC99_SOURCE -I/usr/local/include -I/usr/local/include -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE -Wno-long-long -Wundef -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -O2 -pipe -march=pentium-m -fno-strict-aliasing -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT kcalc_core.lo -MD -MP -MF .deps/kcalc_core.Tpo -c -o kcalc_core.lo kcalc_core.cpp kcalc_core.cpp: In member function 'void CalcEngine::ArcCosDeg(KNumber)': kcalc_core.cpp:252: error: 'acosl' was not declared in this scope [ snipped ] Yes, it's been broken since at least the beginning of April and ignored - mostly. I posted a patch last week and was going to commit it soon if I didn't hear anything. Looks like HAVE_L_FUNCS gets turned on because we have sqrtl in libm in HEAD and that is why it breaks. You can try http://people.freebsd.org/~deischen/patch-configure and adding that to misc/kdeutils3/files. I'm trying to get an amd64 system built with KDE but being hampered by other unrelated things; my intent was to commit it after everything else was built. I've already just hacked the generated config.h to turn HAVE_L_FUNCS off and built it. -- John Baldwin ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd
[kde-freebsd] kdeutils3 build broken on HEAD..
Perhaps by recent libm changes that trick autoconf into think we implement an entire batch of floating point ops when we only do a subset: /bin/sh /usr/local/bin/libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I.. -I./knumber -D_ISOC99_SOURCE -I/usr/local/include -I/usr/local/include -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE -Wno-long-long -Wundef -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -O2 -pipe -march=pentium-m -fno-strict-aliasing -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT kcalc_core.lo -MD -MP -MF .deps/kcalc_core.Tpo -c -o kcalc_core.lo kcalc_core.cpp kcalc_core.cpp: In member function 'void CalcEngine::ArcCosDeg(KNumber)': kcalc_core.cpp:252: error: 'acosl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcCosRad(KNumber)': kcalc_core.cpp:263: error: 'acosl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcCosGrad(KNumber)': kcalc_core.cpp:288: error: 'acosl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcSinDeg(KNumber)': kcalc_core.cpp:313: error: 'asinl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcSinRad(KNumber)': kcalc_core.cpp:324: error: 'asinl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcSinGrad(KNumber)': kcalc_core.cpp:349: error: 'asinl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcTangensDeg(KNumber)': kcalc_core.cpp:362: error: 'atanl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcTangensRad(KNumber)': kcalc_core.cpp:377: error: 'atanl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::ArcTangensGrad(KNumber)': kcalc_core.cpp:390: error: 'atanl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::AreaCosHyp(KNumber)': kcalc_core.cpp:411: error: 'acoshl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::AreaSinHyp(KNumber)': kcalc_core.cpp:428: error: 'asinhl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::AreaTangensHyp(KNumber)': kcalc_core.cpp:451: error: 'atanhl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::CosHyp(KNumber)': kcalc_core.cpp:561: error: 'coshl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::Exp(KNumber)': kcalc_core.cpp:583: error: 'expl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::Ln(KNumber)': kcalc_core.cpp:654: error: 'logl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::Log10(KNumber)': kcalc_core.cpp:674: error: 'log10l' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::SinHyp(KNumber)': kcalc_core.cpp:784: error: 'sinhl' was not declared in this scope kcalc_core.cpp: In member function 'void CalcEngine::TangensHyp(KNumber)': kcalc_core.cpp:920: error: 'tanhl' was not declared in this scope gmake[3]: *** [kcalc_core.lo] Error 1 gmake[3]: Leaving directory `/usr/ports/misc/kdeutils3/work/kdeutils-3.5.8/kcalc' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/usr/ports/misc/kdeutils3/work/kdeutils-3.5.8/kcalc' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/ports/misc/kdeutils3/work/kdeutils-3.5.8' gmake: *** [all] Error 2 *** Error code 2 Stop in /usr/ports/misc/kdeutils3. *** Error code 1 Stop in /usr/ports/x11/kde3. Looks like HAVE_L_FUNCS gets turned on because we have sqrtl in libm in HEAD and that is why it breaks. -- John Baldwin ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd
Re: [kde-freebsd] kdeutils3 build broken on HEAD..
On Mon, 2 Jun 2008, John Baldwin wrote: Perhaps by recent libm changes that trick autoconf into think we implement an entire batch of floating point ops when we only do a subset: /bin/sh /usr/local/bin/libtool --silent --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I.. -I./knumber -D_ISOC99_SOURCE -I/usr/local/include -I/usr/local/include -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE -Wno-long-long -Wundef -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -O2 -pipe -march=pentium-m -fno-strict-aliasing -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT kcalc_core.lo -MD -MP -MF .deps/kcalc_core.Tpo -c -o kcalc_core.lo kcalc_core.cpp kcalc_core.cpp: In member function 'void CalcEngine::ArcCosDeg(KNumber)': kcalc_core.cpp:252: error: 'acosl' was not declared in this scope [ snipped ] Yes, it's been broken since at least the beginning of April and ignored - mostly. I posted a patch last week and was going to commit it soon if I didn't hear anything. Looks like HAVE_L_FUNCS gets turned on because we have sqrtl in libm in HEAD and that is why it breaks. You can try http://people.freebsd.org/~deischen/patch-configure and adding that to misc/kdeutils3/files. I'm trying to get an amd64 system built with KDE but being hampered by other unrelated things; my intent was to commit it after everything else was built. -- DE ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd