Re: [OS-BUILD PATCHv11 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821357524 I don't think the directory name should influence the output UKI name. ie for any of those directories, if i put a `fips.addon` file there, the output binary addon should be `fips.addon.efi`. Also if a 'fips.addon' file is present in both `/common/fips.addon` and `/fedora/x86/fips.addon`, every target build should use the `/common/fips.addon` as input, except for Fedora x86, should should use the override. ie for any given addon name, the most highly specified directory should win as input -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821347736 Answering here because you @berrange and @prudo1 are making the same point: the `common` folder. So the idea is: ``` redhat/addons/virt common common.addon // creates common-virt-rhel-x86, common-virt-rhel-aarch64, common-virt-fedora-x86, common-virt-fedora-aarch64 rhel common rhel.addon // creates rhel-virt-rhel-x86, rhel-virt-rhel-aarch64 x86 x86.addon // creates x86-virt-rhel-x86 aarch64 aarch64.addon // creates aarch64-virt-rhel-aarch64 fedora [same story as rhel] ``` makes sense? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] gitlab-ci: do not merge ark-latest for gating pipelines
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3028#note_1821333677 lots 😂, basically all the scheduled container image builds are broken because of this: - eln: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal- pipelines/cki-trusted-contributors/-/jobs/6422778884 - rawhide: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal- pipelines/cki-trusted-contributors/-/jobs/6423188908 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 1/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821326977 leftover from debugging -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 1/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821326487 yes they need it, I think it's for the PE headers. Anyways, it's super lightweight. But if not provided it will anyways default. And actually you reminded me that it will be picked by default at these same locations, so no need to add this option, neither to keep track of the arch. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821195372 Seeing `fips.addon` file duplicated multiple times makes me think we would benefit from a `redhat/addons/fedora/virt/common/` directory for addons that are not going to be architecture specific. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 1/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Philipp Rudo on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821173690
+arch = path[-1]
+uki = path[-2]
+distro = path[-3]
+for addon_f in filenames:
+if addon_f.endswith('.addon'):
+addon_name = addon_f.replace(".addon","")
+addon_full_name =
f'{addon_name}-{uki}.{distro}.{arch}.addon.efi
I'm not sure if this directory structure is too simple. Thing is that for the
crashkernel= parameter the value is a size. We will need to provide multiple
addons for the parameter for different sizes so users can choose the best
matching one. With the directory structure you are suggesting this means that
we will need to maintain 4 sets of identical addons ((fedora, rhel)*(x86,
aarch64)). Wich will be a constant source of errors.
For configs there is the common/ directory that contains the configs that are
identical for rhel and fedora. In addtions configs contained directly in the
$flavor directory are identical for all arches (unless they explicitely
overwrite it...). Can we do the same for addons as well? That would reduce the
number of redundant definitions and makes managing the addons a lot easier.
--
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 1/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821173923 Is this print intentional or a leftover from debugging? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 1/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Philipp Rudo on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821173795
+cmd = [
+f'{UKIFY_PATH}', 'build',
+f'--stub={CURRENT_SYSTEMD_STUB}'
Do addons need a stub? I thought addons are just data which get parsed by the
stub contained in the UKI.
--
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv11 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821173591 You need to do more to make me truly happy. But having the -debug sub-rpm is a step in the right direction ;-) Although I don't see a point in shipping unsigned addons at all. Creating the addons is a simple call to ukify. Signing them is much more painful. You not only need to create and install your MOK but, when you want to make it properly, setup a full signing environment where the key is stored securely. This adds a lot of complexity and additional hardware requirements only to make sure that the MOK doesn't fall in the wrong hands. So the real value RH adds for our customers is to sign the addons so they don't need to maintain such an environment. Anyway, when the consensus is to ship the -debug addons unsigned I won't block it. We can still sign them later on when needed once we have real life experience with UKI from the field. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] gitlab-ci: do not merge ark-latest for gating pipelines
From: Tales Aparecida on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3028#note_1820954518 Do you have a ticket or an example of the problem to post a link in here? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: kernel leftovers in /boot/efi/EFI/Linux/
the patch worked, thank you https://germano.fedorapeople.org/bugreport/kernel_leftovers/kernel_leftovers_fixed.txt -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: kernel leftovers in /boot/efi/EFI/Linux/
> > https://github.com/kraxel/systemd/commit/6eed67a291bf896befb4d407dc57f9a7fca9c332 > > can't comment on the function, but there is a typo in the commit > message IMO > > and *not* exist early -> and *not* exit early Thanks, fixed. take care, Gerd -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: kernel leftovers in /boot/efi/EFI/Linux/
On Tue, Mar 19, 2024 at 01:46:54AM +0100, Germano Massullo wrote: > I created a Copr repository with the patch > https://copr.fedorainfracloud.org/coprs/germano/systemd_fix_uki-copy_deinstall_patch/ Oh, I was thinking about just patching the file directly on the installed system (90-uki-copy.install is simply copied on install, so the patch should apply just fine) instead of doing a full systemd package update ... take care, Gerd -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] redhat: Fix RT kernel kvm subpackage requires
From: Juri Lelli
redhat: Fix RT kernel kvm subpackage requires
kernel-rt-kvm package currently depends on kernel-rt meta-package, so it
fails to install if kernel-rt is not installed as well. All the other
kernel-rt-* packages however only depend on the kernel-uname-r so they
do not require the kernel-rt meta-package.
Layered products doesn't use kernel-rt meta-package to side load
kernels, as it would bring in unwanted additional dependency. They
install kernel-rt-* packages and this is then currently a problem for
kernel-rt-kvm.
kernel-rt-kvm doesn't actually require kernel-rt meta-package, but only
the correct kernel-rt (core) version. So, fix its dependencies
accordingly.
Signed-off-by: Juri Lelli
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100644
--- a/redhat/kernel.spec.template
+++ b/redhat/kernel.spec.template
@@ -1504,7 +1504,7 @@ The meta-package for the %{1} kernel\
%package %{?1:%{1}-}kvm\
Summary: KVM modules for package kernel%{?1:-%{1}}\
Group: System Environment/Kernel\
-Requires: kernel%{?1:-%{1}} = %{version}-%{release}\
+Requires: kernel-uname-r = %{KVERREL}%{uname_suffix %{?1:%{1}}}\
Provides: installonlypkg(kernel-module)\
Provides: kernel%{?1:-%{1}}-kvm-%{_target_cpu} = %{version}-%{release}\
AutoReq: no\
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3029
--
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
