Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Cirilo Bernardo]

On Thu, Apr 13, 2017 at 11:55 PM, Tiger12506  wrote:
> My opinion doesn't matter, but how about this for a comment...
>
> // ReadName has a side-effect of incrementing the parser, so it should
> indeed be called twice.
>
> I certainly agree with you that people shouldn't change something they don't
> understand, but I also don't think it's unreasonable for someone to think
> that a function named ReadName might be a harmless read-only function.
>
> Or if that comment doesn't accurately describe what's happening, provide an
> example of what's getting parsed by that line in a comment.
>
> Just a thought.
>
>

I'll think about it; maybe I can put the expected pattern into a comment so
it's more obvious why the function is called twice.

- Cirilo

>
> On 4/13/2017 6:06 PM, Cirilo Bernardo wrote:
>>
>> On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller  wrote:
>>>
>>> Hi!
>>>
>>> These lines scream for some comments in the source...
>>> I wouldn't get it, too.
>>>
>>> Regards,
>>>
>>> Clemens
>>>
>> What sort of comment: "this is really supposed to have two sequential
>> calls to the same function, so don't change it"?  For me that makes no
>> sense. If anyone is going to play with parsers they should be familiar
>> with the standard that is being implemented; making changes without
>> understanding the specification (and without understanding what the
>> parser is doing) cannot possibly be a good thing. Programmers should
>> also check that they are fixing a demonstrable problem and if they don't
>> understand the code then it should be left alone. At any rate there is a
>> comment only a few lines back about how the unimplemented features
>> PROTO and EXTERNPROTO are to be treated and from this the fact
>> that PROTO and EXTERNPROTO code are different and in two distinct
>> blocks should suggest that they really should not be the same code.
>> In the past when other developers have seen code that they don't
>> immediately understand but which looks a little strange to them, they
>> at least ask for comments rather than making blind changes. If people
>> don't read an obvious comment block a few lines up I don't see why they
>> would read comments immediately surrounding code either. How much
>> hand-holding are we expected to do?
>>
>> - Cirilo
>>
>>
>>> On 2017-04-13 14:03, Wayne Stambaugh wrote:

 Cirilo,

 Thanks for the info.  The second call to ReadName() does look a bit odd
 so I can understand Konrad's confusion.

 Cheers,

 Wayne

 On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
>
> Do not accept this patch, it will break the parser. The statement
> which was removed is not redundant.
>
> - Cirilo
>
> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
>  wrote:
>>
>> ---
>>   plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Kevin Cozens]

On 2017-04-13 06:06 PM, Cirilo Bernardo wrote:

On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller  wrote:

These lines scream for some comments in the source...
I wouldn't get it, too.


What sort of comment: "this is really supposed to have two sequential
calls to the same function, so don't change it"?  For me that makes no
sense. If anyone is going to play with parsers they should be familiar
with the standard that is being implemented;

[snip]

How much hand-holding are we expected to do?


That duplicate call looks really suspicious at first glance. A one line 
comment saying it is deliberate and not a mistake is all that is needed. Any 
additional explanation can be left for elsewhere in the source code.


--
Cheers!

Kevin.

http://www.ve3syb.ca/   |"Nerds make the shiny things that distract
Owner of Elecraft K2 #2172  | the mouth-breathers, and that's why we're
| powerful!"
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Tiger12506]

My opinion doesn't matter, but how about this for a comment...

// ReadName has a side-effect of incrementing the parser, so it should 
indeed be called twice.


I certainly agree with you that people shouldn't change something they 
don't understand, but I also don't think it's unreasonable for someone 
to think that a function named ReadName might be a harmless read-only 
function.


Or if that comment doesn't accurately describe what's happening, provide 
an example of what's getting parsed by that line in a comment.


Just a thought.


On 4/13/2017 6:06 PM, Cirilo Bernardo wrote:

On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller  wrote:

Hi!

These lines scream for some comments in the source...
I wouldn't get it, too.

Regards,

Clemens


What sort of comment: "this is really supposed to have two sequential
calls to the same function, so don't change it"?  For me that makes no
sense. If anyone is going to play with parsers they should be familiar
with the standard that is being implemented; making changes without
understanding the specification (and without understanding what the
parser is doing) cannot possibly be a good thing. Programmers should
also check that they are fixing a demonstrable problem and if they don't
understand the code then it should be left alone. At any rate there is a
comment only a few lines back about how the unimplemented features
PROTO and EXTERNPROTO are to be treated and from this the fact
that PROTO and EXTERNPROTO code are different and in two distinct
blocks should suggest that they really should not be the same code.
In the past when other developers have seen code that they don't
immediately understand but which looks a little strange to them, they
at least ask for comments rather than making blind changes. If people
don't read an obvious comment block a few lines up I don't see why they
would read comments immediately surrounding code either. How much
hand-holding are we expected to do?

- Cirilo



On 2017-04-13 14:03, Wayne Stambaugh wrote:

Cirilo,

Thanks for the info.  The second call to ReadName() does look a bit odd
so I can understand Konrad's confusion.

Cheers,

Wayne

On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:

Do not accept this patch, it will break the parser. The statement
which was removed is not redundant.

- Cirilo

On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
 wrote:

---
  plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Cirilo Bernardo]

On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller  wrote:
> Hi!
>
> These lines scream for some comments in the source...
> I wouldn't get it, too.
>
> Regards,
>
> Clemens
>

What sort of comment: "this is really supposed to have two sequential
calls to the same function, so don't change it"?  For me that makes no
sense. If anyone is going to play with parsers they should be familiar
with the standard that is being implemented; making changes without
understanding the specification (and without understanding what the
parser is doing) cannot possibly be a good thing. Programmers should
also check that they are fixing a demonstrable problem and if they don't
understand the code then it should be left alone. At any rate there is a
comment only a few lines back about how the unimplemented features
PROTO and EXTERNPROTO are to be treated and from this the fact
that PROTO and EXTERNPROTO code are different and in two distinct
blocks should suggest that they really should not be the same code.
In the past when other developers have seen code that they don't
immediately understand but which looks a little strange to them, they
at least ask for comments rather than making blind changes. If people
don't read an obvious comment block a few lines up I don't see why they
would read comments immediately surrounding code either. How much
hand-holding are we expected to do?

- Cirilo


> On 2017-04-13 14:03, Wayne Stambaugh wrote:
>> Cirilo,
>>
>> Thanks for the info.  The second call to ReadName() does look a bit odd
>> so I can understand Konrad's confusion.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
>>> Do not accept this patch, it will break the parser. The statement
>>> which was removed is not redundant.
>>>
>>> - Cirilo
>>>
>>> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
>>>  wrote:
 ---
  plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [FEATURE] Component table viewer

[Oliver Walters]

Just a friendly reminder about this, I haven't heard anything since
attaching the correct patches.

Cheers

On 7 Apr 2017 19:27, "Oliver Walters" 
wrote:

> I am very sorry about this, three mistakes in a row!
>
> It has been pointed out that I have attached the patches in the incorrect
> order.
>
> To prevent this I have attached a single patch for each commit. They are
> attached to this email (ignore previous patches) and should be applied in
> order _001 , _002.
>
> Sorry! :)
>
> On Sat, Apr 1, 2017 at 11:53 PM, Oliver Walters <
> oliver.henry.walt...@gmail.com> wrote:
>
>> After a long break on this project I have finally rounded the edges off
>> the component table viewer I have been working on.
>>
>> This is a table/spreadsheet view of all the components in the schematic,
>> which allows bulk editing, grouping components, and exporting to
>> CSV/TSV/HTML BOM.
>>
>> Here's some screenshots of it in action:
>>
>> http://imgur.com/gallery/WUwek
>>
>> I have tried to limit the complexity as far as possible, so that it's not
>> too cumbersome for users.
>>
>> Any changes you make in the table are highlighted and can be reverted
>> (back to the values in the schematic).
>>
>> When you close the view, all changes are pushed back to the schematic,
>> and the bulk-edit is pushed to the undo-stack as a single item (meaning
>> that you can easily undo all the changes you just made).
>>
>> Please let me know of any errors or edge cases!
>>
>> Patch has been rebased to latest master at time of this email.
>>
>> Cheers,
>> Oliver
>>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Kicad request, wish list

[Wayne Stambaugh]

Hi Oksana,

This feature has been requested and discussed in the past.  There may
even be a bug report for it in our bug tracker.

You could use the array tool in the GAL canvas but it's not very usable
for large boards due to speed issues.

I personally don't have the time to work on this.  Maybe one of our
other developers has the time to help you out.

As far as getting this done before the next stable release, that may be
asking a lot.  We are hoping to branch the next stable release within
the next month or two.  Once we make a new stable release branch, no new
features will be committed to the stable branch and will be merged to
the development branch for the next stable release.

We typically do paid work through the donations via CERN which you can
find on our website.  In the past, donors have paid for specific
features so you should be able to do this as well.  You are free to pay
developers directly but you are responsible for making that happen.
Please keep in mind that paying developer does not insure that a feature
will make it into KiCad.  That still requires approval from the KiCad
development team and project leader (me).  Thank you for your interest
in supporting KiCad.  Hopefully someone will have the time to help you out.

Cheers,

Wayne

On 4/13/2017 8:16 AM, Oksana Gryndak wrote:
> Hello
> I'm wondering if it's possible to add functions to the program as in this 
> script Replicating pcbnew new for arrayed sheets 
> https://kicad.mmccoo.com/2017/02/01/replicating-pcbnew-new-for-arrayed-sheets/
>  and how here Panelize Http://projects.borg.ch/electronics/kicad/panelize.html
> I can pay / donate to get this feature in the next release of KiCAD if it can 
> be done quickly.
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Kicad request, wish list

[Oksana Gryndak]

Hello
I'm wondering if it's possible to add functions to the program as in this 
script Replicating pcbnew new for arrayed sheets 
https://kicad.mmccoo.com/2017/02/01/replicating-pcbnew-new-for-arrayed-sheets/ 
and how here Panelize Http://projects.borg.ch/electronics/kicad/panelize.html
I can pay / donate to get this feature in the next release of KiCAD if it can 
be done quickly.

-- 
Best Regards,
Oksana Gryndak
oksana.gryn...@yandex.ru

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

[Wayne Stambaugh]

Where do we stand on a fix for this?

On 4/10/2017 3:18 AM, jp charras wrote:
> Le 10/04/2017 à 08:39, Nick Østergaard a écrit :
>> Hi JP,
>>
>> Yes I can confirm that it seems to work now, but since you mentioned
>> that it was not fixed properly yet, I thought it was worth
>> highlighting in this thread. Are unittests missing here for the
>> geometry library or is this on a higher level?
> 
> About SEG class, unittests works.
> 
> It is more the fact when using a SEG class, you can now modify an other 
> entity without clearly
> notice in your code the other entity will be modified, by side effect, 
> because now the SEG class
> stores a reference to the other entity, not a copy of values.
> 
> It is this side effect I do not like.
> 
> About bugs reports for zones, zones had 3 different bugs:
> * The outlines was broken when adding a corner (GAL) due to the SEG class 
> change.
> * Cutout outlines were incorrectly saved and read in .kicad_pcb files.
> * Cutout outlines were incorrectly managed in GAL, when created: they were 
> added as main outlines,
> not holes in an existing main outline.
> 
> Still remains serious issues in GAL mode about self intersecting and 
> overlapping polygons after
> creation or edition.
> These issues exist since the beginning.
> (They are not too hard to fix, because methods to fix them are written for 
> the legacy mode, but need
> a better knowledge I have to correctly manage undo/redo on GAL, due to the 
> fact the number of
> existing or new zones can change after cleaning or editing zones)
> 
> Note also usability issues in zones pop up menu (missing option to delete a 
> cutout, and most
> commands disabled when the zone tool is activated).
> 
>>
>> Nick
>>
>> 2017-04-10 8:21 GMT+02:00 jp charras :
>>> Le 09/04/2017 à 22:18, Nick Østergaard a écrit :
 Hi Alejandro,

 It seems like there is a use case you may not have considered. The zone 
 cutout.
>>>
>>> I am thinking I recently fixed this issue.
>>>
>>> However I am not thrilled by commit 
>>> f68ce306bdca0a2f5a1a234497ede6550ca79a0b for geometry/seg.h
>>> Instead of storing coordinates, SEG stores after this commit references to 
>>> VECTOR2I of an other entity.
>>> It means when you (for some reason) modify a coordinate value in a SEG 
>>> instance, you can modify also
>>> the other entity, that is not expected.
>>> (I saw that when I fixed the zone cutout issues).
>>> It was one (but not the only one) reason cutouts did not work.
>>>
>>> However I am really not satisfied by the way polygon zones are created or 
>>> edited in GAL:
>>> they can easily be self intersecting (when created or when a corner is 
>>> moved or deleted) or overlapping.
>>>
>>> In Kicad, polygons *cannot be* self intersecting (not accepted in Gerber 
>>> files).
>>>
>>> In Legacy mode, they are tested and modified (break into 2 or more 
>>> polygons, and/or merged with
>>> similar zones) after each change.
>>> This is mandatory to avoid broken zones.
>>>

 See https://bugs.launchpad.net/kicad/+bug/1679795


 2017-03-24 11:01 GMT+01:00 Maciej Sumiński :
> TL;DR: Everything seems fine, I am going to merge the branch today.
>
> For the record: I got the board that was showing the differences. I
> refilled zones using the master branch, then once again with the polygon
> refactor patch applied. Diff of zone polygons shows no difference.
>
> There were differences between the zones in the original file and the
> just refilled, so there could be a change in the filling algorithm in
> the meantime.
>
> I am going to merge the branch soon. Thank you Alejandro, I know it was
> a rough road, but we are really grateful for your work. Well done!
>
> Regards,
> Orson
>
> On 03/23/2017 09:19 AM, Maciej Sumiński wrote:
>> Finally I had some time to test the branch and I could not find any
>> problems, hence I would like to merge it. Let me know if there are any
>> objections.
>>
>> @Nick:
>> Could you give more details? I placed keepout zones and refilled zones
>> for all demo boards, and every time I get exactly the same zones (diffed
>> two .kicad_pcb files).
>>
>> Regards,
>> Orson
>>
>> On 02/18/2017 08:13 PM, Nick Østergaard wrote:
>>> I have noticed that Alejandro's branch does not have a clearance
>>> distance to a keepout zone, which the old filling algorithm has.
>>>
>>> I am not sure what is really desired, but this could potentially break
>>> old designs, although I like the new way where the zone goes to the
>>> keepout edge.
>>>
>>> 2017-02-17 20:24 GMT+01:00 jp charras :
 Le 17/02/2017 à 19:41, Alejandro Garcia Montoro a écrit :
> Hi!
>
> The errors were caused by some asserts that contained functions that 
> needed to be called... My bad.

Re: [Kicad-developers] [PATCH 1/2] Remove redundant statement in DSNLEXER::PopReader

[Wayne Stambaugh]

Konrad,

I merged your patch into the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 4/12/2017 4:01 PM, Konrad Beckmann wrote:
> ---
>  common/dsnlexer.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

Simon,

I committed your patch since osx expects the icons to be disabled by
default.

Thanks,

Wayne

On 4/8/2017 6:42 AM, Simon Wells wrote:
> Please see attached patch to disable icons in the menus by default on osx
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[David Godfrey]

  
  
I agree, 
  A patch to add explanatory comments would seem to be required
  here.
  Otherwise someone in the future is likely to make a similar change
  in a larger patch and it will likely be missed during review.

Regards
David G

On 13/04/17 21:34, Clemens Koller
  wrote:


  Hi!

These lines scream for some comments in the source...
I wouldn't get it, too.

Regards,

Clemens

On 2017-04-13 14:03, Wayne Stambaugh wrote:

  
Cirilo,

Thanks for the info.  The second call to ReadName() does look a bit odd
so I can understand Konrad's confusion.

Cheers,

Wayne

On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:


  Do not accept this patch, it will break the parser. The statement
which was removed is not redundant.

- Cirilo

On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
 wrote:

  
---
 plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


  
  
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


  
  
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




-- 
  
  Regards
  David Godfrey
  
  

 mb:
  chat:   0437 286 200
  with dcg_mx at #sbts:matrix.org
  Chat is via matrix.org.
There are clients available for All Operating Systems and
Hardware devices.
Including Linux, Android, Windows, Mac, iOS
I'd recommend the multiplatform RIOT client as the best
starting point.
with RIOT web the easiest on any PC 

  

  


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Clemens Koller]

Hi!

These lines scream for some comments in the source...
I wouldn't get it, too.

Regards,

Clemens

On 2017-04-13 14:03, Wayne Stambaugh wrote:
> Cirilo,
> 
> Thanks for the info.  The second call to ReadName() does look a bit odd
> so I can understand Konrad's confusion.
> 
> Cheers,
> 
> Wayne
> 
> On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
>> Do not accept this patch, it will break the parser. The statement
>> which was removed is not redundant.
>>
>> - Cirilo
>>
>> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
>>  wrote:
>>> ---
>>>  plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[Wayne Stambaugh]

Cirilo,

Thanks for the info.  The second call to ReadName() does look a bit odd
so I can understand Konrad's confusion.

Cheers,

Wayne

On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
> Do not accept this patch, it will break the parser. The statement
> which was removed is not redundant.
> 
> - Cirilo
> 
> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
>  wrote:
>> ---
>>  plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Expose netclassptr constructor to python interface

[miles mccoo]

Hello,

This is my second contribution. It's a simple one line addition to
netclass.i to expose the netclassptr constructor, enabling python scripts
to add new netclasses.

In my first contribution, I made a couple errors in the contribution
process which Wayne graciously fixed for me. I did look at those
differences and I believe I'm adhering better now.

If I missed something this time, please be specific. I plan on contributing
again and want to make things as easy as possible.



In case anyone would like to exercise the code, this will do it. The new
api is in red:
import pcbnew

board = pcbnew.GetBoard()
ds = board.GetDesignSettings()
# ugly. exposes a public member not via an accessor method
nc = ds.m_NetClasses
foo = pcbnew.NETCLASSPTR("foo")
nc.Add(foo)



Miles

PS this is only a one-liner and I feel a little goofy for it. I wanted to
get it out there before it got lost in the pile other stuff I'm doing.
From 2812192e5928a8d72abceeef33291f4ac3a3dfa7 Mon Sep 17 00:00:00 2001
From: Miles McCoo 
Date: Thu, 13 Apr 2017 11:13:21 +0200
Subject: [PATCH] Minor Pcbnew Python scripting improvement.
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2.7.4"

This is a multi-part message in MIME format.
--2.7.4
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit


Added NETCLASSPTR contructor to swig interface. This enables scripts to generate new net classes.
---
 pcbnew/swig/netclass.i | 26 +-
 1 file changed, 25 insertions(+), 1 deletion(-)


--2.7.4
Content-Type: text/x-patch; name="0001-Minor-Pcbnew-Python-scripting-improvement.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Minor-Pcbnew-Python-scripting-improvement.patch"

diff --git a/pcbnew/swig/netclass.i b/pcbnew/swig/netclass.i
index 200c8ed..64602c8 100644
--- a/pcbnew/swig/netclass.i
+++ b/pcbnew/swig/netclass.i
@@ -1,3 +1,26 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2012 NBEE Embedded Systems, Miguel Angel Ajo 
+ * Copyright (C) 1992-2017 KiCad Developers, see AUTHORS.txt for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
 
 /*
 
@@ -25,7 +48,8 @@ function set if you see something missing from class NETCLASS that you need.
 %extend std::shared_ptr
 {
 public:
-
+std::shared_ptr(std::string name) { return new std::shared_ptr( new NETCLASS(name) ); }
+
 STRINGSET&  NetNames()  { return (*self)->NetNames(); }
 
 const wxString& GetName()   { return (*self)->GetName(); }

--2.7.4--


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp