Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Wayne Stambaugh 
On 9/4/2017 8:58 AM, Tomasz Wlostowski wrote:
> On 03.09.2017 18:29, Mathias Grimmberger wrote:
>>
>> Hi all,
>>
>>
>> below is a patch to add "mils" as a user unit to pcbnew, the gerber
>> viewer and the module editor. I left out eeschema because I do not think
>> it's useful there, but if required adding it would be easy.
>>
>> I probably missed some places needing modification. In any case somebody
>> with the requisite skills needs to create a proper toolbar icon for
>> mils.
>>
> Hi all,
> 
> I tested this patch and I consider it very useful. If there's no
> objections (Wayne, JP?), I'd like to merge it as soon as possible (+
> make icon as a bonus ;-)

Did you verify coding style?  I have not had a chance to look at it yet.

Wayne

> 
> Cheers,
> Tom
>>
>> Have fun,
>>
>> MGri
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Wayne Stambaugh 
On 9/4/2017 4:14 PM, Mathias Grimmberger wrote:
> 
> Hi Lorenzo,
> 
> Lorenzo Marcantonio  writes:
>> On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote:
>>> below is a patch to add "mils" as a user unit to pcbnew, the gerber
>>> viewer and the module editor. I left out eeschema because I do not think
>>> it's useful there, but if required adding it would be easy.
>>
>> The input box parser actually interpret 'mi' for mils since its
>> creations, by the way!
> 
> I noticed that this should already work.
> 
> Unfortunately in the dialogs using the WX_UNIT_BINDER it doesn't because
> the unit binder flags input with an appended unit as invalid. And to add
> insult to injury no error is shown, the input is just ignored (also
> for stuff like "zz").
> 
> Input validation is implemented quite unevenly in any case, some inputs
> do not even allow to input invalid characters (IMHO desirable), others
> allow anything and complain later.
> 
> Is there a plan how this should work, is WX_UNIT_BINDER the standard way
> envisioned? Because in that case it needs some work.

wxValidator is the standard way to customize control input and output.
This is well documented in the wxWidgets documentation.  Please do not
create a custom design unless there is no way to do this as validator
which I highly doubt.  There are even source files for creating custom
validators aptly named include/validators.h and common/validators.cpp.

> 
> 
> MGri
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Mathias Grimmberger 

Hi Lorenzo,

Lorenzo Marcantonio  writes:
> On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote:
>> below is a patch to add "mils" as a user unit to pcbnew, the gerber
>> viewer and the module editor. I left out eeschema because I do not think
>> it's useful there, but if required adding it would be easy.
>
> The input box parser actually interpret 'mi' for mils since its
> creations, by the way!

I noticed that this should already work.

Unfortunately in the dialogs using the WX_UNIT_BINDER it doesn't because
the unit binder flags input with an appended unit as invalid. And to add
insult to injury no error is shown, the input is just ignored (also
for stuff like "zz").

Input validation is implemented quite unevenly in any case, some inputs
do not even allow to input invalid characters (IMHO desirable), others
allow anything and complain later.

Is there a plan how this should work, is WX_UNIT_BINDER the standard way
envisioned? Because in that case it needs some work.


MGri

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Select via sizes from design rules

2017-09-04 Thread Mathias Grimmberger 

Hi Maciej,

Maciej Sumiński  writes:
> Hi Mathias,
>
> I apologize for not replying to the width setting dropbox earlier, now
> it seems to be too late to change the idea.
>
> Your patch is a clever solution to the problem, so if there are no more
> ideas/patches for setting via sizes, I am going to apply your changes.


Below is an updated patch, the original one would not disable the
dropdown when the "use netclass values" checkbox was checked.


Have fun,

MGri


diff --git a/pcbnew/dialogs/dialog_track_via_properties.cpp b/pcbnew/dialogs/dialog_track_via_properties.cpp
index 28d4c1b30..15db2bc5a 100644
--- a/pcbnew/dialogs/dialog_track_via_properties.cpp
+++ b/pcbnew/dialogs/dialog_track_via_properties.cpp
@@ -189,6 +189,30 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
 setCommonVal( viaY, m_ViaYCtrl, m_viaY );
 setCommonVal( viaDiameter, m_ViaDiameterCtrl, m_viaDiameter );
 setCommonVal( viaDrill, m_ViaDrillCtrl, m_viaDrill );
+m_DesignRuleViasUnit->SetLabel( GetAbbreviatedUnitsLabel( g_UserUnit ) );
+
+int viaSelection = wxNOT_FOUND;
+
+for( unsigned ii = 0; ii < aParent->GetDesignSettings().m_ViasDimensionsList.size(); ii++ )
+{
+VIA_DIMENSION* viaDimension = >GetDesignSettings().m_ViasDimensionsList[ii];
+wxString msg = StringFromValue( g_UserUnit, viaDimension->m_Diameter, false )
++ " / " + StringFromValue( g_UserUnit, viaDimension->m_Drill, false );
+m_DesignRuleViasCtrl->Append( msg, viaDimension );
+
+if( viaSelection == wxNOT_FOUND && viaDiameter == viaDimension->m_Diameter
+&& viaDrill == viaDimension->m_Drill )
+{
+viaSelection = ii;
+}
+}
+
+m_DesignRuleViasCtrl->SetSelection( viaSelection );
+
+m_DesignRuleViasCtrl->Connect( wxEVT_CHOICE, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaSelect ), NULL, this );
+m_ViaDiameterCtrl->Connect( wxEVT_TEXT, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaEdit ), NULL, this );
+m_ViaDrillCtrl->Connect( wxEVT_TEXT, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaEdit ), NULL, this );
+
 m_ViaDiameterCtrl->SetFocus();
 }
 else
@@ -410,6 +434,10 @@ void DIALOG_TRACK_VIA_PROPERTIES::onViaNetclassCheck( wxCommandEvent& aEvent )
 {
 bool enableNC = aEvent.IsChecked();
 
+m_DesignRuleVias->Enable( !enableNC );
+m_DesignRuleViasCtrl->Enable( !enableNC );
+m_DesignRuleViasUnit->Enable( !enableNC );
+
 m_ViaDiameterLabel->Enable( !enableNC );
 m_ViaDiameterCtrl->Enable( !enableNC );
 m_ViaDiameterUnit->Enable( !enableNC );
@@ -433,6 +461,24 @@ void DIALOG_TRACK_VIA_PROPERTIES::onOkClick( wxCommandEvent& aEvent )
 }
 
 
+void DIALOG_TRACK_VIA_PROPERTIES::onViaSelect( wxCommandEvent& aEvent )
+{
+VIA_DIMENSION* viaDimension = static_cast ( aEvent.GetClientData() );
+
+wxString msg = StringFromValue( g_UserUnit, viaDimension->m_Diameter, false );
+m_ViaDiameterCtrl->ChangeValue( msg );
+
+msg = StringFromValue( g_UserUnit, viaDimension->m_Drill, false );
+m_ViaDrillCtrl->ChangeValue( msg );
+}
+
+
+void DIALOG_TRACK_VIA_PROPERTIES::onViaEdit( wxCommandEvent& aEvent )
+{
+m_DesignRuleViasCtrl->SetSelection( wxNOT_FOUND );
+}
+
+
 bool DIALOG_TRACK_VIA_PROPERTIES::check() const
 {
 bool trackNetclass = m_trackNetclass->IsChecked();
diff --git a/pcbnew/dialogs/dialog_track_via_properties.h b/pcbnew/dialogs/dialog_track_via_properties.h
index 14e15518c..50909924c 100644
--- a/pcbnew/dialogs/dialog_track_via_properties.h
+++ b/pcbnew/dialogs/dialog_track_via_properties.h
@@ -46,6 +46,8 @@ private:
 void onViaNetclassCheck( wxCommandEvent& aEvent ) override;
 void onCancelClick( wxCommandEvent& aEvent ) override;
 void onOkClick( wxCommandEvent& aEvent ) override;
+void onViaSelect( wxCommandEvent& aEvent );
+void onViaEdit( wxCommandEvent& aEvent );
 
 void OnInitDlg( wxInitDialogEvent& event ) override
 {
diff --git a/pcbnew/dialogs/dialog_track_via_properties_base.cpp b/pcbnew/dialogs/dialog_track_via_properties_base.cpp
index 5af355aba..23c117bc2 100644
--- a/pcbnew/dialogs/dialog_track_via_properties_base.cpp
+++ b/pcbnew/dialogs/dialog_track_via_properties_base.cpp
@@ -191,6 +191,19 @@ DIALOG_TRACK_VIA_PROPERTIES_BASE::DIALOG_TRACK_VIA_PROPERTIES_BASE( wxWindow* pa
 	fgViaRightSizer->SetFlexibleDirection( wxBOTH );
 	fgViaRightSizer->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
 	
+	m_DesignRuleVias = new wxStaticText( m_sbViaSizer->GetStaticBox(), wxID_ANY, _("Design rule vias:"), wxDefaultPosition, wxDefaultSize, 0 );
+	m_DesignRuleVias->Wrap( -1 );
+	fgViaRightSizer->Add( m_DesignRuleVias, 0, wxALIGN_CENTER_VERTICAL|wxALIGN_RIGHT|wxALL, 5 );
+	
+	wxArrayString m_DesignRuleViasCtrlChoices;
+	m_DesignRuleViasCtrl = new wxChoice(

Re: [Kicad-developers] [PATCH] Change track width setting to dropbox

2017-09-04 Thread Mathias Grimmberger 

Hi Maciej,

Maciej Sumiński  writes:
> Hi Mathias,
>
> On 08/25/2017 09:55 PM, Mathias Grimmberger wrote:
>> 
>> Hi Maciej,
>> 
>> [snip]
>> 
>> Does that sound useable or is it too much "magic"?
>
> I agree, it is not as simple as with track widths, so it requires a bit
> of "magic".
>
> What do you think about putting in each dropbox single values (either
> diameter or drill size) followed by value pairs? If the user selects a
> single value, the other setting is not affected. In case of choosing a
> pair - both values are modified.
>
> For example, via size settings:
> diameter | drill
> -+--
>1 | 0.5
>  1.5 | 1
>  1.7 | 1.2
>
> Would give the following choices in dropboxes:
>
> Via diameter: 1
>   1.5
>   1.7
>   1/0.5
>   1.5/1
>   1.7/1.2
>
> Via drill:0.5
>   1
>   1.2
>   1/0.5
>   1.5/1
>   1.7/1.2

I thought about it for a bit but I think it's not the right thing to do.
The via diameter/drill were setup as pairs of dimensions, they should be
used a such. Otherwise one could select a larger drill than via diameter
which would be weird for predefined values (one can always enter the
values by hand to get the effect ;-).

Anyway, I also experimented with the implementation of such a behaviour,
I don't think it can be made to work. The problem is in updating the
dropbox itself to a different value than is in its value list. This
leads to the control resetting its internal position in the value list
which makes scrolling by up/down key through the values impossible. I
have no idea what weird behaviour could emerge on Windows or Mac.

That is ultimately the reason there is now a standard dropdown list to
select from.


MGri

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Python doxygen for 4.0.7 Stable?

2017-09-04 Thread Nick Østergaard 
No, but good point. I will try to make that available.

Den 4. sep. 2017 5.10 PM skrev "Greg Smith" :

> Is there an equivalent to
>
> http://docs.kicad-pcb.org/doxygen-python/
>
> For 4.0.7 Stable?
>
>
> Clicking on "Namespaces" tab and then the "pcbnew" label brings you to
> this page:
> http://docs.kicad-pcb.org/doxygen-python/namespacepcbnew.html
>
>
> I use that page as the primary reference document for pcbnew python.
>
> Greg S.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Python doxygen for 4.0.7 Stable?

2017-09-04 Thread Greg Smith 
Is there an equivalent to

http://docs.kicad-pcb.org/doxygen-python/

For 4.0.7 Stable?

Clicking on "Namespaces" tab and then the "pcbnew" label brings you to this 
page:
http://docs.kicad-pcb.org/doxygen-python/namespacepcbnew.html

I use that page as the primary reference document for pcbnew python.

Greg S.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Missing symbol elements in eeschema?

2017-09-04 Thread Bernhard Stegmaier 
… here the bug report:
  https://bugs.launchpad.net/kicad/+bug/1714974 


Regards,
Bernhard

> On 4. Sep 2017, at 14:31, Bernhard Stegmaier  wrote:
> 
> Hi Orson,
> 
> sure, no problem… I’ll do some more tests and put everything into a bug 
> report.
> I just quickly wanted to know beforehand if this happens only to me (or, only 
> on macOS?).
> 
> 
> Regards,
> Bernhard
> 
>> On 4. Sep 2017, at 14:16, Maciej Suminski  wrote:
>> 
>> Hi Bernhard,
>> 
>> It would be greatly appreciated if you could turn this into a bug
>> report. Otherwise it will quickly drown and become forgotten, given the
>> ML traffic level.
>> 
>> Any chance we could get a project that reliably reproduces the problem?
>> 
>> Regards,
>> Orson
>> 
>> On 09/03/2017 11:24 PM, Bernhard Stegmaier wrote:
>>> Hi,
>>> 
>>> with current version (see below), I am missing arbitrary symbols in 
>>> eeschema after startup:
>>> (1) Startup KiCad (project manager)
>>> (2) Open schematic of last project. This time the graphic lines of two 
>>> connectors are missing:
>>> 
>>> 
>>> Close/reopen of eeschema doesn’t help.
>>> If I change to a different project and then back to first project (without 
>>> restarting KiCad), then the missing symbols are back again.
>>> I have seen this also in the official nightly (same version, but with 
>>> supported wxWidgets).
>>> 
>>> Looks like some race-condition in loading symbol libraries?
>>> 
>>> 
>>> Regards,
>>> Bernhard
>>> 
>>> ===
>>> 
>>> Application: kicad
>>> Version: (2017-09-02 revision 1fe91e625)-master, release build
>>> Libraries:
>>>   wxWidgets 3.1.1
>>>   libcurl/7.54.0 SecureTransport zlib/1.2.8
>>> Platform: macOS Sierra Version 10.12.6 (Build 16G29), 64 bit, Little 
>>> endian, wxMac
>>> Build Info:
>>>   wxWidgets: 3.1.1 (UTF-8,STL containers)
>>>   Boost: 1.59.0
>>>   Curl: 7.55.1
>>>   Compiler: Clang 8.1.0 with C++ ABI 1002
>>> 
>>> Build settings:
>>>   USE_WX_GRAPHICS_CONTEXT=ON
>>>   USE_WX_OVERLAY=ON
>>>   KICAD_SCRIPTING=OFF
>>>   KICAD_SCRIPTING_MODULES=OFF
>>>   KICAD_SCRIPTING_WXPYTHON=OFF
>>>   KICAD_SCRIPTING_ACTION_MENU=OFF
>>>   BUILD_GITHUB_PLUGIN=ON
>>>   KICAD_USE_OCE=ON
>>>   KICAD_SPICE=OFF
>>> 
>>> 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread jp charras 
Le 04/09/2017 à 14:58, Tomasz Wlostowski a écrit :
> On 03.09.2017 18:29, Mathias Grimmberger wrote:
>>
>> Hi all,
>>
>>
>> below is a patch to add "mils" as a user unit to pcbnew, the gerber
>> viewer and the module editor. I left out eeschema because I do not think
>> it's useful there, but if required adding it would be easy.
>>
>> I probably missed some places needing modification. In any case somebody
>> with the requisite skills needs to create a proper toolbar icon for
>> mils.
>>
> Hi all,
> 
> I tested this patch and I consider it very useful. If there's no
> objections (Wayne, JP?), I'd like to merge it as soon as possible (+
> make icon as a bonus ;-)
> 
> Cheers,
> Tom
>>
>> Have fun,
>>
>> MGri


No objection.
I just made a small test, without problem.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Lorenzo Marcantonio 
On Mon, Sep 04, 2017 at 02:58:45PM +0200, Tomasz Wlostowski wrote:
> below is a patch to add "mils" as a user unit to pcbnew, the gerber
> viewer and the module editor. I left out eeschema because I do not think
> it's useful there, but if required adding it would be easy.

The input box parser actually interpret 'mi' for mils since its creations, by 
the way!

-- 
Lorenzo Marcantonio


signature.asc
Description: PGP signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add mils as user unit

2017-09-04 Thread Tomasz Wlostowski 
On 03.09.2017 18:29, Mathias Grimmberger wrote:
> 
> Hi all,
> 
> 
> below is a patch to add "mils" as a user unit to pcbnew, the gerber
> viewer and the module editor. I left out eeschema because I do not think
> it's useful there, but if required adding it would be easy.
> 
> I probably missed some places needing modification. In any case somebody
> with the requisite skills needs to create a proper toolbar icon for
> mils.
> 
Hi all,

I tested this patch and I consider it very useful. If there's no
objections (Wayne, JP?), I'd like to merge it as soon as possible (+
make icon as a bonus ;-)

Cheers,
Tom
> 
> Have fun,
> 
> MGri
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Missing symbol elements in eeschema?

2017-09-04 Thread Bernhard Stegmaier 
Hi Orson,

sure, no problem… I’ll do some more tests and put everything into a bug report.
I just quickly wanted to know beforehand if this happens only to me (or, only 
on macOS?).


Regards,
Bernhard

> On 4. Sep 2017, at 14:16, Maciej Suminski  wrote:
> 
> Hi Bernhard,
> 
> It would be greatly appreciated if you could turn this into a bug
> report. Otherwise it will quickly drown and become forgotten, given the
> ML traffic level.
> 
> Any chance we could get a project that reliably reproduces the problem?
> 
> Regards,
> Orson
> 
> On 09/03/2017 11:24 PM, Bernhard Stegmaier wrote:
>> Hi,
>> 
>> with current version (see below), I am missing arbitrary symbols in eeschema 
>> after startup:
>> (1) Startup KiCad (project manager)
>> (2) Open schematic of last project. This time the graphic lines of two 
>> connectors are missing:
>> 
>> 
>> Close/reopen of eeschema doesn’t help.
>> If I change to a different project and then back to first project (without 
>> restarting KiCad), then the missing symbols are back again.
>> I have seen this also in the official nightly (same version, but with 
>> supported wxWidgets).
>> 
>> Looks like some race-condition in loading symbol libraries?
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> ===
>> 
>> Application: kicad
>> Version: (2017-09-02 revision 1fe91e625)-master, release build
>> Libraries:
>>wxWidgets 3.1.1
>>libcurl/7.54.0 SecureTransport zlib/1.2.8
>> Platform: macOS Sierra Version 10.12.6 (Build 16G29), 64 bit, Little endian, 
>> wxMac
>> Build Info:
>>wxWidgets: 3.1.1 (UTF-8,STL containers)
>>Boost: 1.59.0
>>Curl: 7.55.1
>>Compiler: Clang 8.1.0 with C++ ABI 1002
>> 
>> Build settings:
>>USE_WX_GRAPHICS_CONTEXT=ON
>>USE_WX_OVERLAY=ON
>>KICAD_SCRIPTING=OFF
>>KICAD_SCRIPTING_MODULES=OFF
>>KICAD_SCRIPTING_WXPYTHON=OFF
>>KICAD_SCRIPTING_ACTION_MENU=OFF
>>BUILD_GITHUB_PLUGIN=ON
>>KICAD_USE_OCE=ON
>>KICAD_SPICE=OFF
>> 
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Missing symbol elements in eeschema?

2017-09-04 Thread Maciej Suminski 
Hi Bernhard,

It would be greatly appreciated if you could turn this into a bug
report. Otherwise it will quickly drown and become forgotten, given the
ML traffic level.

Any chance we could get a project that reliably reproduces the problem?

Regards,
Orson

On 09/03/2017 11:24 PM, Bernhard Stegmaier wrote:
> Hi,
> 
> with current version (see below), I am missing arbitrary symbols in eeschema 
> after startup:
> (1) Startup KiCad (project manager)
> (2) Open schematic of last project. This time the graphic lines of two 
> connectors are missing:
> 
> 
> Close/reopen of eeschema doesn’t help.
> If I change to a different project and then back to first project (without 
> restarting KiCad), then the missing symbols are back again.
> I have seen this also in the official nightly (same version, but with 
> supported wxWidgets).
> 
> Looks like some race-condition in loading symbol libraries?
> 
> 
> Regards,
> Bernhard
> 
> ===
> 
> Application: kicad
> Version: (2017-09-02 revision 1fe91e625)-master, release build
> Libraries:
> wxWidgets 3.1.1
> libcurl/7.54.0 SecureTransport zlib/1.2.8
> Platform: macOS Sierra Version 10.12.6 (Build 16G29), 64 bit, Little endian, 
> wxMac
> Build Info:
> wxWidgets: 3.1.1 (UTF-8,STL containers)
> Boost: 1.59.0
> Curl: 7.55.1
> Compiler: Clang 8.1.0 with C++ ABI 1002
> 
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=ON
> USE_WX_OVERLAY=ON
> KICAD_SCRIPTING=OFF
> KICAD_SCRIPTING_MODULES=OFF
> KICAD_SCRIPTING_WXPYTHON=OFF
> KICAD_SCRIPTING_ACTION_MENU=OFF
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_SPICE=OFF
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Symbol library table remapping branch.

2017-09-04 Thread jp charras 
Le 01/09/2017 à 23:09, Wayne Stambaugh a écrit :
> I finally found the time to finish the symbol library table remapping
> implementation and I would like some help with testing before I merge
> this into the master branch.  I would like to get as much testing as
> possible.  I remember the issues when we switched from the same library
> lookup format in Pcbnew so I would like to try to get as many of the
> issues resolved before I merge the changes into the master branch.
> Please back up your schematic files before you load them.  Otherwise you
> will have a bunch of broken symbol library links in schematic since all
> of the symbols names will now be in the new format
> (LIB_NICKNAME:SYMBOL_NAME).  Also, please don't generate any external
> files such as netlists with the remapped symbol names.  I haven't tested
> any of that yet.  I am just trying to get the remapping as accurate as
> possible.  The branch can be found in my dev repo at:
> 

Good news, Wayne.

I tested this branch and I encountered 2 issues.

1 - The remap dialog creates a suitable project symbol library table from the 
current .pro file, but
the project symbol library table is not loaded by eeschema (the symbol library 
table config dialog
always shows an empty project symbol library table, regardless the content of 
this table).
As a consequence, symbols in a project library are not remapped (this is the 
more annoying issue).

2 - if (inside Eeschema) I add a symbol lib in the project symbol library 
table, this library is
shown in the symbol library browser (which is good), but if I try to select it, 
Eeschema crashed or
shows a message saying a non handled exception happened (depending on the phase 
of the moon).


I did not made a lot of tests, but symbols found in the libraries listed in 
global symbol library
table are found and correctly remapped.

Thanks for your hard work.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-09-04 Thread Kristoffer Ödmark 
I beleive the two latest patches will benefit most people. the automatic 
select from same sheet will actaully hang kicad for a brief moment. This 
is very noticeable on larger PCBs, not so much on smaller. Adding the 
select feature as a context menu is more correct.


The more aggressive selection behaviour is really just an improvement to 
the current sheet selection.


I kindly ask that someone commit this before v5.

- Kristoffer

On 08/19/2017 04:10 PM, Kristoffer Ödmark wrote:

bump

On 08/07/2017 05:19 PM, Kristoffer Ödmark wrote:
I added a logo for the context menu. This context menu also has the 
added benefit of making the "select on same sheet" feature more 
visible to a user, also it doesnt freeze kicad when you happen to 
click on a sub-schematic


I attach both patches in this mail.

- Kristoffer

On 07/24/2017 10:03 PM, Kristoffer Ödmark wrote:
After suggestions from chris, I deactivated the "select all items on 
sheet" on left-click inside eeschema, and instead added a context 
menu for it when rightclicking on a sheet in eeschema.


This is a separate patch to the sheet-selection improvement. I do not 
know how to generate a icon for this menu entry, so right now I am 
reusing an already existing one.


- Kristoffer

On 07/24/2017 10:19 AM, Kristoffer Ödmark wrote:

Hmm, I was planning to send that mail to the ML. will resend it there.

I am unsure about the separate tool. Most circuits I am using this 
on is instant, but I guess that doing both could be a viable option. 
The tool is available as a separate tool from pcbnew.


On 07/24/2017 04:50 AM, Chris Pavlina wrote:

What about a slightly different approach? Don't do this on a
single-click on sheet, make it a separate tool. That way it just 
doesn't

happen accidentally. And give some feedback when it does run by
displaying a progress dialog.

On Mon, Jul 24, 2017 at 12:53:43AM +0200, Kristoffer Ödmark wrote:

Thank you for testing this!

I was not aware of the large pcb problem, and this actually raises a
question of having a large "demo" project to test stuff on. Since 
I guess
many do like me and actually do many of the tests on the demo 
projects.


Also, I am thinking of adding a setting to be able to disable the 
automatic
cross-probing for this since I think that getting the speed up 
will not
really be easy without some major refactor. Any tips and thoughts 
for that?


- Kristoffer


On 07/24/2017 12:19 AM, Chris Pavlina wrote:
I like this change, and I was about to push it and suggest we can 
add
any suggested changes others have later, when I decided to test 
it on a

large project.

It's REALLY slow now. If I click on a sheet, KiCad freezes for a 
solid
ten seconds in my larger test project. IMO that isn't acceptable, 
it's

too easy to do accidentally and way too annoying when it happens.

On Mon, Jul 17, 2017 at 03:00:58PM +0200, Kristoffer Ödmark wrote:
I fixed up some of the code violations I could see, and applied 
the patch to

current master, where the sheet selection is working once again.

- Kristoffer

On 07/12/2017 10:01 PM, Kristoffer Ödmark wrote:

The last working revision I copuld test was:
2c21c70f46dd3ef444ac4a909434697cce972f4a

Right before the new connectivty algorithm.

After that the sheet-selection is not working anymore. So It 
would be

nice if you could file a bug report on it :)

- Kristoffer

On 2017-07-12 13:33, Kristoffer Ödmark wrote:

No worries!

As an example, If i layout a group of components, all which 
require
the powerpaths as in they need acess to 3v3 lines that are 
used in

other areas of the board as well. These 3v3 lines might be a bit
annoying to route for certain cases.

As the code is now, since these 3v3 lines are used as an outside
connection of the sheet, they will be ignored, even if they only
connect
between pads on the same subschematic. Say that the connection to
the global 3v3 net is handled later with a via or something like
that.

The same logic applies to all pins that connect outside the 
block,

and in some cases the layout of the blocks have a non-trivial
routing to get the signal out of the block "area", which is 
what i
noticed when using these. Hope this explanation made it more 
clear


With this more aggressive change. It is also more visible from 
the

pcb side to where this "block" has dependencies, I also find it
easier to deselect segments manually, than to select them if the
block is not very trivial.

Regarding the code violations, I will have a look later when I 
get

the time as well.

the GND thing must indeed be a bug, which I will look into as 
well.


On 07/12/2017 10:30 AM, Maciej Sumiński wrote:

Hi Kristoffer,

I apologize for such a long delay. Finally I had to time to 
look at the
patch. I tried it out with a few boards, but I could not 
really notice a
difference. I read the code and I think I understand what are 
you trying
to do, but are you sure it is the right way to go? 
Hierarchical sheets
are frequently used as