Re: [Kicad-developers] Add links to library contributor page(s) on GitHub
Wayne, Ah, dropped the wxT. I have fixed it in the attached patch. Thanks, On Tue, Dec 12, 2017 at 3:36 AM, Wayne Stambaugh wrote: > Oliver, > > I see you noticed that I added a place holder for library devs. I was > going to ask you for a list of contributors but I like you solution > better. That being said, there is a problem with your patch on windows > (see attached image). > > Cheers, > > Wayne > > On 12/11/2017 9:02 AM, Oliver Walters wrote: > > The attached patch adds links to the library contributor pages, which > > list all the contributors to the various library repositories: > > > > Previously the symbols and footprints were attributed to "Leet hacker1" > > and her associate "Leet hacker2". While I am sure they have made > > valuable contributions, I think their time has come. > > > > Inline image 1 > > > > > > Wayne: I would like to reiterate that Christophe and Renie have not made > > contributions to the _current_ 3D model repository which has been > > completely remastered thanks to the great efforts of Maurice et al. It > > has _no_ resemblance to the old hodge-podge of model files, it's a real > > credit to the work of the modeling team > > > > I think here (unlike the icons credits) it would be sufficient to just > > link to the GitHub contributors page - would you agree? > > > > Thanks, > > Oliver > > > > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > From d1eec5b40dc1a3684af70e24e0de071bd0260779 Mon Sep 17 00:00:00 2001 From: Oliver Date: Tue, 12 Dec 2017 00:56:32 +1100 Subject: [PATCH] Add links to list of library contributors on GitHub - Apologies to "leet hackers" - Add URL option to contributor entity --- common/dialog_about/AboutDialog_main.cpp | 43 ++-- common/dialog_about/aboutinfo.h | 4 +++ common/dialog_about/dialog_about.cpp | 29 - 3 files changed, 68 insertions(+), 8 deletions(-) diff --git a/common/dialog_about/AboutDialog_main.cpp b/common/dialog_about/AboutDialog_main.cpp index d259962..2c362f4 100644 --- a/common/dialog_about/AboutDialog_main.cpp +++ b/common/dialog_about/AboutDialog_main.cpp @@ -254,94 +254,117 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf */ aInfo.AddTranslator( new CONTRIBUTOR( "Robert Buj", wxEmptyString, + wxEmptyString, "Catalan (CA)", KiBitmapNew( lang_catalan_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( wxT( "Martin Kratoška" ), wxEmptyString, + wxEmptyString, "Czech (CZ)", KiBitmapNew( lang_cs_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( "Jerry Jacobs", wxEmptyString, + wxEmptyString, "Dutch (NL)", KiBitmapNew( lang_nl_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( "Vesa Solonen", wxEmptyString, + wxEmptyString, "Finnish (FI)", KiBitmapNew( lang_fi_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( "Jean-Pierre Charras", wxEmptyString, + wxEmptyString, "French (FR)", KiBitmapNew( lang_fr_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( wxT( "Mateusz Skowroński" ), wxEmptyString, + wxEmptyString, "Polish (PL)", KiBitmapNew( lang_pl_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTOR( "Kerusey Karyu", wxEmptyString, + wxEmptyString, "Polish (PL)", KiBitmapNew( lang_pl_xpm ) ) ); aInfo.AddTranslator( new CONTRIBUTO
Re: [Kicad-developers] Getting patches committed
Hey Jeff, The preferred method is for you to use git and committing your changes to your local repo (all commits in git are local) then using `git format-patch` to submit your patches. Using `git format-patch` eliminates the need for busy lead developers from having to enter your author information and writing a commit message in order to merge your patch. I haven't looked at your patches but if you are not aware, kicad has both a coding stype policy[1] and a commit message policy[2]. Following both these will goe a long way to getting you patches merged. The other thing that helps is patience. All of the kicad lead developers are part time, volunteers, or both so they are typically busy and not always able to review patches in as timely a manner as we would like. Cheers, Wayne [1]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html [2]: http://docs.kicad-pcb.org/doxygen/commit_messages.html On 12/11/2017 12:45 PM, Jeff Young wrote: > Hi guys and gals, > > I’ve logged a few bugs that affect me and developed fixes for some of > them[1]. After decades of svn and then a few years of retirement I don’t > trust my git skills so I added the fixes as patches. What’s the process for > getting them reviewed and committed? > > Thanks, > Jeff. > > [1] > https://bugs.launchpad.net/kicad/+bug/1737010 > https://bugs.launchpad.net/kicad/+bug/1737562 > https://bugs.launchpad.net/kicad/+bug/1736836 > https://bugs.launchpad.net/kicad/+bug/1715440 > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting patches committed
Hi Jeff, Thanks for your patches! You've already done the right thing - KiCad uses a somewhat old-fashioned flow so submitting patches directly like that is the norm. I'll just take a little while for them to be reviewed. If you have patches that add features rather than fixing bugs, you can submit them directly here instead - for future reference, that is (we're in feature freeze right now). -- Chris On Mon, Dec 11, 2017 at 05:45:48PM +, Jeff Young wrote: > Hi guys and gals, > > I’ve logged a few bugs that affect me and developed fixes for some of > them[1]. After decades of svn and then a few years of retirement I don’t > trust my git skills so I added the fixes as patches. What’s the process for > getting them reviewed and committed? > > Thanks, > Jeff. > > [1] > https://bugs.launchpad.net/kicad/+bug/1737010 > https://bugs.launchpad.net/kicad/+bug/1737562 > https://bugs.launchpad.net/kicad/+bug/1736836 > https://bugs.launchpad.net/kicad/+bug/1715440 > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Getting patches committed
Hi guys and gals, I’ve logged a few bugs that affect me and developed fixes for some of them[1]. After decades of svn and then a few years of retirement I don’t trust my git skills so I added the fixes as patches. What’s the process for getting them reviewed and committed? Thanks, Jeff. [1] https://bugs.launchpad.net/kicad/+bug/1737010 https://bugs.launchpad.net/kicad/+bug/1737562 https://bugs.launchpad.net/kicad/+bug/1736836 https://bugs.launchpad.net/kicad/+bug/1715440 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Add links to library contributor page(s) on GitHub
Oliver, I see you noticed that I added a place holder for library devs. I was going to ask you for a list of contributors but I like you solution better. That being said, there is a problem with your patch on windows (see attached image). Cheers, Wayne On 12/11/2017 9:02 AM, Oliver Walters wrote: > The attached patch adds links to the library contributor pages, which > list all the contributors to the various library repositories: > > Previously the symbols and footprints were attributed to "Leet hacker1" > and her associate "Leet hacker2". While I am sure they have made > valuable contributions, I think their time has come. > > Inline image 1 > > > Wayne: I would like to reiterate that Christophe and Renie have not made > contributions to the _current_ 3D model repository which has been > completely remastered thanks to the great efforts of Maurice et al. It > has _no_ resemblance to the old hodge-podge of model files, it's a real > credit to the work of the modeling team > > I think here (unlike the icons credits) it would be sufficient to just > link to the GitHub contributors page - would you agree? > > Thanks, > Oliver > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Joining buses with junctions behavior
And if they are both an option, should bus-to-bus junctions have this same behavior or joining two buses with different labels? On Mon, Dec 11, 2017 at 8:12 AM, Maciej Sumiński wrote: > It poses a question then: are the bus-to-bus entries ever used? > > Regards, > Orson > > On 12/10/2017 08:12 PM, Seth Hillbrand wrote: > > Jon- > > > > Thanks for catching this discrepancy. I had written the logic such that > > busses connect to other busses by a bus-to-bus entry. But clearly, that > is > > historically not accurate and there needs to be a junction. > > > > -S > > > > On Sun, Dec 10, 2017 at 8:09 AM, Jon Evans wrote: > > > >> Hi all, > >> > >> As I am working on bus features I have dived into all the ways you can > use > >> buses (that I haven't always known about myself). > >> > >> One thing I noticed was an example given on the docs: > >> http://docs.kicad-pcb.org/stable/en/eeschema.html#wires- > >> buses-labels-power-ports > >> > >> Under "Global connections between buses", you have three different named > >> bus segments joined together with a junction, and a description of how > >> their nets will be connected during netlisting. > >> > >> a) This behavior seems to be kind of broken at present -- when I try to > >> replicate it, the junction is sometimes automatically removed, and the > >> netlist does not join all of the nets as described in the manual (maybe > >> related to Seth's recent changes?) > >> > >> b) Those of you who use this feature: how do you use it? Do you care > that > >> the final netlist arbitrarily picks one of the possible net names? > >> > >> Thanks, > >> > >> -Jon > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > >> > > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Joining buses with junctions behavior
It poses a question then: are the bus-to-bus entries ever used? Regards, Orson On 12/10/2017 08:12 PM, Seth Hillbrand wrote: > Jon- > > Thanks for catching this discrepancy. I had written the logic such that > busses connect to other busses by a bus-to-bus entry. But clearly, that is > historically not accurate and there needs to be a junction. > > -S > > On Sun, Dec 10, 2017 at 8:09 AM, Jon Evans wrote: > >> Hi all, >> >> As I am working on bus features I have dived into all the ways you can use >> buses (that I haven't always known about myself). >> >> One thing I noticed was an example given on the docs: >> http://docs.kicad-pcb.org/stable/en/eeschema.html#wires- >> buses-labels-power-ports >> >> Under "Global connections between buses", you have three different named >> bus segments joined together with a junction, and a description of how >> their nets will be connected during netlisting. >> >> a) This behavior seems to be kind of broken at present -- when I try to >> replicate it, the junction is sometimes automatically removed, and the >> netlist does not join all of the nets as described in the manual (maybe >> related to Seth's recent changes?) >> >> b) Those of you who use this feature: how do you use it? Do you care that >> the final netlist arbitrarily picks one of the possible net names? >> >> Thanks, >> >> -Jon >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu
I tested the patch on Linux and it works as advertised. Well done, we need the same thing for GAL too. Cheers, Orson On 12/06/2017 07:05 PM, Seth Hillbrand wrote: > The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020 > > The current double-click handler in draw_panel gets overridden by the > disambiguation menu, preventing double-clicks from being properly handled. > This patch introduces a delay between the mouse up and handling the > single-click. If the double-click arrives in this time, the double-click > is handled. Otherwise, the normal single-click is processed. > > Of note, we only introduce this delay in cases where the disambiguation > menu is needed. Otherwise, single-clicks are immediately processed. > > Tested on MacOS and Linux. The current delay is set to 250ms. We might > slow this down to 400-500ms but that felt a bit clunky to me. > > -Seth > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] macOS 3d-viewer improvements
Hi, Attached patches improve 3d-viewer on macOS a bit. Patches (1)+(2) add Retina support to 3d-viewer just like it was already there for GAL canvas. I pulled out all the ugly #ifdef stuff into a new base class, so now all Retina related code for GAL and 3d-viewer is in one class. I put it into the gal folder… if you think it shouldn’t be there, please move it to a better spot or tell me where to put it. Patch (3) is only a cleanup wrt pinch-to-zoom and enables pinch-to-zoom again when using newer wxWidgets. Tested only on macOS, shouldn’t have any impact on other platforms. Regards, Bernhard 0001-Create-HIDPI_GL_CANVAS-wrapper-for-transparent-wxGLC.patch Description: Binary data 0002-Merge-HIDPI_GL_CANVAS-wrapper-with-OPENGL_GAL-implem.patch Description: Binary data 0003-Fix-macOS-pinch-to-zoom-for-3d-viewer.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] macOS & New Zone Filling?
Hi Bernhard, If you have time and interest, would you test my zone filling, does it work in mac. It may help to find out progress freezing. https://github.com/heikkipu/kicad-devel Regards Heikki On Mon, Dec 11, 2017 at 11:25 AM, Bernhard Stegmaier < stegma...@sw-systems.de> wrote: > Hi Tom, > > Sorry for the delay… no, doesn’t fix it. > Just hangs in the progress dialog at zero progress/time, no way to close > it. > > > Regards, > Bernhard > > > On 9. Dec 2017, at 20:13, Tomasz Wlostowski > wrote: > > > > On 09/12/17 18:30, Seth Hillbrand wrote: > >> Tom- > >> > >> I can confirm that this fixes the issue for me on MacOS 10.13 > >> > > > > Hi Seth & Bernhard, > > > > Could you try the attached patch? > > > > Tom, in the process of getting a macintosh... > > <0001-WX_PROGRESS_REPORTER-possible-fix-for-freeze-on-OSX.patch> > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] New records with zone filling.
Hi, With interest, I try to improve my parallel zone filling. And new records are: Olinuxino A64 board. My parallel zone filling with new connectivity algo 4s. My parallel zone filling with old connectivity algo 6s. Current master 13s. WRS board. My parallel zone filling with new connectivity algo 12s. My parallel zone filling with old connectivity algo 2min 37s. Old ratsnest calculation spend so much time at this board. Current master 1 min 47s. Olinuxino A64 board with fully teardrops, stitch vias and rounded track corners inserted. My parallel zone filling with new connectivity algo 2min 16s. My parallel zone filling with old connectivity algo 2min 27s. Current master 3min 45s. Records are to be broken. Other things... that was the question. Regards Heikki ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Reduction of Polygon Complexity
Dear Kicad developers,
when looking at the polygons generated by converting all copper layers
to polygons, I found some very small segments. I further investigated
these segments and the reason was that zones are inflated by adding
segments with rounded ends to their boundary. The rounded ends are
segmented into a specified number of segments. This was not aligned.
Often, two of these half-circles lye on each other and are bool-added
afterwards. This creates these small segments.
Find attached some code which aligns the segmentation. With the change,
circles are always segmented the same way and two circles with same
center and same radius have the same vertices in the generated polygon.
Generating all polygons for all copper layers of the Olimex A64 board
resulted in 415312 vertices before. With this patch applied, this number
goes down to 280378 vertices.
I hope you like it. Source code is clang-format-ed :-).
Cheers,
Andreas
From f138235f2b768b1749572a4bb7e66f8e8e36a748 Mon Sep 17 00:00:00 2001
From: Andreas Buhr
Date: Mon, 11 Dec 2017 11:03:41 +0100
Subject: [PATCH] always align segmentation of circles
Rounded end segments were converted to a polygon using
a specified "aCircleToSegmentCount". But the segmentation
was not aligned to be 0 degree, delta degree, 2*delta degree etc,
but it was aligned with the angle of the segment.
Often, two rounded segment ends are joined (boolAdd).
Because their segmentation did not align, this resulted
in more segments than necessary and sometimes very small segments.
This commit changes this behavior to create aligned
segmentations. This reduces the number of vertices in the generated
polygons substantially.
---
common/convert_basic_shapes_to_polygon.cpp | 71 --
1 file changed, 47 insertions(+), 24 deletions(-)
diff --git a/common/convert_basic_shapes_to_polygon.cpp b/common/convert_basic_shapes_to_polygon.cpp
index f2efe03..0c42263 100644
--- a/common/convert_basic_shapes_to_polygon.cpp
+++ b/common/convert_basic_shapes_to_polygon.cpp
@@ -149,59 +149,82 @@ void TransformRoundRectToPolygon( SHAPE_POLY_SET& aCornerBuffer,
* Note: the polygon is inside the arc ends, so if you want to have the polygon
* outside the circle, you should give aStart and aEnd calculated with a correction factor
*/
-void TransformRoundedEndsSegmentToPolygon( SHAPE_POLY_SET& aCornerBuffer,
- wxPoint aStart, wxPoint aEnd,
- int aCircleToSegmentsCount,
- int aWidth )
+void TransformRoundedEndsSegmentToPolygon( SHAPE_POLY_SET& aCornerBuffer, wxPoint aStart,
+wxPoint aEnd, int aCircleToSegmentsCount, int aWidth )
{
-int radius = aWidth / 2;
-wxPoint endp= aEnd - aStart; // end point coordinate for the same segment starting at (0,0)
-wxPoint startp = aStart;
-wxPoint corner;
+int radius = aWidth / 2;
+wxPoint direction =
+aEnd - aStart; // end point coordinate for the same segment starting at (0,0)
+wxPoint startp = aStart;
+wxPoint endp = aEnd;
+wxPoint corner;
VECTOR2I polypoint;
aCornerBuffer.NewOutline();
// normalize the position in order to have endp.x >= 0;
-if( endp.x < 0 )
+if( direction.x < 0 )
{
-endp= aStart - aEnd;
-startp = aEnd;
+direction = aStart - aEnd;
+startp = aEnd;
+endp = aStart;
}
-double delta_angle = ArcTangente( endp.y, endp.x ); // delta_angle is in 0.1 degrees
-int seg_len= KiROUND( EuclideanNorm( endp ) );
+double delta_angle = ArcTangente( direction.y, direction.x ); // delta_angle is in 0.1 degrees
-int delta = 3600 / aCircleToSegmentsCount;// rot angle in 0.1 degree
+int delta = 3600 / aCircleToSegmentsCount; // rot angle in 0.1 degree
// Compute the outlines of the segment, and creates a polygon
// add right rounded end:
-for( int ii = 0; ii < 1800; ii += delta )
+
+// Start arc:
+corner = wxPoint( 0, radius );
+RotatePoint( &corner, -delta_angle );
+corner += endp;
+polypoint.x = corner.x;
+polypoint.y = corner.y;
+aCornerBuffer.Append( polypoint.x, polypoint.y );
+
+int ii = int( delta_angle ) % delta;
+if( ii <= 0 )
+ii += delta;
+for( ; ii < 1800; ii += delta )
{
+assert( ( ii - int( delta_angle ) ) % delta == 0 );
corner = wxPoint( 0, radius );
-RotatePoint( &corner, ii );
-corner.x += seg_len;
-RotatePoint( &corner, -delta_angle );
-corner += startp;
+RotatePoint( &corner, ii - int( delta_angle ) );
+corner += endp;
polypoint.x = corner.x;
polypoint.y = corner.y;
aCornerBuffer.Append( polypoint.x, polypoint.y );
}
// Finish arc:
-corner = wxPoint( seg_len, -radius );
+corner = wxPoint( 0, -radius );
RotatePoint( &corner, -d
Re: [Kicad-developers] macOS & New Zone Filling?
I applied this workaround for OSX builds. It is better not to have a
progress dialog rather than freeze on zone refill. It is a temporary
change until we get the hardware where we can debug the problem properly.
Regards,
Orson
On 12/09/2017 03:56 AM, Tomasz Wlostowski wrote:
> On 09/12/17 01:33, Bernhard Stegmaier wrote:
>> Some sites say that.
>> I tried to manually compile a test program from one of those, but my
>> clang doesn’t even recognise -fopenmp.
>> The other thing mentioned is clang-omp, but that seems not to be
>> maintained any longer.
>> Didn’t try further…
>
> Hi Bernhard,
>
> Could you try this:
>
> in zone_filler.cpp, after lines 92-93:
>
> void ZONE_FILLER::Fill( std::vector aZones )
> {
>
> put:
> m_progressReporter = nullptr;
>
> recompile and try filling zones to check if it still freezes.
>
> Tom
>
>>
>>
>> Regards,
>> Bernhard
>>
>>> On 8. Dec 2017, at 16:50, Simon Wells >> > wrote:
>>>
>>> I thought it did if you can find the right lib as it was only the lib
>>> that was missing?
>>>
On 9/12/2017, at 3:48 AM, Bernhard Stegmaier >>> > wrote:
… I looked around a bit and from that it seems to be pretty sure that
stock Xcode Apple clang (which I use) doesn’t support OpenMP.
Regards,
Bernhard
> On 8. Dec 2017, at 14:05, Bernhard Stegmaier
> mailto:stegma...@sw-systems.de>> wrote:
>
> Hi Tom,
>
>> On 8. Dec 2017, at 13:59, Tomasz Wlostowski
>> mailto:tomasz.wlostow...@cern.ch>> wrote:
>>
>> Wonderful.
>>
>> I thought a workaround for Windows OpenMP/wxWidgets support will be
>> sufficient. Time to get a macbook...
>>
>> Bernard, could you try building kicad with OpenMP disabled?
>
> Hmm… how do I do this?
>
> I get from cmake
> <<<
> …
> -- Performing Test COMPILER_SUPPORTS_WSUGGEST_OVERRIDE
> -- Performing Test COMPILER_SUPPORTS_WSUGGEST_OVERRIDE - Failed
> -- Performing Test COMPILER_SUPPORTS_WSHADOW
> -- Performing Test COMPILER_SUPPORTS_WSHADOW - Success
> -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS
> OpenMP_C_LIB_NAMES) (found version "1.0")
> -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS
> OpenMP_CXX_LIB_NAMES) (found version "1.0")
> -- Found wxWidgets:
> -L/Volumes/OSXData/bstegmaier/KiCad/wx-master/lib;;;-framework
> IOKit;-framework Carbon;-framework Co
> …
>
> So I always thought it doesn’t use OpenMP?
>
>
> Regards,
> Bernhard
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
>>>
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::drawPolygon did not respect fill settings
Great, I pushed your patch to the master branch. Thank you for your
contribution.
The line:
+if(isFillEnabled){
should look like:
+if( isFillEnabled )
+{
As I said, nothing I could not fix myself. I realize switching between
projects with different code formatting is not easy, but perhaps you may
find useful either uncrustify or clang-format - we provide configuration
files for both (uncrustify.cfg and _clang-format in the root directory).
Cheers,
Orson
On 12/11/2017 10:20 AM, Andreas Buhr wrote:
> On 12/11/2017 10:11 AM, Maciej Sumiński wrote:
>>
>> There is a minor code formatting violation, that I will fix. I suppose
>> that unfilled polygons have not been used so far, therefore the issue
>> could not be observed. If you use them, can you confirm the behavior is
>> coherent with the cairo backend?
>
> Hello Orson,
>
> thanks a lot.
> What was the formatting violation? I'll try to format my coming patches
> better.
>
> The behavior is coherent with the cairo backend, i.e. the cairo backend
> fills correctly.
>
> Cheers,
> aDnreas
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] macOS & New Zone Filling?
Hi Tom, Sorry for the delay… no, doesn’t fix it. Just hangs in the progress dialog at zero progress/time, no way to close it. Regards, Bernhard > On 9. Dec 2017, at 20:13, Tomasz Wlostowski wrote: > > On 09/12/17 18:30, Seth Hillbrand wrote: >> Tom- >> >> I can confirm that this fixes the issue for me on MacOS 10.13 >> > > Hi Seth & Bernhard, > > Could you try the attached patch? > > Tom, in the process of getting a macintosh... > <0001-WX_PROGRESS_REPORTER-possible-fix-for-freeze-on-OSX.patch> ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::drawPolygon did not respect fill settings
On 12/11/2017 10:11 AM, Maciej Sumiński wrote: > > There is a minor code formatting violation, that I will fix. I suppose > that unfilled polygons have not been used so far, therefore the issue > could not be observed. If you use them, can you confirm the behavior is > coherent with the cairo backend? Hello Orson, thanks a lot. What was the formatting violation? I'll try to format my coming patches better. The behavior is coherent with the cairo backend, i.e. the cairo backend fills correctly. Cheers, aDnreas ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::drawPolygon did not respect fill settings
Andreas, There is a minor code formatting violation, that I will fix. I suppose that unfilled polygons have not been used so far, therefore the issue could not be observed. If you use them, can you confirm the behavior is coherent with the cairo backend? Cheers, Orson On 12/08/2017 12:53 PM, Andreas Buhr wrote: > Dear Kicad developers, > > The OPENGL_GAL::drawPolygon function and all functions using it > did not respect the isFillEnabled member set by > GAL::SetIsFill. This is fixed by the attached patch. > > I hope you find it useful. > Cheers, > Andreas > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Bugfix: EDA_RECT to BOX2I generated wrong boxes
Hi Andreas, Good catch, it must have been like this since the GAL origin. I have applied your patch to the master branch. Thank you! Cheers, Orson On 12/10/2017 11:08 PM, Andreas Buhr wrote: > Dear Kicad developers, > > The "operator BOX2I() const" of EDA_RECT produced wrong boxes, usually > much to big. It passed its end-position as second argument to the > constructor of BOX2I. However, BOX2I expects its size as second > argument. > > This caused a dramatic performance penalty in some > cases. Took me about a day to figure this out. > > Cheers, > Andreas > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use explicit shift in hotkeys instead of mixed-case characters
For the record, the patch has been already pushed. Thank you Jon! Regards, Orson On 12/09/2017 07:37 PM, Jon Evans wrote: > A minor fix due to how wxWidgets parses menu items. > > Fixes: https://bugs.launchpad.net/kicad/+bug/1737303 > > -Jon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Fix AlignLeft / AlignRight when using Flip Board view
Hi Jon, Thank you for the patch, I have pushed it to the master branch. Regards, Orson On 12/09/2017 08:18 PM, Jon Evans wrote: > Hi all, > > This is a "band-aid" patch for this bug: > https://bugs.launchpad.net/kicad/+bug/1734377 > > When flip board view is active, item bounding boxes are not flipped. So, > any tools that rely on the bounding boxes may have undesired behavior. We > should probably think about how we actually want this to work, i.e. maybe > having a separate "view coordinate system" and "edit coordinate system" so > that the tools don't have to worry about whether or not the view is > mirrored. > > -Jon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
