date:20180312

+Michael

This looks like "clever" code so I can't tell if this is a bug or not
without running through a bunch of test cases which I'm not going to do
right now.
Do you see any issues with the operation of the code, Mark, or just the
warning?

-Jon

On Mon, Mar 12, 2018 at 9:28 PM, Mark Roszko  wrote:

> Not sure where to even begin looking at libeval since it looks scary but
> MSVC complains:
>
> D:\kicad-source-mirror\common\libeval\numeric_evaluator.cpp(216): warning
> C4805: '==': unsafe mix of type 'char' and type 'bool' in operation
>
> which is:
>
>   auto ch = clToken.input[clToken.pos];
>   do {
>  if (ch == isDecSep(ch) && sepCount) break;
>
>
> ch is a char
>
> isDecSep returns bool
>
> char == bool?
>
>
>
> --
> Mark
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] bug in numeric_evaluator?

Not sure where to even begin looking at libeval since it looks scary but
MSVC complains:

D:\kicad-source-mirror\common\libeval\numeric_evaluator.cpp(216): warning
C4805: '==': unsafe mix of type 'char' and type 'bool' in operation

which is:

  auto ch = clToken.input[clToken.pos];
  do {
 if (ch == isDecSep(ch) && sepCount) break;


ch is a char

isDecSep returns bool

char == bool?



-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Kevin Cozens


On 2018-03-12 05:03 PM, Jeff Young wrote:

Well, my build is still running so I canâ€™t confirm the fixes yet, but since I 
already broke the build for some I went ahead and pushed â€œfixesâ€.


My build with latest hash code of f32f14dc8 completed without error.

--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

nick, use the attached patched on kicad :3

Under vcpkg, wxwidgets is put into a unix like dependency tree meanwhile
the wxwidgets script assumes crazy prefixed distributed by wx scheme.

With this it'll at least find the right path.

If you are using VS2017, here's a sample CMakeSettings.Json


Just need to resolve some link errors now

On Mon, Mar 12, 2018 at 7:02 PM, Nick Østergaard  wrote:

> I can't make cmake find wxwidgets from vcpkg. I think Thomas Figueroa also
> uses vcpkg, but he built wxwidgets himself to overcome this. So I think
> something is missing for wxwidgets in vcpkg, or something else is not quite
> right in that corner.
>
> 2018-03-12 23:36 GMT+01:00 Mark Roszko :
>
>> Wayne,
>>
>> Long term there is good news, VCPKG exists. https://github.com/Mic
>> rosoft/vcpkg  right now its separate but eventually it'll be part of VS.
>> (But it works now).
>>
>> It's like msysbut for MSVC and it builds packages locally and puts
>> them in a central store. I think most of  Kicad's depedencies are there, I
>> actually started to work on seeing if Kicad would compile with it but
>> didn't get far before being distracted.
>>
>>
>> On Mon, Mar 12, 2018 at 5:33 PM, Wayne Stambaugh 
>> wrote:
>>
>>> Tom,
>>>
>>> I would prefer KiCad not be in the business of providing dependency
>>> binaries.  I can't stop anyone from providing them but I would rather
>>> developers focus on kicad development rather than our dependencies as
>>> much as possible.  The whole point of removing all of the dependency
>>> build code from v4 was specifically for this reason.  The amount of time
>>> we were spending supporting this was significant.  I would prefer that
>>> the projects provide their own binary installers or we do a better job
>>> of choosing dependencies.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> On 03/12/2018 04:18 PM, Tomasz Wlostowski wrote:
>>> > On 12/03/18 19:10, Wayne Stambaugh wrote:
>>> >>  The context switching build
>>> >> issue will most likely have to be fixed yet again if we choose to go
>>> >> down this path.
>>> >
>>> > Wayne,
>>> >
>>> > One of the things that Windows does remarkably well is binary
>>> > compatibility. We can just provide pre-built libcontext binaries (as
>>> > well as binaries of every other dependency for Kicad), say, once a
>>> year,
>>> > and with a very high probability they will work on every Windows box
>>> out
>>> > there. I wouldn't worry much about libcontext, I'm more worried about
>>> > code that MSVC might not like in Kicad - but as Mark & Jon reported,
>>> > newer MSVC versions have fixed such interoperability issues, so I hope
>>> > things will go smoothly. Simon has been running MSVC builds for a
>>> while,
>>> > so he's likely more up-to-date than me in MSVC compatibility.
>>> >
>>> > Tom
>>> >
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> --
>> Mark
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


-- 
Mark


0001-Add-exception-for-vcpkg-search-of-package.patch
Description: Binary data


CMakeSettings.json
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Volunteer

That's a good point, I think we should all try to be better about assigning
ourselves to things on launchpad so that people don't accidentally work on
the same thing!

Jon

On Mon, Mar 12, 2018, 19:48 hauptmech  wrote:

> Thanks, at first glance it looked like the work there was fast and furious
> with devs working on bugs without formally grabbing the assignment, so I
> was afraid of stepping on toes.
>
> On 13/03/18 11:59, Nick Østergaard wrote:
>
> If you have a hard time to find a bug worth looking at, you could probably
> have a look at https://launchpad.net/kicad/+milestone/5.0.0-rc2  and pick
> one where no one is assigned.
>
> 2018-03-12 23:38 GMT+01:00 Jeff Young :
>
>> I threw one your way, but it would also be handy to know what platform
>> you’re on, as some of them are platform-specific.
>>
>> Cheers,
>> Jeff.
>>
>>
>> > On 12 Mar 2018, at 22:07, hauptmech  wrote:
>> >
>> > I'm able to do some work on v5-rc bugs. I'm reasonably familiar with
>> all corners of the code. Bugs where the desired results are clear from the
>> bug discussion are probably best. Just assign them to me on launchpad and
>> I'll get to work.
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Volunteer

2018-03-12 Thread hauptmech

Thanks, at first glance it looked like the work there was fast and 
furious with devs working on bugs without formally grabbing the 
assignment, so I was afraid of stepping on toes.

On 13/03/18 11:59, Nick Østergaard wrote:
If you have a hard time to find a bug worth looking at, you could 
probably have a look at 
https://launchpad.net/kicad/+milestone/5.0.0-rc2 and pick one where no 
one is assigned.

2018-03-12 23:38 GMT+01:00 Jeff Young >:

I threw one your way, but it would also be handy to know what
platform you’re on, as some of them are platform-specific.

Cheers,
Jeff.

> On 12 Mar 2018, at 22:07, hauptmech > wrote:
>
> I'm able to do some work on v5-rc bugs. I'm reasonably familiar
with all corners of the code. Bugs where the desired results are
clear from the bug discussion are probably best. Just assign them
to me on launchpad and I'll get to work.
> ___
> Mailing list: https://launchpad.net/~kicad-developers

> Post to     : kicad-developers@lists.launchpad.net

> Unsubscribe : https://launchpad.net/~kicad-developers

> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

The findwxwidgets script in kicad is screwy, it can't even find wxwidgets
in msys2 if I invoke Msys2 via a secondary terminal/application (i.e. using
msys2 as a toolchain rather than shell directly).

On Mon, Mar 12, 2018 at 7:02 PM, Nick Østergaard  wrote:

> I can't make cmake find wxwidgets from vcpkg. I think Thomas Figueroa also
> uses vcpkg, but he built wxwidgets himself to overcome this. So I think
> something is missing for wxwidgets in vcpkg, or something else is not quite
> right in that corner.
>
> 2018-03-12 23:36 GMT+01:00 Mark Roszko :
>
>> Wayne,
>>
>> Long term there is good news, VCPKG exists. https://github.com/Mic
>> rosoft/vcpkg  right now its separate but eventually it'll be part of VS.
>> (But it works now).
>>
>> It's like msysbut for MSVC and it builds packages locally and puts
>> them in a central store. I think most of  Kicad's depedencies are there, I
>> actually started to work on seeing if Kicad would compile with it but
>> didn't get far before being distracted.
>>
>>
>> On Mon, Mar 12, 2018 at 5:33 PM, Wayne Stambaugh 
>> wrote:
>>
>>> Tom,
>>>
>>> I would prefer KiCad not be in the business of providing dependency
>>> binaries.  I can't stop anyone from providing them but I would rather
>>> developers focus on kicad development rather than our dependencies as
>>> much as possible.  The whole point of removing all of the dependency
>>> build code from v4 was specifically for this reason.  The amount of time
>>> we were spending supporting this was significant.  I would prefer that
>>> the projects provide their own binary installers or we do a better job
>>> of choosing dependencies.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> On 03/12/2018 04:18 PM, Tomasz Wlostowski wrote:
>>> > On 12/03/18 19:10, Wayne Stambaugh wrote:
>>> >>  The context switching build
>>> >> issue will most likely have to be fixed yet again if we choose to go
>>> >> down this path.
>>> >
>>> > Wayne,
>>> >
>>> > One of the things that Windows does remarkably well is binary
>>> > compatibility. We can just provide pre-built libcontext binaries (as
>>> > well as binaries of every other dependency for Kicad), say, once a
>>> year,
>>> > and with a very high probability they will work on every Windows box
>>> out
>>> > there. I wouldn't worry much about libcontext, I'm more worried about
>>> > code that MSVC might not like in Kicad - but as Mark & Jon reported,
>>> > newer MSVC versions have fixed such interoperability issues, so I hope
>>> > things will go smoothly. Simon has been running MSVC builds for a
>>> while,
>>> > so he's likely more up-to-date than me in MSVC compatibility.
>>> >
>>> > Tom
>>> >
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> --
>> Mark
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

I can't make cmake find wxwidgets from vcpkg. I think Thomas Figueroa also
uses vcpkg, but he built wxwidgets himself to overcome this. So I think
something is missing for wxwidgets in vcpkg, or something else is not quite
right in that corner.

2018-03-12 23:36 GMT+01:00 Mark Roszko :

> Wayne,
>
> Long term there is good news, VCPKG exists. https://github.com/Mic
> rosoft/vcpkg  right now its separate but eventually it'll be part of VS.
> (But it works now).
>
> It's like msysbut for MSVC and it builds packages locally and puts
> them in a central store. I think most of  Kicad's depedencies are there, I
> actually started to work on seeing if Kicad would compile with it but
> didn't get far before being distracted.
>
>
> On Mon, Mar 12, 2018 at 5:33 PM, Wayne Stambaugh 
> wrote:
>
>> Tom,
>>
>> I would prefer KiCad not be in the business of providing dependency
>> binaries.  I can't stop anyone from providing them but I would rather
>> developers focus on kicad development rather than our dependencies as
>> much as possible.  The whole point of removing all of the dependency
>> build code from v4 was specifically for this reason.  The amount of time
>> we were spending supporting this was significant.  I would prefer that
>> the projects provide their own binary installers or we do a better job
>> of choosing dependencies.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 03/12/2018 04:18 PM, Tomasz Wlostowski wrote:
>> > On 12/03/18 19:10, Wayne Stambaugh wrote:
>> >>  The context switching build
>> >> issue will most likely have to be fixed yet again if we choose to go
>> >> down this path.
>> >
>> > Wayne,
>> >
>> > One of the things that Windows does remarkably well is binary
>> > compatibility. We can just provide pre-built libcontext binaries (as
>> > well as binaries of every other dependency for Kicad), say, once a year,
>> > and with a very high probability they will work on every Windows box out
>> > there. I wouldn't worry much about libcontext, I'm more worried about
>> > code that MSVC might not like in Kicad - but as Mark & Jon reported,
>> > newer MSVC versions have fixed such interoperability issues, so I hope
>> > things will go smoothly. Simon has been running MSVC builds for a while,
>> > so he's likely more up-to-date than me in MSVC compatibility.
>> >
>> > Tom
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
> --
> Mark
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Volunteer

If you have a hard time to find a bug worth looking at, you could probably
have a look at https://launchpad.net/kicad/+milestone/5.0.0-rc2  and pick
one where no one is assigned.

2018-03-12 23:38 GMT+01:00 Jeff Young :

> I threw one your way, but it would also be handy to know what platform
> you’re on, as some of them are platform-specific.
>
> Cheers,
> Jeff.
>
>
> > On 12 Mar 2018, at 22:07, hauptmech  wrote:
> >
> > I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all
> corners of the code. Bugs where the desired results are clear from the bug
> discussion are probably best. Just assign them to me on launchpad and I'll
> get to work.
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Volunteer

2018-03-12 Thread hauptmech

Linux (Arch, though Ubuntu LTS is always on a partition nearby). I have 
the other platforms on my desk but don't have a kicad build set up on 
them, nor do I know much about their build/wx related quirks.



On 13/03/18 11:38, Jeff Young wrote:

I threw one your way, but it would also be handy to know what platform you’re 
on, as some of them are platform-specific.

Cheers,
Jeff.



On 12 Mar 2018, at 22:07, hauptmech  wrote:

I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all 
corners of the code. Bugs where the desired results are clear from the bug 
discussion are probably best. Just assign them to me on launchpad and I'll get 
to work.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Volunteer

I threw one your way, but it would also be handy to know what platform you’re 
on, as some of them are platform-specific.

Cheers,
Jeff.


> On 12 Mar 2018, at 22:07, hauptmech  wrote:
> 
> I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all 
> corners of the code. Bugs where the desired results are clear from the bug 
> discussion are probably best. Just assign them to me on launchpad and I'll 
> get to work.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

Wayne,

Long term there is good news, VCPKG exists. https://github.com/
Microsoft/vcpkg  right now its separate but eventually it'll be part of VS.
(But it works now).

It's like msysbut for MSVC and it builds packages locally and puts them
in a central store. I think most of  Kicad's depedencies are there, I
actually started to work on seeing if Kicad would compile with it but
didn't get far before being distracted.


On Mon, Mar 12, 2018 at 5:33 PM, Wayne Stambaugh 
wrote:

> Tom,
>
> I would prefer KiCad not be in the business of providing dependency
> binaries.  I can't stop anyone from providing them but I would rather
> developers focus on kicad development rather than our dependencies as
> much as possible.  The whole point of removing all of the dependency
> build code from v4 was specifically for this reason.  The amount of time
> we were spending supporting this was significant.  I would prefer that
> the projects provide their own binary installers or we do a better job
> of choosing dependencies.
>
> Cheers,
>
> Wayne
>
> On 03/12/2018 04:18 PM, Tomasz Wlostowski wrote:
> > On 12/03/18 19:10, Wayne Stambaugh wrote:
> >>  The context switching build
> >> issue will most likely have to be fixed yet again if we choose to go
> >> down this path.
> >
> > Wayne,
> >
> > One of the things that Windows does remarkably well is binary
> > compatibility. We can just provide pre-built libcontext binaries (as
> > well as binaries of every other dependency for Kicad), say, once a year,
> > and with a very high probability they will work on every Windows box out
> > there. I wouldn't worry much about libcontext, I'm more worried about
> > code that MSVC might not like in Kicad - but as Mark & Jon reported,
> > newer MSVC versions have fixed such interoperability issues, so I hope
> > things will go smoothly. Simon has been running MSVC builds for a while,
> > so he's likely more up-to-date than me in MSVC compatibility.
> >
> > Tom
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Volunteer

2018-03-12 Thread hauptmech

I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all
corners of the code. Bugs where the desired results are clear from the bug
discussion are probably best. Just assign them to me on launchpad and I'll
get to work.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Git noob question

2018-03-12 21:02 GMT+01:00 Kevin Cozens :

> On 2018-03-11 11:52 AM, Nick Østergaard wrote:
>
>> That sounds a bit risky. Using the stash and popping can make you lose
>> your local changes if you decide to abort a potential merge conflict. IIRC.
>> Commiting changes are generally safer. Or you could use git stash apply
>> instead.
>>
>
> The risk of lose comes from how you try to resolve the merge conflict that
> arises from trying to apply the stashed changes whether you use pop or
> apply. When applying stashed changes triggers a merge conflict the stashed
> changes stay stashed. If you try to abort a merge git will say there is no
> merge in progress. If you tell git to reset the source tree it will tell
> you that there is a merge in progress so it won't reset the tree.
>

Yes, this is why I say it is not safe for noobs.

>
> You then have code in a Heisenberg box situation. The code is
> simultaneously in the middle of a merge and not in the middle of a merge.
> The only really safe way to protect against potential merge conflict when
> you go to apply the stashed changes is to save the output of a "git diff"
> before you stash changes not yet commited.
>

You could just commit it, if you get lost and need to reset you can just
find the patch my the commit has with reflog.


>
> Subversion was much better about dealing with conflicts. It would tell you
> there is a conflict but apply changes to files so you could see the before
> and after. You then had to manually fix the conflicts. No loss of changes
> and no being unable to access what the changes were. I've had no success
> trying to save stashed changes as a file so I could manually fix a merge
> conflict.
>

IMHO it is different, not better. :)

>
> --
> Cheers!
>
> Kevin.
>
> http://www.ve3syb.ca/|"Nerds make the shiny things that
> distract
> https://patreon.html/KevinCozens | the mouth-breathers, and that's why
> we're
>  | powerful"
> Owner of Elecraft K2 #2172   |
> #include   | --Chris Hardwick
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

It looks like it just passed the build here,
http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/3072/

2018-03-12 22:03 GMT+01:00 Jeff Young :

> Well, my build is still running so I can’t confirm the fixes yet, but
> since I already broke the build for some I went ahead and pushed “fixes”.
>
> We’ll see if they actually are shortly. ;)
>
>
> > On 12 Mar 2018, at 20:33, Kevin Cozens  wrote:
> >
> > On 2018-03-12 03:19 PM, Jeff Young wrote:
> >> I just pushed a change which removes a bunch of unnecessary boilerplate.
> >> But it occurs to me that maybe itâ€™s necessary with pickier
> compilers?  Anyway, if someone could try it on Windows and/or Unix that
> would be great.
> > Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9)
> 5.4.0 20160609 under Linux Mint 18.3
> >
> >
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member
> function ‘void CVPCB_MAINFRAME::UpdateTitle()’:
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43:
> error: operands to ?: have different types ‘const wxChar* {aka const
> wchar_t*}’ and ‘const wxString’
> >   fn.IsFileWritable() ? wxEmptyString : _( " [Read
> Only]" ) );
> >   ^
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note:
> and each type can be converted to the other
> > cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed
> > make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o]
> Error 1
> > CMakeFiles/Makefile2:817: recipe for target 
> > 'cvpcb/CMakeFiles/cvpcb_kiface.dir/all'
> failed
> > make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
> > Makefile:149: recipe for target 'all' failed
> > make: *** [all] Error 2
> >
> >
> > --
> > Cheers!
> >
> > Kevin.
> >
> > http://www.ve3syb.ca/| "Nerds make the shiny things that
> > https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
> > | that's why we're powerful"
> > Owner of Elecraft K2 #2172   |
> > #include   | --Chris Hardwick
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 03/12/2018 04:45 PM, Simon Richter wrote:
> Hi,
> 
> On 12.03.2018 16:39, Tomasz Wlostowski wrote:
> 
>> Would someone be so kind to upload all build dependencies for Kicad
>> compiled for VS in a binary form?
> 
> I have them as artifacts in Jenkins[1], and the runtime is also
> available on the download server[2].
> 
> The only thing that is missing is Python support.

This would be a non-starter for nightly release builds.  Users expect
python scripting to be available.  For developer builds, you can do
whatever you fancy but this would have to be addressed if we wanted to
use this for nightly and release builds.

Wayne

> 
>Simon
> 
> [1] http://darine.hogyros.de:8080/view/MSVC/
> [2] http://downloads.kicad-pcb.org/windows/testing/msvc/
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter

Hi,

On 12.03.2018 21:50, Tomasz Wlostowski wrote:

> Would you be able to provide all dependencies for Kicad MSVC builds in
> form of a zip archive (+CMake.exe)?

I've told Jenkins to pack all the artifacts together, for some reason
they ended up in the root of the download server. I'll move them to
windows/testing/msvc later, and also add a script.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

Tom,

I would prefer KiCad not be in the business of providing dependency
binaries.  I can't stop anyone from providing them but I would rather
developers focus on kicad development rather than our dependencies as
much as possible.  The whole point of removing all of the dependency
build code from v4 was specifically for this reason.  The amount of time
we were spending supporting this was significant.  I would prefer that
the projects provide their own binary installers or we do a better job
of choosing dependencies.

Cheers,

Wayne

On 03/12/2018 04:18 PM, Tomasz Wlostowski wrote:
> On 12/03/18 19:10, Wayne Stambaugh wrote:
>>  The context switching build
>> issue will most likely have to be fixed yet again if we choose to go
>> down this path.
> 
> Wayne,
> 
> One of the things that Windows does remarkably well is binary
> compatibility. We can just provide pre-built libcontext binaries (as
> well as binaries of every other dependency for Kicad), say, once a year,
> and with a very high probability they will work on every Windows box out
> there. I wouldn't worry much about libcontext, I'm more worried about
> code that MSVC might not like in Kicad - but as Mark & Jon reported,
> newer MSVC versions have fixed such interoperability issues, so I hope
> things will go smoothly. Simon has been running MSVC builds for a while,
> so he's likely more up-to-date than me in MSVC compatibility.
> 
> Tom
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Jenkins build is back to normal : kicad-qa #3761

2018-03-12 Thread Miguel Angel Ajo

See 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

Well, my build is still running so I can’t confirm the fixes yet, but since I 
already broke the build for some I went ahead and pushed “fixes”.

We’ll see if they actually are shortly. ;)


> On 12 Mar 2018, at 20:33, Kevin Cozens  wrote:
> 
> On 2018-03-12 03:19 PM, Jeff Young wrote:
>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>> But it occurs to me that maybe itâ€™s necessary with pickier compilers?  
>> Anyway, if someone could try it on Windows and/or Unix that would be great.
> Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 
> 20160609 under Linux Mint 18.3
> 
> 
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member function 
> ‘void CVPCB_MAINFRAME::UpdateTitle()’:
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: error: 
> operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ and 
> ‘const wxString’
>   fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" 
> ) );
>   ^
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note: and 
> each type can be converted to the other
> cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target 
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed
> make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o] Error 1
> CMakeFiles/Makefile2:817: recipe for target 
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/all' failed
> make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
> Makefile:149: recipe for target 'all' failed
> make: *** [all] Error 2
> 
> 
> -- 
> Cheers!
> 
> Kevin.
> 
> http://www.ve3syb.ca/| "Nerds make the shiny things that
> https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
> | that's why we're powerful"
> Owner of Elecraft K2 #2172   |
> #include   | --Chris Hardwick
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 12/03/18 21:41, Simon Richter wrote:
> Hi,
> 
> On 12.03.2018 19:10, Wayne Stambaugh wrote:
> 
>> As long as we don't have to add msvs specific fixes to the kicad source
>> then I don't have any issues with this but I think this falls under the
>> category be careful what you wish for.
> 
> There is one major issue for building with Visual Studio: static
> libraries are not linked elementwise, but rather, their entire symbol
> table is imported in one go, and sections pulled in as required.
> 
> This means that symbols need to be unique for the entire project, and
> overwriting symbols from static libraries (as the qa programs do) does
> not work.
> 
> I've avoided the issue by simply removing the "qa" subfolder from the
> main CMakeLists.txt, but obviously that is not a solution.
> 
>> The context switching build
>> issue will most likely have to be fixed yet again if we choose to go
>> down this path.  I do not believe current context assembly files will
>> build with msvc so we will either have to provide both sets of assembly
>> files or go back to using them from the boost which has it's own set of
>> well known build issues.
> 
> FWIW, I've backed out the relevant commits, and it builds fine with
> Boost 1.60 and 1.62. The only problematic version seems to be 1.61. If
> we wanted to go back to Boost, we could perhaps special-case 1.61 if
> there is significant demand.
> 
> The only other MSVC specific change is a workaround for a VS2015
> internal compiler error. The code in question is nonsensical anyway,
> I've replaced it with equally nonsensical code that is a bit more
> legible so it is more obvious that it is nonsensical. For those who
> care: it's the initializers for the BOX2 template, which use
> std::numeric_limits to default-initialize boxes to span the largest
> possible area. Except this doesn't work, because
> 
> using namespace std;
> cout << numeric_limits::min() << ' '
> << numeric_limits::max() << endl;
> cout << numeric_limits::min() << ' '
> << numeric_limits::max() << endl;
> 
> gives
> 
> -2147483648 2147483647
> 1.17549e-38 3.40282e+38
> 
> so the default initialization for BOX2 covers (0,0) while
> BOX2 does not. My suspicion is that this is either responsible
> for some very subtle bugs, or simply does not matter because all
> default-initialized boxes are later overwritten anyway.
> 
> Current MSVC patch stack:
> 
> Remove qa code for MSVC
> Remove own copy of FindOpenSSL.cmake
> Revert "Switched coroutine library from Boost libcotext to custom
> libcontext."
> Revert "Made libcontext compile on FreeBSD. Code formatting too."
> Revert "Preserve FPU registers on context switch"
> Revert "libcontext FreeBSD compatibility fix"
> Revert "Some coverity fixes"
> Revert "Fix an initialization order warning in coroutine.h"
> Work around VC++ 2015 bug.
> Define compiler flags for MSVC
> 
> IMO:
> 
>  - the compiler flags patch can be applied as is, it just adds a
> conditional block to CMakeLists.txt
>  - the workaround can be applied as is, or someone can look at that code
> and throw it out
>  - the context stuff needs to be decided
>  - the OpenSSL CMake script can probably be removed and the shipped
> version used, but we need to check why we had this file in the first place
>  - the QA code needs refactoring if we want to compile it with MSVC, so
> the best we can do now is disable it on MSVC.

Simon,

Would you be able to provide all dependencies for Kicad MSVC builds in
form of a zip archive (+CMake.exe)?

The goal would be to:

- unzip the dependency file
- git clone Kicad
- cd kicad
- configure.bat
- open kicad.sln with VS

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter

Hi,

On 12.03.2018 16:39, Tomasz Wlostowski wrote:

> Would someone be so kind to upload all build dependencies for Kicad
> compiled for VS in a binary form?

I have them as artifacts in Jenkins[1], and the runtime is also
available on the download server[2].

The only thing that is missing is Python support.

   Simon

[1] http://darine.hogyros.de:8080/view/MSVC/
[2] http://downloads.kicad-pcb.org/windows/testing/msvc/



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter

Hi,

On 12.03.2018 19:10, Wayne Stambaugh wrote:

> As long as we don't have to add msvs specific fixes to the kicad source
> then I don't have any issues with this but I think this falls under the
> category be careful what you wish for.

There is one major issue for building with Visual Studio: static
libraries are not linked elementwise, but rather, their entire symbol
table is imported in one go, and sections pulled in as required.

This means that symbols need to be unique for the entire project, and
overwriting symbols from static libraries (as the qa programs do) does
not work.

I've avoided the issue by simply removing the "qa" subfolder from the
main CMakeLists.txt, but obviously that is not a solution.

> The context switching build
> issue will most likely have to be fixed yet again if we choose to go
> down this path.  I do not believe current context assembly files will
> build with msvc so we will either have to provide both sets of assembly
> files or go back to using them from the boost which has it's own set of
> well known build issues.

FWIW, I've backed out the relevant commits, and it builds fine with
Boost 1.60 and 1.62. The only problematic version seems to be 1.61. If
we wanted to go back to Boost, we could perhaps special-case 1.61 if
there is significant demand.

The only other MSVC specific change is a workaround for a VS2015
internal compiler error. The code in question is nonsensical anyway,
I've replaced it with equally nonsensical code that is a bit more
legible so it is more obvious that it is nonsensical. For those who
care: it's the initializers for the BOX2 template, which use
std::numeric_limits to default-initialize boxes to span the largest
possible area. Except this doesn't work, because

using namespace std;
cout << numeric_limits::min() << ' '
<< numeric_limits::max() << endl;
cout << numeric_limits::min() << ' '
<< numeric_limits::max() << endl;

gives

-2147483648 2147483647
1.17549e-38 3.40282e+38

so the default initialization for BOX2 covers (0,0) while
BOX2 does not. My suspicion is that this is either responsible
for some very subtle bugs, or simply does not matter because all
default-initialized boxes are later overwritten anyway.

Current MSVC patch stack:

Remove qa code for MSVC
Remove own copy of FindOpenSSL.cmake
Revert "Switched coroutine library from Boost libcotext to custom
libcontext."
Revert "Made libcontext compile on FreeBSD. Code formatting too."
Revert "Preserve FPU registers on context switch"
Revert "libcontext FreeBSD compatibility fix"
Revert "Some coverity fixes"
Revert "Fix an initialization order warning in coroutine.h"
Work around VC++ 2015 bug.
Define compiler flags for MSVC

IMO:

 - the compiler flags patch can be applied as is, it just adds a
conditional block to CMakeLists.txt
 - the workaround can be applied as is, or someone can look at that code
and throw it out
 - the context stuff needs to be decided
 - the OpenSSL CMake script can probably be removed and the shipped
version used, but we need to check why we had this file in the first place
 - the QA code needs refactoring if we want to compile it with MSVC, so
the best we can do now is disable it on MSVC.

   Simon

signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Kevin Cozens


On 2018-03-12 03:19 PM, Jeff Young wrote:

I just pushed a change which removes a bunch of unnecessary boilerplate.

But it occurs to me that maybe itâ€™s necessary with pickier compilers?  
Anyway, if someone could try it on Windows and/or Unix that would be great.
Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 
20160609 under Linux Mint 18.3



/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member 
function ‘void CVPCB_MAINFRAME::UpdateTitle()’:
/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: error: 
operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ and 
‘const wxString’
   fn.IsFileWritable() ? wxEmptyString : _( " [Read 
Only]" ) );

   ^
/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note: 
and each type can be converted to the other
cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target 
'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed

make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o] Error 1
CMakeFiles/Makefile2:817: recipe for target 
'cvpcb/CMakeFiles/cvpcb_kiface.dir/all' failed

make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2


--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 12/03/18 19:10, Wayne Stambaugh wrote:
>  The context switching build
> issue will most likely have to be fixed yet again if we choose to go
> down this path.

Wayne,

One of the things that Windows does remarkably well is binary
compatibility. We can just provide pre-built libcontext binaries (as
well as binaries of every other dependency for Kicad), say, once a year,
and with a very high probability they will work on every Windows box out
there. I wouldn't worry much about libcontext, I'm more worried about
code that MSVC might not like in Kicad - but as Mark & Jon reported,
newer MSVC versions have fixed such interoperability issues, so I hope
things will go smoothly. Simon has been running MSVC builds for a while,
so he's likely more up-to-date than me in MSVC compatibility.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

Cool.  I’ll fix it up.

Cheers,
Jeff.

> On 12 Mar 2018, at 20:07, jp charras  wrote:
> 
> Le 12/03/2018 à 20:53, Jeff Young a écrit :
>> Hi JP,
>> 
>>> On 12 Mar 2018, at 19:40, jp charras  wrote:
>>> 
>>> Le 12/03/2018 à 20:19, Jeff Young a écrit :
 Hi folks,
 
 I just pushed a change which removes a bunch of unnecessary boilerplate.
 
 But it occurs to me that maybe it’s necessary with pickier compilers?  
 Anyway, if someone could try it on Windows and/or Unix that would be great.
 
 Cheers,
 Jeff.
 
>>> Hi Jeff,
>>> 
>>> You fixes can create issues because:
>>> 
>>> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
>>> creates issues because wxEmptyString does not return a wxString, but _( " 
>>> [Read Only]" ) that is a
>>> macro for wxGetTranslation( " [Read Only]" ) returns a wxString
>> 
>> Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
>> (Mine doesn’t, but that doesn’t mean much.)
> 
> gcc 6.3 on msys2 (and certainly gcc 4.8 on Kubuntu 14.04 LST) complains:
> E:/kicad-launchpad/testing_git/pcbnew/footprint_edit_frame.cpp:802:28: error: 
> operands to ?: have
> different types 'const wxChar* {aka const wchar_t*}' and  'const wxString'
>   writable ? wxEmptyString : _( " [Read Only]" ),
> 
>> 
>>> 
>>> and
>>> 
>>> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( 
>>> GetScreen()->GetFileName() ) );
>>> 
>>> is incorrect because the string inside _() *must be* a ASCII7 string.
>>> This is mandatory for translation tools.
>> 
>> Oops.  Missed that one.
>> 
>> Thanks,
>> Jeff.
>> 
> 
> -- 
> Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

2018-03-12 Thread jp charras

Le 12/03/2018 à 20:53, Jeff Young a écrit :
> Hi JP,
> 
>> On 12 Mar 2018, at 19:40, jp charras  wrote:
>>
>> Le 12/03/2018 à 20:19, Jeff Young a écrit :
>>> Hi folks,
>>>
>>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>>>
>>> But it occurs to me that maybe it’s necessary with pickier compilers?  
>>> Anyway, if someone could try it on Windows and/or Unix that would be great.
>>>
>>> Cheers,
>>> Jeff.
>>>
>> Hi Jeff,
>>
>> You fixes can create issues because:
>>
>> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
>> creates issues because wxEmptyString does not return a wxString, but _( " 
>> [Read Only]" ) that is a
>> macro for wxGetTranslation( " [Read Only]" ) returns a wxString
> 
> Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
> (Mine doesn’t, but that doesn’t mean much.)

gcc 6.3 on msys2 (and certainly gcc 4.8 on Kubuntu 14.04 LST) complains:
E:/kicad-launchpad/testing_git/pcbnew/footprint_edit_frame.cpp:802:28: error: 
operands to ?: have
different types 'const wxChar* {aka const wchar_t*}' and  'const wxString'
   writable ? wxEmptyString : _( " [Read Only]" ),

> 
>>
>> and
>>
>> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( 
>> GetScreen()->GetFileName() ) );
>>
>> is incorrect because the string inside _() *must be* a ASCII7 string.
>> This is mandatory for translation tools.
> 
> Oops.  Missed that one.
> 
> Thanks,
> Jeff.
> 

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Git noob question

2018-03-12 Thread Kevin Cozens


On 2018-03-11 11:52 AM, Nick Østergaard wrote:
That sounds a bit risky. Using the stash and popping can make you lose your 
local changes if you decide to abort a potential merge conflict. IIRC. 
Commiting changes are generally safer. Or you could use git stash apply instead.


The risk of lose comes from how you try to resolve the merge conflict that 
arises from trying to apply the stashed changes whether you use pop or 
apply. When applying stashed changes triggers a merge conflict the stashed 
changes stay stashed. If you try to abort a merge git will say there is no 
merge in progress. If you tell git to reset the source tree it will tell you 
that there is a merge in progress so it won't reset the tree.


You then have code in a Heisenberg box situation. The code is simultaneously 
in the middle of a merge and not in the middle of a merge. The only really 
safe way to protect against potential merge conflict when you go to apply 
the stashed changes is to save the output of a "git diff" before you stash 
changes not yet commited.


Subversion was much better about dealing with conflicts. It would tell you 
there is a conflict but apply changes to files so you could see the before 
and after. You then had to manually fix the conflicts. No loss of changes 
and no being unable to access what the changes were. I've had no success 
trying to save stashed changes as a file so I could manually fix a merge 
conflict.


--
Cheers!

Kevin.

http://www.ve3syb.ca/|"Nerds make the shiny things that distract
https://patreon.html/KevinCozens | the mouth-breathers, and that's why we're
 | powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build failed in Jenkins: kicad-qa #3760

2018-03-12 Thread Miguel Angel Ajo

See 

Changes:

[jeff] Translatable strings must be ASCII7 for translation tools.

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 3d32ee774ee26c5382e7f37c25f90afbd90c7f8c 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 3d32ee774ee26c5382e7f37c25f90afbd90c7f8c
Commit message: "Translatable strings must be ASCII7 for translation tools."
 > git rev-list --no-walk 4eedb3a27dab45e17295bb04d2327bbe15c89ed2 # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins394364674791066345.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10+deb8u1) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ env
+ grep -q ^MAKEJOBS=
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] Built target lib_table_lexer_source_files
[  0%] [  0%] Built target page_layout_lexer_source_files
Built target idf3
[  0%] Built target netlist_lexer_source_files
[  0%] [  2%] Generating version string header
Built target gal
[  5%] Built target kicad_3dsg
-- Using Git to determine build version string.
[  5%] -- Found Git: /usr/bin/git (found version "2.1.4") 
Built target pcb_plot_lexer_source_files
[  5%] -- Writing 
 file with 
version: (5.0.0-rc2-dev-182-g3d32ee7)
Built target pcb_lexer_source_files
[  5%] [  5%] Built target polygon
Built target version_header
[  5%] [  5%] Built target lib_dxf
Built target specctra_lexer_source_files
[ 49%] Built target bitmaps
[ 54%] Built target pcbcommon
[ 56%] Built target pcad2kicadpcb
[ 61%] Built target 3d-viewer
Scanning dependencies of target common
[ 61%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
[ 61%] [ 61%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/pcb_edit_frame.cpp.o
Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/footprint_edit_frame.cpp.o
Linking CXX static library libcommon.a
: In 
member function ‘void FOOTPRINT_EDIT_FRAME::updateTitle()’:
:802:28:
 error: operands to ?: have different types ‘const wxChar* {aka const 
wchar_t*}’ and ‘const wxString’
   writable ? wxEmptyString : _( " [Read Only]" ),
^
: In member 
function ‘void PCB_EDIT_FRAME::UpdateTitle()’:
:1115:46: 
error: operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ 
and ‘const wxString’
 fileinfo = fileName.IsFileWritable() ? wxEmptyString : _( " [Read 
Only]" );
  ^
[ 76%] Built target common
[

Re: [Kicad-developers] Pushed change

Hi JP,

> On 12 Mar 2018, at 19:40, jp charras  wrote:
> 
> Le 12/03/2018 à 20:19, Jeff Young a écrit :
>> Hi folks,
>> 
>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>> 
>> But it occurs to me that maybe it’s necessary with pickier compilers?  
>> Anyway, if someone could try it on Windows and/or Unix that would be great.
>> 
>> Cheers,
>> Jeff.
>> 
> Hi Jeff,
> 
> You fixes can create issues because:
> 
> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
> creates issues because wxEmptyString does not return a wxString, but _( " 
> [Read Only]" ) that is a
> macro for wxGetTranslation( " [Read Only]" ) returns a wxString

Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
(Mine doesn’t, but that doesn’t mean much.)

> 
> and
> 
> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( GetScreen()->GetFileName() 
> ) );
> 
> is incorrect because the string inside _() *must be* a ASCII7 string.
> This is mandatory for translation tools.

Oops.  Missed that one.

Thanks,
Jeff.


> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

2018-03-12 Thread jp charras

Le 12/03/2018 à 20:19, Jeff Young a écrit :
> Hi folks,
> 
> I just pushed a change which removes a bunch of unnecessary boilerplate.
> 
> But it occurs to me that maybe it’s necessary with pickier compilers?  
> Anyway, if someone could try it on Windows and/or Unix that would be great.
> 
> Cheers,
> Jeff.
> 
Hi Jeff,

You fixes can create issues because:

fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
creates issues because wxEmptyString does not return a wxString, but _( " [Read 
Only]" ) that is a
macro for wxGetTranslation( " [Read Only]" ) returns a wxString

and

title.Printf( _( "Eeschema \u2014 %s" ), GetChars( GetScreen()->GetFileName() ) 
);

is incorrect because the string inside _() *must be* a ASCII7 string.
This is mandatory for translation tools.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build failed in Jenkins: kicad-qa #3759

2018-03-12 Thread Miguel Angel Ajo

See 

Changes:

[jeff] The _() macro affords some nullptr safety over a naked immediate.

--
Started by an SCM change
Building remotely on debian8 (clang gcc linux) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/KiCad/kicad-source-mirror.git # timeout=10
Fetching upstream changes from https://github.com/KiCad/kicad-source-mirror.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/KiCad/kicad-source-mirror.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 4eedb3a27dab45e17295bb04d2327bbe15c89ed2 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 4eedb3a27dab45e17295bb04d2327bbe15c89ed2
Commit message: "The _() macro affords some nullptr safety over a naked 
immediate."
 > git rev-list --no-walk b1f613071dc5ebc649c46e69fc1cf0c0ac2ef410 # timeout=10
[kicad-qa] $ /bin/sh -xe /tmp/jenkins5161105025873186572.sh
+ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
+ gcc --version
gcc (Debian 4.9.2-10+deb8u1) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

+ git --version
git version 2.1.4
+ OPTS= -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON 
-DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
+ [ -d passed-qa ]
+ [ -d build ]
+ cd build
+ /usr/bin/cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_GITHUB_PLUGIN=ON 
-DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_WXPYTHON=ON
-- Kicad install dir: 
-- Check for installed GLEW -- found
-- Boost version: 1.55.0
-- Check for installed Python Interpreter -- found
-- Python module install path: lib/python2.7/dist-packages
-- wxPython version 3.0 found.
-- S3DSG version: 2.0.0
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Boost version: 1.55.0
-- Found the following Boost libraries:
--   unit_test_framework
-- Configuring done
-- Generating done
-- Build files have been written to: 

+ echo CMAKE exit code is 0
CMAKE exit code is 0
+ rm -f pcbnew/pcbnewPYTHON_wrap.cxx
+ env
+ grep -q ^MAKEJOBS=
+ echo The MAKEJOBS variable is empty
The MAKEJOBS variable is empty
+ JOBS=4
+ make -j4 pcbnew_python_module
[  0%] [  0%] Built target page_layout_lexer_source_files
Built target lib_table_lexer_source_files
[  0%] Built target idf3
[  0%] [  0%] Built target netlist_lexer_source_files
Generating version string header
[  2%] Built target gal
[  5%] Built target kicad_3dsg
[  5%] -- Using Git to determine build version string.
Built target pcb_plot_lexer_source_files
-- Found Git: /usr/bin/git (found version "2.1.4") 
[  5%] Built target pcb_lexer_source_files
[  5%] -- Writing 
 file with 
version: (5.0.0-rc2-dev-181-g4eedb3a)
Built target polygon
[  5%] [  5%] Built target version_header
Built target lib_dxf
[  5%] [ 49%] Built target specctra_lexer_source_files
Built target bitmaps
[ 54%] Built target pcbcommon
[ 57%] [ 61%] Built target pcad2kicadpcb
Built target 3d-viewer
Scanning dependencies of target common
[ 61%] Building CXX object common/CMakeFiles/common.dir/build_version.cpp.o
Scanning dependencies of target pcbnew_kiface_objects
[ 61%] [ 61%] [ 61%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/pcb_edit_frame.cpp.o
Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/footprint_edit_frame.cpp.o
Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/footprint_viewer_frame.cpp.o
Linking CXX static library libcommon.a
: In 
member function ‘void FOOTPRINT_EDIT_FRAME::updateTitle()’:
:802:28:
 error: operands to ?: have different types ‘const wxChar* {aka const 
wchar_t*}’ and ‘const wxString’
   writable ? wxEmptyString : _( " [Read Only]" ),
^
: In member 
function ‘void PCB_EDIT_FRAME::UpdateTitle()’:
:1115:46: 
error: operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ 
and ‘const

[Kicad-developers] Pushed change

Hi folks,

I just pushed a change which removes a bunch of unnecessary boilerplate.

But it occurs to me that maybe it’s necessary with pickier compilers?  Anyway, 
if someone could try it on Windows and/or Unix that would be great.

Cheers,
Jeff.


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 3/12/2018 1:24 PM, Tomasz Wlostowski wrote:
> On 12/03/18 17:36, Wayne Stambaugh wrote:
>> No doubt I'm out of touch. :)  It's been at least 10 years since I used
>> msvs.  It's great that they have decided to support open source
>> development tools. 
> 
> Hi Wayne,
> 
> I hadn't used MSVC for a while until a few months ago where I had to
> develop a small program for Windows. It was quite a positive change
> since the previous time (also ~10 years ago). I appreciate the nice dark
> coloured theme and greatly improved autocompletion/class browser.
> 
> Honestly, I don't care if MSVS supports Mingw or other non-MS toolchain
> or debugger. What I care about is a compiler that doesn't take ages to
> compile Kicad (for some reason MSYS's gcc is ~3 times slower than gcc
> under Linux). Same applies to CMake and a debugger that works under Windows:
> - In my case GDB and LLDB require some strange hacks (a separate
> program) to send a ctrl-c to interrupt the application being debugged.
> This hasn't been fixed since 2009 (see [1]) - so apparently nobody cares
> to make GDB a working thing under Windows.
> - Qt Creator crashes when I try to attach to running kicad process.
> - Converting DWARF-2 symbols to MS PDB format (in order to use MSVS
> debugger) using cv2pdb tool fails. Maybe due to debug symbols taking ~1
> GB in _pcbnew.kiface alone. I also can't understand why the debug info
> takes more than 100 times the size of the source code ;-).
> - IDA Pro in free version doesn't support debugging...
> 
> Since we often do favors for our Linux users (e.g. by adding workarounds
> for poor quality Linux graphics drivers), we should also be more
> welcoming to the Windows users (and programmers) - it's only 70-80% of
> our user base IIRC. Vast majority of Windows developers use MSVS. If we
> want them onboard, we must support MSVS. I'm pretty sure there are
> people willing to help with this on the mailing list.
> 
> Tom
> 
> [1]
> https://stackoverflow.com/questions/711086/in-gdb-on-mingw-how-to-make-ctrl-c-stop-the-program
> 

As long as we don't have to add msvs specific fixes to the kicad source
then I don't have any issues with this but I think this falls under the
category be careful what you wish for.  The context switching build
issue will most likely have to be fixed yet again if we choose to go
down this path.  I do not believe current context assembly files will
build with msvc so we will either have to provide both sets of assembly
files or go back to using them from the boost which has it's own set of
well known build issues.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

Thanks for the information everyone.  Maybe some day when I have a few
spare seconds and am feeling motivated, I will take a look at it.

Wayne

On 3/12/2018 12:46 PM, Jon Evans wrote:
> The free version is actually very complete for many use
> cases: https://www.visualstudio.com/vs/compare/
> 
> On Mon, Mar 12, 2018 at 12:36 PM, Wayne Stambaugh  > wrote:
> 
> No doubt I'm out of touch. :)  It's been at least 10 years since I used
> msvs.  It's great that they have decided to support open source
> development tools.  I'm may to to check it out when I get a chance.  I'm
> guessing they have a minimal free version available or have they stopped
> offering that?
> 
> On 3/12/2018 11:36 AM, Mark Roszko wrote:
> > Way out of touch now Wayne ;)
> >
> > VS can open CMake projects directly without generator. Also supports
> > GDB.MINGWand even ships with Clang. MS even patched all their
> > VC++ headers to be compatible with Clang.
> >
> >
> > I haven't tried this yet though, but in theory it should be possible to
> > run MSYS2/MINGW and debug via this new feature from last year that lets
> > you configure toolchains and even use gdb:
> >
> > 
> https://blogs.msdn.microsoft.com/vcblog/2017/07/19/using-mingw-and-cygwin-with-visual-cpp-and-open-folder/
> 
> 
> > 
>  
> >
> >
> > In this example it is using MSYS2.
> >
> >
> >
> > On Fri, Mar 9, 2018 at 9:54 AM, Wayne Stambaugh  
> > >> wrote:
> >
> >     It's been a really long time since I've done this but you
> should be able
> >     to tell cmake to create a VS project (`cmake -G "Visual
> Studio 14
> >     2015 [arch]`") and then use msvs to build.  You might want to
> disable
> >     python scripting, oce, and ngspice unless you feel like
> building msvc
> >     variant of those dependencies.  You will also need a msvc
> build of boost
> >     as well for the unit test library.  I'm pretty sure Simon Richter
> >     creates msvs builds so he may have some more up to date
> information than
> >     I do.
> >
> >     Wayne
> >
> >     On 3/9/2018 9:48 AM, Tomasz Wlostowski wrote:
> >     > Dear Windows experts,
> >     >
> >     > I'm desperately trying to debug a segfault in a Windows build of
> >     Kicad.
> >     > So far I've been unable to pause the program in gdb, because
> gdb exits
> >     > when I press Ctrl-C instead of pausing the application.
> >     >
> >     > I'm fed up with this 'unix style of doing things'.
> >     >
> >     > Could you help me set up a VS2015 project for building and
> debugging
> >     > Kicad? Is there some tutorial?
> >     >
> >     > Cheers,
> >     > Tom
> >     >
> >     >
> >     >
> >     > ___
> >     > Mailing list: https://launchpad.net/~kicad-developers
> 
> >      >
> >     > Post to     : kicad-developers@lists.launchpad.net
> 
> >      >
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >      >
> >     > More help   : https://help.launchpad.net/ListHelp
> 
> >      >
> >     >
> >
> >     ___
> >     Mailing list: https://launchpad.net/~kicad-developers
> 
> >      >
> >     Post to     : kicad-developers@lists.launchpad.net
> 
> >      >
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >

Re: [Kicad-developers] Multi-thread crash

2018-03-12 Thread Seth Hillbrand

Hi Jeff-

The underscore is a macro to call wxGetTranslation().  There's some null
checking there but more importantly, it returns a wxString that will be
valid regardless of the the contents.  If you cast a wxString with no data
to a C string, you still get the valid pointer to the data segment (just
has length 0).

-S

2018-03-12 10:32 GMT-07:00 Jeff Young :

> I’ve had a couple of crashes while clicking in a window when CvPcb was
> loading footprints.
>
> Both were because a format string of the form  L"blah, blah, %s"  was
> NULL.  Is there some protection that _( "…" ) gives us over using an
> immediate value?  (When I use those instead, it doesn’t crash.)
>
> Thanks,
> Jeff.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Multi-thread crash

I’ve had a couple of crashes while clicking in a window when CvPcb was loading 
footprints.

Both were because a format string of the form  L"blah, blah, %s"  was NULL.  Is 
there some protection that _( "…" ) gives us over using an immediate value?  
(When I use those instead, it doesn’t crash.)

Thanks,
Jeff.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 12/03/18 17:36, Wayne Stambaugh wrote:
> No doubt I'm out of touch. :) It's been at least 10 years since I used
> msvs. It's great that they have decided to support open source
> development tools.

Hi Wayne,

I hadn't used MSVC for a while until a few months ago where I had to
develop a small program for Windows. It was quite a positive change
since the previous time (also ~10 years ago). I appreciate the nice dark
coloured theme and greatly improved autocompletion/class browser.

Honestly, I don't care if MSVS supports Mingw or other non-MS toolchain
or debugger. What I care about is a compiler that doesn't take ages to
compile Kicad (for some reason MSYS's gcc is ~3 times slower than gcc
under Linux). Same applies to CMake and a debugger that works under Windows:
- In my case GDB and LLDB require some strange hacks (a separate
program) to send a ctrl-c to interrupt the application being debugged.
This hasn't been fixed since 2009 (see [1]) - so apparently nobody cares
to make GDB a working thing under Windows.
- Qt Creator crashes when I try to attach to running kicad process.
- Converting DWARF-2 symbols to MS PDB format (in order to use MSVS
debugger) using cv2pdb tool fails. Maybe due to debug symbols taking ~1
GB in _pcbnew.kiface alone. I also can't understand why the debug info
takes more than 100 times the size of the source code ;-).
- IDA Pro in free version doesn't support debugging...

Since we often do favors for our Linux users (e.g. by adding workarounds
for poor quality Linux graphics drivers), we should also be more
welcoming to the Windows users (and programmers) - it's only 70-80% of
our user base IIRC. Vast majority of Windows developers use MSVS. If we
want them onboard, we must support MSVS. I'm pretty sure there are
people willing to help with this on the mailing list.

Tom

[1]
https://stackoverflow.com/questions/711086/in-gdb-on-mingw-how-to-make-ctrl-c-stop-the-program

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

The free version is actually very complete for many use cases:
https://www.visualstudio.com/vs/compare/

On Mon, Mar 12, 2018 at 12:36 PM, Wayne Stambaugh 
wrote:

> No doubt I'm out of touch. :)  It's been at least 10 years since I used
> msvs.  It's great that they have decided to support open source
> development tools.  I'm may to to check it out when I get a chance.  I'm
> guessing they have a minimal free version available or have they stopped
> offering that?
>
> On 3/12/2018 11:36 AM, Mark Roszko wrote:
> > Way out of touch now Wayne ;)
> >
> > VS can open CMake projects directly without generator. Also supports
> > GDB.MINGWand even ships with Clang. MS even patched all their
> > VC++ headers to be compatible with Clang.
> >
> >
> > I haven't tried this yet though, but in theory it should be possible to
> > run MSYS2/MINGW and debug via this new feature from last year that lets
> > you configure toolchains and even use gdb:
> >
> > https://blogs.msdn.microsoft.com/vcblog/2017/07/19/using-
> mingw-and-cygwin-with-visual-cpp-and-open-folder/
> >  mingw-and-cygwin-with-visual-cpp-and-open-folder/>
> >
> > In this example it is using MSYS2.
> >
> >
> >
> > On Fri, Mar 9, 2018 at 9:54 AM, Wayne Stambaugh  > > wrote:
> >
> > It's been a really long time since I've done this but you should be
> able
> > to tell cmake to create a VS project (`cmake -G "Visual Studio 14
> > 2015 [arch]`") and then use msvs to build.  You might want to disable
> > python scripting, oce, and ngspice unless you feel like building msvc
> > variant of those dependencies.  You will also need a msvc build of
> boost
> > as well for the unit test library.  I'm pretty sure Simon Richter
> > creates msvs builds so he may have some more up to date information
> than
> > I do.
> >
> > Wayne
> >
> > On 3/9/2018 9:48 AM, Tomasz Wlostowski wrote:
> > > Dear Windows experts,
> > >
> > > I'm desperately trying to debug a segfault in a Windows build of
> > Kicad.
> > > So far I've been unable to pause the program in gdb, because gdb
> exits
> > > when I press Ctrl-C instead of pausing the application.
> > >
> > > I'm fed up with this 'unix style of doing things'.
> > >
> > > Could you help me set up a VS2015 project for building and
> debugging
> > > Kicad? Is there some tutorial?
> > >
> > > Cheers,
> > > Tom
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
> >
> >
> > --
> > Mark
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

No doubt I'm out of touch. :)  It's been at least 10 years since I used
msvs.  It's great that they have decided to support open source
development tools.  I'm may to to check it out when I get a chance.  I'm
guessing they have a minimal free version available or have they stopped
offering that?

On 3/12/2018 11:36 AM, Mark Roszko wrote:
> Way out of touch now Wayne ;)
> 
> VS can open CMake projects directly without generator. Also supports
> GDB.MINGWand even ships with Clang. MS even patched all their
> VC++ headers to be compatible with Clang.
> 
> 
> I haven't tried this yet though, but in theory it should be possible to
> run MSYS2/MINGW and debug via this new feature from last year that lets
> you configure toolchains and even use gdb:
> 
> https://blogs.msdn.microsoft.com/vcblog/2017/07/19/using-mingw-and-cygwin-with-visual-cpp-and-open-folder/
> 
> 
> In this example it is using MSYS2.
> 
> 
> 
> On Fri, Mar 9, 2018 at 9:54 AM, Wayne Stambaugh  > wrote:
> 
> It's been a really long time since I've done this but you should be able
> to tell cmake to create a VS project (`cmake -G "Visual Studio 14
> 2015 [arch]`") and then use msvs to build.  You might want to disable
> python scripting, oce, and ngspice unless you feel like building msvc
> variant of those dependencies.  You will also need a msvc build of boost
> as well for the unit test library.  I'm pretty sure Simon Richter
> creates msvs builds so he may have some more up to date information than
> I do.
> 
> Wayne
> 
> On 3/9/2018 9:48 AM, Tomasz Wlostowski wrote:
> > Dear Windows experts,
> >
> > I'm desperately trying to debug a segfault in a Windows build of
> Kicad.
> > So far I've been unable to pause the program in gdb, because gdb exits
> > when I press Ctrl-C instead of pausing the application.
> >
> > I'm fed up with this 'unix style of doing things'.
> >
> > Could you help me set up a VS2015 project for building and debugging
> > Kicad? Is there some tutorial?
> >
> > Cheers,
> > Tom
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> -- 
> Mark

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

On 12/03/18 16:36, Mark Roszko wrote:
> Way out of touch now Wayne ;)
> 
> VS can open CMake projects directly without generator. Also supports
> GDB.MINGWand even ships with Clang. MS even patched all their
> VC++ headers to be compatible with Clang.

Would someone be so kind to upload all build dependencies for Kicad
compiled for VS in a binary form?

Tom


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

Way out of touch now Wayne ;)

VS can open CMake projects directly without generator. Also supports
GDB.MINGWand even ships with Clang. MS even patched all their VC++
headers to be compatible with Clang.


I haven't tried this yet though, but in theory it should be possible to run
MSYS2/MINGW and debug via this new feature from last year that lets you
configure toolchains and even use gdb:

https://blogs.msdn.microsoft.com/vcblog/2017/07/19/using-
mingw-and-cygwin-with-visual-cpp-and-open-folder/

In this example it is using MSYS2.



On Fri, Mar 9, 2018 at 9:54 AM, Wayne Stambaugh 
wrote:

> It's been a really long time since I've done this but you should be able
> to tell cmake to create a VS project (`cmake -G "Visual Studio 14
> 2015 [arch]`") and then use msvs to build.  You might want to disable
> python scripting, oce, and ngspice unless you feel like building msvc
> variant of those dependencies.  You will also need a msvc build of boost
> as well for the unit test library.  I'm pretty sure Simon Richter
> creates msvs builds so he may have some more up to date information than
> I do.
>
> Wayne
>
> On 3/9/2018 9:48 AM, Tomasz Wlostowski wrote:
> > Dear Windows experts,
> >
> > I'm desperately trying to debug a segfault in a Windows build of Kicad.
> > So far I've been unable to pause the program in gdb, because gdb exits
> > when I press Ctrl-C instead of pausing the application.
> >
> > I'm fed up with this 'unix style of doing things'.
> >
> > Could you help me set up a VS2015 project for building and debugging
> > Kicad? Is there some tutorial?
> >
> > Cheers,
> > Tom
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

On 3/12/2018 10:40 AM, Steven A. Falco wrote:
> On 03/12/2018 10:23 AM, Jon Evans wrote:
>> I have seen multiple users who run nightlies think they have RC2 because 
>> they read "5.0.0-rc2" and stop reading after that :-)
>> Maybe we should switch the tag back to "5.0-dev" between RC releases?
>> I think all of us developers are going to look up the git hash anyway to 
>> know exactly when a given version was built, so the "rc2-dev" information 
>> isn't super necessary for me at least.
>>
>> By the way, it's probably annoying to change this because I imagine there 
>> are scripts that depend on it, but I wish the git hash didn't have a "g" in 
>> front of it, since if I just double-click that portion of the version string 
>> I have to manually remove the "g" before pasting it elsewhere to look up the 
>> hash.
> 
> I agree that the -rc2 could be confusing.  As to the "g" prefix, that is not 
> present in the Fedora nightlies.  They report more like:
> 
> 5.0.0-rc2-dev-unknown-r12328-8fcbb64a

My bad.  I forgot that -unknown is append to the end of the version
string when building from a source archive or no git.  Every think
appended after that is done by the build script.

> 
> where the r12328 is a sequential number representing the number of commits to 
> date and the 8fcbb64a is the short SHA of the head commit.
> 
>   Steve
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Steven A. Falco

On 03/12/2018 10:23 AM, Jon Evans wrote:
> I have seen multiple users who run nightlies think they have RC2 because they 
> read "5.0.0-rc2" and stop reading after that :-)
> Maybe we should switch the tag back to "5.0-dev" between RC releases?
> I think all of us developers are going to look up the git hash anyway to know 
> exactly when a given version was built, so the "rc2-dev" information isn't 
> super necessary for me at least.
> 
> By the way, it's probably annoying to change this because I imagine there are 
> scripts that depend on it, but I wish the git hash didn't have a "g" in front 
> of it, since if I just double-click that portion of the version string I have 
> to manually remove the "g" before pasting it elsewhere to look up the hash.

I agree that the -rc2 could be confusing.  As to the "g" prefix, that is not 
present in the Fedora nightlies.  They report more like:

5.0.0-rc2-dev-unknown-r12328-8fcbb64a

where the r12328 is a sequential number representing the number of commits to 
date and the 8fcbb64a is the short SHA of the head commit.

Steve


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

On 3/12/2018 10:23 AM, Jon Evans wrote:
> I have seen multiple users who run nightlies think they have RC2 because
> they read "5.0.0-rc2" and stop reading after that :-)
> Maybe we should switch the tag back to "5.0-dev" between RC releases?
> I think all of us developers are going to look up the git hash anyway to
> know exactly when a given version was built, so the "rc2-dev"
> information isn't super necessary for me at least.

I don't have any issues changing the git tag and KiCadVersion.cmake to
something more descriptive.  I'm not sure if you will be able find
anything that wont confuse someone but I'm open to suggestion.

> 
> By the way, it's probably annoying to change this because I imagine
> there are scripts that depend on it, but I wish the git hash didn't have
> a "g" in front of it, since if I just double-click that portion of the
> version string I have to manually remove the "g" before pasting it
> elsewhere to look up the hash.

You will have to take this up with the git project.  I wasn't thrilled
with the leading g either but using `git describe --dirty` does work
well and simplified the the code in CreateGitVersionHeader.cmake so I
will be reluctant to change it.

> 
> -Jon
> 
> On Mon, Mar 12, 2018 at 10:11 AM, Wayne Stambaugh  > wrote:
> 
> The version string should look like 5.0.0-rc2-dev-176-g53c9143b6 or
> 5.0.0-rc2-dev.  The latter only happens if KiCad is built from a source
> archive or git isn't available to generate the full version sting.
> 
> Wayne
> 
> On 3/12/2018 10:02 AM, Rene Pöschl wrote:
> > Hello
> >
> > It seems at least some packages of current nightlies report themselves
> > as version 5.0.0-rc2. (The arch package seems to be one of them.)
> Is it
> > on purpose that every nightly between tagging rc1 and tagging rc2 is
> > reported as rc2? (I assumed only the one commit tagged would be called
> > 5.0.0-rcx)
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

I have seen multiple users who run nightlies think they have RC2 because
they read "5.0.0-rc2" and stop reading after that :-)
Maybe we should switch the tag back to "5.0-dev" between RC releases?
I think all of us developers are going to look up the git hash anyway to
know exactly when a given version was built, so the "rc2-dev" information
isn't super necessary for me at least.

By the way, it's probably annoying to change this because I imagine there
are scripts that depend on it, but I wish the git hash didn't have a "g" in
front of it, since if I just double-click that portion of the version
string I have to manually remove the "g" before pasting it elsewhere to
look up the hash.

-Jon

On Mon, Mar 12, 2018 at 10:11 AM, Wayne Stambaugh 
wrote:

> The version string should look like 5.0.0-rc2-dev-176-g53c9143b6 or
> 5.0.0-rc2-dev.  The latter only happens if KiCad is built from a source
> archive or git isn't available to generate the full version sting.
>
> Wayne
>
> On 3/12/2018 10:02 AM, Rene Pöschl wrote:
> > Hello
> >
> > It seems at least some packages of current nightlies report themselves
> > as version 5.0.0-rc2. (The arch package seems to be one of them.) Is it
> > on purpose that every nightly between tagging rc1 and tagging rc2 is
> > reported as rc2? (I assumed only the one commit tagged would be called
> > 5.0.0-rcx)
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

The version string should look like 5.0.0-rc2-dev-176-g53c9143b6 or
5.0.0-rc2-dev.  The latter only happens if KiCad is built from a source
archive or git isn't available to generate the full version sting.

Wayne

On 3/12/2018 10:02 AM, Rene Pöschl wrote:
> Hello
> 
> It seems at least some packages of current nightlies report themselves
> as version 5.0.0-rc2. (The arch package seems to be one of them.) Is it
> on purpose that every nightly between tagging rc1 and tagging rc2 is
> reported as rc2? (I assumed only the one commit tagged would be called
> 5.0.0-rcx)
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?