Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
On 6/22/2015 1:20 AM, jp charras wrote: > Le 21/06/2015 22:24, Wayne Stambaugh a écrit : >> Does anyone else have an opinion on this? Is there any objection to >> getting rid of the search dialog or do you prefer adding both a search >> (current dialog) and a browse (Chris's patch) option to select the >> footprint. I'm fine with either option. I want to be sure before I >> commit this patch. >> > > > I have in my working copy a version with both a search and a browse option. > I need a bit of time to be sure there is no issue on Windows and Linux. > > (Usually on Windows, when using the fp viewer in modal mode, when > closing the Kicad manager window is raised, and this is annoying). > Thanks JP! I'll let you commit the change to avoid any duplication. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
Le 21/06/2015 22:24, Wayne Stambaugh a écrit : > Does anyone else have an opinion on this? Is there any objection to > getting rid of the search dialog or do you prefer adding both a search > (current dialog) and a browse (Chris's patch) option to select the > footprint. I'm fine with either option. I want to be sure before I > commit this patch. > I have in my working copy a version with both a search and a browse option. I need a bit of time to be sure there is no issue on Windows and Linux. (Usually on Windows, when using the fp viewer in modal mode, when closing the Kicad manager window is raised, and this is annoying). -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
The problem this fixes will not be fixed by Henner's search dialog because the lag is due to the loading of the all footprints in the fp lib table. Henner's search dialog will need the entire list of footprint in order for the search to be effective. The footprint browser solves this problem because it uses lazy loading. I'll go ahead an commit the patch is unless someone objects. On 6/21/2015 5:19 PM, Nick Østergaard wrote: > I think it is good. Mostly I click Select by Browser anyway. And if > Henner plans to move his awesome search as you type dialog to pcbnew > after the release I think it is ok. > > 2015-06-21 22:24 GMT+02:00 Wayne Stambaugh : >> Does anyone else have an opinion on this? Is there any objection to >> getting rid of the search dialog or do you prefer adding both a search >> (current dialog) and a browse (Chris's patch) option to select the >> footprint. I'm fine with either option. I want to be sure before I >> commit this patch. >> >> On 6/14/2015 4:30 PM, Chris Pavlina wrote: >>> This patch enables use of the new (kiface) footprint selector in the >>> "Exchange Footprints" dialog. >>> >>> As suggested in this bug report: >>> https://bugs.launchpad.net/kicad/+bug/1464821 >>> >>> I'll look into making this change in the module editor as well, but that >>> will require more work. >>> >>> -- >>> Chris >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
I think it is good. Mostly I click Select by Browser anyway. And if Henner plans to move his awesome search as you type dialog to pcbnew after the release I think it is ok. 2015-06-21 22:24 GMT+02:00 Wayne Stambaugh : > Does anyone else have an opinion on this? Is there any objection to > getting rid of the search dialog or do you prefer adding both a search > (current dialog) and a browse (Chris's patch) option to select the > footprint. I'm fine with either option. I want to be sure before I > commit this patch. > > On 6/14/2015 4:30 PM, Chris Pavlina wrote: >> This patch enables use of the new (kiface) footprint selector in the >> "Exchange Footprints" dialog. >> >> As suggested in this bug report: >> https://bugs.launchpad.net/kicad/+bug/1464821 >> >> I'll look into making this change in the module editor as well, but that >> will require more work. >> >> -- >> Chris >> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
Does anyone else have an opinion on this? Is there any objection to getting rid of the search dialog or do you prefer adding both a search (current dialog) and a browse (Chris's patch) option to select the footprint. I'm fine with either option. I want to be sure before I commit this patch. On 6/14/2015 4:30 PM, Chris Pavlina wrote: > This patch enables use of the new (kiface) footprint selector in the > "Exchange Footprints" dialog. > > As suggested in this bug report: https://bugs.launchpad.net/kicad/+bug/1464821 > > I'll look into making this change in the module editor as well, but that > will require more work. > > -- > Chris > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
Chris, I'm not opposed to this patch. I actually prefer the footprint viewer over the footprint search dialog for two reasons. One, the footprint viewer uses lazy loading (it doesn't actually read the footprint files until you select a library) so there is no lag showing the viewer due to loading all of the footprints in every library as is the case with the search dialog. Two, you can actually view the footprint to make sure that is really what you want. That being said, I'm sure not everyone shares my enthusiasm for the footprint viewer so a better solution may be to add a separate button to launch the footprint viewer and leave the footprint search dialog in place for users who prefer using that instead. I promise you if we remove the footprint search dialog, someone will file a bug report about it shortly there after. Wayne On 6/14/2015 4:30 PM, Chris Pavlina wrote: > This patch enables use of the new (kiface) footprint selector in the > "Exchange Footprints" dialog. > > As suggested in this bug report: https://bugs.launchpad.net/kicad/+bug/1464821 > > I'll look into making this change in the module editor as well, but that > will require more work. > > -- > Chris > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH] Use new footprint selector for "Change Footprints"
This patch enables use of the new (kiface) footprint selector in the
"Exchange Footprints" dialog.
As suggested in this bug report: https://bugs.launchpad.net/kicad/+bug/1464821
I'll look into making this change in the module editor as well, but that
will require more work.
--
Chris
commit 6f3c07f0835898bb4cc022b45c586c4aecaef4b2
Author: Chris Pavlina
Date: Sun Jun 14 16:28:06 2015 -0400
Use new footprint selector for "Change Footprints"
diff --git a/pcbnew/xchgmod.cpp b/pcbnew/xchgmod.cpp
index 3ae43b8..a481419 100644
--- a/pcbnew/xchgmod.cpp
+++ b/pcbnew/xchgmod.cpp
@@ -43,6 +43,7 @@
#include
#include
#include
+#include
#include
#include
@@ -95,14 +96,14 @@ void PCB_EDIT_FRAME::InstallExchangeModuleFrame( MODULE* Module )
{
DIALOG_EXCHANGE_MODULE dialog( this, Module );
-dialog.ShowModal();
+dialog.ShowQuasiModal();
}
void DIALOG_EXCHANGE_MODULE::OnQuit( wxCommandEvent& event )
{
m_selectionMode = m_Selection->GetSelection();
-EndModal( 0 );
+EndQuasiModal( wxID_CANCEL );
}
@@ -507,11 +508,14 @@ void DIALOG_EXCHANGE_MODULE::BrowseAndSelectFootprint( wxCommandEvent& event )
{
wxString newname;
-newname = m_parent->SelectFootprint( m_parent, wxEmptyString, wxEmptyString, wxEmptyString,
- Prj().PcbFootprintLibs() );
+KIWAY_PLAYER* frame = Kiway().Player( FRAME_PCB_MODULE_VIEWER_MODAL, true );
-if( newname != wxEmptyString )
+if( frame->ShowModal( &newname, this ) )
+{
m_NewModule->SetValue( newname );
+}
+
+frame->Destroy();
}
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
