Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
I finally had a chance to test this. Here are my concerns: * The Ctrl+mouse wheel behavior is completely broken on windows and I suspect Linux as well when the use mouse wheel to pan option is set. It acts just the Shift+mouse scroll wheel (scroll vertically). This needs to be fixed. The default behavior should always remain the same across platforms. It can be OSX specific compiled code or a configurable option but breaking the current behavior on other platforms is not an option. * The Ctrl+wheel mouse when the use mouse to pan option is not set (zoom) periodically freezes. I seems to come back when I perform some other function that updates the display but the exact cause I cannot say for sure. I did not get a chance to try it out on a laptop to test the track pad behavior. It definitely needs some work before it can be committed to the product branch. On 3/4/2015 7:31 AM, Bob Gustafson wrote: My last build last week seemed to work fine with both up-down and left-right panning using the trackpad. If you want to support OSX in the stable release, I would say that trackpad panning is important. I won't be able to do much testing until after next Tuesday. Bob G Bernhard Stegmaier wrote: Hi, as Garth pointed out, it does work for 3D-Viewer… the only bad thing is that xy-panning is *always* enabled because it doesn’t respect the pcbnew preference setting. When I look into the some things I maybe will find some time to also look into that. PL editor is probably not a big deal to support from the panning point of view. But, it doesn’t have “Preferences” dialog… so, how to enable/disable it? Some new entry in the “Preferences” menu? Regards, Bernhard On 03 Mar 2015, at 22:54, Adam Wolf adamw...@feelslikeburning.com mailto:adamw...@feelslikeburning.com wrote: I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot get this in in time for the stable release. If so, let's get it in the next one! Adam Wolf On Tue, Mar 3, 2015 at 3:49 PM, Wayne Stambaugh stambau...@gmail.com mailto:stambau...@gmail.com wrote: Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering windows. Does it work in GerbView? Cheers, Wayne On 3/3/2015 4:13 PM, Adam Wolf wrote: Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
You might try to compile with Clang on Fedora 21. It is pretty close to the OSX version and gives lots of warning messages (which correlate pretty well with the coverity diagnostics). Bob G On 03/13/2015 07:42 PM, inkblotter wrote: On 03/13/2015 04:00 PM, Wayne Stambaugh wrote: I finally had a chance to test this. Here are my concerns: * The Ctrl+mouse wheel behavior is completely broken on windows and I suspect Linux as well when the use mouse wheel to pan option is set. It acts just the Shift+mouse scroll wheel (scroll vertically). This needs to be fixed. The default behavior should always remain the same across platforms. It can be OSX specific compiled code or a configurable option but breaking the current behavior on other platforms is not an option. * The Ctrl+wheel mouse when the use mouse to pan option is not set (zoom) periodically freezes. I seems to come back when I perform some other function that updates the display but the exact cause I cannot say for sure. I did not get a chance to try it out on a laptop to test the track pad behavior. It definitely needs some work before it can be committed to the product branch. On 3/4/2015 7:31 AM, Bob Gustafson wrote: My last build last week seemed to work fine with both up-down and left-right panning using the trackpad. If you want to support OSX in the stable release, I would say that trackpad panning is important. I won't be able to do much testing until after next Tuesday. Bob G Ah yes, reality hits the fan, as it often does. At least on Fedora 21, I can pan with the mouse wheel depressed and it correctly pans the display for all intents and purposes. And if I roll the mouse wheel it zooms. Everyone is practicing how to build Kicad from src, because after the stable release you/we plan to remove all that spaghetti cmake stuff that we all love to hate about cmake. I, for instance, have taken to building release and debug versions of Kicad every now and then with all their Kicad dependencies built and you can verify that with ldd. I have largely succeeded despite lots of pointless complains from cmake. That is, I have built boost 1.5.7 wxWidgets 3.0.2.0 pixman git head version gl enabled cairo git head, essentially 10.2 Bleeding edge all. Kicad hasn't blinked. Kicad doesn't really care about versions; it cares only that certain calls exist in whichever version of dependencies it has. I also have installed and built wxPython_Phoenix, built via pip, but not in the way kicad approves of. There should be a patch in wxPython head to make wxPython (any version) build using the picky gcc 4.9.2 compiler. But the wxPython people have since run off again and are working on wxPython_Phoenix now. When I get wxPython correctly built against wxWidgets I would try to figure out how to make Kicad build with the -DKICAD_USE_WEBKIT=ON flag on Fedora 21. I will also try building all the dependencies, and Kicad, with clang and clang++. If it works on OS X, then it should work on Linux as well, yes? Ideally, there would be an external (from Kicad) script, jar or python program that would attempt to maintain some semblance of constraints only for that platform. cmake would do what it does fairly well: it builds the code and installs it. It could use some more work on the make clean target that really makes clean, instead of the make mostlyclean we have now. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
On 03/13/2015 04:00 PM, Wayne Stambaugh wrote: I finally had a chance to test this. Here are my concerns: * The Ctrl+mouse wheel behavior is completely broken on windows and I suspect Linux as well when the use mouse wheel to pan option is set. It acts just the Shift+mouse scroll wheel (scroll vertically). This needs to be fixed. The default behavior should always remain the same across platforms. It can be OSX specific compiled code or a configurable option but breaking the current behavior on other platforms is not an option. * The Ctrl+wheel mouse when the use mouse to pan option is not set (zoom) periodically freezes. I seems to come back when I perform some other function that updates the display but the exact cause I cannot say for sure. I did not get a chance to try it out on a laptop to test the track pad behavior. It definitely needs some work before it can be committed to the product branch. On 3/4/2015 7:31 AM, Bob Gustafson wrote: My last build last week seemed to work fine with both up-down and left-right panning using the trackpad. If you want to support OSX in the stable release, I would say that trackpad panning is important. I won't be able to do much testing until after next Tuesday. Bob G Ah yes, reality hits the fan, as it often does. At least on Fedora 21, I can pan with the mouse wheel depressed and it correctly pans the display for all intents and purposes. And if I roll the mouse wheel it zooms. Everyone is practicing how to build Kicad from src, because after the stable release you/we plan to remove all that spaghetti cmake stuff that we all love to hate about cmake. I, for instance, have taken to building release and debug versions of Kicad every now and then with all their Kicad dependencies built and you can verify that with ldd. I have largely succeeded despite lots of pointless complains from cmake. That is, I have built boost 1.5.7 wxWidgets 3.0.2.0 pixman git head version gl enabled cairo git head, essentially 10.2 Bleeding edge all. Kicad hasn't blinked. Kicad doesn't really care about versions; it cares only that certain calls exist in whichever version of dependencies it has. I also have installed and built wxPython_Phoenix, built via pip, but not in the way kicad approves of. There should be a patch in wxPython head to make wxPython (any version) build using the picky gcc 4.9.2 compiler. But the wxPython people have since run off again and are working on wxPython_Phoenix now. When I get wxPython correctly built against wxWidgets I would try to figure out how to make Kicad build with the -DKICAD_USE_WEBKIT=ON flag on Fedora 21. I will also try building all the dependencies, and Kicad, with clang and clang++. If it works on OS X, then it should work on Linux as well, yes? Ideally, there would be an external (from Kicad) script, jar or python program that would attempt to maintain some semblance of constraints only for that platform. cmake would do what it does fairly well: it builds the code and installs it. It could use some more work on the make clean target that really makes clean, instead of the make mostlyclean we have now. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244asically it does not work in pl_editor and it won’t until I or someone give that application a place to hang the mouse preferences. Not sure if it’s worth doing anything with pl_editor at this piont as I haven’t actually used it for anything. If someone wanted to go in there and give it a preference dialog and some preferences I s’pose that would help. The 3D viewer does have support, but it does not honor the preference because there’s no support for them in the 3D canvas. Probably not a huge deal to fix this but I simply haven’t been back in there. At the very least this should probably not behave as if it has the preference checked. I was going to try to give Bernhard commit access to the branch in case he wanted to patch things up, but quite honestly I was too dumb to figure out how. Most important, as Wayne points out, there absolutely could be hidden Windows or Linux issues lurking in there. I simply didn’t have a way to test. Garth On Feb 24, 2015, at 2:33 PM, Garth Corral gcor...@abode.com wrote: Sorry for being so silent, folks. I'll try to send a summary later tonight with my take on these changes and the impediments to getting them in. Garth On Feb 24, 2015, at 11:17 AM, Nick Østergaard oe.n...@gmail.com wrote: True, but it is quite some time ago, although not a first announcement. I have not seen if any new changes has been made after that. Also the patch adds an alternative pan/zoom mode, and still has the old style (almost unaffected). In the old mode, I think he swapped the actions of the ctrl+scroll and shift+scroll buttons. That is all as I understand it for the old mode. The new mode addes better trimming for those wierdass-magic input devices and thereby gives an option for people who like default horizontal and verticall scroll is panning. 2015-02-24 20:13 GMT+01:00 Adam Wolf adamw...@feelslikeburning.com: Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Hi, as Garth pointed out, it does work for 3D-Viewer… the only bad thing is that xy-panning is *always* enabled because it doesn’t respect the pcbnew preference setting. When I look into the some things I maybe will find some time to also look into that. PL editor is probably not a big deal to support from the panning point of view. But, it doesn’t have “Preferences” dialog… so, how to enable/disable it? Some new entry in the “Preferences” menu? Regards, Bernhard On 03 Mar 2015, at 22:54, Adam Wolf adamw...@feelslikeburning.com wrote: I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot get this in in time for the stable release. If so, let's get it in the next one! Adam Wolf On Tue, Mar 3, 2015 at 3:49 PM, Wayne Stambaugh stambau...@gmail.com mailto:stambau...@gmail.com wrote: Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering windows. Does it work in GerbView? Cheers, Wayne On 3/3/2015 4:13 PM, Adam Wolf wrote: Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
If it doesn't make it in this stable release, we can definitely merge it during the next development cycle. On 3/3/2015 4:54 PM, Adam Wolf wrote: I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot get this in in time for the stable release. If so, let's get it in the next one! Adam Wolf On Tue, Mar 3, 2015 at 3:49 PM, Wayne Stambaugh stambau...@gmail.com mailto:stambau...@gmail.com wrote: Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering windows. Does it work in GerbView? Cheers, Wayne On 3/3/2015 4:13 PM, Adam Wolf wrote: Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com mailto:gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244asically it does not work in pl_editor and it won’t until I or someone give that application a place to hang the mouse preferences. Not sure if it’s worth doing anything with pl_editor at this piont as I haven’t actually used it for anything. If someone wanted to go in there and give it a preference dialog and some preferences I s’pose that would
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot get this in in time for the stable release. If so, let's get it in the next one! Adam Wolf On Tue, Mar 3, 2015 at 3:49 PM, Wayne Stambaugh stambau...@gmail.com wrote: Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering windows. Does it work in GerbView? Cheers, Wayne On 3/3/2015 4:13 PM, Adam Wolf wrote: Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 asically it does not work in pl_editor and it won’t until I or someone give that application a place to hang the mouse preferences. Not sure if it’s worth doing anything with pl_editor at this piont as I haven’t actually used it for anything. If someone wanted to go in there and give it a preference dialog and some preferences I s’pose that would help. The 3D viewer does have support, but it does not honor the preference because there’s no support for them in the 3D canvas. Probably not a huge deal to fix this but I simply haven’t been back in there. At the very least this should probably not behave as if it has the preference checked. I was going to try to give Bernhard commit access to the branch in case he wanted to patch things up, but quite honestly I was too dumb to figure out how. Most important, as Wayne points out, there absolutely could be hidden Windows or Linux issues lurking in there. I simply didn’t have a
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering windows. Does it work in GerbView? Cheers, Wayne On 3/3/2015 4:13 PM, Adam Wolf wrote: Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com wrote: Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244asically it does not work in pl_editor and it won’t until I or someone give that application a place to hang the mouse preferences. Not sure if it’s worth doing anything with pl_editor at this piont as I haven’t actually used it for anything. If someone wanted to go in there and give it a preference dialog and some preferences I s’pose that would help. The 3D viewer does have support, but it does not honor the preference because there’s no support for them in the 3D canvas. Probably not a huge deal to fix this but I simply haven’t been back in there. At the very least this should probably not behave as if it has the preference checked. I was going to try to give Bernhard commit access to the branch in case he wanted to patch things up, but quite honestly I was too dumb to figure out how. Most important, as Wayne points out, there absolutely could be hidden Windows or Linux issues lurking in there. I simply didn’t have a way to test. Garth On Feb 24, 2015, at 2:33 PM, Garth Corral gcor...@abode.com mailto:gcor...@abode.com wrote: Sorry for being so silent, folks. I'll try to send a summary later tonight with my take on these changes and the impediments to getting them in. Garth On Feb 24, 2015, at 11:17 AM, Nick Østergaard oe.n...@gmail.com
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Since the pinch part still needs to be developed for wxWidgets, it doesn't have to be in at the moment (my vote anyway). For zoom, the cmd + and cmd - will do fine, as long as the panning is both sideways and up-down. Zoom tends to be sensitive anyway. Having only panning as two finger trackpad gestures would be easier to 'handle'.. FWIW Bob G On 02/24/2015 12:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list:https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to :kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe :https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help :https://help.launchpad.net/ListHelp ___ Mailing list:https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to :kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe :https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help :https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Getting Trackpad Support in before feature freeze?
Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to :
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list:https://launchpad.net/~kicad-developers Post to :kicad-developers@lists.launchpad.net Unsubscribe :https://launchpad.net/~kicad-developers More help :https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf Description: RTF file ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't have any disastrous issues in what he did. Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 1:04 PM, Bernhard Stegmaier stegma...@sw-systems.de wrote: I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto: kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto: kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp Ki-localMergeLog.rtf___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
True, but it is quite some time ago, although not a first announcement. I have not seen if any new changes has been made after that. Also the patch adds an alternative pan/zoom mode, and still has the old style (almost unaffected). In the old mode, I think he swapped the actions of the ctrl+scroll and shift+scroll buttons. That is all as I understand it for the old mode. The new mode addes better trimming for those wierdass-magic input devices and thereby gives an option for people who like default horizontal and verticall scroll is panning. 2015-02-24 20:13 GMT+01:00 Adam Wolf adamw...@feelslikeburning.com: Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't have any disastrous issues in what he did. Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 1:04 PM, Bernhard Stegmaier stegma...@sw-systems.de wrote: I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
On 2/24/2015 2:13 PM, Adam Wolf wrote: Hi Wayne, The Waynelight worked! :) Too funny! Must resist urge to make batman jokes. I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't have any disastrous issues in what he did. I'll try to take a look at it this weekend and test it on both my desktop and my laptop. If it looks OK, I'll commit it. Thanks, Wayne Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 1:04 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com mailto:stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de mailto:stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com mailto:bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to :
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Sorry for being so silent, folks. I'll try to send a summary later tonight with my take on these changes and the impediments to getting them in. Garth On Feb 24, 2015, at 11:17 AM, Nick Østergaard oe.n...@gmail.com wrote: True, but it is quite some time ago, although not a first announcement. I have not seen if any new changes has been made after that. Also the patch adds an alternative pan/zoom mode, and still has the old style (almost unaffected). In the old mode, I think he swapped the actions of the ctrl+scroll and shift+scroll buttons. That is all as I understand it for the old mode. The new mode addes better trimming for those wierdass-magic input devices and thereby gives an option for people who like default horizontal and verticall scroll is panning. 2015-02-24 20:13 GMT+01:00 Adam Wolf adamw...@feelslikeburning.com: Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't have any disastrous issues in what he did. Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 1:04 PM, Bernhard Stegmaier stegma...@sw-systems.de wrote: I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming and panning and any track pad behavior is not broken. Has anyone tested this? Is there a patch that I can apply against the latest product branch so I can do some testing and make sure the patch makes sense? On 2/24/2015 1:22 PM, Adam Wolf wrote: Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at this point I am shining the Waynelight up into the clouds. Wayne--what do you need to make the call on this? A branch to make a build on your own tree? A quick summary of how it impacts non-OS X? Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 12:18 PM, Bernhard Stegmaier stegma...@sw-systems.de mailto:stegma...@sw-systems.de wrote: Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and Magic Mouse). So, in my opinion question is only about non-OSX impacts. Wrt to pinch-to-zoom there seem to be changes in wxWidgets trunk. I don’t know if we would like to patch until it has completely landed (wxWidgets needs to be patched anyway for OS X), or just wait with that until it has arrived in official versions. Regards, Bernhard On 24 Feb 2015, at 18:25, Bob Gustafson bob...@rcn.com mailto:bob...@rcn.com wrote: I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after awhile it did not respond to clicks on the red go-way button (top left of window). I had to Force Quit. FWIW Bob G On 02/24/2015 10:30 AM, Bob Gustafson wrote: Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any chance to get this in, it'll be a focussed effort!) Thanks! Adam Wolf Cofounder and Engineer Wayne and Layne, LLC ___ Mailing list: https://launchpad.net/~kicad-developers https://launchpad.net/%7Ekicad-developers Post to : kicad-developers@lists.launchpad.net mailto:kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers
Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?
Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately from everything else so it would be easy to make a patch just for that. It is 100% conditionally compiled and currently guarded by -DUSE_OSX_MAGNIFY_EVENT. It does require a patch to wxWidgets but, as Bernhard pointed out, that patch (or a version of it) recently landed on trunk there. So hopefully when it finally does make it into a release it will be straightforward to use in Kicad. This is my preferred way to zoom in Kicad with a Magic Trackpad as it is much smoother than the default. The rest of is it is a bit more muddled. As I mentioned in a recent posting, the basic differences are fairly small, and described here: http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 The salient points from that are: With the preference unchecked, this is now: - Unmodified scrollwheel performed zoom in/out - Shift modified scrollwheel performed pan left/right - Cmd modified scrollwheel performed pan up/down - Shift+Cmd modified scrollwheel performed zoom in/out with no cursor warp It should be noted that for the last case, the behavior has changed. This is not arbitrary. This now matches expected behavior for an OS X application. This also matches what wxWidgets expects on this platform as wxWidgets changes the axis of mousewheel events to horizontal when the event is shift-modified. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 This means that if you have this in but choose not to use it, the default behavior changes as described, for all platforms. Nick seems to think it’s not a big deal, and I tend to agree, but folks can get a tad upset about UI changes, no matter how small, and rightly so. The final thing, an probably the main impediment to committing this is the last part: The preference is added everwhere that mouse preferences previously existed, i.e., eeschema, pcbnew and gerbview. The 3D Viewer does not yet honor this preference, but behaves as if it was checked. The pl_editor does not currently have any preferences to honor. http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244 B http://bazaar.launchpad.net/~gcorral/kicad/osx-trackpad-gestures/revision/5244asically it does not work in pl_editor and it won’t until I or someone give that application a place to hang the mouse preferences. Not sure if it’s worth doing anything with pl_editor at this piont as I haven’t actually used it for anything. If someone wanted to go in there and give it a preference dialog and some preferences I s’pose that would help. The 3D viewer does have support, but it does not honor the preference because there’s no support for them in the 3D canvas. Probably not a huge deal to fix this but I simply haven’t been back in there. At the very least this should probably not behave as if it has the preference checked. I was going to try to give Bernhard commit access to the branch in case he wanted to patch things up, but quite honestly I was too dumb to figure out how. Most important, as Wayne points out, there absolutely could be hidden Windows or Linux issues lurking in there. I simply didn’t have a way to test. Garth On Feb 24, 2015, at 2:33 PM, Garth Corral gcor...@abode.com wrote: Sorry for being so silent, folks. I'll try to send a summary later tonight with my take on these changes and the impediments to getting them in. Garth On Feb 24, 2015, at 11:17 AM, Nick Østergaard oe.n...@gmail.com wrote: True, but it is quite some time ago, although not a first announcement. I have not seen if any new changes has been made after that. Also the patch adds an alternative pan/zoom mode, and still has the old style (almost unaffected). In the old mode, I think he swapped the actions of the ctrl+scroll and shift+scroll buttons. That is all as I understand it for the old mode. The new mode addes better trimming for those wierdass-magic input devices and thereby gives an option for people who like default horizontal and verticall scroll is panning. 2015-02-24 20:13 GMT+01:00 Adam Wolf adamw...@feelslikeburning.com: Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't have any disastrous issues in what he did. Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 1:04 PM, Bernhard Stegmaier stegma...@sw-systems.de
