[Kicad-developers] Getting patches committed
Hi guys and gals, I’ve logged a few bugs that affect me and developed fixes for some of them[1]. After decades of svn and then a few years of retirement I don’t trust my git skills so I added the fixes as patches. What’s the process for getting them reviewed and committed? Thanks, Jeff. [1] https://bugs.launchpad.net/kicad/+bug/1737010 https://bugs.launchpad.net/kicad/+bug/1737562 https://bugs.launchpad.net/kicad/+bug/1736836 https://bugs.launchpad.net/kicad/+bug/1715440 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting patches committed
Hi Jeff, Thanks for your patches! You've already done the right thing - KiCad uses a somewhat old-fashioned flow so submitting patches directly like that is the norm. I'll just take a little while for them to be reviewed. If you have patches that add features rather than fixing bugs, you can submit them directly here instead - for future reference, that is (we're in feature freeze right now). -- Chris On Mon, Dec 11, 2017 at 05:45:48PM +, Jeff Young wrote: > Hi guys and gals, > > I’ve logged a few bugs that affect me and developed fixes for some of > them[1]. After decades of svn and then a few years of retirement I don’t > trust my git skills so I added the fixes as patches. What’s the process for > getting them reviewed and committed? > > Thanks, > Jeff. > > [1] > https://bugs.launchpad.net/kicad/+bug/1737010 > https://bugs.launchpad.net/kicad/+bug/1737562 > https://bugs.launchpad.net/kicad/+bug/1736836 > https://bugs.launchpad.net/kicad/+bug/1715440 > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting patches committed
Hey Jeff, The preferred method is for you to use git and committing your changes to your local repo (all commits in git are local) then using `git format-patch` to submit your patches. Using `git format-patch` eliminates the need for busy lead developers from having to enter your author information and writing a commit message in order to merge your patch. I haven't looked at your patches but if you are not aware, kicad has both a coding stype policy[1] and a commit message policy[2]. Following both these will goe a long way to getting you patches merged. The other thing that helps is patience. All of the kicad lead developers are part time, volunteers, or both so they are typically busy and not always able to review patches in as timely a manner as we would like. Cheers, Wayne [1]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html [2]: http://docs.kicad-pcb.org/doxygen/commit_messages.html On 12/11/2017 12:45 PM, Jeff Young wrote: > Hi guys and gals, > > I’ve logged a few bugs that affect me and developed fixes for some of > them[1]. After decades of svn and then a few years of retirement I don’t > trust my git skills so I added the fixes as patches. What’s the process for > getting them reviewed and committed? > > Thanks, > Jeff. > > [1] > https://bugs.launchpad.net/kicad/+bug/1737010 > https://bugs.launchpad.net/kicad/+bug/1737562 > https://bugs.launchpad.net/kicad/+bug/1736836 > https://bugs.launchpad.net/kicad/+bug/1715440 > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Getting patches committed
Hi Maciej, Thanks for the workaround for the progress dialog on OSX. The attached patch is a similar workaround but preserves more of the progress window functionality. Please have a look and let me know what you think. BTW, I’ve also noticed that the DRC window ends up behind the document window after running the rules. Is that also OSX-specific, or does it happen on all platforms? Cheers, Jeff. 0001-A-different-workaround-to-the-OSX-progress-dialog-is.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
