Re: [Kicad-developers] [PATCH] Old Stable file handling

2019-04-01 Thread Seth Hillbrand

Hi Wayne-

I only added Italian and French as they were the two listed on the 
Upgrading website [2].  However, looking it appears that the bug was 
fixed by Dick in 25b65b2e3b9c349cde33dbc59d62be284c287694 on Mar 19, 
2013.  At that time, the translations database was at 
cc2022b1ac739aa673d2a0b7a2047638aa7a47b3 and only had translations for 
layer names in French, Italian and Polish.  While there were other 
languages, they didn't have translations for names like "F.Adhes".


I've added polish to the list and pushed the patch.  If we find 
additional translations due to some mismatch in translation database vs. 
code database, we can add them to createOldLayerMapping()


-S

Am 2019-04-01 15:10, schrieb Wayne Stambaugh:

Seth,

I only see two translations (looks like French and Spanish), I'm pretty
sure there were more translations than this even way back in v3.  I'm
not opposed to it but there is a possibility that it's incomplete.  I'm
surprised that there any of these board files still around.  This bug
was not in the field very long so the number of boards with this bug
should be fairly small.

Cheers,

Wayne

On 4/1/2019 1:25 PM, Seth Hillbrand wrote:

Recently, there was a question on the user forum about opening an old
stable file that had layer names translated[1].  I had suggested
following the instructions that we have posted about this issue on the
website[2].  But after I posted that, I tried it myself and found that
it didn't work correctly (and was a real pain).

Simon observed that this is something we should be able to handle
programatically, so I took a stab at it.

I'm attaching the patch here for comments.  If you'd like a copy of an
oldstable board with translated layer names, you can download one from
here [3]

If this is merged, I'll submit a PR to remove that part of the 
website. 

If we decide not to merge this (or similar), we should at a minimum,
revise the instructions on the website to use the correct (new) layer
numbers.

-Seth

[1]
https://forum.kicad.info/t/problem-opening-old-file-with-kicad-5-1-0/16077
[2] http://kicad-pcb.org/help/upgrading/
[3] https://drive.google.com/open?id=10OaglGiBMD_WUY20AFWRhoditUtiCax4

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] Old Stable file handling

2019-04-01 Thread Wayne Stambaugh
Seth,

I only see two translations (looks like French and Spanish), I'm pretty
sure there were more translations than this even way back in v3.  I'm
not opposed to it but there is a possibility that it's incomplete.  I'm
surprised that there any of these board files still around.  This bug
was not in the field very long so the number of boards with this bug
should be fairly small.

Cheers,

Wayne

On 4/1/2019 1:25 PM, Seth Hillbrand wrote:
> Recently, there was a question on the user forum about opening an old
> stable file that had layer names translated[1].  I had suggested
> following the instructions that we have posted about this issue on the
> website[2].  But after I posted that, I tried it myself and found that
> it didn't work correctly (and was a real pain).
> 
> Simon observed that this is something we should be able to handle
> programatically, so I took a stab at it.
> 
> I'm attaching the patch here for comments.  If you'd like a copy of an
> oldstable board with translated layer names, you can download one from
> here [3]
> 
> If this is merged, I'll submit a PR to remove that part of the website. 
> If we decide not to merge this (or similar), we should at a minimum,
> revise the instructions on the website to use the correct (new) layer
> numbers.
> 
> -Seth
> 
> [1]
> https://forum.kicad.info/t/problem-opening-old-file-with-kicad-5-1-0/16077
> [2] http://kicad-pcb.org/help/upgrading/
> [3] https://drive.google.com/open?id=10OaglGiBMD_WUY20AFWRhoditUtiCax4
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp