[Kmymoney-devel] [kmymoney4] [Bug 322768] Interest category and amount disappear when new fee entered in Dividend.
https://bugs.kde.org/show_bug.cgi?id=322768 Cristian Oneț changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/6b6aba3f1aaae3c6d7a146 |oney/967fa2d7c4f9253d5c8826 |6492a8cdb478c10da8 |548f5870f27b738b1f --- Comment #4 from Cristian Oneț --- Git commit 967fa2d7c4f9253d5c8826548f5870f27b738b1f by Cristian Oneț, on behalf of Allan Anderson. Committed on 02/10/2013 at 15:33. Pushed by conet into branch '4.6'. Related: bug 112947 when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues. (cherry picked from commit 6b6aba3f1aaae3c6d7a1466492a8cdb478c10da8) M +16 -12 kmymoney/dialogs/investactivities.cpp M +38 -19 kmymoney/dialogs/investtransactioneditor.cpp M +2-0kmymoney/dialogs/investtransactioneditor.h M +1-1kmymoney/dialogs/transactioneditor.cpp M +11 -0kmymoney/widgets/transactioneditorcontainer.h http://commits.kde.org/kmymoney/967fa2d7c4f9253d5c8826548f5870f27b738b1f -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 276322] Unwanted fields show in ledger for investment.
https://bugs.kde.org/show_bug.cgi?id=276322 Cristian Oneț changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym ||oney/a82ddef366860e8cd63ca9 ||03f7d8e1192c38d65d --- Comment #16 from Cristian Oneț --- Git commit a82ddef366860e8cd63ca903f7d8e1192c38d65d by Cristian Oneț, on behalf of Allan Anderson. Committed on 17/09/2011 at 09:52. Pushed by conet into branch '4.6'. REVIEW:6791 If an existing cash dividend transaction is selected, the form shows widgets for Date, Amount, Total and Status, which is what is expected. If that transaction is then opened for editing, additional widgets show for Security, Quantity and Price, which aren't expected for a cash dividend. If, while the transaction is open for editing, 'Dividend' is reselected, the additional fields disappear. Similar behaviour occurs for Buy transactions. Also, in numerous places, the likes of - QWidget* w = haveWidget(*it_s); if (w) w->hide(); were found to produce unreliable results. Also, When a Dividend transaction is opened for editing, the fee category field is active, but there is no label. If a fee category is entered, the fee amount field becomes active - again no label, and if an amount is entered, the total reflects this change. However, when the transaction edit is accepted, the fee amount has been lost. Also, fees have been removed from Dividends, and interest income has been removed from Buy and Sell, as these seem most unlikely combinations. I've noticed various other anomalies in the various investment types, to do with unnecessary fields, missing labels and one where it's possible to enter a value for a fee without a category, and which doesn't get retained. svn path=/trunk/extragear/office/kmymoney/; revision=1254077 (cherry picked from commit 101225c4ec65fc7eb4c94d92ee38a32666013908) M +116 -54 kmymoney/dialogs/investactivities.cpp M +48 -27 kmymoney/dialogs/investtransactioneditor.cpp M +2-2kmymoney/widgets/transaction.cpp http://commits.kde.org/kmymoney/a82ddef366860e8cd63ca903f7d8e1192c38d65d -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112947/ --- (Updated Oct. 3, 2013, 10:23 a.m.) Status -- This change has been marked as submitted. Review request for KMymoney. Bugs: 322768 http://bugs.kde.org/show_bug.cgi?id=322768 Repository: kmymoney Description --- - Interest category disappears - Steps to Reproduce: 1.Open a new Dividend transaction. 2.Enter an interest category and amount. 3.Enter a new fee category. 4.On accepting the new category, the interest category and amount have been cleared. One line fix in kmymoney/dialogs/transactioneditor.cpp. - Fixes for KEditWidget visibility issues. When editing an investment transaction, interest or fee edit widgets show or hide incorrectly. This is a fairly long-standing issue, and there have been attempts to fix by delaying the show() or hide() instructions. This became more pronounced during work to allow column resizing, and Cristian produced a fix for the root cause. This fix is included here. With the above fix in place, it became necessary to revert the delayed show() and hide() calls, and this has been done. Of course, nothing is ever as simple as that, and another couple of issues emerged. Whether or not an interest or fee amount widget is shown depends on the presence or absence of the associated category's text. It transpired that if, say, an existing Reinvest transaction was edited to be, say a Buy transaction, the text from the Reinvest interest category was seen by the new Buy entry and resulted in the interest-amount widget being visible when none should appear. Similarly, if a transaction with a fee set is edited to be a type with no fee expected, for instance, an Add or RemoveShares, then the fee-amount widget became visible when not needed. It was necessary to rework the slotUpdateFeeVisibility() and slotUpdateInterestVisibility() functions to take account of the new transaction type. Diffs - kmymoney/dialogs/investactivities.cpp 50f33ed kmymoney/dialogs/investtransactioneditor.h 3e62c2a kmymoney/dialogs/investtransactioneditor.cpp e9f87fb kmymoney/dialogs/transactioneditor.cpp cfb0f71 kmymoney/widgets/transactioneditorcontainer.h f77b195 Diff: http://git.reviewboard.kde.org/r/112947/diff/ Testing --- Entering and editing various transaction types to ensure only the appropriate widgets became visible or hidden when required. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322768] Interest category and amount disappear when new fee entered in Dividend.
https://bugs.kde.org/show_bug.cgi?id=322768 allan changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/6b6aba3f1aaae3c6d7a146 ||6492a8cdb478c10da8 --- Comment #3 from allan --- Git commit 6b6aba3f1aaae3c6d7a1466492a8cdb478c10da8 by Allan Anderson. Committed on 02/10/2013 at 15:33. Pushed by allananderson into branch 'master'. Related: bug 112947 when new fee entered in Dividend. Also, fixes for KEditWidget visibility issues. M +16 -12 kmymoney/dialogs/investactivities.cpp M +38 -19 kmymoney/dialogs/investtransactioneditor.cpp M +2-0kmymoney/dialogs/investtransactioneditor.h M +1-1kmymoney/dialogs/transactioneditor.cpp M +11 -0kmymoney/widgets/transactioneditorcontainer.h http://commits.kde.org/kmymoney/6b6aba3f1aaae3c6d7a1466492a8cdb478c10da8 -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
