[Koha-bugs] [Bug 4518] Enhance 2.2 to 3.0 scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4518 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy 2011-11-14 11:26:44 UTC --- Two small QA remarks. move_marc_to_authheader.pl This pertains to UNIMARC only. Is not clear from name of script or initial comments. Compare with warning in misc/migration_tools/upgradeitems.pl. upgradeitems.pl The way the code uses $rqitemnumber is somewhat questionable. Apparently, you want to check the existence of itemnumber from 995 in items table. In the for loop at the end only the last item number is passed to ModItemFromMarc. I assume that there should always only be one subfield 9. Code will work therefore, but could be improved. I set the status to Passed QA and let Paul decide if he wants to push or change status to Failed QA and work first on it. It should not stay on hold in the Signed Off queue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5981] OPAC: Add limits to search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 M. de Rooy changed: What|Removed |Added Patch Status|Signed Off |Does not apply --- Comment #21 from M. de Rooy 2011-11-14 11:33:08 UTC --- This patch is already SIGNED, but unfortunately does not apply. Please rebase. Applying: Bug 5981 : (MT 4231) Adds limits to search history /usr/share/koha/testclone/.git/rebase-apply/patch:101: trailing whitespace. ADD `limit_cgi` VARCHAR( 255 ) NULL DEFAULT NULL AFTER `limit_desc` warning: C4/Auth.pm has type 100755, expected 100644 error: patch failed: C4/Auth.pm:130 error: C4/Auth.pm: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:4446 error: installer/data/mysql/updatedatabase.pl: patch does not apply Using index info to reconstruct a base tree... :101: trailing whitespace. ADD `limit_cgi` VARCHAR( 255 ) NULL DEFAULT NULL AFTER `limit_desc` warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merged C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Auto-merged C4/Search.pm Auto-merged installer/data/mysql/kohastructure.sql Auto-merged installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-search-history.tt Auto-merged opac/opac-search.pl Failed to merge in the changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6328] Fine in days does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QAContact|koha-b...@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6670] Link patron name on returns screen to circulation page instead of patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6670 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch Status|Signed Off |Failed QA QAContact|koha-b...@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com --- Comment #10 from M. de Rooy 2011-11-14 11:44:09 UTC --- >From the above discussion I conclude that we are waiting on a new patch introducing such a preference. In the meantime I change the status to Failed QA in order to keep the signoff queue clean. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6670] Link patron name on returns screen to circulation page instead of patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6670 --- Comment #11 from M. de Rooy 2011-11-14 11:44:45 UTC --- signoff -> signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy changed: What|Removed |Added Attachment #5837|0 |1 is obsolete|| --- Comment #34 from M. de Rooy 2011-11-14 12:44:27 UTC --- Created attachment 6303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6303 Signed patch Rebased signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy changed: What|Removed |Added Patch Status|Signed Off |Passed QA --- Comment #35 from M. de Rooy 2011-11-14 12:45:42 UTC --- Some QA remarks (not blocking approval): systempreferences.pl This script is now only used for Local use. Adding a line for Patrons is no longer useful. patrons.pref Just a practical question: How does a user know the name of a field to exclude, e.g. B_address2 ? Could you show the fields in a popup when clicking on a link or so? I realize that the same holds for BorrowerMandatoryField. Maybe a small follow up? memberentry.pl regex, use of o modifier: Perl will not recompile the pattern unless an interpolated variable that it contains changes. You can force Perl to skip the test and never recompile by adding a /o (which stands for "once") after the trailing delimiter. The regex here does not contain a variable. Actually, I wonder if you need this regex at all here. Thank you for work and numerous rebasing! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6296] Allow authentication to Koha via PKI / x.509 certificates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6296
M. de Rooy changed:
What|Removed |Added
Patch Status|Signed Off |Failed QA
QAContact|koha-b...@lists.koha-commun |ian.walls@bywatersolutions.
|ity.org |com
--- Comment #12 from M. de Rooy 2011-11-14 12:59:13
UTC ---
Please resolve whitespace issues and rebase (syspref and updatedatabase).
Applying: Bug 6296: allow users to be authenticated by SSL client certs
/usr/share/koha/testclone/.git/rebase-apply/patch:29: space before tab in
indent.
my $borrower = GetMember(borrowernumber => $user);
/usr/share/koha/testclone/.git/rebase-apply/patch:30: space before tab in
indent.
if ($borrower) {
/usr/share/koha/testclone/.git/rebase-apply/patch:31: space before tab in
indent.
$borrowernumber = $user;
/usr/share/koha/testclone/.git/rebase-apply/patch:136: trailing whitespace.
SELECT borrowernumber, firstname, surname, flags,
borrowers.branchcode,
/usr/share/koha/testclone/.git/rebase-apply/patch:137: trailing whitespace.
branches.branchnameas branchname,
warning: C4/Auth.pm has type 100755, expected 100644
error: patch failed: installer/data/mysql/sysprefs.sql:327
error: installer/data/mysql/sysprefs.sql: patch does not apply
error: patch failed: installer/data/mysql/updatedatabase.pl:4523
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Using index info to reconstruct a base tree...
:29: space before tab in indent.
my $borrower = GetMember(borrowernumber => $user);
:30: space before tab in indent.
if ($borrower) {
:31: space before tab in indent.
$borrowernumber = $user;
:136: trailing whitespace.
SELECT borrowernumber, firstname, surname, flags,
borrowers.branchcode,
:137: trailing whitespace.
branches.branchnameas branchname,
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merged C4/Auth.pm
Auto-merged C4/Members.pm
Auto-merged installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merged installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #36 from Katrin Fischer 2011-11-14 13:06:20 UTC --- Hi Marcel, thx for QA :) We have the same problem for borrower import - the user does not know which fields correspond to which description in the user interface. Translation makes it even harder. I think the best we can do now is link to the database documentation - http://schema.koha-community.org/tables/borrowers.html -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7033] Make all strings translatable in marc21_field_007.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7033 M. de Rooy changed: What|Removed |Added Patch Status|Signed Off |Passed QA AssignedTo|frede...@tamil.fr |fcapovi...@live.ca QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #7 from M. de Rooy 2011-11-14 13:10:31 UTC --- Lot of work. Did you run code over the code? ;) If so, I could QA that for you.. QA Comment: This large patch only extensively covers the marc21 007 template. Looks good to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6303] Display Organisation and Parent Organisation names when viewing a borrower of type organistaion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303
M. de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
Patch Status|Signed Off |Does not apply
--- Comment #11 from M. de Rooy 2011-11-14 13:15:49
UTC ---
This patch is already SIGNED but unfortunately does no longer apply. Please fix
whitespace issues and rebase.
/usr/share/koha/testclone/.git/rebase-apply/patch:56: trailing whitespace.
# 'showname' which is the alternate form the user's first name if
/usr/share/koha/testclone/.git/rebase-apply/patch:444: trailing whitespace.
# in template => instutitional (A for Adult, C for children)
/usr/share/koha/testclone/.git/rebase-apply/patch:445: trailing whitespace.
$template->param( $data->{'categorycode'} => 1 );
/usr/share/koha/testclone/.git/rebase-apply/patch:499: trailing whitespace.
error: patch failed: circ/circulation.pl:629
error: circ/circulation.pl: patch does not apply
error: patch failed: members/moremember.pl:439
error: members/moremember.pl: patch does not apply
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6303] Display Organisation and Parent Organisation names when viewing a borrower of type organistaion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6321] Add a 1/4 month frequency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7220] Returns page message boxes being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220 Owen Leonard changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Failed QA AssignedTo|kyle.m.h...@gmail.com |chr...@catalyst.net.nz --- Comment #1 from Owen Leonard 2011-11-14 13:40:31 UTC --- I get a conflict when I try to apply this patch, either by git bz apply or git am -i3u. Viewing the conflict, it looks like there's an error in the changes made by this patch: <<< HEAD [% END %] === [% END %] >>> made appropriate changes so that user can customise the display of >>> messages on the returns page as per wr87151 This reverses the order of the [% END %] and the which doesn't look correct. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6321] Add a 1/4 month frequency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 M. de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy 2011-11-14 13:44:19 UTC --- QA Comment: The code for making the distinction between the various frequencies is actually asking for some refactoring. This patch just adds another case, but is easy to read and tested thoroughly, as can be seen above. Marking it as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7220] Returns page message boxes being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220 --- Comment #2 from Owen Leonard 2011-11-14 13:46:17 UTC --- Sorry, my description of the problem is clearly wrong, so pay no attention to that. The conflicts are there, however: <<< HEAD [% IF ( soundon ) %] [% END %] === [% IF ( soundon ) %] [% END %] >>> made appropriate changes so that user can customise the display of >>> messages on the returns page as per wr87151 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7079] Default values for German system preferences (web installer)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7079 M. de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED CC||m.de.r...@rijksmuseum.nl Patch Status|Signed Off |Passed QA QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #3 from M. de Rooy 2011-11-14 13:49:28 UTC --- QA Comment: Does only change some default values in German sql file. Looks good to me. Marking it as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7084] New Tag on results display missing results_summary class, causing display inconsistency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch Status|Signed Off |Passed QA QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #9 from M. de Rooy 2011-11-14 13:59:59 UTC --- QA: Very small template change. Marking it as Passed QA. Applies with one whitespace warning. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6916] Selecting the acq date of an item should take you to the invoice page for it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6916] Selecting the acq date of an item should take you to the invoice page for it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #7 from M. de Rooy 2011-11-14 14:33:33 UTC --- What could I be doing wrong if I see the accession date but it it not linked at all? I already changed AcqCreateItem to receiving an order. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6916] Selecting the acq date of an item should take you to the invoice page for it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916 --- Comment #8 from Katrin Fischer 2011-11-14 14:48:17 UTC --- Hi Marcel, I am not sure how this can happen and how much influence AcqCreateItem has here. It should link correctly, whether you create the item on order or on receive. Perhaps Robin has an idea. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6328] Fine in days does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328 --- Comment #38 from Paul Poulain 2011-11-14 16:18:32 UTC --- Ian, this bug is really important, sorry to bug you once again, bug I'd like to see it in 3.6.1 ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] New: DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 Bug #: 7221 Summary: DelBiblio POD is incorrect Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation AssignedTo: neng...@gmail.com ReportedBy: ian.wa...@bywatersolutions.com QAContact: ian.wa...@bywatersolutions.com C4::Biblio::DelBiblio's in-line documentation says it takes two params, $dbh and $biblionumber, but in reality, it only takes $biblionumber. Attempting to pass this extra param in a script will result in that script's failure. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207
--- Comment #3 from Ian Walls 2011-11-14
17:36:34 UTC ---
The line:
@item_numbers = grep{my $number=$_; $number = {item_number => $number}}
@item_numbers;
follows the same pattern as the two lines above; should it not also be
reverted? Can we confirm that labels with multiple item numbers work properly
with this change still in place?
What this original commit was trying to fix vs. what it actually did here seems
divergent... the original bug report is about declaring variables in
conditionals.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5226] MARC21 field 545 missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5226 M. de Rooy changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 --- Comment #1 from Joy Nelson 2011-11-14 18:56:48 UTC --- Created attachment 6304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6304 Patch file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com AssignedTo|neng...@gmail.com |j...@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 Joy Nelson changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 Ian Walls changed: What|Removed |Added Attachment #6304|0 |1 is obsolete|| --- Comment #2 from Ian Walls 2011-11-14 19:02:57 UTC --- Created attachment 6305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6305 Signed off patch Signed off patch... assigning to Jonathan for QA (since it's been just ByWater thus far in the writing/testing process) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7221] DelBiblio POD is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7221 Ian Walls changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off QAContact|ian.walls@bywatersolutions. |jonathan.dru...@biblibre.co |com |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7222] New: Display if a hold was placed in the OPAC or through the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7222 Bug #: 7222 Summary: Display if a hold was placed in the OPAC or through the staff interface Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests AssignedTo: ian.wa...@bywatersolutions.com ReportedBy: wizzy...@gmail.com QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com It would be nice to see whether a hold was patron-initiated through the patron catalog or placed by a staff member through the staff log-in. It'd help me a lot to know whether my staff is not paying close enough attention when placing holds or if it's the patron who is making mistakes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7220] Returns page message boxes being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220 --- Comment #3 from Chris Hall 2011-11-14 19:56:19 UTC --- Hey Owen I did the patch against a different koha master to the koha community one (oops), so if there are any issues I can create a new patch. However, isn't that conflict just a change in whitespace? unless I am missing something (which is a very real possibility). <<< HEAD [% IF ( soundon ) %] [% END %] === [% IF ( soundon ) %] [% END %] >>> made appropriate changes so that user can customise the display of >>> messages on the returns page as per wr87151 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7220] Returns page message boxes being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220 --- Comment #4 from Owen Leonard 2011-11-14 20:27:52 UTC --- Would a patch conflict just because of whitespace? I don't know. But if the patch conflicts because it's not based on master then it should be resubmitted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7220] Returns page message boxes being ignored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220 Chris Hall changed: What|Removed |Added Attachment #6301|0 |1 is obsolete|| --- Comment #5 from Chris Hall 2011-11-14 20:46:09 UTC --- Created attachment 6306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6306 patch against koha community master to add ids to return message dialogs Yeah git will complain about a change in whitespace as it sees tabs and spaces as characters. Attached is patch against koha community master, hopefully this will make git happier :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #4 from Liz Rea 2011-11-14 20:49:29 UTC --- Created attachment 6307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6307 Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern. Don't change $_ in a list context Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea changed: What|Removed |Added Attachment #6295|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #5 from Liz Rea 2011-11-14 20:50:35 UTC --- This latest attachment will need a new signoff, as it's got an additional change in it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea changed: What|Removed |Added Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7223] New: Move borrowerRelationship to Authorised Values list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7223 Bug #: 7223 Summary: Move borrowerRelationship to Authorised Values list Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration AssignedTo: paul.poul...@biblibre.com ReportedBy: ian.wa...@bywatersolutions.com QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com Rather than a system preference of pipe-delimited values (user unfriendly!), this list should be stored in our all-purpose Authorised Values engine. This will allow for a separation of Code and display values, as well as remove a system preference (there are too many) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6303] Display Organisation and Parent Organisation names when viewing a borrower of type organistaion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic changed: What|Removed |Added Attachment #5836|0 |1 is obsolete|| --- Comment #12 from Srdjan Jankovic 2011-11-14 23:22:32 UTC --- Created attachment 6308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6308 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6303] Display Organisation and Parent Organisation names when viewing a borrower of type organistaion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7201] Hold to pull sreport needs extra fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic changed: What|Removed |Added Attachment #6264|0 |1 is obsolete|| --- Comment #3 from Srdjan Jankovic 2011-11-15 03:04:35 UTC --- Created attachment 6309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6309 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7201] Hold to pull sreport needs extra fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff --- Comment #4 from Srdjan Jankovic 2011-11-15 03:06:47 UTC --- Actually the original request was for the copy number, just wasn't formulated properly, and I copied it blindly. Serves me right. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Srdjan Jankovic changed: What|Removed |Added Attachment #5477|0 |1 is obsolete|| --- Comment #22 from Srdjan Jankovic 2011-11-15 07:07:36 UTC --- Created attachment 6310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6310 patch * I have removed numbering from the results * On the results page, numbers are coming from the record XML, so they are not affected with our post processing. In order to change that we would need to either a) change XML on the fly, or b) introduce same Hide items logic to XSLT I am mentioning b) just for the sake of completeness, I would not even contemplate that. * I tried details screen with items of different types scenario, and it came right. That is after reindexing zebra. Can you please retest that, and if it still does not come up right then we definitely need either some screenshots of item details, or preferably the database dump. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Srdjan Jankovic changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
