[Koha-bugs] [Bug 7359] Begin migration to a new Koha namespace from the old C4 namespace

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7359

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger mag...@enger.priv.no 2011-12-15 08:35:24 UTC 
---
This is a topic for the General IRC Meeting, 4 January 2012: 
http://wiki.koha-community.org/wiki/General_IRC_Meeting,_4_January_2012

See also: http://wiki.koha-community.org/wiki/Namespace_QA_Rules

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com 2011-12-15 
08:54:58 UTC ---
Hi Ian,
I think I found the problem :)
I fact, I check in from the circ/circulation.pl table, and this script call
circ/renewscript and not circ/returns.pl.

In this script, error messages are not caught and sent to the template.

But renewscript.pl redirects to circulation.pl. Thus to transmit the message,
it's not easy nor clean :-/

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #31 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-15 09:14:21 
UTC ---
Just some comments from testing again:

The distinction between nonlinear and linear by using DEBUG is a good thing!

Patch 2 and 3 need rebasing. If you do, could you squash everything? Will make
it easier for additional testers.

If the last db rev fails (as in your examples), you allow access to the staff
client (in standard mode) and you are not going to update page again, I wonder
if that's what you want. There is a problem and shouldn't it be solved first?

If in dev mode I run the third db rev only WHILE table already EXISTS, I feel
that the returned message is not so clear. And if I do not mark it as OK and I
come back at update page, I can still execute it again. Would it not be better
to mark it as Failed?

Clicking Home in dev mode still brings me to update page (earlier comment!).

About says: 3.6.2.1 / 3.7.1.3, but I did not install 1  2 ? Personally, I do
not prefer the A .. B, C .. D listing that is now possible too.

Since this is a larger change, I do not feel that my tests and [probably] those
of Chris N really cover all situations. Wouldn't it be better to ask for some
additional signoffs too?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

   Attachment #6605|0   |1
is obsolete||

--- Comment #16 from Koustubha Kale kmk...@anantcorp.com 2011-12-15 09:42:31 
UTC ---
Created attachment 6806
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6806
[SIGNED-OFF] Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser

AutoEmailPrimaryAddress is not only used for the patron account mails, but
also for overdues and other email notices to patrons.

This patch separates the system preferences in the system preference editor.

To test:
- Check Patrons tab shows both system preferences separated
- Check you can still change the settings

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
Signed-off-by: Koustubha Kale kmk...@anantcorp.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

   Attachment #6789|0   |1
is obsolete||

--- Comment #17 from Koustubha Kale kmk...@anantcorp.com 2011-12-15 09:45:38 
UTC ---
Created attachment 6807
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6807
[SIGNED-OFF] 6302 follow up

Updates to_address in message queue when sending an email (when needed).

Signed-off-by: Koustubha Kale kmk...@anantcorp.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

 CC||kmk...@anantcorp.com

--- Comment #18 from Koustubha Kale kmk...@anantcorp.com 2011-12-15 09:49:12 
UTC ---
(In reply to comment #16)
 Created attachment 6806 [details]
 [SIGNED-OFF] Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser
 
 AutoEmailPrimaryAddress is not only used for the patron account mails, but
 also for overdues and other email notices to patrons.
 
 This patch separates the system preferences in the system preference editor.
 
 To test:
 - Check Patrons tab shows both system preferences separated
 - Check you can still change the settings
 
 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
 Signed-off-by: Koustubha Kale kmk...@anantcorp.com

1) Verified that prior to applying patch one the System preferences
AutoEmailOpacUser and AutoEmailPrimaryAddress were combined.
2) after applying first patch, verified that there were two separate system
preferences for AutoEmailOpacUser and AutoEmailPrimaryAddress

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

--- Comment #19 from Koustubha Kale kmk...@anantcorp.com 2011-12-15 09:50:30 
UTC ---
(In reply to comment #17)
 Created attachment 6807 [details]
 [SIGNED-OFF] 6302 follow up
 
 Updates to_address in message queue when sending an email (when needed).
 
 Signed-off-by: Koustubha Kale kmk...@anantcorp.com

3) Verified that before applying patch two, after running
process_message_queue.pl, the to_address field in table message_queue had null
for Item Overdue notice. 
4) Verified that after applying patch two , after running
process_message_queue.pl, the to_address field in table message_queue had
patrons email address in it.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #6782|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com 2011-12-15 
11:08:08 UTC ---
Created attachment 6808
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6808
Proposed patch

Hi Katrin,

1a/ Corrected
(my english is very poor as you see :-/)

1b/ Normally, the from field is created with the email key of
C4::Context-userenv. This one get the email field from database for the logged
user. Maybe you're logged as root ?
I tried, it works for me.

2/ I forgot a replacement :-/

3/ Ok; it's done

4/ No, I didn't modifify this section. I just add a warning to display the sent
message.

I added biblio and biblioitems in the field list when you modify a notice
template.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7349] Sorting patron search result by cardnumber doesn't work

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

   Attachment #6752|0   |1
is obsolete||

--- Comment #7 from Koustubha Kale kmk...@anantcorp.com 2011-12-15 11:29:50 
UTC ---
Created attachment 6809
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6809
[SIGNED-OFF] Bug 7349: corrects sort order for Patron search

Sorting by cardnumber now works (removed a client-side
sort, the server-side sort is enough).

Signed-off-by: Koustubha Kale kmk...@anantcorp.com

1) Verified that before applying this patch, when searching patrons with
cardnumber as order by preference, patrons are sorted ny name.
2) Verified that after applying this patch, when searching with cardnumber as
order by preference, patrons are correctly sorted by cardnumber.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7349] Sorting patron search result by cardnumber doesn't work

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349

Koustubha Kale kmk...@anantcorp.com changed:

   What|Removed |Added

 CC||kmk...@anantcorp.com
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7361] 'Default' encoding in staged marc import breaks diacritics

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7361

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #4 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-15 
12:25:14 UTC ---
Template-only change, passes a much better default than empty string.  marking
as passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7349] Sorting patron search result by cardnumber doesn't work

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #8 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-15 
12:32:17 UTC ---
Template only change, removes JS block only.  Marking as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7185] Update to 3.6 says Koha release 3.4

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7185

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:33:37 UTC ---
follow-up for simple typo release notes pushed

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6302] Failing to send email notices - to_address not set

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6727|0   |1
is obsolete||

--- Comment #62 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:46:30 UTC ---
Comment on attachment 6727
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6727
[SIGNED-OFF] Added unit tests for Sip Checksum.pm

patch pushed please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6728|0   |1
is obsolete||

--- Comment #63 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:47:12 UTC ---
Comment on attachment 6728
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6728
[SIGNED-OFF] Added unit test for AuthoritiesMarc/UNIMARC.pm

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6729|0   |1
is obsolete||

--- Comment #64 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:47:36 UTC ---
Comment on attachment 6729
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6729
[SIGNED-OFF] Added unit tests for Scrubber

patch pushed please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6730|0   |1
is obsolete||

--- Comment #65 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:48:04 UTC ---
Comment on attachment 6730
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6730
[SIGNED-OFF] Bug 5327: Patch removes unneeded self=shift from
TTParser::unshift_token

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6805|0   |1
is obsolete||

--- Comment #66 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:54:08 UTC ---
Comment on attachment 6805
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6805
[SINGED-OFF] Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm

patch pushed

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6732|0   |1
is obsolete||

--- Comment #67 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:54:47 UTC ---
Comment on attachment 6732
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6732
[SIGNED-OFF] Added missing reference case to Boolean.t and corrected count

patch pushed

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #68 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
12:55:27 UTC ---
QA comments:
2 tests not merged:
 TEST 1 
[SIGNED-OFF] Added coverage to unit test for TTParser

I don't understand what this patch is adding. A little bit more explanatory on
the commit notes welcomed...

 TEST 2 
Applying: Moving SIP_ILS.t to db_dependent
fatal: sha1 information is lacking or useless (t/SIP_ILS.t).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Moving SIP_ILS.t to db_dependent
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #6 from Marc Balmer m...@msys.ch 2011-12-15 13:07:22 UTC ---
(In reply to comment #5)
 Patch 1 is okay now. Looking forward to update of 2, 3 and 4.

Patch 3 does not change any .po files, it should be ok, right?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-15 13:10:43 
UTC ---
(In reply to comment #6)
 (In reply to comment #5)
  Patch 1 is okay now. Looking forward to update of 2, 3 and 4.
 Patch 3 does not change any .po files, it should be ok, right?

OK. Overlooked something?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5533] marking item lost diff in two places

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533

--- Comment #32 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-15 
13:29:24 UTC ---
Created attachment 6810
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6810
Proposed followup patch

removes filter that was preventing Lost status from being editable in the Edit
Items screen.  Numerous libraries have complained about losing this ability,
even when they understand it was removed to force consistent 'lost' behaviour.

The default framework is altered to hide this field for new installs.  It can
be restored to the interface by editing the 'hidden' value for the itemlost
subfield. 

This method hides the preference by default, but allows libraries who
understand the implications of what they're doing (and accept the risks) to
have more control over their workflows.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

Marc Balmer m...@msys.ch changed:

   What|Removed |Added

   Attachment #6780|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #8 from Marc Balmer m...@msys.ch 2011-12-15 13:41:58 UTC ---
Created attachment 6811
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6811
wether - whether

Changes only code, not .po files.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #9 from Marc Balmer m...@msys.ch 2011-12-15 13:42:42 UTC ---
Created attachment 6812
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6812
the the - the

No more changing of the the .po files ;)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-15 14:20:47 
UTC ---
Applying: developper - developer.
error: patch failed: authorities/authorities.pl:204
error: authorities/authorities.pl: patch does not apply
error: patch failed: cataloguing/addbiblio.pl:414
error: cataloguing/addbiblio.pl: patch does not apply
error: patch failed: cataloguing/plugin_launcher.pl:27
error: cataloguing/plugin_launcher.pl: patch does not apply
Patch failed at 0001.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

Marc Balmer m...@msys.ch changed:

   What|Removed |Added

   Attachment #6779|0   |1
is obsolete||

--- Comment #11 from Marc Balmer m...@msys.ch 2011-12-15 14:23:57 UTC ---
Created attachment 6813
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6813
developper - developer

re-created.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

--- Comment #12 from Marc Balmer m...@msys.ch 2011-12-15 14:31:52 UTC ---
(In reply to comment #10)
 Applying: developper - developer.
 error: patch failed: authorities/authorities.pl:204
 error: authorities/authorities.pl: patch does not apply
 error: patch failed: cataloguing/addbiblio.pl:414
 error: cataloguing/addbiblio.pl: patch does not apply
 error: patch failed: cataloguing/plugin_launcher.pl:27
 error: cataloguing/plugin_launcher.pl: patch does not apply
 Patch failed at 0001.

ok. I have to merge to patches now, sorry.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6142] CanBookBeReserved function is redefined in C4/ILSDI/Utility.pm

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6142

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch Status|Signed Off  |Failed QA

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-15 14:32:26 
UTC ---
Question seems unanswered. Changing status to reflect pending status.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

Marc Balmer m...@msys.ch changed:

   What|Removed |Added

   Attachment #6811|0   |1
is obsolete||
   Attachment #6813|0   |1
is obsolete||

--- Comment #13 from Marc Balmer m...@msys.ch 2011-12-15 14:32:35 UTC ---
Created attachment 6814
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6814
wether - whether, developper - developer

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7321] Silence warns in Koha.pm

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7321

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch Status|Signed Off  |Passed QA

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-15 14:36:18 
UTC ---
Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] FIx various typos and mis-spellings

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

Marc Balmer m...@msys.ch changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6805|1   |0
is obsolete||

--- Comment #70 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
15:19:00 UTC ---
Comment on attachment 6805
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6805
[SINGED-OFF] Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm

push reverted, make jenkins unhappy, seems it's a database problem thing so the
other ILS moved to db_dependant is required to have this one working

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Patch Status|Signed Off  |Failed QA

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
15:50:33 UTC ---
QA comment:
Owen, shouldn't
+h2Search results/h2

be spelled 
+h2Z39.50 Search results/h2
for an even more relevant title ? (I fear that catalogue Search result could
be translated in a different way, and be displayed here, resulting in something
strange)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7323] Javascript error when editing list

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7323

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
15:58:51 UTC ---
QA comment : tiny patch, fixes the problem

passed QA

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7325] Editing a list generates errors in the log

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7325

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
16:12:02 UTC ---
QA comment: tiny patch, remove log noise, passed QA

patch pushed, please test

PS: totitem could also have been quieted by defaulting to 0. That could have
been cleaner, but that could also be debated for years, so accepting this one
;-)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7326] longoverdue.pl was hardcoded to 1 year, is now a parameter

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7326

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed
Summary|longoverdue.pl hardcoded to |longoverdue.pl was
   |1 year max  |hardcoded to 1 year, is now
   ||a parameter

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
16:15:00 UTC ---
QA comment: small patch, new feature documented, default behaviour unchanged
(++ for existing setups)

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

--- Comment #4 from Owen Leonard oleon...@myacpl.org 2011-12-15 16:24:39 UTC 
---
(In reply to comment #3)
 Owen, shouldn't
 +h2Search results/h2
 
 be spelled 
 +h2Z39.50 Search results/h2

A valid question. Here's my reasoning:

- First, the patch changes the heading from h2Results/h2 to h2Search 
  results/h2, so it's actually more specific than it was before.
- The link which brings you to this search reads [order] From an external
  source, so I added the Order from an external source terminology to the
  search page itself (in the title and breadcrumbs)
- With that in mind I changed the heading of the search form from Z39.50
  Search Points to Order from external source. At this point there 
  is no reference anywhere to Z39.50 which would necessitate the use of
  the term on the search results page.

I see that when translating from English the phrase Search results could be
interpreted as the results of your search or search the results. Is that
the problem?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7333] Cleaning up tests to use sample data

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333

--- Comment #8 from Liz Rea wizzy...@gmail.com 2011-12-15 16:29:12 UTC ---
Created attachment 6815
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6815
Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris
N. for helping figure out that it was because there were no French stopwords in
the DB that the test was failing.

Patch changes the French string (with French stopwords) to an English string
with English stopwords, as only English stopwords are installed in the default
data.

This patch will allow Search.t to run on the database attached to this bug.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7333] Cleaning up tests to use sample data

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333

Liz Rea wizzy...@gmail.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7330] System preferences editor generates errors in the log with each search

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8
   Patch Status|Signed Off  |Patch Pushed

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
16:37:13 UTC ---
QA comment:
well I feel I shouldn't accept a patch that says fixes the problem, but I
don't know why... OTH, preferences.pl is poorly documented, it fixes the
problem, and I couldn't find any side effect. I couldn't understand why those
empty values are here though.

So:

passed QA

patch pushed, please test

chris_n = I would wisely say don't push this on 3.6. If there is a side effect
we couldn't detect, we can hope someone else will spot it in the next 4 months
before 3.8 is released

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7331] Circulation.pl generates errors in the log

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7331

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed

--- Comment #7 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
16:38:37 UTC ---
QA comment: tiny patch, silent log

passed QA

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7328] Expanded options in advanced search

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328

--- Comment #4 from Frédéric Demians frede...@tamil.fr 2011-12-15 16:44:15 
UTC ---
 QA comment :

Thanks for going through this patch.

 I can't see any difference with and without the patch.
 Frédéric, looking at your code, it seems it does something only if the
 syspref is not defined, which should not happend.

I don't think so.

Expanded search option are passed with a CGI param, it is used (and
controlled), otherwise syspref is used.

 Marking failed QA until I have more information about how to reproduce
 the problem

1. On HEAD, in intra interface, enable expandedSearchOption syspref
2. Click Search link in the top links bar.
3. Next to Search button, you can see [More options] link. This is wrong.
   We should have [Fewer options] 
4. Commit the patch
5. Repeat 1-2
6. Next to Search button, you have [Fewer options] link. This is
   correct.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7332] Translated title (MARC21 field 242) doesn't display

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7332

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
16:56:39 UTC ---
QA comment: started a thread on koha-devel to see if we must have a policy for
XSLT changes

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7333] Cleaning up tests to use sample data

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
17:15:08 UTC ---
patch 
[SIGNED-OFF] Bug 7333 - modifying Members.t to use a branchcode that exists in
the sample data

pushed

QA comment : fixes the problem (i made a fresh install of sample database)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7334] Improve 'No address stored' and similar messages in patron account

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
17:21:19 UTC ---
QA comment: small patch related to templates, works

prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok 


passed QA

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7346] 'perl translate install' creates template directories for invalid languages

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
   Patch Status|Signed Off  |Patch Pushed
   Severity|normal  |minor

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2011-12-15 
17:39:18 UTC ---
QA comment: tiny patch, usefull, works

passed QA

patch pushed, please test


Welcome Marc Balmer, you're 167th

Marc: you should not have signed-off this patch by yourself. It's a tiny one,
works fine, so i'm pushing it. But usually, the sign-off must not be made by
the author.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7346] 'perl translate install' creates template directories for invalid languages

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346

--- Comment #5 from Marc Balmer m...@msys.ch 2011-12-15 17:42:49 UTC ---
(In reply to comment #4)
 QA comment: tiny patch, usefull, works
 
 passed QA
 
 patch pushed, please test
 
 
 Welcome Marc Balmer, you're 167th
 
 Marc: you should not have signed-off this patch by yourself. It's a tiny one,
 works fine, so i'm pushing it. But usually, the sign-off must not be made by
 the author.

credit whom credit is due:  I reported the problem, it was Fréderic Demians who
suggested the patch, I did test it and thus signed it off.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6142] CanBookBeReserved function is redefined in C4/ILSDI/Utility.pm

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6142

MJ Ray (software.coop) m...@ttllp.co.uk changed:

   What|Removed |Added

   Attachment #6027|0   |1
is obsolete||

--- Comment #10 from MJ Ray (software.coop) m...@ttllp.co.uk 2011-12-15 
19:14:02 UTC ---
Created attachment 6817
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6817
Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on
@EXPORT

Original-Author:Alex Arnaud alex.arn...@biblibre.com, Stéphane Delaune
stephane.dela...@biblibre.com
Original-Signed-off-by: MJ Ray m...@phonecoop.coop

Correct use statement bug found by Ian Walls

Author: MJ Ray m...@phonecoop.coop

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6933] Add a view of titles with a particular tag to the staff client

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6933

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #6816|0   |1
is obsolete||

--- Comment #9 from Nicole C. Engard neng...@gmail.com 2011-12-15 19:25:16 
UTC ---
Created attachment 6818
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6818
[SIGNED-OFF] Bug 6933 [REVISED] Add a view of titles with a particular tag to
the staff client

- Adds a new page to the tags moderation section for viewing all the
  titles tagged with a particular term.
- Adds display of approved tags to the catalog detail page matching the opac
  view. Adding tags from the detail view not implemented.

Follow-up adds tags display to XSLT detail view

Areas for improvement:

- I think it would be better to show Also tagged with: and exclude
  the current tag from the list of titles tagged with a particular tag.
- It would be nice to be able to show unapproved tags (and some idication of
  their status) along with approved tags on the detail page if the user had
  TagsModeration permission.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6933] Add a view of titles with a particular tag to the staff client

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6933

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Patch Status|Needs Signoff   |Signed Off

--- Comment #10 from Nicole C. Engard neng...@gmail.com 2011-12-15 19:25:44 
UTC ---
Love it - great addition. I've signed off. I tested with XSLT on and off in the
staff client.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7345] Should be possible to export MARC records without private fields

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7345

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Signed Off

--- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com 2011-12-15 
19:48:32 UTC ---
Paul,

(In reply to comment #7)
 QA comment: I must be dumb, but: the test plan include some jquery. this is OK
 for testing. But in real life, how will we control it we export 9 or no ?

No, you're not dumb. There is no user interface change. I suggested the jQuery
so that people could just copy-and-paste something for testing, rather than
needing to modify a URL by hand. I don't think we should change the behavior in
the OPAC without a compelling reason, if everyone's been happy with it as it is
for over a decade. However, as a web service, opac-export.pl and export.pl
really need to be able to provide standard MARC to services like RefWorks
(well, actually, RefWorks doesn't support MARC at all, but that's another
story).

 marking failed QA until I understand, switch back to signed-off once you've
 answered

Will do.

Regards,
Jared

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #71 from Duncan dun...@catalyst.net.nz 2011-12-15 19:49:40 UTC ---
Created attachment 6819
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6819
Corrected findbin path for SIP_ILS bug 5327

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7078] HTML::Template::Pro still listed as Koha dependency

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7078

Liz Rea wizzy...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||wizzy...@gmail.com
 Resolution||FIXED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080

Duncan dun...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #6029|0   |1
is obsolete||
   Attachment #6031|0   |1
is obsolete||
   Attachment #6032|0   |1
is obsolete||
   Attachment #6033|0   |1
is obsolete||
   Attachment #6034|0   |1
is obsolete||
   Attachment #6035|0   |1
is obsolete||
   Attachment #6036|0   |1
is obsolete||

--- Comment #8 from Duncan dun...@catalyst.net.nz 2011-12-15 21:35:12 UTC ---
Created attachment 6820
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6820
Signed off patch

Patch looks good, signing off.

I noticed some inconsistency in the tab titles in the fines tab for a patron.
Follow up patch will follow to fix this trivial issue.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080

Duncan dun...@catalyst.net.nz changed:

   What|Removed |Added

 CC||dun...@catalyst.net.nz

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080

--- Comment #9 from Duncan dun...@catalyst.net.nz 2011-12-15 23:08:01 UTC ---
Created attachment 6821
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6821
Changed casing on tab titles for fines page - bug 7080

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6843] Renew membership from expiry date or from current date

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6843

Duncan dun...@catalyst.net.nz changed:

   What|Removed |Added

 CC||dun...@catalyst.net.nz
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6843] Renew membership from expiry date or from current date

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6843

--- Comment #3 from Duncan dun...@catalyst.net.nz 2011-12-15 23:22:05 UTC ---
Created attachment 6822
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6822
Signed off patch - bug 6843

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7362] Allow searching by item number as a fallback

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7362

--- Comment #5 from Robin Sheat ro...@catalyst.net.nz 2011-12-15 23:29:14 UTC 
---
Also, going to add returning by item number to this.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #6791|0   |1
is obsolete||

--- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com 
2011-12-16 02:36:59 UTC ---
Created attachment 6823
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6823
Bug 1633 - Interface revisions for the staff client

This patch revises the image viewer page to match other
biblio detail pages: a toolbar, a sidebar menu, etc.

Additional data is now pulled by imageviewer.pl in order
to provide information necessary for the proper functioning
of the toolbar and menus: item counts, hold availability,
biblio view options.

Other changes have been made to match the changes in the
OPAC interface like styling of the images and no-javascript
compatibility

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6843] Renew membership from expiry date or from current date

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6843

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #6781|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #6821|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
05:36:45 UTC ---
Created attachment 6824
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6824
[SIGNED-OFF] Bug 7080: Changed casing on tab titles for fines page

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Small change for consistency.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #6608|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
05:52:05 UTC ---
Created attachment 6825
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6825
Bug 7324: Show alternate email as mailto: / hide labels when field is empty

UPDATE 2011-12-15
Fixed wrong div that broke the patron account display.
Thank you Paul for catching this!

Changes made to the patron detail tab:
- alternate email shows as mailto: link

- labels for following fields only show when field is filled
  - initials
  - date of birth
  - gender
  - country (alternate address)
  - email (alternate address)
  - state (alternative contact)
  - country (alternative contact)
  - phone (alternative contact)

To test:
1) Add new patron with minimal data and check the labels don't show
2) Change patron to have data in changed fields and check labels show
3) Check all email addresses are shown as mailto: links now

Signed-off-by: Liz Rea wizzy...@gmail.com
Verified tests 1-3, looks good to me.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch Status|Failed QA   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #6799|0   |1
is obsolete||
   Attachment #6805|0   |1
is obsolete||
   Attachment #6819|0   |1
is obsolete||

--- Comment #72 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
06:00:03 UTC ---
Created attachment 6826
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6826
[SIGNED-OFF] Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Test requires a database installed using the sample data.
All tests pass.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #74 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
06:02:39 UTC ---
Created attachment 6828
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6828
[SIGNED-OFF] Bug 5327: Corrected findbin path for SIP_ILS bug 5327

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Tests run successfully now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #75 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
06:03:30 UTC ---
The last 3 patches for the SIP tests go together (attachments 6826-6828)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

--- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
06:40:15 UTC ---
1) - 4) resolved - thx again! This gets more beautiful every time I look at it
and it converts the late orders into a really useful feature.

There is only one more problem I spotted and I hope it can be resolved easily.
The diacritics in my email are broken. I used titles and a vendor name with
umlauts. They display is wrong in my web client and in Thunderbird.


B�cherschiff


Ordernumber 1 (Handbuch der Religionsp�dagogik.) (1 ordered) ($10.00 each) has
not been received.


Ordernumber 2 (Das Sch�ne Konstanz am Bodensee und Rhein, die alte Stadt im
deutschen S�den  (1 ordered) ($10.00 each) has not been received.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7116] Item form when ordering in batch from staged marc has lots of white space for hidden fields

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7116

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7247] rebuild_zebra.pl -v should show all Zebra log output

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7247

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
07:08:47 UTC ---
Hi Dobrica, 
I tested the option and the new help. It states to use -vv for more output.
Perhaps I am missing some common syntax here, but you have to type -v -v to
make it work, while -vv doesn't. Perhaps we can make the help more clear?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7329] The undo import into catalog command deletes items onloan without checking

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch Status|Needs Signoff   |Failed QA

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
07:23:12 UTC ---
I noticed 2 some problems for this patch:

1) I had one item checked out and 1 available item with missing home and
holding branch (not sure that was the reason). Both were not removed from the
catalog.

2) After 'undoing' the import the bib# for the 2 records remaining in the
catalog due to errors were gone from the list. 

3) I reimported and the bib# were still missing.

4) I undid the import again and now it reports to have removed all records. My
2 problematic records show up in the list as reverted, but they are still
available in my catalog.

I think 3) and 4) are perhaps side effects of 2)?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7329] The undo import into catalog command deletes items onloan without checking

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
07:23:37 UTC ---
Created attachment 6829
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6829
screenshot after step 1)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6943] Create new budget from a copy of a previous budget

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-16 
07:28:20 UTC ---
End of year is near and I think it's the right time to give this a little push
:)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7355] Note subfields are not displayed in TEXTAREA if hidden

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Attachment #6776|0   |1
is obsolete||

--- Comment #3 from Frédéric Demians frede...@tamil.fr 2011-12-16 07:35:05 
UTC ---
Created attachment 6830
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6830
Proposed patch

Thanks Katrin for testing. Rebased on HEAD. No more syntax error...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7355] Note subfields are not displayed in TEXTAREA if hidden

2011-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7355

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/