[Koha-bugs] [Bug 7409] Missing dependencies for Debian package

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #1 from Magnus Enger mag...@enger.priv.no 2012-01-06 08:08:24 UTC 
---
*** Bug 7389 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7389] List unzip as a dependency

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7389

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Magnus Enger mag...@enger.priv.no 2012-01-06 08:08:24 UTC 
---


*** This bug has been marked as a duplicate of bug 7409 ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7264] Display information about library on OPAC detail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7264

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger mag...@enger.priv.no 2012-01-06 09:23:28 UTC 
---
This looks like a nice enhancement, but I fear we will never agree on what
should and should not be displayed in the popup... Would it be possible to add
a syspref that

- disables the feature if it's empty
- takes a template with placeholders for the different fields that describe the
libraries, so each library could format the contents of the popup to their
heart's content? 

I'm attaching a screenshot of what the current patch looks like, to make it
easier for others to add their opinion.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7264] Display information about library on OPAC detail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7264

--- Comment #3 from Magnus Enger mag...@enger.priv.no 2012-01-06 09:24:10 UTC 
---
Created attachment 7059
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7059
Screenshot of library details displayed in the OPAC

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7264] Display information about library on OPAC detail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7264

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
09:28:21 UTC ---
I think i agree with Magnus - not every library will want all the data from the
branches table to be displayed in the OPAC. 

I would really like to see that as an option, a syspref with a list of fields
to display perhaps and leaving it empty when you don't want it to display. With
TT such things have become a lot easier to do!

Is it possible to click on the mail adress? I can't see from the screenshot.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #10 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-06 
09:32:29 UTC ---
I'm preparing a patch where the whole path has to be stored in the system
preference, but I have a doubt about C4/Auth.pm, which contains the following
code at line 445 :

  OPACBaseURL   = ($in-{'query'}-https() ? https://; :
http://;) . $ENV{'SERVER_NAME'} .
   ($ENV{'SERVER_PORT'} eq ($in-{'query'}-https() ? 443 :
80) ? '' : :$ENV{'SERVER_PORT'}),


Should I replace this by a simple :

  OPACBaseURL = C4::Context-preference('OPACBaseURL')

or is there a reason to keep such a construction with SERVER_PORT ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7264] Display information about library on OPAC detail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7264

--- Comment #5 from Magnus Enger mag...@enger.priv.no 2012-01-06 09:32:38 UTC 
---
(In reply to comment #4)
 Is it possible to click on the mail adress? I can't see from the screenshot.

Good question! No, it's not. (At least not in FF8 on Ubuntu). The popup follows
the mouse pointer, and you can't moce the mouse pointer over the popup, if you
try it disappears. So turning the address into a clickable link might not make
too much sense.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #11 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-06 
09:36:12 UTC ---
Well, in fact OPACBaseURL is not necessarily filled with a value, so I guess
I'll just use this code when it's empty, otherwise we use what's stored in the
system preference.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7410] New: Wrong price calculation on order page

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7410

 Bug #: 7410
   Summary: Wrong price calculation on order page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
   URL: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1ba
sketno=2biblionumber=5
OS/Version: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Acquisitions
AssignedTo: henridam...@koha-fr.org
ReportedBy: katrin.fisc...@bsz-bw.de
 QAContact: ian.wa...@bywatersolutions.com


Created attachment 7060
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7060
price calculation on order form

Ok, my settings are:

- gist = 0
- vendor tax rate = 10.00
- list price does include tax
- no discount

Unit price: 8.00
Replacement cost: 6.99
Budgeted cost: 6.99
Total: 6.99

I might be wrong here... but shouldn't it be 7.20?

Wrong calculations in acq are not good at all.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7410] Wrong price calculation on order page

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7410

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
09:40:47 UTC ---
Created attachment 7061
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7061
vendor

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7410] Wrong price calculation on order page

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7410

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
09:46:57 UTC ---
Chris had the right idea, currency exchange rate for EUR was not set to 1 -
sorry!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

   Attachment #6567|0   |1
is obsolete||

--- Comment #12 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-06 
09:59:29 UTC ---
Created attachment 7062
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7062
proposed patch #2

Effects of the patch :
1) OPACBaseURL must now contain the full address with http:// or https://
(system preference help changed accordingly)
2) The RSS Feed in OPAC results now handle OPACBaseURL

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7388] rounded corners for side menus in staff client

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7388

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   Attachment #6964|0   |1
is obsolete||

--- Comment #7 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:00:31 UTC 
---
Created attachment 7063
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7063
Bug 7388 [SIGNED-OFF] [enh] - round the corners on the side menus in the staff
client

To test:
apply patch
check menus on circulation and bib detail page - corners on the menus to the
left should be rounded.

Signed-off-by: Magnus Enger mag...@enger.priv.no
Those rounded corners do look more friendly. I have tested circulation and bib
detail page and
have found no ill side effects.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7388] rounded corners for side menus in staff client

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7388

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no
   Patch Status|Needs Signoff   |Signed Off

--- Comment #8 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:03:59 UTC 
---
I have tested and signed off on the first patch, the one called round the
corners on the side menus in the staff client. I'm changing the status to
Signed Off, but if that patch gets pushed the status should be reset to
Needs signoff for the remaining patches. Or maybe those batches could be
moved to one or more separate bugs?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7388] rounded corners for side menus in staff client

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7388

--- Comment #9 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:05:06 UTC 
---
So just to be completely clear: attachment 7063 is the only one I have signed
off, pending further discussion of the other patches.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7411] New: remove diacritics when automatically generating userid

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411

 Bug #: 7411
   Summary: remove diacritics when automatically generating userid
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: rel_3_6
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
AssignedTo: kyle.m.h...@gmail.com
ReportedBy: sophie.meyni...@biblibre.com
 QAContact: ian.wa...@bywatersolutions.com
CC: gmcha...@gmail.com


When userid is automatically generated from firstname and surname, diacritics
should be removed because login with diacritics may results in failure

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7029] searching : fuzzy et steming

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-06 
10:20:47 UTC ---
No big problem actually. There was a mistake in the French translation of the
QueryFuzzy values.

Don't try was replaced with Activer
Try was replaced with Désactiver

It should be the opposite.


The translation in the Koha Translation Project has been updated.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7165] Add biblio and biblioitems fields for claimacquisition letter

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7165

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Depends on||5347

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||7165

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7165] Add biblio and biblioitems fields for claimacquisition letter

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7165

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com 2012-01-06 
10:29:18 UTC ---
already developped for Bug 5347.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163

Bug 7163 depends on bug 7165, which changed state.

Bug 7165 Summary: Add biblio and biblioitems fields for claimacquisition letter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7165

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5358] keep track of cancelled orders

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5358

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

 CC||christophe.croullebois@bibl
   ||ibre.com
   Patch Status|Needs Signoff   |Signed Off

--- Comment #6 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-06 10:40:32 UTC ---
ok fine, easy and usefull.
Signed off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
 Status|NEW |ASSIGNED
   Patch Status|--- |Needs Signoff
 AssignedTo|kyle.m.h...@gmail.com   |sophie.meyni...@biblibre.co
   ||m

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411

--- Comment #2 from Sophie MEYNIEUX sophie.meyni...@biblibre.com 2012-01-06 
10:46:47 UTC ---
http://mantis.biblibre.com/view.php?id=7744

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5358] keep track of cancelled orders

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5358

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Attachment #7011|0   |1
is obsolete||

--- Comment #7 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-06 10:49:55 UTC ---
Created attachment 7065
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7065
signed-off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7357] Subscriptions titles are replaced by --- when duplicated

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7357

--- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-06 
10:51:17 UTC ---
Our customer just asked for the title to appear instead of this '---' string. I
really think it would be enough, and don't see any real advantage in doing
something complicated here.

I'll wait for a community decision, but my vote would go for the simple removal
of this replace TITLE with --- rule.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #10 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:55:22 
UTC ---
Nice enhancements! Just a couple of questions/suggestions: 

1. Could it be a good idea to use authorized values for class names? That would
leave less room for typos and make it possible to change the name of a class
without changing every attribute that uses that class. 

2. When a patron is viewed with e.g. members/moremember.pl?borrowernumber=3 the
attributes that have a class are displayed in a separate table, which is nice.
But in the edit screens they are all in the same table, sorted by Type. Could
it be an idea to sort the table by Class instead, to make the attributes with
the same class appear more close together? 

I'll attach screenshots of what the display looks like.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #11 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:59:18 
UTC ---
Created attachment 7066
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7066
Displaying patron attributes

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #12 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:59:46 
UTC ---
Created attachment 7067
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7067
Editing patron attributes

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7144] Floating collection

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #10 from Magnus Enger mag...@enger.priv.no 2012-01-06 11:03:31 
UTC ---
What's the relationship between these two patches? Should the one from Ian be
applied on top of the one from Chris, or are they independent?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
11:09:04 UTC ---
Hm, not sure here, but will this change break the URL for installations where
no full URL is entered? 
Can we make the update take care about it? (preferred)
Or have a note in the update process that people have to change the preference?
Should staffClientBaseURL be changed to work like that as well?
Sorry for so many questions :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 CC||dpav...@rot13.org

--- Comment #3 from Dobrica Pavlinusic dpav...@rot13.org 2012-01-06 11:15:06 
UTC ---
I'm wondering why it's using Text::Undiacritic instead of Text::Unaccent which
is more popular and already packaged in Debian.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7394] Broken detail page for last link from result page

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed
 AssignedTo|oleon...@myacpl.org |ch...@bigballofwax.co.nz

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
11:34:38 UTC ---
patch pushed, pleast test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #4 from Magnus Enger mag...@enger.priv.no 2012-01-06 11:38:33 UTC 
---
Using a module that is packaged for Debian would be a good idea. If this is
changed, please remember to add the package to these files: 

install_misc/debian.packages
debian/control

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7166] Modify order notes when basket is closed

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 AssignedTo|henridam...@koha-fr.org |jonathan.dru...@biblibre.co
   ||m

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7166] Modify order notes when basket is closed

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com 2012-01-06 
11:40:10 UTC ---
Created attachment 7068
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7068
Proposed patch

When you are on parcel.pl or basket.pl you can now add or edit a note for each
order.

To test:
Create orders with and without note.
Edit/Add the note on basket.pl page.

Close the basket.
Check you can add/edit the order note on parcel.pl page.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7166] Modify order notes when basket is closed

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7166] Modify order notes when basket is closed

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3184] Show creator and budget receiving a document

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3184

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
12:27:53 UTC ---
Patch pushed, please test

QA comment:
checked perlcritic  valid template are still OK:
perlcritic acqui/orderreceive.pl
acqui/orderreceive.pl source OK
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #19 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:00:45 UTC ---
I'm OK to put this patch, but it introduce a new (internal) feature i'd like to
advertise before pushing.

Chris, could you explain the consequences for dates fields ? Does it mean we
don't need to format them in pl anymore but just throw them as they are,
like:
[% order.entrydate | $KohaDates %] ?

(and :
-my $entrydate = C4::Dates-new( $data-{'entrydate'}, 'iso' );
-$data-{'entrydate'} = $entrydate-output(syspref);
-my $datereceived = C4::Dates-new( $data-{'datereceived'}, 'iso' );
-$data-{'datereceived'} = $datereceived-output(syspref);
to remove lines that are now useless ?

I like it. But if we want to adopt this tool (and I think we should), it must
be validated  a bug entry must be open to clean all dates formattings in Koha
!

Chris, please give me details, i'll take care of the bugzilla  mail to
koha-devel

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #7027|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
   Patch Status|Signed Off  |Passed QA

--- Comment #11 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
13:11:16 UTC ---
This patch is mostly indentation changes... only two sections of code changing
are done.  Changes seems sane and secure.  Marking as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5369] se queries with paranthesis fail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5369

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #22 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:11:42 UTC ---
patch pushed, please test

QA comment: checked UNIMARC record.abs, the problem does not exist

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7357] Subscriptions titles are replaced by --- when duplicated

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7357

--- Comment #4 from Owen Leonard oleon...@myacpl.org 2012-01-06 13:17:43 UTC 
---
I've done some experimenting with it and have not been able to come up with a
solution that I think works better. For now I would agree that letting
duplicate titles appear is probably the best option.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
13:21:50 UTC ---
It's a new filter Chris wrote and I think advertising is good but should not
keep these patches from being pushed. We can implement the use of this filter
step by step in the other templates.

And yes, it makes it unnecessary to deal with date formatting in the .pl files
- which is great!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Failed QA

--- Comment #36 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
13:27:28 UTC ---
I've been leery about this development for a few reasons:

1. it seems that, what we initially discussed for this is not what we got, as
far as code.  There was some BibLibre work that was similar, so that was used
instead of implementing the idea from Mumbaï in it's entirety.

2. making changes to the way database updates are handled effects all versions
of Koha.  This process needs to remain stable at all costs.  Thus any change
must be most thoroughly tested

3. there is a rush order on this, which makes me uncomfortable.  Yes, it would
be nice to start the release cycle with a new method, but we're already well
along the development timeframe for 3.8, and I think changing midstream is
going to introduce more complications than it's worth

4. Frankly, I don't feel the need to rush this.  This project offers no
particular benefits to the end user.  It's only really helpful to testers and
developers.  I'm all for making it easier to test patches, but not at the risk
of breaking upgrades for any set of Koha users.  I'd rather see this
implemented in the next release cycle, so we have adequate time to plan and
test.

5. Moving database updates into the atomic update directory is a good thing,
for sure, but assigning them numbers makes them inherently linear, which we're
trying to avoid.

6. I disagree with removing the Version check on every page.  We're in an
asynchronous web environment; the system could be upgraded while folks are
mid-stream in their work (not a recommended practice, but one that we need to
acknowledge as possible).  If a database change significantly affects the
structure of the area in which people are working, the information they are
submitting/querying could become corrupted, or not work at all.  The code and
the database must be kept synchronous, at all times, with no need for manual
action.

Following is my counter-proposal for what a change to updatedatabase should
look like.  Marking as Failed QA for now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6627] [security] insecure file creation

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6627

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:29:51 UTC ---
patch pushed, please test

I've added a followup on InstallAuth.pm to comment another occurrence of this
buggy code

QA comment: i'm not sure we should have commented, I think/feel removing the
lines would be better here. But as it's a real problem, i push.

If you think it would be better to completly remove those lines, let me know !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6627] [security] insecure file creation

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6627

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:35:43 UTC ---
The more I think of it, the more I think we should remove and not just comment.
And we should also remove sub _session_log !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #37 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
13:36:26 UTC ---
Counter proposal:

Just like we initially thought
* patches would be submitted in a specific file, in atomicupdate directory
* a new file (YAML) would be added, that would have 2 columns, one for
the version number, one for the atomicupdate file name
* updatedatabase wouldn't change anymore: we would just add something like :
LoadYAMLFile()
ForEachLine {
if (C4::Context-preference(Version)  FirstColumnYAML) {
exec(secondColumnYAML);
SetVersion (FirstColumnYAML);
}
}
The YAML file would be updated only by the Release Manager, when he
pushes a patch.

But additionally,

* Each atomic update would be named descriptively, not numerically. 
Preferrably referencing the bug number
* The updates would all have the following 4 functions:
  CHECK: determines if the change is needed
  DESCRIBE: display the text for what this change is supposed to do
  DO:  execute the change
  UNDO:  revert the change
* CHECK would always be run first.  If the change is warranted, DESCRIBE would
be run.  After a confirmation from the user, DO is run.
* Similar process could be implemented to downgrade Koha, using UNDO instead of
DO.

This solves linearity, in that any update can DOne in any order.

It also makes reverting patches easier; if a patch you're testing contains a DB
update, you can run the UNDO before switching back to master.  This prevents
cumulative database corruption from testing DB-rev patches

Duplicate Key entries and other problems that could come from running an update
twice are avoided.

Update descriptions can be viewed in advance, so you know what you're going to
get.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6147] Reading RSS feeds via Netvibes

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6147

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:38:29 UTC ---
patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #6 from Nicole C. Engard neng...@gmail.com 2012-01-06 13:47:44 
UTC ---
I've had several libraries ask to have that ability brought back - for paying
and for writing off fines.  I'm not sure about whether they want to be able to
edit that note after the fact, but if it were possible I'm sure no one would
complain.  Most important thing is allowing people to make notes/memos on
payments/writeoffs.

Nicole

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
13:47:44 UTC ---
I am really not sure that sequence for database update never matters. The
nonlinear approach seems dangerous to me.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7144] Floating collection

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

--- Comment #11 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
13:53:35 UTC ---
Magnus,

The two patches are independent, alternate implementations.  Chris's works at a
global level, while mine works at the branch/itemtype level as well.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] New: Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

 Bug #: 7412
   Summary: Pre-filling items in cataloguing
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
AssignedTo: gmcha...@gmail.com
ReportedBy: matthias.meusbur...@biblibre.com
 QAContact: ian.wa...@bywatersolutions.com


Pre-filling of items: remember what was in the previous item filled, to be able
to create multiple items quickly.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #39 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
13:58:24 UTC ---
(In reply to comment #38)
 I am really not sure that sequence for database update never matters. The
 nonlinear approach seems dangerous to me.

My proposal is, in fact, semi non-linear: all DBrevs are numbered, thus they
have an order.
But each number can be applied individually.
It means that, if you apply DBrev 1 and 3, you can also, later, apply BDrev 2

It means that a DBrev that is not ready to be pushed don't block
everything/everybody and you don't have to renumber everything or use temporary
numberings (or the XXX system we use atm)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

--- Comment #1 from Matthias Meusburger matthias.meusbur...@biblibre.com 
2012-01-06 13:59:36 UTC ---
Created attachment 7069
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7069
proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #40 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:00:36 UTC ---
(In reply to comment #37)
 Counter proposal:

Do you plan to submit a patch that implement this behaviour?

If the answer is no i'll answer to each of your points

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

--- Comment #2 from Matthias Meusburger matthias.meusbur...@biblibre.com 
2012-01-06 14:01:26 UTC ---
To test: 
Enable PrefillItem syspref
Create a new item
Create another item.
Expected result: fields are prefilled with previous values. (except for the
following fields: f k u v x z)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #41 from Chris Nighswonger cnighswon...@foundations.edu 
2012-01-06 14:02:54 UTC ---
(In reply to comment #36)

Up front, I think Ian raises some very good points.

 I've been leery about this development for a few reasons:

snip

 Following is my counter-proposal for what a change to updatedatabase should
 look like.  Marking as Failed QA for now.

However, I'm not sure that the correct mechanism here is a Failed QA. In my
opinion QA is pretty objective. ie. does the code do precisely what it claims
to do. None of the points listed indicate that the code submitted does not
behave as advertised. They are all good points, but fall more into the pail of
the is this the best way to do it discussion. Maybe I'm wrong in that
thought. If so, feel free to correct me.

I fear this may set a precedent of QA vetoing features for reasons other than
objective code related problems. Of course, refusing to QA a feature could
result in a pocket veto of sorts as well. But I think that a conscientious RM
should not push any feature to master about which serious concerns have been
raised.

(For the record, this is not intended to be an indication of my opinion on the
modus operendi of a new update system. It is merely a procedural objection.)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6838] Filtering and pagination in subscriptions table

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

--- Comment #10 from Nicole C. Engard neng...@gmail.com 2012-01-06 14:03:33 
UTC ---
Applies fine, but after it's applied I get :


Software error:

Template process failed: file error - datatables-strings.inc: not found at
/home/nengard/kohaclone/C4/Templates.pm line 125.

For help, please send mail to the webmaster (webmaster@debian), giving this
error message and the time and date of the error.



on the serials_home

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5872] Enhancements to circulation (see comment 23 for details)

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5872

Francois Charbonnier francois.charbonn...@biblibre.com changed:

   What|Removed |Added

 CC||francois.charbonnier@biblib
   ||re.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #42 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
14:04:30 UTC ---
Paul,


I don't have a patch implementing my proposal yet, no, and it's unlikely I'll
get one written any time this month or next.  But that doesn't stop others from
taking the core idea, expounding on it, and implementing.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5872] Enhancements to circulation (see comment 23 for details)

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5872

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

 CC||adrien.sau...@biblibre.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

--- Comment #21 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:07:56 UTC ---
(In reply to comment #20)
 It's a new filter Chris wrote and I think advertising is good but should not
 keep these patches from being pushed. We can implement the use of this filter
 step by step in the other templates.

of course, and that's why i'm just asking for more info from chris.
Once i've them, i'll push, that won't be delayed a lot, don't worry

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #43 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
14:08:47 UTC ---
Chris N,

QA is not strictly assessing the validity of the code and it's conformity to
our established coding guidelines.  It also takes into consideration larger
implications of the code being submitted, the possibilities of regressions and
the risks of introducing new bugs.  Perhaps I'm overstating the scope as others
understand it, but this is my understanding.

That said, having another status to mark this other than Failed QA would be
good, because the code itself isn't technically invalid.  Perhaps Planning or
In Discussion... ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7337] Debarred Until display in the opac tells patrons they are debarred until the year 9999

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Patch Status|Passed QA   |Patch Pushed

--- Comment #8 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:09:14 UTC ---
patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7338] link to serial detail wrong

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #14 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:16:30 UTC ---
patch pushed please test:

QA comment:
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7341] Clicking cancel on system preferences search results causes error

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7341

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|rel_3_8 |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:17:59 UTC ---
patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #44 from Chris Nighswonger cnighswon...@foundations.edu 
2012-01-06 14:19:29 UTC ---
(In reply to comment #43)
 Chris N,
 
 QA is not strictly assessing the validity of the code and it's conformity to
 our established coding guidelines.  It also takes into consideration larger
 implications of the code being submitted, the possibilities of regressions and
 the risks of introducing new bugs.  Perhaps I'm overstating the scope as 
 others
 understand it, but this is my understanding.

I don't think that this is an overstatement of QA responsibilities. I just
think that QA rejection should include concrete, demonstration issues. ie. What
are the exact regressions/bugs along with examples of exactly how those will
manifest. If the code is demonstrably buggy or regression-causing, it should
fail QA. It should not fail QA on issues which are anticipated/suspected, but
no confirmed IMHO.

 
 That said, having another status to mark this other than Failed QA would be
 good, because the code itself isn't technically invalid.  Perhaps Planning 
 or
 In Discussion... ?

Such a choice would be nice. In Discussion would be an unambiguous tag.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7264] Display information about library on OPAC detail

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7264

David Schuster dschu...@gmail.com changed:

   What|Removed |Added

 CC||dschu...@gmail.com

--- Comment #6 from David Schuster dschu...@gmail.com 2012-01-06 14:30:49 UTC 
---
Please make this optional as schools generally the address of the school isn't
important to our users they are just trying to locate a book at their school or
can talk with the librarian about getting it.

my .0001 cent opinion.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7016] CanBookBeReserved uses GetItemsInfo unnecessarily

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7016

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

 CC||pelletiermax...@gmail.com
   Severity|normal  |major

--- Comment #7 from Maxime Pelletier pelletiermax...@gmail.com 2012-01-06 
14:32:45 UTC ---
This patch broke the function. CanItemBeReserved needs an itemnumber and it
seems that it now gets an array of hash (for exemple you would get itemnumber
with $item-{$biblionumber}-[0]). I would suggest either reverting this patch
or using/adding subs that just return an array of itemnumber correctly.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
 CC||neng...@gmail.com
   Patch Status|--- |Needs Signoff
 AssignedTo|gmcha...@gmail.com  |matthias.meusburger@biblibr
   ||e.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Patch Status|Needs Signoff   |Does not apply

--- Comment #3 from Nicole C. Engard neng...@gmail.com 2012-01-06 14:34:47 
UTC ---
This does to appear to apply to master.


nengard@debian:~/kohaclone$ git bz apply 7412
Bug 7412 - Pre-filling items in cataloguing

proposed patch
Apply? [yn] y

Applying: Bug 7412: Pre-filling items in cataloguing
/home/nengard/kohaclone/.git/rebase-apply/patch:85: trailing whitespace.
# force the use of add and duplicate feature, so the form will be filled
with 
/home/nengard/kohaclone/.git/rebase-apply/patch:176: trailing whitespace.
$itemrecord = $cookieitemrecord if ($prefillitem and not $justaddeditem and $op
ne edititem); 
error: patch failed: kohaversion.pl:16
error: kohaversion.pl: patch does not apply
Patch failed at 0001 Bug 7412: Pre-filling items in cataloguing
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/proposed-patch-NyUHpB.patch
nengard@debian:~/kohaclone$

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #45 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:38:55 UTC ---
(In reply to comment #41)
 However, I'm not sure that the correct mechanism here is a Failed QA. In 
 my
 opinion QA is pretty objective. ie. does the code do precisely what it claims
 to do. None of the points listed indicate that the code submitted does not
 behave as advertised. They are all good points, but fall more into the pail of
 the is this the best way to do it discussion. Maybe I'm wrong in that
 thought. If so, feel free to correct me.

Thanks chris_n !
That was my 1st reaction, but I didn't wanted to write it immediatly to avoid
being suspected to refuse the discussion.
I agree that QA should be objective.
OTOH, Ian  me had a long discussion about this improvement at KohaCon, and I
consider his thoughts more a follow-up of this discussion than a QA.

Agreed we should have a discussion status !

Now answering Ian points:
(In reply to comment #36)
 1. it seems that, what we initially discussed for this is not what we got, as
 far as code.  There was some BibLibre work that was similar, so that was used
 instead of implementing the idea from Mumbaï in it's entirety.
You're right here. That does not mean it's not a good piece of code.

 2. making changes to the way database updates are handled effects all versions
 of Koha.  This process needs to remain stable at all costs.  Thus any change
 must be most thoroughly tested
you're right, and we (jonathan  me) have spent a *lot* of time testing this
one.
I also must point that this patch is not exclusive of the actual DBrev system :
both are still working. It means that patches already submitted with
updatedatabase can still be tested/pushed

 3. there is a rush order on this, which makes me uncomfortable.  Yes, it would
 be nice to start the release cycle with a new method, but we're already well
 along the development timeframe for 3.8, and I think changing midstream is
 going to introduce more complications than it's worth

The rush level has been lowered by the clarification made on DBrevs, and the
mails i've sent today (as well as the update of master i also made today)

But:
* the 3.6 updatedatabase has a limit for testing patches as well as a risk for
backporting DBrevs to 3.4, addressed by this patch
* this bug is an absolute necessity for the sandbox system i'm working on.
Without it, it won't work (because updatedatabase have a XXX, so no patch with
a DBrev will apply)

 4. Frankly, I don't feel the need to rush this.  This project offers no
 particular benefits to the end user.  It's only really helpful to testers and
 developers.  I'm all for making it easier to test patches, but not at the risk
 of breaking upgrades for any set of Koha users.  I'd rather see this
 implemented in the next release cycle, so we have adequate time to plan and
 test.

Does it mean your only fear is that it could break something ? and you haven't
tested or found anything broken ?
Yes, it's a core change, but we should not fear doing core change just because
it's in the core !

 5. Moving database updates into the atomic update directory is a good thing,
 for sure, but assigning them numbers makes them inherently linear, which we're
 trying to avoid.
yes and no : the numbering ensure we have an order, but it's not linear because
we can have holes in the numbering.

 6. I disagree with removing the Version check on every page.  We're in an
 asynchronous web environment; the system could be upgraded while folks are
 mid-stream in their work (not a recommended practice, but one that we need to
 acknowledge as possible).  If a database change significantly affects the
 structure of the area in which people are working, the information they are
 submitting/querying could become corrupted, or not work at all.  The code and
 the database must be kept synchronous, at all times, with no need for manual
 action.
we disagree here : upgrading a software is not something you do without knowing
you're doing it. There is a procedure, and the check has been reintroduced on
every mainpage, It's enough !
Note that, if you continue to argue it must be done, then i've a counter
proposal:
at the end of each upgrade, run truncate session, thus the user will be
disconnected, and, on connection, he will be sent to database update !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7144] Floating collection

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

--- Comment #12 from Magnus Enger mag...@enger.priv.no 2012-01-06 14:43:12 
UTC ---
Sorry for being slow... Are they mutually exclusive (competing solutions for
the same problem) or could they co-exist?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch Status|Does not apply  |Needs Signoff

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
14:49:44 UTC ---
Hi Nicole, I was looking at this too - applies to latest master cleanly for me
using git bz.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7193] can't remove end date from subscriptions

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7193

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_6
   Patch Status|Passed QA   |Patch Pushed
 AssignedTo|colin.campbell@ptfs-europe. |dun...@catalyst.net.nz
   |com |

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:51:25 UTC ---
patch pushed, please test

QA comment:
the patch also remove a few inline styling which should not be here
(style=border-width: 0px;)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7194] OPAC detail and recent comments pages require corrections for XHTML validity

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:53:00 UTC ---
patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7016] CanBookBeReserved uses GetItemsInfo unnecessarily

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7016

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

   Priority|PATCH-Sent  |P1 - high

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7220] Add IDs to check-in message dialogs to facilitate CSS customization

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7220

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #12 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:54:18 UTC ---
patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

--- Comment #5 from Nicole C. Engard neng...@gmail.com 2012-01-06 14:58:31 
UTC ---
I just did a fetch on master and tried again and still it's not applying - are
you on the latest master as of this minute?


nengard@debian:~/kohaclone$ git bz apply 7412
Bug 7412 - Pre-filling items in cataloguing

proposed patch
Apply? [yn] y

Applying: Bug 7412: Pre-filling items in cataloguing
/home/nengard/kohaclone/.git/rebase-apply/patch:85: trailing whitespace.
# force the use of add and duplicate feature, so the form will be filled
with 
/home/nengard/kohaclone/.git/rebase-apply/patch:176: trailing whitespace.
$itemrecord = $cookieitemrecord if ($prefillitem and not $justaddeditem and $op
ne edititem); 
error: patch failed: kohaversion.pl:16
error: kohaversion.pl: patch does not apply
Patch failed at 0001 Bug 7412: Pre-filling items in cataloguing
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/proposed-patch-jUts5f.patch
nengard@debian:~/kohaclone$

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3651] Require patron login to send shelves and baskets

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3651

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Signed Off  |Patch Pushed

--- Comment #5 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
14:58:53 UTC ---
patch pushed again, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #12 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 
15:04:38 UTC ---
Patch pushed, please test

Gaetan, just a small comment: when you signoff a patch, be carefull : the 1st
line is the header of the patch comment and is what appear on all lists.

you've added
works beautifully !, which is not a good description ;-)

i've modified the comment to put your happyness after your signature !
Also note that your enthousiasm is nice, but it's not really usefull in the
patch itself. Remember it's in the patch forever (really)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com 2012-01-06 
15:07:32 UTC ---
Created attachment 7070
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7070
7154: Followup: Adds tables on modify + class filled wih AV

Hi Magnus, 

Thank you for returns.

This patch contains modifications you requested.

- FIX display/hide attr on memberentry.pl when category changes
- Attr classes filled with AV 'PA_CLASS' category (you have to create AV
  with a new category 'PA_CLASS' to fill class list)
- Use tables (classes separation) on member modification and attr management
  (admin). Theses array are sorted by name.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7016] CanBookBeReserved uses GetItemsInfo unnecessarily

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7016

--- Comment #8 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 
15:10:20 UTC ---
Created attachment 7071
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7071
Proposed Followup

Adds a new subroutine to just get an array of itemnumbers for any given
biblionumber, and replaces the use of get_itemnumbers_of in CanBookBeReserved.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:14:34 UTC ---
Ok, I am confused here - perhaps someone can clarify: why is this failed qa and
what is the relation to 5878 (that I spent a lot of time testing on)?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:21:45 UTC ---
I have a question about this :)

Why was patron category type (adult, staff, etc.) chosen instead of patron
category? I think it would allow for a lot more flexibility. 

For example we use only 'adult' and 'staff' for academic libraries at the
moment.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

Jane Wagner jwag...@ptfs.com changed:

   What|Removed |Added

 CC||jwag...@ptfs.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5896] Approved comments don't go into pending approval list after edit

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5896

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:31:53 UTC ---
With the recent work done in this part of Koha - it works nicely on master now!
Perhaps another test on 3.6.x would be good before closing this.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5896] Approved comments don't go into pending approval list after edit

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5896

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|master  |rel_3_6

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5959] Add search link for analytics to serial records

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:35:45 UTC ---
This works on master. The links can be removed from display using CSS:
.analytics {display: none;}

Linda - you are right, indicators are not taken into account here. Could you
open a separate bug with some more information perhaps? I can try to look into
it.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:44:59 UTC ---
I think one of the problems here is, that we can not assume people have been
using x for internal notes. 

So perhaps one solution would be:

- Change the mappig only for new installs, don't make any updates to existing
installs and their frameworks

- Provide a script or some SQL and a short documentation how to move over
existing internal notes into the new field from the xml field.

Could this work?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2349] Allow CSS customization of circulation receipts

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2349

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:51:07 UTC ---
I think this can be seen as duplicate of bug 7001:
- html will make it possible to customize to your heart's content
- slips are moved in with notices
- different slips for each branch

*** This bug has been marked as a duplicate of bug 7001 ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:51:08 UTC ---
*** Bug 2349 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 AssignedTo|claire.hernandez@biblibre.c |julian.maur...@biblibre.com
   |om  |

--- Comment #4 from Julian Maurice julian.maur...@biblibre.com 2012-01-06 
15:55:50 UTC ---
Created attachment 7072
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7072
Update database patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5411] Existing renewal rules are not translated into new rule structure on upgrade

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5411

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:56:27 UTC ---
As this is related to 3.0.x - should it be WONTFIX?
Has it been resolved on another bug?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

--- Comment #5 from Julian Maurice julian.maur...@biblibre.com 2012-01-06 
16:03:09 UTC ---
Created attachment 7073
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7073
Invoices management improvement patch

This patch add two pages for managing invoices:
  acqui/invoices.pl
  acqui/invoice.pl

Now, only the invoiceid is passed between acquisitions pages (parcel.pl,
orderreceive.pl finishreceive.pl) instead of invoicenumber, datereceived,
freight, etc.
It is more consistent like this, but I'm not sure I've tested all use cases,
and it may break some behaviours.

Please send me feedback so I can fix things (if things need to be fixed)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >