[Koha-bugs] [Bug 7420] Add max fines to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 Paul Poulain changed: What|Removed |Added Depends on||8486 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] New: Critical error in Koha::Calendar::days_between ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8486
Assignee: colin.campb...@ptfs-europe.com
Blocks: 7420, 8251
Summary: Critical error in Koha::Calendar::days_between ?
Severity: blocker
Classification: Unclassified
OS: All
Reporter: paul.poul...@biblibre.com
Hardware: All
Status: ASSIGNED
Version: master
Component: Architecture, internals, and plumbing
Product: Koha
My setup has syspref finesCalendar set "Use Calendar to skip all days the
library is closed".
I made the small following script:
#!/usr/bin/perl
use Koha::Calendar;
use Koha::DateUtils;
use 5.010;
my $calendar = Koha::Calendar->new( branchcode => 'MAURES' );
say "Test 1=".$calendar->days_between(dt_from_string("2012-01-10") ,
dt_from_string("2012-05-05") )->in_units('days');
say "Test 2=".$calendar->days_between(dt_from_string("2012-05-05") ,
dt_from_string("2012-01-01") )->in_units('days');
The result I get is:
./test_calendar.pl
DURATION : $VAR1 = bless( {
'seconds' => 0,
'minutes' => 0,
'end_of_month' => 'wrap',
'nanoseconds' => 0,
'days' => 26,
'months' => 3
}, 'DateTime::Duration' );
Test 1=26
DURATION : $VAR1 = bless( {
'seconds' => 0,
'minutes' => 0,
'end_of_month' => 'preserve',
'nanoseconds' => 0,
'days' => -4,
'months' => -4
}, 'DateTime::Duration' );
Test 2=-4
(the DURATION line comes from a warn I put in days_between
Whatever the month, I always get the same result.
Digging into documentation, I found this:
$ perldoc DateTime::Duration
· in_units( ... )
Returns the length of the duration in the units (any of those that
can be passed to new) given as
arguments. All lengths are integral, but may be negative. Smaller
units are computed from what remains
after taking away the larger units given, so for example:
my $dur = DateTime::Duration->new( years => 1, months => 15 );
$dur->in_units( 'years' );# 2
$dur->in_units( 'months' ); # 27
$dur->in_units( 'years', 'months' ); # (2, 3)
$dur->in_units( 'weeks', 'days' );# (0, 0) !
The last example demonstrates that there will not be any conversion
between units which don't have a
fixed conversion rate. The only conversions possible are:
· years <=> months
· weeks <=> days
· hours <=> minutes
· seconds <=> nanoseconds
For the explanation of why this is the case, please see the How
Datetime Math Works section of the
DateTime.pm documentation
CONCLUSION = the days_between() sub is doing a completely wrong calculation. I
think we should to a date1-date2 to get a number of days, then remove all
closed days.
2012-07-01 to 2012-07-15 is 14 (days)
2012-07-06 closed => 13 (days)
2012-07-07 closed => 12 (days)
This problem is probably the real cause of bug 8251 and the trouble I get to
test bug 7420
Colin, I've assigned this bug to you because you're Koha::Calendar initial
author. Anyone is welcomed to confirm and provide a fix.
What is really missing is a test plan. With a strong one, we would have
detected the problem before
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Paul Poulain changed: What|Removed |Added Depends on||8486 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5...@gmx.de> changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5...@gmx.de> changed: What|Removed |Added Attachment #11058|0 |1 is obsolete|| --- Comment #12 from Mirko Tietgen <5...@gmx.de> --- Created attachment 11059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11059&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 and element. Additionally it gives basic support for the element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5...@gmx.de> changed: What|Removed |Added Attachment #11057|0 |1 is obsolete|| --- Comment #11 from Mirko Tietgen <5...@gmx.de> --- Created attachment 11058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11058&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 and element. Additionally it gives basic support for the element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5...@gmx.de> changed: What|Removed |Added Attachment #10776|0 |1 is obsolete|| --- Comment #10 from Mirko Tietgen <5...@gmx.de> --- Created attachment 11057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11057&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 and element. Additionally it gives basic support for the element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5...@gmx.de> changed: What|Removed |Added Summary|Show HTML5 video/ audio in |Show HTML5 video/ audio for |OPAC for media files in 856 |media files in OPAC and ||staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #9 from Mirko Tietgen <5...@gmx.de> --- Created attachment 11056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11056&action=edit Remove previous version of sysprefs for this enhancement If you tested a patch for this bug before, you can use this file to delete the previous version of the sysprefs for this bug. They have changed in the new version - sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236
--- Comment #2 from Owen Leonard ---
Under what circumstances does this bug appear? I assume the "if an item is
overdue" is contingent on the OverduesBlockCirc preference? I'm already blocked
from renewing an item on circulation.pl by scanning the barcode.
With our without the patch I am not prevented from renewing an overdue item via
the table of checkouts on the page ("Renew or Return checked items").
Please provide more information and a clear test plan.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Owen Leonard --- This needs to be rebased. Also looks like there's a conflict marker somewhere? +<<< HEAD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7901] Add batch delete borrowers script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 Owen Leonard changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7901] Add batch delete borrowers script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Looks like the script deletes holds which were on a deleted patron's account but doesn't move them to old_reserves? I assume it should, since deleting a hold via reserve/request.pl does so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7901] Add batch delete borrowers script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 --- Comment #3 from Owen Leonard --- I tried loading a file which included one patron with checkouts, one without. The patron with no checkouts was deleted without error, the one with checkouts prompted this: Working on cardnumber 0093698 DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at /home/oleonard/kohaclone/C4/Members.pm line 1708, line 2. Deleting borrower John Smith ( 0093698 ) ... deleted. Sounds like the script tries its best to delete and it's the error that prevents it? I would think that unless there is an explicit plan for how to handle checkouts the script should skip these accounts and report it. After that I tried loading the same file again (including the patron record which had already been deleted) and got this error: Working on cardnumber 0049138 Use of uninitialized value in concatenation (.) or string at batch_delete_borrowers.pl line 80, line 1. Use of uninitialized value in concatenation (.) or string at batch_delete_borrowers.pl line 80, line 1. Use of uninitialized value in concatenation (.) or string at batch_delete_borrowers.pl line 80, line 1. Deleting borrower ( ) ... deleted. It would be nice to handle that situation gracefully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- Why are there two different ways of handling restrictions? I see references to "Debarred" and "PrevDebarred." Are these for different cases? Under what circumstances is the "Debarred" message displayed? If they cannot be consolidated the new message should use the same format as the other one, naming and linking to the patron record. The message should also differentiate between a basic restriction (no specific date) and restricted until. In the former case the staff client should not say "restricted until 12/31/." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Owen Leonard changed: What|Removed |Added Attachment #10585|Bug 8231: reminder when |[SIGNED-OFF] Bug 8231: description|checking in for a |reminder when checking in |restricted patron |for a restricted patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8360] Author facet not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 --- Comment #4 from Jared Camins-Esakov --- I would agree that this should probably be ,phr. Is there a reason you chose ,wrdl, Adrien? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 --- Comment #19 from Owen Leonard --- Frédéric could you vote with your signoff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- The description of this database update is "Add system preference IntranetSlipPrinterJS." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8485] New: Make koha_perl_deps.pl batch friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Priority: P5 - low Change sponsored?: --- Bug ID: 8485 Assignee: gmcha...@gmail.com Summary: Make koha_perl_deps.pl batch friendly Severity: enhancement Classification: Unclassified OS: All Reporter: tomasco...@gmail.com Hardware: All Status: NEW Version: master Component: Installation and upgrade (command-line installer) Product: Koha I propose adding a switch to the koha_perl_deps.pl script so it is more batch friendly. I propose -B (for batch) and make it output just the library name, preserving the other switches semantics. It could be useful to do things like: for k in $(for i in $(./koha_perl_deps.pl -m -B | perl -pi -e 's/::/-/g' | tr '[A-Z]' '[a-z]') do echo lib$i-perl done) do apt-cache search $k done (fix it) to maintain a list of debian packages needed, and stuff like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8414] Intranet header toplinks display white rather than blue in < IE8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8414 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Owen Leonard --- I don't have an installation of IE7 handy but this patch is clearly correct and does nothing to change the status quo in any modern browser. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8414] Intranet header toplinks display white rather than blue in < IE8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8414 Owen Leonard changed: What|Removed |Added Attachment #10777|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 11055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11055&action=edit [SIGNED-OFF] Bug 8414 - Intranet header toplinks display white rather than blue in < IE8 Removes IE7 hash hack which caused head toplinks to display white rather than dark blue against light blue background Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Owen Leonard changed: What|Removed |Added Attachment #11005|0 |1 is obsolete|| --- Comment #17 from Owen Leonard --- Created attachment 11054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11054&action=edit [SIGNED-OFF] Bug 7189 - preference to control if returning lost items gives refund Right now when you return an item that was lost the patron's card is credited with the lost fee, but not all libraries refund lost fees and sometimes the fee is refunded after the patron has paid for it, causing all kinds of financial issues. Adds the syspref RefundLostItemFeeOnReturn to control whether returning a lost item refunds the fee charged for losing that item. Enabled by default to maintain Koha's current functionality. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Ian Walls changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||koha.sek...@gmail.com --- Comment #18 from Ian Walls --- Patch 1: correct 'to' value of truncate function is 'day', not 'days', but the patch no longer applies. Patch 2: looks to be removing 'singleholiday' and 'exceptionholiday' references in favour of 'specialholiday'. Also, patch does not apply anymore. Patch 3: swaps around hash from 'month' => 'day' to 'day' => 'month', which seems backwards as far as granularity goes. I remember us switching this for a reason... was that reason half-baked? Or did we just not switch it in enough places? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #29 from Paul Poulain --- (In reply to comment #27) > This patch should not be pushed because it causes false calculation of late > delay when patron is more than one month late. mmm... could you look at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420#c29 I think there are interesting informations here. I spent 3 hours trying to understand what was happening :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7420] Add max fines to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 --- Comment #29 from Paul Poulain --- QA comment I tried to test this bug, with syspref finesCalendar set "Use Calendar to skip all days the library is closed", and for a late document I get a negative number for days_between, resulting in no fine being set. I think we should give more details on how days_between works. What we should say is: * if the 1st date is BEFORE the 2nd date, return a negative number * if the 1nd date is AFTER the 1st date, return a positive number (to be // with ->compare that says: Compare two DateTime objects. The semantics are compatible with Perl's "sort()" function; it returns -1 if $dt1 < $dt2, 0 if $dt1 == $dt2, 1 if $dt1 > $dt2. ATM, in fines calculation, days_between is called with $datedue, $today. if $date_due < $today, it returns a negative number, which is wrong. The CalcFine sub should be called with $today,$datedue Could you please check I'm right. For now, for me, I can't test this patch properly. Note that the problem is not related to this patch This is probably related to bug 8521, I tested with and without the patch provided by Koha Team Lyon 3, same result. I tried with $today,$duedate, it seems to have fixed the problem (with Koha Team Lyon 3 patch applied) I won't push this patch before having feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall changed: What|Removed |Added Summary|Add ability to choose of|Add ability to choose if |lost items are removed from |lost items are removed from |a borrowers record. |a borrowers record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose of lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 --- Comment #1 from Kyle M Hall --- Created attachment 11053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11053&action=edit Bug 8484 - Add ability to choose of lost items are removed from a borrowers record. Adds the system preference ReturnLostItems to control whether setting an item as lost will remove the item from the borrower's record. Note, this system preference does not affect misc/cronjobs/longoverdue.pl which has its own command line switch to choose this behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] New: Add ability to choose of lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Priority: P5 - low Change sponsored?: --- Bug ID: 8484 CC: m.de.r...@rijksmuseum.nl Assignee: gmcha...@gmail.com Summary: Add ability to choose of lost items are removed from a borrowers record. Severity: enhancement Classification: Unclassified OS: All Reporter: k...@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Currently, if an item is marked as lost, but still checked out to a borrower, that item is automatically returned. Some libraries would prefer that items marked as lost remain checked out to the borrower. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #37 from M. de Rooy --- (In reply to comment #35) > Created attachment 11048 [details] > Adjusted patch for perl deps > > Jonathan: Could you please add a signoff too? Probably, usage=> Core could be amended to Unit tests.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8117] Divide budget periods into two tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8117] Divide budget periods into two tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Owen Leonard changed: What|Removed |Added Attachment #11047|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 11052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11052&action=edit [SIGNED-OFF] Bug 8117: Divide budget periods into two tabs Budget periods are now divided into two tabs : active and inactive budget periods. The original author of this patch is Julian Maurice Signed-off-by: Katrin Fischer Signed-off-by: Michael Davis Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5409] Call number is not show on Opac search result page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Owen Leonard --- These patches correct the problem for the "normal" view in the OPAC. It does not affect the XSLT display. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall changed: What|Removed |Added Attachment #8806|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 11051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11051&action=edit Bug 7887 - Add Option To Include Items That Will Be Available When Calculating Holds Ratios This commit adds the ability to include items that are on order in the aquisitions module, and items whose notforloan attribute is less than 1 ( i.e. will be available in the future ) when calculating holds ratios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5409] Call number is not show on Opac search result page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard changed: What|Removed |Added Attachment #10288|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 11050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11050&action=edit [SIGNED-OFF] Bug 5409 [2] Call number is not show on Opac search result page. [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #36 from M. de Rooy --- Still wondering about this error: [Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25. [Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25. This is separate from the last patch and comes up in current master already. Any idea? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5409] Call number is not show on Opac search result page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard changed: What|Removed |Added Attachment #2754|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 11049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11049&action=edit [SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What|Removed |Added Attachment #10956|0 |1 is obsolete|| --- Comment #35 from M. de Rooy --- Created attachment 11048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11048&action=edit Adjusted patch for perl deps Jonathan: Could you please add a signoff too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #17 from Owen Leonard --- (In reply to comment #16) > 2 first patches are obsoletes ? > And just the last one needs QA ? Correct. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard changed: What|Removed |Added Attachment #9992|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard changed: What|Removed |Added Attachment #9991|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8117] Divide budget periods into two tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8117] Divide budget periods into two tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Jonathan Druart changed: What|Removed |Added Attachment #10178|0 |1 is obsolete|| Attachment #10179|0 |1 is obsolete|| Attachment #10180|0 |1 is obsolete|| Attachment #10235|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 11047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11047&action=edit Bug 8117: Divide budget periods into two tabs Squashed and rebased path A quick last signoff is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Robin Sheat changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #16 from Jonathan Druart --- 2 first patches are obsoletes ? And just the last one needs QA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] New: Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Priority: P5 - low Change sponsored?: --- Bug ID: 8483 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Borrower reading history should include deleted items Severity: enhancement Classification: Unclassified OS: All Reporter: ro...@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #3 from Matthias Meusburger --- This new patch removes the reindenting changes, making the patch easier to read and to understand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Matthias Meusburger changed: What|Removed |Added Attachment #10453|0 |1 is obsolete|| --- Comment #2 from Matthias Meusburger --- Created attachment 11046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11046&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard --- Sounds like this requires a follow-up? Please change the status if I'm incorrect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8117] Divide budget periods into two tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply Version|unspecified |master --- Comment #13 from Owen Leonard --- Applying the patches fails for me at this step: Applying: Bug 8117: Followup: Use the KohaDates plugin in aqbudgetperiods.tt fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8117: Followup: Use the KohaDates plugin in aqbudgetperiods.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #34 from M. de Rooy --- (In reply to comment #33) > This patch displays a warning with the following command: > perl koha_perl_deps.pl -i > > koha_perl_deps.pl: Use of uninitialized value in formline at > koha_perl_deps.pl line 65, line 522. > > I think it is caused by the missing 'min_ver' information. > However, I don't understand what is the value '2' for required. Can you shed > some light on this please ? Good catch. I saw somewhere else that min_ver was not added too, will correct that now also. I tested about page, but should have run this script too. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #13 from M. de Rooy --- (In reply to comment #12) > It would be great to have the same behaviour for the Intranet > systempreference. > > + Maybe a followup is required to update the description of syspref (support > for http AND https) ? Thanks for signing off on this one. We could start a new report for the Intranet side. Will later send a followup for textual change; I hesitated with adjusting the text because there are much more cases in the pref descriptions where http or https could or should be written. But I already wanted Koha to work with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6809] Add branch filter in holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6809 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA Version|unspecified |master --- Comment #3 from Owen Leonard --- This patch seems to work well after correcting conflicts in the HTML. However, I think it's necessary to revise it to include an "all libraries" option since without it the librarian can't reproduce the current behavior of the script. We don't want to take away functionality that someone might be using. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #7 from Marc Véron --- Always got Traceback error during git bz attach -e (due to slow internet connection). Anyway, patch behaves as expected, signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #98 from M. de Rooy --- (In reply to comment #97) > (note about the updated patch = it's easier to have follow-up in a case like > this one, it makes much more clear what has been changed ! The RM or QAer > can squash all patches when things are OK, just before pushing) I completely agree on that, but as described it was not my intention nor hope.. Will soon come back to the other points -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Marc Véron changed: What|Removed |Added Attachment #10864|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #6 from Marc Véron --- Created attachment 11045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11045&action=edit [SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item! There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7715] Add biblio.subtitle and appropriate mappings to MARC frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7715 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #6 from Owen Leonard --- What about using the "Keywords to MARC mapping" setting to determine what information is pulled into the new quasi-subtitle field? I guess that would present problems if you wanted to modify the mapping. You'd have to run some kind of rebuild script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This doesn't have a system preference to turn it on and off. Is that an omission which should be addressed in a revision, or is that a feature which was dropped? What was mean by "house the content of the card?" There are some issues I see with this: 1. There are violations of the capitalization rule described in Bug 2780. 2. The printable card view has a label "Membership No" but the term we standardize on is "Card number." 3. The printed card show the patron image whether or not the patronimages system preference is enabled. 4. The printable card view page has invalid XHTML. 5. The patch adds a CSS file, screen.css. This CSS could probably be embedded in the body of the page since it is "single-purpose." Another idea would be to put the CSS into its own system preference so that libraries could customize it. In any case, "screen.css" is not a descriptive enough name. If the CSS isn't moved into the template the file name should at least be changed. 6. The "Print card" option is added to the toolbar used on some patron-related pages but not to the toolbar used on others. These should be consistent (Sorry, Bug 6261 is still open). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #15 from Owen Leonard --- Created attachment 11044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11044&action=edit [SIGNED-OFF] Bug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page http://bugs.koha-community.org/show_bug.cgi?id=7153 Signed-off-by: Owen Leonard Updatedatabase conflicts fixed, twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 --- Comment #9 from Marc Véron --- Agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8482] labels creator fixes for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8482 Dobrica Pavlinusic changed: What|Removed |Added Attachment #11039|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6448] EAN-13 barcode support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #20 from Dobrica Pavlinusic --- I addressed QA issues in first two patches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6448] EAN-13 barcode support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What|Removed |Added Attachment #10129|0 |1 is obsolete|| --- Comment #19 from Dobrica Pavlinusic --- Created attachment 11043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11043&action=edit Bug 6448 [2/3] Barcodes::EAN13 autoBarcode Implement auto-incrementing EAN-13 barcodes To make this work, C4::Barcodes::next was modified to call process_tail with new incremented value so that process_tail can generate correct checksum. Since process_tail is currenlty not used by any barcodes, this change is safe. C4::Barcodes is used by addbiblio.pl when adding multiple records, while value_builder is used in all other cases. Test scenario: 1. prove t/Barcodes_EAN13.t 2. KOHA_CONF=/etc/koha/sites/fer/koha-conf.xml prove t/db_dependent/Barcodes.t this will check C4::Barcode implementataion 3. in systempreference change autoBarcode to incremental EAN-13 barcode 4. edit two items of any biblio assigning barcodes and verify that numbers are increasing. Have in mind that last digit is check digit, and it doesn't increment, but is calculated from barcode itself. Example with checksum in brackets: 00086275[2], 00086276[9], 00086277[6] 5. Add Item and verify that it gets assigned next barcode 6. Add & Duplicate item and verify barcode increase 7. Add Multiple Copies and verify that barcode increase for each copy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6448] EAN-13 barcode support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What|Removed |Added Attachment #10128|0 |1 is obsolete|| Attachment #11041|0 |1 is obsolete|| --- Comment #18 from Dobrica Pavlinusic --- Created attachment 11042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11042&action=edit Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter This filter which check validity of EAN-13 barcode and padd it with zeros up to full 13 digit number. This will also expand 12 digit UPC-A barcodes to EAN-13 automatically which is useful for older barcode readers which tend to ignore first zero in EAN-13 if they have just UPC-A support. It should be noted that EAN-13 or UPC-A product codes printed on books are not good choice for barcodes in Koha since each item has to have unique barcode. Test scenario: 1. prove t/Circulation_barcodedecode.t this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding 2. in systempreferences search for itemBarcodeInputFilter and select EAN-13 3. edit one item and assign it valid EAN-13 barcode, eg. 000695152, check it out 4. test checkin with just 695152 to test leading zero expansion Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6448] EAN-13 barcode support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #17 from Dobrica Pavlinusic --- Created attachment 11041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11041&action=edit Bug 6448 [3/3] EAN-13 barcode labels Current implementation doesn't scale barcodes because low-price CCD barcode readers are very sensitive about size Test scenario: 1. in Tools > Labels create or edit Layout and select EAN13 as barcode type 2. export one of existing batches using EAN13 layout and verify that generated pdf file contains barcodes 3. print pdf file and test it with barcode reader Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #97 from Paul Poulain --- (In reply to comment #96) > I discovered that in a perl file I needed to define routines for these > queries and comments, and I did not think that it was easier. With just a > use Context, a db handle and the "old style" sql statements things seemed > easier.. The idea behind this feature is not to ease developers, but future administration of the database. Suppose you've handled 3.05.00.017 upgrade. It does a different SQL request depending on your MARC flavour. With this patch, you will know, *6 months later*, which SQL requests you *had* executed. Whatever your parameters are *today* The .pl can do complex things to build queries, but what we're doing is execute SQL, exactly like when you have .sql file. I agree it's a little bit more for developers (but only a little bit more), but can be really helpfull for dbadmin, so it's worth the price. About other points: * Ascending order for table on admin/updatedatabase => it was not a mistake. When you'll upgrade in production, you'll be happy to see what's new & need to be applied first. With the patch as it was, one would see that he has to apply 3 patches. * Important typo $koha39=~ should be assignment. Updated version number in install and Auth due to removing older sql files. => agreed it was a mistake * Typo _get_queries: removed the call after all; it is easier to leave SQL in perl files outside the update tables. Added some checks for emptiness. => see below, I think it's should be kept * Corrected execution of perl dbrevs (filepath). => I don't understand (note about the updated patch = it's easier to have follow-up in a case like this one, it makes much more clear what has been changed ! The RM or QAer can squash all patches when things are OK, just before pushing) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8442] Error when printing labels under plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8442 Dobrica Pavlinusic changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|cnighswon...@foundations.ed |dpav...@rot13.org |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8482] labels creator fixes for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8482 Dobrica Pavlinusic changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Dobrica Pavlinusic --- *** This bug has been marked as a duplicate of bug 8442 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8442] Error when printing labels under plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8442 --- Comment #2 from Dobrica Pavlinusic --- *** Bug 8482 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8442] Error when printing labels under plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8442 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 11040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11040&action=edit Bug 8442 - labels creator fixes for plack - remove all exit(1) and replace them with __END__ which benefits CGI - insert correct =cut markers at end of POD (required for CGI::Compile under plack to correctly parse source code and exeute it) - scope variables with our which are used inside sub for plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8439] Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 --- Comment #5 from Dobrica Pavlinusic --- Sorry about confusion, second patch was supposed to end up in Bug 8482 - labels creator fixes for plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8439] Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Dobrica Pavlinusic changed: What|Removed |Added Attachment #11024|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8482] labels creator fixes for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8482 Dobrica Pavlinusic changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|cnighswon...@foundations.ed |dpav...@rot13.org |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8482] labels creator fixes for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8482 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 11039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11039&action=edit Bug 8482 - labels creator fixes for plack - remove all exit(1) and replace them with __END__ which benefits CGI - insert correct =cut markers at end of POD (required for CGI::Compile under plack to correctly parse source code and exeute it) - scope variables with our which are used inside sub for plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8482] New: labels creator fixes for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8482 Priority: P5 - low Change sponsored?: --- Bug ID: 8482 Assignee: cnighswon...@foundations.edu Summary: labels creator fixes for plack Severity: enhancement Classification: Unclassified OS: All Reporter: dpav...@rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8481] New: Items table shows in opac-MARCdetail.pl but not in MARCdetail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Priority: P5 - low Change sponsored?: --- Bug ID: 8481 CC: gmcha...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Items table shows in opac-MARCdetail.pl but not in MARCdetail.pl Severity: normal Classification: Unclassified OS: All Reporter: gaetan.bois...@biblibre.com Hardware: All Status: NEW Version: master Component: Staff Client Product: Koha In the MARC view on the opac, we have a table that shows items data, we even see 995 fields for items, which seem to be generated on the fly since we have dropped them from the marcxml. In the staff client however, this table is missing from the MARCview, it's a regression since librarians using this view by default wont' have the items information at hand, which used to be the case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8390] Place hold button is missing from the MARC view page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8390 Gaetan Boisson changed: What|Removed |Added Depends on||3142 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Gaetan Boisson changed: What|Removed |Added Blocks||8390 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #17 from Owen Leonard --- Changing this bug's status back to "assigned" since it appears we're waiting for a new patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I'm not sure what problem this patch is trying to address, but it doesn't address the problem I'm trying to describe in this bug. My problem is related to the catalog search results screen. In the staff client, perform a search which will return a result set which includes at least one record with no items. Select all results and click "place hold." The operation will be blocked with the error "One or more selected items cannot be placed on hold." Since request.pl can already sensibly handle multiple holds in this situation it doesn't make sense for the results screen to block the operation. Marking Failed QA because the patch doesn't match the bug, but perhaps the patch belongs on a new bug with a different description? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart --- The solution may be a combination of these 2 patchs. It would allow restriction (from documention) to always be guaranted and existing wrong-formatted category code to be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 --- Comment #7 from Marc Véron --- Jonathan, When our librarians tested Koha for the first time they wanted to have some categories similar to "KIDS 4 +" Then they wanted to delete the code and did not succeed. My patch would have prevented them to enter "illegal" characters (and to have a user experience like 'It does not work'). And if we do not allow to enter illegal characters there is no need to delete entries with illegal characters. I think the main question is: What characters should be / are allowed with category codes? I had a look at the manual for 3.8: http://manual.koha-community.org/3.8/en/patscirc.html#patcats -Snip--- The 'Category Code' is an identifier for your new code. Important The category code is limited to 10 characters (numbers and letters) -End snip--- Your patch assumes that &, @, /, ;, :, =, +, ? and $ are legal characters. Are they (without having side effects at other places in Koha)? Should all characters be allowed? What was (historically) the reason for the restriction in the manual? Why are the codes upper cased by the existing JavaScript? If there are no side effects, your patch is the better solution, because it gives the useres more flexiblity to choose a 'speaking' code. (Manual should then be updated, though). If we have to expect side effects, I would prefer my restricion on data entry. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #33 from Jonathan Druart --- This patch displays a warning with the following command: perl koha_perl_deps.pl -i koha_perl_deps.pl: Use of uninitialized value in formline at koha_perl_deps.pl line 65, line 522. I think it is caused by the missing 'min_ver' information. However, I don't understand what is the value '2' for required. Can you shed some light on this please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8162] packaging scripts create user incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 Robin Sheat changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #8 from Robin Sheat --- These should go in to 3.6 and 3.8 also I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8253] Fine doubling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #7 from Kyle M Hall --- They were simply written at different times. I'd be more than happy to provide a squashed variation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8162] packaging scripts create user incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 --- Comment #7 from Robin Sheat --- Created attachment 11038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11038&action=edit Bug 8162: allow packages to work on Ubuntu Precise The newer version of MySQL in Ubuntu 12.04 installs a default 'localhost' user with no username. Due to the way that MySQL looks up user details when you connect, if you connect from localhost and the user was only created with a wildcard host (%), the anonymous localhost user will be found instead. This means that your username is lost for the connection, and you have no privileges. This patch creates a second user with a hostname of 'localhost'. This will not work if your database is on a remote server, but you probably know what you are doing if that's the case. Patches to determine this server's name relative to the MySQL server are welcome (or even ideas on how to do it.) It also fixes up a couple of other small things: * make koha-remove stop zebra properly * stop the warning that the password file is missing on create -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8253] Fine doubling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #6 from Julian Maurice --- There are 2 patches still 'active'. Should they be applied both? In this case, why not merging them into one single DB rev? Just a note: in the 2nd patch there are commented warns. I think they should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m --- Comment #12 from Jonathan Druart --- Works well It would be great to have the same behaviour for the Intranet systempreference. + Maybe a followup is required to update the description of syspref (support for http AND https) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8479] Opac Holds being created with priority set to NULL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8479 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 11037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11037&action=edit Proposed Patch Removes the if related to the syspref perltidied the reindented code For clarity used rank + 1 rather than rank++ then assigning it as incrementing the variable may suggest to the casual reader that rank is used elsewhere rather than just about to cease to exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart changed: What|Removed |Added Attachment #10930|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 11036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11036&action=edit 8263 Consistent stylesheet prefs This patch makes the use of opaccolorstylesheet and opaclayoutstylesheet more consistent. They may be: 1) just a file name, 2) a complete local path or 3) a full URL starting with http: for a remote css file. This makes the syspref opacstylesheet that was only used for a remote css file obsolete. June 20, 2012 Rebased. July 18, 2012: Regex allows https too (thanks to Owen Leonard). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Jonathan Druart changed: What|Removed |Added Attachment #10633|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 11035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11035&action=edit 8263 Make OPAC stylesheet preferences more consistent (dbrev) This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet. June 21, 2012 & July 4, 2012: Rebased. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
