[Koha-bugs] [Bug 8494] New: use js_beautify.pl to format javascript/jquery code in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8494 Priority: P5 - low Change sponsored?: --- Bug ID: 8494 Assignee: gmcha...@gmail.com Summary: use js_beautify.pl to format javascript/jquery code in Koha Severity: enhancement Classification: Unclassified OS: All Reporter: m...@kohaaloha.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha Koha would benefit from having a method to pretty-format javascript/jquery code (for all the same reasons why we agreed to use perltidy to pretty-format perl code) js_beautify.pl allows us to do that... :) http://search.cpan.org/~fayland/JavaScript-Beautifier/bin/js_beautify.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Mirko, I am not an expert of the apache configuration but it seems it is possible to do that with the RewriteCond and RewriteRule directives. Did you have a look at these directives ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #2) Hi Mirko, I am not an expert of the apache configuration but it seems it is possible to do that with the RewriteCond and RewriteRule directives. Did you have a look at these directives ? I'm not sure you could, in the same way. OpacSuppression lets you put something in 942 that makes an biblio not show in the OPAC. This would let those still show for certain ip ranges while suppressing them for others. I'm not sure how apache could know which items to hide. Unless you made a rule for every biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Julian Maurice julian.maur...@biblibre.com --- The patch doesn't apply on master because it relies on your previous patch. Can you resubmit a clean patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #10982|0 |1 is obsolete|| --- Comment #35 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11098action=edit Bug 6874: Follow-up: fix filename encoding and sanitization for $filename, a / was inserted at the beginning... so a filename like ../foo is ok. Good catch! Fixed in this new patch I think it may be possible to pass the ../ check and with decode_utf8 obtain a ../. To be sure, it should be investigated, but it should be ok to have the decode_utf8 *before* the ../ check. '.' and '/' are ASCII characters. I don't think any UTF-8 operations could change them. But, for safety, decode_utf8 is now before the '../' check -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added CC||ro...@catalyst.net.nz --- Comment #4 from Robin Sheat ro...@catalyst.net.nz --- Mirko, something to consider is that many Koha systems are behind reverse-proxies of various forms. I'm not sure exactly what Apache puts into REMOTE_ADDR, but if it doesn't consider that, it may be worth checking the request headers too (e.g. if the request is from an RFC1918 address, check to see if there's an X-Forwarded-For: header too, or something like that) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: The patch modifies the DB structure but template must be modified too. At least member/memberentrygen.tt: input id=patron_attr_1 type=text name=patron_attr_1 value= maxlength=64 I didn't verify if others occurrences exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7153] Show Open Library as Search Target in More Searches in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|koha.sek...@gmail.com |jonathan.dru...@biblibre.co ||m --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: Change the default value for syspref OPACSearchForTitleIn. Impact only the new installations. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #16 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * unconditionnal warn inside = +warn $backupdir; -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8439] Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- QA comment: tiny patch, same as what is made for other patches for Plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8439] Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8253] Fine doubling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 --- Comment #9 from Julian Maurice julian.maur...@biblibre.com --- I think there is a problem: duplicate rows are not removed. Here's how I tested: I have 1 row in accountlines with accounttype='FU' and description='Orchidées 31/05/2012' I run misc/cronjobs/fines.pl: a duplicate row is created with description='Orchidées 31/05/2012 23:59' Now, I run the updatedatabase: 1st row description is now 'Orchidées 31/05/2012 23:59' (OK) but the 2 rows are still there (KO) Am I doing something wrong? About the patch: there are 2 ' HEAD' remaining in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||7986 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||5600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #10997|0 |1 is obsolete|| --- Comment #17 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11099action=edit Bug 5600: Command line interface for tools/export.pl Removed unconditionnal warn. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 11100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11100action=edit Proposed patch Proposed Patch : Filter suggestions by copyrightdate instead of publicationyear (since it is copyrightdate in the suggestion creation form). Look at Suggestions Management/Bibliographic information. Corrects a bug on date filters (suggested, managed, accepted dates), only suggesteddate could work. Corrects a bug when display by itemtype : itemtype can be null or '' in db. Patch aggregates this two values into the same tab (No name). In suggestion.tt, downsizes a little bit the date fields width so that calendar icon comes on the same line (and so filters part is less high). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
--- Comment #9 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #8)
Frédéric, in kohastructure.sql, the only table which use MyISAM engine
is pending_offline_operations. In my databases, subscription and
borrowers table both use InnoDB, so why they don't in your database?
Good question. Since it's a library currently using Koha database, I'm
sure this issue will occur in real life for others. It means that your
enhancement won't work at all for some (a lot) of libraries. Maybe this
question could be raised on koha-devel list? pointing to this bug.
Engine used for all table:
SELECT TABLE_NAME, ENGINE
FROM information_schema.TABLES
WHERE TABLE_SCHEMA = DATABASE()
I have a lot of Koha DB mixing MyISAM and InnoDB. Why? I have no clue.
Maybe that's because, during the upgrade from 2.x to 3.0, you missed some
message speaking of a problem ? Because the update22to30.pl script update all
tables to innoDB.
# MOVE all tables TO UTF-8 and innoDB
$sth = $dbh-prepare(show table status);
$sth-execute;
while ( my $table = $sth-fetchrow_hashref ) {
next if $table-{Name} eq 'marc_word';
next if $table-{Name} eq 'marc_subfield_table';
next if $table-{Name} eq 'auth_word';
next if $table-{Name} eq 'auth_subfield_table';
if ($table-{Engine} ne 'InnoDB') {
print moving $table-{Name} to InnoDB\n;
$dbh-do(ALTER TABLE $table-{Name} ENGINE = innodb);
}
unless ($table-{Collation} =~ /^utf8/) {
print moving $table-{Name} to utf8\n;
$dbh-do(ALTER TABLE $table-{Name} CONVERT TO CHARACTER SET
utf8);
$dbh-do(ALTER TABLE $table-{Name} DEFAULT CHARACTER SET utf8
COLLATE utf8_general_ci);
# FIXME : maybe a ALTER TABLE tbl_name CONVERT TO CHARACTER SET
utf8 would be better, def char set seems to work fine. If any problem
encountered, let's try with convert !
} else {
}
}
If you have such problems in your database, the good option is to write a small
script in misc/maintenance, that fixes the problem.
It's not the responsibility of this patch, imo, to fix it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8495] New: Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Priority: P5 - low Change sponsored?: --- Bug ID: 8495 Assignee: julian.maur...@biblibre.com Summary: Javascript error when creating a new order Severity: normal Classification: Unclassified OS: All Reporter: julian.maur...@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha Steps to reproduce: - syspref AcqCreateItem='ordering' - syspref UniqueItemFields='barcode' (or something else, but not empty) - with Firebug, enable the 'persistent' mode, so you can see the error message even after form is submitted - create a new order, add 1 item, select a budget and click on save. - you should see in firebug an error like this : Syntax error, unrecognized expression: [value=items.barcode]. This cause the form to be submitted too early in the validation process. Patch is coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8495] Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 --- Comment #1 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11101action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10565|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11102 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11102action=edit Bug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based on reports/itemlost.tt Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8495] Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 --- Comment #5 from Mirko Tietgen 5...@gmx.de --- Jonathan: what Chris says. It's about filtering some, not all results (those marked in 942$c). I don't think that can be achieved with Apache config? Robin: good point, did a little reading on this. It seems like - it won't work with reverse proxies like it is now - you can spoof X-Forwarded-For headers, so using them should be optional A check for RFC1918 addresses sounds like an interesting idea, but is it safe to assume that there would always be a private address here? I doubt that, eg. my university uses external IP addresses everywhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7896] Acquisition statistics wizard: add filters and cell values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #7 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11103 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11103action=edit Bug 7896: follow-up: Allow translation of strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7896] Acquisition statistics wizard: add filters and cell values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896 --- Comment #8 from Julian Maurice julian.maur...@biblibre.com --- (In reply to comment #6) I can't test completly this patch because I haven't enough acquisition data. But it seems to work. Two remarks/demands: [1] GetMarcSubfieldStructureFromKohaField new routine is querying marc_subfield_structure table. It should be cached. Or, since it must have been already retrieved, and cached by GetMarcStructure, the cached version of frameworks must be used. Why ? It is used only once, in a report page, outside of any loop. I don't think we should continue to use the same caching method as the one used for GetMarcStructure as it is not compatible with Plack and mod_perl (and any method that provides persistency) [2] Some texts are not translatable. It was already there, but your patch add text that can't be translated: Fixed in the new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8478] Update Ubuntu related files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #11081|0 |1 is obsolete|| --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Created attachment 11104 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11104action=edit New file for installation instructions under Ubuntu 12.04 I took bits and pieces from the original INSTALL.ubuntu file and what tcohen had posted. I tried to keep lines formatted to 65 wide, except sample output and command-lines. That way cutpasting should work. :) Hopefully this is cleaner. If there are any problems, please let me know. I want this written so that someone not so familiar with linux would be able to follow it. Feedback appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 --- Comment #6 from Mirko Tietgen 5...@gmx.de --- Data::Validate::IP could do these (and more) things is_innet_ipv4 to see if ip is in network given in syspref is_private_ipv4 to see if ip is private Dependencies on Debian Squeeze are available libdata-validate-ip-perl libnet-ipv6addr-perl libnet-netmask-perl libnetwork-ipv4addr-perl What are the rules for introducing perl modules/ dependencies? It could be like this but would introduce a lot of sysprefs option: use OpacSuppression yes/no option: match REMOTE_ADDR and network option: if exists, match X-Forward-For instead of REMOTE_ADDR option: only if REMOTE_ADDR is private IP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 --- Comment #7 from Robin Sheat ro...@catalyst.net.nz --- I wouldn't expect most systems to be on real-world IP addresses if they're behind a proxy anyway, there's no point. And it's only the address of the proxy you care about. Though, thinking about it more, if you're attempting to restrict to part of an RFC1918 set, this would leave forgery open. A better idea would be to specify what your proxy IP/IP pattern is and look for the header only in that case. X-Forwarded-For can be forged, also can (legitimately) have multiple IP addresses in it, but it is possible to be sure about what you're getting. For example, if you know you're behind a proxy you can rely on that header being there, and that the last entry is the real source IP address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11085|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11105 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11105action=edit Bug 7889 - Use standard style for errors and messages Correcting the markup of error messages in three places: catalogue merge, CSV profile editing, and opac comments. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8496] New: show local cover images on lists view in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Priority: P5 - low Change sponsored?: --- Bug ID: 8496 Assignee: oleon...@myacpl.org Summary: show local cover images on lists view in opac Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha It would be nice if local cover images showed when looking at lists in the opac. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8497] New: Strange behavior when modifying the 'timeout' system preference.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Priority: P5 - low Change sponsored?: --- Bug ID: 8497 CC: gmcha...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Strange behavior when modifying the 'timeout' system preference. Severity: enhancement Classification: Unclassified OS: All Reporter: k...@bywatersolutions.com Hardware: All Status: NEW Version: master Component: System Administration Product: Koha The timeout system preference works fine, until I try to define the timeout in days ( e.g. '1d', or '3d' ). Once I have done so, I cannot change it to anything else. I get an error message from the pref system that says I'm logged out and need to log back in. If I click a link, I'm brought to the login page. If I log back in and try to modify the preference, I will get another 'not logged in' message and will start the loop all over again. If I edit the db row directly and change the value back to an integer, everything goes back to normal. I can modify the pref as much as I want, as long as it is an integer. As soon as I use the 'd' option, everything goes haywire again. I noticed in the database, 'timeout' is set to 'Integer'. I tried changing it to 'free' but that did not make a difference. If I dump the value of $timeout in C4::Auth::checkauth, it appears to be correct, even when using the 'd' option, but I end up logged out every time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8495] Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11101|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11106action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8495] Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] New: can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Priority: P5 - low Change sponsored?: --- Bug ID: 8498 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: can't specify an hour when specifying due date Severity: normal Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha With hourly loans Koha can make items due specific hours, but if you have the specify due date box on the checkout screen you can't enter an hour in it ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #4) The patch doesn't apply on master because it relies on your previous patch. Can you resubmit a clean patch? Sorry, that was careless of me. Revision coming up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #11086|0 |1 is obsolete|| --- Comment #6 from Owen Leonard oleon...@myacpl.org --- Created attachment 11107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11107action=edit Bug 8163 [REVISED] Click to populate XSLT preferences with default or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click default or empty to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the default link to populate the field with default. Click the leave empty link to empty the field. Revised according to Julian Maurice's suggestion for a more generic, flexible way to implement it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: You can't modify the prototype of a routine without modifying all the occurrences ! grep is your friend: acqui/uncertainprice.pl:my $pendingorders = GetPendingOrders($booksellerid,0,$owner,$basketno); + Modify POD In the majority of cases, it is preferable to add the new parameters at the end of the parameter's list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11108action=edit Bug 4321: clean C4::Biblio::GetBiblio and uses -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #11107|0 |1 is obsolete|| --- Comment #7 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11109 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11109action=edit [SIGNED-OFF] Bug 8163 [REVISED] Click to populate XSLT preferences with default or empty values Works well. It's really easy to add similar links for other preferences. Great patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: It is a nice feature but a few comments for the new JS function are needed. Indeed, how a new developper can understand the utility of the css class set_syspref ? We can't find it using grep :-/ Marking as Passed QA but a followup is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- OK, this time, passed QA. I also made many tests to check that, with without the syspref ReturnToShelvingCart set the behaviour is unchanged. I could not find any problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 0 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=0action=edit Bug 4491: fix weird code in search scripts This change some code a bit strange, that generate strange effetcs. Now we use $cgi-param to get the values. Test: search at the opac and intranet using limit, etc. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8442] Error when printing labels under plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8442 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 --- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 1 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com --- Submitted patch should address the reported error. Need to add similar tests for hours_between will address that in a separate patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- QA comment: valid_tt.t still OK after this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5409] Call number is not show on Opac search result page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||paul.poul...@biblibre.com
--- Comment #12 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
I think this patch is wrong because OPACItemsResultsDisplay is not updated to
boolean everywhere:
installer/data/mysql/sysprefs.sql still says
INSERT INTO `systempreferences` (variable,value,explanation,options,type)
VALUES('OPACItemsResultsDisplay',statuses,'statuses : show only the status of
items in result list. itemdisplay : show full lo
cation of items (branch+location+callnumber) as in staff
interface',statuses|itemdetails,'Choice');
I think other places are OK.
Please provite an other follow-up switch back to passed QA, i'll push
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8440] Dates does not appear in suggestions management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #3) It would be great to use KohaDates instead of format_date in suggestion.pl Agreed (and agreed it's out of the scope of this patch A minor inconsistency that is due to this patch but a follow-up is welcomed: Suggested by/on says : BERNARDI, Nicole / 24/05/2011 Managed by/on says: BLOT, Sylvie , 10/06/2011 (/ as separator for one , for the other) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #9 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 2 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2action=edit Modified POD and copyright. Also perltidied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #2|Modified POD and copyright. |[Followup] Modified POD and description| Also perltidied|copyright. Also perltidied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 3 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3action=edit Bug 8431 - Followup - Increase maxlength for borrower attributes text input -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- The patch has been pushed, but I'm wondering if there is not another problem: why should the birthdate be mandatory to deal with age limits ? Shouldn't we check AgeLimit anyway ? Shouldn't we have a rule like check AgeLimit if there is a birthdate, otherwise, it's OK ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #27 from Paul Poulain paul.poul...@biblibre.com --- Follow-up pushed (yikes : I wanted to remove the self-signoff put mine, but pushed to quickly...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7367] General OPAC typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11076|0 |1 is obsolete|| --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 11076 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11076 Bug 7367 - One the too many This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7367] General OPAC typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8434] Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8434 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 Severity|enhancement |normal --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed, severity updated to normal instead of ENH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 4 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4action=edit Bug 8431 - Followup - Switch from text input to textarea Switch the text input to a textarea will make editing larger borrower attritube values much easier. Since modern browsers allow for dynamic resizing of textareas, we can keep it small by default and let the library resize it if neccessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8499] New: block based on overdue item type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8499 Priority: P5 - low Change sponsored?: --- Bug ID: 8499 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: block based on overdue item type Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha It would be nice to have a restriction automatically placed on a patrons record when an item on their account with a specific koha item type becomes overdue. For example, if a patron checked out a book with a koha item type two hour check out. If the patron keeps it longer than two hours can Koha automatically restrict the patron's record? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8410] can't edit budget on purchase suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8410 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- We have discovered that staff can add a budget when first entering a purchase request for a patron from the staff client, but cannot modify it once it has been created by either staff or patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8376] Command line utility for exporting borrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
CC||paul.poul...@biblibre.com
Version|master |rel_3_10
--- Comment #7 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
passes perlcritic
(In reply to comment #6)
It would be great to specify a list of borrowernumber (or cardnumber) to
export (with a file given in parameter for example).
Other possible enhancements :
* provide the separator in a parameter
* add a WHERE clause to filter, for example, on a given zipcode, categorycode,
email,...
Another comment: we don't have a coding guideline for that, but I think we
should:
the help should be in POD, like what we have, for example, in:
misc/maintenance/touch_all_biblios.pl
use Pod::Usage;
sub usage {
pod2usage( -verbose = 2 );
exit;
}
i'll send a mail to koha-devel to propose this rule.
Patch pushed, though
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA CC||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- Hey, there's a tiny remaining problem with your patch: * open OPAC tab (or search XSLT, or whatever to reach one of the syspref updated by this patch) * click on default, the default appears in the cell * go to the bottom : damned, the syspref can't be saved because the button is still grey not clickable ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7420] Add max fines to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11083|0 |1 is obsolete|| --- Comment #31 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 11083 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11083 Bug 7420 tiny follow-up, mysql want a space after the -- Yikes, I made a mistake when attaching another patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7302] CSV export of a basketgroup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_10 QA Contact|koha.sek...@gmail.com |m...@kohaaloha.com --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- Small additionnal QA comment: the export as CSV button had no header. I've removed a /td/td to have it in the same column as Reopen and Print buttons Patch pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #10 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #9) Shouldn't we have a rule like check AgeLimit if there is a birthdate, otherwise, it's OK ? I wondered the same thing when I was testing it, but I think it makes sense. Using BorrowerMandatoryFields acts as a de-facto system preference for choosing whether or not the age limit should be enforced. If I want to enforce the age limit on a patron category I want to enforce it on all patrons, not just patrons for whom I have entered a birth date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing addess improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #20 from Paul Poulain paul.poul...@biblibre.com --- This patch does not apply on C4/Acquisition.pm: HEAD ModBasketHeader($basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $booksellerid); === ModBasketHeader( $basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $deliveryplace || undef, $billingplace || undef ); Bug 5356: delivery place and billing place centralised in basket management It seems it's a consequence of bug 8247 patch. I think the solution is to have: ModBasketHeader( $basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $deliveryplace || undef, $billingplace || undef, $booksellerid ); and rewrite ModBasketHeader accordingly (ie = reintroduce booksellerid at the end of the API) QA comments: perlcritic does not pass: perlcritic acqui/basket.pl acqui/basketheader.pl acqui/basket.pl source OK acqui/basketheader.pl: Variable declared in conditional statement at line 135, column 9. Declare variables outside of the condition. (Severity: 5) acqui/basketheader.pl: Variable declared in conditional statement at line 159, column 9. Declare variables outside of the condition. (Severity: 5) (they were OK before the patch valid_tt.t, xt/author/translatable-templates.t and xt/author/valid-templates.t ar OK It would be better to specify where the fields should be added in the table: +$dbh-do(ALTER TABLE aqbasket ADD deliveryplace VARCHAR(10) default NULL;); +$dbh-do(ALTER TABLE aqbasket ADD billingplace VARCHAR(10) default NULL;); +$dbh-do(ALTER TABLE aqbasket ADD freedeliveryplace VARCHAR(10) default NULL;); add a AFTER anotherfieldname to the declaration. I would not have requested that only, but as the patch does not apply and I have other concerns... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #11 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #10) (In reply to comment #9) Shouldn't we have a rule like check AgeLimit if there is a birthdate, otherwise, it's OK ? I wondered the same thing when I was testing it, but I think it makes sense. Using BorrowerMandatoryFields acts as a de-facto system preference for choosing whether or not the age limit should be enforced. If I want to enforce the age limit on a patron category I want to enforce it on all patrons, not just patrons for whom I have entered a birth date. It's a change in the behaviour I was not aware. I think it has been introduced in 3.6. I don't see anything about that in the docs: http://manual.koha-community.org/3.8/en/patscirc.html#patcats Adding Nicole. Nicole, please read comment 9 = age limit is checked only if birthdate is a borrower mandatory field ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 5 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5action=edit Bug 8498 - can't specify an hour when specifying due date With hourly loans Koha can make items due specific hours, but if you have the specify due date box on the checkout screen you can't enter an hour/minute. It will always default to 23:59. * Add jquery timepicker plugin * Update jquery ui to include timepicker prerequisites * Set timepicker's default time to 23:59, remove the hard coded 23:59 setting from circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||elli...@bywatersolutions.co ||m Assignee|kyle.m.h...@gmail.com |elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Patch doesn't apply CC||k...@bywatersolutions.com --- Comment #43 from Kyle M Hall k...@bywatersolutions.com --- Applying: Bug 5911 - Transport Cost Matrix error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:53 error: koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt: patch does not apply Patch failed at 0001 Bug 5911 - Transport Cost Matrix -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #22 from Marc Véron ve...@veron.ch --- Wanted to sign off after my vacancies, first patch does not apply, sorry. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #1 from Elliott Davis elli...@bywatersolutions.com --- Fines Calculation 1) Don’t charge fines when library is closed (Ex: after 5 pm) a) Syspref for how to handle item returns if the return falls during a closed time. b) Make materials due at closed time i) Make materials due next day at time open ii) Open/Closed Rules Creation - This may require that we move everything over to Koha:: from C4:: 2) Recurring times (Ex: Weekdays closed at 5 pm, weekends closed at 3 pm) a) Exceptions (Ex: Closed at noon on Easter) Possible Useful Links: http://search.cpan.org/~fglock/DateTime-Set-0.31/lib/DateTime/Span.pm http://search.cpan.org/~fglock/DateTime-Set-0.31/lib/DateTime/SpanSet.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | --- Comment #2 from Owen Leonard oleon...@myacpl.org --- This patch adds *all* jQueryUI interactions, widgets, and effects to Koha, whereas I was trying to add them only as needed. I would prefer it if you could use the jQueryUI download configuration tool to add just the additional widgets necessary for the timepicker. The current baseline is: - Core - Autocomplete - Tabs - Datepicker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #3 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #2) This patch adds *all* jQueryUI interactions, widgets, and effects to Koha, whereas I was trying to add them only as needed. I would prefer it if you could use the jQueryUI download configuration tool to add just the additional widgets necessary for the timepicker. The current baseline is: - Core - Autocomplete - Tabs - Datepicker Sounds OK/fair to me. What about adding a wiki page (linked to coding guidelines -maybe not coding guidelines page itself) about those rules ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added CC||me...@bywatersolutions.com --- Comment #39 from Melia Meggs me...@bywatersolutions.com --- A new patch coming soon for this!! I want to provide test plans to facilitate community testing. Test plan for On Shelf Holds only Set up the following rules: Rule 1: Patron Category 1 Item type 1 On Shelf Holds Not Allowed Rule 2: Patron Category 2 Item type 2 On Shelf Holds Allowed In both the staff client and the OPAC try the following for each rule combo: Place hold on shelf item Place hold on checked out item Please test with Bug 5787 as well. Test Plan for both On Shelf Holds and OPAC Item Holds together Set up the following rules: Rule 1: Patron Category 1 Item type 1 On Shelf Holds Not Allowed Allow patrons to place item specific holds Rule 2: Patron Category 2 Item type 2 On Shelf Holds Allowed Allow patrons to place item specific holds Rule 3: Patron Category 3 Item type 3 On Shelf Holds Allowed Don't allow patrons to place item specific holds Rule 4: Patron Category 4 Item type 4 On Shelf Holds not Allowed Don't allow patrons to place item specific holds In both the staff client and the OPAC try the following for each rule combo: Place hold on shelf item Place hold on checked out item Place an item specific hold -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added CC||me...@bywatersolutions.com --- Comment #4 from Melia Meggs me...@bywatersolutions.com --- A new patch coming soon for this!! I want to provide test plans to facilitate community testing. Test plan for OPAC Item Holds only: Rule 1: Patron Category 1 Item type 1 Allow patrons to place item specific holds Rule 2: Patron Category 2 Item type 2 Don't Allow patrons to place item specific holds In both the staff client and the OPAC try the following for each rule combo: Place an item specific hold Please test with Bug 5786 as well. Test Plan for both On Shelf Holds and OPAC Item Holds together Set up the following rules: Rule 1: Patron Category 1 Item type 1 On Shelf Holds Not Allowed Allow patrons to place item specific holds Rule 2: Patron Category 2 Item type 2 On Shelf Holds Allowed Allow patrons to place item specific holds Rule 3: Patron Category 3 Item type 3 On Shelf Holds Allowed Don't allow patrons to place item specific holds Rule 4: Patron Category 4 Item type 4 On Shelf Holds not Allowed Don't allow patrons to place item specific holds In both the staff client and the OPAC try the following for each rule combo: Place hold on shelf item Place hold on checked out item Place an item specific hold -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added CC||me...@bywatersolutions.com --- Comment #32 from Melia Meggs me...@bywatersolutions.com --- A new patch coming soon for this!! I want to provide test plans to facilitate community testing. This patch moves ReservesMaxPickUpDelay from system preferences to the circ matrix. It should behave the same way in the circ matrix as it currently behaves as a sys pref. To test: Set ReservesMaxPickUpDelay to 1 Place a hold Check to make sure the item moves from the Holds Waiting tab to the Holds Over tab after 1 day -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8476] Little bug in OPAC XSLT on OPACURLOpenInNewWindow
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8476 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz Version|rel_3_10|rel_3_8 --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8439] Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #20 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz --- Jonathan At first glance this looks good, but do you have an example of a search that provides bad results before this patch, and that is fixed by it please? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz --- Colin, the test is t/Kalendar.t This patch edits the t/Calendar.t which was the test for the old C4::Calendar should we get rid of the t/Kalendar.t one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8500] New: koha-remove needs a --force switch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8500 Priority: P5 - low Change sponsored?: --- Bug ID: 8500 CC: ro...@catalyst.net.nz Assignee: koha-bugs@lists.koha-community.org Summary: koha-remove needs a --force switch Severity: enhancement Classification: Unclassified OS: All Reporter: cnighswon...@foundations.edu Hardware: All Status: NEW Version: rel_3_8 Component: Packaging Product: Koha When running koha-remove, if the db for the instance being removed has been previously dropped, koha-remove throws an error and exits. We should add a --force switch so that koha-remove can be made to continue with the cleanup regardless of what errors it encounters. Of course appropriate warnings should be announced. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Nice catch David, pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911
--- Comment #44 from Srdjan Jankovic srd...@catalyst.net.nz ---
$ git checkout kc/master
...
HEAD is now at 30ee49d... Bug 8376: New script to export borrowers
misc/export_borrowers.pl
$ git am 0001-bug_5911-Transport-Cost-Matrix.patch
Applying: bug_5911: Transport Cost Matrix
/home/srdjan/koha/dev/.git/rebase-apply/patch:131: trailing whitespace.
/home/srdjan/koha/dev/.git/rebase-apply/patch:301: trailing whitespace.
my $request_query = SELECT biblionumber, borrowernumber, itemnumber,
priority, reserves.branchcode,
/home/srdjan/koha/dev/.git/rebase-apply/patch:375: trailing whitespace.
return [ grep {
/home/srdjan/koha/dev/.git/rebase-apply/patch:398: trailing whitespace.
my %specific_items_requested = map { $_-{itemnumber} = 1 }
/home/srdjan/koha/dev/.git/rebase-apply/patch:410: trailing whitespace.
warning: squelched 13 whitespace errors
warning: 18 lines add whitespace errors.
So it went fine here. can you please tell me how you tried to apply it?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8414] Intranet header toplinks display white rather than blue in IE8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8414 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8440] Dates does not appear in suggestions management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #7044|0 |1 is obsolete|| --- Comment #40 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 6 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6action=edit bug_5786, bug_5787, bug_5788: Holds rewrite bug_5786: moved AllowOnShelfHolds to issuingrules bug_5787: moved OPACItemHolds to issuingrules bug_5788: Added reservesmaxpickupdelay to issuingrules C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
