[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Mason James  changed:

   What|Removed |Added

Version|rel_3_8 |master

--- Comment #44 from Mason James  ---
i actually tested these against master,

ill flick the version to reflect that (hope thats ok)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

--- Comment #43 from Mason James  ---
(In reply to comment #40)
> passing QA on 2 patches...

oops, QA'ed the wrong patch

$ koha-qa.pl -c 2

testing 2 commit(s) (applied to commit 32fab74)
 * 66a972f Bug 3652: close XSS vulnerabilities in opac-export
  opac/opac-export.pl

 * 2387688 Bug 3652: close XSS vulnerabilities on biblionumber and authid
  opac/opac-ISBDdetail.pl
  opac/opac-MARCdetail.pl
  opac/opac-authoritiesdetail.pl
  opac/opac-detail.pl
  opac/opac-showmarc.pl

* opac/opac-export.pl  OK
* opac/opac-ISBDdetail.pl  OK
* opac/opac-MARCdetail.pl  OK
* opac/opac-authoritiesdetail.pl   OK
* opac/opac-detail.pl  OK
* opac/opac-showmarc.plOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Mason James  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #42 from Mason James  ---
(In reply to comment #41)
> Created attachment 12926 [details]
> bug 3652 fixing XSS vulnerabilities in opac-search
> 
> Signed-off-by: Mason James 

tested Chris' patch, works well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Mason James  changed:

   What|Removed |Added

  Attachment #12876|0   |1
is obsolete||

--- Comment #41 from Mason James  ---
Created attachment 12926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12926&action=edit
bug 3652 fixing XSS vulnerabilities in opac-search

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

--- Comment #40 from Mason James  ---
passing QA on 2 patches...

$ koha-qa.pl -c 2

testing 2 commit(s) (applied to commit d91a4f8)
 * 09305f2 bug 3652 fixing XSS vulnerabilities in opac-search
  koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
  koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
  koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt

 * 005a1ea Bug 3652: close XSS vulnerabilities in opac-export
  opac/opac-export.pl

* opac/opac-export.pl  OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt   OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt  OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

Robin Sheat  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #4 from Robin Sheat  ---
This, and all its non-Debian dependencies have been uploaded into the
squeeze-dev repo. Please test it to make sure it's installable (as
libkoha-contrib-tamil-perl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Mason James  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #56 from Mason James  ---
(In reply to comment #55)
> Two string follow ups need QA before the string freeze please.
> 
> Thanks
> Nicole

passing QA on these last 2 patches...

$ koha-qa.pl -c 2

testing 2 commit(s) (applied to commit 32fab74)
 * c1fa07f Bug 7986 Follow Up: Fix ExportRemoveFields
 
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

 * 9bafa74 Bug 7986 Follow Up: Update ExportWithCsvProfile
  koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
 
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
  koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref

* koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

--- Comment #3 from Robin Sheat  ---
Also, Koha::Contrib::Tamil appears to depend on itself:

dpkg-buildpackage: source changed by Robin Sheat 
 dpkg-source --before-build Koha-Contrib-Tamil-0.026
dpkg-buildpackage: host architecture i386
dpkg-checkbuilddeps: Unmet build dependencies: libkoha-contrib-tamil-perl
dpkg-buildpackage: warning: Build dependencies/conflicts unsatisfied; aborting.

In a very circular manner, I managed to get a build working without having
itself as a dependency, installed that, and rebuilt with the declared
dependencies. But this isn't an ideal situation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

--- Comment #2 from Robin Sheat  ---
This isn't going to be trivial. A simply built package can't be installed on a
regular system:

The following packages have unmet dependencies:
 libkoha-contrib-tamil-perl : Depends: libanyevent-processor-perl but it is not
installable
  Depends: libmoosex-logdispatch-perl but it is not
installable
  Depends: libmoosex-rw-perl but it is not
installable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

Robin Sheat  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

--- Comment #20 from Mirko Tietgen  ---
Confirming that Dobrica's patch works for the example given by wajasu. Using
TrueType fonts makes sense to me, the hardcoded path is ugly though.

Since PDF (and the problems it comes with) is what we have now that should have
precedence over what would be nice to have in the future.

What about putting the font path in a syspref instead of hardcoding?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #11031|0   |1
is obsolete||

--- Comment #19 from Mirko Tietgen  ---
Created attachment 12925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12925&action=edit
use truetype fonts in PDF::Reuse

Since built-in PDF fonts suport just latin-1 encoding, we have
to switch to truetype fonts to correctly encode all utf-8 characters
(which we should be getting from database anyway).

This approach also nicely sidesteps our encoding cludges, but
requires paths to truetype fonts, so this example has single
path hard-coded.

I don't know if it's better to put font path into koha-conf.xml or
can we somehow get it from system. I did try to figure out if
fc-list can display paths, but failed.

http://bugs.koha-community.org/show_bug.cgi?id=8375

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mi...@abunchofthings.net

--- Comment #6 from Mirko Tietgen  ---
Hi Jane,

thanks a lot for working on this. Changing the bug status to "in discussion"
for now as it needs another database update as Chris explained. If you have any
questions feel free to ask :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2832] Make alphabet localizable

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2832

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

--- Comment #10 from Mirko Tietgen  ---
Tested with mildly crazy cyrillic (kildin saami), IPA and others. Finally I am
able to browse people like Hans ʘ͡qrder :) Works as expected, did not manage to
break it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2832] Make alphabet localizable

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2832

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #12761|0   |1
is obsolete||

--- Comment #9 from Mirko Tietgen  ---
Created attachment 12924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12924&action=edit
Bug 2832 - Make alphabet localizable

Adds the "alphabet" syspref, which can hold a space separated list
of charachters, which can be expanded into browse links when needed.

To test:
- Make sure to run updatedatabase
- Check that the "alphabet" syspref was added under "I18N/L10N preferences"
- Check that browse links are displayed Home › Patrons
- Add some weird charachters like ÆØÅ to "alphabet" and check that the
  browse links are still displayed ok

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7854] preferences.pl: cannot have choice options of yes and no

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
No, if we explicitly type YesNo as a boolean, like Srdjan has shown, then we
have to change none of the YesNo prefs.

And the Choice ones will work the way they should. IE Yes becomes 1, only when
it's used with a boolean field (as it should).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #23 from Chris Cormack  ---
(In reply to comment #18)
> > The simpliest way is to change 'yes' and 'no' with 'allow' and 'noallow' for
> > example.
> 
> I completely agree. Trying to override the implicit typing just to use 'yes'
> and 'no' seems a bit silly and overly complicated.
> 
> I've written a followup to do just that ( coincidentally, I used 'allow' and
> 'noallow' without knowing you had suggested the same thing! ).
> 
> Jonathan, I hope it's ok that I've obsoleted your one patch, as this patch
> is essentially a replacement for that one.

I disagree, implicit typing is wrong, and the real fix is what Srdjan outlined
on bug 7854.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|srd...@catalyst.net.nz  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7854] preferences.pl: cannot have choice options of yes and no

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|7825|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|7854|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12922|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 12923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12923&action=edit
Bug 7825: Followup - Change choices to avoid conflicts with system preference
implicit typing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12915|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 12922
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12922&action=edit
Bug 7825: Followup - Change choices to avoid conflicts with system preference
implicit typeing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12884|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall  ---
Created attachment 12921
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12921&action=edit
[SIGNED-OFF] Bug 7825: Followup prevent submission without choosing an item

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12883|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall  ---
Created attachment 12920
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12920&action=edit
[SIGNED-OFF] Bug 7825 - Change OPACItemHolds syspref to be of type Choice,
choices being "no", "yes", "force"

Signed-off-by: Delaye Stephane 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

--- Comment #24 from Chris Cormack  ---
(In reply to comment #23)
> Created attachment 12913 [details]
> proposed patch to match 3.8.x
> 
> Hello Chris,
> done, I hope this one is ok.
> For the follow up I had no conflicts so it must be ok.
> thx

Unfortunately still has a conflict.  

Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging acqui/parcel.pl
CONFLICT (content): Merge conflict in acqui/parcel.pl
Auto-merging C4/Acquisition.pm

Looks like something to do search has snuck in 


my $datereceived =  ($input->param('op') eq ('new' or "search")) 

Should that be in 3.8.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 12919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12919&action=edit
Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited)

useDaysMode=Datedue wasn't used as advertised in the docs. Added
next_open_day and prev_open_day subs to Koha::Calendar and some tests for them.

- CalcDateDue was modified to be consistent with the intended behaviour
- Koha::Calendar->addDate was rewritten in a more sane way (also split into
  addHours and addDays for convenience).

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #10 from Owen Leonard  ---
Created attachment 12918
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12918&action=edit
Bug 8913 [Follow-up] Improve acquisitions navigation

This follow up adds the vendor menu and toolbar to booksellers.pl
when there is only one "search result" (i.e. a vendor id is passed).

- Menu appears when booksellerid variable is present
- Redundant heading removed
- Additional variables added to enable proper display of the toolbar

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8945] New: Koha 3.10 Help Files Update

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8945

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8945
  Assignee: neng...@gmail.com
   Summary: Koha 3.10 Help Files Update
  Severity: major
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
  Hardware: All
Status: ASSIGNED
   Version: rel_3_10
 Component: Documentation
   Product: Koha

This will be my standing bug for Koha 3.10 help file updates.  

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8944] fix wording on invoice search

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8944

Owen Leonard  changed:

   What|Removed |Added

  Attachment #12916|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 12917
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12917&action=edit
[SIGNED-OFF] Bug 8944: Fix invoices search wording

When the invoices page has no results it asks the user
to use the form on the left to search. This patch fixes the
wording to make it a bit clearer.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8944] fix wording on invoice search

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8944

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #9 from Nicole C. Engard  ---
All looks good in the revised patch... do I sign off or wait for more feedback
and additions to menu pages?

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Nicole C. Engard  changed:

   What|Removed |Added

Version|master  |rel_3_10

--- Comment #1 from Nicole C. Engard  ---
This is a big issue that needs to be looked at before 3.10 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #8 from Nicole C. Engard  ---
I like it and think you're on the right track :) Will test the newest patch.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

--- Comment #55 from Nicole C. Engard  ---
Two string follow ups need QA before the string freeze please.

Thanks
Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8944] fix wording on invoice search

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8944

Nicole C. Engard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8944] fix wording on invoice search

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8944

--- Comment #1 from Nicole C. Engard  ---
Created attachment 12916
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12916&action=edit
Bug 8944: Fix invoices search wording

When the invoices page has no results it asks the user
to use the form on the left to search. This patch fixes the
wording to make it a bit clearer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8944] New: fix wording on invoice search

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8944

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8944
  Assignee: neng...@gmail.com
   Summary: fix wording on invoice search
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
  Hardware: All
Status: ASSIGNED
   Version: rel_3_10
 Component: Acquisitions
   Product: Koha

The coming patch will fix the wording on the invoice page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #18 from Kyle M Hall  ---
> The simpliest way is to change 'yes' and 'no' with 'allow' and 'noallow' for
> example.

I completely agree. Trying to override the implicit typing just to use 'yes'
and 'no' seems a bit silly and overly complicated.

I've written a followup to do just that ( coincidentally, I used 'allow' and
'noallow' without knowing you had suggested the same thing! ).

Jonathan, I hope it's ok that I've obsoleted your one patch, as this patch is
essentially a replacement for that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12885|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 12915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12915&action=edit
Bug 7825: Followup - Change choices to avoid conflicts with system preference
implicit typeing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7854] preferences.pl: cannot have choice options of yes and no

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||k...@bywatersolutions.com

--- Comment #1 from Kyle M Hall  ---
I may be wrong, but if we remove the implicit type, won't that screw up pretty
much every existing YesNo system preference? We would have to find every
reference for every YesNo pref and change the conditional tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|cnighswon...@foundations.ed |k...@bywatersolutions.com
   |u   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12912|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Zeno Tajoli  ---
The test of this patch is failed.
The instructions say:
4. Add EANs to your local ordering branches
Go to Administration > Additional Parameters > EDI EANs

This operation is not possible because the .pl files
admin/edi_ean_accounts.pl
admin/edi_ean_edit.pl  
and the connect table 'edifact_ean' are not more present in the patch

The .pl files and the definiton of the table were present in the version of the
patch dated 2011-06-11

It not clear if are wrong instructions or code.
If instructions are correct probably a merge of the two patch is possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #7 from Owen Leonard  ---
Oh, and the fact that basket groups doesn't have the menu is because I haven't
worked on every acquisitions page yet. If folks think I'm on the right track
here I will keep going.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #6 from Owen Leonard  ---
(In reply to comment #2)

> The Uncertain Prices tab links to: http://localhost:/...

Whoops. Funny, it worked fine on my system ;)

> Also, it's kind of annoying that clicking basket and basket groups makes the
> menu on the left go away.

The baskets link points to booksellers.pl which is both the baskets page for an
individual vendor and the search results page for a vendor search. I was
looking at it more as the latter, but I see now that it would make sense for a
follow-up to add the sidebar menu if booksellerid is defined.

(In reply to comment #3)
> At the top of the contract page there are buttons to edit and delete the
> vendor - they kind of seem out of place there.

My reorganization of acquisitions-related navigation tries to organize things
in sensible groups, so in this case my goal is to group all vendor-specific
pages together and offer vendor-related views and actions on each of those
pages. Since contracts are specifically associated with vendors I thought this
grouping made sense. However, I'm not an acquisitions user so I hope others can
give their opinions too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8939] Fines Charged During Grace Period

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939

--- Comment #4 from Robert Williams  ---
Thanks, Chris. I think I see what I did wrong now. I'll give it a better go
next time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

Owen Leonard  changed:

   What|Removed |Added

  Attachment #12890|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 12914
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12914&action=edit
Bug 8913 [Revised] Improve acquisitions navigation

This patch adds a new menu for vendor-related pages in which
vendor related "views" can be linked to: baskets, basket groups,
contracts, invoices, uncertain prices.

The acquisitions toolbar is pared down to vendor-related actions:
New basket, contract, or vendor; edit vendor, delete vendor,
receive shipment.

Other small improvements have been made to other pages: corrections
to breadcrumbs and title tags, adding useful links betweeen pages.

Revision corrects broken links.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4177] opaccloud missing from the system preferences interface

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4177

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4177] opaccloud missing from the system preferences interface

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4177

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart  ---
The patch adds a missing pref in the .pref file.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8861] Undefined variables in batchMod.pl trigger error logs

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8861

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8861] Undefined variables in batchMod.pl trigger error logs

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8861

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart  ---
Looks good, marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

--- Comment #23 from Christophe Croullebois 
 ---
Created attachment 12913
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12913&action=edit
proposed patch to match 3.8.x

Hello Chris,
done, I hope this one is ok.
For the follow up I had no conflicts so it must be ok.
thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

--- Comment #1 from Kyle M Hall  ---
Created attachment 12912
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12912&action=edit
Bug 8943 - Add table sorting to labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] New: Add table sorting to labels

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8943
  Assignee: cnighswon...@foundations.edu
   Summary: Add table sorting to labels
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: k...@bywatersolutions.com
  Hardware: All
Status: NEW
   Version: master
 Component: Label printing
   Product: Koha

Currently, the label-manage.pl has a table that is sorted by the label id (
i.e. by the order in which the rows were inserted into the database ). This
sorting is not very useful. It would be better to allow sorting, and to sort by
name by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #44 from Jonathan Druart  ---
(In reply to comment #43)
> Question:
> 
> Attachment #10480 [details] brings in the follwoing dependency: 
> +'JSON::Any' => {
> +'usage'=> 'Core',
> +'required' => '0',
> +'min_ver'  => '1.28',
> +},
> 
> JSON::Any seems to be deprecated, see:
> http://search.cpan.org/~perigrin/JSON-Any-1.29/lib/JSON/Any.pm#DEPRECATION
> 
> Where is it used?
> 
> Marc

Hi Marc,

JSON::Any is recommended by MooseX::Storage

aptitude show libmoosex-storage-perl
Depend: perl, libmoose-perl (>= 0.99), libstring-rewriteprefix-perl
Recommande: libjson-any-perl, libyaml-perl

I think it is why I added it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12815|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  ---
Created attachment 12911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12911&action=edit
Bug 8832: Update the gist pref and hide the tax rate value if not needed

The gist system preference will be updated with the existing values and
with the supplier's gstrate values.
The "Tax rate" part becomes hidden if the syspref is not filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8782] Close a subscription

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782

--- Comment #9 from Jonathan Druart  ---
Created attachment 12910
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12910&action=edit
Bug 8782: Followup: add some minor modifications

- Show 'closed' information in biblio detail page
- Add a column in serials report table
- Search subscriptions on title words instead of string
- Prevent serials editing when subscription is closed
- Don't change status of "disabled" serials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8782] Close a subscription

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12305|0   |1
is obsolete||
  Attachment #12879|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  ---
Created attachment 12909
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12909&action=edit
Bug 8782: Close a subscription

If a subscription is no longer enough published (or we are not waiting
for a new periodical) we are allowed to close it.
If a subscription is closed, we are not able to receive or generate a
new serial.

On the serial module, we can now
- close a subscriptionn
- reopen a closed subscription

On serial search 2 tabs is displayed (opened and closed subscriptions).

This patch adds:
- a new field subscription.closed in DB
- a new status for serials (8 = stopped)

Test plan:
- search subscriptions
- close a subscription and check that you cannot receive or generate a
  new serial
- launch another search and check that the closed serial is into the "closed"
  tab.
- You are allowed to reopen a subscription on the subscription detail
  page and on the subscription result page. A javascript alert ask you
  if are certain to do this operation.
- Check the serial status "stopped" everywhere the status is
  displayed (catalogue/detail.pl, serials/claims.pl,
  serials/serial-issues-full.pl, serials/serials-collection.pl,
  serials/serials-edit.pl, serials/serials-recieve.pl,
  serials/subscription-detail.pl and opac-full-serial-issues.pl)
- The report statistics does not include the closed subscriptions if you
  don't check the "Include expired subscriptions" checkbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

--- Comment #4 from Frédéric Demians  ---
> Is there not a risk to convert quotes with the fact that TT elements are
> translated (they are %s) ?

I don't think so. This patch transform only strings coming from JS. I've done a
grep -R "&apos" and """ in fr-FR opac & staff templates directory, and I
didn't find anything wrong. You can check yourself after applying this patch,
and regenerating localized templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

--- Comment #3 from Fridolyn SOMERS  ---
Is there not a risk to convert quotes with the fact that TT elements are
translated (they are %s) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8940] patron card export - without a batch, will work if...

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8940

--- Comment #1 from Waqar Azeem  ---
as an additional comments, i would like this feature in upcoming release.
https://vimeo.com/51583419
(Admin can generate Patron/Member cards directly from his page)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #12907|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 12908
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12908&action=edit
Bug 8942 Fix translation of JS strings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Frédéric Demians  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

--- Comment #1 from Frédéric Demians  ---
Created attachment 12907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12907&action=edit
Bug 8942 Fix translation of JS strings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8942] New: Translation process breaks javascript in calendar.inc

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8942
CC: frede...@tamil.fr
  Assignee: koha-bugs@lists.koha-community.org
   Summary: Translation process breaks javascript in calendar.inc
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: fridolyn.som...@biblibre.com
  Hardware: All
Status: NEW
   Version: master
 Component: translate.koha-community.org
   Product: Koha

In french translation of calendar.inc :
Because (line 31) :
currentText: _('Today'),
is translated
currentText: _('Aujourd'hui'),
additionnal quote brakes the Javascript.

This provokes the use of american format dates in calendar pop-up.

I had a discussion on translate list, the way chosen to repair it is to use
HTML escape char sequence "'" instead of single quote in translated
strings.
Same thing for double quotes, &, < and >.

So I will correct on translate site but one can follow the resolution on this
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8660] Tag status does not show on multiple tag add

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8660] Tag status does not show on multiple tag add

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #12642|0   |1
is obsolete||

--- Comment #11 from Fridolyn SOMERS  ---
Created attachment 12906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12906&action=edit
Proposed patch (follow-up) (rewritten)

Follow-up rewritten : 
Same modifications in opac.css.
Added porting of modifications in doc-head-close.inc and tags.js

(also corrects the comment : 8860 instead of 8660)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8660] Tag status does not show on multiple tag add

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #11786|0   |1
is obsolete||

--- Comment #10 from Fridolyn SOMERS  ---
Created attachment 12905
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12905&action=edit
Proposed patch (rebased master)

Main patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #28 from M. de Rooy  ---
QA Comment:
Looks good to me. Mainly improving details in Zebra config files.
Passing QA with the note that a followup is still needed for packaging
(debian/templates). Please contact packaging manager for details.
RM may decide if this can be pushed already or should wait for its packaging
followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8941] Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

--- Comment #5 from Mirko Tietgen  ---
Tiny patch, works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8941] Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #12902|0   |1
is obsolete||

--- Comment #4 from Mirko Tietgen  ---
Created attachment 12904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12904&action=edit
Bug 8941 - Make title display properly for NORMARC OPAC detail view

Authors and materialtype were displayed to the right of the title.
This patch simly adds class="title" to the h1 that holds the title.

To test:
- Set marcflavour = NORMARC
- Check a detail view in the OPAC and see that the display is wrong
- Apply the patch
- Check that the detail view now looks good

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

M. de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

M. de Rooy  changed:

   What|Removed |Added

  Attachment #11886|0   |1
is obsolete||

--- Comment #27 from M. de Rooy  ---
Created attachment 12903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12903&action=edit
Signed patch for 3087

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

--- Comment #21 from Magnus Enger  ---
That *is* weird. For me, both the test itself and staging and importing
t/db_dependent/www/data/marc21record.mrc manually works as expected. But the
format of the marc file definitely seems to be the problem then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #26 from M. de Rooy  ---
(In reply to comment #25)
> It is like that since patch for bug 7818. I really don't know if it is
> necessary or not. Don't you thing that this issue, if it is one, should
> be covered by a new bug or as follow-up for bug 7818?

This is just an minor issue. As you say, probably for another report. I will
signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8941] Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Magnus Enger  ---
If this gets pushed, it would be nice to have in 3.8.x too. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

--- Comment #20 from M. de Rooy  ---
I still do not get this working.
Manually importing the data file, I have the impression that this file is the
actual problem. When importing, I see under Citation: Englewood Data str
This probably should have been Data structures.
Is this marc datafile really in good shape? I do not think so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8941] Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

--- Comment #2 from Magnus Enger  ---
Created attachment 12902
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12902&action=edit
Bug 8941 - Make title display properly for NORMARC OPAC detail view

Authors and materialtype were displayed to the right of the title.
This patch simly adds class="title" to the h1 that holds the title.

To test:
- Set marcflavour = NORMARC
- Check a detail view in the OPAC and see that the display is wrong
- Apply the patch
- Check that the detail view now looks good

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8941] Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

--- Comment #1 from Magnus Enger  ---
Created attachment 12901
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12901&action=edit
Screenshot showing what it should look like

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #25 from Frédéric Demians  ---
> A small point additionally: I see the lines
>   
>   
> in koha-conf.xml but not in retrieval-... files (only syntax=marc21).
> If we can add them here, these sections are more in line.
> It will give you recordSchema F and B as well on the sru output.

It is like that since patch for bug 7818. I really don't know if it is
necessary or not. Don't you thing that this issue, if it is one, should
be covered by a new bug or as follow-up for bug 7818?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8941] New: Make title display properly for NORMARC OPAC detail view

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8941

  Priority: P5 - low
 Change sponsored?: Sponsored
Bug ID: 8941
  Assignee: mag...@enger.priv.no
   Summary: Make title display properly for NORMARC OPAC detail
view
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: mag...@enger.priv.no
  Hardware: All
Status: NEW
   Version: master
 Component: OPAC
   Product: Koha

Created attachment 12900
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12900&action=edit
Screenshot showing title, author and materialtype displayed wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8940] New: patron card export - without a batch, will work if...

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8940

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8940
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: patron card export - without a batch, will work if...
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: waqar.az...@itcompletes.com
  Hardware: All
Status: NEW
   Version: master
 Component: Patrons
   Product: Koha

This code seem to have a bug!

I didn't find any online browse-able code therefore a snip-it from
"create-pdf.pl" is here:

grep {
push(@{$items}, {item_number => $_});
} @borrower_numbers;

'item_number' itself is not used anywhere. 'browser_number' is used to
retrieved this data.

foreach my $item (@{$items}) {
if ($item) {
my $borrower_number = $item->{'borrower_number'};

So, 'item_number' should be replaced with 'borrower_number'

URL to test:
http://your-testIP/cgi-bin/koha/patroncards/print.pl?borrower_number=19

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #24 from Magnus Enger  ---
(In reply to comment #23)
> Magnuse: Is it a problem if with this patch, Koha Z39.50 server says that it
> returns NORMAC records to clients? It used to say record were in MARC21
> (which was the problem for UNIMARC biblios).

Nope, that definitely sounds like an improvement!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #23 from Frédéric Demians  ---
Marcel: Thanks for your patience!

Magnuse: Is it a problem if with this patch, Koha Z39.50 server says that it
returns NORMAC records to clients? It used to say record were in MARC21 (which
was the problem for UNIMARC biblios).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8662] Remove unused famfamfam icons

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662

Bug 8662 depends on bug 8793, which changed state.

Bug 8793 Summary: Fix materialTypeCode/typeOf008 icons for NORMARC XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793

Magnus Enger  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Magnus Enger  ---
(In reply to comment #6)
> Patch pushed to master
> (untested, Magnus, please, double check ;-) )

Works nicely on master, as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #22 from Magnus Enger  ---
I had a look at this from a NORMARC perspective, and as far as I can tell
(without actually testing it) it will be OK for NORMARC. I'll take the blame if
it isn't... :-) 

Please remember that debian/templates/koha-conf-site.xml needs to be changed
too, so installations running off the packages behave the same way as the
others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #16 from Jonathan Druart  ---
Ho ok, it's what you explain in the Bug 7854 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

--- Comment #19 from Magnus Enger  ---
(In reply to comment #14)
> Just looking at the previous comment, I wonder why it should find the title
> Data structures. On Manage staged MARC records, I can see the file name, but
> not this title.
> Please explain. Changing status to reflect need of clarification. 
> Thank you.

I think I found an axplanation for this: After the file is uploaded you get a
list of information as shown in the screenshot I just uploaded. This list has a
link labelled "Manage staged records" which takes you directly to the records
you just uploaded. This is the link the test follows on line 157:

$agent->follow_link_ok( { text => 'Manage staged records' }, 'view batch' );

And this page should display the titles of the uploaded/staged records. From
the test output it looks like your title might have been truncated to
">Englewood Data str"? 

If you want to spend more time on this you might try and put an __END__ below
line 165, like so:

$agent->content_contains( $bookdescription, 'found book' );
__END__
$agent->form_number(5);

This will let you visit "Staged MARC record management" and see what the
results of the staging looks like (before it is removed further down in the
test).

(I just tested the patch on another installation and it still works for me :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #21 from M. de Rooy  ---
Frederic,
I was close to signing off on this one, but still have one concern. This patch
may probably break things for the NORMARC flavour. Could you make a small
adjustment that makes NORMARC behave like it was MARC21? 

Magnuse will test BTW.

A small point additionally: I see the lines
  
  
in koha-conf.xml but not in retrieval-... files (only syntax=marc21).
If we can add them here, these sections are more in line.
It will give you recordSchema F and B as well on the sru output.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #15 from Jonathan Druart  ---
(In reply to comment #14)
> No disrespect, I understand the motivation, but I deliberately created 7854
> in order to be able to avoid 0, 1, force. I could have done it that way
> myself, but it is wrong and perpetuates a deficiency in the config system

Hi Srdjan!
The values 'yes' and 'no' can't be choosen for systempreferences.
When you change the value of OPACItemHolds using the interface
(preferences.pl), only 'force' is keep. 'yes' and 'no' are respectively
replaced with 1 and ''.
So you can't use the comparaison with 'yes' in the template.

This behaviour is due to the YAML::Syck::ImplicitTyping flag set to on (see
http://search.cpan.org/~toddr/YAML-Syck-1.21/lib/YAML/Syck.pm#$YAML::Syck::ImplicitTyping).

The simpliest way is to change 'yes' and 'no' with 'allow' and 'noallow' for
example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

--- Comment #18 from Magnus Enger  ---
Created attachment 12899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12899&action=edit
Screenshot showing the link followed by the test script on line 157

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8906] Improve OAI management interface

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8906] Improve OAI management interface

2012-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906

Chris Cormack  changed:

   What|Removed |Added

  Attachment #12775|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 12898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12898&action=edit
Bug 8906 - Improve OAI management interface

Revising OAI configuration interface to conform to
existing interface patterns:

- Properly-formatted form rows
- "clone" and "clear" links consistent with other
  forms which use these conventions
- Improved title and breadcrumbs
- Standard save and cancel markup

New to the mappings interface: A "clear" button
to remove or empty the contents of a row. This replaces
the help text about emptying fields.

To test: view, add and edit OAI sets and mappings. Try adding
and removing multiple set descriptions and mappings.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/