[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #13 from Katrin Fischer --- To be more clear - I am talking about the updatedatabase.pl part of this patch :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9545] Fix Import Marc Bibliographic Framework Text Label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9545 David Cook changed: What|Removed |Added Attachment #15240|0 |1 is obsolete|| Attachment #15288|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 15289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15289&action=edit [SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Signed-off-by: David Cook Works as described, although I see what Owen means about it being a good candidate for replacement with a modal dialog box in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9545] Fix Import Marc Bibliographic Framework Text Label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9545 --- Comment #3 from David Cook --- Created attachment 15288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15288&action=edit [SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Signed-off-by: David Cook Works as described, although I see what Owen means about it being a good candidate for replacement with a modal dialog box in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #12 from Katrin Fischer --- For example we could check for English strings in the permissions description - so German and other translated permissions would not be harmed by this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #1 from David Cook --- Created attachment 15287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15287&action=edit Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. This patch also adds stylistic spacing/nesting to the HTML, so that it is easier to visually separate elements when debugging. 99.9% of the mods in this patch are actually just whitespace alterations. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashionwith the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8034] Enable server print queue selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8034] Enable server print queue selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #35 from Srdjan Jankovic --- Created attachment 15286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15286&action=edit bug_8034: Disable delete printer for printers asigned to branches * C4::Printer - added branch count to printer queries * admin/printers.tt - show or not delete link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9603] New: Fix layout of Patron Card Creator Layout screen for display in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Bug ID: 9603 Summary: Fix layout of Patron Card Creator Layout screen for display in IE Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parents of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #11 from Chris Cormack --- (In reply to comment #9) > Um, hate to point it out - but this untranslates existing translated > permissions for non-English installations... could we add a condition here > please? Sorry Katrin, not sure what you mean here? What kind of condition? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9592] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9592 Robin Sheat changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9592] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9592 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9592] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9592 Robin Sheat changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9592] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9592 --- Comment #2 from Robin Sheat --- Created attachment 15285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15285&action=edit Bug 9592 - update dependencies, allow blacklisting * Update the dependencies to match master * Blacklist the CHI and Data::Pagination * Perltidyed the list-deps script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9592] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9592 --- Comment #1 from Robin Sheat --- Created attachment 15284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15284&action=edit Bug 9592 - remove db-dependency from Members.pm This was causing test cases to fail on package builds, introduced in bug 7243. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||dc...@prosentient.com.au --- Comment #34 from David Cook --- I really like the idea of this patch, but it still has quite a few issues. 1) This patch doesn't apply to the staff client, so library staff are still restricted to 1 hold per patron per record, even with the new system preference set to 3. 2) This patch does apply to the OPAC. You are able to place holds (as the patron) on 3 items in a record when you have the system preference set to 3. However, when you try to place a 4th hold, the error message that appears is: "Sorry, none of these items can be placed on hold." "Title / by Author. This title cannot be requested." That error message doesn't really reflect the actual situation. While I think the first message is accurate, I think the second one should say "You have exceeded the maximum number of holds (3) for this record." or something along those lines. -- Stylistically, I think the Javascript warning on the staff client when exceeding the maximum number of holds could be improved. Currently, it is: "This patron has already placed the maximum number of holds for this record Please cancel a previous hold first" These two sentences should have periods at the end and be separated with another new line. -- >From a purely functional level, it seems like you're nearly there though! I'll be excited to see this one come through :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #9 from Katrin Fischer --- Hi Jonathan, I read through your code and have some questions, mostly about documentation: 1) I was wondering if this line in the POD for CanBookBeRenewed makes sense: C<$dbh> is a DBI handle to the Koha database. Just a note, little typo a few lines below: C<$CanBookBeRenewed> returns a true value _iff_ the item may be renewed. The ... 2) POD for CalcDateDue misses $isrenewal 3) In the circulation matrix the new field is named "Renewals period" - "Renewal period" looks a bit better to me, but we are both not native speakers, so I will leave that to someone else. :) I also ran the test suite - so far it looks good. I will continue with testing the interface next. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Jonathan, I have started testing this - could you please add some unit tests in a follow up for the changed routines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #10 from Katrin Fischer --- Apart from that I think staffaccess does not do what the description says, as that is what permissions does: INSERT INTO `userflags` VALUES(5,'permissions','Set user permissions',0); +INSERT INTO `userflags` VALUES(17,'staffaccess','Allow staff members to modify permissions for other staff members',0); >From looking at the code and from what we experienced with one of our libraries I think the permission is actually about changing other staff account details (like passwords, usernames, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Um, hate to point it out - but this untranslates existing translated permissions for non-English installations... could we add a condition here please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8662] Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Can we get one or two more opinions on this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9570] view plain not working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9570] view plain not working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Nicole C. Engard changed: What|Removed |Added Attachment #15277|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 15283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15283&action=edit [SIGNED-OFF] Bug 9570 - view plain not working in ccsr The code in opac-showmarc.pl isn't smart enough to find the xsl files in the "default" (prog) theme if the ccsr theme is enabled, so the "view plain" option on opac-MARCdetail.pl fails ever time. This patch copies some path-handling code from XSLT.pm to improve xsl file path handling when dealing with a "sub-theme." To test, view the MARC view in the OPAC and click the "view plain" link. This should work correctly in prog and ccsr themes and with different languages enabled (keeping in mind the ccsr theme will fail in general for languages other than en). Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9597] grab order info from the 970 when ordering from staged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9597 --- Comment #3 from Nicole C. Engard --- Agreed! A preference or something where you define what field and subfield to look in for the info. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Katrin Fischer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Katrin Fischer changed: What|Removed |Added Attachment #14924|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 15282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15282&action=edit Bug 9454: Use placeholders when adding basket Should always use placeholders when passing variables to DBI; avoids unforeseen bugs and security issues. Also: - reformated the long lists of parameters to add CR - moved the setting of defaults out of the call to ModBasket to clarify code - Setting parameters to undef if they were not defined was unnecessary bloat and obscuration Testing: Patch should not change functional behaviour. To test check that order baskets can still be correctly created. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer All tests and QA script pass. Created a new basket, added order lines and closed basket. Checked everything worked in the staff interface, also checked the entry for the new basket in aqbasket in the database. Logs are clean too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de Severity|minor |major --- Comment #6 from Katrin Fischer --- Looking at this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 Katrin Fischer changed: What|Removed |Added Attachment #15246|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 15281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15281&action=edit Bug 8913 [Revised] Improve acquisitions navigation This patch adds a new menu for vendor-related pages in which vendor related "views" can be linked to: baskets, basket groups, contracts, invoices, uncertain prices. The acquisitions toolbar is pared down to vendor-related actions: New basket, contract, or vendor; edit vendor, delete vendor, receive shipment. Other small improvements have been made to other pages: corrections to breadcrumbs and title tags, adding useful links betweeen pages. Vendor menu and toolbar are added to booksellers.pl when there is only one "search result" (i.e. a vendor id is passed). - Menu appears when booksellerid variable is present - Redundant heading removed - Additional variables added to enable proper display of the toolbar - Revision corrects broken links pointed out by QA. - Revision adds check of existing baskets and subscriptions as a condition on display of the vendor delete button. TODO: Add coverage of Basket groups page. To test, navigate Acquisitions pages and test as many links and buttons as you can, confirming that nothing is broken on vendor pages, invoice pages, contract pages, uncertain price pages, etc. Signed-off-by: Katrin Fischer All tests and QA script pass. Tests done: 1) New toolbar - vendor search - no results = button to create new vendor shows - 1 result = additional new options show - more than one result = button to create new vendor shows 2) Vendor views - acq toolbar consistent with 1 result in vendor search - new tabs on the left - checked all links have the needed parameters and work correctly 3) New toolbar - different pages - Toolbar is formatted consistently - Delete vendor shows only up when it should - no baskets or subscriptions - Links work correctly Works nicely, great groundwork for further improvements. TODO Add new toolbar to (new) invoices page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9602] New: allow/disallow self check out based on item type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9602 Bug ID: 9602 Summary: allow/disallow self check out based on item type Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A nice addition to the circulation matrix would be whether to allow self check outs or not on a patron category/item type basis. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9601] New: ccsr opac no results found ugly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9601 Bug ID: 9601 Summary: ccsr opac no results found ugly Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com Created attachment 15280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15280&action=edit no results In the CCSR template the no results page could use some work. See attached. The column on the left looks like it wants to appear and the text at the top is smooched together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Owen Leonard changed: What|Removed |Added Depends on||9420 Severity|trivial |normal --- Comment #1 from Owen Leonard --- This feature broke when we upgraded tabs handling to the latest version of jQueryUI. Something about the way tabs are displayed confuses how the mouse position is reported by JavaScript. This should probably be reworked to use one of the UI libraries we already have (or will have): jQueryUI or Bootstrap. A jQueryUI version will require a jQueryUI upgrade, and of course a Bootstrap version will require approval of the Bootstrap patches on Bug 9420. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420 Owen Leonard changed: What|Removed |Added Blocks||9572 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9597] grab order info from the 970 when ordering from staged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9597 Zeno Tajoli changed: What|Removed |Added CC||z.taj...@cineca.it --- Comment #2 from Zeno Tajoli --- It is important that the tag and the subfield are configurable. Not all vender use 970 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Elliott Davis changed: What|Removed |Added CC||elli...@bywatersolutions.co ||m Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9257] Add "groups" to normal search pulldown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Kyle M Hall --- (In reply to comment #6) > This seems to be working, but I noticed the update message in > updatedatabase.pl seems to be copy-paste from another patch. Fixed! > I also still see JavaScript in the template. Is that still doing something? > Can it be removed? I believe all the js was removed by the followup, I've squashed the two patches together for easier reading ( and the fact that separate patches was unnecessary ). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9257] Add "groups" to normal search pulldown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall changed: What|Removed |Added Attachment #14364|0 |1 is obsolete|| Attachment #14365|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 15279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15279&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #14 from Kyle M Hall --- Jonathan, I cannot recreate your error. When I try placing a hold on a bib with no items I get the correct behavior as described. Do you think you could provide me with some more info and perhaps re-test it? (In reply to comment #13) > QA Comment: > > I got an error: > > DBD::mysql::st execute failed: You have an error in your SQL syntax; check > the manual that corresponds to your MySQL server version for the right > syntax to use near ')' at line 3 at /home/koha/src/C4/Koha.pm line 833. > > Debug: request.pl l.320, the @itemnumbers is empty > > The issue appears when I place on hold a biblio without item. > > Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9597] grab order info from the 970 when ordering from staged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9597 --- Comment #1 from Nicole C. Engard --- Created attachment 15278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15278&action=edit B&T Marc Here's a couple of records with 970 fields. I don't know what each subfield breaks down to, but it's a start. =LDR 00411cam 2200145 a 4500 =001 BK0010765945 =003 DLC =005 20121207121548.0 =020 \\$a9780425255391 : PAP$c{dollar}15.00 =020 \\$a0425255395 : PAP$c{dollar}15.00 =092 \\$aON ORDER =100 1\$aKingsley, Allie. =245 14$aThe liar, the bitch and the wardrobe / =260 \\$aNew York :$bBerkley Books,$cc2012. =970 \\$apor$b1$cabkf$dbk$fporfr$i9780425255391$p15.00$qBT =LDR 00508nam 2200145 a 4500 =001 BK0011935722 =005 20130124092532.0 =020 \\$a9780062248473 : HRD$c{dollar}27.99 =020 \\$a0062248472 : HRD$c{dollar}27.99 =092 \\$aON ORDER =100 1\$aHill, Jenna Miscavige. =245 10$aBeyond belief :$bmy secret life inside Scientology and my harrowing escape / =260 \\$aNew York :$bWilliam Morrow,$c2013. =970 \\$apor$b1$cabknf$dbknew$fpanf$i9780062248473$p27.99$qBT =970 \\$ash$b1$cabknf$dBK$fshanf$i9780062248473$p27.99$qBT =LDR 00496pam 2200145 i 4500 =001 BK0011239403 =003 DLC =005 20121023144150.0 =020 \\$a9781455515486 : HRD$c{dollar}25.99 =020 \\$a1455515485 : HRD$c{dollar}25.99 =092 \\$aON ORDER =100 1\$aRecitas, Lyn-Genet. =245 14$aThe plan :$beliminate the surprising "healthy" foods that are making you fat-- and lose weight fast / =260 \\$aNew York, NY :$bGrand Central Life & Style,$c2013. =970 \\$apor$b1$cabknf$dbknew$fpanf$i9781455515486$p25.99$qBT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #20 from Kyle M Hall --- Robin, any chance of a rebase for these patches? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9553] link authorities to bibs when imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9553 Nicole C. Engard changed: What|Removed |Added Blocks||9600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9600] New: create authorities on import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9600 Bug ID: 9600 Summary: create authorities on import Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com CC: m.de.r...@rijksmuseum.nl Depends on: 9553 When importing a batch of bib records if the records don't match an authority record it would be nice if Koha created an authority record for you (controlled by biblioaddsauthority preference) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3462] Link see also in authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9589 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9589] authorities to authorities linker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=3462 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9599] New: printable work slip on receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Bug ID: 9599 Summary: printable work slip on receipt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com It would be nice to have a work slip that can be printed at the time of receipt in acquisitions that can be passed on to the cataloger so that he/she can then finish the processing of the item. It should include the bib record info and the item info. It could maybe be controlled by notices and slips and show whatever the library wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9598] New: pro-rate shipping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9598 Bug ID: 9598 Summary: pro-rate shipping Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com It would be nice if Koha could pro-rate the shipping when receiving. That way it splits up the shipping cost between all of the funds used in the basket and not just one fund selected when receiving the basket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9597] New: grab order info from the 970 when ordering from staged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9597 Bug ID: 9597 Summary: grab order info from the 970 when ordering from staged Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com Baker and Taylor puts order information in the 970 field in the carts on their site. What you do is go to B&T create a cart, enter in the info you want to order and then pass that cart information on to the acquisitions person. That person then reviews and downloads the cart as MARC. In that file (which I hope to get a sample of) there is a 970 field that has the library, the fund, the pricing, and more. It would be nice if that field was read by Koha when ordering from a staged file. Right now staged file ordering just grabs the price from the ISBN field and nothing else. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9570] view plain not working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9570] view plain not working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 --- Comment #1 from Owen Leonard --- Created attachment 15277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15277&action=edit Bug 9570 - view plain not working in ccsr The code in opac-showmarc.pl isn't smart enough to find the xsl files in the "default" (prog) theme if the ccsr theme is enabled, so the "view plain" option on opac-MARCdetail.pl fails ever time. This patch copies some path-handling code from XSLT.pm to improve xsl file path handling when dealing with a "sub-theme." To test, view the MARC view in the OPAC and click the "view plain" link. This should work correctly in prog and ccsr themes and with different languages enabled (keeping in mind the ccsr theme will fail in general for languages other than en). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #3 from mathieu saby --- My solution was changing these lines in MungeMarcPrice routine: - ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/; + ( $price ) = $price =~ m/([\d\,\.]+[\,|\.\d\d]?)/; ## Split price into array on periods and commas my @parts = split(/[\,\.]/, $price); ## If the last grouping of digits is more than 2 characters, assume there is no decimal value and put it back. my $decimal = pop( @parts ); - if ( length( $decimal ) > 2 ) { + if ((scalar @parts == 0) or ( length( $decimal ) > 2 )) { M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 mathieu saby changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||mathieu.saby@univ-rennes2.f ||r --- Comment #2 from mathieu saby --- Hello Lyon 3 I noticed the problem last week. I have worked on a solution of my own, and our vendor (Biblibre) has been working on it too... So I set the bug In Discussion. Mathieu Saby Rennes 2 university -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8079] opac not showing fines - says 'no'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8079] opac not showing fines - says 'no'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 --- Comment #3 from Kyle M Hall --- Created attachment 15276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15276&action=edit Bug 8079 - opac not showing fines - says 'no' Make charges of type FU be counted for opac-user.pl Test Plan: 1) Checkout an item to a patron, back date the date due enough to create fines 2) Run fines.pl 3) Log into the patron's account via the OPAC 4) Note the fines line for that issue says 'No' 5) Apply patch 6) Reload opac-user.pl, not the fines column now says 'Yes' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8079] opac not showing fines - says 'no'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8079 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- It appears that only charges of the types F and L are counted, but not FU. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7608] Manual history is always 'enabled'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jonathan Druart changed: What|Removed |Added Attachment #15260|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 15275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15275&action=edit Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7608] Manual history is always 'enabled'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha.sek...@gmail.com |jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- QA comment: Works as advertised. Note that a complete rewrite of this part of code is waiting sign-off (Bug 7688). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 --- Comment #9 from Fred P --- Sorry, that's probably a separate issue... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 Fred P changed: What|Removed |Added CC||fred.pie...@smfpl.org --- Comment #8 from Fred P --- You may be aware about the IndependantBranches preference issue. Setting IndependantBranches to "Don't Prevent" overrides the AutoLocation "Require" ip range restrictions, allowing remote access from anywhere, with implications for security. Auth.pm around line 834: if (C4:Context->boolean_preference('IndependantBranches') && C4::Context->boolean_preference('AutoLocation')){ # we have to check they are coming from the right ip range If we do not restrict remote access, we need to implement stronger login security. So I am wondering how the new IndependantBranches settings affect security. Are we still wide open to password cracking if we say "Don't Prevent" for IndependantBranches? Or do the new settings help secure the system? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9591] Set Library changes after viewing Holds Queue >> reserves item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 --- Comment #1 from Owen Leonard --- Steps to reproduce: 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jared Camins-Esakov changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #10 from Jared Camins-Esakov --- I will return the status to Passed QA, and revisit this once bug 9431 has been QAed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7253] fast cataloging not always checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9585] Fix spelling mistake in default tab conditional for opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 Jonathan Druart changed: What|Removed |Added Attachment #15261|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 15274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15274&action=edit Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9585] Fix spelling mistake in default tab conditional for opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- QA comment: In opac-detail.tt, the test is on the string "subscriptions". Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9591] Set Library changes after viewing Holds Queue >> reserves item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Owen Leonard changed: What|Removed |Added Version|3.10|master Summary|BUG: Set Library changes|Set Library changes after |after viewing Holds Queue |viewing Holds Queue >> |>> reserves item|reserves item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 e-Libris Technologies changed: What|Removed |Added CC||elibris.helpd...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9569] IndependantBranches preference appears to override AutoLocation security feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 Owen Leonard changed: What|Removed |Added Summary|RESOLVED: |IndependantBranches |IndependantBranches |preference appears to |preference appears to |override AutoLocation |override AutoLocation |security feature |security feature| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #9 from Jonathan Druart --- Jared, Yes, this patch depends on Bug 9431. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9569] RESOLVED: IndependantBranches preference appears to override AutoLocation security feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 --- Comment #2 from Fred P --- My mistake again. This problem is still active. This line from Auth.pm yields the result that you must set AutoLocation to "Require" AND IndependantBranches to "Prevent" to secure your Koha. Auth.pm around line 834: --- if (C4:Context->boolean_preference('IndependantBranches') && C4::Context->boolean_preference('AutoLocation')){ # we have to check they are coming from the right ip range --- The other three combinations of these two settings result in a system that anyone can remotely access and hack, because we don't limit password attempts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #8 from Jared Camins-Esakov --- I get a javascript error from this patch: Uncaught TypeError: Property 'natural-asc' of object # is not a function As a result of the Javascript error (I think), I get the following problematic display: http://screencast.com/t/k4l8TAppdWC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9471] Use DataTables on serials claims page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] New: longoverdue by library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Bug ID: 9596 Summary: longoverdue by library Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice if the longoverdue script took a list of branch codes as a value so that each library could have different settings for long overdue. Or nicer still if it was just built in to Koha's staff GUI. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9469] Use Datatables in serials statistics wizard
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9469 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9440] update Koha's LICENSE file from GPL2 to GPL3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9440 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9595 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9595] Update About page for license update to GPL3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9595 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9440 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9595] New: Update About page for license update to GPL3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9595 Bug ID: 9595 Summary: Update About page for license update to GPL3 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: neng...@gmail.com Reporter: katrin.fisc...@bsz-bw.de About page needs to be updated to reflect license update (see also bug 9440). Currently it states: Koha Koha is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9594] New: order item subfields in framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594 Bug ID: 9594 Summary: order item subfields in framework Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com CC: m.de.r...@rijksmuseum.nl It would be nice if in the item field (952) in the framework editor could have the fields put in any order. Having a way to say subfield p is first, and then a and then b or whatever you want is desirable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9440] update Koha's LICENSE file from GPL2 to GPL3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9440 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9105] Moving Z3950 search code to Breeding.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9323] Untranslatable string in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9180] Default rules are not always used for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Koha Team AMU changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 15273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15273&action=edit Followup Bug 5858 - Default frameworks missing many MARC21 tags It's a pity, but this patch re-instates deleted fields to prevent data loss. Also correct minor errors, and add field 883. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #10393|0 |1 is obsolete|| --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 15272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15272&action=edit [SIGNED-OFF] Bug 5858 - Updating the marc21_framework_DEFAULT.sql to MARC21 version 14 Based on work in the Koha Kobli fork Signed-off-by: Bernardo Gonzalez Kriegel Comment: deleted fields added in a followup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9588] weighted search query with index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9588 --- Comment #3 from Paul Poulain --- Created attachment 15271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15271&action=edit Bug 9588: weighted search query with index When QueryWeightFields is enabled, the searching query is created with several options. In C4::Search::_build_weighted_query, when no index is defined, the query is build with fuzzy and stemming options. When an index is defined, theses options are missing, only unconditional right truncation is used. The consequence is that when QueryStemming is disabled, a search with index can give more results (due to right truncation) that a search without. This patch adds stemming and fuzzy on search with index, conditioned with QueryFuzzy and QuerryStemming sysprefs. Also changes world list search (wrld) weight to r6 in order to set fuzzy search to r8 and stemming search to r9 (like search without index). Test plan : - Go to searching preferences (admin/preferences.pl?tab=searching) - Set QueryAutoTruncate to "only if * is added" - Set QueryFuzzy and QuerryStemming to "Don't try" - Set QueryWeightFields to "Enable" - Go to advanced search page - Select an indexe (ie Title) and perform a search on a short word => Look at zebrarv log and see that query does not contain right truncation : @attr 5=1 - Set QueryFuzzy to "Try" - Perform same search => Look at zebrarv log and see that query contains fuzzy : @attr 5=103 - Set QueryFuzzy to "Don't try" and QuerryStemming to "Try" - Perform same search => Look at zebrarv log and see that query contains rigth truncation on stemmed word : @attr 5=1 Signed-off-by: koha.aixmarseille -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9588] weighted search query with index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9588 Paul Poulain changed: What|Removed |Added Attachment #15239|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9588] weighted search query with index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9588 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paul.poul...@biblibre.com --- Comment #2 from Paul Poulain --- Patch tested with a sandbox, by koha.aixmarseille -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9588] weighted search query with index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9588 Koha Team AMU changed: What|Removed |Added CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What|Removed |Added Attachment #15269|Prices not imported |filetest.elc description|correctly from a staged | |file| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #1 from Koha Team Lyon 3 --- Created attachment 15270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15270&action=edit Bug 9593 Prices not imported correctly from a staged file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] New: Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Bug ID: 9593 Summary: Prices not imported correctly from a staged file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr Created attachment 15269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15269&action=edit Prices not imported correctly from a staged file When importing a record from a staged file, sometimes, the price is set to 0 in the Vendor price field (Accounting details block) even if initially present. it occurs when the price is written without decimals : example : 19 EUR. In this case it's not captured by the regular expression in MungeMarcPrice routine (Biblio.pm) : ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/; Same thing if the currency symbol was used after the digits, the result would be the same because of this : $price = $parts[1]; If I got it well, seems that the whole routine can be replaced by 2 regular expressions (may be we could even go up to a single one) integrated in GetMarcprice : the first part (symbol treatment) is unusefull as it can be treated directly by the regular expression that's following it. The part concerning groups of more than 2 digits ( if I got it, it 's come out to delete the eventual separator between thousands and hundreds) can be replaced by another regular expression. Test Plan : 1) get on your pc, the joined example file (testfile.elc). That's the kind of file most currently used in France for our acquisitions. Most of the prices in it match the pattern '[digit][digit] EUR' except 2 titles out of them : La méthodologie appliquée du commentaire de texte (14,20 EUR) Le tournant artiste de la littérature française (54,80 EUR) 2) Go to Tools/Stage MARC records for import and stage it in koha. 3) Go to Acquisition module, and an open basket of your choice and click on 'From a staged file' 4) Choose testfile.elc and add it to the basket 5) Click on the first individual 'add order' link : the price might beeing set to 00.00 in the 'Vendor price' field of Accounting details block. 6) Now go back with go back function of your browser : 7) Apply the patch 8) Click again on the same link 9) The price is now present (I hope so) 10 Sign off (I hope so again) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9511] DOM indexing problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511 Melia Meggs changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #37 from Chris Cormack --- Just updating for myself, so I push it to stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #5 from Katrin Fischer --- Hi Tigran, not sure what to do about this, but reopening the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/