[Koha-bugs] [Bug 5463] limit to available shows on hold items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 --- Comment #1 from Nicole C. Engard --- This is still an issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #53 from Derryn --- (In reply to comment #52) > Derrin, if you use -html option, you have to check html on you notice > template in order your email get the right content type. > > And KohaAdminEmailAddress is only used if Library email address is not set. > This was the previous way to send overdues and this patch does not change > that. This is without the -html option. I'm not outputting them to a file, which the -html option is for; I'm making them to email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #61 from Bernardo Gonzalez Kriegel --- Created attachment 15825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15825&action=edit Bug 8917 : [ Sign followup ] Track clicks to links external to Koha Remove empty pod section in Koha/Linktracker.pm to make koha-qa happy. Add missing "\n" in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15815|0 |1 is obsolete|| --- Comment #60 from Bernardo Gonzalez Kriegel --- Created attachment 15824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15824&action=edit [SIGNED-OFF] Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html Signed-off-by: Bernardo Gonzalez Kriegel General comment: Work as described. No errors. Tested all preference values with and without logged in user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15812|0 |1 is obsolete|| --- Comment #59 from Bernardo Gonzalez Kriegel --- Created attachment 15823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15823&action=edit [SIGNED-OFF] Bug 8917 : Shifting db dependent code to a module Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15787|0 |1 is obsolete|| --- Comment #58 from Bernardo Gonzalez Kriegel --- Created attachment 15822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15822&action=edit [SIGNED-OFF] Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15786|0 |1 is obsolete|| --- Comment #57 from Bernardo Gonzalez Kriegel --- Created attachment 15821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15821&action=edit [SIGNED-OFF] Bug 8917 : Link tracking, changes to XSLT Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15785|0 |1 is obsolete|| --- Comment #56 from Bernardo Gonzalez Kriegel --- Created attachment 15820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15820&action=edit [SIGNED-OFF] Bug 8917 : Script to log link clicks Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15784|0 |1 is obsolete|| --- Comment #55 from Bernardo Gonzalez Kriegel --- Created attachment 15819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15819&action=edit [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15783|0 |1 is obsolete|| --- Comment #54 from Bernardo Gonzalez Kriegel --- Created attachment 15818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15818&action=edit [SIGNED-OFF] Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15811|0 |1 is obsolete|| --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 15817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15817&action=edit [SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Collapsing restored. No errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #15802|0 |1
is obsolete||
--- Comment #13 from Bernardo Gonzalez Kriegel ---
Created attachment 15816
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15816&action=edit
[SIGNED-OFF] Bug 6209 [Revised] Standardize on one plugin for client-side form
validation
This patch adds the jQuery "Validation" plugin
(http://docs.jquery.com/Plugins/Validation) and includes it by
default in the staff client along with an include file containing
translatable strings for all of the plugin's possible messages.
The staff client's main JavaScript file has been modified to perform
automatic validation of any form with the class "validated."
For a simple example I have modified the library entry form
to mark required fields as required (something which had not
been done before). Each required field has been given a class,
"required" and the HTML5 attribute "required." The former adds
the hook for the plugin, the latter adds browser-based validation
in recent browsers (and which will be superceded by the plugin
if JavaScript is enabled).
This will check for inputs classed "required" without any
additional configuration. More complex forms (with specific
data types, for instance) will require more inline JavaScript
configuration.
$("#FormID").validate({ /* configuration details */ });
Also added to the library entry form are checks on the email and URL
fields via classes ("email" and "url", respectively). This demonstrates
validation of content without forcing the field to be required.
To test, go to Administration -> Libraries and Groups and choose
"New library." Submit the form without entering a library code
or name. You should be prevented from submitting the form and be
shown an error message by each field. Perform the same check with an
existing entry.
To test browser-based validation, disable JavaScript and follow
the same procedure.
Revision rebases the patch against current master and adds missing
"//
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #53 from Chris Cormack --- Created attachment 15815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15815&action=edit Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature But the bug only becomes visible with link tracking on Prior to this patch it would put an empty link in the html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #24 from Owen Leonard --- I have attached a rebased copy of my patch because I think git was breaking something in it's auto-merge with the Bootstrap changes. Kyle I'm not sure why you created your patch as a follow-up to mine, since our approaches are so different. I think yours should be constructed as a separate patch and presented as an alternative rather than a follow-up to mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #15767|0 |1 is obsolete|| --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 15814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15814&action=edit [SIGNED-OFF] Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ Signed-off-by: Bernardo Gonzalez Kriegel Comment: All combination of options tested. Works well. No errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack changed: What|Removed |Added Severity|enhancement |new feature --- Comment #52 from Chris Cormack --- Shifted the db insert to a new module. Spotted a bug with the behaviour of the links that existed before this new feature, even if we dont have a uri, we are putting an empty href in. Will do a follow up to fix this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard changed: What|Removed |Added Attachment #15759|0 |1 is obsolete|| --- Comment #23 from Owen Leonard --- Created attachment 15813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15813&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables. The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Rebased on current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #51 from Chris Cormack --- Created attachment 15812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15812&action=edit Bug 8917 : Shifting db dependent code to a module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Chris Cormack changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Owen Leonard changed: What|Removed |Added Attachment #15743|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 15811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15811&action=edit Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Owen Leonard --- Returning to "Passed QA" as per jcamins' instructions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What|Removed |Added Attachment #15775|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 15810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15810&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart Further revision removes old tablesorter code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Pierre Angot changed: What|Removed |Added CC||tredok.pie...@gmail.com --- Comment #12 from Pierre Angot --- Hello, I've tested with files added by Henri-Damien on sandbox (http://pro.pelardon.biblibre.com test/test) - search authorities "Littérature sentimentale", edit it and modify 250$a (Harlequin champion de l'amour) - search catalog "100 romans d'amour" - check 606 - No change : 606$a is still "Littérature sentimentale". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9293] action_logs not tracking payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 --- Comment #15 from Kyle M Hall --- (In reply to comment #14) > Hi Kyle, > Don't you think JSON::to_json is more adapted than Data::Dumper::Dumper here? I think that's a great idea, but Dumper is currently the way most everything is stored for the action logs. Perhaps we should submit a bug to switch everything to that and have it depend on this bug. We would have to have updatedatabase convert everything that is already in the action logs as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7883] save and continue editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Elliott Davis changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7883] save and continue editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Elliott Davis changed: What|Removed |Added Attachment #15500|0 |1 is obsolete|| --- Comment #7 from Elliott Davis --- Created attachment 15809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15809&action=edit Added the ability to save and continue editing in cataloging. This patch adds the ability for catalogers to save and continue editing when adding new biblios. This is helpful in the event of a power failure or perhaps in the event you step away for a sandwich and your co-worker closes your tab to look at cats. To Test: Select an existing item or create a new item in cataloging using your favorite framework. Edit the item >From the save menu in the dropdown, select the new option of "Save and continue editing" If you are missing requited fields you should still be prompted to fill them in before saving Once all required fields are in place you should be allowed to save and should be on the same page (You're fresh bib record should also be saved) http://bugs.koha-community.org/show_bug.cgi?id=7883 Modified: Changed malformed urls in form submits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9550] Replace PazPar2 with MetaProxy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9550 Elliott Davis changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall --- Looks good but a couple things that should probably be taken care of before passing qa: 1) The "Show notes" buttons should probably be titled "Add notes" instead. 2) When doing a multi-hold, clicking one "Show notes" button hides the previously visible note textarea. This is jarring and may confuse patrons into thinking they can only have a note on one and only one of the holds. It would be better to make each "Show notes" button a toggle to hide it's own note textarea, and clear that textarea if it gets hidden. You could even change the text from "Add notes" to "Remove notes" when the textarea is visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #5 from Kyle M Hall --- Created attachment 15808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15808&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What|Removed |Added Attachment #15753|0 |1 is obsolete|| Attachment #15806|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 15807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15807&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall changed: What|Removed |Added Attachment #15752|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 15806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15806&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9716] opaclayoutstylesheet and opaccolorstylesheet must be filled in for CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9716 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9716] opaclayoutstylesheet and opaccolorstylesheet must be filled in for CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9716 Kyle M Hall changed: What|Removed |Added Attachment #15718|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 15805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15805&action=edit Bug 9716 - opaccolorstylesheet must be filled in for CCSR To test: Empty out your opaccolorstylesheet system preference (for fun, but not necessary, you can empty out your opaclayoutstylesheet preference too) Switch themes to CCSR Load the opac - if it doesn't go horribly wrong the patch is working. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- I believe it would be more proper to disable the "my privacy' tab if AnonymousPatron is not a valid patron. This would be more in line with how OPACPrivacy requires opacreadinghistory and the tab does not show if opacreadinghistory is not set to "Allow". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Kyle M Hall changed: What|Removed |Added Attachment #15777|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 --- Comment #3 from Kyle M Hall --- Created attachment 15804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15804&action=edit Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. 4) prove t/Installer_PerlModules.t # which checks String::Random is required Sponsored-by: software.coop Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9740] using XSLT modifies record authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9740] using XSLT modifies record authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15803&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9740] New: using XSLT modifies record authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Bug ID: 9740 Summary: using XSLT modifies record authorized values Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: fridolyn.som...@biblibre.com When using XSLT display, in detail.pl, the record (MARC::Record) is get from database. This record is given to XSLTParse4Display() to transform into HTML using XSLT. This method uses transformMARCXML4XSLT() to replace in record authorized values code by there description. The bug is that this change is made on original record and remains in the rest of the script detail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209
Owen Leonard changed:
What|Removed |Added
Attachment #15141|0 |1
is obsolete||
--- Comment #12 from Owen Leonard ---
Created attachment 15802
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15802&action=edit
Bug 6209 [Revised] Standardize on one plugin for client-side form validation
This patch adds the jQuery "Validation" plugin
(http://docs.jquery.com/Plugins/Validation) and includes it by
default in the staff client along with an include file containing
translatable strings for all of the plugin's possible messages.
The staff client's main JavaScript file has been modified to perform
automatic validation of any form with the class "validated."
For a simple example I have modified the library entry form
to mark required fields as required (something which had not
been done before). Each required field has been given a class,
"required" and the HTML5 attribute "required." The former adds
the hook for the plugin, the latter adds browser-based validation
in recent browsers (and which will be superceded by the plugin
if JavaScript is enabled).
This will check for inputs classed "required" without any
additional configuration. More complex forms (with specific
data types, for instance) will require more inline JavaScript
configuration.
$("#FormID").validate({ /* configuration details */ });
Also added to the library entry form are checks on the email and URL
fields via classes ("email" and "url", respectively). This demonstrates
validation of content without forcing the field to be required.
To test, go to Administration -> Libraries and Groups and choose
"New library." Submit the form without entering a library code
or name. You should be prevented from submitting the form and be
shown an error message by each field. Perform the same check with an
existing entry.
To test browser-based validation, disable JavaScript and follow
the same procedure.
Revision rebases the patch against current master and adds missing
"//
[Koha-bugs] [Bug 6209] Standardize on one javascript library for client-side form validation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #52 from Sophie MEYNIEUX --- Derrin, if you use -html option, you have to check html on you notice template in order your email get the right content type. And KohaAdminEmailAddress is only used if Library email address is not set. This was the previous way to send overdues and this patch does not change that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #9 from Magnus Enger --- So I finally got around to spending some more time on this, and looks like there are three problems here, from the point of view of a package install: * 1. usmarc.mar After bug 3087 this file gets the marcflavour of the installation. I think the solution is to have one file for each marcflavour, e.g. marc21.mar, normarc.mar and unimarc.mar. usmarc.mar is referenced by the different record.abs files for the different marcflavours, so updating them to point to the right .mar file for their flavour should be trivial. Side note: I'm not sure what role the .mar file actually plays in Zebra/Koha. I have tried changing the contents around a bit without any apparent influence on searching. The only documentation I have been able to find is this: 3.9. The MARC (ISO2709) Representation (.mar) Files This file provides rules for representing a record in the ISO2709 format. The rules pertain mostly to the values of the constant-length header of the record. http://www.indexdata.com/zebra/doc/grs-conf.html#grs-mar-files Perhaps Robin is right too, in that it could have been left as it was before Bug 3087? * 2. koha-conf.xml Occurences of hardcoded "usmarc" in debian/templates/koha-conf-site.xml.in need to be replaced with the __ZEBRA_MARC_FORMAT__ placeholder, so it can get the right values when a new site is created: >From To * 3. retrieval-info-*-*.xml To be exact: retrieval-info-auth-dom.xml retrieval-info-auth-grs1.xml retrieval-info-bib-dom.xml retrieval-info-bib-grs1.xml Similar to koha-conf.xml, the __ZEBRA_MARC_FORMAT__ placeholders in these files now get replaced with the actual marcflavour in a regular installation. In a dev install you will have one copy of each of these files for each of your installations, so verything works as expected. Not so for package installs, where these files are not genereated from templates and so continue to have the hardcoded "usmarc". Another major problem is that these files are common to all the instances on a server (in /etc/koha/zebradb). So it looks like we either have to - make the packages generate these files from templates whenever a new instance is added, and find a way to make them instance-sepecific (not shared), or - create one file for each marcflavour and make whatever references these files reference the files for the right marcflavour As far as I can tell, the files that reference these files are the koha-conf.xml files. It looks like it should not be too hard to make the retrieval-info-*.xml files instance specific and generate them from a template. That way we just have two sets of template files to keep updated, and not 3 versions of each of the files, for different marcflavours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 MJ Ray (software.coop) changed: What|Removed |Added Severity|blocker |new feature --- Comment #7 from MJ Ray (software.coop) --- Downgrading to the same status as 7167 until 7167 is pushed, because this is not blocking the release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #233 from MJ Ray (software.coop) --- Could we downgrade Bug 9326, then? I don't think 9326 should block release. Also, it appears unnecessarily high in the needs-signoff list and ahead of this bug which it depends upon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739
--- Comment #2 from Fridolyn SOMERS ---
Created attachment 15801
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15801&action=edit
Proposed patch (followup)
Follow up patch for cosmetic changes :
- perltidy
- q{} for SQL query instead of ""
- list of columns is SQL query instead of SELECT *
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|Medium patch|Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS --- Created attachment 15800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15800&action=edit Proposed patch See commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jared Camins-Esakov changed: What|Removed |Added Severity|blocker |new feature --- Comment #232 from Jared Camins-Esakov --- Bug 9326 is a blocker only if this feature is pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 MJ Ray (software.coop) changed: What|Removed |Added CC||m...@software.coop Severity|new feature |blocker --- Comment #231 from MJ Ray (software.coop) --- I am upgrading this to blocker because it blocks bug 9326 which is a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2283] Poor use of "Not Found" redirect in response to corrupt MARC record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2283 MJ Ray (software.coop) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from MJ Ray (software.coop) --- Yes, that fix removed the redirect. I agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] New: more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bug ID: 9739 Summary: more options for serialsUpdate.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. A library reported that this automatic note can not be changed nor disabled. So I propose to add an option to defined note (keeping default one if not defined) and and option to disable this note. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Fridolyn SOMERS changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #3 from Fridolyn SOMERS --- Your right Chris, I did not knew this behavior. On a biblio edition : biblioitems.timestamp is always updated (because marcxml and marc are updated), but biblio.timestamp is updated only if a concerned column is updated (title, author, ...). Closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #50 from Jonathan Druart --- Chris, I feel like you are upset. Did I offense you? If it is the case, I am sorry, I didn't mean it. I am just trying to do my QA job, and this job consists in following the coding guidelines. I just would like to understand why do you think this remark is no relevant, because I though i was. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nuño López Ansótegui changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nuño López Ansótegui changed: What|Removed |Added Attachment #15797|0 |1 is obsolete|| --- Comment #14 from Nuño López Ansótegui --- Created attachment 15799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15799&action=edit Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9293] action_logs not tracking payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #14 from Jonathan Druart --- Hi Kyle, Don't you think JSON::to_json is more adapted than Data::Dumper::Dumper here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #13 from Jonathan Druart --- Comment on attachment 15797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15797 Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt Review of attachment 15797: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9040&attachment=15797) - ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ +1480,4 @@ > [% IF ( itemdata_copynumber ) %][% > ITEM_RESULT.copynumber %][% END %] >[% INCLUDE 'item-status.inc' item = > ITEM_RESULT %] > [% IF ( itemdata_itemnotes ) %][% > ITEM_RESULT.itemnotes %][% END %] > +[% IF ( itemdata_datedue ) %][% IF > ITEM_RESULT.datedue %][% ITEM_RESULT.datedue | $KohaDates %][% END %] tag END missing for the first IF statement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy --- QA Comment: Small changes. Look good with two notes: members/members-update.pl still lists: Primary Mobile Phone (wrong case use too) I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone. Could be that it should move to primary phone if that is not filled or so? We probably need more community consensus for such a change. Could you raise or prove that consensus? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from M. de Rooy --- QA Comment: Tested. Works. Had some funny things when editing as new while changing frameworks, but apparently not related to your patch. Somewhat out of scope: But I am wondering if I save a new biblio with same title or ISBN and different itemtype (with item level biblio), if I would still like to have the warning? For the rest: Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377
M. de Rooy changed:
What|Removed |Added
Attachment #14557|0 |1
is obsolete||
--- Comment #4 from M. de Rooy ---
Created attachment 15798
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15798&action=edit
Bug 9377 - itemtype in duplicate biblio search
In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search
adds :
$query .= " and itemtype=$result->{itemtype}".
This should be only when itemtype is defined in biblio and not in items.
Test plan :
On a database with itemtype mapped in biblioitems and "item-level_itypes"
syspref on "biblio record" :
- Go to a biblio details page
- Click on "Edit as new (duplicate)"
- If ISBN is defined, remove it
- Click on save
=> a duplicate is detected
- Change biblio item type
- Click on save
=> no duplicate detected
- Set "item-level_itypes" syspref to "specific record"
- Come back to biblio details page
- Click on "Edit as new (duplicate)"
- If ISBN is defined, remove it
- Click on save
=> a duplicate is detected
- Change biblio item type
=> a duplicate is detected
Signed-off-by: Marc Veron
Followed test plan. Behaves as expected.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nuño López Ansótegui changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Nuño López Ansótegui changed: What|Removed |Added Attachment #15748|0 |1 is obsolete|| --- Comment #12 from Nuño López Ansótegui --- Created attachment 15797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15797&action=edit Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #3 from M. de Rooy --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #38 from M. de Rooy --- Created attachment 15796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15796&action=edit Bug 6813: Followup: FIX tabs and replace all occurrences of duplicate search - tabs was broken - 'duplicate search' have to be replaced with 'duplicate finder' - adds datatable instead of tablesorter Signed-off-by: Melia Meggs Incorporated Paul's POD fix for Suggestions.pm in here (marcelr 010313) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #37 from M. de Rooy --- Created attachment 15795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15795&action=edit Bug 6813: Followup: Fix HTML4 coding, new wording, warning on empty search terms The aim of this followup is to fix issues from Comment #17: - HTML4 encoding UCfirst fixed - Warning regardig large databases - Added javascript with warning if search terms are empty - Removed not used fields from search form - Changed wording from "Duplicate search" (Google: 15'000) to "Find duplicates" (Google: 576'000) To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Marc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #36 from M. de Rooy --- Created attachment 15794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15794&action=edit Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What|Removed |Added Attachment #12715|0 |1 is obsolete|| Attachment #12716|0 |1 is obsolete|| Attachment #13806|0 |1 is obsolete|| --- Comment #35 from M. de Rooy --- Created attachment 15793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15793&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #34 from M. de Rooy --- QA Comment: Amit or Savitra, Some comments have been given already. So I will not repeat them all. But I like the idea of your new tool! FindBiblios works with sql statements. That is a risk for performance. I think (like Paul) that this tool should not be in Acquisitions. Could you place it under .. Tools ? Please send a followup and I will continue on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What|Removed |Added Attachment #14009|0 |1 is obsolete|| --- Comment #33 from M. de Rooy --- Comment on attachment 14009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14009 Bug 6813 follow-up, fix POD Obsoleting this one too. Failed, will amend the last patch for this edit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What|Removed |Added Attachment #12714|0 |1 is obsolete|| --- Comment #32 from M. de Rooy --- Comment on attachment 12714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12714 [SIGNED-OFF] Bug 6813: Acquistions duplicate search across orders, suggestions and catalog Obsoleting the first patch for merge conflict. Have resolved it and will send new one after applying the rest with git-bz :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917
--- Comment #49 from Chris Cormack ---
(In reply to comment #48)
> (In reply to comment #47)
> > (In reply to comment #46)
> > > (In reply to comment #38)
> > > > Comment on attachment 15714 [details] [review] [review] [review]
> > > > [review]
> > > > [SIGNED_OFF] Bug 8917 : Script to log link clicks
> > > >
> > > > Review of attachment 15714 [details] [review] [review] [review]
> > > > [review]:
> > > > -
> > > >
> > > > ::: opac/tracklinks.pl
> > > > @@ +65,5 @@
> > > > > +print $cgi->redirect("/cgi-bin/koha/errors/404.pl");# escape
> > > > > early
> > > > > +exit;
> > > > > +}
> > > > > +
> > > > > +sub trackclick {
> > > >
> > > > Don't we want to have this routine into a new module (in order to
> > > > prevent
> > > > sql code into pl file)?
> > >
> > > Hi Chris,
> > > You didn't address this remark, isn't it relevant?
> >
> > I didn't think it was, no.
>
> So please set out your argument, mine is the coding guidelines :
> http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.
> pl_scripts
I no longer care, someone else can work on this
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ch...@bigballofwax.co.nz --- Comment #2 from Chris Cormack --- This shouldn't be needed Can you check your database structure, it should be `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, Which means MySQL will update it, can you do show create table biblio; select biblionumber,title,timestamp from biblio; +--+-+-+ | biblionumber | title | timestamp | +--+-+-+ |1 | chris | 2012-07-01 16:21:13 | |2 | chris 2 | 2012-06-11 23:14:39 | +--+-+-+ update biblio set title='test timestamp' where biblionumber=1; Query OK, 1 row affected (0.05 sec) Rows matched: 1 Changed: 1 Warnings: 0 mysql> select biblionumber,title,timestamp from biblio; +--++-+ | biblionumber | title | timestamp | +--++-+ |1 | test timestamp | 2013-03-01 22:59:09 | |2 | chris 2| 2012-06-11 23:14:39 | +--++-+ 2 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917
--- Comment #48 from Jonathan Druart ---
(In reply to comment #47)
> (In reply to comment #46)
> > (In reply to comment #38)
> > > Comment on attachment 15714 [details] [review] [review] [review]
> > > [SIGNED_OFF] Bug 8917 : Script to log link clicks
> > >
> > > Review of attachment 15714 [details] [review] [review] [review]:
> > > -
> > >
> > > ::: opac/tracklinks.pl
> > > @@ +65,5 @@
> > > > +print $cgi->redirect("/cgi-bin/koha/errors/404.pl");# escape
> > > > early
> > > > +exit;
> > > > +}
> > > > +
> > > > +sub trackclick {
> > >
> > > Don't we want to have this routine into a new module (in order to prevent
> > > sql code into pl file)?
> >
> > Hi Chris,
> > You didn't address this remark, isn't it relevant?
>
> I didn't think it was, no.
So please set out your argument, mine is the coding guidelines :
http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|paul.poul...@biblibre.com |m.de.r...@rijksmuseum.nl --- Comment #31 from M. de Rooy --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 M. de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #11 from Nuño López Ansótegui --- It's true, you are right...sorry, I fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917
--- Comment #47 from Chris Cormack ---
(In reply to comment #46)
> (In reply to comment #38)
> > Comment on attachment 15714 [details] [review] [review]
> > [SIGNED_OFF] Bug 8917 : Script to log link clicks
> >
> > Review of attachment 15714 [details] [review] [review]:
> > -
> >
> > ::: opac/tracklinks.pl
> > @@ +65,5 @@
> > > +print $cgi->redirect("/cgi-bin/koha/errors/404.pl");# escape
> > > early
> > > +exit;
> > > +}
> > > +
> > > +sub trackclick {
> >
> > Don't we want to have this routine into a new module (in order to prevent
> > sql code into pl file)?
>
> Hi Chris,
> You didn't address this remark, isn't it relevant?
I didn't think it was, no.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917
--- Comment #46 from Jonathan Druart ---
(In reply to comment #38)
> Comment on attachment 15714 [details] [review]
> [SIGNED_OFF] Bug 8917 : Script to log link clicks
>
> Review of attachment 15714 [details] [review]:
> -
>
> ::: opac/tracklinks.pl
> @@ +65,5 @@
> > +print $cgi->redirect("/cgi-bin/koha/errors/404.pl");# escape early
> > +exit;
> > +}
> > +
> > +sub trackclick {
>
> Don't we want to have this routine into a new module (in order to prevent
> sql code into pl file)?
Hi Chris,
You didn't address this remark, isn't it relevant?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from M. de Rooy --- QA Comment: This is a hard one. Also taking into account the comments of Liz and Jonathan. I do appreciate your finding a solution in this minefield :) When taking some distance from Koha and just looking at the code, the introduction of the reserve id parameter in ModReserve seems not to be a good idea. It is somewhat 'unusual' way of resolving a problem. (Please note that I understand that we are editing not-so-ideal code already..) It will not make the code more readable/maintainable(..) When going back to Koha, I also think that we should resolve the problem at another place. That is the checkin should not display two prompts (probably one adjusted prompt for this situation). When the book is checked in at the transfer branch, the transfer should be marked as arrived and at the same time the transit hold should become a waiting hold. Actually, AddReturn calls ModReserveStatus but it will update a book with priority 0 only for found="" and not for found=T. Could we resolve it there? About Liz' comment: If we want to know where the transfer was generated, we should probably add some additional field to branchtransfers. At this moment we just do not know how it was generated. So my (somewhat intuitive) recommendation would be not to push this patch in this state. I just 'arbitrarily' picked Failed QA for now. But feel free to put it in Discussion and raise a discussion on the dev list. I will send a short mail to other QA team members. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #10 from Jonathan Druart --- (In reply to comment #9) > Ok, but I check the existence of the variable in [% IF ( itemdata_datedue ) > %] > > I Would not checking the same variable two times? itemdata_datedue is true if at least one datedue is defined in the ITEM_RESULT array. It is not the same variable at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #9 from Nuño López Ansótegui --- (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > In which cases do you see warning messages? > > > > > > On opac-detail.pl, I just get some warnings about $ccode (Use of > > > uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl > > > line 534). > > > > I meant that I have written the code like the other tests, for example as > > the barcode code: > > > > [% IF ( itemdata_datedue ) %][% ITEM_RESULT.datedue | > > $KohaDates %][% END %] > > [% IF ( OPACShowBarcode ) %][% ITEM_RESULT.barcode > > %][% END %] > > > > if $ccode get a warning, must also fix it. > > Since I cannot reproduce, I cannot help you. > You can keep your code but if the error is caused by the KohaDates plugin > you have to check the existence of the variable before filtering it : > > [% IF ( itemdata_datedue ) %][% IF > ITEM_RESULT.datedue%][% ITEM_RESULT.datedue | $KohaDates %][% END %][% > END %] Ok, but I check the existence of the variable in [% IF ( itemdata_datedue ) %] I Would not checking the same variable two times? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > (In reply to comment #6) > > In which cases do you see warning messages? > > > > On opac-detail.pl, I just get some warnings about $ccode (Use of > > uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl > > line 534). > > I meant that I have written the code like the other tests, for example as > the barcode code: > > [% IF ( itemdata_datedue ) %][% ITEM_RESULT.datedue | > $KohaDates %][% END %] > [% IF ( OPACShowBarcode ) %][% ITEM_RESULT.barcode > %][% END %] > > if $ccode get a warning, must also fix it. Since I cannot reproduce, I cannot help you. You can keep your code but if the error is caused by the KohaDates plugin you have to check the existence of the variable before filtering it : [% IF ( itemdata_datedue ) %][% IF ITEM_RESULT.datedue%][% ITEM_RESULT.datedue | $KohaDates %][% END %][% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart changed: What|Removed |Added Attachment #15547|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 15792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15792&action=edit Bug 9043: Changes to the advanced search page New syspref: OpacAdvSearch. This syspref is multivalued and you can add or remove some elements on the adv search page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #14 from Jonathan Druart --- (In reply to comment #13) > Hi Jonathan, I like the idea. But there are couple of issues I would like to > raise > > 1) In the current state, the OpacAdvSearch syspref applies the same behavior > to Advanced search page with both Fewer and More options. This needs to be > rectified. Ok, I didn't understand what you want. New patch coming. > 2) I tried unselecting/disabling a previously selected/enabled option by > clicking on it, this doesn't seem to work. How does one unselect/disable one > of the options from the scroll-down menu? You have to press the ctrl key and click on the entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
