[Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18051|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18086action=edit [PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass Signed-off-by: Katrin Fischer katrin.fischer...@web.de XML changes only, passes all tests. Contains string changes, so should go into 3.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18047|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18087action=edit [PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the Form of release - visual projection, motion picture option list is correct, especially the value other film type - open the plugin for 116 field - check the Technique (prints) 2 option list is correct, especially the value lithography Signed-off-by: Owen Leonard oleon...@myacpl.org I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes tests and fixes an obvious problem in the HTML. I checked the po files - currently the strings appear as: other film type/option %s So in theory it's possible to translate them correctly even if the standard templates now are not correct. Probably has to wait for 3.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Passed QA |Signed Off CC||katrin.fisc...@bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9680] cart aligned right in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9680] cart aligned right in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18079|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18088 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18088action=edit [PASSED QA] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The send window - The download window - From a view of a List's contents trigger: - The send window - The download window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass Signed-off-by: Katrin Fischer katrin.fischer...@web.de Template and CSS changes only, but no string changes. Save for inclusion in 3.12. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18084|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18089action=edit [PASSED QA] Bug 10196 - items table partially hidden in marc view in ccsr In the CCSR theme's OPAC MARC view the table of items is truncated because the container div is styled with overflow:hidden. I think the complete display of information is more important than not seeing a horizontal scrollbar, so this patch removes the style. To test, apply the patch and clear your browser cache. View a MARC detail page for a title which has holdings and confirm that the entire table can be seen. Test other pages to make sure no unwanted layout changes have resulted. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com all tests pass Signed-off-by: Katrin Fischer katrin.fischer...@web.de Simple CSS change, no string changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18040|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18090 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18090action=edit [PASSED QA] Bug 10134 - set XSLT usage ON as default, for new Koha installs Currently, new installs are created with XSLT display set to off, but XSLT seems to be the preferred way to display records, so having the default be on instead seems to make sense. This patch will of course only affect new installs. To test: - Apply the patch - Run through the webinstaller on an empty database - Log in to the staff client and search for xslt in system preferences - Verify that XSLTDetailsDisplay, XSLTResultsDisplay, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are all set to default Signed-off-by: Owen Leonard oleon...@myacpl.org Passes test plan correctly. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Changes syspref.sql for new installations to use XSLT views by default. No changes to existing installations, no string changes. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9679] can't place hold from cart in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9679] can't place hold from cart in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18069|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18091 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18091action=edit [PASSED QA] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking place hold triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click place hold. The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All test passed http://bugs.koha-community.org/show_bug.cgi?id=9769 Signed-off-by: Katrin Fischer katrin.fischer...@web.de Confirmed patch fixes the problem described. All tests and QA script pass, JavaScript only change. No strings involved, save for inclusion in 3.12. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18076|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18092 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18092action=edit [PASSED QA] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the Edit/Delete links appear. - Click a row for an item which is held by another library. No links should appear. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All test pass Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. Changes to the templates include no string changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|master |3.14 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I second Chris' vote to hold this patch for 3.14 to not risk missing something, marking bug accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, your patch contains the po files, but changes to those files should be handled via Pootle. Can you please resubmit your patch without them? I am also not sure if old release notes should be included, as they are 'history'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7441] search results showing wrong branch?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|master |3.14 --- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, I had to rebase the first patch, because of a conflict in updatedatabase and found 1 problem: Third patch contains those lines: +[% USE Koha %] +[% USE KohaBranchName %] But fourth patch deletes the Koha TT plugin without removing them. I think as a result of that the QA script notes a problem with opac-results.tt: * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt FAIL forbidden patterns OK tt_validOK valid_template FAIL Koha: plugin not found Please fix and switch back to signed off if the only changes are the rebase and fixing the plugin problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7441] search results showing wrong branch?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18049|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18093 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18093action=edit [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard oleon...@myacpl.org I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Patch works as decribed. As this only adds a check for a superlibrarian it seems safe and should not interfere with normal staff accounts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Passed QA |Signed Off Patch complexity|Small patch |Trivial patch --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I will open another bug for some inconsistency I found testing this: You can now switch the library once you are logged in, but while the library pull down also shows on the login page, the selection there is not saved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10231] New: When logging in with database user library selection is not saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 Bug ID: 10231 Summary: When logging in with database user library selection is not saved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de CC: gmcha...@gmail.com To test: 1) Log into Koha with your database user, make sure you select a specific library from the pull down on the login page 2) Verify you are logged in correctly, but the top menu shows NO LIBRARY SET. We should either not show the pull down or make it work correctly. See also behaviour after applying patch 10054. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Note: This was tested with activated SingleBranchMode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I think maybe having this off by default would be safer? I wonder if the field is not empty, will the default overwrite what you have in there? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Testing this I was surprised to find the option on the upload page instead of on the page where I actually define the modifications. I tend to check all checkboxes and settings I made twice before I do a change like this, with the options being spread over 2 pages, I can't do that. I think the option should go on the second step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Thinking more about this, a possible enhancement would be to make visible which fields will be set to which default value. There is no way to tell now which changes will be done or not done when you check/uncheck the checkbox. I know that this is more complicated so it should go on a new bug as an enhancement request once have figured this out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ok, I think I need to take a break, because after some more testing I understand better. Ignore last 2 comments, I will try again: 1) Having the feature off by default might be better in my opinion, because it reduces the risk of unintended changes. 2) I can see that the default values for text fields show up in the form, which is good as it makes visible which changes will happen. But there is a bug here: If you use a default itemtype, the pull down will not be preselected. This seems to happen for all values with pull downs. 3) I'd still like to see the checkbox on the second page instead of the first, but it might not be as big as a problem as I initially thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #17879|0 |1 is obsolete|| Attachment #17940|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18094action=edit [PASSED QA] Bug 9533 - batch item modification should ignore defaults This patch makes the pre-population of the fields for the batch item editor with the default values from the default framework optional and off by default. Test Plan: 1) Apply patch 2) Add default values for cost and replacement cost to the default framework. 3) Browse to Tools / Batch item modification 4) Choose a file, or entire some barcodes in the text area 5) Ensure that the 'Populate fields with default values from default framework' is *not* checked 6) Click 'Continue' 7) Observe that the fields for cost and replacement cost are blank 8) Click the 'back' button on your browser 9) Check the checkbox to enable the default value 10) Click 'Continue' 11) Observe that the fields for cost and replacement cost now contain the default values you assigned them in the default MARC framework Signed-off-by: David Cook dc...@prosentient.com.au Signed-off-by: Katrin Fischer katrin.fischer...@web.de Switch works correctly, all tests and QA script pass. Note: there is a bug with default values for all non text input fields. Default values won't be applied for those fields as the pull downs are not preselected correctly with the default values defined in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18095action=edit [PASSED QA] Bug 9533: Use default values by default Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Simple template change checking the checkbox by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18095|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 18095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18095 [PASSED QA] Bug 9533: Use default values by default Obsoleting second patch, but also passing QA on it. The change is alright if we want the checkbox to be checked by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9679] can't place hold from cart in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This is a 3.10.x-only change, as this problem does not exist on 3.12 or 3.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Marcel, I am trying to figure out how this works and entered a http://... into my intranetstylesheet preference. I can see that it works for the staff pages, but the help files (http://localhost:8080/cgi-bin/koha/help.pl) still refer to staff-global.css. Can you take a look please? All 3 patches were applied and the databaes update left my http:// URL alone. titleOnline Help/title meta http-equiv=Content-Type content=text/html; charset=utf-8 / link rel=shortcut icon href=/intranet-tmpl/prog/en/includes/favicon.ico type=image/x-icon / link rel=stylesheet type=text/css href=/intranet-tmpl/lib/jquery/jquery-ui.css / link rel=stylesheet type=text/css media=print href=/intranet-tmpl/prog/en/css/print.css / link rel=stylesheet type=text/css href=/intranet-tmpl/prog/en/css/staff-global.css / !-- local colors -- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9680] cart aligned right in CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|koha.sek...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10232] New: Permission check for editing help files is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232
Bug ID: 10232
Summary: Permission check for editing help files is broken
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Authentication
Assignee: gmcha...@gmail.com
Reporter: katrin.fisc...@bsz-bw.de
CC: dpav...@rot13.org
To test:
- Try editing a help file as superlibrarian, confirm you get to the editor. You
might not be able to save your changes though, because of file permissions.
- Try editing a help file with any of the listed permissions from the
edithelp.pl file:
43 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
44 {
45 template_name = help/edithelp.tt,
46 query = $input,
47 type= intranet,
48 authnotrequired = 0,
49 flagsrequired = {
50 catalogue= 1,
51 circulate= 1,
52 parameters = 1,
53 borrowers= 1,
54 permissions = 1,
55 reserveforothers = 1,
56 borrow = 1,
57 reserveforself = 1,
58 editcatalogue= 1,
59 updatecharges= 1,
60 },
61 debug = 1,
62 }
63 );
Verify it doesn't work.
I think reserveforself doesn't exist in current Koha and the choice of
permissions seems a bit arbitrary.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #35 from Jared Camins-Esakov jcam...@cpbibliography.com --- I suspect this is going to break unit tests on jenkins, in which case I will be reverting it. This line: + isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an array' ); seems problematic. Perhaps you want to check that $#listorders 1, Mathieu? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #16539|0 |1 is obsolete|| Attachment #16540|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18096action=edit Bug 8840 - [SIGNED-OFF] ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Magnus Enger mag...@enger.priv.no Works as advertised, see Bugzilla for details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18097action=edit [PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false All dependencies installed! Reordered logic to accumulate MISSING_PATCHES variable and tweak condition to be certain it was not failing. Signed-off-by: Magnus Enger mag...@enger.priv.no Works as advertised, see Bugzilla for details. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18046|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18098action=edit [PASSED QA] Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. Change is logical, only homebranch should determine if the item can be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.12|3.14 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This influences quite a lot of system preferences - maybe this is better included in 3.14/3.12.1 with a bit more testing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10116] Subscription history notes should be TEXT not VARCHAR(150)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10116 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- *** This bug has been marked as a duplicate of bug 10215 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added CC||jcam...@cpbibliography.com --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- *** Bug 10116 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #17932|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18099action=edit [PASSED QA] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard oleon...@myacpl.org This revised patch works fine for me, thanks. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Verified following system preferences still work as expected: - COinSinOPACResults on/off - TagsEnabled, TagsShowOnList, TagsInputOnList on/off - OpacStarRatings Couldn't test Babeltheque functionality as this requires an account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, I am sorry, but this doesn't work for me. I created 3 different holds with 3 different pickup libraries away from my logged in library. I turned on independentbranches and like you described, suddenly all holds showed my current branch as pickup library. But after applying the patch and refreshing the page several times, this is still the case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 18041 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18041 [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Review of attachment 18041: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6739attachment=18041) - Hi Chris H. and Kyle, I have taken a look at those patches and found some problems, the most severe is in the database update (see splinter review comments below). Please fix and resubmit. And a little note for a possible enhancement: The new option doesn't show up on the patron categories summary table in administration. ::: installer/data/mysql/kohastructure.sql @@ +441,4 @@ `reservefee` decimal(28,6) default NULL, -- cost to place holds `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) + `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this categori can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BLockExpiredPAtronOpacACtions Tiny typo: categori ::: installer/data/mysql/updatedatabase.pl @@ +6845,5 @@ +NULL, +'YesNo' +) +); +$dbh-do(ALTER TABLE `categories` ADD COLUMN `BlockExpiredPatronOpacActions` TINYINT(1) DEFAULT 0 NOT NULL); The default value for new patron categories is -1 (use system preference), but for existing installations we create the column with default 0. I checked that the follow ups are not fixing this. Failing QA. Also: It would be a bit safer to make sure the column is added after category_type like in kohastructure.sql. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18100action=edit Bug 9452: C4::Letters not Plack-compatible Prior to this patch, at more-or-less random intervals pages working with notices will cease to function. To test: 1) Apply patch. 2) Try to edit some notices. 3) Trigger some notices. 4) If you were able to edit the notices and trigger the notices, sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- I do not have any technique for consistently reproducing these errors. 75% of the time notices are not generated and/or I am unable to save changes to notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10230] Match points do not work with authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18101action=edit Bug 10230: no need to use SimpleSearch for matching auths When introducing QueryParser, I introduced a check for QueryParser at too high a level, causing authority matching to try and use SimpleSearch for authorities prematurely, when SearchAuthorities should be handling it. This patch corrects the level of the check. This patch only moves three lines, but thanks to the change in if level, it adjusts the indentation quite a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10230] Match points do not work with authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18102 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18102action=edit Bug 10230: Don't limit valid matches to bibs The patch for bug 9523 added a JOIN to the biblio table when identifying the best match so that if a matched record had been deleted it would not hold up the import process. Unfortunately, this broke all authority matching, since of course authorities don't appear in the biblio table. This patch adds a join to auth_header as well, and decides which to check based on the record type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10230] Match points do not work with authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10230] Match points do not work with authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18103 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18103action=edit Bug 10230: show correct matching record The correct matching record was not always shown on the manage staged MARC page. This patch corrects the issue and provides the template with the appropriate ID for the matched record regardless what type of record it is. To test: 1) Create a matching record for authorities. For MARC21, the following is a good choice: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag:100 Subfields: a 2) Create a record that has the appropriate fields for being matched with that rule (if you don't already have one). 3) Save the authority record as MARC (Unicode/UTF-8). 4) Stage the file choosing your new matching rule. 5) Note that with these patches, you get a link to the existing authority and without them you could get any number of strange things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10094] koha-list should have an --disabled option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #17731|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18104 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18104action=edit [PASSED QA] Bug 10100: adds a class to OPAC news dates Adds a newsfooter class to allow CSS modification of the date appearing as a footer on each news. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Adds a class, checked po files to make sure change is string safe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10094] koha-list should have an --disabled option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Packaging manager has signed off - that's good enough for me :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #17846|0 |1 is obsolete|| --- Comment #2 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 18105 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18105action=edit Bug 10159 - koha-rebuild-zebra error handling This patch makes koha-rebuild-zebra: - Check for the existence of the instance - Handle arbitrary amount of instance parameters - Capture -a and -b (which made the script rebuild twice the chosen DB). It adds the extended version (--authorities and --biblios respectively) of the option switch. This makes the -a and -b switches work as only do authorities (or viceversa). They can be used concurrently, which is the default behaviour when no switch is provided. - Handle -v (and --verbose) as koha-rebuild-zebra options, to ease the use for non-techie users. - The rebuild_zebra.pl is wrapped inside an IF to return error values if we ever make rebuild_zebra.pl return error codes (this is pointed in the code). - Added -h/--help switches and an 'usage' output :-D Please provide patches for any wording issues, or contact me to fix it. To test: - Apply the patch and create your packages (or just use the script from your branch) - Run it in this scenarios / options - -h/--help to see the available option switches - Mix them with one or more instances, of which some could be fake - try -a/--authorities and -b/--biblios in all possible combinations - try -v/--verbose works Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Robin Sheat ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10157] koha-email-enable error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #17842|0 |1 is obsolete|| --- Comment #2 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 18106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18106action=edit Bug 10157 - koha-email-enable error handling koha-email-enable now - Checks the instance exists. - Checks if email is already enabled. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Robin Sheat ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10146] koha-stop-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #17843|0 |1 is obsolete|| --- Comment #5 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 18107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18107action=edit Bug 10146 - koha-stop-zebra error handling koha-stop-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Edit: Corrected the die message Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Robin Sheat ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10157] koha-email-enable error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10146] koha-stop-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10157] koha-email-enable error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10146] koha-stop-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #2 from Liz Rea l...@catalyst.net.nz --- I kind of disagree with this - I think that one cannot expect this to work when logging in as the DB user - maybe all we need to do is add a notice to the yellow box that the superuser has NO LIBRARY SET no matter what. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10233] New: Toolbar background missing from staff client catalogue page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Bug ID: 10233 Summary: Toolbar background missing from staff client catalogue page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au Currently, the toolbar containing the buttons New Record and Z39.50 search is missing a background. Before we moved from YUI to Bootstrap, there was an extra div#toolbar wrapping the button group, but that appears to have vanished (and with it the background). We might be able to just change the current id from newmenuc to toolbar, since the javascript that touched newmenuc seems to have been removed from the page as well (since it cleared the newmenuc div so that the plain html could be replaced with yui buttons). However, I'm loathe to do that without making sure that no existing functionality would break from doing that. It might be an idea to just wrap that div with a div#toolbar again to get that background back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com --- I would prefer not to revert this if I could get a follow-up fixing the broken test, which is a problem only in the unit test and not in the code itself. If someone can provide a follow-up fixing the unit test by May 16, I will not revert these patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10234] New: MySQL error when adding entry to z39.50servers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10234 Bug ID: 10234 Summary: MySQL error when adding entry to z39.50servers Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au Recently, someone reported getting an error when trying to add an entry into z39.50servers (http://irc.koha-community.org/koha/2013-05-09#i_1250075). Here is a snippet of their log: log: z3950servers.pl: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /usr/share/koha/intranet/cgi-bin/admin/z3950servers.pl line 133 I believe the problem is the result of using a strict SQL mode: Strict mode controls how MySQL handles input values that are invalid or missing. A value can be invalid for several reasons. For example, it might have the wrong data type for the column, or it might be out of range. A value is missing when a new row to be inserted does not contain a value for a non-NULL column that has no explicit DEFAULT clause in its definition. (For a NULL column, NULL is inserted if the value is missing.) (http://dev.mysql.com/doc/refman/5.5/en/server-sql-mode.html [You can check different versions, they all seem to have the same behaviour from what I can tell.]) * In this case, the field 'description' has no default value but is also NOT NULL field. If your SQL mode isn't strict, you'll get a warning but the insert will succeed (using a blank value rather than a null value). However, it if it strict, you'll get an error and a rolled back/failed insert. * If we observe other fields in kohastructure.sql that are NOT NULL and don't have a real default value, we typically use a default of ''. This will stop the warnings and the errors. Admittedly, the field description is documented as not being used, so perhaps the best thing to do is remove the field or perhaps make it NULL, but...using a default of '', will be the least potentially hazardous as it won't really change anything. It'll just enforce what we know as a default behaviour of using '' when the default value is missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #7 from David Cook dc...@prosentient.com.au --- Created attachment 18108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18108action=edit Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching This patch adds the recordtype column to the z3950servers table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is biblio, since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10235] New: Koha's syspref search fails to find 'local' sysprefs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Bug ID: 10235 Summary: Koha's syspref search fails to find 'local' sysprefs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com CC: gmcha...@gmail.com if you add a new syspref to Koha, then attempt to search for it - the 'syspref search' feature fails to find it :/ this ticket will attempt to fix this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
