[Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415
--- Comment #3 from Chris Cormack ---
Comment on attachment 23904
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23904
Implements syspref for SCO receipt printing
Review of attachment 23904:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11415&attachment=23904)
-
::: installer/data/mysql/updatedatabase.pl
@@ +7886,5 @@
> }
>
> +$DBversion = "3.15.00.XXX";
> +if(CheckVersion($DBversion)) {
> + $dbh->do("INSERT INTO systempreferences
> (variable,value,options,explanation,type) VALUES('SelfCheckReceiptPrompt',
> '0', 'NULL', 'If ON, print receipt dialog pops up when self checkout is
> finished.', 'YesNo');");
This all looks good, and works well. Our rule of thumb though is to not change
behaviour. This syspref is set off, so once you upgrade you will no longer get
the prompt showing up.
I think it should go into the update as on, so the behaviour doesn't change on
upgrade, people can switch it off.
It can go in off for new installs though.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What|Removed |Added Attachment #23916|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 23923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23923&action=edit Bug 11473 - Remove boilerplate in log viewer template This patch eliminates unnecessary conditions and boilerplate. _TEST PLAN_ Apply the patch. 1) Try viewing logs for circulation, patrons, fines, cataloguines, serials, authorities, etc. 2) Note that everything should look exactly the same as before, with one exception: FINES 3) Fines will now show "member X" for the user associated with the fine. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What|Removed |Added Attachment #23915|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 23922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23922&action=edit Bug 11473 - Fix log viewer template conditions This patch adds the 'loopro' key to the 'module' value, so that conditions are actually triggered in the template logic. (Note: loopro.CIRCULATION is valid, but I changed it for the sake of consistency across the different conditions.) This patch also adds substr checks to the 'info' column when using the cataloguing module. This will check for 'item' and 'biblio', so that the appropriate label qualifer can be shown in the log viewer. If either term is absent, the unqualified number will be shown instead (this will be the majority of action logs at this point). _TEST PLAN_ Before applying: 1) Access log viewer from Tools (or wherever really) 2) Look up logs for circulation, patrons, cataloguing, serial, authorities, etc. 3) Note that the "Object" will always just be a number without qualification. After applying the patch: 1) Look at those same logs 2) Note that the object number for borrowers will usually be prefaced by 'member' (notwithstanding FINES which aren't taken into account in this template yet); new bibs and new items should say 'Item X' or 'Biblio X'. Serials should have a link. Authorities should have a link and an 'auth' preface. Signed-off-by: Chris Cormack Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What|Removed |Added Attachment #23917|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 23924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23924&action=edit Bug 11473 - Improve wording in log viewer template This patch capitalizes 'member' and 'biblio' as object labels in the log viewer. It also adds a "Subscription" label, and changes "auth" to "Authority". _TEST PLAN_ Before applying patch: 1) View logs for patrons, new biblio, serials, and authorities. Apply the patch: 1) Notice the capitalization and new/modified labels. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What|Removed |Added Attachment #23918|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 23925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23925&action=edit Bug 11473 - add 'biblio' and 'item' to cataloguing logging info This patch adds the words 'biblio' and 'item' to the 'info' of the cataloguing logs which were missing them (such as biblio delete, biblio mod, item mod, upload cover image). This patch also adds 'authority' for authority mod. _TEST PLAN_ Before applying: 1) Create/view mods for items, biblios, and authorities. 2) Create/view biblio deletion 3) Create/view upload cover image log 4) Note that none of these contain the words 'biblio','item',or 'authority' in their "Info" columns. Apply patch. 5) Repeat steps 1-3 6) Note that the new logs contain 'biblio','item', and 'authority' in their "Info" column, while the past ones don't. 7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item' appear in their "Object" column for the new logs Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Chris Cormack changed: What|Removed |Added Attachment #23919|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 23926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23926&action=edit Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #17 from Julian Maurice --- I was not able to reproduce the problem, but I suspect that the session is not properly deleted when it should. The following patch ensure that by flushing session after each call to $session->delete(). I hope this will fix the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #18 from Julian Maurice --- Created attachment 23927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23927&action=edit Bug 10952: Always flush session after deletion This is recommended in CGI::Session documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What|Removed |Added Attachment #22135|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize --- Created attachment 23928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23928&action=edit [PASSED QA] Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Also provide command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain "experimental" so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it checks for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Edit: fixed koha-create to call the koha-indexer script instead, and added -q to make koha-inxeder quiet (useful for the init script). Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #42 from Martin Renvoize --- All works as expected, no regressions created. I didn't get it fully working with the new daemon mode rebuild_zebra.pl, however I don't think that in itself should fail the patch. The scaffolding to add support for it is all there, but koha-indexer may need some re-factoring to support the different switches that rebuild_zebra contains compared to Tamils indexer. (I'd actually rpefer to see rebuild_zebra become close to Tamils indexer personally). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 --- Comment #7 from Katrin Fischer --- Thanks Galen :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #10 from Jonathan Druart --- > This patch is an improvement, but there is still more work to do. > > - Filters are not cumulative, but when another filter is selected > the first filter is not reset. > - It's not possible to combine > 2 or more filters. Will be possible with bug 10855 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11478] New: Remove experimental given/when from Koha::SimpleMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Bug ID: 11478 Summary: Remove experimental given/when from Koha::SimpleMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org As of perl 5.18 the given when keywords are marked as experimental and produce compile time errors. Avoid the unnecessary error by reverting to an if/else -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11478] Remove experimental given/when from Koha::SimpleMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell --- Created attachment 23929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23929&action=edit Proposed Patch With patch applied module will not issue errors because of use of experimental features in testsuite with perl >= 5.18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11479] New: Remove experimental given/when from C4::MarcModificationTemplates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Bug ID: 11479 Summary: Remove experimental given/when from C4::MarcModificationTemplates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Compile time warnings are issued by perl 5.18 and greater over use of experimental keywords given and when as behaviour may change in next release. Replace usage of these constructs with core syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336
--- Comment #31 from Jonathan Druart ---
Galen,
commit 543e1dc6731d4a26b777223920bfe4037e7546dd introduces a call to a
nonexistent routine:
=head2 ModReserve
@@ -1184,7 +1181,7 @@ sub ModReserveFill {
# now fix the priority on the others (if the priority wasn't
# already sorted!)
unless ( $priority == 0 ) {
-_FixPriority({ reserve_id => $reserve_id });
+FixPriority({ reserve_id => $reserve_id });
}
}
The FixPriority routine does not exist.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell --- Created attachment 23930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23930&action=edit Proposed patch With patch applied test suite no longer reports 'experimental' warnings from this module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #22685|0 |1 is obsolete|| --- Comment #57 from M. de Rooy --- Created attachment 23931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23931&action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber Description: GetReservesFromItemnumber also returns waiting date. Simplifies some code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788
M. de Rooy changed:
What|Removed |Added
Attachment #22686|0 |1
is obsolete||
--- Comment #58 from M. de Rooy ---
Created attachment 23932
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23932&action=edit
Bug 9788: Followup removing the alldates parameter
Before bug 9788 the alldates parameter of GetReservesFromItemnumber was
actually not used in the codebase.
The first patch of bug 9788 did change that and passed true by default.
But a closer look revealed that we do not really need it.
The parameter is removed by this patch; the SQL statement is slightly
adjusted: if reservedate<=now or a waitingdate is filled for the
requested itemnumber, GetReservesFromItemnumber will return the reserve.
This includes so-called future waits: a future hold that has been confirmed
ahead of time with pref ConfirmFutureHolds > 0 days.
Note that future item-level holds are not really interesting to return; this
just corresponds to original behavior. Future next-available holds are not
in view at all; they do not contain an item number.
Test plan:
Actually, the test plan of the first patch is valid. But for completeness I
repeat it here:
[1] Enable future holds and set ConfirmFutureHolds to 2 days.
[2] Place a future next-available hold for 2 days ahead.
[3] Check item status on catalogue detail. Available? That is fine.
[4] Confirm the future hold by checking it in. ('future wait')
[5] Look at item status again on catalogue detail. Must be Waiting now.
[6] Switch to OPAC and login as another opac user. Goto Place a hold.
[7] Check item status with item level hold info. Is it waiting?
[8] Try to place hold in staff, check item level status again. Waiting?
[9] Make a transfer for the item. Switch branch. Check hold status on
Transfers to receive.
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #22687|0 |1 is obsolete|| --- Comment #59 from M. de Rooy --- Created attachment 23933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23933&action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment from the Bugzilla report: Looking bit longer at this code, it is kind of strange to find it there in the first place. Adding maxpickupdelay in Letters.pm should not be there, but it is.. Also this date is not used normally in the default HOLD Available for Pickup notice (that we are generating in this case). And if it would be undef, the expiration date should imo be empty instead of today+0. (before adding maxreservespickupdelay, you should test the allowexpire pref first) So it is an (invisible) bug on its own. Test plan: See former patch. Kyle just discovered this bug, apparently by deleting the maxpickupdelay pref.. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #22693|0 |1 is obsolete|| --- Comment #61 from M. de Rooy --- Created attachment 23935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23935&action=edit Bug 9788: QA followup 1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS date). 2/ The date formatting should be done in the template (using the TT plugin). Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #22688|0 |1 is obsolete|| --- Comment #60 from M. de Rooy --- Created attachment 23934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23934&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #62 from M. de Rooy --- One of the patches needed a rebase for changes in Reserves.t. Galen: This patch waits for some months already in PQA and was written long before that. Could you explain why this patch cannot be pushed? What should be improved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion CC||katrin.fisc...@bsz-bw.de --- Comment #34 from Katrin Fischer --- I have taken a longer look at this and have been trying to make up my mind. I also looked at the code and did some testing. - I agree that adding one more place that has to be taken into account when trying to anonymize the reading history seems problematic. We already have the information in statistics, action_logs and old_issues. - Choosing to build this on the existing anonymizing scripts would give us more flexibility in the future. Like Galen suggested, it would be possible to keep the "last n borrowers". - There is currently no automatic way to delete this information from items/deleteditems once you choose to deactivate the feature. This worries me a bit. Some general thoughts: When we discussed this kind of problem at work, there was a point made that the data is not useful after a certain amount of time. Can you blame a borrower for any damage you find after accepting the item at the circulation desk or reshelving it after a selfcheck return? As we are only allowed to keep data that is actually needed, it would be good if there was an option to delete after x days. About the code: 1) Database update needs to be '15' and contain the bug number. 2) Diacritics in the card number on the items tab get mangled. 3) I think the syspref description could be improved a bit. I didn't understand at first what was meant by "This setting is independent of opacreadinghistory/AnonymousPatron". I think something like "the data will be stored independent on your settings for..." might be a bit more clear and also it might be good to warn that the data will be kept for older items/issues when turning it off again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #23934|0 |1 is obsolete|| --- Comment #63 from M. de Rooy --- Created attachment 23936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23936&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #23643|0 |1 is obsolete|| Attachment #23644|0 |1 is obsolete|| Attachment #23645|0 |1 is obsolete|| Attachment #23646|0 |1 is obsolete|| Attachment #23647|0 |1 is obsolete|| Attachment #23648|0 |1 is obsolete|| Attachment #23649|0 |1 is obsolete|| Attachment #23650|0 |1 is obsolete|| Attachment #23651|0 |1 is obsolete|| Attachment #23652|0 |1 is obsolete|| Attachment #23653|0 |1 is obsolete|| Attachment #23654|0 |1 is obsolete|| Attachment #23655|0 |1 is obsolete|| Attachment #23656|0 |1 is obsolete|| Attachment #23657|0 |1 is obsolete|| --- Comment #116 from Kyle M Hall --- Created attachment 23937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23937&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #117 from Kyle M Hall --- Created attachment 23938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23938&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #119 from Kyle M Hall --- Created attachment 23940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23940&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #121 from Kyle M Hall --- Created attachment 23942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23942&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #118 from Kyle M Hall --- Created attachment 23939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23939&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #122 from Kyle M Hall --- Created attachment 23943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23943&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #120 from Kyle M Hall --- Created attachment 23941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23941&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #130 from Kyle M Hall --- Created attachment 23951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23951&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #128 from Kyle M Hall --- Created attachment 23949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23949&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|String patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #127 from Kyle M Hall --- Created attachment 23948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23948&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #124 from Kyle M Hall --- Created attachment 23945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23945&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #126 from Kyle M Hall --- Created attachment 23947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23947&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #123 from Kyle M Hall --- Created attachment 23944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23944&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #129 from Kyle M Hall --- Created attachment 23950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23950&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #125 from Kyle M Hall --- Created attachment 23946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23946&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi changed: What|Removed |Added Attachment #23872|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 23952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23952&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #131 from Kyle M Hall --- This new patch set fixes the SIP2 issue. (In reply to Larry Baerveldt from comment #115) > Warning, this code seems to break SIP functionality. C4/ILS.pm is looking > for C4/Accounts.pm, but this update removes it. > > Test: > cd C4/SIP > perl -c ILS.pm > > Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone > /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 > /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 > /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23. > > Please do not signoff until SIP functionality has been restored. > > - Larry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Attachment #23641|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 23953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23953&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 23954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23954&action=edit Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126
--- Comment #8 from Katrin Fischer ---
Comment on attachment 22784
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22784
Bug 11126 - Make the holds system optionally give precedence to local holds
Review of attachment 22784:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11126&attachment=22784)
-
Ok, starting with a code review :)
Looks good so far:
- system preferences are added correctly
- new feature is off by default
- unit tests are provided
Only one small issue with one of the comments:
::: C4/Reserves.pm
@@ +915,5 @@
> return ( "Waiting", $res, \@reserves ); # Found it
> } else {
> +# Lazy fetch for borrower and item. We only need to know
> about the patron and item
> +# each and every time if we are using LocalHoldsPriority.
> This is a great place to
> +# leverage the inherent lazy fetching of DBIx::Class.
I think DBIx::Class is currently not yet used here, so the comment could be
fixed in a follow up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #9 from Katrin Fischer --- Coninuing testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 --- Hi Mathieu, I'm not sure that this choice (including or excl) have to be made in the order. In the actual functioning, it's in the vendor page that you can choose if list price or actual cost are with or without tax. It can be extended to remplacement price or budgeted price. ARe tou sure that a vendor have different politics of prices (including tax or not) ? Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #52 from Jonathan Druart --- Last patches fix conflicts with commit b753678c3dff4e0fd2fde008b3c43f0796fcfb05 Bug 11208: regression test for failing SMS messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #49 from Jonathan Druart --- Created attachment 23958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23958&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #48 from Jonathan Druart --- Created attachment 23957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23957&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #51 from Jonathan Druart --- Created attachment 23960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23960&action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10845] Multi transport types for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart --- Patches apply cleanly with patches from bug 9016 applied. I rebased them (conflicts in a UT file). Could you retry please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2327] Performing a z39.50 search on an ISBN causes Koha to throw an error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2327 Chris Nighswonger changed: What|Removed |Added Status|CLOSED |REOPENED Resolution|WORKSFORME |--- --- Comment #2 from Chris Nighswonger --- Be sure to change the status of a bug which has been closed to reopened if you have a case where the bug manifests. Also, please include exact details on how to reproduce the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What|Removed |Added Attachment #23289|0 |1 is obsolete|| Attachment #23290|0 |1 is obsolete|| Attachment #23291|0 |1 is obsolete|| Attachment #23292|0 |1 is obsolete|| Attachment #23293|0 |1 is obsolete|| Attachment #23562|0 |1 is obsolete|| --- Comment #46 from Jonathan Druart --- Created attachment 23955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23955&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #47 from Jonathan Druart --- Created attachment 23956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23956&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #50 from Jonathan Druart --- Created attachment 23959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23959&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Attachment #23602|0 |1 is obsolete|| --- Comment #98 from Jonathan Druart --- Created attachment 23961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23961&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Attachment #23775|0 |1 is obsolete|| --- Comment #99 from Jonathan Druart --- Created attachment 23962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23962&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Attachment #23774|0 |1 is obsolete|| --- Comment #100 from Jonathan Druart --- Created attachment 23963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23963&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #102 from Jonathan Druart ---
(In reply to Paola Rossi from comment #97)
> Search) The form in the left column of the page keeps the current search
> values only for non-additional fields. Every time the user selects "Search",
> the search values currently chosen for the additional searchable fields are
> lost or ruined.
> In case of category additional fields, the current search values are lost,
> reset to "ALL" every time the user selects "Search".
> In case of marc additional fields, the current search values are set to a
> Hash value every time the user selects "Search".
>
> So I pass the patch to "Failed QA" status.
Arg, stupid mistake, sorry.
- [% IF av.authorised_value ==
additional_field_filters.${field.name} %]
+ [% IF av.authorised_value ==
additional_field_filters.${field.name}.value %]
This should be fixed now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11145] creating a guided report in non-english language fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145
--- Comment #8 from michel ---
Here are the steps to get the error :
From the "Plus" menu, choose "Bilans et statistiques"
Then choose "assistant de rapports", then "construire nouveau".
Etape 1/6 : choose "Circulation" then "suivant"
Etape 2/6 : choose "Tabulaire" then "suivant"
and here i get "software error..."
Using the german language works fine.
Using koha 3.14 in french also produces the error.
On the other hand, if i try to generate a SQL report nothing happens.
Steps :
From the "Assistant de rapports" page, click "créer à partir de SQL".
Fill in "nom de rapport" and "notes" with "testFR"
Leave "type" as "tabulaire"
Paste a sql report (i pasted the report previously generated with the german
interface :
SELECT borrowers.borrowernumber,biblioitems.biblioitemnumber FROM borrowers
LEFT JOIN statistics on (statistics.borrowernumber=borrowers.borrowernumber)
LEFT JOIN items on (items.itemnumber = statistics.itemnumber) LEFT JOIN
biblioitems on (biblioitems.biblioitemnumber = items.biblioitemnumber)
)
Click "enregistrer rapport"
You get the message "votre rapport a été sauvegardé" ("your report was saved").
Click "rapports sauvegardés"
-->> you get the table with the saved reports, but the report you have just
created does not appear.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #28 from Kyle M Hall --- This problem is actually an issue with Koha's transfer implementation, and is not directly related to this feature. (In reply to Olli-Antti Kivilahti from comment #26) > Rotating collections test case. > > In "Tools" -> "Rotating Collections" -> "Add/Remove items": > When adding item barcodes to the collection, the input field > > should become active > automatically so it is easy to add multiple barcodes rapidly without > touching the > mouse or keyboard. > Enter-press is dealt by the barcode reader so automatic form submittal > should be handled > by the barcode reader. > > In "Rotating collections" -> "Transfer Collection": > When the collection is initially transferred, items are set to trasfer > correctly. > When the collection is transferred while items are still being transferred, > the transfer > destination library doesn't change from the original one. > The holding library changes for all items in the collection to the > destination library on > retransfers as well. > This is tricky if a user accidentally places the wrong destination. > When I try to checkin these items to their new retransfer location, I get > the following messages: > -"This item is part of a rotating collection and needs to be transferred to > " > -"Please return Valkoinen ihmissyöjä / to " > -"Print slip or Cancel transfer" > > When I checkin a Item to a arbitrary branch, I get the following messages: > "This item is part of a rotating collection and needs to be transferred to > " > "Please return Valkoinen ihmissyöjä / to " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #29 from Kyle M Hall --- While I agree that we should try to add unit tests, these patches do not add any new perl subroutines. There are many existing modules that do not have unit tests. > Also unit tests are required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Attachment #23601|0 |1 is obsolete|| --- Comment #101 from Jonathan Druart --- Created attachment 23964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23964&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #6 from Jonathan Druart --- Christopher, The patch is consistent with the test plan: you are allow to modify XXX items and to display XXX items on deletion. It is the same behavior as before the patch. But I agree with you, it is not consistent with the syspref description (the description says: number of items to process). I don't have a quick and small patch to provide. What I know it is that the limit is hardcoded and it is not possible to modify more than 1000 items in a batch, which is a real limitation for some libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #39 from Galen Charlton --- Pushed to master, along with a follow-up that removes a redundant check on singleBranchMode. Thanks, Kyle! This patch does not update the XSLT for the Bootstrap theme, but I think that can be relegated to bug 11310. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Attachment #21008|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 23966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23966&action=edit Bug 8836 - Resurrect Rotating Collections Signed-off-by: jmbroust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Attachment #21010|0 |1 is obsolete|| --- Comment #32 from Kyle M Hall --- Created attachment 23968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23968&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Attachment #23969|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall --- Created attachment 23970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23970&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin * Fix bad query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #35 from Kyle M Hall --- Created attachment 23971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23971&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Attachment #21011|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 23969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23969&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What|Removed |Added Attachment #21009|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall --- Created attachment 23967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23967&action=edit Bug 8836 - Resurrect Rotating Collections - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #6 from mathieu saby --- (In reply to Koha Team Lyon 3 from comment #5) > Hi Mathieu, > I'm not sure that this choice (including or excl) have to be made in the > order. In the actual functioning, it's in the vendor page that you can > choose if list price or actual cost are with or without tax. It can be > extended to remplacement price or budgeted price. ARe tou sure that a vendor > have different politics of prices (including tax or not) ? > Sonia This patch does not add a new choice on order page, it only displays the information (as defined on the vendor page, like before). I think it can be useful for librarians who are only creating orders (so they don't need to check the vendor's page). Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What|Removed |Added Attachment #23711|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 23965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23965&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > I like this idea, but I think we want to display the time in some cases - > like for the due date in case of a hourly loan. Yes, you are right. The last patch takes the 2 formats into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #1 from Galen Charlton --- Created attachment 23972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23972&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #2 from Galen Charlton --- I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them. Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|ch...@bigballofwax.co.nz|colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell --- Created attachment 23973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23973&action=edit Proposed Patch Without this patch the test script is run with perl 5.18 will fail on 0 to 3 tests. (0 is a hard one to spot!) differing on every run. With this patch the results will be consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11481] New: new reservation syspref HoldOnlyWhenAllItemsOnLoan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Bug ID: 11481 Summary: new reservation syspref HoldOnlyWhenAllItemsOnLoan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org This new syspref sets the following behavior about reserves : When enabled, placing hold is possible only if all the items potentially holdable of a record are on loan. By "potentially holdable", we mean these which can be reserved according to circulation rules and have neither notforloan, withdrawn, lost, nor damaged status. Test Plan : 1) Enable RequestOnOpac and HoldOnlyWhenAllItemsOnLoan sysprefs 2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 3) Go to Administration/Circulation and fine rules. 4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column For a beginning , you can set only one rule with itemtype as All or several rules with different item type. 5) In the pro interface, choose a record with some items : you can choose a notforloan status for one, set an itemtype with a circ rule without holds allowed for another etc. 6) Check out on your count as much items of this record as it's possible. Do not forget to change branch to checkout the items from their homebranch. 7) go to opac and search for the detailed record 8) You do not see the Place hold button yet : you must first authenticate yourself as patron1 to make it appear. Then you can pursue the Placing hold process as usual. 9) reconnect as admin and go to pro interface , search for the detailed record 10) click the Holds tab and enter patron1 in text box 11) the usual form appears : you can choose there the pickup location and select a specific item in the items table. 12) Now, check in one of the items and go back to opac detailed record 13) Even if you are already authentified (as patron1), the "Place hold" icon is no more visible (hold is no more possible) 14) reconnect as admin and go back in the pro interface to the detailed record 15) Enter patron1 again in patron textbox : the "Cannot place hold message" displayed with the following explanation : "All reservable items of the record must be on loan" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11482] New: new reservation syspref PickupHoldOnlyFromItemBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Bug ID: 11482 Summary: new reservation syspref PickupHoldOnlyFromItemBranches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org warning : even if this patch and Bug 11481 can work separately it's necessary to first install Bug 11481 in order to avoid conflict and applying patch issues. The use of this new syspref assumes that other sysprefs OPACAllowUserToChooseBranch and canreservefromotherbranches are set on. it introduces the following behavior about reserves : You can't choose whatever branch as your pickup location. It must be a holding branch of an item. Either you don't mind picking the item at one branch or another and you ask for the very first available item or you select a specific branch and you will get the first checked in item in it. Multiholds is not possible from the pro interface (Place hold button is hidden in the results list). In the hold form the pickup list display only the branch(es) where the items are from. If a branch has no circulation rule allowing holds for its documents, it does not appear in the list. Test plan : 1) Enable RequestOnOpac OPACAllowUserToChooseBranch canreservefromotherbranches and PickupHoldOnlyFromItemBranches syspref 2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 3) Go to Administration/Circulation and fine rules 4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column You can set only one rule for a beginning with itemtype as All or several rules with different item type. 5) In the pro interface, choose a record with some items of different branches. 6) check out some items. do not forget to checkout items on their very homebranch 7) go to opac and search for the detailed record 8) Place a hold and authenticate as patron1. In the pickup list, you must see as options, only the branches of the items. You can choose either the first available item from all these branches or first from a specific one of them. try 'first available'. 9) Go to patron1 user file and click the tab Holds : the hold had been recorded. Pickup location is 'Whatever location from the first available'. 10) reconnect as admin and check in one of the items, a message box appears : confirm the hold. 11) Reconnect as Patron1, go back to the user file and check that the pickup location zone now displays the branch of the returned item. cancel the hold 12) redo a test from stage 6 selecting a specific branch in stage 8 13) go to pro interface to the detailed record, click the Holds tab and enter patron1 in text box 14) the holds form appears. The pickup location displays only the branches of items. Select an option and confirm the hold. 15) the holds table now display a line for the new recorded holds with patron1 name. Check that pickup location list is still restricted to item branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11480] New: Tests in Output_JSON.t make invalid assumptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Bug ID: 11480 Summary: Tests in Output_JSON.t make invalid assumptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: colin.campb...@ptfs-europe.com QA Contact: gmcha...@gmail.com Output_JSON.t fails on current perl release. Tests in Output_JSON.t assume that items in the generated json string will be in a consistent order. Internally, though, they are held in a hash, an unordered container. In perl versions 5.18 and greater the overhaul of of hashing ensures that hash elements are returned in an unpredictable sequence, (which was previously the theory). As a result the tests checking the output should be rewitten not to make assumptions about the order of elements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@univ-lyon3.fr Assignee|oleon...@myacpl.org |k...@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 23975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23975&action=edit Bug-11482 PickupHoldOnlyFromItemBranches new syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #36 from Kyle M Hall --- Created attachment 23976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23976&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued and waiting items Items in a rotating collection are automatcially transferred when a collection is transferred. This is a problem for currently checked out items and items on hold marked as "Waiting". This patch resolves this issue by skipping the transfer for those items. When the items are then returned, the librarian will be alerted to transfer the item to the library currently holding that rotating collection. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Hi Jonathan, I retested this and think I spotted a problem: > > Order: 2 orders > Cancel one order, delete bibliographic record > Item cound is correct, but biblio count doesn't show the cancelled biblio. Since the aqorders.biblionumber is set to null on deleting a biblio I don't know how to get the correct count. I could do something like: COUNT(DISTINCT(COALESCE(aqorders.biblionumber, timestamp))) AS total_biblios in order to get the total number of biblio for a basket. But if a same biblio is ordered in several orders, the value will be wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@univ-lyon3.fr Assignee|oleon...@myacpl.org |k...@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 23974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23974&action=edit Bug-11481-HoldOnlyWhenAllItemsOnLoan-new-syspref.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
