[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #25086|0 |1 is obsolete|| --- Comment #4 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 25413 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25413action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #5 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 25414 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25414action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #6 from Julian Maurice julian.maur...@biblibre.com --- I split patch in two parts: 1) whitespace fixes 2) real changes I'll try to write unit tests asap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25124|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25416 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25416action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25125|0 |1 is obsolete|| --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25417 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25417action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25123|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25415 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25415action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25129|0 |1 is obsolete|| --- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25421 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25421action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25127|0 |1 is obsolete|| --- Comment #77 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25419 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25419action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25128|0 |1 is obsolete|| --- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25420 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25420action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25126|0 |1 is obsolete|| --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25418 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25418action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25130|0 |1 is obsolete|| --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25422 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25422action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11458] Confusing description for syspref gist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11458 --- Comment #4 from Jacek Ablewicz a...@biblos.pk.edu.pl --- (In reply to mathieu saby from comment #3) Why not, but I assure you that in France, every library really need to have several gst rates, because tax rate for books and other documents (serials, dvds...) are not the same. We have just ;) 4 tax rates for different kinds of materials: 0% 5% (used to be 0%) 8% 23% (used to be 22%). This is what happens when our beloved, democratically selected leaders have way to many field days revising tax code. (see bug 10613, bug 11681, bug 10461, bug 11062, bug 7686, bug 7495, bug 3980, bug 2865 ) Not to mention bug 11733, bug 11680, bug 11520 and maybe bug 11755 too.. I say we take off and nuke the entire site from orbit. It's the only way to be sure ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11749] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11749 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11749] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11749 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25411|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25423 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25423action=edit Bug 11749 - Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client The jQuery plugin jquery.hoverIntent.minified.js is used only in the OPAC, not the staff client. This patch removes it from the staff client. To test, apply the patch and search for instances of hoverIntent. Only references in OPAC templates should be returned. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11766] Use validation plugin when creating new authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25409|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25424 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25424action=edit r Attachment to Bug 11766 - Use validation plugin when creating new authority type Bug 11766 - Use validation plugin when creating new authority type The new authority type entry form uses custom form validation JavaScript. This patch removes it in favor of using HTML5 validation attributes and Koha's built-in validation plugin. To test, go to Administration - Authority types and click New authority type. Try submitting the form without entering any data. You should see a warning about required fields. Upon entering text in those fields the warning should disappear. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11766] Use validation plugin when creating new authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11767] Use validation plugin when creating new authority framework tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11767 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11767] Use validation plugin when creating new authority framework tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11767 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25410|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25425 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25425action=edit Bug 11767 - Use validation plugin when creating new authority framework tag The page for adding a new tag to an authority framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. The patch also moves some tag markup out of the script and into the template where it belongs. To test, apply the patch and go to Administration - Authority types - MARC structure - New tag. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing tag should also work correctly. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11789] Use validation plugin when creating new list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 25408 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25408 Bug 11789 - Use validation plugin when creating new list Review of attachment 25408: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11789attachment=25408) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ +430,3 @@ ol +lilabel class=required for=addshelfList name:/labelinput id=addshelf type=text name=addshelf size=25 required=required class=required / +span class=requiredRequired/span Are you sure this required string is useful? The label is already in red. I just passed QA on bug 11766 and bug 11767 and you didn't add it. Should we be consistent for all forms? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #7 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 25426 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25426action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #26) Some prelimary QA comments/questions: Thank you Marcel for having a look at this one. If you browse the selection, it would imo be good to show that you are doing so (Browse selected results vs. Browse results). Will be fixed. If we use the js plugin, it would be good to acknowledge that on About, separate from the question if this specific MIT license needs that by law or so. In fact the plugin is useless, I will remove it. Also I do not think that remembering a few biblios in a cookie, would be a big legal problem. We c/should clear the contents every time we start a new search. And if we are not allowed to create it, well we do not.. How do we know if we are allowed or not? More technically: There is a small merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css. Will be fixed. Note that I would like to see the bootstrap patch here also instead of on another report. Bootstrap is now leading and should be pushed first. (Is there any trouble there with less files?) The first patches were signed off, so I prefer to create another report for the bootstrap theme. I will add the patch from bug 11296 to this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23542|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25427 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25427action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link Browse selected biblios when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the Browse results block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the Browse selected biblios link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23543|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25428 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25428action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the browse link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25436action=edit Bug 10858: Replace Browse results with Browse selected results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23633|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25429 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25429action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before (end of string)) at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23782|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25431 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25431action=edit Bug 10858: Update the jquery.json plugin to the lastest version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25432 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25432action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the Browse selected biblios link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25435 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25435action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25433 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25433action=edit Bug 10858: Remove the jQuery JSON plugin JSON.stringify and JSON.parse are natively supported by mordern browsers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25434 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25434action=edit Bug 10858: FIX the Browse selected link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23781|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25430 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25430action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 11296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11296] Browse selected biblios - bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11296 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- *** This bug has been marked as a duplicate of bug 10858 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11311] Browse selected authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Bug 11311 depends on bug 11296, which changed state. Bug 11296 Summary: Browse selected biblios - bootstrap http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11296 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #15) Jonathan, can you point out which template files you believe this is an issue for? I'm not seeing it. Did you try to reproduce my example? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added CC||a...@biblos.pk.edu.pl --- Comment #1 from Jacek Ablewicz a...@biblos.pk.edu.pl --- (In reply to Marjorie Barry-Vila from comment #0) Someone can test it? Yes, I can confirm there is a problem with CancelReceipt(). It will delete (one or more, it doesn't matter) items associated with received order only if the given order is a partial receive (and the parent order is not fully received yet). Plus, in those rare cases when it is actually deleting the items, it's currently not doing a very good job - it is removing item records directly from mysql table, but it does NOT flag biblio record for Zebra reindexing after the deletion. Until recently, it also used to delete the items if given order was a transfer to another basket - but it was deleting the order record itself too, which was not all that good (see bug 11549). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11744 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11549 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11779] Unexpected change in logged in branch when changing overdue notice triggers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11779] Unexpected change in logged in branch when changing overdue notice triggers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25398|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25437 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25437action=edit Bug 11779 - Unexpected change in logged in branch when changing overdue notice triggers Steps to reproduce: 1) Log into staff intranet 2) Set logged in branch 3) Browse to tools/overdue notice triggers 4) Select a branch from the pulldown that is not your logged in branch 5) use the Check out bar at the top of the page to search for a patron to check out to 6) Once you have landed here, click the check out tab link again, or the Edit button ( any action really ) 7) Note your logged in branch has now changed to the once selected when editing the notice/status triggers This is due to the way the patron search passes the branchcode to be used via the form. This form assumes the branchcode variable is always the currently logged in branch, which may not and is not always the case. Test Plan: 1) Apply this patch 2) Repeat the steps to reproduce above 3) Note your logged in branch does not change Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Funny bug :) This patch fixes the described issue and should not introduce regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25400|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25438 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25438action=edit Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( source,text ). Go to Tools - Quote editor and click the Import quotes button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com No regression found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11701] Fix C4::Context::Zconn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #25102|0 |1 is obsolete|| --- Comment #4 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 25439 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25439action=edit Bug 11701: Fix C4::Context::Zconn Support other parameters too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11701] Fix C4::Context::Zconn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Julian Maurice julian.maur...@biblibre.com --- A quick grep shows me that other parameters are not used, but it isn't harder to support all parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25403|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25440 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25440action=edit Bug 11783 - Record level unavailable holds sending empty CD field rather than item barcode If a patron has a record-level hold that is unavailable, any patron information request will send back an empty CD field when this field should have an item barcode in it. This is due to a minor error in ILS::Patron::_get_outstanding_hodsl where GetItemnumbersForBiblio is assumed to return an array but in reality returns an arrayref. Test Plan: 1) Create a record level hold for a patron and record 2) Using SIP2, make a patron information request 3) Note the empty CD fields 4) Apply this patch, restart SIP server 5) Repeat step 2 6) Note the CD field now has a barcode Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com I did not test this patch but the following code shows me it is correct: use C4::Items; use Data::Dumper; my $biblionumber = 5035; my $itemnumber = (GetItemnumbersForBiblio($biblionumber))[0]; say Dumper $itemnumber; $itemnumber = (GetItemnumbersForBiblio($biblionumber))-[0]; say Dumper $itemnumber; displays: $VAR1 = [ '23168', '23169', '23170', '23171', '23172' ]; $VAR1 = '23168'; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Blocks||11783 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||10817 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11784] Patron images broken in Self checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11784 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11784] Patron images broken in Self checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Depends on||10636 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Introduced by bug 10636 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25442 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25442action=edit Bug 11777 - Created by name is not coming in order receiving page To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Click on Receive shipment button. 6) Click on receive link on the right hand side you will be able to see created by name Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11777 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Depends on||10723 Severity|enhancement |normal --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Certainly introduced by bug 10723. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #26 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 25443 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25443action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #27 from Julian Maurice julian.maur...@biblibre.com --- This time the problem should be fixed ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #14 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Whenever using the koha-shell command I am met with the following error messages: bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell Is this something specific to my setup, or is it a general bug/oddity? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11782] Need junktag file to remove specific marc fields/subfields on z39.50 import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11782 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Hi, On report 6536 and subsequent ones I still plan to add XSLT on top of Z3950 results, allowing you to strip tags or do whatever you want with them before importing. Unfortunately these patches did not yet reach master, but I have not given up on them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #64 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Doug Kingston from comment #63) This is a new combined patch (original+QA changes). Its been build against HEAD so it should apply to a new branch at origin/master. It replaces the two patches from earlier. Yes, it applies. Will have a look now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jonathan.dru...@biblibre.co ||m Version|3.12|master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- I reproduced against master. I will provide a patch soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25445 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25445action=edit Bug 11744: Cancel a receipt does not delete items created on receiving If items is created on receiving, cancel a receipt should delete them. The code only manage the case if the order is a child of another order (partial). To reproduce: 1/ Set AcqCreateItem to receiving 2/ Order one or more item(s) 3/ Receive the order and verify the item is created 4/ Cancel the receipt 5/ The item is not deleted Test plan: 1/ Apply this patch and do again previous steps. The item should not be deleted at step 5. 2/ Set AcqCreateItem to ordering and verify the item is not deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] canceil receipt not work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25444 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25444action=edit Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acquisition/CancelReceipt.t returns 1 failure. After the patch, the 2 tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 --- Comment #15 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Looks like Galen has reported the bug now: bug 11775 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10821] label pdf adding in strange breaking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #8 from Dan Scott d...@coffeecode.net --- As this bug addresses regressions from the prior default theme to the new default theme in 3.14, will the patch also be backported to 3.14? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Dan, as this is marked as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10821] label pdf adding in strange breaking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #28 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- Hi, It's marked Resolved Wontfix but for us it's very critical. We just have 3.12 and we can not print our labels correctly. We are in lcc and for a call number like HQ759.96 C58 1986, we have this: HQ 759.96 .C58 1986 and for this STV B46ga 2013 Saison.2 DVD 1/5, we have STV .B46 G A2013 SAISON.2 DVD 1/5 We don't want to put our call number in dcc. How can we go back for print lcc call number correctly? Thanks, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #25412|0 |1 is obsolete|| --- Comment #65 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 25446 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25446action=edit Bug 11078: Add locking to rebuild_zebra (revised patch 2014-02-18) This patch adds locking to rebuild_zebra.pl to ensure that simultaneous changes are prevented (as one is likely to overwrite the other). Incremental updates in daemon mode will skipped if the lock is busy and they will be picked up on the next pass. Non-daemon mode invocations will also exit immediately if they cannot get the lock unless the new flag -wait-for-lock is specified, in which case they will wait until the get the lock and then proceed. Supporting changes made to Makefile.PL and templates for the new locking directory (paralleling the other zebra lock directories). We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl can find it. To address earlier QA concerns we: 1. added code to check if flock is available and ignore locking if its missing (from M. de Rooy) 2. changed default for adhoc invocations to abort if they cannot obtain the lock. Added option -wait-for-lock if the user prefers to wait until the lock is free, and then continue processing. 3. added missing entry to t/db_dependent/zebra_config.pl 4. added a fallback locking directory of /tmp Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Doug merged the original patch with the QA changes. Just for the record, noting here that the original patch was tested extensively too by Martin Renvoize. I have added a followup for some exceptional cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #66 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 25447 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25447action=edit Bug 11078: QA Follow-up for missing file permissions on lockfile The original patch creates a lockfile in the ZEBRA_LOCKDIR. It can fall back to /var/lock or even /tmp. If the create fails, it dies. This can be considered as very exceptional. This followup adjusts the fallback location in /var/lock or /tmp slightly. It appends the database name to the folder in order to prevent interfering between multiple Koha instances. Creation of the lockfile has been moved to a subroutine extending directory and file creation testing. In the very unlikely case that we cannot create the lockfile (after three separate tries), this follow-up allows you to continue instead of die. This is just as we did before we had file locking here. Every time skipping a reindex could cause more harm than continuing and having the race condition once in a while. Test plan: Test adding and removing lockdir from your koha-conf.xml. Check fallback. Note that fallback in /var/lock or /tmp must contain database name. Remove the lockdir config line and remove permissions from fallback. In this case the reindex should continue but with a warning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Tested with daemon and one-off invocation simultaneously. Tested new wait parameter. Tried all variations of lock directory (changing permissions etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Attachment #24143|0 |1 is obsolete|| --- Comment #6 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no --- Created attachment 25448 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25448action=edit Bug 11518 [Followup] - Change method name from 'itemtype' to 'effective_itemtype' for clarity Test runs without errors. Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #67 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Thanks Doug for all adjustments. As you can see, I still saw a reason to add a followup to cover some (very) exceptional cases. Just for the record: I would prefer (next time) to keep the original patch with signoff and just add QA follow-ups. But no reason to do that now anymore! I would like to suggest the following route now: Please apply both patches and test again (hopefully last time). You could add your signoff on the second patch. Since we had Martin for the signoff and considering the second patch as a QA follow-up, I will pass QA on this report after receiving your confirmation. Note that we have no warnings too from the QA tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- This is still an issue and a big one at that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- http://screencast.com/t/GgtRm7IqPf7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10821] label pdf adding in strange breaking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #29 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to Marjorie Barry-Vila from comment #28) Hi, It's marked Resolved Wontfix but for us it's very critical. We just have 3.12 and we can not print our labels correctly. Please see comment 22. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl --- Jonathan: Thanks for your adjustments and your patience in looking at what follows :) I would strongly prefer to slightly adjust a few patches here. We now add the plugin, update it and then remove it in this series.. I would not recommend to push that line of action if we can just remove it from the first patch. I have no objection to leaving the original signoff on that one when you enter your additional signoff commenting on the amend. After that I will add still another signoff. Makes that sense? Changing status to reflect this.. Please change back to SO after that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #82 from M. de Rooy m.de.r...@rijksmuseum.nl --- Olli, Since this is a larger set of patches, it could be helpful while reviewing it to know what you exactly tested when signing off? Is it possible to elaborate on that? Thanks in advance.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Hardware|PC |All Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11328] Local cover images not appearing in staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 25449 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25449action=edit Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration - Cities. - Edit or create a new patron. - Under main address - city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address - city and alternate contact - city. - Save your changes and confirm that everything worked correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11791] New: Use validation plugin when creating new city
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Bug ID: 11791 Summary: Use validation plugin when creating new city Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The new city entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25453 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25453action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25451 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25451action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the browse link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25455 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25455action=edit Bug 10858: FIX the Browse selected link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25452 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25452action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before (end of string)) at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25427|0 |1 is obsolete|| Attachment #25428|0 |1 is obsolete|| Attachment #25429|0 |1 is obsolete|| Attachment #25430|0 |1 is obsolete|| Attachment #25431|0 |1 is obsolete|| Attachment #25432|0 |1 is obsolete|| Attachment #25433|0 |1 is obsolete|| Attachment #25434|0 |1 is obsolete|| Attachment #25435|0 |1 is obsolete|| Attachment #25436|0 |1 is obsolete|| --- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25450 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25450action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link Browse selected biblios when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the Browse results block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the Browse selected biblios link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25454 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25454action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the Browse selected biblios link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25456 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25456action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25457 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25457action=edit Bug 10858: Replace Browse results with Browse selected results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11791] Use validation plugin when creating new city
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11791] Use validation plugin when creating new city
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 25458 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25458action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration - Cities - New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #40) I would strongly prefer to slightly adjust a few patches here. We now add the plugin, update it and then remove it in this series.. I would not recommend to push that line of action if we can just remove it from the first patch. I have no objection to leaving the original signoff on that one when you enter your additional signoff commenting on the amend. After that I will add still another signoff. Makes that sense? Absolutely, it was a morning laziness :) I completely removed all references to this plugin in the last set of patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11328] Local cover images not appearing in staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #1 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- Created attachment 25459 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25459action=edit local cover -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
