[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

Binu Thomas  changed:

   What|Removed |Added

 CC||b...@eclateng.com

--- Comment #46 from Binu Thomas  ---
I was able to make it work using Wajasu's method. But the html is still not
working. Requires re-write of scheduler.pl CGI.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

Binu Thomas  changed:

   What|Removed |Added

 CC||b...@eclateng.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5956] Highlight holds on check-in

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956

--- Comment #2 from Viktor Sarge  ---
Created attachment 28858
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28858&action=edit
5956 Highlight holds on chech-in

This patch adds a flag in returns.pl if the returned books have
reservervations.
The flag is picked up by returns.tt and displays a warning using the "Note"
field and CSS-class already in place.

Note that this differs from the atcual suggestion from Jared, but using the
note field instead of making the title red felt that it kept it more
consistent.

Apologies if the commit message hints at the fact that I'm still learning Git.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5956] Highlight holds on check-in

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956

Viktor Sarge  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

Yohann Dufour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

Yohann Dufour  changed:

   What|Removed |Added

  Attachment #28834|0   |1
is obsolete||

--- Comment #4 from Yohann Dufour  ---
Created attachment 28859
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28859&action=edit
Bug 12416: add the test of DelUniqueDebarment

The subroutine DelUniqueDebarment was not tested

To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.43 cusr  0.07
csys =  1.54 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5956] Highlight holds on check-in

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #3 from Viktor Sarge  ---
Test plan: 

* Return both reserved and not reserved books and verify that the reserved
books are not highlighted
* Install the patch
* Return both reserved and not reserved books again and verify that reserved
books are now highlighted in the "Notes" field.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

--- Comment #5 from Yohann Dufour  ---
Created attachment 28860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28860&action=edit
Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is'

The use of the subroutine 'is' is prefered over the subroutine 'is'

To test: execute the commande prove t/db_dependent/Borrower_Debarments.t
To command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.42 cusr  0.08
csys =  1.54 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

Yohann Dufour  changed:

   What|Removed |Added

   Patch complexity|Small patch |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #8 from Julian Maurice  ---
Hi Paola,

have you created the order line being logged in with a real user (not the mysql
user) ? Does this user have a firstname and a surname ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

Yohann Dufour  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416

--- Comment #6 from Yohann Dufour  ---
Created attachment 28861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28861&action=edit
Bug 12416: add new tests of DelUniqueDebarment

The subroutine DelUniqueDebarment was not enough tested

To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=31,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.44 cusr  0.08
csys =  1.56 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #4 from Magnus Enger  ---
paxed: Will you be using some other functionality to hide the items from
searches? What happens if an item connected to your hidden branch turns up in a
search?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000

Yohann Dufour  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10700

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10700] Remove misc/cronjobs/rss

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10700

Yohann Dufour  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9000

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

--- Comment #3 from Viktor Sarge  ---
Created attachment 28862
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28862&action=edit
9245 Fixes visual bux with fines tab not highlighting

This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the
value "finesview=1" that makes the tab active.

Test plan:
1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's
highlight when you click "Pay fines", "Create manual invoice" and "Create
manual credit".
2) Install the patch.
3) Redo the first step and make shure that the left menu tab "Fines" is now
highlighted all the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

Viktor Sarge  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11292] barcode scanner clicking 'save'

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292

--- Comment #16 from Kyle M Hall  ---
Created attachment 28863
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28863&action=edit
Bug 11292 [QA Followup] - Use noEnterSubmit instead of new keypress handler

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417

--- Comment #1 from Yohann Dufour  ---
Created attachment 28864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28864&action=edit
Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm

The module Koha::Borrower::Files.pm was not tested

To test:
1/ Execute the command: prove t/db_dependent/Borrower_Files.t
2/ The command has to print:
t/db_dependent/Borrower_Files.t .. ok
All tests successful.
Files=1, Tests=23,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.47 cusr  0.08
csys =  1.60 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417

Yohann Dufour  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000

--- Comment #5 from Yohann Dufour  ---
Since misc/cronjobs/rss/rss.pl is not used anymore, it should be removed.
Moreover, this file contains old dependencies with the module
HTML::Template::Pro.

For a new user of Koha, which launchs the test of t/db_dependent/00-strict.t ,
it prints :
t/db_dependent/00-strict.t . 363/? 
#   Failed test 'Syntax check misc/cronjobs/rss/rss.pl'
#   at /usr/share/perl5/Test/Strict.pm line 394.
# Can't locate HTML/Template/Pro.pm in @INC (you may need to install the
HTML::Template::Pro module) (@INC contains: installer misc/translator
/home/yohann/koha /home/yohann/qa-test-tools /etc/perl
/usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5
/usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18
/usr/local/lib/site_perl . /home/yohann/koha /home/yohann/qa-test-tools
/etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2
/usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18
/usr/local/lib/site_perl .) at misc/cronjobs/rss/rss.pl line 30.
# BEGIN failed--compilation aborted at misc/cronjobs/rss/rss.pl line 30.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

--- Comment #1 from Viktor Sarge  ---
Created attachment 28865
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28865&action=edit
12332 Fix for tab "Purchase suggestions" not lighting up

This patch changes the file purchase-suggestions.pl with "suggestionsview => 1"
for the template parameter.
In circ-menu.inc i changed the condition from "suggestions" to
"suggestionsview" since it seemed to conflict with the existing variable
suggestions (and in that case only highlighting the tab when there were
suggestions).

Please note that I fixed the troubles with the tab "Fines" in a separate patch
9245.

Test plan:
1) Verify that "Purchase suggestions" does not light up as it should when
clicked.
2) Install the patch.
3) Verify that the tab "Purchase suggestions" now actually light up when
clicked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Viktor Sarge  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] New: C4::Members::Attributes.pm needs unit tests

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Bug ID: 12427
   Summary: C4::Members::Attributes.pm needs unit tests
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: yohann.duf...@biblibre.com
QA Contact: gmcha...@gmail.com

The module C4::Members::Attributes.pm is not tested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Yohann Dufour  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12428] New: "OPAC info" is not displayed in the OPAC

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428

Bug ID: 12428
   Summary: "OPAC info" is not displayed in the OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: mag...@enger.priv.no
QA Contact: testo...@bugs.koha-community.org

Bug 7264 made it possible to enter a piece of "OPAC info" for each library, and
have it displayed as a tooltip on the library name in the items table on the
detail view in the OPAC. This functionality now seems to be broken, I can't get
anything to display when I hover over the library name. 

The Firebug JS console does not show any errors. Tested in Firefox 30.0 on
Ubuntu 14.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

Juhani Seppälä  changed:

   What|Removed |Added

 CC||jsep...@student.uef.fi

--- Comment #1 from Juhani Seppälä  ---
Hello,

I looked into this issue:

if (me.curPos === me.searchCookie.results.length && me.searchCookie.total ==   
 me.curPos + me.searchCookie.offset) {
  nextbutton = '' + me.curPos + '
' + me.searchCookie.results.length + ' »';
} else {
  nextbutton = '' +
me.curPos + ' ' + me.searchCookie.results.length + ' »';
}

To me it looks like an off-by-one issue with searchCookie.results.length.
searchCookie.total seems to also be returning undefined leading that if-clause
evaluating to false.

I'm still pretty new to Koha development and am trying still to get a hold of
things - may I propose a fix for this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8565] forgive fines doesn't work

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8565

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #2 from Viktor Sarge  ---
Is this stil an issue Nicole? I created a new authorized value with the code FU
but couldn't replicate this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Could you rebase the patch please ? I fail to apply it on master:

Applying: Bug 12197: enforce the maxreserves preference when staff members
place hold requests
fatal: sha1 information is lacking or useless (reserve/request.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9208] overdue letters (pdf) are not correctly encoded

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9208

Sophie MEYNIEUX  changed:

   What|Removed |Added

  Attachment #28849|0   |1
is obsolete||

--- Comment #8 from Sophie MEYNIEUX  ---
Created attachment 28866
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28866&action=edit
Bug 9208 : Fix encoding of overdue letters

When overdue letters templates contain symbol like euro,
  the conversion between html to pdf results in wrong encoding
  of special characters.
  Adding explicit utf8 encoding at the beginning of html file
  resolves this problem. This is already done for hold notices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9208] overdue letters (pdf) are not correctly encoded

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9208

--- Comment #9 from Sophie MEYNIEUX  ---
Fixing some typo in the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12429] New: patron seeing fines codes

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429

Bug ID: 12429
   Summary: patron seeing fines codes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: cgi-bin/koha/opac-account.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 28867
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28867&action=edit
FU showing in OPAC

In the past the patron did not see the Fines code (FU, F, etc) - but they do
now and it's confusing and a bit insulting in US English.  Can we have FU just
say Fine or not appear at all to the public?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12231] AllowMultipleIssuesOnABiblio description misleading

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12231

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
I think there is a typo: effect/affect ?
"This will only affect records ..." sounds better for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
If a numbering pattern uses {X}, {X}{Y} or {X}{Y}{Z}, in this order, then the
updatedatabase works.
But if I have a numbering pattern that uses only {Z} for example, then the Z
part will be stored in serialseq_x (and future serials will have the Z part in
serialseq_z column)
If my numbering pattern uses only {X} and {Z}, the Z part will be in
serialseq_y.
I think this have to be fixed, so failing QA here.

Also the original serialseq column is not removed. Is it intended ? I think we
should not keep values in database that can be easily generated on the fly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428

--- Comment #1 from Owen Leonard  ---
Git bisect blames this commit (Bug 7720):

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=09ce37d349340f9af4b7bb565381718f5c182e18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #26003|0   |1
is obsolete||

--- Comment #15 from Julian Maurice  ---
Created attachment 28868
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28868&action=edit
Bug 11708: Add aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #26004|0   |1
is obsolete||

--- Comment #16 from Julian Maurice  ---
Created attachment 28869
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28869&action=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #26006|0   |1
is obsolete||

--- Comment #17 from Julian Maurice  ---
Created attachment 28870
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28870&action=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #18 from Julian Maurice  ---
Created attachment 28871
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28871&action=edit
Bug 11708: explicitly remove pagination

The use of columnfilter seems to keep the pagination even if the sDom is
't'.  We want to remove the pagination here in order to show all data in
the table.

To reproduce:
Add 10+ closed basketgroup and verify all are displayed.
Without this patch, only the 10 first are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #19 from Julian Maurice  ---
Created attachment 28872
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28872&action=edit
Bug 11708: All basketgroups on one page - several fixes

1/ Change wording from "Basket grouping" to "Basket groups"
2/ Display vendor name in front of "Baskets group for"
3/ Change wording from "Charged amount" to "Amount spent"
4/ Change wording from "Ordered amount" to "Amount ordered"
5/ Add bug number in updatedatabase.pl
6/ Show "Basket groups" link in menu only if user have group_manage
permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #20 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #8)
> 3) I am missing the vendor in the basket group table, I think the new view
> for all baskets would make more sense with it.

I didn't added the vendor in tables because it is already displayed before each
pair of tables ("Basket groups for ")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #21 from Katrin Fischer  ---
(In reply to Julian Maurice from comment #20)
> (In reply to Katrin Fischer from comment #8)
> > 3) I am missing the vendor in the basket group table, I think the new view
> > for all baskets would make more sense with it.
> 
> I didn't added the vendor in tables because it is already displayed before
> each pair of tables ("Basket groups for ")

Hi Julian, 

not sure, maybe I thought it would be one big table. Looking at the notes I
think I had done a search without selecting any vendor:

>2) When using the link in the navigation, you end up with the heading:
>  Basket grouping for  (because no vendor was selected)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

--- Comment #86 from Kyle M Hall  ---
It's been a month with no reply, setting to passed qa.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086

--- Comment #21 from Kyle M Hall  ---
Created attachment 28873
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28873&action=edit
Bug 12086 [QA Followup 2] - Implement Jonathan's suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #2 from Fridolin SOMERS  ---
(In reply to Juhani Seppälä from comment #1)
> may I propose a fix for this issue?
Hello and welcome to Koha.
Your fixe will be most welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #28862|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

--- Comment #4 from Nicole C. Engard  ---
Created attachment 28874
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28874&action=edit
[SIGNED-OFF] 9245 Fixes visual bux with fines tab not highlighting

This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the
value "finesview=1" that makes the tab active.

Test plan:
1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's
highlight when you click "Pay fines", "Create manual invoice" and "Create
manual credit".
2) Install the patch.
3) Redo the first step and make shure that the left menu tab "Fines" is now
highlighted all the time.

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8565] forgive fines doesn't work

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8565

Nicole C. Engard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nicole C. Engard  ---
I haven't had any complaints about it, so if you can reproduce we can close
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12423] librarything reviews aren't showing in bootstrap

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12423

--- Comment #2 from Nicole C. Engard  ---
I was going to patch this by editing opac-details, but it turns out this might
be an XSLT issue because everything in the tabs is working just fine, it's just
the reviews link up at the top that's not working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12328] report actions don't work in Chrome

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12328

stevecallen...@esilibrary.com changed:

   What|Removed |Added

 CC||stevecallender@esilibrary.c
   ||om

--- Comment #1 from stevecallen...@esilibrary.com ---
I've seen the same behavior. What I noticed is that there seems to be a report
threshold where the action button will stop working. It looks like about 100
reports. What happens is when you the reports screen and load more than the
standard 20, the highest number reports action button does not work. However if
you first click the action button on one of the 1-20 reports and then scroll
down and click on a higher report, it will work. 

The easiest way to test this where I can see the behavior every time, when you
have a good amount of reports that will not all display on the normal view,
select to show "ALL" entries, and then click on the action button for the
bottom most report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428

--- Comment #2 from Owen Leonard  ---
Created attachment 28877
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28877&action=edit
Bug 12428 - "OPAC info" is not displayed in the OPAC

The changes made by Bug 7720 ("Ambiguity in OPAC Details location")
broke the display of OPAC branch information tooltips by making changes
to the markup which the tooltip plugin needs to function.

This patch corrects the markup to enable tooltips to work again. This
patch also makes changes to Items.pm so that branch information tooltips
can be shown for both home and holding branches (which are optionally
displayed now via the changes by Bug 7720). Before this patch the
tooltip would always display the information for the holding branch
regardless of the OpacLocationBranchToDisplay setting.

This patch also changes the footer include, adding an alias for the
jQueryUI tooltip function to prevent conflict with Bootstrap's function
of the same name.

To test, you must have at least two libraries configured with "OPAC
info" for display in the OPAC.

Modify the holdings of a title so that there is at least one item which
has different holding and home branches matching your library configured
above.

View the detail page for that record under various values of the
OpacLocationBranchToDisplay system preference:

- "holding library" : The table of holdings should show a column for
  only the holding library. Hovering your cursor over the library name
  should display the branch information you configured for that library
  in a tooltip .

- "home and holding library" : The table of holdings should show columns
  for both home and holding library. Hovering your cursor over each
  should show the corresponding library information tooltips.

- "home library" : The table of holdings should show a column for
  only the home library. Hovering your cursor over the library name
  should display the branch information you configured for that library
  in a tooltip.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12343] TransformKohaToMarc() is adding MARC subfields in random order

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12343

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jacek!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11270] Search Result highlighting should be refactored

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger  ---
Looks like this should be "Needs signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11233] testing development

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mag...@enger.priv.no
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Brooksml  changed:

   What|Removed |Added

 CC||je...@brookslibraryvt.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12338] Remove smartmatch operator from C4/Serials.pm

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12338

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11958] classification sources help file has typo

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12380] can't tab to save buttons on add item

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

Brendon Ford  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |brendon.f...@manhattan.edu

--- Comment #2 from Brendon Ford  ---
Created attachment 28878
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28878&action=edit
Fix for switched phone numbers on patron details page.

This patch fixes switched phone numbers on patron details page and also makes
phone number labels more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #87 from Katrin Fischer  ---
I have just retested this and after giving it some more thought... I am still
worried. My point is:

As a user, I should be able to find out if my checkouts are visible to others
at any time. If the library opts to disable OpacPrivacy (and I still think it's
not a good thing to tie different functionalities to the same pref), I don't
see anywhere in my account that my data is shared with others.

Please feel free to get more opinions, eyes on this. I don't want to be
unreasonable and I hope I am not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

--- Comment #1 from Owen Leonard  ---
In my test almost everything appears to be working:

SyndeticsAuthorNotes - working
SyndeticsAwards - couldn't confirm
SyndeticsCoverImages - working
SyndeticsCoverImageSize - working
SyndeticsEditions - couldn't confirm
SyndeticsExcerpt - working
SyndeticsReviews - working
SyndeticsSeries - working
SyndeticsSummary - working
SyndeticsTOC - working

I couldn't find any title for which SyndeticsAwards or SyndeticsEditions were
working, but I don't know if that's because there is a problem with my data or
if there is a problem with the feature.

Nicole can you please test again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #88 from Mickey Coalwell  ---
Katrin, while I appreciate your point of view, it does seem that you didn't
address the point that Kyle made a month ago, i.e.,

"I would *not* consider this a bug. If OPAC privacy was turned off, the patron
would need to go to a librarian to have it enabled in the first place. In that
case, I see no issue with the patron needing to have a librarian to disable it
in the same way."

I agree with Kyle, and share that point of view. At some point, the library
simply has to be allowed/trusted to manage the library user's account in an
appropriate manner. 

Barring any specific (rather than philosophical) objection to this view, I
would ask that you reconsider your decision to mark this FAILED QA. This
discussion has dragged on long enough, and I don't see that it's gaining us
anything to go back and forth in the absence of any support for your view or a
consensus arising from a compelling debate. 

Will you agree to allow this to development to move forward at this time? Thank
you.

Mickey

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #89 from Galen Charlton  ---
(In reply to Mickey Coalwell from comment #88)
> I agree with Kyle, and share that point of view. At some point, the library
> simply has to be allowed/trusted to manage the library user's account in an
> appropriate manner. 

Not all legal jurisdictions would agree, and it would not surprise me if there
are some where there is an absolute right, even for juveniles, to prevents
relatives from seeing checkouts.

I believe that Koha should respect stronger data privacy laws when applicable,
and this is one such case.

I believe that a resolution is the move the OPAC page for toggling
privacy_relative_checkout so that it is not dependent on the value OpacPrivacy.
 This change would be small and would allow general circ privacy to be
orthogonal to linked patron checkout visibility.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #90 from Chris Cormack  ---
(In reply to Galen Charlton from comment #89)
> (In reply to Mickey Coalwell from comment #88)
> > I agree with Kyle, and share that point of view. At some point, the library
> > simply has to be allowed/trusted to manage the library user's account in an
> > appropriate manner. 
> 
> Not all legal jurisdictions would agree, and it would not surprise me if
> there are some where there is an absolute right, even for juveniles, to
> prevents relatives from seeing checkouts.
> 
> I believe that Koha should respect stronger data privacy laws when
> applicable, and this is one such case.
> 
> I believe that a resolution is the move the OPAC page for toggling
> privacy_relative_checkout so that it is not dependent on the value
> OpacPrivacy.  This change would be small and would allow general circ
> privacy to be orthogonal to linked patron checkout visibility.

I agree with this entirely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #91 from Owen Leonard  ---
Picture this scenario:

1. Husband and wife enable each other to see the other's checkouts.
2. Marriage goes bad, wife wants to check out books on divorce.
3. Library has turned off OpacPrivacy, wife can't block husband from seeing her
checkouts.

It's not hard to see situations like this where this bug could have very real
and negative effects on people's use of the library. I agree that this is a bug
and there should be a way to control it separate from OpacPrivacy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #92 from Mickey Coalwell  ---
(In reply to Owen Leonard from comment #91)
> Picture this scenario:
> 
> 1. Husband and wife enable each other to see the other's checkouts.
> 2. Marriage goes bad, wife wants to check out books on divorce.
> 3. Library has turned off OpacPrivacy, wife can't block husband from seeing
> her checkouts.
> 
> It's not hard to see situations like this where this bug could have very
> real and negative effects on people's use of the library. I agree that this
> is a bug and there should be a way to control it separate from OpacPrivacy.

Excellent points, and Owen's (and others') suggestion sounds good to me. Kyle,
is providing the necessary control through OpacPrivacy a solution you can live
with? If so, can we move ahead on that basis with this development? Thank you
all for your input. 

Mickey

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

--- Comment #3 from Nicole C. Engard  ---
Brendon,

Every patch needs a test plan. So after your description type something like :

To Test:

1. 
2. 
etc etc

So that people can test to be sure the patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12293] Remove Problematic Logic from Patron Messaging Preferences Form - bootstrap

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12293

Chris Cormack  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Template only change, pushed to master as Module Maintainer for OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

--- Comment #4 from Brendon Ford  ---
Sorry about that Nicole. Thanks for the info.

To Test:

1. Create/modify a patron entering some unique data into the "Secondary phone:"
and "Other phone:" fields (different data for each).
2. Save the patron record.
3. Go to the patrons details page and make sure the data entered into the
"Secondary phone:" field is displaying next to the "Secondary phone:" label and
that the data entered into the "Other phone:" field is displaying next to the
"Other phone:" label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

Brendon Ford  changed:

   What|Removed |Added

  Attachment #28878|0   |1
is obsolete||

--- Comment #5 from Brendon Ford  ---
Created attachment 28879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28879&action=edit
Fix for switched phone numbers on patron details page.

I have added the test plan to the patch and updated it to include actually
applying the patch.

To Test:

1. Apply the patch.
2. Create/modify a patron entering some unique data into the "Secondary phone:"
and "Other phone:" fields (different data for each).
3. Save the patron record.
4. Go to the patrons details page and make sure the data entered into the
"Secondary phone:" field is displaying next to the "Secondary phone:" label and
that the data entered into the "Other phone:" field is displaying next to the
"Other phone:" label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #53 from Katrin Fischer  ---
Hi Jesse,

here 2 small things I found during a quick test drive:

1) The position of the descriptions for the fields and subfields seems a bit
off
  when you have a language chooser (more than 1 language installed an active). 
  When the window is maximized I don't see the description at all, when the
  window is a bit smaller I can partially see it, but have to scroll

2) I have German sample frameworks installed and the umlauts in the
descriptions
  are broken, an example is 040$cÜbertragungsstelle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (when not using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] New: Truncation disables relevance ranking (when not using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Bug ID: 12430
   Summary: Truncation disables relevance ranking (when not using
QueryParser)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Scenario:

1) NOT using QueryParser
2) Using truncation (either by explicitly using * in the query or when
'QueryAutoTruncate' is set to 'automatically')

Result:

1) Search results ARE ordered by biblionumber ascending and NOT by relevance

--

This appears not to be an issue when using QueryParser as it seems to parse
queries much better than the traditional...method.

However, quite a major issue for those not using QueryParser, as everyone likes
relevant searches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

Summary|Truncation disables |Truncation disables
   |relevance ranking (when not |relevance ranking (and has
   |using QueryParser)  |issues when using
   ||QueryParser)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #1 from David Cook  ---
So the QueryParser actually acts a bit oddly as well.

In some cases, it will add the relevance attribute to a query with a couple
weighted fields, as defined in this section of queryparser.yaml:

relevance_bumps:
  keyword:
titleext:
  enabled: 1
  bib1_mapping:
biblioserver: 34
titlekw:
  enabled: 1
  bib1_mapping:
biblioserver: 20

If you type in "test" into the OPAC as a "Library catalog" search with
QueryAutoTruncate (or as test*), QueryParser will generate something like this:

@or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 9=20 @attr 2=102 @attr
5=1 @attr 4=6 "test" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "test"

Let me re-organize that a bit so it looks a bit more readable by humans...

@attr 1=1016 @attr 5=1 @attr 4=6 "test" 
@or
@attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "test"
@or
@attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "test"

Basically, it says it's doing a keyword (@attr 1=1016) wordlist (@attr 4=6)
search for a right truncated (@attr 5=1) "test" in 3 branches of this query. 

In two branches, it's looking for relevance (@attr 2=102) with weighted fields
(@attr 9=20) and (@attr 9=34) where the former is worth fewer points than the
latter in the ranking.

Source: http://www.indexdata.com/zebra/doc/administration-ranking.html

--

If you do a "Title" search for "test", you'll get the following:

@attr 1=4 @attr 5=1 @attr 4=6 "test"

(@attr 5=1 means 'right truncate', @attr 4=6 means 'wordlist', and @attr 1=4
means 'title')

Notice that we no longer have relevance ranking (via @attr 2=102) and no
weighted fields (@attr 9=VALUE)

--

So...it seems to me that relevance only works with QueryParser for
keywords...and even then in an unexpected way...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #2 from David Cook  ---
There's a bit of odd code in  Koha\QueryParser\Driver\PQF\query_plan\node.pm,
which is where a lot of the action happens in QP...

When doing a "Library Catalog" search, it tries to use the following code to
create a relevance query branch:

$fieldobj = $self->plan->QueryParser->bib1_mapping_by_name('field',
$relbump->{'classname'}, $relbump->{'field'}, $server);

This means $fieldobj, which should contain our CCL2RPN type mapping, will
always be null because $relbump->{'classname'} and $relbump->{'field'} don't
exist.

This is why the 2nd line in the following code doesn't have an @attr 1=1016 in
it. 

@attr 1=1016 @attr 5=1 @attr 4=6 "test" 
@or
@attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "test"

But we don't notice the error in the OPAC, as I think Zebra/Yaz/Zoom/whatever
silently treats the second branch as having @attr 1=1016 as a bare search will
usually be treated as a keyword (ie @attr 1=1016). 

--

Here is another odd bit of code, which is responsible for QueryParser's current
"support" for relevance.

my $relbumps = $self->plan->QueryParser->bib1_mapping_by_name('relevance_bump',
$self->classname, '', $server);

This line will return ALL the relevance_bump mappings under the keyword
class...which are 'titleext' and 'titlekw'.

I think these may have been example mappings...as it doesn't really make sense
to have them under a keyword class search. It should be a "keyword" class
search with a "keyword" field rather than a "titleext" field, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #3 from David Cook  ---
In any case, you can add relevance mappings to QueryParser by adding additional
config in queryparser.yaml.

For instance:
  title:
title:
  enabled: 1
  bib1_mapping:
biblioserver: 30

This will add relevance ranking to a title search with a field weight of 30.

However, it's worth noting that QueryParser seems to often fall back to
non-QueryParser mode for more complicated indexes like "ti,phr", so...I
wouldn't go out and make a lot of QP mappings just yet...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #2 from Viktor Sarge  ---
(In reply to Nicole C. Engard from comment #1)
> Anyone have any ideas on this?

My understanding is that they have indeed found the problem and that the
maximum-scale attribute is often used to prevent content from being blown up
and get blurry images on for example iPad. It would be easy to remove I guess,
but since it will have all manners of effects on different platform I think
there should be more discussion on the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/