[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59818|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 59843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59843=edit
Bug 18036: Perlcritic improve t/db_dependent/Templates.t

TEST PLAN
-
1) apply 17982
2) perlcritic -3 t/db_dependent/Templates.t
   -- messages
3) apply this patch
4) perlcritic -3 t/db_dependent/Templates.t
   -- OK
5) run koha qa test tools

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #20 from Marcel de Rooy  ---
Created attachment 59845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59845=edit
Bug 18036: [QA Follow-up] Descriptions and mock_preference

Adjusted a few test descriptions.
The test depends on template being set to prog. Made that explicit by
adding a mock_preference. If you change the mock to bootstrap, this
test will fail.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59838|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 59844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59844=edit
Bug 18036: All 4 cases tested

Added theme, lang, and availablethemes tests for all 4 cases.
Previously just availablethemes was tested.

Signed-off-by: Marcel de Rooy 
The warns from Mark's additional patch showed all four cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59839|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Comment on attachment 59839
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59839
[DO NOT PUSH] Proof that all 4 cases are triggered.

Worked fine. Obsoleting it now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #17 from Josef Moravec  ---
Please update the POD in svc/checkout_notes

29  =head1 NAME
30  
31  svc/issue_notes - Web service for managing patron notes set on issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #26 from M. Tompsett  ---
Sorry, Owen. Looks like 17855's cleanup to address the points JD requires a
rebase here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #150 from M. Tompsett  ---
Created attachment 59842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59842=edit
Bug 17855: Followup silence a warning when there are no imported patrons.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59830|0   |1
is obsolete||

--- Comment #148 from M. Tompsett  ---
Created attachment 59840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59840=edit
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Tets plan: Same as outlined in previous comments:
Go to and go through the web installer and onboarding tool:
https://koha-community.org/manual/installation/html/

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #149 from M. Tompsett  ---
Created attachment 59841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59841=edit
Bug 17855: Follow up on more trimming

Still needed to remove some libraries to address point 3 in comment #133.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #147 from M. Tompsett  ---
Comment on attachment 59830
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Review of attachment 59830:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59830)
-

Found more point 3 trimming needed.

::: installer/onboarding.pl
@@ +27,1 @@
>  use C4::Koha;

Digest::MD5, Encoding and C4::Koha don't need to be here. :(

@@ +30,2 @@
>  use Koha::Patrons;
>  use Koha::Items;

Koha::Items is not necessary either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #146 from M. Tompsett  ---
Comment on attachment 59830
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Review of attachment 59830:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=59830)
-

Quick eyeball. If it behaves as before, I'll sign off.

::: installer/onboarding.pl
@@ +2,4 @@
>  
>  # This file is part of Koha.
>  #
> +# Copyright (C) 2017 Catalyst IT

Addresses point 4 in comment #133.

@@ -30,5 @@
> -use C4::Members::Attributes;
> -use C4::Members::AttributeTypes;
> -use C4::Log;
> -use Koha::AuthorisedValues;
> -use Koha::Patron::Debarments;

Addresses point 3 in comment #133.

@@ -39,5 @@
>  use Koha::DateUtils;
>  use Koha::Patron::Categories;
>  use Koha::Patron::Category;
> -use Koha::Patron::HouseboundRole;
> -use Koha::Patron::HouseboundRoles;

Addresses point 3 in comment #133.

@@ -44,4 @@
>  use Koha::ItemTypes;
>  use Koha::IssuingRule;
>  use Koha::IssuingRules;
> -use Data::Dumper;

Addresses point 3 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
@@ -42,5 @@
>   href="/cgi-bin/koha/admin/admin-home.pl">Administration
>  [% END %]
>  About Koha
> -Summary
> -

Removal deals with point 7-9 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
@@ +5,5 @@
>   Add a patron category
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
> +[% INCLUDE 'js_includes.inc' %]
> +[% INCLUDE 'datatables.inc' %]

Good simplification to address point 5 in comment #133.

@@ +20,4 @@
>} else {
>   return true;
>}
> +}, MSG_ONE_ENROLLMENTPERIOD

Because of using included javascripts, variable name changed. Related to point
5 in comment #133.

@@ +25,2 @@
>  
> +

Addresses point 5 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ +7,4 @@
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
>  [% INCLUDE 'datatables.inc' %]
> +[% INCLUDE 'js_includes.inc' %]

Point 6 in comment #133.

@@ -21,5 @@
> -
> -
> 

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59824|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Created attachment 59839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59839=edit
[DO NOT PUSH] Proof that all 4 cases are triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59823|0   |1
is obsolete||
  Attachment #59825|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 59838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59838=edit
Bug 18036: All 4 cases tested

Added theme, lang, and availablethemes tests for all 4 cases.
Previously just availablethemes was tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8355] "save" button on the result list doesn't have a clear function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8355

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia  ---
Can we mark this as resolved? I don't know how this function looked in 2012 but
in the latest version it is quite clear, with an 'Add to:' label and the lists
marked clearly from the Cart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59837=edit
Bug 18043: Updating buttons for z39.50 cataloguing search

1) Go to Cataloguing -> New from Z39.50
2) Do a search, noticing the ugly buttons from Comment 1
3) Apply patch and go back to a new search
4) Do a search again, noticing the new, nicer buttons
5) Confirm they still work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18043] New: Updating buttons for z39.50 cataloguing search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

Bug ID: 18043
   Summary: Updating buttons for z39.50 cataloguing search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Buttons that need to use bootstrap 3/font awesome icons:
- Search
- MARC (fa)
- Card (fa)
- Import (fa)
- Previous page/Next page
- Go
- Try another search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Claudio  changed:

   What|Removed |Added

 CC||cost...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59836=edit
Bug 18042: Updating buttons in batch record modification and deletion

To test:
Create a test record that you can edit and delete. Go through each
process of modifying the record, then deleting the record - once before
applying the patch, and after apply the patch. Notice the difference in
buttons and confirm they all still work as expected.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18042] New: Update buttons in batch record modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042

Bug ID: 18042
   Summary: Update buttons in batch record modification and
deletion
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Buttons should use bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59835=edit
Bug 11932: Move delete checkbox on patron modification to right

To test:
1) Go to Tools -> Batch patron modification
2) Put in a user cardnumber and click Continue
3) Notice checkboxes on the left of the input fields
4) Apply patch and refresh page (resend information if prompted)
5) Notice checkboxes on the right of the input fields
6) Confirm they still work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59834=edit
Bug 18041: Updating buttons in Batch Item modification and deletion

To test:
1) Go to Tools -> Batch item modification
2) Put a barcode in and click Continue (notice ugly button)
3) Scroll to the bottom of the page and click Save (you don't have to
make any changes) (Notice ugly button)
4) I am leaving the Return button as is
5) Go to Tools -> Batch item deletion
6) Put a barcode in and click Continue (notice ugly button)
7) Uncheck the selected item (so you don't actually delete anything) and
click Delete selected items (Notice ugly button)
8) I am leaving the Return button as is
9) Apply patch and repeat steps 1-8. Notice changes to buttons

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18041] New: Updating buttons in Batch Item Mod and Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Bug ID: 18041
   Summary: Updating buttons in Batch Item Mod and Deletion
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

The buttons in the whole process are styled differently for both modification
and deletion. They should use bootstrap 3 styling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040

--- Comment #1 from Aleisha Amohia  ---
Created attachment 59833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59833=edit
Bug 18040: Updating buttons in Tools -> Upload local cover image

To test:
1) Go to Tools -> Upload local cover image
2) Select an image and click Upload file
3) Notice Process images button looks different to Upload file button
4) Apply patch and refresh page
5) Follow steps 1-3 again and notice the changed styling of the buttons

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18040] New: Updating buttons on Tools->Upload Local Cover Image

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040

Bug ID: 18040
   Summary: Updating buttons on Tools->Upload Local Cover Image
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

There are two buttons on this page - Upload file, Process images - and they
have different styling and look ugly. Should use bootstrap3 styling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59288|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 59832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59832=edit
Bug 17946: Show number of subscriptions on tab in OPAC record details

This patch removes some duplicate code.

To test:
1) Edit at least one subscription (or add a new one) to have a record
2) Find that record on the OPAC
3) Confirm that the Subscriptions tab reads the correct number of
subscriptions attached to the record

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946

Aleisha Amohia  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946

--- Comment #4 from Aleisha Amohia  ---
(In reply to Aleisha Amohia from comment #3)
> I think maybe the code that creates subscriptionsnumber is unnecessary since
> template toolkit provides the .size method. I will attach a patch that
> removes this

Classic case of "should've looked at the code before making a comment"...
subscriptions number is actually used for a few things in the code so I will
change my patch to use it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946

--- Comment #3 from Aleisha Amohia  ---
(In reply to M. Tompsett from comment #2)
> Why not just subscriptionsnumber?
> See line 796ish where it puts it in the sentence.
> There is no need for || 0, because subscriptions.size should be equal to
> subscriptionsnumber.

I think maybe the code that creates subscriptionsnumber is unnecessary since
template toolkit provides the .size method. I will attach a patch that removes
this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #57873|0   |1
is obsolete||

--- Comment #28 from Aleisha Amohia  ---
Created attachment 59831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59831=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work
Update6: Merge conflicts and making sure export of default auth type
works
Update7: Fixing merge conflicts and updating buttons to bootstrap3

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) IMPORTANT STEP:
Before you import, make sure that the authtypecode of the file you
are going to import matches the Code of your new authority type. Use
Vim or something similar to do a search and replace and change the
codes in your file - do NOT use LibreOffice etc. because it tries to
be too helpful and messes with the formatting of the file (this is what has
broken the Import function in previous testing of this patch)
7) Import into your new authority type using the file you just exported
(make sure you've done Step 6)
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #145 from Alex Buckley  ---
Created attachment 59830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830=edit
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Tets plan: Same as outlined in previous comments:
Go to and go through the web installer and onboarding tool:
https://koha-community.org/manual/installation/html/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #16 from Aleisha Amohia  ---
(In reply to Jonathan Druart from comment #12)
> Aleisha,
> I have rebased your patch on top of the ones I have submitted on bug 14224.
> You should take a look to apply some changes, for instance:
> 1/ Return a to_json
> 2/ Check the existence of the DB columns before inserting them
> 3/ Use "AFTER" in the ADD column sql query (to enforce fields order)
> 4/ I do not think checkout_notes should be a new module. I'd say it should
> go to circ
> 5/ Make sure the strings are translatable

(In reply to Jonathan Druart from comment #13)
> Something important: In svc/issue_notes you are not testing that the logged
> in user is allowed to call this script.

I have applied all of these changes and changed all instances (I think) of
'issue note' to 'checkout note'. This is ready to sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59828|0   |1
is obsolete||

--- Comment #15 from Aleisha Amohia  ---
Created attachment 59829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59829=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowCheckoutNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave a checkout note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage checkout notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage checkout notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an checkout note as seen. This should update the status
of the checkout note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59809|0   |1
is obsolete||

--- Comment #14 from Aleisha Amohia  ---
Created attachment 59828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59828=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowCheckoutNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave a checkout note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage checkout notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage checkout notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an checkout note as seen. This should update the status
of the checkout note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #41 from Liz Rea  ---
Created attachment 59827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59827=edit
Bug 14764 - [followup] Addressing QA concerns

* removed Policy:
* put the syspref in alpha order with the others
* added els to the if.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #59742|0   |1
is obsolete||

--- Comment #144 from Alex Buckley  ---
Created attachment 59826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59826=edit
Bug 17855: Follow-up on broken xt test

Apologies for missing that. Here is a patch for point 2 in
comment #133.

TEST PLAN
-
1) apply all except this patch
2) prove xt
   -- a failure
3) apply this patch
4) prove xt
   -- no failures
5) prove t
   -- only prices fails on master, and is unrelated to this patch.
6) run koha qa test tools

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #143 from Alex Buckley  ---
In the commit I have just finished (soon to be attached to bug 17855) the
following points have been addressed:

1/ I have made a new bug 18039 (assigned to myself but if someone else wants to
take it on they are more than welcome to). This bug requires the movement of
the mandatory and optional files of other languages into default directories.
Because this is a complex job it is going to take significant testing and so I
have placed the work for this in a new bug report to keep bug 17855 moving
forwards.


2/ M.Tompsetts patch has addressed this issue as the xt test now returns a
successful result of:
xt/sample_notices.t . ok
xt/single_quotes.t .. ok   
xt/tt_valid.t ... ok   
xt/verify-debian-docbook.t .. ok
xt/yaml_valid.t . ok 
All tests successful.
Files=5, Tests=90,  5 wallclock secs ( 0.05 usr  0.00 sys +  4.19 cusr  0.06
csys =  4.30 CPU)
Result: PASS


3/ I assume you mean the use pragmas at the top of the onboarding tool. If this
is the case in my most recent commit I have removed 7 more unused use pragmas.

4. I've fixed the copyright notice

5. I now include the js from categories.js, removing the duplicate js code in
onboardingstep2.tt except for the assignment of the message variables and the
enrollment_period function which is different for the onboarding tool to that
in the categories.js

6. I've fixed the indentation of js in onboardingstep3.tt. 
Due to my password_match js function being slightly different to the one in
members.js I have left that in onboardingstep3.tt additionally I have left the
form validation js code in onboardingstep3.tt as there are different fields to
validate than the memberentrygen.tt. 
Making the js form validation in members.js work for both the
onboardingstep3.tt and memberentrygen.tt can be done in a later bug as a lot of
testing would be required.

7. I have now removed summary.tt which can be added in a later bug 

8. Removed summary.pl same reason as above

9. Removed summary info same reason as above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494

--- Comment #21 from Liz Rea  ---
Cool thank you very much. Just made building a package trickier than necessary.
:)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #14 from M. Tompsett  ---
Created attachment 59825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59825=edit
Bug 18036: Followup

If you have the proof applied, do not apply this.
If you do not have the proof applied, apply this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks||18039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] New: Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Bug ID: 18039
   Summary: Move the mandatory and optional files for non-english
languages into 'default' directory so bug 17855
permits use of other languages
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 17855

At the moment after applying bug 17855 (updated web installer and onboarding
tool) users can only use Koha in English. 

This bug requires the moving of mandatory and optional files into default
directories for all other non-English languages.

The rationale for placing the work for this in a bug separate to bug 17855 is
that it is going to take a lot of testing to confirm all files have been moved
and Koha with the updated web installer and onboarding tool works with other
languages.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] Updated Koha web installer and new onboarding tool feature to guide
users through setting up Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754

--- Comment #5 from Mirko Tietgen  ---
Just had it again. The XML file is created with Catmandu. When I convert it to
mrc (with Catmandu) it works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59820|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 59824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59824=edit
Proof that all 4 cases are triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59819|0   |1
is obsolete||
  Attachment #59821|0   |1
is obsolete||
  Attachment #59822|0   |1
is obsolete||

--- Comment #12 from M. Tompsett  ---
Created attachment 59823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59823=edit
Bug 18036: All 4 cases tested

Added theme, lang, and availablethemes tests for all 4 cases.
Previously just availablethemes was tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #11 from M. Tompsett  ---
Created attachment 59822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59822=edit
Bug 18036: Full complement of testing

Added theme, lang, and availablethemes tests for all 4 cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #10 from M. Tompsett  ---
Created attachment 59821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59821=edit
Bug 18036: Replace accidentally deleted test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #9 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #8)
> Why not leave this test:
> cmp_deeply( ( C4::Templates::themelanguage(
> C4::Context->config('intrahtdocs'), 'about.tt' , 'intranet', 'fake_cgi' )
> )[2], [ 'prog' ], 'We only expect one prog here' );
> 
> The other tests do not touch the returned themes,,

Oops... Good point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #8 from Marcel de Rooy  ---
Why not leave this test:
cmp_deeply( ( C4::Templates::themelanguage( C4::Context->config('intrahtdocs'),
'about.tt' , 'intranet', 'fake_cgi' ) )[2], [ 'prog' ], 'We only expect one
prog here' );

The other tests do not touch the returned themes,,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18038] New: Generate fees per month for all patrons with a particular category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18038

Bug ID: 18038
   Summary: Generate fees per month for all patrons with a
particular category
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: PC
OS: Linux
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ing.lucia...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some libraries collect fees every month from patrons. 
By now there is no possibility to generate a fee but manually one by one.
I think maybe you can put an option where we can click it and automatically
generate the fees for the actual month for a particulary category that we can
select.
Thank you.
Regards,
Luciana.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17937] Adding item description to Twitter Summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
Generates the meta data, but can't figure out how to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #7 from M. Tompsett  ---
Thanks for the rescue, Marcel, but I was so focused on non-en, that I forgot I
was just trying to trigger the first case. Why complicate things, when simple
works?

DO NOT PUSH the proof patch. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #6 from M. Tompsett  ---
Created attachment 59820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59820=edit
Proof that all 4 cases are triggered.

Do not push!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #4 from M. Tompsett  ---
Created attachment 59818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59818=edit
Bug 18036: Perlcritic improve t/db_dependent/Templates.t

TEST PLAN
-
1) apply 17982
2) perlcritic -3 t/db_dependent/Templates.t
   -- messages
3) apply this patch
4) perlcritic -3 t/db_dependent/Templates.t
   -- OK
5) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

M. Tompsett  changed:

   What|Removed |Added

  Attachment #59767|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 59819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59819=edit
Bug 18036: All 4 cases tested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17937] Adding item description to Twitter Summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937

Baptiste  changed:

   What|Removed |Added

  Attachment #59816|0   |1
is obsolete||

--- Comment #4 from Baptiste  ---
Created attachment 59817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59817=edit
Bug 17937 deleting space around TwitterSummary in OPAC details template and add
twitter image in metatag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722

--- Comment #8 from Marcel de Rooy  ---
(In reply to David Gustafsson from comment #7)
> Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm
> quite new to Koha and marc, so I might be completely wrong, but I don't
> understand why the handling of 001 and 035a should be handled differently
> between the two. When importing a bibliographic record into Koha I would
> expect 001 to be replaced with the Koha local id, and the previous 001 moved
> to 035a.

Yeah, we were talking authorities. On several reports there was indeed
discussion about the biblionumber in 001. Until now no results yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722

--- Comment #7 from David Gustafsson  ---
Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm
quite new to Koha and marc, so I might be completely wrong, but I don't
understand why the handling of 001 and 035a should be handled differently
between the two. When importing a bibliographic record into Koha I would expect
001 to be replaced with the Koha local id, and the previous 001 moved to 035a.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17937] Adding item description to Twitter Summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937

--- Comment #3 from Baptiste  ---
Created attachment 59816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59816=edit
Bug 17937 deleting space around TwitterSummary in OPAC details template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59814|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy  ---
Created attachment 59815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59815=edit
Bug 18037: Hold notes template cleanup (from 15545)

>From the second patch of bug 15545:
Removing some unused template code related to a former approach.
Adding some changes for future extension by bug 15545.

This patch was tested by Liz Rea when the routine IsHoldNoteRequired was
called by opac-reserve.pl. The only change here is that we do not yet
call this routine; so leaving her original signoff.

Test plan:
[1] Enable OPACHoldNotes.
[2] Place a hold on a serial record. No behavior change.

Signed-off-by: Liz Rea  
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #41 from Marcel de Rooy  ---
Blocked (temporarily) in favor of bug 18037.
Actually splitting the patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||15545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545
[Bug 15545] Optionally make hold notes required when placing a hold (via
Koha::Plugin)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037
[Bug 18037] Hold notes template cleanup (from 15545)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
Summary|Working title   |Hold notes template cleanup
   ||(from 15545)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Working title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Working title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] Working title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

--- Comment #1 from Marcel de Rooy  ---
Created attachment 59814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59814=edit
Bug 18037: Hold notes template cleanup (from 15545)

>From the second patch of bug 15545:
Removing some unused template code related to a former approach.
Adding some changes for future extension by bug 15545.

This patch was tested by Liz Rea when the routine IsHoldNoteRequired was
called by opac-reserve.pl. The only change here is that we do not yet
call this routine; so leaving her original signoff.

Test plan:
[1] Enable OPACHoldNotes.
[2] Place a hold on a serial record. No behavior change.

Signed-off-by: Liz Rea  
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #142 from Owen Leonard  ---
(In reply to Alex Buckley from comment #138)

> Re: point 9: What is the final decision on summary info. To get this signed
> off and through QA are both of you happy for me to remove summary.pl and
> summary.tt. And they can be added in a separate bug?

I think this is the right thing to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #76 from Tomás Cohen Arazi  ---
Created attachment 59813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59813=edit
Bug 13757: (QA followup) Fix non-editable attrs on failed save

When a field is not editable but displayable in the OPAC, and you submit
an incomplete/wrong update, those attributes are displayed as empty.

This patch fixes that.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

--- Comment #3 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #2)
> Saved a kitten for you, Mark. But still needs some polishing..

Thanks, I'll wait for bug 17982 to get pushed, then rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #35 from David Gustafsson  ---
The previously posted version of this patch at least for me did not apply
cleanly. Rebased against current HEAD of master, and also slightly altered the
behavior of "GetMarcPermissionsAction". The previous behaviour struck me as odd
since a module with a higher specificity will always override modules with
lower, even for the case when a filter argument for a module with lower
specificity has an exact match. So for example, if we have a rule with filter
'source' => 'bulkmarcimport', and another for 'borrower' => '*', the later rule
will always have precedence, even when source is matching 'bulkmarcimport'. I
seems more flexible to have the option to override on a more specific filter
match. 

Generally I think this patch is great, and almost exactly what we need, but the
whole filter-system I think is in need of some revamping. It would be nice if
the modules where more like separate namespaces, so that one set of rules
(belonging to a certain module) was applied at once. Right now rules from
several modules might be mixed in, and field-specificity has precedence in
rules selection. The code could be simplified and optimized if rules where
grouped by module instead (and also easier to admin from a user perspective I
would believe, since rules precedence would be more obvious. But have made no
such changes in the current patch, as wanted to bring this up for discussion
before make any large breaking changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #59811|0   |1
is obsolete||

--- Comment #34 from David Gustafsson  ---
Created attachment 59812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59812=edit
Rule based permission for MARC fields

Oops, forgot to remove some temporary comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18037] New: Working title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

Bug ID: 18037
   Summary: Working title
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #57114|0   |1
is obsolete||
  Attachment #57115|0   |1
is obsolete||
  Attachment #57116|0   |1
is obsolete||
  Attachment #57117|0   |1
is obsolete||
  Attachment #57118|0   |1
is obsolete||
  Attachment #57119|0   |1
is obsolete||
 CC||glask...@gmail.com

--- Comment #33 from David Gustafsson  ---
Created attachment 59811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59811=edit
Rule based permission for MARC fields

Rebased against master as single patch. Behaviour of filter modules slightly
tweaked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59797|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 59810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59810=edit
Bug 18033: Remove duplicate code in paycollect.pl

Test plan:
0) apply the patch
1) try to pay individual fee, with full amount and partial amount
   it should work the same as before patch

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #13 from Jonathan Druart  
---
Something important: In svc/issue_notes you are not testing that the logged in
user is allowed to call this script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #12 from Jonathan Druart  
---
Aleisha,
I have rebased your patch on top of the ones I have submitted on bug 14224.
You should take a look to apply some changes, for instance:
1/ Return a to_json
2/ Check the existence of the DB columns before inserting them
3/ Use "AFTER" in the ADD column sql query (to enforce fields order)
4/ I do not think checkout_notes should be a new module. I'd say it should go
to circ
5/ Make sure the strings are translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59778|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 59809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59809=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first, update database, rebuild schema.
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowIssueNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave an issue note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage issue notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage issue
notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an issue note as seen. This should update the status
of the issue note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Allow templates from plugin directories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18010

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #14 from Jonathan Druart  
---
(In reply to Colin Campbell from comment #12)
> (In reply to Jonathan Druart from comment #10)
> > Should not we rephrase the comment without "penny", to make it more
> > international?
> 
> I think penny is fairly universal in US, Commonwealth, and Irish English
> although most are more formally cent. both are in the commit message

Ho yes sorry, I thought it was from UK only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #13 from Jonathan Druart  
---
Yes, but I was more referring to arbitrarily force the number of decimals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #12 from Colin Campbell  ---
(In reply to Jonathan Druart from comment #10)
> Should not we rephrase the comment without "penny", to make it more
> international?

I think penny is fairly universal in US, Commonwealth, and Irish English
although most are more formally cent. both are in the commit message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #80 from Jonathan Druart  
---
Thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #11 from Colin Campbell  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to M. Tompsett from comment #8)
> > NOTE: prove -v t/db_dependent/Circulation.t triggers the change.
> >   Though, all the returned amounts are 0.00 only.
> 
> Where? I did not find it.
> 
> I am not sure this is the correct way to fix it, but definitely the quicker
> and more efficient.

perldoc -q round

sprintf behaves as expected in normal round (i.e) to closest integer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/