date:20170324

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #23 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #22)
> Yes but I was wondering if it is really what we expect.
> If a checkin is 5 days late, with 2 days of fine per day of overdue and 1
> day of grace: I think it would make more sense to apply the grace on the
> total of fine days, then 5 * 2 - 1.

I would stick to the current policy. Subtract the grace period first. You
should not be fined over the grace period. Which you do if you do 5*2-1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

--- Comment #24 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #22)
> (In reply to Marcel de Rooy from comment #21)
> > [1] We now assume that the max suspension days should be applied on the
> > individual suspension, not on the accumulation. Is that a logical choice?
> > No blocker, just mentioning it.
> 
> I do not get it, what do you mean?
> There is now a pref to choose the behavior you want to apply.

If you return 10 books which result in say 3 fine days each. Is 30.
But the max suspension days is say 5.
The current logic compares 10 times 3 with 5 and says ok.
My question was: Should it be applied to the accumulation. So should we say
when it reaches 6 with the second book: Max reached?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #28 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #26)
> Comment from Colin regarding SIP (He's on leave today, so I've replied for
> him after a conversation about this yesterday):
> 
> "I think if user tries to issue the item you will see that there is a fee
> associated and the unit should take that from the user - similar to rental
> fees - we just need to check that is returned"

Martin, could you translate this for me? :)
I am not sure what you or Colin mean here.
Do you want a change, or are you comfortable with the current status?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

--- Comment #25 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #23)
> The classes of the exceptions should not be named with the module they are
> raised from.

Hmm. Just following what we already did (and approved).
Like:

package Koha::Patron::Modification;
use Koha::Exceptions::Patron::Modification;
Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw
===
package Koha::Exceptions::Patron::Modification;

'Koha::Exceptions::Patron::Modification::DuplicateVerificationToken' => {
isa => 'Koha::Exceptions::Patron::Modification',
description => "The verification token given already exists"
},
===

Please explain.
Should we formulate a coding guideline here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #24)
> Moreover I do not know if it is very safe to explode if output_pref is
> called without a defined variable.
> I can easily imagine some places where output_pref($var) is called with $var
> undefined.

Agreed. Changing status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Should biblio_metadata.biblionumber be biblioitemnumber instead?

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

--- Comment #17 from Marcel de Rooy  ---
(In reply to Olli-Antti Kivilahti from comment #13)
> The issues with (MA)chine (R)eadable (C)ard catalogues are aknowledged for
> decades. Probably even then when the format was being discussed.
> 
> Now the official formats for implementing FRBR (RDA -> Bibframe) are at the
> door and we (Finland) are already migrating to RDA this year. Actually I
> think we officially did and new records are only available in RDA as we
> speak.
> Looking forward to Bibframe in the near future.
> 
> Structuring the DB to model the separation of work from manifestation is
> fundamentally important to achieve moving Koha to the future.
> 
> Removing this distinction will turn us back 30 years.
> 
> I have already suffered from the awkwardness caused by this divide
> (biblio-biblioitems) for many years with Koha, but the problem is not with
> DB but the internal API.
> Better stick to it now, since it is the foothold for pushing us forward.
> Naturally the current implementation is not good enough, but it is better
> than nothing. Otherwise we need to reinvent this wheel.

The current implementation of biblio-biblioitems is very poor.
I agree with your argument that we should look to the future, allowing for
work, manifestation, etc.
Koha has not been designed with that in mind. Just books-items. So yes, it will
need (a lot of) attention.
But biblio-biblioitems is no good foundation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #19 from Marcel de Rooy  ---
Success, Martin. You can do it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

--- Comment #8 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60402|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 61594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61594&action=edit
Bug 17963: TT syntax for notices - Prove that AR_* are compatible

Nothing new here since bug 17962, the AR_* notice messages are quite
simple. They send the article_request, patron, biblio, biblioitem, item and
library linked to the article request.

All the fields from these 6 tables should still be accessible using the
TT syntax.

Test plan:
Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED
or AR_CANCELED.

You should manage to create a template to generate the same result as
the historical syntax.

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

--- Comment #10 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #11 from Marcel de Rooy  ---
+module   => 'Koha::Old::Checkouts',

Hope that we will rename that one..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #12 from Marcel de Rooy  ---
Created attachment 61595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61595&action=edit
Bug 17964: [QA Follow-up] Test descriptions, typo

Typo: have been checkin => checked.
And five test descriptions ;)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Marcel de Rooy  ---
In the interface I used this checkin notice:

The following items have been checked in:

[% biblio.title %]  [% old_issues.returndate %]
[% old_issues.issue_id %]

Thank you.

And it does not show me the old issues information. No date and no id.

===

If I look at sub _get_tt_params, I am having doubts if the correct old issues
record would be found when just using itemnumber as a foreign key.
Note that I repeatedly checked in and out the same item. Looking at the code, I
would expect the wrong old issue record found. Should you not look at the last
one instead of the first one? The "historical" code uses: ORDER BY timestamp
DESC in _parseletter_sth..

Another question: How do you use plural in _get_tt_params ? If we are not using
it, why add it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #14 from Marcel de Rooy  ---
And as a side note: Is this code in get_tt_params really correct:
else {# $ref eq 'ARRAY'
my $object;
if ( @{ $tables->{$table} } == 1 ) {# Param is a single key
$object = $module->search( { $pk => $tables->{$table} }
)->next();
}
else {  # Params are mutliple
foreign keys
croak "Multiple foreign keys (table $table) should be
passed using an hashref";
}
I was thinking that I could pass a few primary keys in an array (see historical
code). But this code croaks on "multiple fk's". Plus a typo :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #68 from Martin Renvoize  ---
Created attachment 61596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61596&action=edit
Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #69 from Martin Renvoize  ---
In the name of doing it properly.. I've added the tests here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #70 from Martin Renvoize  ---
I'll do the switch from find to search single in another bug as it affects
actual function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #6 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Martin Renvoize from comment #0)
> > If we're going to add it for elasticsearch, it ought to also be there for
> > zebra ;)
> 
> Hope that will not become a rule...

As is happens we were about to submit this patch anyway when the elastic
version got into master.

I'd prefer to see the configurable facets system in elastic; having this sort
of thing hard coded is not very nice, but if we are hard coding then I feel the
two search systems should stay roughly in sync to prevent a maintenance and
support nightmare.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #7 from Martin Renvoize  ---
(In reply to Tomás Cohen Arazi from comment #4)
> This is missing the index definition on the zebra files.

The definition is already present in the zebra files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Summary|Mana webservice : share and |Mana Knowledge Base : share
   |use common information  |data
   |between Kohas   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #8 from Martin Renvoize  ---
Created attachment 61597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61597&action=edit
[QA Followup] Add a facet for ccode fields to Zebra (UNIMARC)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #9 from Martin Renvoize  ---
Added UNIMARC defs as requested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #19 from Martin Renvoize  ---
This one is also on my list for today :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61596|0   |1
is obsolete||

--- Comment #71 from Martin Renvoize  ---
Created attachment 61598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61598&action=edit
Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61598|0   |1
is obsolete||

--- Comment #72 from Martin Renvoize  ---
Created attachment 61599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61599&action=edit
Bug 12026: [QA Follow-up] Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #29 from Colin Campbell  ---
(In reply to Marcel de Rooy from comment #28)
> (In reply to Martin Renvoize from comment #26)
> > Comment from Colin regarding SIP (He's on leave today, so I've replied for
> > him after a conversation about this yesterday):
> > 
> > "I think if user tries to issue the item you will see that there is a fee
> > associated and the unit should take that from the user - similar to rental
> > fees - we just need to check that is returned"
> 
> Martin, could you translate this for me? :)
> I am not sure what you or Colin mean here.
> Do you want a change, or are you comfortable with the current status?

Sip calls CanBookBeIssued and will need to be told in the return that the issue
requires a fee to be paid - It will then handle it much as it does rental fees.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] New: Reception date when receiving multiple issues for a subscription is not the good one

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Bug ID: 18327
   Summary: Reception date when receiving multiple issues for a
subscription is not the good one
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When receiving several issues for a subscription (Serials > Serial collection >
Multi receiving), the reception date is identical to the publication date
instead of being the today date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #30 from Marcel de Rooy  ---
(In reply to Fiona Borthwick from comment #27)
> (In reply to Marcel de Rooy from comment #23)
> > Just another question: If we checkout in the staff client, wouldn't it be
> > good to also show a message? A staff member could remind the patron that the
> > fee is applied now, but he does not see it happening.
> 
> I think this would be a 'nice to have' feature but not essential so perhaps
> it could be a phase 2 follow up. Items with rental fees show an alert at
> checkout so an alert would be consistent with this. However in large, busy
> public libraries for example with lots of customers collecting holds, an
> alert may be more of a hindrance.

Thx Fiona for your feedback.
A busy librarian may ignore alerts at his own responsibility. (In this case the
user has been informed when he placed the hold.)
But yes, I agree that it would be consistent to show the alert just as a rental
charge is shown under the attention label of staff checkout. And I would rather
see it on this report; it is a small change and within scope.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #1 from Colin Campbell  ---
Created attachment 61600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61600&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #2 from Colin Campbell  ---
Created attachment 61601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61601&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #3 from Colin Campbell  ---
Created attachment 61602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61602&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Colin Campbell  ---
Patches should apply to both master and 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is blocked

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160

Koha Team Lyon 3  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16787
 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Koha Team Lyon 3  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11160

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #31 from Marcel de Rooy  ---
(In reply to Colin Campbell from comment #29)
> Sip calls CanBookBeIssued and will need to be told in the return that the
> issue requires a fee to be paid - It will then handle it much as it does
> rental fees.

Thx Colin for your quick response.
There is a fundamental difference with this fee. The user cannot acknowledge it
anymore as with a rental fee. He already agreed with this fee when he placed
the hold. In other words, CanBookBeIssued does not look at it and AddIssue will
just charge the fee via MoveReserve/ModReserveFill.
But just as we show the fee on the self checkout, we need to show a message imo
on the sip terminal about the fee applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #32 from Marcel de Rooy  ---
Just for completeness:
Colin: See comment 24. The currently applied hold fee at the time of placing a
hold is not shown in SIP. I guess that placing a hold via SIP is not that
common as checking out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #41 from Lari Taskula  ---
I support moving validations into store(). Tests also need rewriting. I have
done much of this work already and would like to attach it, but we also
discussed Swagger parameter naming convention with Tomás (borrowernumber vs
patron_id, branchcode vs library_id and so on) and it should be decided and
properly implemented before moving on. Please see my e-mail in koha-devel.
Switched this Bug to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Baptiste  changed:

   What|Removed |Added

  Attachment #61357|0   |1
is obsolete||

--- Comment #13 from Baptiste  ---
Created attachment 61603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61603&action=edit
BUG 12310: Modified the tooltips

Modified the tooltips helping the users entering monrtary information in the
right format.

BUG 12310: Corrected the RegExp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18328] New: There is no history for article request

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18328

Bug ID: 18328
   Summary: There is no history for article request
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Il would be useful if the "Cancelled requests" and "Completed requests" of
articles request were kept in different tabs, just like it exists for
acquisition suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Baptiste  changed:

   What|Removed |Added

  Attachment #61603|0   |1
is obsolete||

--- Comment #14 from Baptiste  ---
Created attachment 61604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61604&action=edit
BUG 12310: Modified the tooltips

Modified the tooltips helping the users entering monrtary information in the
right format.

BUG 12310: Corrected the RegExp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Baptiste  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell  changed:

   What|Removed |Added

  Attachment #61602|0   |1
is obsolete||

--- Comment #5 from Colin Campbell  ---
Created attachment 61605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61605&action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #6 from Colin Campbell  ---
Created attachment 61606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61606&action=edit
proposed patch

Add test for new method added to line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Séverine Queune  ---
The patch 13205 apply perfectly.
There is no problem jumping from any page to first/last/next/previous page on
OPAC or staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61375|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 61607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61607&action=edit
Bug 16757 - Add ability to pay fee by id for SIP2

The SIP protocol allows for a Fee Paid message to specify a fee
identifier in the CG field. While this field is read and passed to
C4::SIP::ILS::pay_fee, it is not passed along to
C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We
should enable this functionality in Koha now that accountlines each have
a unique identifier that can be passed along to the payment requestor
via the AV field line items added by bug 14512.

Test Plan:
1) Create a fee in Koha
2) Ensure your SIP2 server is running and configured correctly
3) Send a 37 Fee Paid message to Koha's SIP server with the
   accountlines_id for that fee in the CG fee identifier field,
   along with the other required fields.
4) Note that specific fee was paid in Koha

Signed-off-by: Rhonda Kuiper 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61376|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 61608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61608&action=edit
Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing

Signed-off-by: Rhonda Kuiper 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #15 from Koha Team Lyon 3  ---
I'm testing now.
Looks goog but I haven't finished yet.
But It should be extended to this page : /cgi-bin/koha/admin/aqbudgets.pl
/cgi-bin/koha/members/mancredit.pl
and /cgi-bin/koha/members/maninvoice.pl? as well
Perhaps in cgi-bin/koha/acqui/neworderempty.pl too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

--- Comment #13 from Marcel de Rooy  ---
QA Comment:
Looks good to me. Tested fee paid with and without accountlines id.
The cli emulator looks ok, but did not test it; rather run a test file like
t/db_dependent/SIP/Message.t or so :)

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18329] New: Batch record deletion broken

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329

Bug ID: 18329
   Summary: Batch record deletion broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).

Looks like it is because of Bug 18242 which added a transaction  in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18329] Batch record deletion broken

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||18242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242
[Bug 18242] Remove primary key on old_issues.issue_id
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||18329


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
[Bug 18329] Batch record deletion broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18329] Batch record deletion broken

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18330] New: REST API: Date-time handling

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Bug ID: 18330
   Summary: REST API: Date-time handling
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lari.task...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Swagger2 wants dates and date-times as defined in RFC3339,
https://xml2rfc.tools.ietf.org/public/rfc/html/rfc3339.html#anchor14

Make sure each object property has a format date or date-time defined where
needed.

We should include information on time zone and use an appropriate separator "T"
between date and time, e.g.:
2017-03-24T14:00:00+02:00
2017-03-24T12:00:00Z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Marcel de Rooy  ---
Question raised while testing:

Why does sub pay in C4/SIP/ILS/Transaction/FeePayment.pm contain this check:
if ( $fee && $fee->amountoutstanding == $amt ) {

If I am paying a partial amount in the interface, this is allowed too. But note
that it is not possible to writeoff a partial amount in the interface.
I tried a partial writeoff in testing this patch and I wondered why I got a N
in the response. But the cause is this test. I think we should print a message
why we refused the payment.

While I understand that you refuse it for a writeoff, I do not understand it
for another payment type. And thats where I can tie it to this report: Should
this check be applied only to the writeoffs ?

In summary I propose two changes:
[1] Send a message why you refuse a partial payment for writeoffs.
[2] Accept a partial payment for other types.

Changing status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #7 from Marcel de Rooy  ---
Last one :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

--- Comment #8 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #4)
> I get an empty file no matter what I do. Tried with a 'biblios' file with
> valid biblionumbers, tried renaming to 'biblios.txt' and even tried without
> a file. The result is always an empty .mrc file.

Problem reproduced.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61434|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 61609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61609&action=edit
Bug 18312: Fix export unless a file is supplied

Bug 18087 breaks export unless a file is supplied.

Can't use an undefined value as a HASH reference at
/home/vagrant/kohaclone/tools/export.pl line 75.

Test plan:
Export records using a file of id that is not a valid file (not txt or
csv)
Export records using a valid file
Export records without supplying a file

=> The export should work or fail as expected.

Signed-off-by: Jesse Maseto 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #20 from Baptiste  ---
Created attachment 61610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61610&action=edit
BUG 18110: Corrected display address format

- minor changes on address format
- corrected member-password so that steetnumber is given to the template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #21 from Baptiste  ---
I corrected the display of streetnumber in this ticket, I don't think it's
necessary to open a new ticket just for one code line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #28 from Katrin Fischer  ---
It appears that if you actually translate the file by having a translated
version of the string 

%s %s %s %s "%s %svon %s%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s",
"%s", "%s", "%s" 

then the csv export is broken again because the line breaks in
itemsearch_item.csv.inc get destroyed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #29 from Katrin Fischer  ---
Easiest way to test: Install German, look for the string (search for the file
name), mark it as 'fuzzy' - Export works, remove 'fuzzy' - export is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #16 from Koha Team Lyon 3  ---
I repeat tests proposed by Marc in Comment 5  :

With syspref DigitSeparator : ",."

CHF 1.45 -> 1.45 OK
12.50$ -> 12.50 OK
199 -> 199.00 OK
1'345.95 -> 1345.95 OK (Switzerland)

With syspref DigitSeparator : "."

12,34,567.89 -> 1234567.89 OK (Pakistan, India)
12,34,567 -> 1234567.00 OK
1 234 567,89 -> 123456789.00  OK (Germany...)

With syspref DigitSeparator : ","
1.234.567,89 -> 1234567.89  
1.234.567 -> 1234567.00 

Calculations are good but I don't want to sign-off this patch before the other
pages are done (see comment 15)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18331] New: Export csv in item search, exports all items in one line (see Bug 16914)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331

Bug ID: 18331
   Summary: Export csv in item search, exports all items in one
line (see Bug 16914)
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

CSV exports of late orders and item search are broken again if you are using
them from a 'complete' translation.

The theory is that if the strings are not translated, then the file is only
copied (preserves line breaks) and not translated (kills line breaks). 

Both late orders and item search csv expots are effected.

For item search there is one string in itemsearch_item.csv.inc:

%s %s %s %s "%s %svon %s%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s",
"%s", "%s", "%s" 

Easiest way to test: 

- Install German
- Test CSV export - it should be broken.
- Look for the strings in itemsearch_item.csv in the staff po file and
"untranslate" them. This is easiest done by adding "fuzzy".
- Reinstall German
- CSV shoudl be fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18331] Export csv in item search, exports all items in one line ( see Bug 16914)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||16914


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914
[Bug 16914] Export csv in item search, exports all items in one line
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||18331


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331
[Bug 18331] Export csv in item search, exports all items in one line (see Bug
16914)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

--- Comment #30 from Katrin Fischer  ---
Filed bug 18331 for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Eric  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||eric.gosseli...@gmail.com

--- Comment #36 from Eric  ---
Patch didn't apply, 

Some problems occurred applying patches from bug 14272:
Something went wrong !Applying: Bug 14272: Show single news item
(tests)
Applying: Bug 14272: Show single news item (backend)
Using index info to reconstruct a base tree...
M   C4/NewsChannels.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/NewsChannels.pm
CONFLICT (content): Merge conflict in C4/NewsChannels.pm
Patch failed at 0001 Bug 14272: Show single news item (backend)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #15 from Benjamin Rokseth  ---
(In reply to Marcel de Rooy from comment #14)
> Please look at this:
> 
> if ($messages->{NeedsTransfer}) {
> $self->{item}->destination_loc($messages->{NeedsTransfer});
> $self->alert_type('04');# send to other branch
> }
> if ($messages->{WasTransfered}) { # set into transit so tell unit
> $self->destination_loc($iteminformation->{homebranch});
> $self->alert_type('04');# send to other branch
> }
> 
> You changed NeedsTransfer, but you did not touch WasTransfered here.
> That is the reason why I saw the CV04 without CT.
> Please change and set back to Needs Signoff. A fresh signoff would not be
> bad.

this must be a lost commit, will make a new patch and set back to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244

--- Comment #7 from Marc Véron  ---
Created attachment 61611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61611&action=edit
Re-testing same settings as in screenshot comment #5

(In reply to Christopher Brannon from comment #4)
> I've cleared cache, restarted apache2, restarted memcache, restarted all
> (restart_all), no luck.
> 
> I'm using the demo layout that installed with Koha, and just editing the 2nd
> field to read "Address: "
> 
> I go to manage Card batches and on my one patron I click Export.  When I
> open the pdf, I still see .
> 
> I will attach my screen shots.

I repeated with your settings, it works as expected (see screenshot attached).
After taking the screenshots, I tested with other B_-fields as well, e.g.
, they display as expected.

It did not work immediately after applying the patch, I had to re-start Plack
and to reload the page for batch management. Tested with single export and with
export of entire batch.

Hmm, where is the difference...?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312

--- Comment #10 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Tomás Cohen Arazi from comment #4)
> > I get an empty file no matter what I do. Tried with a 'biblios' file with
> > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without
> > a file. The result is always an empty .mrc file.
> 
> Problem reproduced.

I do not understand, Tomas is saying that the patch is buggy, you confirmed,
but PQA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244

--- Comment #8 from Christopher Brannon  ---
> I repeated with your settings, it works as expected (see screenshot
> attached). After taking the screenshots, I tested with other B_-fields as
> well, e.g. , they display as expected.
> 
> It did not work immediately after applying the patch, I had to re-start
> Plack and to reload the page for batch management. Tested with single export
> and with export of entire batch.
> 
> Hmm, where is the difference...?

Don't know.  I've tried everything I know. Don't know why loading a patch
should be this difficult.  I even tried another browser.  If it is sticking
anywhere, it is on the server side, not the browser, since the change is not
reflected in a new browser.  I'll keep beating up on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306

Owen Leonard  changed:

   What|Removed |Added

  Component|Circulation |OPAC
   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502

--- Comment #27 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #25)
> (In reply to Jonathan Druart from comment #23)
> > The classes of the exceptions should not be named with the module they are
> > raised from.
> 
> Hmm. Just following what we already did (and approved).
> Like:
> 
> package Koha::Patron::Modification;
> use Koha::Exceptions::Patron::Modification;
> Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw
> ===
> package Koha::Exceptions::Patron::Modification;
> 
> 'Koha::Exceptions::Patron::Modification::DuplicateVerificationToken' => {
> isa => 'Koha::Exceptions::Patron::Modification',
> description => "The verification token given already exists"
> },
> ===
> 
> Please explain.
> Should we formulate a coding guideline here?

We might need to.

I think the thing with the exceptions you add is:
- There's no need to have them tied to output_pref, they could jus tbe
top-level for the DateUtils namespace. Remember when you catch them, you have
the context in which it happened and can build the needed actions.
- The ones you add should be general exceptions: WrongParameters,
MissingParameters, InvalidParamType. Keep in mind that you can use them like
this:

  Koha::Exceptions::InvalidParamType->throw('DateTime object expected');
  Koha::Exceptions::WrongParameters->throw('Conflicting parameters dt and str
passed');

instead of baking a too specific exception.

Regarding the Patron modification ones, I found that patron modification tokens
were too specific, and they deserved its own exception. But it might be subject
to future changes if someone raises it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #10 from Martin Renvoize  ---
Created attachment 61612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61612&action=edit
Furher UNIMarc Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #15 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #13)
> In the interface I used this checkin notice:
> 
> The following items have been checked in:
> 
> [% biblio.title %]  [% old_issues.returndate %]
> [% old_issues.issue_id %]
> 
> Thank you.
> 
> And it does not show me the old issues information. No date and no id.

I will take a look.

> If I look at sub _get_tt_params, I am having doubts if the correct old
> issues record would be found when just using itemnumber as a foreign key.
> Note that I repeatedly checked in and out the same item. Looking at the
> code, I would expect the wrong old issue record found. Should you not look
> at the last one instead of the first one? The "historical" code uses: ORDER
> BY timestamp DESC in _parseletter_sth..

Same.

> Another question: How do you use plural in _get_tt_params ? If we are not
> using it, why add it?

You should take a look at the whole enhancement, tree of dependencies.
If you take a look bug 17981, which is almost the top of the tree, you will see
all the deps. There is a remote branch to see all patches applied. I think it's
important to have this overview in mind before QAing separately the different
bug reports.
It is hard to make a such big tree and trying to reflect what you are trying to
do on all the different steps.

(In reply to Marcel de Rooy from comment #14)
> And as a side note: Is this code in get_tt_params really correct:
> else {# $ref eq 'ARRAY'
> my $object;
> if ( @{ $tables->{$table} } == 1 ) {# Param is a single
> key
> $object = $module->search( { $pk => $tables->{$table} }
> )->next();
> }
> else {  # Params are
> mutliple foreign keys
> croak "Multiple foreign keys (table $table) should be
> passed using an hashref";
> }
> I was thinking that I could pass a few primary keys in an array (see
> historical code). But this code croaks on "multiple fk's". Plus a typo :)

That could be implement later, I just implemented what I used. During the whole
process I did not need it. Maybe later?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18322] Add facets for ccode to zebra

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #11 from Tomás Cohen Arazi  ---
I expected to see something like:

  
ccode:0
  

in biblio-koha-indexdefs.xml for MARC21 and NORMARC (and the corresponding
field/subfield for UNIMARC). And then have the biblio-zebra-indexdefs.xsl file
get re-generated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #16 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #15)
> (In reply to Marcel de Rooy from comment #13)
> > In the interface I used this checkin notice:
> > 
> > The following items have been checked in:
> > 
> > [% biblio.title %]  [% old_issues.returndate %]
> > [% old_issues.issue_id %]

TT syntax uses old_checkouts. Take a look at unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244

--- Comment #9 from Christopher Brannon  ---
Are you testing the patch on a dedicated test server, or are you using
kohadevbox?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244

--- Comment #10 from Marc Véron  ---
Not kohadevbox. It's a VM with an install from packets that I gitified. Current
version is 16.12.00.015

Just an idea because I remember a similar situation:
What happens if you edit the patched C4/Patroncards/Patroncard.pm file and
intentionally insert some errors in order to make it crash? - Can you provoke
the crash or does export still behave as before?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647

Eric  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||eric.gosseli...@gmail.com

--- Comment #5 from Eric  ---
Patch doesn't apply

Some problems occurred applying patches from bug 15647:
Something went wrong !Applying: Bug 15647: Allow selection of
destination email address for print overdue notices
Using index info to reconstruct a base tree...
Koha/Library.pm
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
misc/cronjobs/overdue_notices.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/overdue_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging Koha/Library.pm
Patch failed at 0001 Bug 15647: Allow selection of destination email address
for print overdue notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18329] Batch record deletion broken

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 61613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61613&action=edit
Bug 18329 - Batch record deletion broken

Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).

Looks like it is because of Bug 18242 which added a transaction  in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;

This patch fixes by using also Koha::Schema in batch_delete_records to manage
transaction.
It also removes "$dbh->{RaiseError} = 1", this behavior is managed in
Koha::Database.

Test plan :
 - Go to Staff interface : Tools > Batch record deletion
 - Enter a few existing biblionumbers
 - Click on "Continue"
 - Click on "Delete selected records"
=> Without patch you get a DB error
=> With patch you get confirmation message
 - Try to get the biblios to confirm they are deleted :
/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
 - Test with and without Plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18329] Batch record deletion broken

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244

--- Comment #11 from Christopher Brannon  ---
Throwing stray text into the file you patched doesn't seem to effect anything. 
I know my test environment is working, as I can apply another patch and see the
effects of it right away.  We're missing something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8266] remove location from pull down on search

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #32 from Jonathan Druart  
---
Created attachment 61615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61615&action=edit
Bug 17762: Add the new TranslateNotices syspref

This whole patch set adds the ability to translate notices in different
languages.
That way, if a library has patrons from different countries, they will
not have to send the notices in only one language but they will be able to
translate them.

Test plan:
- Switch on TranslateNotices
- Translate the interface in different languages
- Edit patron's details
=> You should see a new "prefered language" entry
That language will be used to send notices to this patron
- Edit several notice templates
=> You should see different tabs, 1 tab per language translated at the
opac (which sounds to make sense)
- Now the notice generated for this patron should be the one translated
in the language picked for him
To confirm that, try to generate several notices for this patron.
If the notice is not translated, the default one should be used.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #34 from Jonathan Druart  
---
Created attachment 61617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61617&action=edit
Bug 17762: Remove FK on message_transports

I don't really understand where does come from this foreign key but at first
glance it does not make sense.

Note that it seems we could also remove message_transports.branchcode

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #33 from Jonathan Druart  
---
Created attachment 61616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61616&action=edit
Bug 17762: Add the lang attribute to the patron form

Not the opac because we do not want the patron to modify it, they won't
be necessary translated.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #59452|0   |1
is obsolete||
  Attachment #59453|0   |1
is obsolete||
  Attachment #59454|0   |1
is obsolete||
  Attachment #59455|0   |1
is obsolete||
  Attachment #59456|0   |1
is obsolete||
  Attachment #59457|0   |1
is obsolete||
  Attachment #59458|0   |1
is obsolete||
  Attachment #59459|0   |1
is obsolete||
  Attachment #59460|0   |1
is obsolete||
  Attachment #59461|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 61614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61614&action=edit
Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #37 from Jonathan Druart  
---
Created attachment 61620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61620&action=edit
Bug 17762: Send lang to GetPreparedLetter

This patch set the lang parameter when C4::Letters::GetPreparedLetter is
called to generate the notice.
Note that we do not need to pass it if want_librarian is set.

TODO: I do not know what to do with TransferSlip

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #35 from Jonathan Druart  
---
Created attachment 61618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61618&action=edit
Bug 17762: Add lang to the PK of letter

We need to enlarge the PK of the letter table.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #36 from Jonathan Druart  
---
Created attachment 61619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61619&action=edit
Bug 17762: Update the letter form interface

If the pref is on, the notice template will be translatable in different
languages

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #38 from Jonathan Druart  
---
Created attachment 61621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61621&action=edit
Bug 17762: Add the lang parameter to C4::Letters::getletter

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #39 from Jonathan Druart  
---
Created attachment 61622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61622&action=edit
Bug 17762: Fix sql fields insertion

The "Insert ->" buttons used to copy the sql field to the textarea was
based on the id of the fieldset.
This id has to be unique to work as expected. It is now composed of mtt
+ lang instead of mtt only

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #40 from Jonathan Druart  
---
Created attachment 61623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61623&action=edit
Bug 17762: Fix test for NewsChannels.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17762] Ability to translate notices

2017-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

--- Comment #42 from Jonathan Druart  
---
Rebased and fixed a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 141 matches

Mail list logo