[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Magnus Enger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||mag...@libriotech.no

--- Comment #11 from Magnus Enger  ---
There have been a lot of long discussions, but as far as I can tell, these
bugs:

Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 minor, P5 -
low, ---, kyle.m.hall, CLOSED FIXED, Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 enhancement,
P5 - low, ---, alex.arnaud, RESOLVED FIXED, Change date calculation for reserve
expiration to skip all holidays

have changed things enough that it now makes sense to revive the current
bug/patch. I have made a similar change on my live server and customers are
happy with it. 

I am setting the status to "Signed off". Please set it to "Needs signoff" you
think that is necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Marc Véron  changed:

   What|Removed |Added

  Attachment #65529|0   |1
is obsolete||

--- Comment #18 from Marc Véron  ---
Created attachment 66263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66263&action=edit
Bug 12691: Use Koha.Preference in Self-Checkout

For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns,
OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Marc Véron  changed:

   What|Removed |Added

  Attachment #65528|0   |1
is obsolete||

--- Comment #19 from Marc Véron  ---
Created attachment 66264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66264&action=edit
Bug 12691: [FOLLOW-UP] Follow-up patch

This patch fixes merge conflicts and fixes the problems in Comment 7

QA tools complain about missing bracket, will be fixed in next followup
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Marc Véron  changed:

   What|Removed |Added

  Attachment #66252|0   |1
is obsolete||

--- Comment #20 from Marc Véron  ---
Created attachment 66265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66265&action=edit
Bug 12691: [FOLLOW-UP] Missing bracket

Patch adds bracket to template file (Comment 16)

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #64 from Alex Sassmannshausen 
 ---
Created attachment 66266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66266&action=edit
Bug 7317: Only allow cancellation request when status is new.

* Koha/Illrequest.pm (_core_status_graph): Update status graph.
* koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Only
  show button when status is NEW.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19016] Add a script to fix corrupted data

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016

Krishna K  changed:

   What|Removed |Added

 CC||krishna.moorth...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Nick Clemens  changed:

   What|Removed |Added

Summary|[OMIBUS] MySQL 5.7  |[OMNIBUS] MySQL 5.7
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

  Attachment #63593|0   |1
is obsolete||

--- Comment #53 from Julian Maurice  ---
Created attachment 66267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66267&action=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
--
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

  Attachment #63595|0   |1
is obsolete||

--- Comment #55 from Julian Maurice  ---
Created attachment 66269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66269&action=edit
Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved

Since bug 14695 it is possible to reserve more than one item per biblio

Also fix bad use of $item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

  Attachment #63594|0   |1
is obsolete||

--- Comment #54 from Julian Maurice  ---
Created attachment 66268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66268&action=edit
Bug 11999: Check for age restriction in CanBookBeReserved

+ improve t/db_dependent/Reserves.t to make tests pass on UNIMARC
installation

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #56 from Julian Maurice  ---
Created attachment 66270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66270&action=edit
Bug 11999: Remove the "biblio already reserved" check in CanItemBeReserved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #57 from Julian Maurice  ---
All patches rebased on master.
The last patch should fix comment 52

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5= Use restrictions)? Place a hold for reference?

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

--- Comment #23 from Marcel de Rooy  ---
Bug 18980 has been pushed. This bug can be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

Marcel de Rooy  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

--- Comment #30 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #29)
> Hi Marcel and Kyle, what's needed to get this moving again? 
> Would love to be able to exclude the internal notes from being indexed (bug
> 15050)
Hard to say.

Another question is: If we exclude field A from Zebra, do we need to exclude it
from ElasticSearch too ? If we add a pref or a config var, it is on the
instance level. We probably don't want it to be on search engine level ?

Nick: Could you please report the current status of Elastic in this regard? How
can I exclude a specific field from indexing per INSTANCE in Elastic now ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #6 from Marcel de Rooy  ---
(In reply to Aleisha Amohia from comment #3)
> (In reply to Marc Véron from comment #2)
> > What happens if a library has modified the note? - Modifications for title
> > and content would get lost with the following statement in 
> > bug_18915_-_modifying_patron_note_notice.sql 
> > 
> > UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set
> > by patron', title = 'Checkout note', content = '<>
> > <> has added a note to the item <> -
> > <> (<>).' WHERE code = 'PATRON_NOTE';
> 
> I see what you mean, but this patch is fixing the content of the note, so it
> does need to be changed. Unless you can think of another way to fix the note?

Aleisha,
Could you fix the note by just a SQL replace for the wrong field?
UPDATE table SET field = REPLACE(field ,from_str, to_str) etc etc
So look for biblio.item only and replace that by biblio.title.
If the library changed the note and fixed it already, there will be no problem.

Please adjust this entry too:
installer/data/mysql/updatedatabase.pl:VALUES ('circulation',
'PATRON_NOTE', '', 'Patron note on item', '0', 'Patron issue note',
'<> <> has added a note to the item
<> - <> (<>).','email');

And do not forget to add PATRON_NOTE (or CHECKOUT_NOTE) to 
installer/data/mysql/en/mandatory/sample_notices.sql
It does not occur yet..

Thanks !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #31 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #30)
> (In reply to Katrin Fischer from comment #29)
> > Hi Marcel and Kyle, what's needed to get this moving again? 
> > Would love to be able to exclude the internal notes from being indexed (bug
> > 15050)
> Hard to say.
> 
> Another question is: If we exclude field A from Zebra, do we need to exclude
> it from ElasticSearch too ? If we add a pref or a config var, it is on the
> instance level. We probably don't want it to be on search engine level ?
> 
> Nick: Could you please report the current status of Elastic in this regard?
> How can I exclude a specific field from indexing per INSTANCE in Elastic now
> ?

I would say yes, if excluding from Zebra we should exclude from Elastic, I am
having a hard time thinking of a reason you would only want to exclude form one
search engine.

Currently ES implementation doesn't support this, we push the entire record
into the '_all' field.

Catmandu fixes do allow exclusion of fields I believe, so we should be able to
add the ability to exclude fields into the configuration section, or in a
syspref, to allow this per instance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Do we need recurring irregularities in Serials ?

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #6 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #5)
> Thread: https://lists.katipo.co.nz/pipermail/koha/2017-June/048380.html
> 
> Sadly no comments so far. So it's Lyon 3 and me so far considering this a
> bug, maybe enough?

We can wait a little bit more :) Good things take time..
Hope to address this later, having some more feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

Marc Véron  changed:

   What|Removed |Added

  Attachment #63611|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

Marc Véron  changed:

   What|Removed |Added

  Attachment #63611|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #32 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #30)
> (In reply to Katrin Fischer from comment #29)
> > Hi Marcel and Kyle, what's needed to get this moving again? 
> > Would love to be able to exclude the internal notes from being indexed (bug
> > 15050)
> Hard to say.
> 
> Another question is: If we exclude field A from Zebra, do we need to exclude
> it from ElasticSearch too ? If we add a pref or a config var, it is on the
> instance level. We probably don't want it to be on search engine level ?
> 
> Nick: Could you please report the current status of Elastic in this regard?
> How can I exclude a specific field from indexing per INSTANCE in Elastic now
> ?

Definitely worth re thinking on ES as we could have separate indexes for
intranet and OPAC. Filtering should be achieved using the record processor
filter over MARC records we already have, before sending for indexing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #33 from Katrin Fischer  ---
I think with Zebra separate complete indexes would need twice as much space,
that might be an issue for bigger installations. Also needs separate reindexing
etc. Using the record filter would require that. 
Having some indexes separate for intranet/staff might be less resource
intensive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

--- Comment #10 from Marc Véron  ---
Created attachment 66271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66271&action=edit
Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

New version based on Koha.Preference TT plugin as of comment #7
Depends on Bug 12691

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Chris Slone  changed:

   What|Removed |Added

 CC||cslone@camdencountylibrary.
   ||org

--- Comment #1 from Chris Slone  ---
I know this bug is a little old now, but it is still pertinent. If you have an
item type that cannot be viewed on the OPAC it still shows up in the facets.
For example, we have an Interlibrary Loan item type that is not visible on the
OPAC, but it appears in the facets when it meets the criteria of the search.
Clicking on this item type will bring you to an error message. It's confusing
to the patron and/or gives the impression that there are problems with the
OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65279|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 66274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66274&action=edit
Bug 17989: Include full path logic in _get_template_file

Similar to the full path test in sub themelanguage, this patch makes a
change in _get_template_file. This allows you to pass a template
outside the modules directory to get_template_and_user. (Note: the sub
badtemplatecheck already blocks bad paths.)

Especially, this would be helpful for plugins using templates. As can be
seen in Templates.pm, a change was made earlier to overwrite the filename
for a plugin in sub gettemplate. This exception can now be removed.

Also note the small change in Koha/Plugin/Base.pm; mbf_path is already
absolute and if we pass a full path, we do not need it. This allows use of
a regular Koha template or a shared template between plugins (as long as
badtemplatecheck allows the path).

What are the side-effects of this change?
[1] We should not pass absolute paths if we mean relative ones.
A follow-up patch deals with one occurrence in the codebase.
No regressions for regular use.
[2] Plugins can call get_template_and_user directly or go via get_template
in Koha/Plugin/Base (absolute paths don't go via mbf_path).

Note: replaced two single quotes in Auth.pm to show template name in test
description.

Test plan:
[1] Open some page on OPAC or staff client to trigger a template.
[2] Run t/db_dependent/Auth.t to verify not allowing some bad templates.
[3] Run t/db_dependent/Templates.t to verify an absolute path.
[4] Run t/db_dependent/Plugins.t to verify using templates in a plugin.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65278|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 66273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66273&action=edit
Bug 17989: Extend bad template check

The check is now extended by only allowing templates from the regular
Koha template directories and additional plugin directories as defined
in koha-conf.xml.

Note: In order to prevent an uninitialized warning on $theme from sub
themelanguage for a not-existing file, I added a trivial assignment. Will
get further attention in a follow-up.

Test plan:
[1] Run t/db_dependent/Auth.t
[2] Run t/db_dependent/Templates.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65277|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 66272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66272&action=edit
Bug 17989: Centralize bad template check

The bad template check in get_template_and_user can be removed, since
this check has been added in gettemplate on bug 18010.

The check moves here to a new sub in C4::Templates. And will be extended
in a follow-up.

Removed unused variable $path in gettemplatefile.

Test plan:
[1] Run t/db_dependent/Auth.t (get_template_and_user bad calls).
[2] Run t/db_dependent/Templates.t (bad call to gettemplate).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65280|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 66275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66275&action=edit
Bug 17989: Resolve "verbatim paragraph in NAME section" warning in
C4::Templates

*** WARNING: Verbatim paragraph in NAME section at line 28 in file
C4/Templates.pm

Test plan:
Run podchecker on C4::Templates and verify that the warning is resolved.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

--- Comment #11 from Marcel de Rooy  ---
Trivial rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65281|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 66276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66276&action=edit
Bug 17989: Final changes

[1] The template sco/printslip.tt is in the regular modules directory.
Should not be prefixed with a slash.
[2] Script svc/members/search gets its template path from a URL parameter.
When you git grep json_template, you will have an idea what values it
should receive.

Test plan:
[1] Go intranet home page. Search for patrons in the combo box. Results?
[2] Try the URL /cgi-bin/koha/svc/members/search. Should trigger a 500
error with Bad template path in the logs.
[3] Try to find another occurrence just like the one corrected in
sco/printslip.pl where an absolute path is passed to gettemplate or
get_template_and_user. I already tried several regex variations
while git grepping template_name, but you may still find one..

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5534] Koha does not ignore punctuation when searching

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

--- Comment #17 from dgui...@lcg.org ---
We originally installed Koha around May or June of 2016 and would have been on
the 3.22 version that was released at that time. We used defaults for
everything as far as I remember and it appears that we're using Zebra. Is it
possible to switch to ElasticSearch and is it fairly involved to do so? Are
there any other considerations to take into account before doing so? Is
ElasticSearch production-ready?

Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64952|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 66277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66277&action=edit
Bug 17380: Add some checks around Authorities::Types->find

Resolves:
Use of uninitialized value $biblio_fields in scalar chop at
authorities/detail.pl line 212.
Can't call method "authtypetext" on an undefined value at authorities/detail.pl
line 216.
Can't call method "authtypecode" on an undefined value at authorities/detail.pl
line 180.

NOTE: Some of these problems have actually been resolved now by bugs 18801
and 18811, but it is still better imo to have these checks.

Test plan:
[1] Verify unchanged behavior. Search for some authorities on authorities.pl
and click on the details of a record.
[2] Open an authorities detail page and change the authid in the URL to a
not existing number. Instead of an internal server error, you should see
a message like "The authority record you requested does not exist".

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64953|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 66278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66278&action=edit
Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority

If we got an authtypecode from the database and this value is not NULL
since the table column does not allow it, there is no need to call
GuessAuthTypeCode for empty string (read: Default framework) in the
sub get_from_authid.

Furthermore, we remove three Koha::MetadataRecord::Authority->new calls.
They are useless, since we do not pass a record. It just generates:
  No record passed at authorities/merge.pl line 96.
  Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66.
Instead we throw an ObjectNotFound exception.

Test plan:
[1] Run t/db_dependent/Koha_Authority.t
[2] Interface will be tested in the following patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64954|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 66279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66279&action=edit
Bug 17380: Graceful resolution of missing reporting tag in merge

Altough this patch deals with a mostly hypothetical case and this report
makes it practically impossible anymore to merge with records in the
Default framework (having no reporting tag), we can make the code of
sub merge still a bit more robust here.

If you would merge biblio records from one authtype to another and the new
framework would not have a reporting tag, before this patch the result would
be data loss. Merge would handle this request as a delete. This patch makes
merge handle it differently: instead of clearing the biblio records, it
keeps $a and $9 in order to make a future corrective merge possible.

Note: The additional condition on line 1468 for $tags_using_authtype
makes sure that we do not select all fields when the authtype should
unexpectedly be empty string (Default). This prevents crashing on
a "Control fields do not have subfields" error.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64955|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 66280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66280&action=edit
Bug 17380: Do not allow Default template in merge form

This patch makes the following changes:
[1] Removes Default from the template list. We should not merge with the
Default framework, since it does not have a reporting tag.
[2] Rearranges the error section in the template. It is confusing to have
two error sections in this template. The error CANNOT_MOVE is not used.
The error FRAMEWORK_NOT_SELECTED is replaced by WRONG_FRAMEWORK.
[3] Do not allow to merge a record with itself.
[4] Check if the merge reference record still contains any MARC tags.
[5] Additional polishing: Simplify passing frameworks to template. Remove
an unused Koha::Authority::Types->search. Remove obsolete POD header
for functions from the script.

Test plan:
[1] Select two authorities to merge. Verify that you cannot select Default
anymore as framework for the reference record.
[2] Reproduce error WRONG_COUNT by adding another authid=999 in the URL
after you selected two authority records for merging.
[3] Remove the third authid from the URL and change the first or second
authid into an unexisting record id. You should generate an Internal
Server Error. The log should show the exception message.
[4] Merge two authorities. Deselect all MARC tags. Should trigger the
error EMPTY_MARC in the template.
[5] Select the same authority record twice for merging. Should trigger the
error DESTRUCTIVE_MERGE in the template.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

--- Comment #13 from Marcel de Rooy  ---
Trivial rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990
[Bug 18990] Overdue Notices are not sending through SMS correctly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS correctly

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Nick Clemens  changed:

   What|Removed |Added

 Depends on||18478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478
[Bug 18478] Some notices sent via SMS gateway fail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

--- Comment #3 from Jon Knight  ---
Created attachment 66281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66281&action=edit
Add quantity field to the opac suggestions form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Jon Knight  changed:

   What|Removed |Added

  Attachment #65767|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66254|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 66282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66282&action=edit
[SIGNED OFF] Bug 18046 CAS logout infinite redirect

To test (You need a CAS server and CAS configured in Koha)

1/ Login using CAS in Koha
2/ Logout in Koha
3/ Notice you get redirected again and again
4/ Apply patch
5/ Login with CAS, then logout
6/ Notice logout works, but no longer infinitely redirected

Signed-off-by: Katrin Fischer 
Patch has been in production use for several months
on several instances. Fixes a critical bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Jon Knight  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Jon Knight  ---
New version of the patch uploaded, hopefully this time in the correct format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19160] New: CAS Single Log Out

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Bug ID: 19160
   Summary: CAS Single Log Out
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

CAS allows not only Single Sign On, but also Single Log out. 

Specification:
https://apereo.github.io/cas/5.0.x/protocol/CAS-Protocol-Specification.html#233-single-logout

2.3.3 Single Logout

The CAS Server MAY support Single Logout (SLO). SLO means that the user gets
logged out not only from the CAS Server, but also from all visited CAS client
applications. If SLO is supported by the CAS Server, the CAS Server MUST send a
HTTP POST request containing a logout XML document (see Appendix C) to all
service URLs provided to CAS during this CAS session whenever a Ticket Granting
Ticket is explicitly expired by the user (e.g. during logout). CAS Clients that
do not support the SLO POST requests MUST ignore these requests. SLO requests
MAY also be initiated by the CAS Server upon TGT idle timeout.

Koha currently doesn't support this, but it should in order to improves patron
privacy and data security.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19160] CAS Single Log Out

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ch...@bigballofwax.co.nz
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19161] New: asdsad

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19161

Bug ID: 19161
   Summary: asdsad
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: retasbro...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 66283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66283&action=edit
asdasd

asdasdsada

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #104 from M. Tompsett  ---
I would very much appreciate testing and feedback, while I attempt to make a
more complete test plan.

Apply 19040 first.
Then this. Then test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66216|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 66284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66284&action=edit
Bug 2946: Added some missing logic

The norequests logic affects the opac-details-sidebar.inc logic
which is shared in ISBD and MARC views. It is correct in ISBD
and this brings it into MARC detailed view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5062] Acq terminology: list price, ordering price, vendor price, RRP

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5062

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19160] CAS Single Log Out

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

--- Comment #1 from Chris Cormack  ---
Created attachment 66285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66285&action=edit
Bug 19160 CAS Single logout

CAS supports single logout, where if you logout of one application it
logs you out of all of them.

This bug implements this

You will need a CAS server (with single logout configure),
and at least 2 applications (one being Koha)

1/ In Koha login via CAS
2/ Login to the other application via CAS
3/ Logout of the other application
4/ Notice you are still logged into Koha
5/ Log out of Koha
6/ Apply patch
7/ Login to Koha via CAS, login to other app via CAS
8/ Log out of other app
9/ Notice you are logged out of Koha

If you dont have CAS, this patch should be a no op, you could test that
1/ Login and logout normally
2/ Apply patch
3/ Login and logout still work fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19160] CAS Single Log Out

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #40 from Josef Moravec  ---
Created attachment 66288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66288&action=edit
Bug 18606: Database changes - Add foreign keys to collections_tracking

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #39 from Josef Moravec  ---
Created attachment 66287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66287&action=edit
Bug 18606: Easy ones - CRUD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Josef Moravec  changed:

   What|Removed |Added

  Attachment #66227|0   |1
is obsolete||
  Attachment #66228|0   |1
is obsolete||
  Attachment #66229|0   |1
is obsolete||
  Attachment #66230|0   |1
is obsolete||
  Attachment #66231|0   |1
is obsolete||
  Attachment #66232|0   |1
is obsolete||
  Attachment #66233|0   |1
is obsolete||
  Attachment #66234|0   |1
is obsolete||
  Attachment #66235|0   |1
is obsolete||
  Attachment #66236|0   |1
is obsolete||
  Attachment #66237|0   |1
is obsolete||
  Attachment #66238|0   |1
is obsolete||
  Attachment #66239|0   |1
is obsolete||
  Attachment #66240|0   |1
is obsolete||
  Attachment #66241|0   |1
is obsolete||

--- Comment #38 from Josef Moravec  ---
Created attachment 66286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66286&action=edit
Bug 18606: Add RotationCollections object classes

Test plan:
1) Apply the patch
2) Update database
3) Go to tools -> Rotating collections and play with trying to break it:
3a) Add some collections
3b) Edit them
3c) Add some items to collections
3d) Remove some items
3e) Transfer some collections
3f) Try to remove collection without items
3g) Try to remove collection with items
4) Go to returns and:
4a) Try to return item from untransferred collection
4b) Try to return item from transferred collection
5) prove t/db_dependent/Koha/RotatingCollections.t
t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t
t/db_dependent/Circulation/Returns.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #41 from Josef Moravec  ---
Created attachment 66289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66289&action=edit
Bug 18606: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #42 from Josef Moravec  ---
Created attachment 66290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66290&action=edit
Bug 18606: Get rid of GetItemsInCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #45 from Josef Moravec  ---
Created attachment 66293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66293&action=edit
Bug 18606: Get rid of RemoveItemFromCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #44 from Josef Moravec  ---
Created attachment 66292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66292&action=edit
Bug 18606: Get rid of AddItemToCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #43 from Josef Moravec  ---
Created attachment 66291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66291&action=edit
Bug 18606: Get rid of GetCollectionItemBranches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #47 from Josef Moravec  ---
Created attachment 66295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66295&action=edit
Bug 18606: Get rid of isItemInThisCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #48 from Josef Moravec  ---
Created attachment 66296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66296&action=edit
Bug 18606: Get rid of isItemInAnyCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #46 from Josef Moravec  ---
Created attachment 66294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66294&action=edit
Bug 18606: Get rid of TransferCollection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #49 from Josef Moravec  ---
Created attachment 66297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66297&action=edit
Bug 18606: Remove lefover of C4::RotatingCollections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #51 from Josef Moravec  ---
Created attachment 66299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66299&action=edit
Bug 18606: Add test to t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #50 from Josef Moravec  ---
Created attachment 66298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66298&action=edit
Bug 18606: Rework tests for rotating collections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #52 from Josef Moravec  ---
Created attachment 66300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66300&action=edit
Bug 18606: Unify handling of success/error messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #53 from Josef Moravec  ---
I've rebased this on top of master, squashed few commits, fix issues, now it
should be working and ready to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19161] SPAM

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19161

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|asdsad  |SPAM
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18883] koha-http.conf designed for Apache 2.2

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18883

Chris Cormack  changed:

   What|Removed |Added

 CC|sidu...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #50 from Alex Buckley  ---
Created attachment 66301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66301&action=edit
Bug 18002: Followup - Changes based on test feedback

In this patch the following changes have been made based on test
feedback:

* Added POD to GetHighestBudgetPeriod
* Removed unconditional warns in Budgets.pm
* Fixed typos and uncommented hint and date field
* Changed manual link

Made the acquisition onboarding tool less visible in the right hand side
of the screen rather than in the middle obscuring the rest of the
acquisition home page

Implemented conditional so this tool is only displayed when the user
is superlibrarian

Test plan:
1. Restart memcached: sudo service memcached restart

2. Drop and recreate the database

3. Go through the web installer selecting all data values (except the
basic currencies)

4. After the web installer is finished log into the staff interface
using database admin credentials

5. Create a patron and assign superlibrarian permissions to them

6. Log out of staff interface and log back in as the new user you just
created

7. Go to More->Acquisitions

8. Notice yellow/orange warning message telling you to create a budget

9. Apply the patches attached to this bug report

10. Repeat steps 1,2,3,4,5,6,7

11. Notice instead of warning messages a currency creation form appears
on the right hand side of the page along with explanation of what a currency is
and why the user is being
asked to fill this form out. Fill out and submit this form.

12. A budget creation form is displayed along with an explanation of
budgets above it. Fill this form out and submit it.

13. A fund creation form appears (again with explanation text above it),
fill it out and submit it

14. The acquisition onboard tool disappears from the right of the screen and a
table of
created funds is displayed and should show the fund you just created

15. On the left of the screen below the text 'Administration' click
on 'Funds' and delete the fund you just created

16. Click on More->Acquisitions and observe how the funds form is
displayed rather than the currency or budget forms (because we
already have a currency and budget in the database). Fill out the fund form and
submit it.

17. Again you'll notice the fund table is displayed

18. On the left of the screen click on 'Budget' and delete your
budget

19. Navigate to More->Acquisitions and observe how this time the
budget form is displayed. Fill out this form and submit it. You
should be redirected to the Budget Information page
(aqbudgetperiods.pl) where you can click Actions->Add fund to add a
fund.

20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample
data in the web installer including the basic currencies

21. Notice this time because you have installed basic currencies the
first form to appear is the budget creation form

22. Repeat step 15 and then create a patron that does not have the
superlibrarian permissions
and log out and log back in.

23. Go to the Acquisitions module and notice that the yellow message
telling you that your administrator must define a budget is displayed

Sponsored by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #105 from M. Tompsett  ---
Created attachment 66302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66302&action=edit
Bug 14385: Trigger the C4::ILSDI::Services changes

prove t/db_dependent/ILSDI_Services.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #51 from Alex Buckley  ---
Hi Katrin

Thanks for testing.

I have just attached a patch that fixes the issues you found. I have two
queries:

1. At the moment in the new followup patch I have implemented a conditional so
only superlibrarian users can see the acquisition onboarding tool. I tried
using the haspermission() and the get_user_subpermissions() functions from the
Auth.pm in the acqui-home.pl script however I found that when testing using
these functions with a user that had full acq permissions these functions
returned that the user did not have acq permissions and so I found myself at a
roadblock.

Can you suggest any ideas for implementing checks on the users permissions so
that users with full acq permissions and that are not superlibrarians can also
view the acq onboarder?

2. I have run the QA test tool and as the GetBudgetHighestPeriod() function POD
has now been added that passes, however I now get this error:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template
Can't call method "config" on unblessed reference at
Koha/Database.pm line 56.

I have been researching this error however I am rather confused about how to
fix it, can you please point me in the right direction for fixing it? 

Cheers
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #106 from M. Tompsett  ---
Created attachment 66303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66303&action=edit
Bug 14385: Added missing 'my'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #66160|0   |1
is obsolete||

--- Comment #21 from Dilan Johnpullé  ---
Created attachment 66304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66304&action=edit
Bug 18351: [FOLLOW-UP] Prevent deletion if funds are added after clicking
'Delete' and before confirming delete

Followed test plan and patch works as described.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #52 from Katrin Fischer  ---
Hi Alex, I was not aware that it only showed up for superlibrarians, that makes
it 'less invasive' already :) Maybe we can leave it like that for now.

About the other error I am not sure - maybe check with some of the other devs
on IRC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17940

--- Comment #6 from Katrin Fischer  ---
Found a fixed bug that reads similarly: bug 17940

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19116

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

--- Comment #5 from Katrin Fischer  ---
Hi Jon, patch def looks better! One more small but important thing. In the
second line of the patch it reads:

From: Your Full Name 

That means you haven't set up your git completely yet. The name and address
there will be visible in git and also will make your name show up in the
release notes. I think you will just need to run those 2 commands with your
correct information, before rerunning the format-patch command again:

 git config --global user.name "Your NAME"
 git config --global user.email "y...@mail.com"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/