[Koha-bugs] [Bug 20347] Add missing classes to search results elements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347

paxed  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi
   |ity.org |

--- Comment #1 from paxed  ---
Created attachment 72497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72497=edit
Bug 20347: Add missing classes to search results elements

The MARC21 XSLT doesn't add html classes to distinguish between
certain elements, and there's no way to rely on the element
positioning, making it impossible to style the elements with CSS.

Add the missing classes to distinguish the elements.

Test plan:
1) Apply patch
2) Search for any biblios
3) Check the search result page table HTML to see that the
   "Publisher", "Edition", "Source", "Other title", and "Online access"
   are wrapped in a span with class of results_summary and one
   of "publisher", "edition", "source", "other_title", and
   "online_access"
4) Check that the search results of the elements above looks correct
   when compared to the other elements

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20347] New: Add missing classes to search results elements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347

Bug ID: 20347
   Summary: Add missing classes to search results elements
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@joensuu.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The MARC21 XSLT doesn't add html classes to distinguish between certain
elements, and there's no way to rely on the element positioning, making it
impossible to style the elements with CSS.

Add the missing classes to distinguish the elements.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #2 from Magnus Enger  ---
Definitely +1 for 2 factor auth! If at all possible it would probably be nice
to make it pluggable, to make it easy to add more two factor methods? Anyone
want to crowdsource funding for this? I'd gladly chip in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17489] Allow Koha plugins to have translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20340

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8822] Public calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|public calendar |Public calendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17489

--- Comment #2 from Katrin Fischer  ---
I like the idea of this, but with more and more functionality being moved into
plugins, I think we really need to make them translatable - bug 17489.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #73 from paxed  ---
Comment on attachment 72485
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72485
Bug 15516: Allow to reserve first available item from a group of titles

Couple tiny nitpicks:

1) the JS translation function should have the string in double quotes, so
instead of _('Loading'), use _("Loading")

2) Having separate translatable strings for PART_OF_A and HOLD_GROUP isn't
optimal, because those two always go together. It should perhaps be written as
PART_OF_HOLD_GROUP = _("(part of a %shold group%s)") and then replace the
placeholders with the html code. Even better would be to avoid the html in the
middle of the sentence altogether, by making the whole sentence a link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

--- Comment #1 from Alex Buckley  ---
Created attachment 72496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72496=edit
Bug 20346 - Server side patron filtering implemented

Server side (in the svc/members/search file) perl logic for filtering
results returned from patron searches checks all patron data fields for
a match with the filter value.

This filtering works in the following steps: when filtering is initiated
the original search using the original search query is run again and
then the filter value is used to filter the resulting data, thereby
using both the search and filter values to easily find a patron.

The submitted filter value is automatically checked against
every patron value in every patron record returned from the search and
so there is no need for a specific data value to be
selected with the select dropdown box id=searchfieldstype_filter and so
that select dropdown has been removed due to this redundancy.

This filter works for both filtering based on finding a match containing
the filter value and, filtering based on finding a match starting with
the filter value.

Test plan:
1. Go to /members/members-home.pl and create 4 users. Make them all have
the same first and last name but vary the homebranch, email addresses
and dates of birth

2. Perform a search by writing in the first and last name combination
shared by the 4 users and you should get 4 results

3. Filter by writing in the email adrr

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20346] New: Patron filtering resulting in new search rather than filtering existing results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

Bug ID: 20346
   Summary: Patron filtering resulting in new search rather than
filtering existing results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

After getting a range of  results from a patron search on the
members/members-home.pl if you use the patron filtering a new search is
performed rather than the existing results of the first search being filtered
down. 

This makes finding a user in a institution with a large number of similarly
named patrons very difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218

--- Comment #11 from Aleisha Amohia  ---
Created attachment 72495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72495=edit
Bug 17218: [FOLLOW-UP] Removing pointless code and putting checks in missed
places

To test:
1) Log in as admin
2) View contents of a public list
3) Click drop-down for 'Add to' - there should be no [New list] option
4) Click on an item in the list
5) Click drop-down for 'Add to' in nav bar, click List
6) There should be no option to add a new list in the pop-up window
7) Do a catalog search that will return multiple results
8) Click drop-down for 'Add to list' - there should be no New list
option

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

--- Comment #11 from Agnes Rivers-Moore  ---
Just in case anyone ever revisits this one...
As a librarian, having the reservoir separate is a benefit to non-cataloguing
staff. When cataloguers search they expect to find records that are not in
library stock. For other staff it is confusing to read through multiple
variations of a title, looking for the one that has a live item. For that
reason reservoir records need to be filtered out from staff searches somehow.
>From the technical standpoint, there may be advantages in not loading lots of
records to Zebra/Elasticsearch and having system resources spent on fully
indexing them, when they may never be added as stock. Z39.50 loads MARC records
for all search hits to reservoir. Cataloguers pick one variant, but the rest
live on in reservoir until cleaned out. From experience, the reservoir can
become larger than the library stock database in as little as a year or so,
depending on cataloguing practice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Katrin Fischer  changed:

   What|Removed |Added

Summary|Allow to reserve first  |Allow to place a hold on
   |available item from a group |first available item from a
   |of titles   |group of titles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #21 from Barton Chittenden  ---
I would like to see this back-ported, if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

--- Comment #1 from Owen Leonard  ---
Created attachment 72494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72494=edit
Bug 20345: Put saved report keyword search form on reports home

This patch makes cosmetic changes to the reports home page in the staff
client following the pattern set on the Administration home page with
the system preferences search box. A reports keyword search form is
added, and reports actions have font-awesome icons.

To test, apply the patch and view the reports home page. Confirm that
all affected links work correctly and that the search form works
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20045


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045
[Bug 20045] Switch single-column templates to Bootstrap grid: Various
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045

Owen Leonard  changed:

   What|Removed |Added

 Blocks||20345


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345
[Bug 20345] Put saved report keyword search form on reports home
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20345] New: Put saved report keyword search form on reports home

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

Bug ID: 20345
   Summary: Put saved report keyword search form on reports home
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

We have a quick search form for system preferences on the administration page.
I think we should have the same on the reports home page for saved reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #2 from Victor Grousset/tuxayo  ---
== Simpler test plan ==
On master.
1. Place a hold
2. Transfer the item twice (wherever, it can be the same transfer)
3. Check the branchtransfers table
 SELECT *
 FROM branchtransfers
 order by datesent DESC
 LIMIT 10;
4. First one should have been canceled
  «Canceled, new transfer from A to A created»
5. Another one should have been created from A to A
6. These 2 things are the issue.
 Because doing the same without a hold
  - doesn't create a new transfer
  - doesn't cancel the first one

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be specified per instance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64915|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 72493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72493=edit
Bug 18909 - Enable the maximum zebra records size to be specified per instance

The default for Zebra is to not return results where the record size is
greater than 1045 KB ( 1 MB ). Some libraries need to increase this
ceiling, but it may come at a cost with z39.50 compatibility with other
services. For that reason, we should make this setting configurable on a
per-instance basis.

Test Plan:
1) Apply this patch
2) Build a Debian package
3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml
4) Restart zebra
5) Index a record greater than 1 MB but smaller than 2 MB
6) Note that it is searchable!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20336] Add a generic way for Koha::Object(s) to call logaction as required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20336

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #71885|0   |1
is obsolete||
  Attachment #71886|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 72492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72492=edit
Bug 17468: Remove koha-*-zebra scripts and its traces

This patch removes traces from the (deprecated) koha-*-zebra scripts.

To test:
- Apply the patch
- Verify no traces of koha-*-zebra remain on the codebase (besides
  Release Notes and the koha-zebra script):
  $ cd kohaclone
  $ git grep koha-start-zebra
  $ git grep koha-stop-zebra
  $ git grep koha-restart-zebra
=> SUCCESS: No traces!
- Create the following symlinks:
  $ sudo ln -s /usr/sbin/koha-zebra  /usr/sbin/koha-start-zebra
  $ sudo ln -s /usr/sbin/koha-zebra  /usr/sbin/koha-stop-zebra
  $ sudo ln -s /usr/sbin/koha-zebra  /usr/sbin/koha-restart-zebra
- Try the koha-*-zebra commands:
  $ sudo koha-stop-zebra kohadev
  $ sudo koha-start-zebra kohadev
  $ sudo koha-restart-zebra kohadev
=> SUCCESS: They all work as expected!

- Sign off :-D!

Sponsored-by: Orex Digital

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #72 from Benjamin Rokseth  ---
added missing file hold-group-modal.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #72489|0   |1
is obsolete||

--- Comment #71 from Benjamin Rokseth  ---
Created attachment 72491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72491=edit
Bug 15516: Reword 'reserve group' to 'hold group'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #1 from Victor Grousset/tuxayo  ---
Same behavior on 17.11.03

On 16.11.15, step 8:
The first hold isn't cancelled, creating a duplicate transfert (without the
same destinations).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #7 from Owen Leonard  ---
Created attachment 72490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72490=edit
Screenshot showing follow-up changes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #70 from Benjamin Rokseth  ---
rebased against master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #69902|0   |1
is obsolete||

--- Comment #65 from Benjamin Rokseth  ---
Created attachment 72485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72485=edit
Bug 15516: Allow to reserve first available item from a group of titles

It can be useful, for instance, if a library have the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.

This patch is only for staff interface.

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
   and click on 'Place hold' button at the top of the results.
2. Enter a patron cardnumber and click Search
3. Check the box for 'Place a hold on the next available item' (it's
   usually hidden when placing a hold on multiple biblios)
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
   additional text '(part of a reserve group)' in Details column.
6. Click on the "reserve group" link. A modal window should appear with
   the content of the reserve group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are
   deleted.

Note: the "reserve group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl

Signed-off-by: Josef Moravec 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #69906|0   |1
is obsolete||

--- Comment #69 from Benjamin Rokseth  ---
Created attachment 72489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72489=edit
Bug 15516: Reword 'reserve group' to 'hold group'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #69904|0   |1
is obsolete||

--- Comment #67 from Benjamin Rokseth  ---
Created attachment 72487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72487=edit
Bug 15516: Update old_reserves (reserve_group_id)

Without it, deletion of reserves will fail

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #69905|0   |1
is obsolete||

--- Comment #68 from Benjamin Rokseth  ---
Created attachment 72488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72488=edit
Bug 15516: Set reserve-group.pl to be executable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #69903|0   |1
is obsolete||

--- Comment #66 from Benjamin Rokseth  ---
Created attachment 72486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72486=edit
Bug 15516 - Holding first available item from x biblios only count 1 reserve

Signed-off-by: Josef Moravec 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #6 from Owen Leonard  ---
Created attachment 72484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72484=edit
Bug 20322 (follow-up) Circulation page layout and design update

This follow-up makes some suggestions about how to push this further:

- Put content in four columns which reduces to two on smaller screens
- Adjust font size of large links
- Move Offline Circulation links into its own column
- Add image icons to the Firefox extension and Windows application
  download links
- Improve indentation in template

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

--- Comment #15 from Lari Taskula  ---
It seems that $SIG{__DIE__} catches dies inside eval blocks, thus generating a
lot of useless "fatal" noise about missing modules inside some dependencies,
such as Mojolicious.

Perhaps another approach needs to be considered. I'm currently looking at
Plack::Middleware::Log4perl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8822] public calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822

Josef Moravec  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17015
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Josef Moravec  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8822

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14962] Temp Shelving Location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962

--- Comment #10 from Owen Leonard  ---
See also: Bug 6615 - Add shelving location option to transfers page. I think it
would be useful to be able to transfer books from one shelving location to
another without granting staff batch item modification permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14962] Temp Shelving Location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] New: Transferring an item while on hold results in a transfer were the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

Bug ID: 20344
   Summary: Transferring an item while on hold results in a
transfer were the destination is the same as the
source
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

1. Check out an item
2. Place a hold on the specific item with a pickup at a different branch
3. Check in: Confirm hold and transfert
4. Check the branchtransfers table to ensure that the transfert is here
 SELECT *
 FROM branchtransfers
 order by datesent DESC
 LIMIT 10;
5. Home › Circulation › Transfers
6. Create a transfer identical as the existing one
7. You should see «Item is already at destination library.»
8. Check the branchtransfers table
   1. First one should have been canceled
«Canceled, new transfer from A to A created»
   2. Another one should have been created from A to A
   3. These 2 things are the issue.
Because doing the same without a hold
- doesn't create a new transfer
- doesn't cancel the first one

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14962] Temp Shelving Location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #9 from Christopher Brannon  ---
The biggest issue for us on items on display is handling.  We can certainly
define locations for displays.  And Koha now has the ability to automatically
update information (like reset a location) after a prescribed length of time. 
That was one of the troublesome areas that Koha has solved (thank you!).  The
problem still at hand is how to get staff to know where to shelve the item if
it is supposed to be on display.  When an item is checked in, unless there is
some special marking on the book (which really defeats the purpose of Koha
automatically updating locations so staff don’t have to), how do staff know to
shelve it in the display rather than its normal location?  The best answer
would be to have a popup for items in specific locations on check in.  This
would alert staff, and they would either place the item in a special pile or
place a bookmark in it or something at that time so they know to shelve it
elsewhere.

As long as we have to manually process the book in some way in order to keep it
in a special location, it remains a chore that current automated processes that
Koha has can’t handle quite yet.  We are close, but there are still some minor
kinks to work out.

Ideally, it would be great if you had a display module to check items in on. 
It would ask where you want to display the item, and for how long.  Then the
module would temporarily move the item to the new location, setup a rule to
change it back after the time is up, and would alert staff of the temporary
location when checked in at the home location.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342

--- Comment #2 from Kyle M Hall  ---
Created attachment 72483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72483=edit
Bug 20342: Use File::Temp to get temp dir

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

--- Comment #1 from Julian Maurice  ---
Created attachment 72482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72482=edit
Bug 20343: Show number of checkouts by itemtype in circulation.pl

It is sometimes useful to have the number of checkouts grouped by
itemtype (to see if we're approaching the maximum number of checkouts
allowed for instance).
This patch adds this information above the checkouts table, in
circ/circulation.pl

Test plan:
1. Check out some items with various item types to a patron
2. In circ/circulation.pl, click on 'Show checkouts' button to display
   the table
3. Notice the line "Number of checkouts by item type" above the table,
   click on it
4. See that the list of item types is displayed with a count in front of
   each one
5. Compare the numbers to the checkouts in the table and verify that the
   numbers are correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] New: Show number of checkouts by itemtype in circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Bug ID: 20343
   Summary: Show number of checkouts by itemtype in circulation.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It is sometimes useful to have the number of checkouts grouped by itemtype (to
see if we're approaching the maximum number of checkouts allowed for instance).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342

--- Comment #1 from Kyle M Hall  ---
Created attachment 72481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72481=edit
Bug 20342: Fix table locking issue, progress bar not updating, and allow use of
plack for Stage MARC Import

Have you ever seen this error?
DBD::mysql::st execute failed: Deadlock found when trying to get lock; try
restarting transaction [for Statement "INSERT INTO import_record_matches
(import_record_id, candidate_match_id, score),

Have you ever noticed your progress bar during stage for import jumps from 0%
to 100% with no updates in between?

Would you like stage-marc-import.pl to work under plack?

If you answered yes to any of the following questions, this bug is for you!

During uploads of large records using matching rules, we were getting 'Failed
to submit form' popups on the marc record importer.

First, I noticed that the parent process of stage-marc-import.pl wasn't
returning the job id via ajax until the child process had completed. This works
fine for smaller files as they process fast. For large files ( and in
particular when using matching rules ) the process takes *much* longer.

It appears that $.ajax will resubmit the form if it doesn't get a response back
in a given time ( I would estimate that to be about 30 seconds or so ). This
causes a *second* instance of stage-marc-import.pl to be run. So now we have
two processes both running transactions on the same table for the same batch
id. I believe this is what is causing the Deadlock.

So, the crux of the matter is that for whatever reason, the parent process will
not output until the child process has gone away. Hours of research entailed.
The final answer is that the child process must be detached from the parent
process. I tried doing this via setsid() but it did not help. Finally, I found
that using Net::Server::Daemonize did!

After I had my solution, I decided to see if stage-marc-import.pl and
background-job-progress.pl could now be run under plack, and it appears that
they can!

Test Plan:
1) Apply this patch
2) Update /etc/koha/apache-shared-intranet-plack.conf manually, comment
   out the lines for stage-marc-import.pl and  background-job-progress.pl
3) Restart apache, plack and memcached
4) Stage a large record in stage-marc-import.pl, use a matching rule
5) Note it works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20342] New: Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342

Bug ID: 20342
   Summary: Fix table locking issue, progress bar not updating,
and allow use of plack for Stage MARC Import
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Have you ever seen this error?
DBD::mysql::st execute failed: Deadlock found when trying to get lock; try
restarting transaction [for Statement "INSERT INTO import_record_matches
(import_record_id, candidate_match_id, score),

Have you ever noticed your progress bar during stage for import jumps from 0%
to 100% with no updates in between?

Would you like stage-marc-import.pl to work under plack?

If you answered yes to any of the following questions, this bug is for you!

During uploads of large records using matching rules, we were getting 'Failed
to submit form' popups on the marc record importer.

First, I noticed that the parent process of stage-marc-import.pl wasn't
returning the job id via ajax until the child process had completed. This works
fine for smaller files as they process fast. For large files ( and in
particular when using matching rules ) the process takes *much* longer.

It appears that $.ajax will resubmit the form if it doesn't get a response back
in a given time ( I would estimate that to be about 30 seconds or so ). This
causes a *second* instance of stage-marc-import.pl to be run. So now we have
two processes both running transactions on the same table for the same batch
id. I believe this is what is causing the Deadlock.

So, the crux of the matter is that for whatever reason, the parent process will
not output until the child process has gone away. Hours of research entailed.
The final answer is that the child process must be detached from the parent
process. I tried doing this via setsid() but it did not help. Finally, I found
that using Net::Server::Daemonize did!

After I had my solution, I decided to see if stage-marc-import.pl and
background-job-progress.pl could now be run under plack, and it appears that
they can!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

Claire Gravely  changed:

   What|Removed |Added

  Attachment #72436|0   |1
is obsolete||
  Attachment #72437|0   |1
is obsolete||

--- Comment #4 from Claire Gravely  ---
Created attachment 72479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72479=edit
Bug 20167: Regression test

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

--- Comment #5 from Claire Gravely  ---
Created attachment 72480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72480=edit
Bug 20167: Make changing a hold pass the itemnumber to ModReserve

If you have an item-level hold, changing an attribute (like priority,
pickup location or suspended until date) makes the hold a biblio-level
hold, because ModReserve is not passed the current itemnumber.

This patch uses the hold's itemnumber and passes it to the ModReserve
call.

To test:
- Run the regression tests from the previous patch:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail
- Apply this patch
- Run the tests:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #29 from Josef Moravec  ---
Created attachment 72478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72478=edit
Bug 19933: Fix typo in template plugin name

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #28 from Josef Moravec  ---
Created attachment 72477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72477=edit
Bug 19933: Move instantiation of in deletemem.pl

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #27 from Josef Moravec  ---
Created attachment 72476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72476=edit
Bug 19933: (follow-up) Remove patronflags - easy ones

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #25 from Josef Moravec  ---
Created attachment 72474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72474=edit
Bug 19933: Remove patronflags - easy ones

This patch replaces the easy occurrences of patronflags.

These calls only need the CHARGES->amount value, that is the non issues
charges. Luckily we now have a Koha::Account->non_issues_charges that
deal with that.

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #26 from Josef Moravec  ---
Created attachment 72475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72475=edit
Bug 19933: Remove patronflags - tricky ones

Here we are, patronflags is used in a couple of places where (almost) all flags
were really useful: C4::SIP::ILS::Patron->new and circulation.pl

This patch only deal with the circulation code as I am not convident
enough with SIP code.

The change does not seems trivial because of the complexity of the
existing code, but the logic is the same. We send a variable to the
template depending on the situation of the patron.

I guess only code eyes ball could catch issue in this patch quickly.

Maybe we need to find a good place in a Koha module to move this code
and provide code coverage (especially when C4::SIP::ILS::Patron will
reuse it).

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #24 from Josef Moravec  ---
Created attachment 72473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72473=edit
Bug 19933: Remove patronflags - In CanBookBeIssued

The change is trivial here, we only want to pass gonenoaddress, lost and
is_debared to the template.

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72350|0   |1
is obsolete||
  Attachment #72351|0   |1
is obsolete||
  Attachment #72352|0   |1
is obsolete||
  Attachment #72353|0   |1
is obsolete||
  Attachment #72354|0   |1
is obsolete||
  Attachment #72355|0   |1
is obsolete||
  Attachment #72356|0   |1
is obsolete||

--- Comment #23 from Josef Moravec  ---
Created attachment 72472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72472=edit
Bug 19933: Remove patronflags - unused vars oldamount/amountold in
circulation.pl

There is oldamound/amountold variable that is sent to the template but
never used later. Let remove it now to avoid useless replacement.

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

David Gustafsson  changed:

   What|Removed |Added

  Attachment #72435|0   |1
is obsolete||

--- Comment #6 from David Gustafsson  ---
Created attachment 72471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72471=edit
Bug 20334 - Option for escaping slashes in search queries

Add "QueryRegexEscapeOption" system preference to provide option to escape
Elasticsearch regexp delimiters (/) within queries, or alternativly to
unescape escaped slashes (\/) while escaping unescaped slashes, in
effect making "\/" the new regexp delimiter.

How to test:
1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
2) All tests should succeed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72468|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 72470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72470=edit
Bug 20341: Show authorized value description for withdrawn like damaged and
lost

Actually catalog detail page shows for damaged and lost items the authorized
value description if exists.
We must do the same for withdrawn information.

Test plan :
1) Set for items a subfield linked to items.withdrawn and using the authorized
value category 'WITHDRAWN'
2) Edit the authorized value category to add value '2' and description 'Eaten
by dog'
3) Edit an item to set this withdrawn value
4) Go to staff interface and look at items in record detail page
/cgi-bin/koh/catalogue/detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
5) Go to OPAc and look at items in record detail page
/cgi-bin/koha/opac-detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'

Signed-off-by: delaye 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #1 from Alex Arnaud  ---
Created attachment 72469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72469=edit
Bug 20340 - Ability to add and use authentication plugins

Plugins must be placed in  and enabled with
AuthenticationModule system preference.

Test plan:

  - Apply this patch and update your database,
  - set UseKohaPlugins to enabled,
  - define a pluginsdir in your koha-conf.xml,
  - put a plugin in this directory.
  - I.e, take the one provided in tests directory:
 - t/Koha/Plugin/TestAuth.pm,
 - login/pass is test/test
  - You should have:
  /your/plugins/dir/Koha/Plugin/TestAuth.pm,
  - replace default by your plugin in AuthenticationModule
system preference,
  - test authentication with and without the plugin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #5 from Josef Moravec  ---
And I would stick with col-sm-4 to have 3 columns on small and larger displays

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #14 from Josef Moravec  ---
Comment on attachment 72442
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442
Bug 19469: Add ability to split view of holds view on record by pickup library
and/or itemtype

Review of attachment 72442:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19469=72442)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ +1,1 @@
> +[% USE Dumper %]

debug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 72468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72468=edit
Bug 20341: Show authorized value description for withdrawn like damaged and
lost

Actually catalog detail page shows for damaged and lost items the authorized
value description if exists.
We must do the same for withdrawn information.

Test plan :
1) Set for items a subfield linked to items.withdrawn and using the authorized
value category 'WITHDRAWN'
2) Edit the authorized value category to add value '2' and description 'Eaten
by dog'
3) Edit an item to set this withdrawn value
4) Go to staff interface and look at items in record detail page
/cgi-bin/koh/catalogue/detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
5) Go to OPAc and look at items in record detail page
/cgi-bin/koha/opac-detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #11 from Fridolin SOMERS  ---
(In reply to Owen Leonard from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > I personally think we should fix all of them at the same time.
> 
> I'd be happy to submit a follow-up for moredetail.tt and detail.tt.
>  
> > Yes, but for these 3 ones I am pretty sure everybody keeps the default 
> > value.
> 
> This bug exists because we use more than just the default value for lost,
> and damaged and we want to see those locally-defined values. Bug 11280 shows
> that there was a need for withdrawn to be the same.
> 
> > catalogue/detail.tt
> >  662 [% IF ( item.withdrawn ) %]
> >  663 Withdrawn
> >  664 [% END %]
> 
> catalogue/detail.tt already shows the authorized value description for lost
> and damaged. That it doesn't do so for withdrawn is a bug which should have
> been fixed by Bug 11280.

I propose Bug 20341 for that.
The idea is to just implement for withdrawn the same behavior as lost and
damaged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||11280


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280
[Bug 11280] Change Withdrawn toggle to drop down selection of authorized values
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15922

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20341

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20341


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341
[Bug 20341] Show authorized value description for withdrawn like damaged and
lost
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20341] New: Show authorized value description for withdrawn like damaged and lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341

Bug ID: 20341
   Summary: Show authorized value description for withdrawn like
damaged and lost
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Actually catalog detail page shows for damaged and lost items the authorized
value description if exists.
We must do the same for withdrawn information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #13 from Fridolin SOMERS  ---
Or maybe one could change the existing preference noItemTypeImages to use
choices : image and text, image only, text only.
My2c

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
> add a class to make it easy to hide with css.
+1

Not another system preference please :(

Actually you may use a trick by painting text with background color :
  #holdings_table .itype { color: #F3F3F3; }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20340] New: Ability to use authentication plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

Bug ID: 20340
   Summary: Ability to use authentication plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

This enhancement intends to allow adding and use authentication plugins. A
plugin can be enabled with a system preference (AuthenticationModule) and
placed in the 


-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

David Gustafsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from David Gustafsson  ---
Just saw that a swap file was accidentally committed, setting failed until this
is fixed (later today).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from David Gustafsson  ---
Wrong issue, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from David Gustafsson  ---
Just saw that a vim swap file was accidentally committed, marking as failed
until I have fixed this (shortly).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from David Gustafsson  ---
Ok! Yes, ready to signoff.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

paxed  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi
   |ity.org |

--- Comment #1 from paxed  ---
Created attachment 72467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72467=edit
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20339] New: Unify MARC21 ISBN/ISSN handling in XSL

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Bug ID: 20339
   Summary: Unify MARC21 ISBN/ISSN handling in XSL
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@joensuu.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The code to show the ISBN and ISSN is repeated between the search results and
the detail view. Create a function to show the ISBN/ISSN, and call that
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20338] New: Preference noissuescharge should not be considered 5 when it is actually 0

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338

Bug ID: 20338
   Summary: Preference noissuescharge should not be considered 5
when it is actually 0
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When the noissuescharge is set to 0, then limit 5 is used, see FIXME comment in 
circ/circulation.pl after bug 19933

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20338] Preference noissuescharge should not be considered 5 when it is actually 0

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338

Josef Moravec  changed:

   What|Removed |Added

 Depends on||19933


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933
[Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Josef Moravec  changed:

   What|Removed |Added

 Blocks||20338


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338
[Bug 20338] Preference noissuescharge should not be considered 5 when it is
actually 0
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Comment on attachment 72466
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72466
Screenshot

I think this looks like a really good start! Really glad you took this on Liz!

Some things I notice:

- Maybe offline circulation would look a little nicer as some kind of box on
the right?
- Some icons could be added: Set library and Pending on-site checkouts. Maybe
something like a house or building to indicate on-site?
- Do we need the note for overdues with fines? Or could we move it to the page
itself?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/