date:20180419

[Koha-bugs] [Bug 18426] Subscriptions batch editing

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Katrin Fischer  ---
Something is not quite right yet. Testing with a staff patron that has all
serial permissions but 'edit subscription'. I don't see the links, but I still
have the checkboxes that now have no function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #54 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #39)
> Marcel,
> We talked about that earlier. The pref was the best compromise we found to
> not break somebody's workflow. See comment 29.

I will QA what is here now, but I still do not see why we should avoid (per se)
breaking a workflow based on a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #53 from Marcel de Rooy  ---
Resuming QA here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4850] CheckReserves does not respect holds circulation policies

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #9 from Hugh Rundle  ---
I disagree that this isn't a problem.

Comment 7 is true, but only if the only thing you care about is item types.

Imagine you have a circ rule for borrower category A plus item type Z, and
another rule for borrower category B plus item type Z. You want Category A to
be allowed to place holds on Z items, and you don't want category B to be able
to place holds on Z items.

"Default holds policy by item type" is a blanket rule based on the item type
only. So it's impossible to apply different hold rules on a combination of item
type and borrower category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
After reviewing the patches, this seems awesome! It seems like a great way to
move Koha into the 21st century and allow for incremental improvements.

I see it doesn't need PERL5LIB but what about KOHA_CONF?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #12 from Hugh Rundle  ---
Can confirm this is still a problem: titles where all items are hidden still
appear in search results, then when you click on it you get a 404 (of course).
If you can't reach the title description it shouldn't appear in results.

Anyone on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] Elasticsearch - result sets limited to 10000

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #4 from Nick Clemens  ---
Created attachment 74587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74587=edit
Bug 19520: (follow-up) Pass parameters to avoid making templates depend on
search engine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #33 from Hugh Rundle  ---
If I am understanding correctly what the patch does (removes the cancel button
from allocated holds), then yes, it qualifies as a quick fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

--- Comment #11 from Lisette  ---
I agree that it would be nice if there was one combined method. 

I think as long as clicking on the barcode from the check-in screen or the
barcode on the took you somewhere where you could edit the item and see
statuses for that specific item that would work. 
We rarely look through the tab directly because it is pretty terrible to scroll
through. 
Since our circulation staff can't edit items but can edit statuses, we would
need to be able to set SubfieldsToAllowForRestrictedEditing to only be those
statuses.

Also, to see the Lost, Damaged,  and nonpublic note fields you have to click
again on the show hidden fields button. I'm not sure if that button is a
setting we can change or not, but that adds an additional click to our
workflow.

Our next problem would be that as a (about) 50 library consortium, getting all
the libraries to agree on what is allowed is highly unlikely. It would be
better if it could be set per branch or per staff member even. 

I forget what the different actions are that are taken when edited the
different ways, but we would also need to examine that. 


Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #49 from Liz Rea  ---
It's all good, thanks everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

--- Comment #10 from Heather  ---
Hi, Joy!

Oh, yes--I understand that there are different actions & useful information &
stats there--I just hope that it can all be combined into one method for
updating items.  And I just had to add my opinion about which method for
editing was preferable for me & why, in case it was useful.  Overall, I just
hope that there will eventually be one method.

--h2

> Yes, it is unusual to have to two methods to update items.  However, keep in
> mind that there are different actions taken by Koha when editing lost
> statuses in the Items tab or Items grid.  For circulating libraries (mainly
> public) this is essential for their workflow.  Additionally the information
> about circulation stats that can be easily and quickly seen on the Items tab
> is useful for circulating libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17471] Borrower Previously Checked Out: Date of last checkout

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17471

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

--- Comment #9 from Joy Nelson  ---
Heather-
Yes, it is unusual to have to two methods to update items.  However, keep in
mind that there are different actions taken by Koha when editing lost statuses
in the Items tab or Items grid.  For circulating libraries (mainly public) this
is essential for their workflow.  Additionally the information about
circulation stats that can be easily and quickly seen on the Items tab is
useful for circulating libraries.  

joy

> 
> And it just seems like there should be only way to edit items--this is the
> only ILS I've ever seen that has two different edit item functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #8 from Heather  ---
I'm a total cataloger, and I find that trying to edit items via that "Items"
button on the left in between the "ISBD" and "Holds" button is, to me,
horrid--the resulting display of item records going endlessly down screen with
tons of white space is terrible--it's not uncommon for us to have dozens, if
not hundreds, of items on a record, and even where there are just a few items,
the display scrolls down and down without really clear delineation between
items--it's easy for staff to make mistakes and edit the wrong item so all my
staff is trained to use the Edit Items tab into the edit items table.  When I
have a serial with 200+ items, it is pretty much impossible to try to navigate
to trying to edit an item via that button.  I always choose the "Edit"
pull-down-menu button across the top of the bib record which is in between the
"New" button and the "Save" button, which
gives me a, to me, more easily navigated visually table of items with instant
access to a search box at the top of the table, and I would love for this
to be the only way to get into editing items.

If the "Edit items" table is too confusing for non-catalogers, then perhaps
there's a way to control the column visibility via their login so that they can
achieve an edit items experience suited to their commonly used tasks?  (There
may be already--I haven't checked--my staff is trained to use the Column
Visibility function).  I am generally in favor of a user-customizable
experience and one can customize the Edit Items table easily via Column
Visibility and the search box.

And it just seems like there should be only way to edit items--this is the only
ILS I've ever seen that has two different edit item functions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19617] Allow 'writeoff of selected'

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #2 from Séverine Queune  ---
Not sure I can test it as 18316 is 'Failed'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #20 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #48 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #37 from Jonathan Druart  
---
So we should remove the 2x2 lines you add in the .pl to retrieve the active
currency, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #31 from Jonathan Druart  
---
signed-off-by lines have been removed, do we need to retest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #58 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #57)
> This followup adds errors for the first and last situations. The middle one
> only occurs if you apply the patch set but don't restart plack ( at least
> for me ) so it's not a valid production error afaict.
> 
> > Errors handling should be polished a bit. For instance I am seeing these
> > screens when id or keeper does not match valid borrowernumbers:
> > https://screenshots.firefox.com/nIgsc8xOpLHvuqXC/pro.kohadev.org
> > https://screenshots.firefox.com/VTKYZNqBS3L8B5cq/pro.kohadev.org
> > https://screenshots.firefox.com/gEGiMi16yknuyrZU/pro.kohadev.org

IIRC it happened when keeper was invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74253|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74584|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 74586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74586=edit
Bug 20562: Fix Returns.t test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74240|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #57 from Kyle M Hall  ---
This followup adds errors for the first and last situations. The middle one
only occurs if you apply the patch set but don't restart plack ( at least for
me ) so it's not a valid production error afaict.

> Errors handling should be polished a bit. For instance I am seeing these
> screens when id or keeper does not match valid borrowernumbers:
> https://screenshots.firefox.com/nIgsc8xOpLHvuqXC/pro.kohadev.org
> https://screenshots.firefox.com/VTKYZNqBS3L8B5cq/pro.kohadev.org
> https://screenshots.firefox.com/gEGiMi16yknuyrZU/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #56 from Kyle M Hall  ---
Created attachment 74585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74585=edit
Bug 9302: Add error messages, correct number of unit tests in subtest 'Test
Koha::Patrons::merge'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #17 from David Gustafsson  ---
Thanks

> 1.) Incomplete fields should be handled more gracefully...

I agree. Have ignored this since only results in a warning, but could probably
be done in better way. Some mappings ranges in the mappings YAML are off by one
(mostly the ff*-fields I think), this might aggravate the issue.

> 2.) es_id is missing from the indexed records compared to the Catmandu 
> indexing code. Is this intentional?

I think this is something Catmandu adds, and I think I just left it out since
doesn't seems to be needed for anything.

> 3.) I think this, when done, should just replace the Catmandu-based indexing 
> code. Since the ES support itself is somewhat experimental, it would make 
> sense to switch once and for all.

That would be wonderful. I would actually love to get rid of all
Catmandu-dependencies altogether. Indexing is probably the heaviest part, the
rest should be quite trivial to replace with Search::Elasticsearch (which
Catamndu uses internally).

> 4.) Make sure to document the dependency on Search::Elasticsearch. Would it 
> be possible to use the v6 module? It says it supports ES 5 too. I had to 
> downgrade it on my system for the patch to work.

I did not document it since Catmandu depends on it, but it will need to be done
if Catmandu is no longer a dependency. To use v6 you just have to change, 
client => "5_0::Direct" to client => "6_0::Direct". If I'm not mistaken, I
think we are running ES 6 with the "5_0::Direct" line (and works, but probably
not optimal). The reason I went for 5.0 was that was the version Koha was using
at the time of the initial version of the patch (I think).

> 5.) Booleans should be indexed as true/false. I'm seeing deprecation notices 
> for suppress and onloan (this is wrong in the old code too, but could as well 
> be done correctly here).

I agree. This is a problem in Koha master as well I think (but there is a
bugzilla issue that takes care of it). It would be easy to fix so will make
sure to do so.

> 6.) The Catmandu version seems to create way more __sort fields, but perhaps 
> it's a bug in the Catmandu version?

Yes, I think this is a bug in Koha master, but will look into to it.

> 7.) The patch doesn't apply cleanly, so there could be also something I 
> screwed up while fixing it manually.

I think you got it right, most of the above I have run into myself, though a
bit strange that you had to downgrade to 5.0 to get it to work? Can verify
tomorrow that it really is 6.x we are running.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #55 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #54)
> Thanks for the follow-ups.
> 
> (In reply to Jonathan Druart from comment #38)
> > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING?
> > How are we going to keep it up-to-date?

I went through the tables looking for columns that represent borrowernumbers.
It's pretty easy for columns with foreign keys to borrowers.borrowernumber, but
not all the columns have a borrowernumber. We should just add that to the qa
process. If a new column is added that is a borrowernumber, it should be added
to the mapping. We could move the mapping itself its own perl module to make it
more obvious if you wish.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74560|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74561|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74240|0   |1
is obsolete||
  Attachment #74253|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 74584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74584=edit
Bug 20562: Fix unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74562|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74563|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74583|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74560|0   |1
is obsolete||
  Attachment #74561|0   |1
is obsolete||
  Attachment #74562|0   |1
is obsolete||
  Attachment #74563|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 74583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74583=edit
Bug 20590: Fix unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

--- Comment #15 from Kyle M Hall  ---
Ah, the unit test assumed that his was implemented already! That still doesn't
explain the expected behavior of the test. It seems like that particular test
should expect an accountline to exist and *not* for none to exist!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

--- Comment #14 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #13)
>   commit dc5d3b9abd34b0e80794fff7029809b7438bcefa
>   Bug 20562: issue_id is not stored in accountlines for rental fees
> 
> breaks t/db_dependent/Circulation/Returns.t
> 
> #   Failed test 'No account lines should exist for this issue_id, patron
> should not have been charged'
> #   at t/db_dependent/Circulation/Returns.t line 330.
> #  got: '1'
> # expected: '0'
> # Looks like you failed 1 test of 6.
> t/db_dependent/Circulation/Returns.t .. 4/5 
> #   Failed test 'Handle ids duplication'
> #   at t/db_dependent/Circulation/Returns.t line 333.
> # Looks like you failed 1 test of 5.
> 
> 
> Please fix ASAP

I'm trying to understand what this is actually testing. Can you give me any
context? The unit tests aren't telling me much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10537

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10537] Limit ability to grant permissions based on user's own permissions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20100

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20624


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624
[Bug 20624] Allow switching off the OAuth2 client credentials grant
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20624


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624
[Bug 20624] Allow switching off the OAuth2 client credentials grant
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20624


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624
[Bug 20624] Allow switching off the OAuth2 client credentials grant
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20624] Allow switching off the OAuth2 client credentials grant

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||20402, 20568, 20612


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
[Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568
[Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612
[Bug 20612] Make OAuth2 use patron's client_id/secret pairs
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20624] New: Allow switching off the OAuth2 client credentials grant

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624

Bug ID: 20624
   Summary: Allow switching off the OAuth2 client credentials
grant
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

--- Comment #24 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #21)
> Could we have a global switch to turn on/off the whole REST API stuffs?

s/REST API/OAuth server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] PDF export of a basket group fails when an item has an itemtype is not in the itemtype table

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |victor.grous...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] PDF export of a basket group fails when an item has an itemtype is not in the itemtype table

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] PDF export of a basket group fails when an item has an itemtype is not in the itemtype table

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

Victor Grousset/tuxayo  changed:

   What|Removed |Added

Summary|PDF export of a basket  |PDF export of a basket
   |group fails when an item as |group fails when an item
   |an itemtype is not in the   |has an itemtype is not in
   |itemtype table  |the itemtype table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] New: PDF export of a basket group fails when an item as an itemtype is not in the itemtype table

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

Bug ID: 20623
   Summary: PDF export of a basket group fails when an item as an
itemtype is not in the itemtype table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Does it matter?
Yes, using authorized values like ccode to populate the itemtypes of the
biblioitems (instead of the itemtype table) can lead to such data.
Or importing records with invalid itemtype codes. Koha doesn't do enough checks
to at least warn about these issues.

== Reproduce ==
1. have/create a budget
2. have/create a fund
3. have/create a vendor with minimal info
4. create a basket with minimal info
5. add a item to the basket
6. go to the basket. URL should be
   /cgi-bin/koha/acqui/basket.pl?basketno=X
7. close this basket
8. create a basket group with the basket
   - your vendor page => Basket groups
   - create basket group
   - (tick the "close this basket group" check box)
9. go to the basket group
  your vendor page => Basket groups => Closed
10. export as PDF, it should work, keep the page opened
11. find the itemtype code of item in the basket
12. delete it with the following SQL[1] (directly or use sql reports)
  replace with the relevant type code
  DELETE from itemtypes where itemtype = "BOOK";
13. reexport the basket as PDF
14. It should fail (internal server error)

[1] Or you can find a more realistic way to have a biblioitem whose itemtype is
not in the itemtype table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

--- Comment #23 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #22)
> Should we really remove a deleted key from the DB table?
> I would flag it as inactive instead, it would permit to keep track of the
> different requests and associate it to a user.
> Disclaimer: This may be a very stupid idea.

I thought about it too. That would mean an extra column: deleted TINYINT (1),
and it makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

--- Comment #22 from Jonathan Druart  
---
Should we really remove a deleted key from the DB table?
I would flag it as inactive instead, it would permit to keep track of the
different requests and associate it to a user.
Disclaimer: This may be a very stupid idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

--- Comment #21 from Jonathan Druart  
---
Could we have a global switch to turn on/off the whole REST API stuffs?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #49 from Jonathan Druart  
---
It the key is revoked or deleted, the token is still valid, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #48 from Jonathan Druart  
---
How hard will it be to package Net::OAuth2::AuthorizationServer and deps?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #20 from Jonathan Druart  
---
Please write a wiki page about these changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #47 from Séverine Queune  ---
Hi Nick !
I'm not sure I understood all your comments, but I've tested once more and here
are my feedbacks.

(In reply to Nick Clemens from comment #46)
> The pref now affects all datatables where we use anti-the,
When you say 'all databases using anti-the', can you tell me which one are
concernd ?
Do you have some ideas it could impact staff client and so where I should test
?
I've tried on the /cgi-bin/koha/circ/circulation.pl page for the issues-table :
articles are ignored even when the syspref is empty.

> however, we still generate the extra column in serials-search and sort 
> against that initially?
I don't understand that part.

> This code also seems to automatically strip articles before apostrophes -
> this works for some languages, but would it work for all? I don't know if
> the 'anti-the' plugin works with apostrophe'd articles, can you weigh in on
> that severine or someone else?
I tested with " L' " and " D' ", used very often in french and they are
correctly ignore for sorting if I save them on the syspref.
Do you have ideas of what of strings / articles / apostrophes use could be a
problem ?

> I find it confusing that the table is initially sorted by one column, then
> uses another if you click.  Adding this to datatables seems to allow sorting
> by a hidden column:
>  { 'orderData': 2, 'targets': 0},
I don't understand that part either...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #13 from Jonathan Druart  
---
  commit dc5d3b9abd34b0e80794fff7029809b7438bcefa
  Bug 20562: issue_id is not stored in accountlines for rental fees

breaks t/db_dependent/Circulation/Returns.t

#   Failed test 'No account lines should exist for this issue_id, patron
should not have been charged'
#   at t/db_dependent/Circulation/Returns.t line 330.
#  got: '1'
# expected: '0'
# Looks like you failed 1 test of 6.
t/db_dependent/Circulation/Returns.t .. 4/5 
#   Failed test 'Handle ids duplication'
#   at t/db_dependent/Circulation/Returns.t line 333.
# Looks like you failed 1 test of 5.


Please fix ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #47 from Nick Clemens  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #46 from Owen Leonard  ---
(In reply to Tomás Cohen Arazi from comment #45)
> I realize dropping my follow-up here and saying we are ready to go
> can feel rude, that's not my intention!

Also I told him he should do it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #45 from Tomás Cohen Arazi  ---
The follow-up is my two cents to get this pushed. The link is really pointing
to both Windows and macOS downloads so I thought is was worth changing it like
this, and using the icons we already have with Font Awesome.

If there is disagreement, this can be put back in 'In discussion' status. I
realize dropping my follow-up here and saying we are ready to go can feel rude,
that's not my intention!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20580] create_superlibrarian.pl should accept parameters

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20580

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 18.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the exceptions

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 because of caller()

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
Summary|Update minimum version of   |Update minimum version of
   |Perl to 5.20|Perl to 5.20 because of
   ||caller()
 Status|Pushed to Master|CLOSED

--- Comment #11 from Jonathan Druart  
---
Reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20594] Revert Perl version to 5.10

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20594
Bug 20594 depends on bug 20104, which changed state.

Bug 20104 Summary: Update minimum version of Perl to 5.20 because of caller()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104

   What|Removed |Added

 Status|Pushed to Master|CLOSED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19794] Rename RLIST - Routing list notice template as it's not related to routing lists

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #54 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #41 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #42 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 Status|In Discussion   |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74101|0   |1
is obsolete||

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 74581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74581=edit
Bug 20322: (follow-up) fix validator.w3.org complaints - extra /div

The intranet-bottom.inc has the closing div, just deleted
the last one.

Signed-off-by: Mark Tompsett 

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74100|0   |1
is obsolete||

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 74580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74580=edit
Bug 20322: (follow-up) use tooltips for warning

This puts similar old text into tool tips for the overdues.
Hover over the overdues, and the tool tips should appear and
be similar to what the text was before.

Signed-off-by: Mark Tompsett 

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 74582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74582=edit
Bug 20322: (QA follow-up) Use Font Awesome icons

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74099|0   |1
is obsolete||

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 74579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74579=edit
Bug 20322: (follow up) design refresh for circulation page

Further revisions, compromise.

- 4 columns to three
- offline circulation demoted to below the intranet homepage preference,
and no buttons, due to its relative lack of everyday use.

Signed-off-by: Katrin Fischer 

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74098|0   |1
is obsolete||

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 74578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74578=edit
Bug 20322: (follow-up) Circulation page layout and design update

This follow-up makes some suggestions about how to push this further:

- Put content in four columns which reduces to two on smaller screens
- Adjust font size of large links
- Move Offline Circulation links into its own column
- Add image icons to the Firefox extension and Windows application
  download links
- Improve indentation in template

Signed-off-by: Katrin Fischer 

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74097|0   |1
is obsolete||

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 74577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74577=edit
Bug 20322: design refresh for circulation page

do note, I don't actually mind if these aren't the changes eventually accepted.
I just know it needs doing and starting it will hopefully get some gears
turning.

To test:
Click all the links and check they work.
Do you like the styling? it's different. :)

Signed-off-by: Katrin Fischer 

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #40 from Jonathan Druart  
---
Created attachment 74576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74576=edit
Bug 18790: Prevent the tests to fail if precision changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #32 from Jonathan Druart  
---
What's wrong with the patches, could they be considered ok as a quick fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20365] Allow several open orders on subscription

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |---
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74387|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20619] Remove last occurrences of long gone syspref (opacsmallimage)

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20619

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20619] Remove last occurrences of long gone syspref (opacsmallimage)

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20619

Owen Leonard  changed:

   What|Removed |Added

  Attachment #74543|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 74575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74575=edit
Bug 20619: Remove last occurrences of long gone syspref (opacsmallimage)

Code was commented anyway, so it was useless

Test plan:
1. Read the diff
2. Confirm that it only removes comments
3. Confirm that there are no remaining references to this syspref in the
   code (only remaining references are in updatedatabase.pl and release
   notes)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #48 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #39)
> 3) 
> >> - choice vs multiple in the added KohaManualLanguage sys pref
> 
> >It's a choice indeed.
> 
> Hm, what I was thinking about was a multiple indeed. We usually have at
> least German and English installed for staff, often Spanish and French now
> too. I would like to use the pref to indicate existing manuals for staff
> activated languages. So when I open the help and it matches one of the
> selected languages I get the right language manual. Makes sense?

The pref is the default value.

If the pref is set to English and the interface is in Spanish, the manual will
be in Spanish. If the interface is in Esperanto, the manual will be in English
(the manual is not translated in Esperanto, yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #18 from Marjorie Barry-Vila  ---
(In reply to Katrin Fischer from comment #17)
> I think tabs. Could we keep the content or is that not possible?

Hi Katrin,
When I read Jeremy's first comment, he talks about Batch items
modification/deletion.
I understand that patch proposed by Aleisha concerns only thr tool for batch
record modification/deletion.
Do I need to open a new bug for tool "batch items modification"?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #47 from Jonathan Druart  
---
Created attachment 74574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74574=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #43 from Jonathan Druart  
---
Created attachment 74570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74570=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #45 from Jonathan Druart  
---
Created attachment 74572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74572=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #44 from Jonathan Druart  
---
Created attachment 74571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74571=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #41 from Jonathan Druart  
---
Created attachment 74568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74568=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #46 from Jonathan Druart  
---
Created attachment 74573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74573=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #42 from Jonathan Druart  
---
Created attachment 74569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74569=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73931|0   |1
is obsolete||
  Attachment #73932|0   |1
is obsolete||
  Attachment #73933|0   |1
is obsolete||
  Attachment #73934|0   |1
is obsolete||
  Attachment #73935|0   |1
is obsolete||
  Attachment #73936|0   |1
is obsolete||
  Attachment #73937|0   |1
is obsolete||
  Attachment #73938|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 74567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74567=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #138 from Tomás Cohen Arazi  ---
(In reply to Roch D'Amour from comment #134)
> Working on this and wondering what could be a good default value for
> accessdir?
> 
> Also, renaming accessdir to access_dir make sense to me, I will include this
> change in my fix to make this feature unicode proof.

This configuration entry should default to empty.

The patch is missing to add the entry in debian/templates/koha-conf-site.xml.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 229 matches

Mail list logo