[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #2 from Nick Clemens --- Selenium tests may be messy, I have not written them in some time, and the circ rules table has few identifying classes etc. We don't execute in a transaction, but I didn't know if this is intentional? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #1 from Nick Clemens --- Created attachment 87305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87305&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22619] New: Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug ID: 22619 Summary: Adding a new circ rule with unlimited checkouts is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- On bug 18925 we missed a case of fixing null/empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582
--- Comment #20 from Owen Leonard ---
(In reply to Tomás Cohen Arazi from comment #19)
> The only doubt I had is if we should use
> mime types instead.
This was my approach: Use the simple notation ("css" or "javascript") where it
was possible, and the mime type ("text/html") where it was necessary for
specificity. I'm fine with using the mime type notation consistently if folks
prefer.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #88 from David Cook --- Maybe this would be a compromise for Ere's situation: https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Arbitrary-SQL-through-a-custom-ResultSource It wouldn't work for my scenario as I'm doing higher performance inserts, but this might be a nice way of adding arbitrary SQL while maintaining use of the DBIx::Class framework? (I was inspired by Class::DBI. I work on a legacy project that uses Class::DBI and it has some functionality for adding arbitrary SQL to the ORM: https://metacpan.org/pod/Class::DBI#Ima::DBI-queries) There's also some interesting discussion at https://www.perlmonks.org/?node_id=700283. I wonder if a person could define a custom search through https://metacpan.org/pod/DBIx::Class::ResultSet#ATTRIBUTES to achieve the performance that Ere wants. Ere, you're not re-using statement handles, right? So are you getting performance improvement basically by reducing the number of SQL queries being made? If so, you might be able to avoid the arbitrary SQL by just making a more detailed search as noted in the attributes link above. Worth thinking about maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #6 from Magnus Enger --- Would "If on loan" make more sense? That seems to be what is actually checked by the code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #22 from Liz Rea --- Just noting that I resolved a small conflict in the tests (they still pass) and added a follow up to address Jonathan's use patron-title.inc request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #20 from Liz Rea --- Created attachment 87303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87303&action=edit Bug 17171: (QA Followup) Add message to batch checkout template Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #21 from Liz Rea --- Created attachment 87304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87304&action=edit Bug 17171: (QA Follow up) Using patron-title.inc for names Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Liz Rea changed: What|Removed |Added Attachment #73258|0 |1 is obsolete|| Attachment #73315|0 |1 is obsolete|| --- Comment #19 from Liz Rea --- Created attachment 87302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87302&action=edit Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon Signed-off-by: BWS Sandboxes Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #3) > Hi Tomas, > > patch doesn't apply, can you please rebase? I rebased it, but you should ask Agustin :-P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #19 from Tomás Cohen Arazi --- Great job, Owen. Works as expected. The only doubt I had is if we should use mime types instead. But not important and works great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87288|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 87301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87301&action=edit Bug 21582: Use CodeMirror for *UserJS & *UserCSS This patch adds CodeMirror syntax highlighting by default to JS and CSS system preferences. HTML preferences will use CodeMirror editors if UseWYSIWYGinSystemPreferences is disabled. Three new CodeMirror files are added to support three new syntax highlighting modes: XML (for HTML), CSS, and JS. A new option is added to *.pref file configurations for textareas which are intended for HTML, JS, or CSS: syntax. This option is passed to the CodeMirror configuration to control syntax highlighting mode. Textareas without a syntax option specified will not have CodeMirror enabled. To test, apply the patch and go to Administration -> System preferences. Test the behavior of several preferences which use as their input. For example: - OPACUserJS (JS) - IntranetUserCSS (CSS) - OpacHeader (HTML) - BibtexExportAdditionalFields (no highlighting) Text entry in each of these should have the correct syntax highlighting applied to them. All data should be saved correctly. Test with UseWYSIWYGinSystemPreferences both on and off. Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- Nice useful enhancement. No regressions found, QA scripts pass (with the exception of a false failure in the template check) Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #87121|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Attachment #87118|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 87297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87297&action=edit Bug 10796: Add Koha::Patron::Category->effective_change_password method This method checks whether the local $self->change_password is set to override the OpacPasswordChange syspref (i.e. if it is set to a bool) or undef, in which case it falls back to the value of the syspref To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #17 from Martin Renvoize --- Created attachment 87300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87300&action=edit Bug 10796: (QA follow-up) Changing password recovery verbiage for users who are disallowed online password resets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Attachment #87120|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 87299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87299&action=edit Bug 10796: Use $category->effective_change_password in the OPAC This patch makes the OPAC pages that rely on OpacPasswordChange use the current patron's category to make the decision to allow password change or not. It does so by making sure all the places in which OpacPasswordChange was used, use $logged_in_user->category->effective_change_password instead. Special attention is required on the case of opac-registration-verify.pl in which the use of an unblessed Koha::Patron object is changed in favour of the blessed object, so we can actually use the new method to make a decision on the text to display. To test: - Go through the OPAC pages, check that the password change strings and links are displayed only whne appropriate. - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Attachment #87119|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 87298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87298&action=edit Bug 10796: Handle can_change_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21968] Don't make it possible to put a return date prior to the loan date with SpecifyReturnDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21968 Marjorie Barry-Vila changed: What|Removed |Added Version|unspecified |18.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What|Removed |Added Attachment #87117|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 87296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87296&action=edit Bug 10796: DB update Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #48 from Martin Renvoize --- Works well, nice clear patches, no regressions and passes the qa scripts (with the notable exception of a false failure for the template plugin) Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #47 from Martin Renvoize --- Created attachment 87295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87295&action=edit Bug 21890: (QA follow-up) Use List::Util::any When possible it's a good idea to use `any` from List::Util to shortcut on the first occurence of a truthy value. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Attachment #86867|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize --- Created attachment 87290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87290&action=edit Bug 21890: Handle can_reset_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890
Martin Renvoize changed:
What|Removed |Added
Attachment #86870|0 |1
is obsolete||
--- Comment #45 from Martin Renvoize ---
Created attachment 87293
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87293&action=edit
Bug 21890: Allow restricting password resets by patron category
This patch makes the templates relying on the OpacResetPassword syspref
use the introduced TT plugin method instead by changing:
[% IF Koha.Preference('OpacResetPassword') %]
=>
[% IF Categories.can_any_reset_password %]
To test:
- Verify that all the places in which the 'forgot password' link is
displayed in OPAC keep working, provided there's at least one category
that has the flag set
- Attempt to recover the password for a patron that belong to a valid
category (i.e. that has the flag set)
=> SUCCESS: You can go through the normal process
- Attempt to recover the password for a patron that belongs to a
category with the flag unset.
=> SUCCESS: Once Koha identifies your category, you are told you are not
allowed to do it
- Sign off :-D
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Attachment #86866|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize --- Created attachment 87289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87289&action=edit Bug 21890: DB updates This patch adds a new column to the categories table: 'reset_password' which is a boolean, and represents, well... that. The value itself is nullable. The idea is that OpacResetPassword governs the general behaviour, and this can be overriden at category-level. Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Attachment #86911|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 87294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87294&action=edit Bug 21890: Wrap message in span Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Attachment #86869|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize --- Created attachment 87292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87292&action=edit Bug 21890: Add can_any_reset_password() to the Categories TT plugin This patch introduces a method to the Koha::Template::Plugin::Categories TT plugin. This methods queries for categories filtering them by effective_reset_password flag set, and returns a boolean representing the fact that there's at least one category allowed. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Categories.t => SUCCESS: Tests pass! - Sign off :-D Caveat: this patch/tests require the schema to be updated Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What|Removed |Added Attachment #86868|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize --- Created attachment 87291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87291&action=edit Bug 21890: Add Koha::Patron::Category->effective_reset_password method This method checks wether the local $self->reset_password is set to override the OpacResetPassword syspref (i.e. if it is set to a bool) or undef, in which case if falls back to the value of the syspref. To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890
--- Comment #40 from Martin Renvoize ---
Comment on attachment 86869
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86869
Bug 21890: Add can_any_reset_password() to the Categories TT plugin
Review of attachment 86869:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21890&attachment=86869)
-
::: Koha/Template/Plugin/Categories.pm
@@ +33,5 @@
> return Koha::Patron::Categories->find( $categorycode )->description;
> }
>
> +sub can_any_reset_password {
> +return ( grep { $_->effective_reset_password } @{
> Koha::Patron::Categories->search->as_list } )
I'd prefer a List::Util::any call here: https://metacpan.org/pod/List::Util#any
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22618] New: Tests in t/Acquisition.t are actually database dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Bug ID: 22618 Summary: Tests in t/Acquisition.t are actually database dependent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Here are the results of running t/Acquisition.t without a database set up: t/Acquisition.t .. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at C4/Templates.pm line 154. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at C4/Auth_with_cas.pm line 42. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. t/Acquisition.t .. 1/3 unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Can't call method "config" on unblessed reference at Koha/Database.pm line 56. # Child (Test for get_rounded_price) exited without calling finalize() # Failed test 'Test for get_rounded_price' # at /usr/local/share/perl/5.20.2/Test/Builder.pm line 279. # Looks like you failed 1 test of 3. # Looks like your test exited with 2 just after 3. t/Acquisition.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/3 subtests Test Summary Report --- t/Acquisition.t (Wstat: 512 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 2 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.02 sys + 2.11 cusr 0.13 csys = 2.29 CPU) Result: FAIL These tests should be moved to a file in t/db_dependent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- wont backport to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 --- Comment #8 from Lucas Gass --- not backporting this to the 18.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #87 from Lucas Gass --- missing dependencies and wont be backporting to the 18.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21049] Rancor 007 field does not retain value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22536] Display problem in Holds to Pull report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22617] New: Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22617 Bug ID: 22617 Summary: Checkout notes pending dashboard link - error received even though manage_checkout_notes permission set. Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucy.vaux-har...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Target Milestone: --- When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the ‘Checkout notes pending’ link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- pushed to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 --- Comment #4 from Martin Renvoize --- On second thoughts.. why do we look for 'W' at all in that query?.. 'W' = Writeoff == Credit.. should we not be looking solely for the 'L' (and/or 'LR') debt line? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22608] Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22608 Claudio changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #27 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- this isn't necessary in 18.05, not backporting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- not backporting ES bugs/features to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21974] cxn_pool must be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- not backporting ES bug fixes/features to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2096] Label sources for OPAC descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2096 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|REOPENED|In Discussion --- Comment #6 from Liz Rea --- Hi Marjorie, Could you supply a record that clearly demonstrates this problem? Just easier when we can see what you see. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- not backporting enhancement to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #25 from Lucas Gass --- cant prove t/db_dependent/api/v1/acquisitions_funds.t correctly in 18.05.x, not backporting new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Liz Rea changed: What|Removed |Added Attachment #87278|0 |1 is obsolete|| --- Comment #17 from Liz Rea --- Created attachment 87288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87288&action=edit Bug 21582: Use CodeMirror for *UserJS & *UserCSS This patch adds CodeMirror syntax highlighting by default to JS and CSS system preferences. HTML preferences will use CodeMirror editors if UseWYSIWYGinSystemPreferences is disabled. Three new CodeMirror files are added to support three new syntax highlighting modes: XML (for HTML), CSS, and JS. A new option is added to *.pref file configurations for textareas which are intended for HTML, JS, or CSS: syntax. This option is passed to the CodeMirror configuration to control syntax highlighting mode. Textareas without a syntax option specified will not have CodeMirror enabled. To test, apply the patch and go to Administration -> System preferences. Test the behavior of several preferences which use as their input. For example: - OPACUserJS (JS) - IntranetUserCSS (CSS) - OpacHeader (HTML) - BibtexExportAdditionalFields (no highlighting) Text entry in each of these should have the correct syntax highlighting applied to them. All data should be saved correctly. Test with UseWYSIWYGinSystemPreferences both on and off. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- not backporting enhancement to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 --- Comment #6 from Josef Moravec --- Created attachment 87287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87287&action=edit Bug 22594: Validate SMS messaging numbers using the E.164 format Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. Test plan: 1) Apply this patch 2) Enable SMS message ( you can set to Email to enable ) 3) Test entering and updating SMS numbers on the OPAC and staff interfaces. 4) Note you can only enter a 1 to 14 digit number with an optional + sign at the beginning ( used to indicate the number includes a country calling code ) Signed-off-by: Liz Rea Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 --- Comment #3 from Martin Renvoize --- Bug 22563 could be very helpful here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22563 CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- missing dependency for 18.05.x, not backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22616] updating error text messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22616 --- Comment #1 from Liz Rea --- Created attachment 87286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87286&action=edit Bug 22616: Updating error text messages To test: Apply this patch Go to a borrower that doesn't exist, check that the error message is displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=) Go to an item, subscription, biblio that don't exist, check that the error message is correct and the links work Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22616] updating error text messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22616 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22616] New: updating error text messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22616 Bug ID: 22616 Summary: updating error text messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- There were multiple error messages in the staff client that had slightly awkward text, for example: "This patron does not exist" should be "Patron not found." "This $thing does not exist" should be "$thing not found." "Find another $thing?" should be "Return to search." "You are not allowed to see the information of this patron" should be "This account cannot view requested patron information" - this change makes it less personal, and might remind a person to check another account or to ask a supervisor if access is really required. I say this because it's not always the *person* who can't see a patron record, but the account that is currently logged in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2096] Label sources for OPAC descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2096 Marjorie Barry-Vila changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Swapped tabs for spaces to keep the QA script happy. Tested and works as expected, though perhaps we should also be validating we're getting good data on the serverside too.. I didn't check if this was already the case. Signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #86455|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Attachment #85911|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #8 from Martin Renvoize --- Created attachment 87285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87285&action=edit Bug 20830: Make sure a fund is selected when ordering from a stage file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #183 from Lucas Gass --- not backporting enhancement to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||martin.renvoize@ptfs-europe ||.com --- Comment #31 from Martin Renvoize --- Did this get fixed somewhere else already.. looks like both patches are applied but I can't seen any reference to them in the git logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22615] Add /ill_backends endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Josef Moravec --- This is work-in-progress, but I am sharing it in hope I got some feedback. We need to think of what should be capabilities structure presented in response. For now I used raw data returned by $backend->capabilities method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22615] Add /ill_backends endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615 --- Comment #1 from Josef Moravec --- Created attachment 87284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87284&action=edit Bug 22615: Add /ill_backends endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22615] Add /ill_backends endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | CC||andrew.isherwood@ptfs-europ ||e.com URL||https://wiki.koha-community ||.org/wiki/Illbackends_endpo ||int_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22615] New: Add /ill_backends endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615 Bug ID: 22615 Summary: Add /ill_backends endpoint Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 87283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87283&action=edit Bug 22538: Add a noticeable alert about waiting holds In SCO, bug 21772 introduced holds information, but it lacked the capability to attract atention when any of those holds was in waiting status. Because SCO and opac-user uses the same include file for holds table, this bug applies to both modules. To test: 1) Have a patron with holds in waiting status and pending status. 2) Enable SCO module. 3) Holds tab label contains holds count, but doesn't inform that there is something that requires attention. 5) Holds tab content has no visual aid to recognize without reading effort which holds are in waiting status. 6) Apply this patch => SUCCESS: Holds tab label has a visual aid to indicate that something requires attention, and in holds table it's easy to recognize waiting holds without reading effort. 7) Sign off Sponsored-by: Theke Solutions Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86783|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Martin Renvoize changed: What|Removed |Added Attachment #86831|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 87282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87282&action=edit Bug 17978: Unit tests for changes Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #24 from Martin Renvoize --- Created attachment 87280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87280&action=edit Bug 17978: Circ rules will not limit holds The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose. Test Plan: 1) Set ReservesControlBranch to "item's home library" 2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds 3) Place 3 record level holds, you can but you should not be able to! 4) Delete the holds 5) Apply this patch 6) Attempt to place 3 record level holds 7) Note that you cannot! Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #27 from Martin Renvoize --- Worked well, no regressions found and the QA script is happy.. passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Martin Renvoize changed: What|Removed |Added Attachment #86829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Martin Renvoize changed: What|Removed |Added Attachment #86830|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 87281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87281&action=edit Bug 17978: Check if hold can be placed before placing on placerequest.pl To test: 1 - Set an All/All/All rule with reserves limited 2 to 2 - Search in the staff side 3 - Select all records (or more than 2) from the results 4 - Click 'Place hold' 5 - Find a patron, place holds 6 - You get more holds than you should 7 - Delete those holds 8 - Apply patch 9 - Search and select more than 2 records 10 - Find patron, place holds 11 - Only 2 holds are placed Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #11 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Bug 22512 depends on bug 22518, which changed state. Bug 22518 Summary: accounttype 'O' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22126] OMNIBUS: Update cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22126 Bug 22126 depends on bug 22127, which changed state. Bug 22127 Summary: Update dateaccessioned value builder https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22127] Update dateaccessioned value builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21646, which changed state. Bug 21646 Summary: Clean up Overdrive template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21646] Clean up Overdrive template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
