[Koha-bugs] [Bug 22889] Typo found in intranet-tmpl/prog/en/includes/serials-toolbar.inc and intranet-tmpl/prog/en/modules/admin/admin-home.tt

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22889

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Another typo fund in: intranet-tmpl/prog/en/modules/admin/admin-home.tt

Found in line #20: This feature allows you to retrieve and share data
(subscription patterns and reports) with other Koha libaries.

Github permalink:
https://github.com/Koha-Community/Koha/blob/31684a426be4dcdf75a06f1f15fcfc73726fa6ae/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt#L20

Word "libaries" should be "libraries"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22889] Typo found in intranet-tmpl/prog/en/includes/serials-toolbar.inc and intranet-tmpl/prog/en/modules/admin/admin-home.tt

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22889

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Typo found in   |Typo found in
   |intranet-tmpl/prog/en/inclu |intranet-tmpl/prog/en/inclu
   |des/serials-toolbar.inc |des/serials-toolbar.inc and
   ||intranet-tmpl/prog/en/modul
   ||es/admin/admin-home.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22889] New: Typo found in intranet-tmpl/prog/en/includes/serials-toolbar.inc

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22889

Bug ID: 22889
   Summary: Typo found in
intranet-tmpl/prog/en/includes/serials-toolbar.inc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: intranet-tmpl/prog/en/includes/serials-toolbar.inc
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Typo found in Typo found in intranet-tmpl/prog/en/includes/serials-toolbar.inc

Word "librairies" should be "libraries"

whit line 70:  Share

Github pemalink:
https://github.com/Koha-Community/Koha/blob/31684a426be4dcdf75a06f1f15fcfc73726fa6ae/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc#L70

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #2 from Liz Rea  ---
I was having trouble replicating the original problem, does it still happen for
you? 

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Liz Rea  ---
Oh you are not going to like this:

Using index info to reconstruct a base tree...
M   C4/Suggestions.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Suggestions.pm
CONFLICT (content): Merge conflict in C4/Suggestions.pm
error: Failed to merge in the changes.

Terribly sorry >.<

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22850] SharedContent.t wrongly use ->set_userenv

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850

Liz Rea  changed:

   What|Removed |Added

  Attachment #89353|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 89578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89578&action=edit
Bug 22850: Do no longer use set_userenv in tests (SharedContent.t)

Since bug 21817 we should use the mock_userenv subroutine instead.

Test plan:
The tests must pass after this patch

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22850] SharedContent.t wrongly use ->set_userenv

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #33 from Liz Rea  ---
GO GO UNIT TEST MASTAH. :D We think the concept is good afaict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22849] Data shared without agreement

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849

Liz Rea  changed:

   What|Removed |Added

  Attachment #89355|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 89577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89577&action=edit
Bug 22849: Do not share data (Mana) without agreement

A couple of things wrong in serials/subscription-add.pl

1.
447 if ( defined( $query->param('mana_id') ) ) {

It's always defined, you wanted to test with ""

2.
375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq
"subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){

Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case

So we are sharing data whereas the library did not decide yet!

Test plan:
You need to be familiar you Mana to test this patch.

JD: I did not test this patch

Signed-off-by: Liz Rea 
Tested this, adding subscription still works, mana seems not to be queried.
tested on top of 22812.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22849] Data shared without agreement

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #109 from Liz Rea  ---
That's true, I'll retest with those set away from the defaults, maybe it will
make it work the way I think they probably want it.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Liz Rea  changed:

   What|Removed |Added

  Attachment #89562|0   |1
is obsolete||
  Attachment #89563|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 89575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89575&action=edit
Bug 22878: Add tests

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

--- Comment #4 from Liz Rea  ---
Created attachment 89576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89576&action=edit
Bug 22878: Do not pass layout_id on creating a layout

Attempting to create a patron card layout with mysql strict mode on gives the
following error:
  DBD::mysql::st execute failed: Incorrect integer value: '' for column
'layout_id' at row 1

Test plan:
- Turn on sql_strict_modes
- Create a new patron card
=> Must success with this patch applied

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

--- Comment #17 from Lucas Gass  ---
not backporting to 18.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #16 from Lucas Gass  ---
not backporting to 18.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #26 from Lucas Gass  ---
missing dependency not backporting to 18.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21899] Update MARC21 frameworks to Update 27 (November 2018)

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21899

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
not backporting enhancement to 18.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22716] Use gender-neutral pronouns in system preference descriptions

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22716

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Maryse Simard  changed:

   What|Removed |Added

  Attachment #76926|0   |1
is obsolete||

--- Comment #10 from Maryse Simard  ---
Created attachment 89574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89574&action=edit
Bug 14493: export_borrowers.pl - Export patron attributes

Tweaked Vitor's original patch to accomodate changes to the file.

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #13 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702

--- Comment #9 from Lucas Gass  ---
not needed in 18.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #11 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #21 from Michal Denar  ---
Created attachment 89572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89572&action=edit
Bug 22812: Fix GROUP BY in checkrouting

On the way, let fix this error
DBD::mysql::st execute failed: Mixing of GROUP columns
(MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is
no GROUP BY clause [for Statement "SELECT count(routingid) routingids
FROM subscription LEFT JOIN subscriptionroutinglist

Test plan:
Create a routing list, search for subscriptions
In the action list you should see "Edit routing list (1)" or "New
routing list"

Signed-off-by: Liz Rea 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #22 from Michal Denar  ---
Created attachment 89573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89573&action=edit
Bug 22812: Use Koha::Subscription in NewSubscription

Starting to write tests I realize that we are going to add too much
specific logic which is already handled in Koha::Object->store.
The easiest and safe way is to use it :)

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #20 from Michal Denar  ---
Created attachment 89571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89571&action=edit
Bug 22812: Add tests for checkrouting

Signed-off-by: Liz Rea 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21975] Unnecessary substitutions in automatic item modification by age

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21975

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #25 from Lucas Gass  ---
missing dependencies for 18.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

Michal Denar  changed:

   What|Removed |Added

  Attachment #89535|0   |1
is obsolete||
  Attachment #89536|0   |1
is obsolete||
  Attachment #89537|0   |1
is obsolete||
  Attachment #89561|0   |1
is obsolete||

--- Comment #19 from Michal Denar  ---
Created attachment 89570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89570&action=edit
Bug 22812: Fix new subscription with strict sql modes

With sql_strict_modes turned on, if you try to create a new subscription
you will get:
Incorrect integer value: '' for column '$INT_COLUMN' at row 1

Signed-off-by: Liz Rea 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
not backporting ES bugs to 18.05.x, not backporting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22742] RenewLoan return wrong datetime format

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742

Bin  changed:

   What|Removed |Added

  Attachment #89565|0   |1
is obsolete||

--- Comment #3 from Bin  ---
Created attachment 89568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89568&action=edit
Bug 22742: FIX : RenewLoan returns correct datetime format

Test plan :
Call RenewLoan a few times and check the date returned is correct (minute
wise).

Signed-off-by: Arthur Bousquet 
Signed-off-by: Bin Wen 

https://bugs.koha-community.org/show_bug.cgi?id=22472
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22742] RenewLoan return wrong datetime format

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742

Bin  changed:

   What|Removed |Added

  Attachment #89568|0   |1
is obsolete||

--- Comment #4 from Bin  ---
Created attachment 89569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89569&action=edit
Bug 22742: FIX : RenewLoan returns correct datetime format

Test plan :
Call RenewLoan a few times and check the date returned is correct (minute
wise).

Signed-off-by: Arthur Bousquet 
Signed-off-by: Bin Wen 

https://bugs.koha-community.org/show_bug.cgi?id=22472

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22090] Cash register report missing data in CSV export

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22090

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist?

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472

Bin  changed:

   What|Removed |Added

  Attachment #89566|0   |1
is obsolete||

--- Comment #12 from Bin  ---
Created attachment 89567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89567&action=edit
Bug 22742: FIX : RenewLoan returns correct datetime format

Test plan :
Call RenewLoan a few times and check the date returned is correct (minute
wise).

Signed-off-by: Arthur Bousquet 
Signed-off-by: Bin Wen 

https://bugs.koha-community.org/show_bug.cgi?id=22472

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist?

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472

--- Comment #11 from Bin  ---
Created attachment 89566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89566&action=edit
Bug 22742: FIX : RenewLoan returns correct datetime format

Test plan :
Call RenewLoan a few times and check the date returned is correct (minute
wise).

Signed-off-by: Arthur Bousquet 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds the
  release notes||ability to define
   ||additional fields to store
   ||information about
   ||acquisition baskets.
   ||
   ||It
   ||refactors and centralizes
   ||the code used to add fields
   ||to subscriptions as well.
   ||
   ||Users can name additional
   ||fields, tie them to
   ||authorized values, and
   ||specify whether the fields
   ||can be searched in the
   ||acquisitions module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Keywords||rel_19_05_candidate

--- Comment #12 from Nick Clemens  ---
This is cleanup I would like to see move ahead if the browser issue is
reasonable, will test next week so considering for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22867] UniqueItemFields preference value should be pipe-delimited

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Keywords||rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Nick Clemens  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate
 CC||n...@bywatersolutions.com

--- Comment #12 from Nick Clemens  ---
I ran out of time for testing etc today, but this seems a culmination of a lot
of work we have done on improving this interface this cycle, I would like to
include it if we can resolve issues in the next few days

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #19 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com
   Keywords||additional_work_needed

--- Comment #16 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #15)

This one can be done in a follow-up please Kyle? Pushing for now

> Passing QA but frowning:
> 
> +my @itemtypes = sort map { uc $_->[0] } @{
> C4::Context->dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) };
> 
> +my @available_itemtypes = map { uc $_->[0] } @{
> $dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) };
> 
> Old school SQL..
> 

This seems okay to me, we should make a rule somewhere if we like this or not

> The earlier mention of --list-itemtypes is no blocker for me.
> Leaving final decision to RM ;)

Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #32 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21312] Show lockout on Patrons form

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #18 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22856] Show SQL code button should trigger CodeMirror view

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22742] RenewLoan return wrong datetime format

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #88341|0   |1
is obsolete||

--- Comment #2 from Arthur Bousquet  ---
Created attachment 89565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89565&action=edit
Bug 22742: FIX : RenewLoan returns correct datetime format

Test plan :
Call RenewLoan a few times and check the date returned is correct (minute
wise).

Signed-off-by: Arthur Bousquet 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22742] RenewLoan return wrong datetime format

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742

Arthur Bousquet  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the|This new feature adds the   |Sponsored by:
  release notes|ability to define a per day |Huntsville-Madison County
   |(or per hour) rental fee|Public Library
   |for rental items. The new   |(http://hmcpl.org/)
   |fee may be used as an   |
   |alternative to the fixed|This
   |price rental fee or in  |new feature adds the
   |conjunction with it.|ability to define a per day
   ||(or per hour) rental fee
   ||for rental items. The new
   ||fee may be used as an
   ||alternative to the fixed
   ||price rental fee or in
   ||conjunction with it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11000] koha-restore not working: Koha username error

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Katrin Fischer  ---
(In reply to Rudolf Byker from comment #4)
> As far as I can see, this is fixed. Shall we close the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This new feature adds the   |This new feature adds the
  release notes|ability for Koha to talk to |ability for Koha to talk to
   |a Mana Knowledge Base   |a Mana Knowledge Base
   |server, allowing libraries  |server, allowing libraries
   |to share a small, but   |to share a small, but
   |hopefully growing, number   |hopefully growing, number
   |sets of data.
  |sets of data.
   |
   |
   |Currently   |Currently
   |this includes subscription  |this includes sharing
   |patterns and ...|serial subscription
   ||patterns and reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature adds the
  release notes||ability for Koha to talk to
   ||a Mana Knowledge Base
   ||server, allowing libraries
   ||to share a small, but
   ||hopefully growing, number
   ||sets of data.
   ||
   ||Currently
   ||this includes subscription
   ||patterns and ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||Part of the ongoing effort
  release notes||to improve the
   ||maintainability of our
   ||codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577

Martin Renvoize  changed:

   What|Removed |Added

  Component|Acquisitions|Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21662] Missing developers from history

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature allows
  release notes||librarians with appropriate
   ||permissions to configure
   ||(show/hide/re-order) the
   ||search facets provided by
   ||elasticsearch.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761

--- Comment #39 from Jonathan Druart  
---
GetPreparedLetter is actually not called, hence the confusion.
Is there a good reason not to?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature adds the
  release notes||ability to define a per day
   ||(or per hour) rental fee
   ||for rental items. The new
   ||fee may be used as an
   ||alternative to the fixed
   ||price rental fee or in
   ||conjunction with it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22870] When adding a '#' into Rancor with a macro, the special character gets removed

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22870

Jonathan Druart  changed:

   What|Removed |Added

Summary|When adding a special   |When adding a '#' into
   |character into Rancor with  |Rancor with a macro, the
   |a macro, the special|special character gets
   |character gets removed  |removed
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
>From cateditor/macros/rancor.js:
238 contents = contents.replace( /#.*$/, '' );

So it's expected, what's following # is considered as a comment

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7862] Warns when creating a new notice

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #38 from Jonathan Druart  
---
Some notes about this:
1. The TT content has been moved but without being adjusted.
For instance:
- Should not we use library.branchname instead of LibraryName (otherwise we
will have to pass 'LibraryName' to all our templates)?
- Branches.GetName( patron.branchcode ), should not we prefer
patron.library.branchname?

If we do not know what is sent/used in the template, it will be a nightmare to
provide backward compatibility in next versions.

2. About evaltt, I really do not understand why we need it, the template has
been parsed already, we should not need to parse it again, I think the content
must be  displayed with $raw

3. +library => C4::Context::mybranch,
so library will be the branchcode, whereas we are expecting a Koha::Library
object

(In reply to Kyle M Hall from comment #29)
> > > ::: members/printfeercpt.pl
> > > @@ +83,2 @@
> > > >  
> > > >  $template->param(
> > > 
> > > There are more parameters than before, I would expect less.
> > > Is that correct?
> There are more parameters because I made the slip compatible with the
> existing syntax for the ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF slips.

I am sorry but I still do not understand that part. The variable we do not see
in the template will not be used, so for instance 'credit' is useless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #20 from Martin Renvoize  ---
Testers do please go ahead and test this however..

The work I'm doing is more as preparation for doing a QA.. I felt working
through the thought process involved in thinking about an alternative would be
the best way for me to get up to speed with this implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21662] Missing developers from history

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #93 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20485] Don't account for items timestamps when combining "dont_export_items=1" and "date" in misc/export_records.pl

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20485

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #10 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|cnighswon...@foundations.ed |jonathan.dru...@bugs.koha-c
   |u   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #41 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

--- Comment #8 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #6)
> Data::Printer isn't in our deps - can you use Data::Dumper instead?

Yup, good catch! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

--- Comment #7 from Jonathan Druart  
---
Created attachment 89564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89564&action=edit
Bug 22433: Use Data::Dumper instead of Data::Printer

Data::Printer is not in our deps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

--- Comment #2 from Jonathan Druart  
---
Created attachment 89563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89563&action=edit
Bug 22878: Do not pass layout_id on creating a layout

Attempting to create a patron card layout with mysql strict mode on gives the
following error:
  DBD::mysql::st execute failed: Incorrect integer value: '' for column
'layout_id' at row 1

Test plan:
- Turn on sql_strict_modes
- Create a new patron card
=> Must success with this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

--- Comment #1 from Jonathan Druart  
---
Created attachment 89562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89562&action=edit
Bug 22878: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|Seeking cosponsors  |Sponsored
  Text to go in the|The new feature adds the|Sponsored by Northeast
  release notes|ability to send a new   |Kansas Library System,
   |notice to the library,  |NEKLS (http://nekls.org/)
   |branch or a specific email  |
   |address whenever a purchase |The new feature adds the
   |suggestion is created.  |ability to send a new
   ||notice to the library,
   ||branch or a specific email
   ||address whenever a purchase
   ||suggestion is created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22433] SIP/Transaction.t is failing randomly

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #6 from Nick Clemens  ---
Data::Printer isn't in our deps - can you use Data::Dumper instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||22878


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878
[Bug 22878] cannot add a patron card layout with mysql strict mode on
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Jonathan Druart  
---
We can close it without moving the remaining one. No discussion and abandoned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19023] inventory tool performance

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Bug 19023 depends on bug 17819, which changed state.

Bug 17819 Summary: Performance 16.11 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22878] cannot add a patron card layout with mysql strict mode on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17258
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #11 from Jonathan Druart  
---
Actually there is something weird in master as well, the buttons are not
disabled when clicked. Sounds like a regression, isn't it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #10 from Jonathan Druart  
---
Quick note while testing: the "Save all XXX preferences" buttons do not behave
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #18 from Jonathan Druart  
---
Maybe I went a bit too far with this last patch, but it's definitely the way to
go. Sending back to NSO as I rewrote the original approach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #17 from Jonathan Druart  
---
Created attachment 89561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89561&action=edit
Bug 22812: Use Koha::Subscription in NewSubscription

Starting to write tests I realize that we are going to add too much
specific logic which is already handled in Koha::Object->store.
The easiest and safe way is to use it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22888


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888
[Bug 22888] Use DataTables for Koha news table filtering
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22888] New: Use DataTables for Koha news table filtering

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888

Bug ID: 22888
   Summary: Use DataTables for Koha news table filtering
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 22811
  Target Milestone: ---

On the Koha news page we display all news items in the table (rather than using
server-side pagination) so we can use DataTables' built-in column search/filter
features instead of having to submit a form and reload the page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811
[Bug 22811] Add button to clear DataTables filtering
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812

--- Comment #16 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #10)
> SELECT count(routingid) routingids FROM subscription LEFT JOIN
> subscriptionroutinglist ON subscription.subscriptionid =
> subscriptionroutinglist.subscriptionid order by ranking asc;
> 
> does not raise a warning with me on mariadb with sql mode:
> STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,
> NO_ENGINE_SUBSTITUTION
> 
> Do I overlook a setting?

MariaDB [koha_kohadev]> SET sql_mode =
'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION';
Query OK, 0 rows affected (0.01 sec)

MariaDB [koha_kohadev]> SELECT count(routingid) routingids FROM subscription
LEFT JOIN subscriptionroutinglist ON subscription.subscriptionid =
subscriptionroutinglist.subscriptionid WHERE subscription.subscriptionid = 1
ORDER BY ranking ASC;
ERROR 1140 (42000): Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no
GROUP columns is illegal if there is no GROUP BY clause

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #108 from Tomás Cohen Arazi  ---
(In reply to Agustín Moyano from comment #107)
> (In reply to Liz Rea from comment #106)
> > I think we'll just want to know which way the library that requested it
> > wants to go. I'm told there's some kind of meeting today that might shed
> > some light. :)
> > 
> > All of your notes make sense - I think it's working as you coded it, and
> > it's TBD whether that's how the requester wants it to work. Hopefully we
> > find out today!
> > 
> > Liz
> 
> Maybe if VOKAL want's Patron's hold group, or if it just makes sense to have
> it, I can add that option to Hold Pickup Library Match in a separate bug
> that depends on this one.
> 
> Agustín

Keep in mind there's this sysprefs already:
- canreservefromotherbranches
- ReservesControlBranch

both should affect this behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22053] Ability to disable some plugins

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #89551|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 89558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89558&action=edit
Bug 22053: (QA follow-up) Fix tests

This patch makes the tests enable the plugins that are required for
them. Otherwise unexpected failures can happen

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

--- Comment #7 from axel Amghar  ---
Created attachment 89560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89560&action=edit
Bug 20384: unit test for get_all_biblios_iterator &
get_all_authorities_iterator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

axel Amghar  changed:

   What|Removed |Added

  Attachment #89425|0   |1
is obsolete||

--- Comment #6 from axel Amghar  ---
Created attachment 89559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89559&action=edit
Bug 20384 - Elastic rebuild script improvements - options --offset & --length

This patch add the options --offset & --length to the script:
misc/search_tools/rebuild_elastic_search.pl

To test :
- apply the patch
- verify that the script by default is working, launch :
perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100

- launch with the option --offset
- then with the option --length
- launch with both options :
perl misc/search_tools/rebuild_elastic_search.pl -v -d -c 100 --offset
1000 --length 200
- verify that the total records indexed is 200

launch perl misc/search_tools/rebuild_elastic_search.pl --man
for help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #54 from Owen Leonard  ---
Created attachment 89556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89556&action=edit
Bug 21626: Add release dates to team

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #55 from Owen Leonard  ---
Created attachment 89557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89557&action=edit
Bug 21626: (follow-up) Minor tweaks to the columns formatting

This patch makes minor markup and CSS changes to improve the
column-formatting of team data. The primary goal of these changes is to
avoid showing a large blank space when using a development version. Some
text has been moved around to avoid validation errors.

To test, apply the patch and rebuild the staff client CSS.

Release and maintenance team information should be displayed in 3-column
sets. The information should look well-formatted when using a
development or non-development version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #51 from Owen Leonard  ---
Created attachment 89553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89553&action=edit
Bug 21626: Use teams.yaml for teams section

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #53 from Owen Leonard  ---
Created attachment 89555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89555&action=edit
Bug 21626: (follow-up) Performance Improvement

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #52 from Owen Leonard  ---
Created attachment 89554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89554&action=edit
Bug 21626: (follow-up) Changes based on feedback

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Owen Leonard  changed:

   What|Removed |Added

  Attachment #89307|0   |1
is obsolete||
  Attachment #89308|0   |1
is obsolete||
  Attachment #89309|0   |1
is obsolete||
  Attachment #89310|0   |1
is obsolete||
  Attachment #89311|0   |1
is obsolete||

--- Comment #50 from Owen Leonard  ---
Created attachment 89552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89552&action=edit
Bug 21626: Add teams.yaml to /docs

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >