[Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

--- Comment #16 from Nabila  ---
The patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #16 from Maryse Simard  ---
Patch doesn't apply

Applying: Bug 21852: Add more columns and column configuration to overdues
report
Using index info to reconstruct a base tree...
M   admin/columns_settings.yml
M   koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
M   koha-tmpl/intranet-tmpl/prog/js/datatables.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/datatables.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
Auto-merging admin/columns_settings.yml
error: Failed to merge in the changes.
Patch failed at 0001 Bug 21852: Add more columns and column configuration to
overdues report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954

Arthur Bousquet  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #90258|0   |1
is obsolete||

--- Comment #3 from Arthur Bousquet  ---
Created attachment 90261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90261&action=edit
Bug 22954: Minor markup error in OPAC messaging template

This patch corrects a minor error in opac-messaging.tt in order to
quiet errors returned by the HTML validator.

To reproduce the problem you should have the
EnhancedMessagingPreferencesOPAC  system preference enabled. Log in
to the OPAC and go to the "your messaging" page. Run the page through
the W3C validation service: https://validator.w3.org. Either by pasting
in the URL for the search results (if web accessible) or by viewing
source, copying, and pasting into "Validate by Direct Input."

This patch addresses this error:

 - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring
   the slash and treating as a start tag."

To test, apply the patch and try again to reproduce the validation
error. The error should no longer be present. There should be no
visible change to the page.

Signed-off-by: Nadine Pierre 
Signed-off-by: Arthur Bousquet 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #90207|0   |1
is obsolete||

--- Comment #14 from Arthur Bousquet  ---
Created attachment 90260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90260&action=edit
Bug 21534: Always compute wildcards

You get no results when searching with an hyphen + with * in query string (or
with preference QueryAutoTruncate) :
ie /cgi-bin/koha/opac-search.pl?q=saints-anges*

Looks like query-string by default does not compute wildcards, see
analyze_wildcard in :
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html

Test plan :
1) Use Elasticsearch
2) Create a record with "saints-anges"
3) Search for "saints-anges" => you get results
4) Search for "saints-anges*" => you get results
5) Search for "saints-ang*" => you get results

Signed-off-by: Michal Denar 
Signed-off-by: Arthur Bousquet 


 Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #90249|0   |1
is obsolete||

--- Comment #5 from Arthur Bousquet  ---
Created attachment 90259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90259&action=edit
Bug 22952: Markup error in OPAC suggestions template

This patch makes a minor correction to the OPAC suggestions template in
order to quiet an error returned by the HTML validator.

To reproduce the problem you should have the 'suggestion' system
preference turned on, and you should be logged in to the OPAC as a user
who has submitted one or more suggestions. View the "your purchase
suggestions" page in the OPAC. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses these errors:

 - "End tag div seen, but there were open elements."
 - "Unclosed element span."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Signed-off-by: Maryse Simard 
Signed-off-by: Bin Wen 
Signed-off-by: Nadine Pierre 
Signed-off-by: Arthur Bousquet 


 Current status: Signed Off

 Current patch-complexity: Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #89948|0   |1
is obsolete||

--- Comment #2 from Nadine Pierre  ---
Created attachment 90258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90258&action=edit
Bug 22954: Minor markup error in OPAC messaging template

This patch corrects a minor error in opac-messaging.tt in order to
quiet errors returned by the HTML validator.

To reproduce the problem you should have the
EnhancedMessagingPreferencesOPAC  system preference enabled. Log in
to the OPAC and go to the "your messaging" page. Run the page through
the W3C validation service: https://validator.w3.org. Either by pasting
in the URL for the search results (if web accessible) or by viewing
source, copying, and pasting into "Validate by Direct Input."

This patch addresses this error:

 - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring
   the slash and treating as a start tag."

To test, apply the patch and try again to reproduce the validation
error. The error should no longer be present. There should be no
visible change to the page.

Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Marie-Luce Laflamme  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #28 from Marie-Luce Laflamme  ---
Patch doesn't apply.

The 'Merge' is not recorded in the log viewer, only the deleted account is
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948

Bin Wen  changed:

   What|Removed |Added

  Attachment #90248|0   |1
is obsolete||

--- Comment #3 from Bin Wen  ---
Created attachment 90257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90257&action=edit
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23029] New: OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029

Bug ID: 23029
   Summary: OPAC Authorities Search. Internal Server Error.
Free-floating subdivisions imported from LOC
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbut...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Koha 18.11 on Ubuntu 16.04 (MariaDb) with Plack.


I recently discovered that the Library of Congress released their 2014
authorities as a free, open-access dataset in Marc8, xml, and Utf8 formats.
This is great!
(https://www.loc.gov/cds/products/MDSConnect-subject_authorities.html)

I have completed batch uploading the file successfully into Koha (about 320,000
records) and reindexed Zebra.

Part of the authority file includes free-floating subdivisions, identified by
the presence of a MARC21 authority tag 180.

I discovered an "Internal Server Error" page if I attempted to click on the
Details button of any of these sub-divisions' records in the OPAC authority
browse results page. My Plack error log reported the following error each time
I attempted to access the authorities details page from the OPAC:

"Can't call method "authtypetext" on an undefined value at
/usr/share/koha/opac/cgi-bin/opac/opac-authoritiesdetail.pl line 89."

I corrected this error by creating a new Authority Type using the pre-populated
value found in field 942 within these free-floating subdivision records (i.e.,
"GEN_SUBDIV") and assigning tag 180 as the "authority field to copy"

Once created, I was able to access the OPAC details page, as expected, and all
free-floating subdivisions were re-indexed as free-floating subdivisions. They
also became selectable as an authority type from the drop-down menu in the
Authority Search.

For a detailed explanation of the above, see:
http://craigbutosi.ca/2019/05/31/plack-error-authority-file-free-floating-subdivisions-koha-18-11/

The Authority Type GEN_SUBDIV should be defined in order to prevent the Plack
error from occurring.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Arthur Bousquet  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #90256|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #56 from Arthur Bousquet  ---
Created attachment 90256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90256&action=edit
Update release notes for the 19.05.00 release

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90161|0   |1
is obsolete||

--- Comment #57 from Maryse Simard  ---
Created attachment 90254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90254&action=edit
Bug 14242: (follow-up) Translateable js strings, $raw filter

Sponsored-by: Region Halland
Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90162|0   |1
is obsolete||

--- Comment #58 from Maryse Simard  ---
Created attachment 90255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90255&action=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90160|0   |1
is obsolete||

--- Comment #56 from Maryse Simard  ---
Created attachment 90253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90253&action=edit
Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes

To test, enter a valid ISBN complete with -
eg
978-1-78416-110-1

The search should still work

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90159|0   |1
is obsolete||

--- Comment #55 from Maryse Simard  ---
Created attachment 90252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90252&action=edit
Bug 14242: (follow-up) Change the icon to words

Fix a bug that meant it would search on empty ISBN

To test
1. Fill in a valid ISBN (Book data is correctly loaded)
2. Clear the ISBN from the field (Book data is correctly removed)
3. Tab away from the empty ISBN field: Data is loaded for a title
  "ISBN 0-9690745-2-2"
4. Apply patch
5. Repeat 1,2 and 3 notice a search is no longer done

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90242|0   |1
is obsolete||

--- Comment #4 from Nadine Pierre  ---
Created attachment 90249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90249&action=edit
Bug 22952: Markup error in OPAC suggestions template

This patch makes a minor correction to the OPAC suggestions template in
order to quiet an error returned by the HTML validator.

To reproduce the problem you should have the 'suggestion' system
preference turned on, and you should be logged in to the OPAC as a user
who has submitted one or more suggestions. View the "your purchase
suggestions" page in the OPAC. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses these errors:

 - "End tag div seen, but there were open elements."
 - "Unclosed element span."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Signed-off-by: Maryse Simard 
Signed-off-by: Bin Wen 
Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90157|0   |1
is obsolete||

--- Comment #53 from Maryse Simard  ---
Created attachment 90250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90250&action=edit
Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s) into
search fields for Google Books API and automaticly fills requested fields with
search result.

Use in OPAC purchase suggestions to automaticly fill out fields when entering
ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACAutoFill"
3. Log into OPAC and go to purchase suggetions page
4. Write a valid ISBN into the ISBN field and press the edit icon next to the
   field, or unfocus the field.
5. Title, Author, Publisher and Item Type fields should now be filled
   automaticly.
6. Press "undo" to undo - should restore all changed fields to original values

Tested all patches together, works as expected.
Signed-off-by: Marc 

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Maryse Simard  changed:

   What|Removed |Added

  Attachment #90158|0   |1
is obsolete||

--- Comment #54 from Maryse Simard  ---
Created attachment 90251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90251&action=edit
Bug 14242: (follow up) renaming syspref

OPACAutoFill -> OPACSuggestionAutoFill

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Arthur Bousquet  changed:

   What|Removed |Added

 CC||arthur.bousq...@inlibro.com
  Attachment #90246|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

Arthur Bousquet  changed:

   What|Removed |Added

  Attachment #90247|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

--- Comment #13 from Katrin Fischer  ---
No problem, we all started out once. :)

Ah, and to obsolete the ones attached falsely you can uncomment their lines  in
the git bz attach or git bz edit commands. The other option is to do it here:
Details > Edit details > check obsolete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

--- Comment #12 from Arthur Bousquet  ---
Yes, sorry it really seems like I'm having some trouble with git-bz =/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

Katrin Fischer  changed:

   What|Removed |Added

 CC||arthur.bousq...@inlibro.com

--- Comment #11 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #10)
> Hi Arthus, same issue as on bug 11573 here, wrong patch attached. Can you
> please check your git bz command? If the patch is applied, the right command
> here would be: git bz attach 21534 HEAD
> 
> For multiple patches (4): git bz attach  HEAD~4..

Arthur, not Arthus, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Hi Arthus, same issue as on bug 11573 here, wrong patch attached. Can you
please check your git bz command? If the patch is applied, the right command
here would be: git bz attach 21534 HEAD

For multiple patches (4): git bz attach  HEAD~4..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178

--- Comment #16 from Agustín Moyano  ---
(In reply to Tomás Cohen Arazi from comment #15)
> (In reply to Agustín Moyano from comment #14)
> > (In reply to Josef Moravec from comment #13)
> > > Just one question:
> > > 
> > > why are all the language and layout files added to the codebase, when you
> > > need only the ones named all.js?
> > 
> > Hi Josef, all.js is constructed by concatenating all js files.. 
> > 
> > So, if you want to modify one language, or add a new one you should:
> > 
> > 1. remove all.js
> > 2. place the new file in that directory (or modify an existing file)
> > 3. cat *.js > all.js
> 
> Agustin, I think Josef's question is if we really need to ship those files
> with the project, or we can just remove them to save space.

If modifications from layout / languages are required, it would be rather
inconvenient to have to import those files, make the adjustments and remove
them... 

I'm not sure which is best.. 

To make modifications, surely the most convenient option is to have those
files, but it's clear there are a lot of files.. 

maybe we could have a separate repo somehow and import / copy the resultant
all.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Marie-Luce Laflamme  ---
Patch doesn't apply.

The patch seems to erase all the record information in the Normal view tab.

Title, author and contributor names, publisher, material type, description and
other fields all disappear.

Only the item information is displayed on screen (item, call number, status,
location and barcode).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948

Maryse Simard  changed:

   What|Removed |Added

  Attachment #89943|0   |1
is obsolete||

--- Comment #2 from Maryse Simard  ---
Created attachment 90248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90248&action=edit
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534

--- Comment #9 from Arthur Bousquet  ---
Created attachment 90247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90247&action=edit
Update release notes for the 19.05.00 release

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=11573

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #55 from Katrin Fischer  ---
Hi Arthur, I think something went wrong here - the last file should not be
attached here. Let me know if I can help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23028] New: Optionally use invalid ISBN 020 $z to get cover images

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23028

Bug ID: 23028
   Summary: Optionally use invalid ISBN 020 $z to get cover images
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jhann...@nmc.edu
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Currently Koha pulls enhanced content cover images using only valid (020$a)
ISBNs. It would be nice to optionally include cancelled ISBNs (020$z) in the
pool to check for cover images as well. I'm not sure how complex it would be to
have a hierarchy; i.e. use 020$a as the source first, and then 020$z if none
are found. Even if this kind of distinction isn't possible, it would be
enormously helpful to include the cancelled ISBNs (optionally, of course).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23028] Optionally use invalid ISBN 020 $z to get cover images

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23028

Joelle Hannert  changed:

   What|Removed |Added

 CC||jhann...@nmc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #54 from Arthur Bousquet  ---
Created attachment 90246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90246&action=edit
Update release notes for the 19.05.00 release

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178

--- Comment #15 from Tomás Cohen Arazi  ---
(In reply to Agustín Moyano from comment #14)
> (In reply to Josef Moravec from comment #13)
> > Just one question:
> > 
> > why are all the language and layout files added to the codebase, when you
> > need only the ones named all.js?
> 
> Hi Josef, all.js is constructed by concatenating all js files.. 
> 
> So, if you want to modify one language, or add a new one you should:
> 
> 1. remove all.js
> 2. place the new file in that directory (or modify an existing file)
> 3. cat *.js > all.js

Agustin, I think Josef's question is if we really need to ship those files with
the project, or we can just remove them to save space.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Marie-Luce Laflamme  ---
The patch apply correctly.

However, I do believe it will better to use the same term in both place: the
access tab and the page itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

 CC||nadine.pie...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90050|0   |1
is obsolete||

--- Comment #11 from Nadine Pierre  ---
Created attachment 90243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90243&action=edit
Bug 22982: Paying lost fee does not always remove lost item from checkouts

Depending on how a lost fee is paid, it may or may not be removed from the
patrons current checkouts. The current expected behavior is for the lost item
to be removed from the patrons checkouts when the lost fee is paid in full.

This is due to the subroutine for handling of lost fees being included in the
'pay specific lines' code but not in the 'pay by amount' code.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account.t

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90051|0   |1
is obsolete||

--- Comment #12 from Nadine Pierre  ---
Created attachment 90244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90244&action=edit
Bug 22982: Add unit tests

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90152|0   |1
is obsolete||

--- Comment #13 from Nadine Pierre  ---
Created attachment 90245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90245&action=edit
Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit
test

Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952

Bin Wen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952

Bin Wen  changed:

   What|Removed |Added

  Attachment #90092|0   |1
is obsolete||

--- Comment #3 from Bin Wen  ---
Created attachment 90242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90242&action=edit
Bug 22952: Markup error in OPAC suggestions template

This patch makes a minor correction to the OPAC suggestions template in
order to quiet an error returned by the HTML validator.

To reproduce the problem you should have the 'suggestion' system
preference turned on, and you should be logged in to the OPAC as a user
who has submitted one or more suggestions. View the "your purchase
suggestions" page in the OPAC. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses these errors:

 - "End tag div seen, but there were open elements."
 - "Unclosed element span."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Signed-off-by: Maryse Simard 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006

--- Comment #10 from Katrin Fischer  ---
Thx all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21973

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22585

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585

Jonathan Druart  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Jonathan Druart  
---
*** Bug 23026 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23026] Staff client CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23026

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Needs Signoff   |RESOLVED

--- Comment #2 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 22585 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585

Jonathan Druart  changed:

   What|Removed |Added

Version|18.11   |master
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |major
   Assignee|koha-b...@lists.koha-commun |jritt...@nd.edu
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17598] Make use of itemtypes.summary

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #7 from Jonathan Druart  
---
(In reply to Victor Grousset/tuxayo from comment #3)
> > You can also test the buggy branch:
> 
> Applying this patch on v18.11.05 conflicts.
> I think I might be able to backport it, is it worth it?

Always good to have more tests :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #6 from Jonathan Druart  
---
New patch for 18.11.05, unfortunately I was not able to test it (firefox-esr
version mismatch in kohadevbox)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #5 from Jonathan Druart  
---
Created attachment 90241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90241&action=edit
Bug 22898: [v18.11.05] Add selenium tests placing holds (staff)

Quick selenium tests to prevent regressions like bug 22895.

Test plan:
Make sure the selenium tests return green

You can also test the buggy branch:
% git checkout v18.11.05
% prove t/db_dependent/selenium/basic_workflow.t
=> Failure
% git bz apply 22895.
% prove t/db_dependent/selenium/basic_workflow.t
=> Success

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex relevant characters ($, ...)

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #90217|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 90237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90237&action=edit
Bug 23006: Cannot use inventory with barcodes containing special chars

If a barcode contains special characters like $, the regex in inventory
does no longer work.
This fix (as suggested by Jonathan) replaces the regex by a eq compare.

Test plan:
Pick one barcode and add a $ somewhere in the middle, say 123$456.
Include this barcode in a barcode file for inventory.
Run inventory on that file and verify that barcode was read and datelastseen
was updated. The barcode should not be reported as missing (not scanned).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027

--- Comment #1 from Jonathan Druart  
---
Created attachment 90236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90236&action=edit
Bug 23027: Make Suggestions.t pass even if no biblio in DB

There are biblionumbers 1 and 2 hardcoded

Test plan:
MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from
biblio;
% prove t/db_dependent/Suggestions.t
Must return green with this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23027] Suggestions.t is failing if no biblio in DB

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23027] New: Suggestions.t is failing if no biblio in DB

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027

Bug ID: 23027
   Summary: Suggestions.t is failing if no biblio in DB
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23026] Staff client CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23026

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||fridolin.som...@biblibre.co
   ||m,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||lu...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23026] Staff client CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23026

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23026] Staff client CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23026

--- Comment #1 from Nick Clemens  ---
Created attachment 90235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90235&action=edit
Bug 23026: Do not double encode CAS url

It is already escaped correctly in
C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape

Note that shibbolethLoginUrl is not and must be url escaped in template
("be consistent, they said")

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23026] New: Staff client CAS URL escaped twice, preventing login

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23026

Bug ID: 23026
   Summary: Staff client CAS URL escaped twice, preventing login
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
  Target Milestone: ---

Bug 21973 fixed CAS login for the opac - we need to do the same for the staff
client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22255] Item Search csv export, missing fields

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22255

--- Comment #1 from José Anjos  ---
It's working again in Version 18.11.05.000
Can someone confirm?
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22802] When ordering from a staged file, if funds are populated per item order level fund should not be required

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802

--- Comment #9 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #8)
> I'm not entirely sure if we need a port of this or not for 18.11.x series,
> but I don't feel confident I can deliver on in time to 18.11.06 I'm afraid..
> deferring to next rmaint (sorry Frido)

The two easiest paths here I think are:
1 - Back 22743 and apply this on top - that gets things in line with master
2 - revert 20830 - this removes the problematic code that causes this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23024] New: Limit quantity of items in staff items

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23024

Bug ID: 23024
   Summary: Limit quantity of items in staff items
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: b.paster...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

Is there a patch or a setting that can limit amount of items shown in
bibliorecord?
In OPAC there is something of that kind - 
"This record has many physical items (xxx). Click here to view them all."

The issue here is that if a record has more than a couple hundred items, it
takes too much time to generate template on server and user has to wait few
minutes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23023] New: System adds item in subscription but not in record when duplicate barcode is used

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23023

Bug ID: 23023
   Summary: System adds item in subscription but not in record
when duplicate barcode is used
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: b.paster...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

When i try to receive an item in a subscription and write a duplicate barcode,
system at first gives me a warning about a duplicate barcode. If i try this
again, it changes item status to arrived, new item in subscription is created
with "Expected" status, but in bibliorecord no item is created.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Vitor Fernandes  changed:

   What|Removed |Added

 CC||vitorfernande...@gmail.com

--- Comment #1 from Vitor Fernandes  ---
This would be a great feature for Koha next version.
In my opinion authorities search results and authorities details should also be
XSLT driven.

With this feature, we can have full control of the visualization of the
following entities:

- OPAC - biblio records search results and details
- Staff client - biblio records client search results and details

- OPAC - authorities results and details
- Staff client - authorities search results and details

I also think that ISBD views sould be XSLT driven (bug 20406).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #10 from Kyle M Hall  ---
> I am having some doubts too on cases where $fine->amountoutstanding >
> $balance_remaining in the first edit. $new_amountoutstanding may not be zero.

In cases where $new_amountoutstanding is not zero, we should *not* remove the
item from the patron's checkouts. We should only do so once the entire fee is
paid off. If you feel otherwise please give specific details that I can act on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #88726|0   |1
is obsolete||
  Attachment #88727|0   |1
is obsolete||
  Attachment #88728|0   |1
is obsolete||
  Attachment #88729|0   |1
is obsolete||

--- Comment #50 from Kyle M Hall  ---
Created attachment 90231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90231&action=edit
Bug 11573: Make rental accountlines translatable

To test:

1. Set up an item type with a rental charge
2. Issue an item with that item type
3. Check fines, a charge of type 'Rent' will be visible with a
description of 'Rental'.
4. Renew the item
5. Check fines, a charge of type 'Rent' will be visible with a
description of 'Renewal of Rental Item TITLE BARCODE' where TITLE and
BARCODE are the items title and barcode.
5. Apply the patch
6. Repeat steps 1-4, charge descriptions should now be empty and charge
types should display 'Rental fee' and 'Renewal of rental item'.
7. Repeat steps 1-6 for an item type with a daily rental charge and note
the charge types are now 'Daily rental fee' and 'Renewal of daily rental
item'

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #53 from Kyle M Hall  ---
Created attachment 90234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90234&action=edit
Bug 11573: (follow-up) Correction to accountype search on opac-user.pl

With the update of accountype from 'Rent' to four distinct accountypes
we need to update the search here to catch all four types of charge.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #51 from Kyle M Hall  ---
Created attachment 90232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90232&action=edit
Bug 11573: Update existing accountlines for 'Rent'

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #52 from Kyle M Hall  ---
Created attachment 90233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90233&action=edit
Bug 11573: Update of unit tests

This patch updates the unit tests to reflect the changes to the core
routines.  The relevant changes are the removal of a hard coded
'description' and the splitting up of the 'Rent' accounttype into
'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20406] Remove ISBD display

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406

Vitor Fernandes  changed:

   What|Removed |Added

 CC||vitorfernande...@gmail.com

--- Comment #17 from Vitor Fernandes  ---
I think the ISBD preview should not be removed. 
However it should work equal to the normal view, ie use XSLT.
It allows more flexibility (repeatable fields, maintain fields ordering, etc.)
to configure the view than the system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #43 from Kyle M Hall  ---
Created attachment 90230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90230&action=edit
Bug 19919: Unit Tests

This patch adds unit tests for the addition of a patron accessor to the
Koha::Account::Line object.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #90228|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall  ---
Created attachment 90229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90229&action=edit
Bug 19919: Stop using paidfor altogether

This patch removed references to setting and getting the items.paidfor
field. Where it was used for display, in moredetail.pl, we replace it
with a query on the accountlines.

Test plan:
1) Apply patch
2) Pay off a LOST item
3) Check for the associated display of 'Paidfor?:' on the itemdetails
page
4) Writeoff a LOST item
5) Check that a 'Paidfor?:' is not displayed on the itemdetails page.

Signed-off-by: Martin Renvoize 
Signed-off-by: Liz Rea 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #89816|0   |1
is obsolete||
  Attachment #89817|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall  ---
Created attachment 90228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90228&action=edit
Bug 19919: Stop using paidfor altogether

This patch removed references to setting and getting the items.paidfor
field. Where it was used for display, in moredetail.pl, we replace it
with a query on the accountlines.

Test plan:
1) Apply patch
2) Pay off a LOST item
3) Check for the associated display of 'Paidfor?:' on the itemdetails
page
4) Writeoff a LOST item
5) Check that a 'Paidfor?:' is not displayed on the itemdetails page.

Signed-off-by: Martin Renvoize 
Signed-off-by: Liz Rea 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #57 from Kyle M Hall  ---
Created attachment 90227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90227&action=edit
Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database

Test plan:
1) Confirm that after the DB update there are no L, LR or CR
accountlines present.
2) Read the db update and confirm is makes sense.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #54 from Kyle M Hall  ---
Created attachment 90224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90224&action=edit
Bug 22563: (follow-up) Corrections for tests

Updates to unit tests to reflect the accounttype changes and
introduction of status usage.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #55 from Kyle M Hall  ---
Created attachment 90225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90225&action=edit
Bug 22563: (follow-up) Items LOST should not be RETURNED

Up until now we marked lost items as returned in the accountlines, now
we have the oportunity to mark these distinctly with an appropriate
status we should.

Test Plan
1) Find an overdue with fines
2) Ensure you are not forgiving fines when an item is marked as lost
3) Mark the item as lost
4) Confirm the Fine is given a status of 'Lost'

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #56 from Kyle M Hall  ---
Created attachment 90226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90226&action=edit
Bug 22563: (follow-up) Corrections for overdue tests

Updates to unit tests to reflect the accounttype changes and introduction of
status usage for _FixOverduesOnReturn.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #90221|0   |1
is obsolete||

--- Comment #52 from Kyle M Hall  ---
Created attachment 90222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90222&action=edit
Bug 22563: Be more descriptive with accountypes

Convert 'L' to 'LOST' to become more descriptive in it's use.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #53 from Kyle M Hall  ---
Created attachment 90223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90223&action=edit
Bug 22563: Update lost handling to use accountline.status

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #89462|0   |1
is obsolete||
  Attachment #89463|0   |1
is obsolete||
  Attachment #89464|0   |1
is obsolete||
  Attachment #89465|0   |1
is obsolete||
  Attachment #89466|0   |1
is obsolete||
  Attachment #89467|0   |1
is obsolete||

--- Comment #51 from Kyle M Hall  ---
Created attachment 90221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90221&action=edit
Bug 22563: Be more descriptive with accountypes

Convert 'L' to 'LOST' to become more descriptive in it's use.

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23009] Add -deleted_marc_conditions argument to export_records script

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23009

--- Comment #2 from David Gustafsson  ---
Regarding the bug causing the tests to fail it was just a mismatch of my
current schema version and code base, so forget about that part :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20292] Filter/censor info sent via SIP

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #10 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #9)
> +$resp .= add_field( FID_FEE_AMT, $status->fee_amount, $server );
> +$resp .= maybe_add( FID_CURRENCY,   $status->sip_currency,
> $server );
> +$resp .= maybe_add( FID_FEE_TYPE,   $status->sip_fee_type,
> $server );
> +$resp .= maybe_add( FID_TRANSACTION_ID,
> $status->transaction_id, $server );
> 
> I have some doubts here. Will this work if people add such fields to the
> hidden list? Or should these be added no matter what? So moved to add_field?
> Maybe there are more ?

I see no reason to override a librarian's ability to scrub any particular SIP
field. That just makes the feature inconsistent, and for all we know maybe
there *will* be a scenario where a library needs to not send those fields to a
particular service.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #18 from David Gustafsson  ---
Created attachment 90220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90220&action=edit
Bug 20551: Rename "marcflavour" field to "schema"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

--- Comment #4 from Ray Delahunty  ---
UAL (along with I think 4 other Koha users) is part funding the turning of
AUTO_RENEWALS into a digest email. My understanding of this is that Bywater
Solutions hope to have the work completed for inclusion in 19.11 and we are
right now in the process of sending the money through. This will be a great
development as we have had to use the workaround of using RENEWAL (renewal
success notification) & ODUE1 (renewal failure notification) in place of
AUTO_RENEWALS.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12450] Closing libraries for the summer

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi

--- Comment #6 from Johanna Räisä  ---
Lot of work for closing a library for a period of time. Could this be only a
single preference in libraries, probably the easiest way than try to add this
to calendar?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Bug 17258 depends on bug 22919, which changed state.

Bug 22919 Summary: Authorities MARC Structure not inserted with SQL strict modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

Nick Clemens  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919

Nick Clemens  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22633] Link barcodes in hold summary in patron account to moredetail page

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22633

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #89620|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 90219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90219&action=edit
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Bug 21070 links the barcode on holds to the item on moredetail.pl.
This patch makes the same change to the hold lists in the staff
patron account.

To test:
- Create some holds, have at least
  - one item level hold
  - one hold waiting for pick-up
- Take a look at the details and checkouts tabs
  in the patron account on staff side
- Verify that the barcodes link to the record detail page
- Apply patch
- Verify the barcodes now link to the moredetail page

Signed-off-by: Axel Amghar 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22633] Link barcodes in hold summary in patron account to moredetail page

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22633

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22633] Link barcodes in hold summary in patron account to moredetail page

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22633

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23003] Accessibility improvements

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003

Paul Poulain  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om,
   ||paul.poul...@biblibre.com

--- Comment #1 from Paul Poulain  ---
note: the tests have also been done on a demo sandbox (UNIMARC), setup by
BibLibre for the tests. we've been contacted by the company who made the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >