[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #16 from Jonathan Druart --- (In reply to Martin Renvoize from comment #13) > Now it's looking good to me.. Setting back to SO as I'd like Jonathan to > check my followup.. seems strange it was missed. Oops, I have the bad habit to modify my patches after I already tested them. I guess I renamed something just before attaching it here, sorry about that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What|Removed |Added Attachment #99286|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 99300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99300=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize Signed-off-by: Lisette Scheer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #21 from Jonathan Druart --- I wanted to get back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #1 from Julian Maurice --- Created attachment 99299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99299=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24693] New: GD is declared as an optional dependency but Koha dies without it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bug ID: 24693 Summary: GD is declared as an optional dependency but Koha dies without it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What|Removed |Added Blocks||24692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 [Bug 24692] OpacBrowseSearch: enable navigating result list with arrow keys -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24692] OpacBrowseSearch: enable navigating result list with arrow keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Katrin Fischer changed: What|Removed |Added Depends on||14567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24692] New: OpacBrowseSearch: enable navigating result list with arrow keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Bug ID: 24692 Summary: OpacBrowseSearch: enable navigating result list with arrow keys Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org With the new OpacBrowseSearch feature from bug 14567 a list of authors, titles or subjects will show. When clicking on an entry, the records linked to it will show on the right of the list. It would be nice if jumping between entries was possible using the arrow keys (up and down). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What|Removed |Added Blocks||24691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 [Bug 24691] OpacBrowseSearch: Show number of results behind each list entry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24691] New: OpacBrowseSearch: Show number of results behind each list entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 Bug ID: 24691 Summary: OpacBrowseSearch: Show number of results behind each list entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de Depends on: 14567 When using the new OpacBrowseSearch feature from bug 14567 it would be great if the number of results showed behind each list entry when browsing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What|Removed |Added Attachment #99292|0 |1 is obsolete|| --- Comment #63 from Katrin Fischer --- Created attachment 99298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99298=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Apply patches 2 - Update database (updatedatabase on kohadevbox) 3 - Compile the CSS https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client yarn build --view=opac on kohadevbox 4 - Enable the new syspref OpacBrowseSearch 5 - Have ES running and some records in it SearchEngine syspref set to Elasticsearch 6 - Browse to opac home, click 'Browse search' link for your site) 7 - Test searching for author, title, and subject 8 - Verify that results are returned in expected order 9 - Experiment with fuzziness https://www.elastic.co/guide/en/elasticsearch/reference/5.6/common-options.html#fuzziness Options are: exact (0 edits), fuzzy (1 edit), very fuzzy (2 edits) 10 - Click any result and verify specific titles are correct 11 - Click through title to record and verify it is the correct record 12 - Test that disabling pref removes the link on the opac home Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Attachment #99250|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 99297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99297=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Attachment #99002|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 99296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99296=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Blocks||24690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer changed: What|Removed |Added Depends on||13327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24690] New: Make OPACPopupAuthorsSearch work with search terms containing parenthesis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug ID: 24690 Summary: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org As noted in bug 13327 this feature doesn't work when the selected search terms contain (). No results will be found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #18 from Katrin Fischer --- hi Owen, sorry, just realized it was even in the test plan: Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What|Removed |Added Attachment #98610|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 99295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99295=edit Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create manual invoice for any patron and click on "Save", you should be redirected to Account tab 2. Create manual invoice for any patron and click on "Save and pay", you should be redirected to Account tab Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What|Removed |Added Summary|After adding manual invoice |Add 'Save and pay' button |redirect to pay tab instead |to use after adding a |of account tab |manual invoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Mason James changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Mason James --- aah, it seems the hold claas has been intentionally removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 --- Comment #1 from Mason James --- Created attachment 99294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99294=edit Bug 24689: Fix missing 'hold' class regression from BZ 23903 (19.11.x) this trival patch replaces the missing 'hold' class, regressed in BZ 23903 (19.11.x) this issue have been fixed in master :) test plan.. 1/ apply patch, 2/ observe missing hold class exists (pic attached) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23903 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24689 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24689] New: Fix missing 'hold' class regression from BZ 23903 (19.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Bug ID: 24689 Summary: Fix missing 'hold' class regression from BZ 23903 (19.11.x) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org This trival patch replaces the missing 'hold' class, regressed in BZ 23903 (19.11.x) This issue have been fixed in master :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 --- Comment #3 from AspenCat Team --- If alphabetical sort by title is not correct (in that it ignores the 245 second indicator) it should not be offered as an option as it is misleading. One usually sorts by title because there are more records than can easily be reviewed in one page. I have been misled! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #123 from David Cook --- Reminds me how I really should work on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 one of these days -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #11 from David Cook --- Thanks for the quick turnaround on this, guys. Really appreciated. I love Koha::Middleware::RealIP, so glad I was able to contribute :D. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Hayley Mapley changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|19.05.08|19.05.08, 18.11.14 CC||hayleymap...@catalyst.net.n ||z --- Comment #19 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What|Removed |Added Attachment #99234|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 99293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99293=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Attachment #99060|0 |1 is obsolete|| --- Comment #62 from Nick Clemens --- Created attachment 99292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99292=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Apply patches 2 - Update database (updatedatabase on kohadevbox) 3 - Compile the CSS https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client yarn build --view=opac on kohadevbox 4 - Enable the new syspref OpacBrowseSearch 5 - Have ES running and some records in it SearchEngine syspref set to Elasticsearch 6 - Browse to opac home, click 'Browse search' link for your site) 7 - Test searching for author, title, and subject 8 - Verify that results are returned in expected order 9 - Experiment with fuzziness https://www.elastic.co/guide/en/elasticsearch/reference/5.6/common-options.html#fuzziness Options are: exact (0 edits), fuzzy (1 edit), very fuzzy (2 edits) 10 - Click any result and verify specific titles are correct 11 - Click through title to record and verify it is the correct record 12 - Test that disabling pref removes the link on the opac home Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08|19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 --- Comment #1 from Aleisha Amohia --- Created attachment 99291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99291=edit Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24688] New: Hold priority isn't adjusted correctly if checking out a middle priority hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Bug ID: 24688 Summary: Hold priority isn't adjusted correctly if checking out a middle priority hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To reproduce 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. So the priorities have not been adjusted to be consecutive which can cause problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08|19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24686] Capturing circulation statistics per number of items in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24687] New: Installation errors in Koha-common
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Bug ID: 24687 Summary: Installation errors in Koha-common Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: jwboul...@sbcglobal.net QA Contact: testo...@bugs.koha-community.org Getting errors about unable to locate Koha configuration file koha-conf.xml at line 245. /usr/share/koha/lib/C4/Context.pm. (Repeated 4 times) Can't call method "config" on unblessed reference at /usr/share/koha/lib/Koha/Database/pm line 56. Setting up koha-common (19.11.02-1) ... failed to load external entity "/etc/koha/sites/jack/koha-conf.xml" Upgrading database schema for jack unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. Can't call method "config" on unblessed reference at /usr/share/koha/lib/Koha/Database.pm line 56. dpkg: error processing package koha-common (--configure): installed koha-common package post-installation script subprocess returned error exit status 2 Errors were encountered while processing: koha-common E: Sub-process /usr/bin/dpkg returned an error code (1) Using a Dell 7500, 6 core 48 Gig of ram, Mint 19.3 Cannot load any Koha software. Attempted a live DVD. Does not respond to the install software from the admin menu, Following instructions from the Live DVD. Why is this software so difficult to install? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 --- Comment #8 from Katrin Fischer --- Asked Kyle to take a look here and he wanted to get some libraries to take a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #17 from Katrin Fischer --- Thx! I'll try to come back to this one in my next QA session (not mad if someone beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #16 from Owen Leonard --- (In reply to Katrin Fischer from comment #15) > forbidden pattern: Contains old bootstrap style for buttons > (see bug It's a false positive. That check doesn't apply to OPAC templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #96 from Katrin Fischer ---
Hi Aleisha,
can you please take a look at David'd comment#95?
I also got a lot of fails with the QA tools for missing filters :(
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
FAIL filters
missing_filter at line 4 ( First)
missing_filter at line 6 ( Previous)
missing_filter at line 12 ([% PAGE_NUMBER.pg | html
%])
missing_filter at line 16 (Next )
missing_filter at line 17 (Last )
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
FAIL filters
missing_filter at line 274 (
Results per page: [% results_per_page %] )
missing_filter at line 281 (
[% END %] Library default: [% Koha.Preference('numSearchResults')
%])
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
FAIL filters
wrong_html_filter at line 6 ( First)
missing_filter at line 6 ( First)
wrong_html_filter at line 7 ( Previous)
missing_filter at line 7 ( Previous)
wrong_html_filter at line 13 ([% PAGE_NUMBER.pg | html
%])
missing_filter at line 13 ([% PAGE_NUMBER.pg | html
%])
wrong_html_filter at line 17 (Next )
missing_filter at line 17 (Next )
wrong_html_filter at line 18 (Last )
missing_filter at line 18 (Last )
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
FAIL filters
missing_filter at line 172 (
Library
default: [% Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 172 (
Library
default: [% Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 174 (
Library default: [%
Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 174 (
Library default: [%
Koha.Preference('OPACnumSearchResults') %])
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What|Removed |Added Attachment #98633|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 99289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99289=edit Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #20 from Katrin Fischer --- Created attachment 99290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99290=edit Bug 14647: Make spelling in file format pull downs match While bibliographic had XML and MARC, authorities had xml and marc in the pull down. This just makes both the same. To test: - Look at the pull downs on both tabs and verify they are now using the same spelling Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What|Removed |Added Attachment #98632|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 99288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99288=edit Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647
Katrin Fischer changed:
What|Removed |Added
Attachment #98631|0 |1
is obsolete||
--- Comment #17 from Katrin Fischer ---
Created attachment 99287
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99287=edit
Bug 14647: Make the file name extension dynamic on exporting records
Test -
1. go to cgi-bin/koha/tools/export.pl
2. Check that both tabs ("Export bibliographic records & Rxport authority
records") do the following
3. In Output format
4. When changing "File format" from dropdown it update "file name"
5. Still works with user inputted names
Works as expected.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #11 from Heather --- Could there be some way to choose this or not (e.g., syspref)? We are an OCLC library, and retain the OCLC record number in the 001 when importing authorities as our primary key; we match and replace authority records on the 010 field (Library of Congress Control Number). We (and perhaps other OCLC users) would definitely not want the OCLC number data moved out of the 001 field and into the 035 upon import. (The 001 also contains the OCLC record number in our bibs.) Could the desired moving of 001 data to 035 be accomplished with the new MARC modification templates capabilities upon record import? (So then maybe this enhancement isn't needed?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #61 from Katrin Fischer --- Notes: - Pref appears on Search/OpenUrl - I think move up by one: Features - Test plan and commit message needs a little update: * Run yarn build --view opac * Mention OpacBrowseSearch system preference ... ? - Capitalization: Really Fuzzy As the QA queue is really full right now, I will leave the follow-ups to the devs right now. But they should be quick and I will come back asap! Improvement ideas (separate bugs): - Show number of records for each list entry - It would be cool if you could move up and down list entries with the arrow keys, making it quick move between entries and see linked records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18024] Adding a "genres/ form term" search in Authorities module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #3 from Heather --- This would save so much time if it were added; it is a wonderful way to import authorities, but the fact that we can't use it for "Genre/Form Term" means that we must save Genre/Form authority records & then import them into Koha via the much slower "Stage MARC records..." workflow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #60 from Katrin Fischer --- False positive ;) FAIL spelling Sheat ==> Sheath, sheet, cheat Testing further... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #35 from Katrin Fischer --- Also missing tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What|Removed |Added Attachment #99282|0 |1 is obsolete|| --- Comment #14 from Lisette Scheer --- Created attachment 99286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99286=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #34 from Katrin Fischer ---
Hi Nicolas,
starting with QA review here:
1) QA test tools
Possibly a false positive:
FAIL Koha/Desk.pm
FAIL pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
FAIL Koha/Desks.pm
FAIL pod coverage
POD is missing for 'object_class'
Possibly a false positive:
FAIL Koha/Schema/Result/Desk.pm
FAIL pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc
FAIL filters
missing_filter at line 3 ([% LibraryName %])
missing_filter at line 7 ( )
missing_filter at line 8 ()
FAIL forbidden patterns
forbidden pattern: tab char (line 5)
forbidden pattern: tab char (line 7)
forbidden pattern: tab char (line 9)
forbidden pattern: tab char (line 10)
forbidden pattern: tab char (line 11)
forbidden pattern: tab char (line 15)
forbidden pattern: tab char (line 17)
forbidden pattern: tab char (line 18)
forbidden pattern: tab char (line 21)
forbidden pattern: tab char (line 22)
forbidden pattern: tab char (line 23)
forbidden pattern: tab char (line 24)
forbidden pattern: tab char (line 28)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt
FAIL filters
missing_filter at line 79 ([% branch.branchname
%])
missing_filter at line 79 ([% branch.branchname
%])
missing_filter at line 81 ([% branch.branchname %])
missing_filter at line 81 ([% branch.branchname %])
2) Quick code review
admin/desks.pl
Are the copyright statements correct?
+# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN
+# Copyright 2015 Koha Development Team
Leftover debugging code:
+use Data::Dumper;
The new page requires a new permission: manage_desks
+flagsrequired => { parameters => 'manage_desks' },
But the new permission is not properly added. It looks like maybe you were
planning to use manage_libraries here instead?
Check:
koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Owen, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1347) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #110 from Katrin Fischer --- Hi Maryse, small failure in the QA script: 1) QA script FAIL installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column categories.canbeguarantee is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline The first could be fixed by squashing the patches in question, but should only be done if they got the same author/tester lines. 2) Quick code review Looks good so far, will continue testing with the follow-ups (switch back to signed-off) Note: I feel that GuarantorFields and "Shows guarantees' fines in the guarantor's page" should have been separate features/bugs - they add even more code to check and work through and make this this harder to test and harder to advertise/document. The bug title/description is actually not what this patch does, but is what will show up in release notes. - Too late now I guess, but I think it's part of the reason this has not been moving as fast as hoped for. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24686] New: Capturing circulation statistics per number of items in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Bug ID: 24686 Summary: Capturing circulation statistics per number of items in an item Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A library would like to see a possible enhancement to Koha. If a DVD has 5 discs in the item, when this item (with 5 dvds) is circulated- they would like Koha to count this circulation as 5 issues (as in each of the items included in the 1 main item) was circulated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Works as expected.. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637
Martin Renvoize changed:
What|Removed |Added
Attachment #99279|0 |1
is obsolete||
--- Comment #5 from Martin Renvoize ---
Created attachment 99285
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99285=edit
Bug 24637: Add brancode in all pay circumstances
To TEST:
1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons.
2. SELECT branchcode FROM accountlines where borrowernumber =
'{borrowernumber}';
3. See that branchcode is NULL
4. Apply patch and restart_all
5. Make a partial payment using both the Pay select and Pay amount buttons.
6. SELECT branchcode FROM accountlines where borrowernumber =
'{borrowernumber}';
7. Now you should see the branchcodes in the table and no NULL values.
Signed-off-by: Benjamin Daeuber
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What|Removed |Added Attachment #99244|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 99283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99283=edit Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Cheers guys, Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What|Removed |Added Attachment #99245|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 99284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99284=edit Bug 24538: Handle Net::Netmask parser errors This patch switches from the new() to new2() constructor, which will return an undef value when it fails to parse a value. This patch warns on parser failures, but otherwise silently drops the invalid value, and returns objects for any valid input it can parse. This way one mistake won't disable the whole feature. To test: 1. Run the unit test t/Koha/Middlware/RealIP.t Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #30 from Katrin Fischer --- Hi Johanna, can you please rebase? Small thing: Print checked-in today -slip I think I'd just label that as 'Print checkin slip' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #13 from Martin Renvoize --- Now it's looking good to me.. Setting back to SO as I'd like Jonathan to check my followup.. seems strange it was missed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added Attachment #99280|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 99281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99281=edit Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #12 from Martin Renvoize --- Created attachment 99282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99282=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Martin Renvoize --- Ooops.. false positive there.. had the wrong branch checked out. I see the same error as Lisette I'm afraid.. looks like $rules is defined in a local scope but then assigned to in a global one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- This makes a big difference on my test system, thanks for the quick work guys. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #99278|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #8 from Martin Renvoize --- Created attachment 99280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99280=edit Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber changed: What|Removed |Added Attachment #98734|0 |1 is obsolete|| --- Comment #4 from Benjamin Daeuber --- Created attachment 99279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99279=edit Bug 24637: Add brancode in all pay circumstances Signed-off-by: Benjamin Daeuber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #7 from Lisette Scheer --- I went back later and it worked this time. Much faster now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What|Removed |Added Attachment #99082|0 |1 is obsolete|| --- Comment #6 from Lisette Scheer --- Created attachment 99278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99278=edit Attachment to Bug 24670 - Circulation and fine rules page has performance issues since issuingrules change Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 --- Comment #8 from Hayley Mapley --- Thanks Kyle, I followed the test plan but forgot to check for the system preference before I applied the patch! Commit has been reverted in 18.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99276|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 99277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99277=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #20 from Kyle M Hall --- Created attachment 99276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99276=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #19 from Kyle M Hall --- Created attachment 99275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99275=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #18 from Kyle M Hall --- Created attachment 99274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99274=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99269|0 |1 is obsolete|| Attachment #99270|0 |1 is obsolete|| Attachment #99271|0 |1 is obsolete|| Attachment #99272|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 99273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99273=edit Bug 23727: Add new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #15 from Kyle M Hall --- Created attachment 99271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99271=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #14 from Kyle M Hall --- Created attachment 99270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99270=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
