[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106378|0   |1
is obsolete||

--- Comment #507 from Aleisha Amohia  ---
Created attachment 106817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106817=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

Test plan in Comment 482.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106376|0   |1
is obsolete||

--- Comment #505 from Aleisha Amohia  ---
Created attachment 106815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106815=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106377|0   |1
is obsolete||

--- Comment #506 from Aleisha Amohia  ---
Created attachment 106816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106816=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106372|0   |1
is obsolete||

--- Comment #501 from Aleisha Amohia  ---
Created attachment 106811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106811=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106374|0   |1
is obsolete||

--- Comment #503 from Aleisha Amohia  ---
Created attachment 106813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106813=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106373|0   |1
is obsolete||

--- Comment #502 from Aleisha Amohia  ---
Created attachment 106812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106812=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106375|0   |1
is obsolete||

--- Comment #504 from Aleisha Amohia  ---
Created attachment 106814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106814=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106371|0   |1
is obsolete||

--- Comment #500 from Aleisha Amohia  ---
Created attachment 106810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106810=edit
Bug 19532: Database and installer stuff

- Add recalls table
- Add recalls circulation rules - recalls allowed, recalls per record, on shelf
recalls, recall due date interval, recall overdue fine, recall shelf time
- Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog
- Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM)
- Add print notice (RECALL_REQUESTER_DET)
- Add user permission - recalls, manage_recalls
- Add Recall and CancelRecall enum options for branchtransfers reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #499 from Aleisha Amohia  ---
(In reply to Owen Leonard from comment #498)
> I ran into a problem at step 70, checking in a recalled item which requires
> a transfer and clicking "confirm recall and transfer." The dialog disappears
> as expected but then I'm shown another modal, the regular transfer dialog
> which is shown when an item is checked in at the wrong branch.

Hey Owen, I am seeing this problem too but for some reason I'm really
struggling with not getting that second dialog to pop up, and to hide to 'Item
not checked out' alert box behind the modals. Do you have any ideas? All the
code to look at is in C4/Circulation.pm in AddReturn, or in circ/returns.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #39 from Maryse Simard  ---
Created attachment 106809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106809=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #40 from Maryse Simard  ---
Rebased the patch and added a commit for unit tests.

I was unsure which status to set this to, so I've set it back to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #38 from Maryse Simard  ---
Created attachment 106808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106808=edit
Bug 14784: Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 
Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to main content' link

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #30 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25151] Accessibility: The 'Your cart' page does not contain a level-one header

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #8 from Aleisha Amohia  ---
decided to rebase myself :)

backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #10 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #15 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #8 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #7 from Aleisha Amohia  ---
There are no  headings on this page in 19.11.x. I'd like to backport this
for accessibility, but need someone to write a patch that fixes the Confirm
holds for: for 19.11.x only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25402] Put OPAC cart download options into dropdown menu

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #11 from Aleisha Amohia  ---
enhancement, not backporting to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25471] Add DataTables to MARC subfield structure admin page for bibliographic frameworks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25471

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #8 from Aleisha Amohia  ---
enhancement, not backporting to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25699] Add edition information to Holds to pull report

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #10 from Aleisha Amohia  ---
enhancement, not backporting to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] Holds Queue sorts patrons by firstname

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||25747


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747
[Bug 25747] Don't display a comma when patron has no firstname
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25747] Don't display a comma when patron has no firstname

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||2
 CC||alei...@catalyst.net.nz

--- Comment #6 from Aleisha Amohia  ---
missing dependencies, not backporting to 19.11.x


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2
[Bug 2] Holds Queue sorts patrons by firstname
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25789] New expiration date on placing a hold in staff interface can be set to a date in the past

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25789

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||alei...@catalyst.net.nz
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #7 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25756] Empty HTML table row after OPAC "Appearance" preferences

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25756

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 Status|Pushed to stable|Pushed to oldstable
 CC||alei...@catalyst.net.nz

--- Comment #7 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25611] Changing the vendor when creating the basket does not keep that new vendor

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||alei...@catalyst.net.nz
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #9 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #29 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #18 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

--- Comment #9 from Pablo AB  ---
I just formatted Martin Renvoize's comment 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #9 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25570] Listing requests should be paginated by default

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #17 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093

--- Comment #21 from Aleisha Amohia  ---
enhancement, not backported to 19.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25804] Remove HTML from title tag of bibliographic detail page

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25804

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #8 from Aleisha Amohia  ---
missing dependencies, not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 Status|Pushed to stable|Pushed to oldstable

--- Comment #12 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25553] Edit item date sort does not sort correctly

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25553

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||alei...@catalyst.net.nz
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08

--- Comment #12 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25447] Terminology: Fix button text "Edit biblio"

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25447

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00, 20.05.02  |20.11.00, 20.05.02,
released in||19.11.08
 CC||alei...@catalyst.net.nz

--- Comment #11 from Aleisha Amohia  ---
Backported to 19.11.x for 19.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #41 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #39)
> Hm, I think I don't understand what you are referring to as source files.
> Will this work for tarball installations, packaging installations and git
> based installations alike? I believe we don't always have 2 copies of the
> files? 
> I am worried this could break things for some of those?
By source files I mean the files that are committed in the git repo. All files
that you have directly after a git clone.
IMO create and update should not be run on "installations", but directly on
files inside the git repository, independently of any installation.
'create' and 'update' are essentially developer tools to manage PO files within
the git repository.

> I think it's a wrong assumption that update and create will only be used by
> our translation manager or developers. I believe libraries have for example
> changed terms in po files and similar for the normal GUI.
I think that we should not support nor encourage that. Even if it's "only"
translations, it's still a fork of Koha. Everyone is free to do that, of
course, but then they are on their own to maintain their changes.
If translations are wrong, they should be fixed on translate.koha-community.org

> But I'd be interested in your workflow for separate po for other use cases.
> :)
Basically, for each client-specific development that adds new strings, we
create a PO file in misc/translator/po/fr-FR--.po
containing all the new strings and their translation. When we need to update
fr-FR templates we call a script that "concatenates" (msgcat) all
fr-FR--*.po and runs misc/translator/translate install

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #40 from Katrin Fischer  ---
(In reply to Julian Maurice from comment #38)
> Last patch tested with fr-FR PO files : msgmerge correctly keep all
> translations (even short ones like "Do"). The only difference is that long
> lines are now wrapped.

That's some good news. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #39 from Katrin Fischer  ---
Hm, I think I don't understand what you are referring to as source files. Will
this work for tarball installations, packaging installations and git based
installations alike? I believe we don't always have 2 copies of the files? 
I am worried this could break things for some of those?

Adding the info in a comment could help a bit, I tihnk, but it could get quite
a lot, maybe just the names of the prefs?

I think it's a wrong assumption that update and create will only be used by our
translation manager or developers. I believe libraries have for example changed
terms in po files and similar for the normal GUI. 

But I'd be interested in your workflow for separate po for other use cases. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #38 from Julian Maurice  ---
Last patch tested with fr-FR PO files : msgmerge correctly keep all
translations (even short ones like "Do"). The only difference is that long
lines are now wrapped.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #37 from Julian Maurice  ---
Created attachment 106807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106807=edit
Bug 25067: Do not set msgctxt in pref PO files

By having msgctxt set, msgmerge will "lose" some translations, forcing
translators to re-translate them.
Also, Pootle does not offer the ability to search by context, making it
harder to translate all strings related to a single preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #36 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #34)
> I don't know about the .pot files, but was looking at the test plan again
> (thx for the write-up!):
> 
> - Can 'gulp po:update' be run for a selected language? It takes a long while
> to do this for all languages, so you might want to do it only for the ones
> you need/test with.
Yep, just use --lang option:

  gulp po:update --lang de-DE

> You write:
> >- there is no need for $KOHA_CONF to be defined
> >  LangInstaller.pm relied on $KOHA_CONF to get the different paths
> >  needed. I'm not sure why, since string extraction and PO update should
> >  work on source files, not installed files
> 
> But aren't the paths to the templates we need to parse different depending
> on installation type? And also the po files will be stored in a different
> place?
I believe create and update operations should work exclusively on source files.
I don't see why we would want to work on the copy installed under
/usr/share/koha for instance.
Note that 'install' operation still work the same, translated templates are
installed in the right place.

> 
> We need to keep the option for everyone to update/install their own adapted
> po files. I know a lot of people make local changes. Even we do to a certain
> extend to have our own XSLT files translated.
We do too, but local translations are handled in separate PO files.

Do you alter the original PO files ? How do you handle Koha upgrades ?

> 
> Still a bit worried about this one:
> 
> >  Now context is put into msgctxt, and the reference is set, which is
> >  cleaner
> 
> >#: 
> > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
> >msgctxt "Accounting > Policy > FinePaymentAutoPopup"
> >msgid "automatically display a print dialog for a payment receipt "
> >"when making a payment.."
> 
> I think in translation practice using Pootle this could be quite hard on
> tranlators. :(
> 
> Right now you can search in the prefs file for a system preference and it
> will turn up all strings related to it. They also appear in alphabetic
> order, so when you start translating, you have the 'context' because the
> strings appear together with the prefixed note. This was intentional and a
> 'feature'. 
> 
> It doesn't seem that we can search by 'context' in Pootle, so seeing all
> strings for a pref together will no longer be possible.
It seems that Pootle can search by comment. Would that help if the syspref name
and category appear in a comment ?

> 
> To explain: Translating prefs is quite hard because you have to make sure
> things work grammatically with sentence parts torn apart. This depends on
> language I am sure, but for German it's not an easy task and we can't
> translate "Do" and "Don't" just like that. Often we need to move parts of
> the rest of the sentence into the options for things to make more sense.
This will still be possible

> 
> Also:
> 
> >  The downside is that some messages will have to be re-translated,
> >  especially short messages like 'Do', for which msgmerge has a hard
> >  time finding the corresponding new msgid.
> 
> This is quite a burden for translators, escpecially since you have to look
> up every single one of them to see what the rest of the sentence looks like.
> Can't we figure them out? We do have the pref and the current translation.
Probably.
We can also easily revert this change from this patchset and address the issue
in a separate bug. This bug brings already too many different things, so if it
helps I will gladly remove that. I just thought it would be a nice "clean up"
to do at the same time.

(In reply to Katrin Fischer from comment #35)
> > - In the test plan only installing a language is used with the old syntax,
> > creating and updating are different. I think mixing would not be good. Why
> > is it not possible to move all to the old syntax? and should we them move
> > installing as well with the deprecation note you suggest?
> 
> Realizing that last bit made no sense:
> 
> And should we not move installing to the new syntax as well with a
> deprecation note like you suggest? 
> 
> Overall I think we need to keep things as easy as possible since not only
> experienced Koha users will be using these commands (update, install,
> create).
In my opinion, install is really different from create/update so it makes sense
for it to be in a different script/called in a different way.
Only install should be called by end users (people who manage Koha instances)
create/update is more for Koha translation maintainer (aka Bernardo)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : 

[Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #9 from Andrew Fuerste-Henry  ---
Patch no longer applies. Please rebase? Needed to test bug 23091

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is html not xml

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982

didier  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is html not xml

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982

--- Comment #1 from didier  ---
Created attachment 106806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106806=edit
Bug 25982: OPAC shelves RSS link output is xml

Output rss feed as text/xml

Test plan:
1) have books entered
2) log in create a list
3) add books to list
4) display list in OPAC
5) click the RSS link button.
   -- output is displayed as html text
6) apply patch
7) repeat steps 4&5
   -- output is displayed as xml tree

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25982] New: OPAC shelves RSS link output is html not xml

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982

Bug ID: 25982
   Summary: OPAC shelves RSS link output is html not xml
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: didier.gauthe...@biblibre.com
  Reporter: didier.gauthe...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Unlike opac-search.pl opac-shelves.pl output header is text/html not text/xml
and it seems to confuse some RSS readers.

cf 2009 git commit b04f432857617c6a7b863e34420103321ea1 for opac-search

Test plan:
1) have books entered
2) log in create a list
3) add books to list
4) display list in OPAC
5) click the RSS link button.
   -- output is displayed as html text
6) apply patch
7) repeat steps 4&5
   -- output is displayed as xml tree

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #35 from Katrin Fischer  ---

> - In the test plan only installing a language is used with the old syntax,
> creating and updating are different. I think mixing would not be good. Why
> is it not possible to move all to the old syntax? and should we them move
> installing as well with the deprecation note you suggest?

Realizing that last bit made no sense:

And should we not move installing to the new syntax as well with a deprecation
note like you suggest? 

Overall I think we need to keep things as easy as possible since not only
experienced Koha users will be using these commands (update, install, create).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #34 from Katrin Fischer  ---
I don't know about the .pot files, but was looking at the test plan again (thx
for the write-up!):

- Can 'gulp po:update' be run for a selected language? It takes a long while to
do this for all languages, so you might want to do it only for the ones you
need/test with.

- In the test plan only installing a language is used with the old syntax,
creating and updating are different. I think mixing would not be good. Why is
it not possible to move all to the old syntax? and should we them move
installing as well with the deprecation note you suggest?

You write:
>- there is no need for $KOHA_CONF to be defined
>  LangInstaller.pm relied on $KOHA_CONF to get the different paths
>  needed. I'm not sure why, since string extraction and PO update should
>  work on source files, not installed files

But aren't the paths to the templates we need to parse different depending on
installation type? And also the po files will be stored in a different place?

We need to keep the option for everyone to update/install their own adapted po
files. I know a lot of people make local changes. Even we do to a certain
extend to have our own XSLT files translated.

Still a bit worried about this one:

>  Now context is put into msgctxt, and the reference is set, which is
>  cleaner

>#: 
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
>msgctxt "Accounting > Policy > FinePaymentAutoPopup"
>msgid "automatically display a print dialog for a payment receipt "
>"when making a payment.."

I think in translation practice using Pootle this could be quite hard on
tranlators. :(

Right now you can search in the prefs file for a system preference and it will
turn up all strings related to it. They also appear in alphabetic order, so
when you start translating, you have the 'context' because the strings appear
together with the prefixed note. This was intentional and a 'feature'. 

It doesn't seem that we can search by 'context' in Pootle, so seeing all
strings for a pref together will no longer be possible.

To explain: Translating prefs is quite hard because you have to make sure
things work grammatically with sentence parts torn apart. This depends on
language I am sure, but for German it's not an easy task and we can't translate
"Do" and "Don't" just like that. Often we need to move parts of the rest of the
sentence into the options for things to make more sense.

Also:

>  The downside is that some messages will have to be re-translated,
>  especially short messages like 'Do', for which msgmerge has a hard
>  time finding the corresponding new msgid.

This is quite a burden for translators, escpecially since you have to look up
every single one of them to see what the rest of the sentence looks like. Can't
we figure them out? We do have the pref and the current translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25975] Receiving a manual transfer triggers another transfer (non-floating collection)

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25975

--- Comment #1 from Katrin Fischer  ---
Thank you for all the great use cases!

I like 2) with the option to not send the item back (start a new transfer).

I also wonder if it should be possible to flag for 'floating' on item level for
the cases you describe. Because if you allow circulation from display, you
might still wan to put the item back on display (or on the bus) when it's
returned. So those transfer notices popping up are getting in the way.

Or you could put everything in a rotating collection for that I guess...?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21494] No checkin notice created for offline circulation checkins

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25977

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25977] Koha Offline Circulation tool to handle trigger for sending necessary notices after successful .koc upload and processing

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25977

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21494
Summary|Koha Offline Circulation|Koha Offline Circulation
   |tool to handle trigger for  |tool to handle trigger for
   |sending necessary notices   |sending necessary notices
   |after successful .koc   |after successful .koc
   |upload  |upload and processing

--- Comment #1 from Katrin Fischer  ---
I think this is at least a partial duplicate of bug 21494.

I've updated the description a little, not upload but processing of the
transactions should trigger the sending of the notices. I agree it's confusing
that it doesn't happen and the feedback would be even more important to users
in case of offline circ. 

Maybe it could be a setting/checkbox you check when processing the
transactions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25173] Create list of parameters to choose from via a query

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25173

--- Comment #4 from Katrin Fischer  ---
I like the idea, independent of syntax, it might be nice to give an option for
a description showing different to the values it adds to the query.

Something like:
<>

First column will be used for the query and as description, if no second column
exists. So the second parameter could be made optional, if that makes sense?

<>.

I can see that the first syntax would give us a bit more flexibility. Like one
could create a list of all shelving locations actually in use:

<>

And also allowing to pull in a second table for getting descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

--- Comment #8 from Katrin Fischer  ---
Hi Pablo, thx for the systematic testing!

(In reply to Pablo AB from comment #7)
> ## Setting Combination
> 
> QueryAutoTruncate - Automatically
> QueryFuzzy - Try/Don't try
> QueryStemming - Try/Don't try
> 
> [Search Terms : Number of Results : Notes]
> frogs toads : 8 :
> frogs and toads : 7 : The missing record here contains 'toadstools' -
> truncation not working correctly?

I think this is due to it not containing frogs. The and is (as far as I know)
interpreted as boolean operator.

> frogs or toads : 29 : 'And' and 'or' treated as search operators.
> Adv. Search: frogs and toads : 8 : Apostrophe search not working

What do you mean by Apostrophe search?

> QueryAutoTruncate - only if * added
> QueryFuzzy - don't try
> QueryStemming - don't try
> 
> frogs toads : 7 :
> frogs and toads : 5 : And is treated as a search word
> frogs or toads : 0 :
> Adv. Search: frogs and toads : 7 : Apostrophe search not working 
> 
> QueryAutoTruncate - only if *added
> QueryFuzzy - don't try
> QueryStemming - Try
> 
> frogs toads : 0 : No results for any search
> frogs and toads : 0 :
> frogs or toads : 0 :
> Adv. Search: frogs and toads : 0 :

It's hard to tell without seeing the records what's going on there and if it's
correct or not. 

> QueryAutoTruncate - only if *added
> QueryFuzzy - Try
> QueryStemming - don't try/Try
> 
> frogs toads : 0 : No results for any search 
> frogs and toads : 0 :
> frogs or toads : 0 :
> Adv. Search: frogs and toads : 0 :
> 
> Queryfuzzy can't be used with ICU in use?

I think that is possible, we have had to play around with settings when we
started using ICU in the first library. ,ext (exact field content) search is
also not working with ICU as far as I know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98077|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 106805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106805=edit
Bug 24473: Add $raw filter for Syndetics content

Signed-off-by: Stina Hallin 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #12 from Katrin Fischer  ---
I see that Stina had signed this off originally, setting back to "signed off".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25923] pr-BR translations breaks Tools (Ferramentas) menu and submenus

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25923

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #1 from Katrin Fischer  ---
Hi Steven, 

usually translation errors like these need to be fixed on
translate.koha-community.org where we maintain the po files used for
translations.

The files from there are then shipped with every release of Koha. 

I have copied the original English into the translations on translate now for
pr-BR now and hope this will fix the issue. But please check!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25981] apt-get install koha-common returned E: Unable to correct problems, you have held broken packages.

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25981

Katrin Fischer  changed:

   What|Removed |Added

  Component|Installation and upgrade|Packaging
   |(command-line installer)|
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25981] New: apt-get install koha-common returned E: Unable to correct problems, you have held broken packages.

2020-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25981

Bug ID: 25981
   Summary: apt-get install koha-common  returned E: Unable to
correct problems, you have held broken packages.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@mphomosia.com
QA Contact: testo...@bugs.koha-community.org

Hi

I am trying to install Koha on Ubuntu 18.04 and have followed the installation
instructions specified at
http://libtechbwn.blogspot.com/2018/09/install-koha-in-ubuntu-1804-lts.html

After # sudo apt-get install koha-common

I get: 

Reading package lists... Done
Building dependency tree   
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not
going to be installed
E: Unable to correct problems, you have held broken packages.


Please assist me. 

Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/