[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #8 from David Cook  ---
Another suggestion would be to look into whatever logging/monitoring you have
for Elasticsearch, MariaDB Galera, and Memcached. 

If I were you, I'd be checking those logs, when I experience the Koha latency. 

Going back to my previous example, I had a Keycloak cluster that had 2 active
nodes and 2 dead nodes. Requests were only going to the 2 active nodes, but
they were struggling, because they were obsessing over checking the 2 dead
nodes. 

Admittedly, that doesn't always happen. It was a bit of a fluke that I noticed
one time, but it was interesting. 

Looking at Galera... it looks like there's a default 5 second timeout
inactivity:
https://galeracluster.com/library/documentation/galera-parameters.html#evs-suspect-timeout.
 

After you power off/disconnect Node A, does the performance degradation stay
for a long time? Or does it resolve itself after X minutes?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #7 from David Cook  ---
(In reply to Christian McDonald from comment #6)
> Well Koha doesn't really know it is part of a cluster, does it? It still
> talks to a single MariaDB instance (at localhost, just like a standalone
> instance), and the same can be applied to ES (again a single localhost:9200
> ES node could be configured on each, just like a standalone deployment). 
> 
> Apache isn't aware it's part of a cluster. Plack/Starman aren't aware
> either. Really Koha is still "standalone" from the perspective of Koha
> itself, it just so happens that the DB, file-system and index are
> distributed.
> 

Right, Koha isn't aware of the clusters, but it relies on components that are
clustered, so if those components experience latency, then Koha will experience
latency.

> So what I mean about taking nodes offline is that, when all nodes are online
> and all services running, everything is very performant. As I would expect.
> However, when one node goes offline, the Koha application itself becomes
> very slow to respond to page loads...lots of spinning browser tabs waiting
> for a response...but it will eventually respond. My question is, why? Again,
> Koha as an application isn't aware that it is part of a cluster, it doesn't
> know that it's database, file system and index are replicated under-the-hood.
> 

And that's why Jonathan and I were saying that you should profile the
application to see where it's hanging. 

It might be trying to do database I/O, but the database might not be responding
because it's trying to synchronize with the missing DB node. I'm not familiar
with Galera, but multi-master sounds like it would need synchronous
consistency, which could be slow and if it were trying to synchronize (until it
times out) with a node that isn't there... that could be a source of latency. 

> Here's what's weird. Like I said, when all nodes and their services are
> online, everything is fine. However, say if I "systemctl stop" Maria,
> elastic, Apache, and memcached on a single node (say on Node A), everything
> still is fine when connecting to either of the remaining nodes (Nodes B and
> C). However, if I then power down Node A (remember, all it's koha-related
> services had been stopped) or pull node A's network connection, node B and C
> become very slow to serve page requests. Again, this isn't because of some
> performance degradation of Maria (3 nodes can withstand 1 node offline),
> Elastic (again, one node offline is okay). 
> 

When you say that you "power down Node A", what kind of power down is that? Is
it graceful or forced? Pulling out node A's network connection is definitely a
forced outage, so I could see that having impact on a cluster. 

If you're sure about Galera's and Elastic's fault tolerance, I'd say look at
Memcached. 

Even if the systems are fault tolerant, I imagine there will be some latency
due to cluster re-balancing and comms timeouts. But I haven't run these
particular clusters. I've just had issues with latency on other clustered
systems when the remaining systems are trying to determine that the dead
members are actually dead. 

> What can I do to monitor performance, or poke into Plack/Starman? The reason
> why I have a hunce Plack/Starman are involved here is because when I disable
> Plack on all nodes, the loss of a single node doesn't impact the performance
> of the remaining nodes... granted with Plack disabled they are all noticably
> slower, which is expected

I really don't think it's going to Be Plack/Starman. Everything suggests it
being one of the distributed systems. However, the easiest way to find that is
by profiling the Koha application. 

Now I haven't done this in a while... but you'll want to look at NYTProf and
you might get some clues about configuration at
https://wiki.koha-community.org/wiki/Plack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #6 from Christian McDonald  ---
Well Koha doesn't really know it is part of a cluster, does it? It still talks
to a single MariaDB instance (at localhost, just like a standalone instance),
and the same can be applied to ES (again a single localhost:9200 ES node could
be configured on each, just like a standalone deployment). 

Apache isn't aware it's part of a cluster. Plack/Starman aren't aware either.
Really Koha is still "standalone" from the perspective of Koha itself, it just
so happens that the DB, file-system and index are distributed.

So what I mean about taking nodes offline is that, when all nodes are online
and all services running, everything is very performant. As I would expect.
However, when one node goes offline, the Koha application itself becomes very
slow to respond to page loads...lots of spinning browser tabs waiting for a
response...but it will eventually respond. My question is, why? Again, Koha as
an application isn't aware that it is part of a cluster, it doesn't know that
it's database, file system and index are replicated under-the-hood.

Here's what's weird. Like I said, when all nodes and their services are online,
everything is fine. However, say if I "systemctl stop" Maria, elastic, Apache,
and memcached on a single node (say on Node A), everything still is fine when
connecting to either of the remaining nodes (Nodes B and C). However, if I then
power down Node A (remember, all it's koha-related services had been stopped)
or pull node A's network connection, node B and C become very slow to serve
page requests. Again, this isn't because of some performance degradation of
Maria (3 nodes can withstand 1 node offline), Elastic (again, one node offline
is okay). 

Also, when Apache is nuked, HAProxy immediately stops sending clients to that
node. So in that regard, once Apache is hosed, that node isn't even going to
get client requests.


What can I do to monitor performance, or poke into Plack/Starman? The reason
why I have a hunce Plack/Starman are involved here is because when I disable
Plack on all nodes, the loss of a single node doesn't impact the performance of
the remaining nodes... granted with Plack disabled they are all noticably
slower, which is expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.06  |20.11.00, 20.05.06,
released in||19.11.12
 CC||alei...@catalyst.net.nz
 Status|Pushed to stable|Pushed to oldstable

--- Comment #55 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543
Bug 26543 depends on bug 26557, which changed state.

Bug 26557 Summary: Batch import fails when incoming records contain itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Aleisha Amohia  ---
missing dependencies, not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #5 from David Cook  ---
(In reply to Christian McDonald from comment #0)
> 
> When I disable Starman/Plack on all nodes, the speed of each node doesn't
> change when a single node goes offline.

What do you mean by "the speed of each node"? Is this a reference to the Koha
application specifically? If Starman/Plack is disabled, are you running Koha
using CGI?

I'd be interested to know more about your "node goes offline" scenario. I
assume this is not a graceful process? If you think about it, chances are your
clusters haven't been notified that the node has left the cluster, so they're
going to keep trying to connect to it. That would explain a slowdown.
Gracefully shutting down a process would probably cause a node member to
gracefully leave the cluster and that would explain a lack of a slowdown.

I'd say... profile the application and monitor network traffic during slowdown. 

As a side note: I think it's great that you're trying out this clustered setup!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #4 from Jonathan Druart  
---
Yes, sorry Christian, I misread. I thought you had only 1 memcached server per
node. With the full cluster defined on each node you should be good.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
(In reply to Christian McDonald from comment #2)
> That makes sense, though that's conflicting with what I'm reading about
> scaling out memcached in this way. So then, what is the point of having
> multiple memcached servers (which can be configured in koha-conf.xml)? As I
> understand memcached (which I will admit is novice at best), the use of
> multiple servers is completely up to the memcached client
> implementation...something along the lines of hashing each keyitem against
> the server list, effectively tying a keyitem to a single node in the
> cluster. Because the number of nodes is known by all clients, this should
> effectively distribute keys across the nodes and ensure a cached value only
> lives on one node at a time. If a node goes down, those keys are simply
> rebased on another node.
> 
> I might be completely off here too lol

I haven't set up a memcached cluster but I think it should be fine so long as
it's configured correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27083] New: Create ability to record circulation for every item in kits or sets

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27083

Bug ID: 27083
   Summary: Create ability to record circulation for every item in
kits or sets
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Our library would like to have a way to record circulation for kits or sets
that consist of multiple items.  For example we have kits which consist of ten
copies of the same title that can be used for a book discussion group.  We also
have DVD binge bags/boxes which consist of five various DVD titles on a theme. 
All of these could exist on their own but we've packaged them up for the
convenience of the patron or to market our collection better.  Each kit/set has
one barcode and is recorded as only one check out.  But we would like to be
able to record the book discussion kit as 10 checkouts since it consists of 10
books.  We’d like to have the DVD binge bags record 5 check outs since we
assume all of the DVDs were probably viewed.  I’m not sure how this could be
accomplished but what I’m envisioning is a field in the item record were you
could set the number of circs that should be counted when a particular
kit/bag/box is checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27082] New: Problem when a basket has more of 20 orders with uncertain price

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082

Bug ID: 27082
   Summary: Problem when a basket has more of 20 orders with
uncertain price
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

There is a problem when a basket has more of 20 orders with uncertain price

Test plan:

1- create a basket
2- add more of 20 orders with uncertain price
3- click on uncertain price button
4- on page 1 of list, uncheck uncertain box of an order
5- click on save button
6- orders who were on page 2 are not display anymore in page uncertainprice.pl
7- return to basket view acqui/basket.pl
8- orders who were on page 2 have "rvcd" label and quantity is null

Screen capture here https://www.screencast.com/t/00cO5f1RNJdE

Tested on 19.05 and 20.05.04

Regards

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

David Nind  changed:

   What|Removed |Added

 Attachment #113925|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 113938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113938=edit
Bug 27072: Don't process staff interface CSS with rtlcss

This patch changes Koha's gulpfile to add a check for the "OPAC" context
before using rtlcss to automatically build right-to-left versions of
CSS.

To test, apply the patch and test the process of building CSS for both
the OPAC and staff client:

- "yarn css --view opac" : This should build unminified CSS for the
OPAC, including map files in bootstrap/css/maps

- "yarn build --view opac" : This should build minified CSS for the
  OPAC and generate the RTL versions.

- "yarn css" : This should build unminified CSS for the staff
  interface, including map files in prog/css/maps.

- "yarn build" : This should build minified CSS for the
   staff interface, with no creation of RTL versions.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

--- Comment #2 from Christian McDonald  ---
That makes sense, though that's conflicting with what I'm reading about scaling
out memcached in this way. So then, what is the point of having multiple
memcached servers (which can be configured in koha-conf.xml)? As I understand
memcached (which I will admit is novice at best), the use of multiple servers
is completely up to the memcached client implementation...something along the
lines of hashing each keyitem against the server list, effectively tying a
keyitem to a single node in the cluster. Because the number of nodes is known
by all clients, this should effectively distribute keys across the nodes and
ensure a cached value only lives on one node at a time. If a node goes down,
those keys are simply rebased on another node.

I might be completely off here too lol

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581

--- Comment #26 from Aleisha Amohia  ---
(In reply to Nick Clemens from comment #25)
> (In reply to Aleisha Amohia from comment #24)
> > does not apply cleanly on 19.11.x, please rebase
> 
> Relies on 25265 which relies on 26507 (though not really) which relies on
> 23463.
> 
Thanks, I have added the dependency to the bug report.

missing dependencies, not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||26581


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581
[Bug 26581] Elasticsearch - Records can be indexed multiple times during
returns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||25265


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265
[Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to
incorrect index
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||26750


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26750
[Bug 26750] Deleted items are not removed from index
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26750] Deleted items are not removed from index

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26750

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||23463

--- Comment #12 from Aleisha Amohia  ---
(In reply to Björn Nylén from comment #11)
> (In reply to Aleisha Amohia from comment #10)
> > doesn't apply cleanly for 19.11.x, please rebase
> 
> This bug was introduced by Bug 23463 so shouldn't exist in 19.11

Thanks, I'll add this to the bug report.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
[Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747

--- Comment #8 from Nick Clemens  ---
Created attachment 113937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113937=edit
Bug 26747: [20.05.x] Show 'Always available' if title always available in
overdrive

To test:
1 - Have a developer account for overdrive, or library credentials
https://developer.overdrive.com/
2 - Enter info into 'Overdrive' sysprefs and enable overdrive
3 - Search for 'house' in the opac
4 - Click the overdrive link
5 - Note some titles in the collection show 99 copies available
6 - Apply patch
7 - Note they now say 'Always available'

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26750] Deleted items are not removed from index

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26750

--- Comment #11 from Björn Nylén  ---
(In reply to Aleisha Amohia from comment #10)
> doesn't apply cleanly for 19.11.x, please rebase

This bug was introduced by Bug 23463 so shouldn't exist in 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

--- Comment #4 from Nick Clemens  ---
Created attachment 113936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113936=edit
Test records

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113934|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 113935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113935=edit
Bug 26957: Don't remove words that are also operators from search terms

FindDuplicate has a hardcoded regex to remove 'and', 'or', and 'not' from any
search fields, however,
is does this with no regard for these terms being embedded in the middle of a
word or phrase.

E.g.:
'Coupland' becomes 'Coupl'
'Frog and toad' becomes 'frog toad'
etc.

This patch simplay removes the substitutions as we already quote the terms as
well

To test:
1 - Add records to your system like:
The night circus by Erin Morgenstern
Frog and toad all year
Nothing ever happens
2 - Attempt to add purchase suggestions like
title: the night circus, author:Morgenstern, Erin
title: For and toad all year
title:nothing ever happens (case is important)
3 - No warnings about existing biblios
4 - Apply patches
5 - Delete existing suggestions
6 - Repeat step 2
7 - Each attempt should warn you of existing biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

--- Comment #2 from Nick Clemens  ---
Created attachment 113934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113934=edit
Bug 26957: Don't remove words that are also operators from search terms

FindDuplicate has a hardcoded regex to remove 'and', 'or', and 'not' from any
search fields, however,
is does this with no regard for these terms being embedded in the middle of a
word or phrase.

E.g.:
'Coupland' becomes 'Coupl'
'Frog and toad' becomes 'frog toad'
etc.

This patch simplay removes the substitutions as we already quote the terms as
well

To test:
1 - Add records to your system like:
The night circus by Erin Morgenstern
Frog and toad all year
Nothing ever happens
2 - Attempt to add purchase suggestions like
title: the night circus, author:Morgenstern, Erin
title: For and toad all year
title:nothing ever happens (case is important)
3 - No warnings about existing biblios
4 - Apply patches
5 - Delete existing suggestions
6 - Repeat step 2
7 - Each attempt should warn you of existing biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

--- Comment #1 from Nick Clemens  ---
Created attachment 113933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113933=edit
Bug 26957: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21498] Possibility to renew early when automatic renewals are enabled

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21498

--- Comment #1 from Marjorie Barry-Vila  ---
Duplicate of #22018 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21498] Possibility to renew early when automatic renewals are enabled

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21498

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

--- Comment #12 from Victor Grousset/tuxayo  ---
(and it works ^^)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

--- Comment #11 from Victor Grousset/tuxayo  ---
Thanks, QA script ok :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113924|0   |1
is obsolete||

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 113932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113932=edit
Bug 25942: (follow-up) fix filters

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113916|0   |1
is obsolete||

--- Comment #9 from Victor Grousset/tuxayo  ---
Created attachment 113931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113931=edit
Bug 25942: Fix batch report operations for cardnumbers and biblionumbers

This patch moves the processing for these to a block and adds a comment
in place of whitespace and uses template directives to chomp newlines to
improve readability

To test:
 1 - Create a report like:
SELECT biblionumber FROM biblio
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
(You will need to define a marc modification template)
 4 - The operations don't find the biblios
 5 - Create a report like:
SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581

--- Comment #25 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #24)
> does not apply cleanly on 19.11.x, please rebase

Relies on 25265 which relies on 26507 (though not really) which relies on
23463.

Changes a bit bigger than I can clear through easily, anyone else is welcome to
take stab, but I think it's okay if only in stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26679] Genre tags linking to subject search, causing null results

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26679

Andrew Fuerste-Henry  changed:

   What|Removed |Added

  Component|Searching - Elasticsearch   |Searching
Summary|Elasticsearch and   |Genre tags linking to
   |Genre/Form Terms: "No   |subject search, causing
   |results found" after|null results
   |clicking genre term URL in  |
   |opac-detail |
 QA Contact||testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27081] New: Notes missing from lost items report column configuration

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27081

Bug ID: 27081
   Summary: Notes missing from lost items report column
configuration
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The last column of the lost items report - "notes" is missing from the table
configuration pull down in 20.05.05. Couldn't test in master yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Timothy Alexis Vass  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |timothy_alexis.v...@ub.lu.s
   |ity.org |e

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] New: Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Bug ID: 27080
   Summary: Add --statute-barred option to cleanup_database.pl to
purge all fees where the item has been returned and
the fee is older than the given number of days.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: timothy_alexis.v...@ub.lu.se
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

According to Swedish law, fees become statute-barred after 3 years.
With this option, we can use cleanup_database.pl to purge those from
accountlines.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
I bet you don't see anything on htop?

Are you able to profile a perl process to catch any bottlenecks?

I don't think you are safe using Memcached on each node. If you have Node 1
that modifies something that is cached, only the one from Node 1 will be
updated/invalidated. Nodes 2 and 3 will continue to use an old value.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26679] Elasticsearch and Genre/Form Terms: "No results found" after clicking genre term URL in opac-detail

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26679

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26679] Elasticsearch and Genre/Form Terms: "No results found" after clicking genre term URL in opac-detail

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26679

--- Comment #4 from Andrew Fuerste-Henry  ---
Created attachment 113930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113930=edit
Bug 26679: Use index-term-genre for 655

To test:
1 - have a bib with a 655 that is not linked to an authority
2 - confirm link on OPAC and intranet details uses subject index
3 - apply patch, restart, reload pages
4 - confirm links now use index-term-genre and give correct results

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26679] Elasticsearch and Genre/Form Terms: "No results found" after clicking genre term URL in opac-detail

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26679

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Christopher Brannon  changed:

   What|Removed |Added

  Text to go in the|This feature adds the   |This feature adds the
  release notes|ability to define some  |ability to define some
   |itemtypes as 'parent' to|itemtypes as 'parent' to
   |other item types for|other item types for
   |defining circulation|defining circulation
   |limits.
|limits.
   |
   |
   |This allows to  |This allows to
   |create 'groups' of related  |create 'groups' of related
   |items types. E.g. - a   |items types. E.g. - a
   |library has both Blu-ray|library has both Blu-ray
   |and DVD itemtypes - these   |and DVD itemtypes - these
   |can be grouped under the|can be grouped under the
   |'Media' itemtype. The   |'Media' itemtype. The
   |checkout limit for Media|checkout limit for Media
   |will then apply to both |will then apply to both
   |Blu-ray and DVD. 
  |Blu-ray and DVD.
   |
   |
   |So if a |So if a
   |library says a patron can   |library says a patron can
   |have 4 dvds - 4 blu-ray -   |have 4 dvds - 4 blu-ray -
   |and sets Media to have a|and sets Media to have a
   |limit of 4 then patrons can |limit of 4 then patrons can
   |have up to 4 items of   |have up to 4 items of
   |either type (e.g. 1 DVD, 3  |either type (e.g. 1 DVD, 3
   |blu-rays) but will be   |blu-rays) but will be
   |prevented form checking out |prevented from checking out
   |more of either type by the  |more of either type by the
   |limit on the parent.
   |limit on the parent.
   ||
   |Parent rules only apply to  |Parent rules only apply to
   |checkout limits |checkout limits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26679] Elasticsearch and Genre/Form Terms: "No results found" after clicking genre term URL in opac-detail

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26679

--- Comment #3 from Andrew Fuerste-Henry  ---
I should clarify, that bit is from MARC21slimOPACdetails for the 655.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26876] Add ability to create items when using Bibliotheca eBook plugin

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26876

--- Comment #2 from Barbara Johnson  ---
Yes that's the one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27079] New: UpdateFine adds refunds for fines paid off before return

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079

Bug ID: 27079
   Summary: UpdateFine adds refunds for fines paid off before
return
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The issue seems to be that the amount passed in to UpdateFine fails the
comparison to $accountline->amount - one is $1.80 and the other is $1.8
and comparison fails:

576 if ( $accountline ) {
577 if ( $accountline->amount != $amount ) {

To recreate:
1 - Set a circ rule to have a .15 per day fine
2 - Issue an item of this type to a borrower
3 - Make it 12 days overdue either at checkout or in the db:
UPDATE issues SET date_due = DATE_SUB(CURDATE(),INTERVAL 12 DAY);
4 - Run the fines job or just put a fine in place:
INSERT INTO accountlines
(issue_id,borrowernumber,itemnumber,amount,debit_type_code,status,amountoutstanding)
SELECT issue_id,5,itemnumber,1.80,'OVERDUE','UNRETURNED',1.80 FROM issues WHERE
borrowernumber=5;
5 - Pay the fine for the patron
6 - Check in the item
7 - Note that the patron has an 'Overpayment refund' of $0.00

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27078] New: Starman hanging in 3-node Koha cluster when 1 node goes offline.

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27078

Bug ID: 27078
   Summary: Starman hanging in 3-node Koha cluster when 1 node
goes offline.
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rcmcdonal...@gmail.com
QA Contact: testo...@bugs.koha-community.org

So I've got a pretty interesting case that I've been playing with for the past
several weeks. My goal has been to build a converged 3-node Koha cluster.

The architecture looks like this:
1. Each node runs the "standalone" Koha stack (Koha, Starman, Apache,
ElasticSearch, Memcached, MariaDB). For the sake of example, these nodes are
10.10.100.51, 10.10.100.52, and 10.10.100.53.
2. Galera is used to build the 3-node MariaDB cluster and each Koha node simply
talks to the MariaDB server at localhost. This has worked fine and koha is
blissfully unaware of the underlying galera cluster.
3. ElasticSearch is built in a 3-node cluster. koha-conf.xml is configured to
use all three ES nodes (again at 10.10.100.51, 10.10.100.52, and 10.10.100.53).
Again, koha doesn't seem to mind this at all.
4. All three nodes run Memcached and koha-conf.xml is configured to use all
three Memcached nodes (again at 10.10.100.51-3). 
5. Plack is enabled on all nodes using koha-plack --enable instancename &&
koha-plack --start instancename.
6. GlusterFS is used to serve up a 3-node replicated volume for /etc/koha/*,
/usr/share/koha/*, and /var/lib/koha* across all three nodes. symlinks are used
to present this storage in places koha is expecting them to be. Again, this
works great.
6. Two HAProxy instances sit in front of these three koha instances (at
10.10.100.2 and 10.10.100.3). koha_trusted_proxies in koha-conf.xml is
configured with these two IPs.
7. Finally, HAProxy handles SSL-offloading and client stickiness. This all
works fine too.

Here is the weirdness... When all three nodes are online, everything is
absolutely fine. Everything is snappy, searching works, etc. When I change
koha-conf.xml on one node, this is replicated to the other nodes immediately.
However, when one node goes offline, the two remaining nodes become really
sluggish. I've narrowed this down to a Starman/Plack issue, but I have no idea
why. 

Here's how I arrived at that conclusion.

* I started by killing pertinent services one-by-one on Node A. Killing MariaDB
on Node A had no effect on Node B and C... though as expected, Node A started
spitting out errors that the DB was unavailable.
* Next, I stopped Memcached on Node A. Again, this had no effect on Node B and
C.
* Next, I stopped ElasticSeasrch on Node A. Again, this had no effect on Node B
and Node C.
* Next, I stopped GlusterFS on Node A. Again, this had no effect on Node B and
Node C.
* Next, I stopped koha-common on Node A. Again, this had no effect on Node B
and Node C.


So at this point, Node A is still "online." However, every service related to
Koha is stopped (MariaDB, Memcached, ElasticSearch, Apache, koha-common, etc.).
As expected, Node B and C keep on working just fine.

Here is the weird part,

When Node A actually goes offline (i.e. loses network connectivity and/or
powers down), Node B and C become very very slow. They still serve traffic, but
they are really sluggish. As soon as connectivity is restored to Node A, Node B
and Node C speed right back up again.

So is this related to Starman/Plack?

When I disable Starman/Plack on all nodes, the speed of each node doesn't
change when a single node goes offline.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Also, we should not see "pickupNotInHoldGroup" on the interface, the error code
is not handled correctly to display a correct message to the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071

--- Comment #4 from Jonathan Druart  
---
In my understanding Koha::Library->validate_hold_sibling is plain wrong. It
only tests for the first from @hold_libraries is not the one we are looking
for, then it's considered an invalid one.

However with this patch we have tests from t/db_dependent/Holds.t that are
failing (maybe others as well).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071

--- Comment #3 from Jonathan Druart  
---
Created attachment 113929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113929=edit
Bug 27071: Code simplification

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071

--- Comment #2 from Jonathan Druart  
---
Created attachment 113928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113928=edit
Bug 27071: Fix Hold pickup library when using hold groups

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819

--- Comment #9 from Kyle M Hall  ---
Created attachment 113927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113927=edit
Bug 26819: (QA follow-up) Fix branchtransfers.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819

--- Comment #8 from Kyle M Hall  ---
Created attachment 113926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113926=edit
Bug 26819: (QA follow-up) authorized_value should be authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

--- Comment #2 from Owen Leonard  ---
Created attachment 113925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113925=edit
Bug 27072: Don't process staff interface CSS with rtlcss

This patch changes Koha's gulpfile to add a check for the "OPAC" context
before using rtlcss to automatically build right-to-left versions of
CSS.

To test, apply the patch and test the process of building CSS for both
the OPAC and staff client:

- "yarn css --view opac" : This should build unminified CSS for the
OPAC, including map files in bootstrap/css/maps

- "yarn build --view opac" : This should build minified CSS for the
  OPAC and generate the RTL versions.

- "yarn css" : This should build unminified CSS for the staff
  interface, including map files in prog/css/maps.

- "yarn build" : This should build minified CSS for the
   staff interface, with no creation of RTL versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27075] "Cancel charge" doesn't seem to appear in po files or on translate

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27075

Jonathan Druart  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
I emailed Bernardo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

Owen Leonard  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

--- Comment #8 from Nick Clemens  ---
Created attachment 113924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113924=edit
Bug 25942: (follow-up) fix filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26578] OverDrive results can return false positives when searches contain CCL syntax

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578

Nick Clemens  changed:

   What|Removed |Added

 Attachment #110987|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 113923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113923=edit
Bug 26578: Clean overdrive searches before passing to OD

This patch copies regex used in buildQuery to detect ccl code in queries, but
here we adapt
it to remove any ccl signifiers to ensure correct results from OD

To test:
1 - Have OverDrive enabled and configured
2 - set UseAuthoritiesForTracings to "Don't use"
3 - Search in the catalog for a record
4 - From the details page for a record click on an author link
5 - Note the query in catalog is like 'au:Whitford, Bradley.'
6 - Some overdrive catalogs will return records matching 'au:'
7 - Apply patch
8 - Reload the page, if there were spurious results before, they should now be
gone
9 - Perform a search that returns overdrive results
10 - For a title in overdrive search koha with:
au:{Author} AND ti:{Title}
11 - Confirm overdrive results are returned
12 - Check the link to overdrive results and note query section is:
q=Author AND Title

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113810|0   |1
is obsolete||

--- Comment #2 from Victor Grousset/tuxayo  ---
Created attachment 113922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113922=edit
WIP Bug 27055: Fix compatibility with newer Selenium+Firefox version

Fix "submit is not a function error"
A submit button should be named "submit", in this case, it's id.
https://stackoverflow.com/questions/833032/submit-is-not-a-function-error-in-javascript

Fix some uses of get_attribute()

Fix with wait_for_element_visible()

WIP:
1. Fix SCSS which used the id=submit
2. Fix other tests, there are major issues like crash at the beginning
   or endless duration

== Test plan ==
1. Update selenium/standalone-firefox to the latest version [1]
2. prove t/db_dependent/selenium/authentication.t
3. It fails with: arguments[0].form.submit is not a function
4. Apply patch
5. Retest
6. Success

[1] In koha-testing-docker you can do it with
docker-compose.yml
 selenium:
-image: selenium/standalone-firefox:2.53.1-americium
+image: selenium/standalone-firefox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

--- Comment #1 from Jonathan Druart  
---
I'd like this one for 20.11 if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

hasa...@mugirls.org.uk changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

--- Comment #5 from hasa...@mugirls.org.uk ---
Thank you very much. i will look into all this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

--- Comment #32 from Nick Clemens  ---
Created attachment 113921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113921=edit
Bug 26518: (QA follow-up) Expect warnings, don't supress them

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113674|0   |1
is obsolete||

--- Comment #31 from Nick Clemens  ---
Created attachment 113920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113920=edit
Bug 26518: Move BiblioAutoLink within the transaction

We don't want the authorities to be created if the biblio insert fails
later

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113673|0   |1
is obsolete||

--- Comment #30 from Nick Clemens  ---
Created attachment 113919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113919=edit
Bug 26518: Hide expected DBI warnings

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113672|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 113918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113918=edit
Bug 26518: Raise exception if the insert failed

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113671|0   |1
is obsolete||

--- Comment #28 from Nick Clemens  ---
Created attachment 113917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113917=edit
Bug 26518: Use Koha::Biblio[item] in AddBiblio

Bug 26518: Does not return from the catch block

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Owen Leonard  ---
(In reply to hasanah from comment #0)

> This is my KOHA VERSION: 17.11.04.000

I don't know if it's related to your problem, but this Koha version is over two
years old now and is no longer maintained. I would think an upgrade is
recommended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27076] software error

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27076

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This feature adds the
  release notes||ability to define some
   ||itemtypes as 'parent' to
   ||other item types for
   ||defining circulation
   ||limits.
   ||
   ||This allows to
   ||create 'groups' of related
   ||items types. E.g. - a
   ||library has both Blu-ray
   ||and DVD itemtypes - these
   ||can be grouped under the
   ||'Media' itemtype. The
   ||checkout limit for Media
   ||will then apply to both
   ||Blu-ray and DVD.
   ||
   ||So if a
   ||library says a patron can
   ||have 4 dvds - 4 blu-ray -
   ||and sets Media to have a
   ||limit of 4 then patrons can
   ||have up to 4 items of
   ||either type (e.g. 1 DVD, 3
   ||blu-rays) but will be
   ||prevented form checking out
   ||more of either type by the
   ||limit on the parent.
   ||
   ||Parent rules only apply to
   ||checkout limits

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27077] Searching for patrons with guarantor_id criteria results in 500 error

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27077

Arthur Suzuki  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27077] New: Searching for patrons with guarantor_id criteria results in 500 error

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27077

Bug ID: 27077
   Summary: Searching for patrons with guarantor_id criteria
results in 500 error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: arthur.suz...@biblibre.com

Tried to fetch all patrons who's guarantor is "someone", got 500 error.
Due to changes in the borrower table to permit multiple guarantor.

Curl command :

curl http://localhost:8080/api/v1/patrons?guarantor_id=42 \
-H 'Authorization: Basic a29oYTprb2hh'


Plack error log :

[2020/11/23 10:20:33] [WARN] Use of uninitialized value $column_type in string
eq at /kohadevbox/koha/Koha/Object.pm line 447.
[2020/11/23 10:20:33] [WARN] DBD::mysql::st execute failed: Unknown column
'guarantorid' in 'where clause' [for Statement "SELECT `me`.`borrowernumber`,
`me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`,
`me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`,
`me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`,
`me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`,
`me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`,
`me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`,
`me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`,
`me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`,
`me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`date_renewed`,
`me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`,
`me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`,
`me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`,
`me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`,
`me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`,
`me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_fines`,
`me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`,
`me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`,
`me`.`overdrive_auth_token`, `me`.`anonymized`, `me`.`autorenew_checkouts` FROM
`borrowers` `me` WHERE ( `guarantorid` LIKE ? )" with ParamValues: 0="%42%"] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.



-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886

Timothy Alexis Vass  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #27 from Timothy Alexis Vass  ---
Can we reach a decision on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/