[Koha-bugs] [Bug 27431] ES searches containing words starting with 2 hyphens or only hyphen(s) fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27431 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28148] JavaScript error when printing transfer slip for existing transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 --- Comment #10 from Katrin Fischer --- Created attachment 119814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119814=edit Bug 27644: (QA follow-up) Remove size=1 from template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 Katrin Fischer changed: What|Removed |Added Attachment #119311|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 119813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119813=edit Bug 27644: (follow-up) Wrap strings in translation function This patch updates the in-template JavaScript so that some English strings which were previously untranslatable. This patch wraps them in the _() function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from reports/guided_reports_start.tt for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:1324 #, fuzzy, c-format msgid "Authorized value category:" msgstr "Catégorie de valeur autorisée: " - Edit the "msgstr" string if necessary, or remove the "fuzzy," before "c-format" - Install the updated translation: > perl translate install fr-FR In the staff interface, switch to the language you're testing. Confirm that your translated strings appear. In this case, test in particular: - The controls on the modal window when you preview a report's SQL from the list of saved reports. - The controls and modal dialog for inserting a runtime parameter. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 Katrin Fischer changed: What|Removed |Added Attachment #119039|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 119812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119812=edit Bug 27644: Add button to SQL report editor for inserting runtime parameters This patch adds a button menu to the SQL report CodeMirror editor for inserting runtime parameters. Each menu item triggers a modal dialog where the user can specify a parameter label and any other relevant option. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Reports -> Use saved. - Create or edit a report. - You should see a menu button above the SQL editor field, "Insert runtime parameter." - The menu should contain the options "Authorized value," "Date," "Item types," "Libraries," "Patron categories," and "Text field." - Test each option. Each should trigger the display of a modal dialog with a heading which corresponds to your choice. - In all cases except the "Authorized value" choice you should see a single form field for "label." - Enter text in the label field and click the "Insert parameter" button. - The correct runtime parameter should be inserted into the SQL editor. - If you placed a cursor somewhere in the SQL editor first, your parameter should be inserted in that location in the editor. - If you selected some text in the editor before selecting a parameter, the paramter should replace the selected text. - In the case of the "Authorized value" selection, the modal dialog should include both a label field and a field for choosing an authorized value category. - Try submitting the form without selecting an authorized value. It should warn you that the field is required. - After testing the authorized value selection, try inserting another parameter to confirm that the authorized value selection (now hidden) is no longer required. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28165] New: Use nicer descriptions in layout summary table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28165 Bug ID: 28165 Summary: Use nicer descriptions in layout summary table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Wit bug 28119 nicer descriptions were added to the edit/add form, but the summary table of layouts still shows some crytic codes in the print type column. It would be nice to see this improved as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer changed: What|Removed |Added Attachment #119558|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 119811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119811=edit Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer changed: What|Removed |Added Attachment #119439|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 119810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119810=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #6 from Katrin Fischer --- Should it be proceeds or not maybe preceeds? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28164] New: Sorting on POS register details transactions table is not working right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28164 Bug ID: 28164 Summary: Sorting on POS register details transactions table is not working right Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: martin.renvo...@ptfs-europe.com Sorting on the transactions table on the point of sales register details page doesn't appear to work correctly. - Make some transactions in the points of sale page - Go to the register details page - Try to sort on the different columns - Only the price column will (partially?) sort - There is also sorting on the Actions columun -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #3 from Katrin Fischer --- Created attachment 119809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119809=edit Bug 28127: Add transaction timestamp to register details tables To Test: -Enable POS and setup some registers -Make some transactions -Go to Point of Sale > Register details and look at the two tables, sales and past sales -No timestamp or transaction date -Apply patch and look again -See Tranactions dates in the Transaction column Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28163] New: Register entries doubled up if form is submitted first without a selected register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28163 Bug ID: 28163 Summary: Register entries doubled up if form is submitted first without a selected register Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: martin.renvo...@ptfs-europe.com Testing the patch on bug 28127 I noticed a lot of double ups in my registry details. I think I know how to reproduce this: - Add a debit type for sale with a default price - Go to point of sale - Make sure you have no register selected by default - Add your debit type to current sale - Enter amount tendered - Leave register blank and submit - Set register - Submit again - Go to register details page use the link on the left There are now 2 identical entries in the details table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27830] OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer changed: What|Removed |Added Attachment #119559|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 119808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119808=edit Bug 27830: (follow-up) Merge DE and FR address formats Library addresses don't include the use of "Street Type" and "Street Number." DE and FR address formats differ only in the position of street type and number in the address sequence. This patch merges DE and FR address markup and uses the unified block if the address format system preference ISN'T "us". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27830] OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer changed: What|Removed |Added Attachment #119438|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 119807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119807=edit Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27830] OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27239] FRBRizeEditions is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Katrin Fischer changed: What|Removed |Added Attachment #119618|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 119806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119806=edit Bug 27239: Detail templates remove redundant test Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with syspref values and are redundant anyway. If syspref FRBRizeEditions or OPACFRBRizeEditions aren't set XISBN is empty. Test plan: 1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions 2 - Search for a notice with multiple ISBN in ThingISBN and with some of these ISBNs in Koha. Example: http://www.librarything.com/api/thingISBN/0452254264 In koha imported from LOC ISBN: 0452254264 0198185219 3 - Select one notice 4 - Edition tab is not there. 5 - Apply patch 6 - Redo 2 7 - Edition tab is there. 8 - Unset FRBRizeEditions and OPACFRBRizeEditions 9 - Edition tab isn't there. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27239] FRBRizeEditions is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Katrin Fischer changed: What|Removed |Added Attachment #119638|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 119805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119805=edit Bug 27232: Add missing space between : and in member-alt-contact-style.inc It caused the strings to appear twice in the po file Test plan: Apply this patch and regenerate the PO for a given language. Notice that the string "%s State: " only appears once in the PO file Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23583] Handle OpacHiddenItems with yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Katrin Fischer changed: What|Removed |Added Attachment #119246|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 119804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119804=edit Bug 23583: Handle OpacHiddenItems with yaml_preference This patch makes all places in Koha that rely on OpacHiddenItems actually use C4::Context->yaml_preference instead of manually calling the YAML libraries and handling it. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Items* \ t/db_dependent/Koha/Item* \ t/db_dependent/Koha/Filter/EmbedItems.t => SUCCESS: Tests pass! 3. Try hiding things with opac-ISBDdetail.pl and opac-search.pl => SUCCESS: Things work the same! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23583] Handle OpacHiddenItems with yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28162] Self registration fails if patron extended attributes are editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28162 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- A small change - risking to go directly to PQA here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28162] Self registration fails if patron extended attributes are editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28162 Katrin Fischer changed: What|Removed |Added Attachment #119783|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 119803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119803=edit Bug 28162: fix doubled scalar sigil TEST PLAN: 1 Set up some patron extended attributes 2 Make sure you check 'Display in OPAC' and 'Editable in OPAC' 3 Go to self registration and attempt to register 4 you get an error ( Not a SCALAR reference at /kohadevbox/koha/opac/opac-memberentry.pl line 110 ) 5 Apply patch 6 repeat steps 1-3, ther should be no error now Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28162] Self registration fails if patron extended attributes are editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28162 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
--- Comment #9 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #6)
> Hum, pondering. Why the OPAC maintenance only?
>
> Why not this one as well for instance?
> Koha/Patron/Password/Recovery.pm:my $kohaEmail = $library->branchemail
> || C4::Context->preference('KohaAdminEmailAddress'); # send from patron's
> branch or Koha Admin
Pondering why this still works for us, I think something happens in
sub _send_message_by_email to that. Jonathan, can you maybe verify and let me
know if I should file another bug?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086 Katrin Fischer changed: What|Removed |Added Attachment #119568|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 119802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119802=edit Bug 28086: OpacMaintenance page should use ReplytoDefault if set This patch changes the OPAC maintenance template so that it checks for a value in the ReplyToDefault system preference when displaying the "please contact the site administrator" email link. Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is defined, it won't show the link at all. To test, apply the patch and set the OpacMaintenance preference to "Show." - In the OPAC you should see the "System Maintenance" page. - Test this page with various settings: - ReplytoDefault and KohaAdminEmailAddress both populated. - Only ReplytoDefault - Only KohaAdminEmailAddress - Neither. Confirm that the correct email address is used in each case. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #3 from Katrin Fischer --- Sorry, but can you explain a bit more? >The loop here gets items from the record, plus analytic items. Because of this >we need to check more than 1 record - we decide to do this via biblioitems. >We need to preserve that, but when checking ItemsAnyAvailableAndNotRestricted >we >cannot assume that the biblionumber and biblioitemnumber are the same (they >>should be >but this may not be the best of all possible worlds) We have both biblioitemnumber and biblionumber on items table. biblioitems doesn't have any functionality at the moment, apart from it's 1:1 to biblio. So why do we need to preserve the use of biblioitemnumber? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer --- Really small change, going to set this directly to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer changed: What|Removed |Added Summary|Circulation Module Report |Overdues report uses |"Overdues" assumes time of |23:59:00 on To date filter |23:59:00 on upper bound of | |search | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27442] Circulation Module Report "Overdues" assumes time of 23:59:00 on upper bound of search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer changed: What|Removed |Added Attachment #115351|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 119801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119801=edit Bug 27442: Assume 23:59:59 for date due end date To test: 1 - have a checkout due yesterday at 23:59:59 2 - go to overdue.pl, search with yesterday's date in the From and To dates 3 - confirm your checkout is not listed 4 - change your To date to today 5 - confirm your check is listed 6 - apply patch, restart service 7 - repeat step 2 8 - your checkout is there! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27442] Circulation Module Report "Overdues" assumes time of 23:59:00 on upper bound of search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28096] API datatables wrapper does not deal correctly with hidden columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28096 Katrin Fischer changed: What|Removed |Added Attachment #119237|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 119800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119800=edit Bug 28096: Fix table settings for API datatables wrapper Bug 25287 added the table settings to the API datatables wrapper but it does not handled correctly the hidden columns. Test plan: Go to Home > Administration > Table settings Administration > libraries Tick "Is hidden by default" for "library_address" Go to Home > Administration > Libraries Click Columns and check the "Address" column, it must be hidden Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28096] API datatables wrapper does not deal correctly with hidden columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28096 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27465] Add column visibility to the admin/cities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Katrin Fischer changed: What|Removed |Added Attachment #119238|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 119799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119799=edit Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27465] Add column visibility to the admin/cities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Katrin Fischer changed: What|Removed |Added Attachment #119543|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 119798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119798=edit Bug 23195: Always count shipping costs as 'spent' As shipping costs are created when an invoice is created, and creation of an invoice implies that items have been received, the shipment costs are always assumed to be 'spent' This logic is true in GetBudgetSpent/GetBudgetOrdered, however, GetBudgetHierarchy treats open invoices shipping costs as 'ordered' and closed invoice shipping costs as 'spent' This leads to inconsistencies in acqui-home vs spent.pl and ordered.pl To test: 1 - Find a vendor 2 - Click 'Receive shipments' 3 - Create a new invoice with a shipping cost on budget A 4 - Repeate and create a new invoice with a shipping cost on budget B 5 - Close the second invoice 6 - View acquisitions ome 7 - Note budget A includes the shipping under ordered 8 - Note budget B includes the shipping under spent 9 - Click the 'ordered' column on budget A - no shipping is listed on ordered page 10 - Click the spent column on budget A - the shipping is listed here 11 - Apply patch 12 - Both budgets list the shipping as 'spent' 13 - Both 'spent' pages include the shipping 14 - Neither 'ordered' page includes shipping Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Katrin Fischer changed: What|Removed |Added Attachment #119542|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 119797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119797=edit Bug 23195: Unit tests Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 --- Comment #6 from Katrin Fischer --- Pondering this: If I am reading this correctly, than shipping costs will always seen as "spent" immediately, independent of the invoice status. ... and after testing I realize that this is exactly how the costs from the order lines work as well. So this really makes sense. We had to "hunt" down for shipping costs on non-closed invoices in the past, as they remained as 'encumbered' when the budget was closed. So quite happy about this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #73 from Katrin Fischer --- Do we see a chance for this in 21.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable to parse OpacHiddenItems syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28125 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27662 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable to parse OpacHiddenItems syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662 --- Comment #20 from Katrin Fischer --- I wonder if this could be similar to bug 28125? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27635] Add option for patron to view archived suggestions on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27635 --- Comment #5 from Katrin Fischer --- > Where in the process would this become an issue? As far as I can tell, once > a suggestion is placed in a basket the information is retained, even after > the suggestion is deleted. It might cause questions on why something was ordered in the first place. Or: If it was removed after accepting, but before ordering, it will just be gone. Same goes for suggestions that might have been placed in custom status, waiting for review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- (In reply to Henry Bolshaw from comment #7) > Hi Lucas and Owen, does this need signing off again? Have the issues Lucas > raised been fixed by the follow-ups? > > "Owen, I signed off on this one too hastily. There is still one , > .results_summary .type that should be a > > Also, the display is now altered as each of the elements > 'results_material_type', 'results_format', 'results_contents_literary' now > displaying block instead of displaying inline" I think these sound like good catches - setting FQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28146] admin variable should be replaced by KohaAdminEmailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 --- Comment #1 from Katrin Fischer --- Please also prefer ReplyToDefault here with a fallback to KohaAdminEmailAddress. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27986] Information about setting the CSV profile should be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27986 Katrin Fischer changed: What|Removed |Added Summary|Information about setting |Information about setting |the csv profile should be |the CSV profile should be |updated |updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27970] Koha::Template::Plugin::Branches->pickup_location is failing due to unexpected behavior of Koha::Libraries->new->empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27970 Katrin Fischer changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27934] Table sorting using title-string option is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 --- Comment #12 from Katrin Fischer --- (In reply to Fridolin Somers from comment #11) > Recent push : > Bug 27926: Add 'title-string' for dates on circ-patron-results > > Does it need to be patched ? That already had a follow-up to fix it :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27924] Display number of holds awaiting pickup on check out screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27924 --- Comment #3 from Katrin Fischer --- Hi Barbara, this looks a bit different than I expected (maybe some clever local CSS?) Which page are we looking at on your screenshot? Is this the checkouts tab on the patron account in staff? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26989] Ensure no CR occurs in an EDIFACT Order message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26989 Katrin Fischer changed: What|Removed |Added Summary|Ensure no CR occurs in an |Ensure no CR occurs in an |Edifact Order message |EDIFACT Order message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28028] Remove broken fix_onloan.pl maintenance script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028 --- Comment #13 from Katrin Fischer --- Totally ok with removing the script, but we need to remember to update bug descriptions when changing direction :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28028] Remove broken fix_onloan.pl maintenance script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028 Katrin Fischer changed: What|Removed |Added Text to go in the||This script is removed from release notes||the codebase, as it was ||non-functional for a long ||time which also suggests ||that it wasn't used. Summary|fix_onloan.pl broken by bug |Remove broken fix_onloan.pl |23463 |maintenance script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086 Katrin Fischer changed: What|Removed |Added Version(s)||With this change the email released in||address configured in the ||ReplyToDefault will display ||on the OPAC maintenance ||page if set. If not set, ||the email address ||configured in ||KohaAdminEmailAddress will ||be used as before. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
--- Comment #7 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #6)
> Hum, pondering. Why the OPAC maintenance only?
>
> Why not this one as well for instance?
> Koha/Patron/Password/Recovery.pm:my $kohaEmail = $library->branchemail
> || C4::Context->preference('KohaAdminEmailAddress'); # send from patron's
> branch or Koha Admin
Yes please, if we have missed other cases, we should do them too. But I
recommend not fixing them all in the same bug to keep things moving.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28098] Allow for editing public parameter for Upload tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28098 --- Comment #4 from Katrin Fischer --- (In reply to Eugene Espinoza from comment #3) > Hi! Not sure why three bug reports were reported for this? Was it because of > the upgradation done > http://koha.1045719.n5.nabble.com/Upgrading-bugzilla-server-td6139675.html? I believe that would be the wrong date. Maybe there was a delay and the form was sent multiple times? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28132] Remove "this" from button descriptions on basket and basket group pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28132 Katrin Fischer changed: What|Removed |Added Keywords|Academy |Manual Summary|Remove "this" from button |Remove "this" from button |descriptions on basket |descriptions on basket and |summary page|basket group pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Katrin Fischer changed: What|Removed |Added Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Katrin Fischer changed: What|Removed |Added Severity|minor |normal Status|REOPENED|NEW --- Comment #6 from Katrin Fischer --- I can replicate it now: 1) Use a CCL term in the first search option on advanced search page. kw:the 2) Check itemtype: Books 3) Search 4) Limit on available items 5) Page to second page, availability limit appears unchecked left, but still visibile in breadcrumb 6) Page next - now it's lost from the breadcrumb as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #170 from Katrin Fischer --- Can we please have a rebase? Apply? [(y)es, (n)o, (i)nteractive] < Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22544: Move get_opac_new to Koha namespace Applying: Bug 22544: Move get_opac_news to Koha namespace Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #15 from Katrin Fischer --- I've turned this into a patch file, but haven't tested it. Please try it out! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #14 from Katrin Fischer --- Created attachment 119796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119796=edit Bug 22371: Add MARC21 cataloguing plugin to generate Cutter-Sanborn To associate the plugin with the cutter field, you must set the 'cutter.pl' plugin in your MARC framework. this can be done through the following steps: 1. Navigate to More > Administration > MARC bibliographic framework; 2. On the framework which you want to use de plugin, click on Action > MARC Structure; 3. On the field to be associated with the plugin, click on Actions > Subfields; 4. Select the tab corresponding to the cutter subfield; 5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin" dropdown menu, and save changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22070 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20529 --- Comment #3 from Katrin Fischer --- Could this be somehow related to the discussion on bug 20529? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Text to go in the||This adds the description release notes||of the withdrawn status to ||the message that is ||displayed when a withdrawn ||item is returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Attachment #117914|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 119795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119795=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Text changed in order to look maximum like in checkout : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b7a82b21671f266dbf32e2d41a0/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt#L368 Uses class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item has been withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item has been withdrawn' Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Attachment #117913|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 119794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119794=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18170] Show damaged status on check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27038] Error when viewing a course reserve that has one or more items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27038 Bug 27038 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Bug 26819 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Bug 22352 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Bug 21883 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28155] Guided report save goes to 403
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28155 --- Comment #2 from Katrin Fischer --- On master this works ok for me, but there might be a version difference or some difference we haven't figured out yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28155] Guided report save goes to 403
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28155 --- Comment #1 from Katrin Fischer --- Hi Kim, thx for reporting. Could you add a bit more detail? Are you creating a new guided report when this occurs? What is your exact Koha version? This can be found on the first tab of the About page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28148] JavaScript error when printing transfer slip for existing transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Katrin Fischer changed: What|Removed |Added Summary|js error when printing |JavaScript error when |transfer slip for existing |printing transfer slip for |transfer|existing transfer --- Comment #5 from Katrin Fischer --- It looks like we have a sign-off from Owen now too - Martin, do you want to add your line again counting for QA? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21818] Don't use AutoCommit flag in stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818 --- Comment #5 from Katrin Fischer --- I've done regresssion testing on the GUI side here: - Exported records - Staged them using the biblionumber rule - Verified they matched - Imported into catalog - Undid import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21818] Don't use AutoCommit flag in stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818 Katrin Fischer changed: What|Removed |Added Attachment #118109|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 119793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119793=edit Bug 21818: Replace AutoCommit flag with DBIx transaction in stage-marc-import.pl Like it was done in Bug 18806. Test plan : Use stage-marc-import.pl with and without patch, with a matcher to find duplicates Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21818] Don't use AutoCommit flag in stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Katrin Fischer changed: What|Removed |Added Text to go in the||This adds a new release notes||configuration option to the ||itemtype administration ||page: Automatic checkin. ||With automatic checkin ||enabled the item will be ||automatically checked in at ||its due date. ||In order for ||this feature to work ||correctly, the ||automatic_checkin.pl ||cronjob needs to be set up ||on your installation. Keywords||Manual, ||release-notes-needed --- Comment #26 from Katrin Fischer --- Happy to see this in PQA, trying to provide the release notes note. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21549] Lock expired patron accounts after x days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed|Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21549] Lock expired patron accounts after x days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549 Katrin Fischer changed: What|Removed |Added Summary|Lock expired patron |Lock expired patron |accounts|accounts after x days -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21549] Lock expired patron accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549 Katrin Fischer changed: What|Removed |Added Text to go in the|This report adds pref |This report adds pref release notes|LockExpiredDelay. When you |LockExpiredDelay. When you |enter a value there, the|enter a value there, the |cleanupdatabase cron job|cleanup_database.pl cron |will lock the accounts of |job will lock the accounts |patrons that expired at |of patrons that expired at |least the specified number |least the specified number |of days. |of days. |This follows the|This follows the |same pattern as existing|same pattern as existing |code that already allows|code that already allows |you to anonymize or delete |you to anonymize or delete |locked patrons. |locked patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --- Comment #13 from Katrin Fischer --- I assume we should add something to the release notes about this as it might be a breaking change for some customizations? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Text to go in the||This patch adds a new release notes||system preference ||casServerUrl, that will ||allow Koha to work ||correctly with different ||CAS protocol versions. In ||this case it fixes a ||problem that arose by ||changing the name of a ||parameter in the logout ||request between CAS 2 and 3 ||that broke the redirect ||after successful logout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #15 from Katrin Fischer --- Created attachment 119792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119792=edit Bug 20854: (QA follow-up) Rephrase of the new casServerVersion pref description For another related change, see: https://en.wikipedia.org/wiki/Central_Authentication_Service CAS = Central Authentication Service Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Attachment #118349|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 119791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119791=edit Bug 20854: (QA follow-up) Improve readability The logout_cas method does too little tasks. In this case, I consider we should not split it into a separate method. As the CAS implementation lacked tests, it made sense to do it like this, so it is testable. But now we have higher-level tests for logout_cas, we can bake the behavior inside of it, and it is testable. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Attachment #118348|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 119790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119790=edit Bug 20854: Add more CAS tests This patch aims to add full test coverage for 'logout_cas' the way we do it nowadays (in a subtest, mocking things, etc). It is provided as a separate patch so we can test the follow-up tidy and see no behavior change. To test: 1. Run: $ kshell k$ prove t/db_dependent/Auth_with_cas.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Apply the refactoring follow-up 5. Repeat 3 => SUCCESS: Tests still pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Attachment #118347|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 119789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119789=edit Bug 20854: Allow correct redirect on logout for Cas servers 3.0 and superior. Test plan: 1) Apply the patch 2) Set the system preference casLogout to "Yes" 3) Set the new system preference CasServerVersion to "CAS 3 or superior" 4) Check that you are redirected to Koha after a CAS logout from a CAS 3 server 5) Set the new system preference CasServerVersion to "CAS 2 or inferior" 6) Check that you are redirected to Koha after a CAS logout from a CAS 2 server Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854
--- Comment #11 from Katrin Fischer ---
For comparison, this is the change we have been using in production for years
now:
-print $query->redirect( $cas->logout_url(url => $uri));
+my $logout_url = $cas->logout_url(url => $uri);
+$logout_url =~ s/url/service/;
+print $query->redirect( $logout_url );
This is from the patch:
+my $logout_url = $cas->logout_url( url => $uri );
+$logout_url =~ s/url=/service=/
+ if C4::Context->preference('casServerVersion') eq '3';
+
+print $query->redirect($logout_url);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #20 from Katrin Fischer --- The patch needs a major rebase, since we since moved some things around like changing the way we do the translations on this script. But the problem remains. I tested with: a "test" The link back to the results turns it into a search for: a ++<<< HEAD +var searchURL = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(current_search.query) + '=' + decodeURIComponent(current_search.limit) + '_by=' + current_search.sort + '=' + me.searchid + '=' + me.offset; ++=== + var searchURL = '/cgi-bin/koha/catalogue/search.pl?' + current_search.query + '=' + decodeURIComponent(current_search.limit) + '=' + current_search.sort + '=' + me.searchid + '=' + me.offset; ++>>> Bug 20529: Fix "Return to results" link broken by a double quote -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
