[Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705

--- Comment #3 from David Nind  ---
I changed the assignee to Caroline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16551] Display the name of lists to the search results at the OPAC

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||29621


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621
[Bug 29621] Add link for Lists on opac-detail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||16551
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551
[Bug 16551] Display the name of lists to the search results at the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
Hi Caroline.

I'm not seeing copyrightdate in steps 6 and 7.

The database query I used was (where XXX = the newly created record number):
select * from biblioitems where biblionumber = XXX;

Both mappings for biblio.copyrightdate appear in  Koha to MARC mappings.

Note: For step 5 I'm assuming biblioitems.publishercode should be
biblio.copyrightdate.

David

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29638] Framework default value for year is not <> but is <>

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #1 from Fridolin Somers  ---
The manual is managed in GitLab https://gitlab.com/koha-community/koha-manual.

I've opened a new issue with your text :
https://gitlab.com/koha-community/koha-manual/-/issues/27

Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

--- Comment #4 from David Nind  ---
I also changed the assignee for the bug to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

--- Comment #4 from David Nind  ---
I also changed the assignee for the bug to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634

--- Comment #3 from David Nind  ---
I also changed the assignee for the bug to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #1 from Fridolin Somers  ---
I like the idea

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26051] Elasticsearch uses the wrong field for callnumber sorting

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||29632


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632
[Bug 29632] Callnumber sorting is incorrect in Elasticsearch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Depends on||26051


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051
[Bug 26051] Elasticsearch uses the wrong field for callnumber sorting
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634

David Nind  changed:

   What|Removed |Added

  Text to go in the|This updates the default|This updates the default
  release notes|framework to map|Koha to MARC mappings so
   |biblio.medium to 245$h. |that biblio.medium maps to
   ||245$h. The medium field was
   ||added in 19.11 but it was
   ||not linked to 245$h.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Fridolin Somers  ---
Next run whas OK :
https://jenkins.koha-community.org/view/master/job/Koha_Master/1849/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

  Text to go in the|This updates the default|This updates the default
  release notes|framework to map|Koha to MARC mappings so
   |biblioitems.publishercode   |that
   |to 264$b.   |biblioitems.publishercode
   ||maps to 264$b. Currently it
   ||only maps to 260$b,and RDA
   ||uses 264$b.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

--- Comment #3 from David Nind  ---
Testing notes using koha-testing-docker:

1. I had to make 264$a visible in the editor for the default framework

2. Database query for steps 6 and 7 (where XXX = the newly created record
number): select * from biblioitems where biblionumber = XXX;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

David Nind  changed:

   What|Removed |Added

  Text to go in the|This updates the default|This updates the default
  release notes|Koha to MARC mappings so|Koha to MARC mappings so
   |that  biblioitems.place is  |that biblioitems.place maps
   |mapped to 264$a. Currently  |to 264$a. Currently it only
   |it is only mapped to 260$a, |maps to 260$a, and RDA uses
   |and RDA uses 264$a. |264$a.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

David Nind  changed:

   What|Removed |Added

  Text to go in the||This updates the default
  release notes||Koha to MARC mappings so
   ||that  biblioitems.place is
   ||mapped to 264$a. Currently
   ||it is only mapped to 260$a,
   ||and RDA uses 264$a.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

David Nind  changed:

   What|Removed |Added

 Attachment #128184|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 128245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128245=edit
Bug 29626: Map biblioitems.place to 264 by default (MARC21)

This patch adds a mapping from 264 to biblioitems.place.

To test:
1) Apply patch
2) Delete existing frameworks
   -  In the database
  delete from marc_tag_structure;
  delete from marc_subfield_structure;
  delete from biblio_framework;
3) Load default framework
   - In a terminal, run
 ./misc/load_yaml.pl -f
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
--load
4) In the staff interface, go to Administration > MARC bibliographic framework
   - Make sure the default framework is there
5) In Administration > Koha to MARC mapping, check the mappings for
biblioitems.place
   - biblioitems.place should be mapped to 260 as well as 264
6) Create a bibliographic record with a value in 264
   - In the database, check the biblioitems entry for this record, the value
from 264 should be in place
7) Create a bibliographic record with a value un 260
   - In the database, check the biblioitems entry for this record, the value
from 260 should be in place

I hope I didn't forget anything! :)

Caroline

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

Summary|purchase suggestion link on |Purchase suggestion link on
   |staff main page should  |staff main page should
   |always show, even if logged |always show, even if logged
   |in branch has 0 suggestions |in branch has 0 suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

  Text to go in the||This updates the default
  release notes||framework to map
   ||biblioitems.publishercode
   ||to 264$b.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes using koha-testing-docker:

1. Had to make 264$b visible in the editor for the default framework

2. Database query for steps 6 and 7 (where XXX = the newly created record
number): select * from biblioitems where biblionumber = XXX;

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

 Attachment #128185|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 128244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128244=edit
Bug 29627: Map biblioitems.publishercode to 264 by default (MARC21)

This patch adds a mapping from 264 to biblioitems.publishercode.

To test:
1) Apply patch
2) Delete existing frameworks
   -  In the database
  delete from marc_tag_structure;
  delete from marc_subfield_structure;
  delete from biblio_framework;
3) Load default framework
   - In a terminal, run
 ./misc/load_yaml.pl -f
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
--load
4) In the staff interface, go to Administration > MARC bibliographic framework
   - Make sure the default framework is there
5) In Administration > Koha to MARC mapping, check the mappings for
biblioitems.publishercode
   - biblioitems.publishercode should be mapped to 260 as well as 264
6) Create a bibliographic record with a value in 264
   - In the database, check the biblioitems entry for this record, the value
from 264 should be in publishercode
7) Create a bibliographic record with a value un 260
   - In the database, check the biblioitems entry for this record, the value
from 260 should be in publishercode

I hope I didn't forget anything! :)

Caroline

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

--- Comment #5 from David Nind  ---
I wasn't able to replicate the edge case in the follow-up patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

  Text to go in the|This fixes the display of   |This fixes the display of
  release notes|suggestions pending on the  |suggestions pending
   |staff interface home page   |approval section on the
   |will always show, even if   |staff interface home page
   |the current library has no  |so that it always shows,
   |suggestions. For example:   |even if the current library
   |Suggestions pending |has no suggestions. For
   |approval: Centerville: 0 /  |example: Suggestions
   |All libraries: 2|pending approval:
   ||Centerville: 0 / All
   ||libraries: 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the display of
  release notes||suggestions pending on the
   ||staff interface home page
   ||will always show, even if
   ||the current library has no
   ||suggestions. For example:
   ||Suggestions pending
   ||approval: Centerville: 0 /
   ||All libraries: 2
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

 Attachment #128220|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 128243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128243=edit
Bug 29628: (follow-up) fix for rare edge case

When the number of pending suggestions in the currently selected branch
is equal to the number of pending suggestions across all branches, the
`all_pendingsuggestions` template parameter is equal to 0. This results
in the "Suggestions pending approval:" block not being printed at all.

This follow-up patch fixes that.

Also fixed is the display of pending suggestions in Home > Acquisitions.

Test plan:
1) Apply this patch.
2) Create two Library branches; submit two suggestions in each one.
3) Visit the Home page, and also visit Home > Acquisitions: you should
   only see "${BRANCH_CODE}: 2" suggestions pending approval, regardless
   of the branch you have selected using the 'Set library' menu option.
4) Delete both suggestions from the 1st branch, and set your library
   to be the 1st branch.
5) Visit the same pages: this time "${BRANCH_CODE}: 0 / All libraries: 2"
   is displayed.
6) Set your library to be the 2nd branch, and visit the same two pages:
   this time "${BRANCH_CODE}: 2" is displayed.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

 Attachment #128188|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 128242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128242=edit
Bug 29628: Show purchase suggestion link when there are any suggestions
systemwide

To test:
1. Make some purchase suggestions at different branches.
2. Log in to a branch with a suggestion and visit /cgi-bin/koha/mainpage.pl
3. See something like: Suggestions pending approval: Centerville: 1 / All
libraries: 2
4. Log into a branch with no suggestions, no link about suggestions
5. Apply patch
6. Repeat step 2, and still see something like: Centerville: 1 / All libraries:
2
7. Try a branch with no suggestions, now you see a link like: Centerville: 0 /
All libraries: 2

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
  Text to go in the||This updates the default
  release notes||framework to map
   ||biblio.medium to 245$h.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634

David Nind  changed:

   What|Removed |Added

 Attachment #128227|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 128241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128241=edit
Bug 29634: Map biblio.medium to 245 by default (MARC21)

This patch adds a mapping from 245 to biblio.medium.

To test:
1) Apply patch
2) Delete existing frameworks
   -  In the database
  delete from marc_tag_structure;
  delete from marc_subfield_structure;
  delete from biblio_framework;
3) Load default framework
   - In a terminal, run
 ./misc/load_yaml.pl -f
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
--load
4) In the staff interface, go to Administration > MARC bibliographic framework
   - Make sure the default framework is there
5) In Administration > Koha to MARC mapping, check the mappings for
biblio.medium
   - biblio.medium should be mapped to 245
6) Create a bibliographic record with a value in 245
   - In the database, check the biblio entry for this record, the value from
245 should be in medium

I hope I didn't forget anything! :)

Caroline

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes an issue
  release notes||introduced by bug 26352 in
   ||21.11 that caused the
   ||AutoSwitchPatron system
   ||preference to no longer
   ||work. (When
   ||AutoSwitchPatron is enabled
   ||and a patron barcode is
   ||scanned instead of a book,
   ||it automatically redirects
   ||to the patron.)
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

--- Comment #2 from David Nind  ---
Created attachment 128240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128240=edit
Bug 29637: AutoSwitchPatron should look for card number in the barcode

Bug 26352 changed the line in circ/circulation.pl that searches for a
patron card number in the barcode field from using the $barcode variable
to the $findborrower variable.  This breaks AutoSwitchPatron.

Test plan:

1. make sure AutoSwitchPatron system preference is on.
2. get two patron card numbers.
3. enter the first card number to check out to the patron.
4. enter the second card number in the item barcode field.
5. observe that the barcode is not found.

6. apply patch

7. enter the second card number in the item barcode field again.
8. observe that the second patron is loaded to check out to.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26352

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29637

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #37 from David Nind  ---
This no longer seems to work unless I haven't set something up right. I added
an A as a suffix and prefix to Bug 29637 in the patron search. The plugin
installed okay (I used the latest version) and I copied the configuration in.

I was testing Bug 29637 - which indicates this bug broke AutoSwitchPatron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #20 from David Nind  ---
Testing notes and issues identified (using koha-testing-docker):

1. Database query for step 3: update borrowers set dateofbirth = '2004-11-01'
where borrowernumber = 49;

2. Main patch test plan worked as expected.

3. Had issues with some of the tests in the third patch (see details below),
others worked as expected:
   . with no date of birth: doesn't seem to work if age is NULL
   . with invalid age in category having age required: 'Use of uninitialized
value in sprintf...' message
   . with invalid age in category having upper age limit: 'Use of uninitialized
value in sprintf...' message

with no date of birth
~

1. Edited a staff patron (Henry - 34) and removed date of birth
2. Changed the staff patron category (S) so age required = 18-99 years
3. Error message after running (note: dateofbirth is NULL in database):
   => Patron borrowernumber=34 has an invalid age of 104 for their category 'S'
(18-99)
   => This looks wrong to me - with no date of birth I'm not sure how it works
out they 104 years of age
4. If I update in the database so dateofbirth = '' (which becomes -00-00) I
get this message:
   ==> Can't call method "strftime" on an undefined value at
/kohadevbox/koha/Koha/Patron.pm line 1149.

with invalid age in category having age required


1. Edited a patron (Mary Burton - 49) so that age is less than 24.
2. Changed patron category (PT) so age required = 24 and no maximum age.
3. Worked as expected except for 'Use of unitialized value...' message:
   ==> Use of uninitialized value in sprintf at
misc/maintenance/search_for_data_inconsistencies.pl line 256.
 * Patron borrowernumber=49 has an invalid age of 10 for their category
'PT' (24-)
4. If they have the correct age (changed so they were older than 24)

with invalid age in category having upper age limit
~~~

1. Edited a patron (Mary Burton - 49) so that age is more than 50.
2. Changed patron category (PT) so that no age required and upper age limit was
50.
3. Output as expected except for 'Use of uninitialized value in sprintf...'
message:
   ==> Use of uninitialized value in sprintf at
misc/maintenance/search_for_data_inconsistencies.pl line 256.
 * Patron borrowernumber=49 has an invalid age of 71 for their category
'PT' (-50)

with invalid age in category having age required and upper age limit


1. Edited a patron (Mary Burton - 49) so that age is more than 60.
2. Changed patron category (PT) so that age required = 20 and upper age limit =
60.
3. Output as expected:
   ==> * Patron borrowernumber=44 has an invalid age of 70 for their category
'PT' (20-60)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #15 from David Nind  ---
Created attachment 128239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128239=edit
Bug 29605 - Error messages after reset_all

I had a go at testing this, but I get "BEGIN failed--compilation aborted
at" error messages after the reset_all command.

See attachment for the command line log.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes an issue when
  release notes||upgrading from 21.05.x to
   ||21.11 - the uniq_lang
   ||unique key is failing to be
   ||created because several
   ||rows with the same subtag
   ||and type exist in database
   ||table
   ||language_subtag_registry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
I hope I have tested this correctly, as I often have problems with KTD and
changing to previous versions rather than master.

In this case, for step 1 of the test plan I checked out v21.05.07.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

David Nind  changed:

   What|Removed |Added

 Attachment #128214|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 128238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128238=edit
Bug 29631: Prevent uniq_lang creation to fail

We got 2 reports of this problem in the last 24h, uniq_lang unique key is
failing to be created because several rows with the same (subtag, type) exist
in DB.

I have no idea how this is possible, but apparently it is.

Test plan:
Checkout a commit before 21.06.00.012
reset_all
Create duplicate in language_subtag_registry
> insert into language_subtag_registry(subtag, type, description) values('IN', 
> 'region', 'India');
Checkout master+this patch, updatedatabase
=> Only 1 IN-region exists in the DB, the last one.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552

--- Comment #5 from David Nind  ---
I had a go at testing but came across some issues (or I don't understand how to
test this...).

Testing notes using koha-testing-docker:

1. Update the CSS (yarn install, yarn build, yarn build --view opac,
flush_memcached, restart_all)

2. Examples of where yesterday, today and tomorrow should not be active:
   . Place a hold for: for 'Hold expires on date:' yesterday and today should
not be active [see potential issue [1]]
   . Circulation > Overdue report: in the filter make the from date in the
future, Yesterday, Today and Tomorrow should all be not active, but are active
even though they don't work
   . Struggled to find examples of when Tomorrow should not be selectable

Potential issues noted - mainly with Yesterday, Today and Tomorrow not showing
as inactive when they should be:
1. When placing a hold you can't enter today's date but 'Today' is still active
2. Same for Circulation > Renew
3. Administration > Patron categories > New category - Yesterday and Today are
still active, even though you can't enter a date
4. Reports > Patrons: the "Date of birth" fields are linked so that to cannot
be before from dates, if you add a date in the from taht is a few days in the
future tehy should all be inactive, but aren't

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #9 from Phil Ringnalda  ---
Alphabetically-first is also used for bib-level holds in the case where either
the logged-in library isn't a valid pickup location at all, or is not a valid
pickup location for any of the items.

Should we also change that to blank, guessing without having yet had feedback
from people using local hold groups that alphabetically-first is a bad idea, or
should we take this patch to restore the previous behavior for people who do
not use local hold groups while retaining consistent behavior between bib-level
and item-level for people who do use them, and then find out from feedback
whether alphabetically-first for people who do use them is worse than blank?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29639] OPAC cart and staff cart are not consistent

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29639] New: OPAC cart and staff cart are not consistent

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639

Bug ID: 29639
   Summary: OPAC cart and staff cart are not consistent
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you add items to your cart on the OPAC and go to view them you'll see these
columns:

Title   
Author  
Year
Location (Status)


If you look in the staff client:


Title
Item type
Items

I would be neat if these were more consistent.  And perhaps also column
configurable?


Lucas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273

Fridolin Somers  changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply

--- Comment #6 from Fridolin Somers  ---
Needs an easy rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #110998|0   |1
is obsolete||

--- Comment #19 from Fridolin Somers  ---
Created attachment 128237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128237=edit
Bug 26311: (follow-up) loop through the patron with date of birth and in
categories having age limits

Also added category limits in message, for example (12-18)

Check patron :
- with no date of birth
- with invalid age in category having age required
- with invalid age in category having upper age limit
- with invalid age in category having age required and upper age limit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #110131|0   |1
is obsolete||

--- Comment #18 from Fridolin Somers  ---
Created attachment 128236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128236=edit
Bug 26311: (QA follow-up) Rephrase output message

This is a suggestion for rephrasing the message slightly:

Before:
* Patron borrowernumber=15 in category 'J' has invalid age '56'

After:
* Patron borrowernumber=37 has an invalid age of 37 for their category 'K'

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #110130|0   |1
is obsolete||

--- Comment #17 from Fridolin Somers  ---
Created attachment 128235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128235=edit
Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl

Patron categories may have age limits.
Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of
patrons which age is invalid regarding there category.

Test plan :
1) Create an adult patron category limited to 18-99 years
2) Create a patron in the category
3) Edit in database its date of birth so that he is 17 years old
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> You see the patron

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin Somers  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

--- Comment #25 from Fridolin Somers  ---
Solved by Bug 22417 for example items edition Bug 28445

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

--- Comment #9 from Andrew Fuerste-Henry  ---
I also confirmed the errors Esther mentioned were present without the patch and
fixed with it.
Thanks, Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #128229|0   |1
is obsolete||

--- Comment #8 from Andrew Fuerste-Henry  ---
Created attachment 128234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128234=edit
Bug 27801: Fix javascript price calculations

This patch ensures we're formatting the price values consistently for
the table total and the amount to pay input field.

Test plan
1) Add an item to charge at 0.10.
2) Add this same item 8 or 9 times (Do not use the 'quantity')
3) Note that the table total and the 'Amount paid' values do not match
4) Apply the patch and repeat the above steps.. the values should now
   match.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #16 from Andrew Fuerste-Henry  ---
I like Jonathan's patch here, it does what libraries have indicated they want.
Though I agree that on initial page load all dropdowns (the overall dropdown at
the top and the individual dropdowns on each title) should default to the
logged in branch if that's a valid pickup location.

But if the logged-in branch is not a valid pickup location for one of the
titles, then that title's dropdown should be blank to start and require one to
select a valid pickup location before the form can be submitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #8 from Lucas Gass  ---
Thanks Tomas. 

I am wondering if we should change how this falls back if the pickup location
is not valid. I think it should be:

- Logged-in library
- Holding branch
- Empty/blank

Instead of defaulting to the first choice alphabetically for the 3rd fallback
we should set no value. This seems like it would be a rare occurrence that the
logged in library and the holding branch are not valid pickup locations but if
it does happen I think it can cause confusion. By leaving it empty it forces
librarians to make a decision and I think in this case that is good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28919

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28919
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=28919   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919
[Bug 28919] When placing a multi-hold from results in staff pickup location is
empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |https://bugs.koha-community
   |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi
   |?id=28273   |?id=29349
 Depends on||28273


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273
[Bug 28273] Multi-holds allow invalid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 128233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128233=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Holding branch
- The first valid pickup location the above are not valid

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, the holding branch is
picked, and if not, some of the valid pickup locations is selected (i.e.
there's no empty dropdowns)
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29638] New: Framework default value for year is not <> but is <>

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638

Bug ID: 29638
   Summary: Framework default value for year is not <> but
is <>
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: courtenay.john...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The online manual description of the Framework default value field incorrectly
describes the special values associated with date. It mentions <>,<>,
AND <>. The ones for month and day work, but not the one for year.

This documentation is misleading. After looking at the additem.pl if found out
why the <> did not work. It should be <> which does work as
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Todd Goatley  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

--- Comment #6 from Todd Goatley  ---
We have received requests from libraries asking that this please be fixed as
soon as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

Michael Hafen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

--- Comment #1 from Michael Hafen  ---
Created attachment 128232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128232=edit
Proposed fix

Test plan:

1. make sure AutoSwitchPatron system preference is on.
2. get two patron card numbers.
3. enter the first card number to check out to the patron.
4. enter the second card number in the item barcode field.
5. observe that the barcode is not found.

6. apply patch

7. enter the second card number in the item barcode field again.
8. observe that the second patron is loaded to check out to.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] New: AutoSwitchPatron is broken since Bug 26352

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

Bug ID: 29637
   Summary: AutoSwitchPatron is broken since Bug 26352
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: michael.ha...@washk12.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 26352 changed the line in circ/circulation.pl that searches for a patron
card number in the barcode field from using the $barcode variable to the
$findborrower variable.  This breaks AutoSwitchPatron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Stacey Nix  changed:

   What|Removed |Added

 CC||snix@coastlinelibrarynetwor
   ||k.org

--- Comment #5 from Stacey Nix  ---
We are also a consortium and we need to be able to have item level hold set to
send them to the pickup location chosen by the patron.  It is currently setting
it at the pickup location as the home library and that does not work for us at
all.  Please fix this and set it back the way it was!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Owen Leonard  ---
The OPAC detail page does currently show links to lists, but only to public
lists. I don't think there's any reason why we shouldn't show links to private
lists if the user is logged in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #3 from Andrew Fuerste-Henry  ---
Taking this out of In Discussion. I see a tangible gain in making this change
and no one has stated a reason for objection.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

Erica Rohlfs  changed:

   What|Removed |Added

 CC||erica.roh...@equinoxoli.org
 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

--- Comment #2 from Andrew Fuerste-Henry  ---
(In reply to Owen Leonard from comment #1)
> If we're renaming things let's use "Library" instead of "Branch."

Works for me!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

--- Comment #1 from Owen Leonard  ---
If we're renaming things let's use "Library" instead of "Branch."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #5 from Jonathan Druart  ---
This is just a start! I am willing to work on that (ie. completely remove this
silly subroutine). Just tell me you are ready to test the patches and I will
continue!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #4 from Jonathan Druart  ---
Created attachment 128231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128231=edit
Bug 27272: Remove type=

This is not related to anything known.. was it "itype" at some point?
`git log -p` will tell you that it's there for a looong time already

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #3 from Jonathan Druart  ---
Created attachment 128230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128230=edit
Bug 27272: Remove GetItemsInfo from catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29636] New: System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636

Bug ID: 29636
   Summary: System preferences StaffSearchResultsDisplayBranch and
OpacLocationBranchToDisplay should have parallel names
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The sysprefs StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay
are a paired set, but not constructed such that they easily come up in searches
together.

I suggest we rename OpacLocationBranchToDisplay to
OPACSearchResultsDisplayBranch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128228|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 128229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128229=edit
Bug 27801: Fix javascript price calculations

This patch ensures we're formatting the price values consistently for
the table total and the amount to pay input field.

Test plan
1) Add an item to charge at 0.10.
2) Add this same item 8 or 9 times (Do not use the 'quantity')
3) Note that the table total and the 'Amount paid' values do not match
4) Apply the patch and repeat the above steps.. the values should now
   match.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

--- Comment #6 from Martin Renvoize  ---
Created attachment 128228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128228=edit
Bug 27801: Fix javascript price calculations

This patch ensures we're formatting the price values consistently for
the table total and the amount to pay input field.

Test plan
1) Add an item to charge at 0.10.
2) Add this same item 8 or 9 times (Do not use the 'quantity')
3) Note that the table total and the 'Amount paid' values do not match
4) Apply the patch and repeat the above steps.. the values should now
   match.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29331] Batch edit items.itemlost

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #5 from Andrew Fuerste-Henry  ---
Just to clarify, one is able to use batch modification to add a lost status to
items and to use batch modification to change other values on items that are
lost. But one cannot use batch modification to remove a lost status from items.

I guess it makes sense to prevent items being un-lost in bulk, but if we're
maintaining the current behavior we should actually disable the checkbox in
batch mod. Right now, I can take a bunch of lost items and *tell* batch mod to
un-lose them. Koha claims it will do so and then just doesn't.

If we're preventing an action, we should do so deliberately and clearly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29635] New: Map biblioitems.collectionissn to 490$x by default (MARC21)

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29635

Bug ID: 29635
   Summary: Map biblioitems.collectionissn to 490$x by default
(MARC21)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

This mapping is not as critical in my opinion as some others that are missing,
but while I'm at it, I thought I'd map everything correctly in the default
marc21 framework, I hope that's ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||27801


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
[Bug 27801] Entering multiple lines of an item in Point of Sale can make the
Collect Payment field off
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #7 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #6 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05   |22.05,21.11.01
released in||

--- Comment #10 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part"

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #12 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #10 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #5 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >