[Koha-bugs] [Bug 30962] REST API: Add endpoint /patrons/:patron_id/check_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #3 from David Cook --- (In reply to Tomás Cohen Arazi from comment #2) > How will we prevent abuse for this password-guessing service? Hehe It's not a public/anonymous endpoint. Only an authenticated and authorized user could use it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #33 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30461] Batch authority tool is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED CC||vic...@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 Bug 30486 depends on bug 27253, which changed state. Bug 27253 Summary: borrowers.updated_on cannot be null on fresh install, but can be null with upgrade https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #24 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30531] Search.t needs update for Recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to master|RESOLVED --- Comment #5 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 Bug 29734 depends on bug 30531, which changed state. Bug 30531 Summary: Search.t needs update for Recalls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 --- Comment #13 from Fridolin Somers --- Great thanks. BTW shouldn't there be some space around "->" when there is a parent ? "Translated itemtype A->Translated itemtype B" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- This is still valid and a big blocker for some libraries. Is there any way to get this moving again without a entire rewrite of "sticky due date" & friends ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28701] primary_contact_method not part of the REST API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701 Alexis Ripetti changed: What|Removed |Added CC||alexis.ripe...@inlibro.com --- Comment #3 from Alexis Ripetti --- I tried to test this patch but my master cannot access the API because of modules dependencies. I test this patch in 21.05 and it works. If anyone wants to try, you just need to be connected in the OPAC and to call a endpoint involving patron. Like `/api/v1/patrons`. You may need to check your permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28701] primary_contact_method not part of the REST API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701 --- Comment #2 from Alexis Ripetti --- Created attachment 136124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136124=edit Bug 28701 - Adding primary_contact_method to the REST API spec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #10 from David Nind --- (In reply to Tomás Cohen Arazi from comment #8) > You missed one of the patches to SO I was too quick! Now signed off as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Attachment #136120|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 136123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136123=edit Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=30917 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #8 from Tomás Cohen Arazi --- (In reply to David Nind from comment #6) > Thanks Tomás! > > There are no more occurrences of the git grep queries after the patches are > applied, and the log viewer now works for recalls. > > David You missed one of the patches to SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #7 from Tomás Cohen Arazi --- (In reply to David Nind from comment #6) > Thanks Tomás! > > There are no more occurrences of the git grep queries after the patches are > applied, and the log viewer now works for recalls. > > David David, thanks to you. I also did this: Generated a 'recalls' file: $ cat recalls borrowernumber recalldate biblionumber branchcode cancellationdate recallnotes itemnumber waitingdate expirationdate old item_level_recall and then: $ for i in $(cat ~/recalls) ; do \ git grep "recall\.$i" | grep -v translator; \ git grep "recall\->$i" | grep -v translator; \ done And no more results. Chances are that in some places variables could've been named differently. Hopefully QA didn't allow that :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #6 from David Nind --- Thanks Tomás! There are no more occurrences of the git grep queries after the patches are applied, and the log viewer now works for recalls. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Attachment #136119|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 136122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136122=edit Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Attachment #136118|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 136121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136121=edit Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #2 from Liz Rea --- They've already fixed the exclamation point on bug 28316 :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 136120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136120=edit Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 136119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136119=edit Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 136118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136118=edit Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907 --- Comment #7 from David Nind --- (In reply to David Nind from comment #6) > For me, the log viewer is still exploding (using koha-testing-docker - this > patch is now in master, everything updated) - unless this is a different > cause of the error: Have added bug 30971 for this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30907] Remaining incorrect uses of Koha::Recall->item_level_recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30971 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 David Nind changed: What|Removed |Added Depends on||30971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 [Bug 30971] Recalls - log viewer error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind changed: What|Removed |Added Blocks||29734 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30971] New: Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971
Bug ID: 30971
Summary: Recalls - log viewer error
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
There is an error in the log viewer when displaying the recalls logs on the
screen (exporting to a file works though):
Template process failed: undef error - The method Koha::Recall->biblionumber is
not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55da45a77358)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
385
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
385
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
409
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
18
Template::Provider::__ANON__('Template::Context=HASH(0x55da45d16528)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Templ
.
To replicate:
1. Enable recalls: set UseRecalls system preference to 'Use'.
2. Ensure the RecallsLog system preference is set to 'Log'.
3. Setup recalls circulation and fines rules:
. Recalls allowed (total) = 5
. Recalls per record (count) = 2
. On shelf recalls allowed = 'If any unavailable'
. Recall due date interval (day) = 3
. Recall overdue fine amount = 5
. Recall pickup period (day) = 2
4. Checkout an item to a patron:
- Patron used: Mary Burton (Midway)
- Record used: Programming Perl (biblionumber = 262, one item =
311418, home library = Centerville)
5. Change username/password for a patron and login to the OPAC and place a
recall for the item in step 4.
- Patron used: Henry Acevedo (Midway)
6. View the checkout and details tab for patron used in step 4:
. List of checkouts should display correctly
. Message in the title column for the item with a recall: This item has been
recalled and the due date updated.
7. Go to Tools > Log viewer and press submit (can limit the module to just
Recalls if you wish).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets to place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 --- Comment #3 from Joonas Kylmälä --- Also the commit title should be changed to describe the change, not the issue at hand, so => Disallow placing item-level holds without a pick-up place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets to place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets to place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960
--- Comment #2 from Joonas Kylmälä ---
Comment on attachment 136066
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136066
Bug 30960: Koha lets to place item-level holds without a pick-up place
Review of attachment 136066:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=30960=136066)
-
::: reserve/placerequest.pl
@@ +83,2 @@
>
> +if ( $item_pickup_location || $can_item_be_reserved eq 'OK'
> || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) {
$item_pickup_location shouldn't be here, this lets anyone to place holds,
regardless of the circ rules/override allowability.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #90 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #89) > (In reply to Jonathan Druart from comment #83) > > I missed the other comment anyway, so not ready for PQA. > > Fixed. > > Waiting for Joonas to approve comment 81. All good now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #87 from Victor Grousset/tuxayo --- Rebased. Sorry for the double upload, I lost Fridolin's signoff the 1st time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136107|0 |1 is obsolete|| --- Comment #86 from Victor Grousset/tuxayo --- Created attachment 136117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136117=edit Bug 30733: Split strings differently Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136106|0 |1 is obsolete|| --- Comment #85 from Victor Grousset/tuxayo --- Created attachment 136116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136116=edit Bug 30733: fix url => URL to merge with existing string Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136105|0 |1 is obsolete|| --- Comment #84 from Victor Grousset/tuxayo --- Created attachment 136115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136115=edit Bug 30733: Undo some additions that don't yield good strings They need more complex solutions that would be better in a follow up ticket to not drag this one too long. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136104|0 |1 is obsolete|| --- Comment #83 from Victor Grousset/tuxayo --- Created attachment 136114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136114=edit Bug 30733: Simplify some singular cases To be sure translators don't think it's wrong and translate it plurally. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136103|0 |1 is obsolete|| --- Comment #82 from Victor Grousset/tuxayo --- Created attachment 136113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136113=edit Bug 30733: Undo in an ICS calendar file Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136102|0 |1 is obsolete|| --- Comment #81 from Victor Grousset/tuxayo --- Created attachment 136112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136112=edit Bug 30733: Wrap one more string in Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136101|0 |1 is obsolete|| --- Comment #80 from Victor Grousset/tuxayo --- Created attachment 136111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136111=edit Bug 30733: Undo bad handling of a plural case Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136100|0 |1 is obsolete|| --- Comment #79 from Victor Grousset/tuxayo --- Created attachment 136110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136110=edit Bug 30733: Fix string context lost due to being in two parts Due to conditions. Things like "Edit batch" need to be keept in one strings. Also removed some capitalization because it wasn't needed and wasn't consistend with and which had now capitalization. Also fixed patron edit-batch.tt and edit-layout.tt because they were incomplete in regard to their label counterparts. They had the condition on description and batch_id but weren't displaying anything different between the two cases. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136099|0 |1 is obsolete|| --- Comment #78 from Victor Grousset/tuxayo --- Created attachment 136109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136109=edit Bug 30733: Move all semicolons inside the translatable strings In the 1st patch, sometimes they where left out Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136098|0 |1 is obsolete|| --- Comment #77 from Victor Grousset/tuxayo --- Created attachment 136108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136108=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. And rephrased a string about password reset to have it identical to other strings with the same meaning. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136054|0 |1 is obsolete|| --- Comment #76 from Victor Grousset/tuxayo --- Created attachment 136107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136107=edit Bug 30733: Split strings differently -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136053|0 |1 is obsolete|| --- Comment #75 from Victor Grousset/tuxayo --- Created attachment 136106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136106=edit Bug 30733: fix url => URL to merge with existing string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136052|0 |1 is obsolete|| --- Comment #74 from Victor Grousset/tuxayo --- Created attachment 136105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136105=edit Bug 30733: Undo some additions that don't yield good strings They need more complex solutions that would be better in a follow up ticket to not drag this one too long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136051|0 |1 is obsolete|| --- Comment #73 from Victor Grousset/tuxayo --- Created attachment 136104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136104=edit Bug 30733: Simplify some singular cases To be sure translators don't think it's wrong and translate it plurally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136050|0 |1 is obsolete|| --- Comment #72 from Victor Grousset/tuxayo --- Created attachment 136103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136103=edit Bug 30733: Undo in an ICS calendar file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136049|0 |1 is obsolete|| --- Comment #71 from Victor Grousset/tuxayo --- Created attachment 136102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136102=edit Bug 30733: Wrap one more string in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136048|0 |1 is obsolete|| --- Comment #70 from Victor Grousset/tuxayo --- Created attachment 136101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136101=edit Bug 30733: Undo bad handling of a plural case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136047|0 |1 is obsolete|| --- Comment #69 from Victor Grousset/tuxayo --- Created attachment 136100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136100=edit Bug 30733: Fix string context lost due to being in two parts Due to conditions. Things like "Edit batch" need to be keept in one strings. Also removed some capitalization because it wasn't needed and wasn't consistend with and which had now capitalization. Also fixed patron edit-batch.tt and edit-layout.tt because they were incomplete in regard to their label counterparts. They had the condition on description and batch_id but weren't displaying anything different between the two cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136046|0 |1 is obsolete|| --- Comment #68 from Victor Grousset/tuxayo --- Created attachment 136099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136099=edit Bug 30733: Move all semicolons inside the translatable strings In the 1st patch, sometimes they where left out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136045|0 |1 is obsolete|| --- Comment #67 from Victor Grousset/tuxayo --- Created attachment 136098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136098=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. And rephrased a string about password reset to have it identical to other strings with the same meaning. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30970] holdst columns don't match actual columns in 'Holds waiting'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Sara Brown changed: What|Removed |Added Summary|holdst columns don't match |holdst columns don't match |actual columns |actual columns in 'Holds ||waiting' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30970] New: holdst columns don't match actual columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Bug ID: 30970 Summary: holdst columns don't match actual columns Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: sbr...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The columns selected to hide by default in 'Table settings' for holdst aren't lining up with the actual columns hidden. For example: -In holdst, select columns home_library and current_location to be hidden by default -In the 'Holds waiting' table, see that Patron and Home library are hidden by default. Current location is showing by default. -To hide current_location and home_library by default, I need to select shelving_location and current_location in 'Table settings' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30893] Typo: update_patrons_category.pl fine(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 --- Comment #9 from Owen Leonard --- The patron search stuff has changed enough that I think it's prudent to ask for a new signoff on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30868] Modifying a patron - page not found error after fixing validation errors where the message is displayed at the top of the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What|Removed |Added Attachment #131806|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 136097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136097=edit Bug 29971: Remember selections across patron search pages This patch modifies the patron search results page to enable checkbox selections to be remembered in the browser's localStorage. This allows checkbox selections to persist while navigating through multiple pages of search results or even across multiple different searches. Once selected, these values can be added to a patron list or submitted for merging. Selections can be cleared manually and will be automatically be removed upon logout. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface perform a patron search in the Patrons module which will return multiple pages of results.. - Check checkboxes next to several patrons. - After one checkbox is checked the "Add to patron list" button should be enabled. - After more than one checkbox is checked the "Merge selected patrons" button should be enabled. - A box should appear in the toolbar above the search results, "Patrons selected: X" - Navigate to another page of results. Check more checkboxes. The "Patrons selected" information should be updated. - Return to the first page of results. Your original selections should still be checked. - Test that the correct set of patrons is used when clicking "Merge selected patrons" or when using "Add to patron list." - Click the "Clear" button in the selections information box. Checkboxes should be cleared on every page of results you previously checked. - The "Add to patron list" and "Merge selected patrons" buttons should become disabled. - After making several selections, log out of the staff interface and log back in, returning to the same patron search. Your selections should have been forgotten. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in batch patron modification breaks the form sending
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30886] Recall status cannot be correct on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30885] Recall - detail page explosion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30840] Add support for barcode filters to course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30840 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30968] New: opac-authorites-home.pl still accessible even when OpacAuthorities system preference is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30968 Bug ID: 30968 Summary: opac-authorites-home.pl still accessible even when OpacAuthorities system preference is turned off Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org When the system preference OpacAuthorities is turned off, the page https://your.library.here/cgi-bin/koha/opac-authorities-home.pl is still accessible and likely shouldn't be. To test: set OpacAuthorities to Don't Allow try to visit https://your.library.here/cgi-bin/koha/opac-authorities-home.pl note that the page is still accessible. Thanks for checking it out! Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27700] Patron quick add form is a single fieldset and contains no legend or headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27700 Lucas Gass changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Lucas Gass --- I don't think this is valid. The quick add form should not contain the same legend and fieldsets as the regular form. The purpose of it is to be quick. I am marking this one as resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #30 from Owen Leonard --- (In reply to Kyle M Hall from comment #28) > I think this one will fix that! Looks good, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard changed: What|Removed |Added Attachment #136094|0 |1 is obsolete|| --- Comment #29 from Owen Leonard --- Created attachment 136095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136095=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #66 from Tomás Cohen Arazi --- Please rebase so we can QA and push fast. Thanks, and great work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Tomás Cohen Arazi changed: What|Removed |Added Version|21.05 |master CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30967] New: Add ability to toggle Z39.50 server selection for searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30967 Bug ID: 30967 Summary: Add ability to toggle Z39.50 server selection for searching Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: egpetri...@yahoo.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be nice if one could toggle Z39.50 server selection in z3950_search.pl, so that once the default servers are consulted, one could query the rest of the servers and only those. Curently one has to either manually deselect the servers selected by default, or select all servers/targets, regardless of the performance - load penalty this would entail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Björn Hellberg changed: What|Removed |Added Summary|Record Overlay Rules - |Record Overlay Rules - |Fault in Z39.50 filter |can't use Z39.50 filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30966] New: Record Overlay Rules - Fault in Z39.50 filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Bug ID: 30966 Summary: Record Overlay Rules - Fault in Z39.50 filter Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bjornbibb...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We're setting up MARC Overlay Rules in 21.11.05. When defining the rules, we aren't able to make the filter Z39.50 work. A colleague checked the code and reports that line 876 in cataloguing/addbiblio.pl sets the source to z39.50. The source value should be z3950 to match the filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 Manos PETRIDIS changed: What|Removed |Added CC||egpetri...@yahoo.com --- Comment #5 from Manos PETRIDIS --- It would also be helpful if the entries in the shared Z39.50/SRU servers' list carried information on the libraries' content and/or focus. For example, for libraries following DDC the entry may mention the top 3 Classes, top 10 Divisions, top 30 Sections of each library. Or, 3 top LCC Classes and 30 top subclasses. Perhaps also top 30 Subject headings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27700] Patron quick add form is a single fieldset and contains no legend or headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27700 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #5 from Sally --- I came here to log this bug - the clone of inputs has been giving me a headache this week when trying to target those areas with jQuery, and the non-working datepicker is a real issue for us. I realise it's not an easy fix from what's been said, but just adding a 'still valid' comment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #19 from Owen Leonard --- This is great work, Jonathan, thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #28 from Kyle M Hall --- We are almost there! Owen, I think this one will fix that! (In reply to Owen Leonard from comment #26) > My calendar still thinks things are off by a day. Items due on 2022-06-23 > are still on 2022-06-22. An item due today, 2022-06-15, appears on > 2022-06-14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Attachment #136074|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 136094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136094=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30962] REST API: Add endpoint /patrons/:patron_id/check_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #2 from Tomás Cohen Arazi --- How will we prevent abuse for this password-guessing service? Hehe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947
--- Comment #4 from Nick Clemens ---
Created attachment 136093
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136093=edit
Bug 30947: Simplify CanBookBeIssued date handling
1) This removes support for passing string dates to CanBookBeIssued. The
function didn't publicly even document support for string dates, only
DateTime objects.
2) We get a $duedate always at least from CalcDateDue so having
$issuingimpossible{INVALID_DATE} = output_pref($duedate);
was unneccesary and thus removed.
3) The check "duedate cannot be before now" was needlessly complex: if
the due date really cannot be before now we should check seconds too
and warn the librarian! Thus the truncation to minutes can be dropped
safely.
To test:
1) prove t/db_dependent/Circulation.t
2) prove t/db_dependent/Illrequests.t
3) Enable OnSiteCheckouts and disable SpecifyDueDate syspref. Create
on-site checkout for any patron and verify the due date is your
current date at 23:59, you can check the exact minute with sql:
> select * from issues
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947 Nick Clemens changed: What|Removed |Added Attachment #135959|0 |1 is obsolete|| Attachment #135960|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 136092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136092=edit Bug 30947: Add test for Illrequest checkout with custom due date To test: 1) prove t/db_dependent/Illrequests.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30942] Why can I place a recall on a bib when no items are on loan?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30942 --- Comment #3 from Owen Leonard --- I mention it because I can click on the "Request article" in a page of OPAC search results and get a message, "No article requests can be made for this record." I think that's a good reason to handle it more gracefully for the patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 --- Comment #12 from Nick Clemens --- Created attachment 136091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136091=edit Bug 29454: (follow-up) Cover more test cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What|Removed |Added Attachment #136078|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 136090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136090=edit Bug 29454: Add unit test for Koha::Template::Plugin::ItemTypes Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #18 from Owen Leonard --- Created attachment 136089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136089=edit Bug 30578: Fix multi-terms search Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #17 from Owen Leonard --- Created attachment 136088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136088=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #16 from Owen Leonard --- Created attachment 136087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136087=edit Bug 30578: Fix on-select for 2 occurrences Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #15 from Owen Leonard --- Created attachment 136086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136086=edit Bug 30578: Restore highlighting of patrons from the logged-in library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Attachment #135920|0 |1 is obsolete|| Attachment #136041|0 |1 is obsolete|| Attachment #136042|0 |1 is obsolete|| Attachment #136043|0 |1 is obsolete|| Attachment #136044|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 136085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136085=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #26 from Owen Leonard --- My calendar still thinks things are off by a day. Items due on 2022-06-23 are still on 2022-06-22. An item due today, 2022-06-15, appears on 2022-06-14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #56 from Nick Clemens --- This works and is a relatively small change so signing off. I do think this would be better if it didn't split this control into two places: syspref and itemtype administration. The existing syspref is YAML based, and could be expanded to take itemtypes into account, and would consolidate the feature into a single control. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
