[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #4 from David Cook --- (As a side note: I'd copied the regex for this from the Elasticsearch code, but really we should've written it at as "(\d\d\d)" rather than "(...)".) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #3 from David Cook --- (In reply to Chaminda de Silva from comment #2) > 1. How to findout the URL of the particulaar record. Do you mean how do you determine which record is causing the problem? You'll need to do a SQL Report. You could try something like the following: SELECT biblionumber, ExtractValue(metadata,'//datafield[@tag="880" and subfield[@code="6" and substring(text(),1,3)="24 "]]/*') as f880 from biblio_metadata HAVING f880 <> '' Do you have a public OPAC? If you can provide the URL to that OPAC, I can lookup the records once you've given me a biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #2 from Chaminda de Silva --- (In reply to David Cook from comment #1) > It looks like you've got bad data there in your record. > > Can you share a URL to that record? 1. How to findout the URL of the particulaar record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Status|Needs Signoff |Failed QA
--- Comment #13 from David Nind ---
The tests fail.
Also, I think the format for the follow-up in the bug title is Bug :
(follow-up) ...
prove t/db_dependent/api/v1/holds.t
t/db_dependent/api/v1/holds.t .. 15/16 Use of uninitialized value $rank in
string eq at /kohadevbox/koha/C4/Reserves.pm line 1115.
Use of uninitialized value $rank in pattern match (m//) at
/kohadevbox/koha/C4/Reserves.pm line 1125.
# Failed test 'expiration date changed correctly'
# at t/db_dependent/api/v1/holds.t line 1597.
# got: undef
# expected: '2022-01-01'
# Looks like you failed 1 test of 7.
# Failed test 'PUT /holds/{hold_id}/expiration_date tests'
# at t/db_dependent/api/v1/holds.t line 1600.
# Looks like you failed 1 test of 16.
t/db_dependent/api/v1/holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/16 subtests
Test Summary Report
---
t/db_dependent/api/v1/holds.t (Wstat: 256 Tests: 16 Failed: 1)
Failed test: 16
Non-zero exit status: 1
Files=1, Tests=16, 25 wallclock secs ( 0.07 usr 0.01 sys + 21.83 cusr 1.58
csys = 23.49 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31907] Show items as On hold when in processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes using koha-testing-docker (KTD): 1. Check that SIP is running (should be if using KTD): koha-sip --status kohadev 2. I used item 301310 (biblionumber = 29) from CPL to test, hold placed for pick up at CPL 3. For step 4, command using misc/sip_cli_emulator.pl to return item: misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 301310 4. For step 10, after applying the patch I ran flush_memcached and restart_all Note: I obsoleted comment #2, as it was a patch for another bug incorrectly added to this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #22 from David Cook --- (In reply to Lari Strand from comment #21) > Koha-Suomi SIPoHTTP (SIP2 over HTTPS) communication plugin can be found at: > > https://github.com/KohaSuomi/koha-plugin-SIPoHTTP Cool! I'll certainly keep it in mind for the future. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31907] Show items as On hold when in processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 David Nind changed: What|Removed |Added Attachment #142339|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 142821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142821=edit Bug 31907: Show items as On hold when in processing Test plan: 1. Make sure syspref "opacbookbag" is set to "Allow". 2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill". 3. Place a hold on an item. 4. Return item via SIP at the pickup library. 5. View biblio in Opac. 6. Note that it says "Available" as status. 7. Add biblio to Cart. 8. Open Cart. 9. Note that it says "Available" as status. 10. Apply patch. 11. Reload Opac page. 12. It should now say "On hold". 13. Reload Card page. 14. It should also say "On hold". Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31907] Show items as On hold when in processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32033] Cannot rebuild zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033 --- Comment #1 from David Cook --- It looks like you've got bad data there in your record. Can you share a URL to that record? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #7 from David Nind --- Can't apply the patch: ... Applying: Bug 31627: Add ability to embed the letter id in outgoing email notices error: sha1 information is lacking or useless (C4/Letters.pm). error: could not build fake ancestor Patch failed at 0001 Bug 31627: Add ability to embed the letter id in outgoing email notices .. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #13 from David Nind --- Testing notes (using koha-testing-docker): 1. Enable EDIFACT system preference 2. Creating EDI vendor accounts: Administration > Acquisition parameters > EDI accounts 3. Before applying the patch, I added an EDI vendor account (to test that existing accounts are updated) 3. Step 3 - SQL for report: select * from vendor_edi_accounts 4. Step 4 - after the databaseupdate: I ran flush_memcached and restart_all, and cleared the browser cache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 David Nind changed: What|Removed |Added Attachment #142057|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 142820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142820=edit Bug 30649: Vendor EDI account passwords should be encrypted in the database We are storing edi vendor acccount passwords in clear text in the database. Now that Koha has the Koha::Encryption module, we should use that to encrypt passwords for all existing and new EDI accounts. Test Plan: 1) Apply this patch 2) Create one or more EDI vendor accounts 3) Run a report to view the account passwords, note they are in clear text 4) Run updatedatabase.pl 5) Re-run the report, account passwords should be encrypted now 6) Edit a vendor EDI account, note you can still view and update the password for an account Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I'm not sure how to do step 2 - happy to test if you can show how to do that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi changed: What|Removed |Added URL||https://gitlab.com/thekesol ||utions/Koha/-/commits/oauth ||_client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Sorry, ending up with some questions here: 0) Terminology I have several terminology issues here in the GUI, but also in the code, we are still horribly inconsistent all over. returned = checked in issue = checkout Please update at least the note on the form and use . for ending sentences :) What statuses would remain untouched? It's used several times as an explanation, but I am not sure what is meant actually. 1) I assume we skip here, because they will be re-indexed when the job is processed later on? + skip_record_index => 1, + skip_holds_queue => 1, If we don't update the index, the item would still show as checked out in the result list. 2) Options on the form are misaligned in the form in the new staff interface design. 3) Why the empty setting? Wouldn't it make sense to preset to 'No'? 4) You said this is to allow the library to delete the item. "Eventually, after the patron has paid, or after some time, the library may wish to delete the item. When doing so, they do not wish to check the item in and affect any statuses" Why not add this option to the item batch delete form then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What|Removed |Added Keywords||rel_22_11_candidate Status|Passed QA |Failed QA --- Comment #31 from Katrin Fischer --- Oh no... I found an issue :( You remove the itemnumber, which would have been enough on old versions, but now we also need to change reserves.item_level_hold Should be an easy fix - please follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #30 from Katrin Fischer --- I was starting to doubt myself, but this patch broke my evil "FQA" streak. Thanks Lari, I think the discussion resulted in a nice clean GUI here! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What|Removed |Added Attachment #142596|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 142819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142819=edit Bug 31692: Allow librarians to change hold type in staff client To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What|Removed |Added Attachment #142595|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 142818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142818=edit Bug 31692: Add Koha::Hold::change_type and unit tests To test: 1. prove t/db_dependent/Koha/Hold.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
--- Comment #128 from Katrin Fischer ---
3) POD and use of GetMarcItemFieldsToOrderValues don't match up (first param):
+my $data = GetMarcItemFieldsToOrderValues('MarcItemFieldsToOrder',
$marcrecord, ['homebranch', 'holdingbranch', 'itype', 'nonpublic_note',
'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price',
'replacementprice', 'itemcallnumber', 'quantity', 'budget_code']);
my $alliteminfos = Koha::Acquisition::Utils::GetMarcItemFieldsToOrderValues(
$marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note',
'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price',
'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] );
4) +use C4::Suggestions;# GetSuggestion
Should list all used methods explicitly.
Further testing might also be blocked by bug 32045. :(
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What|Removed |Added Blocks||32046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 [Bug 32046] When adding a new records from a staged files, there are style issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32046] New: When adding a new records from a staged files, there are style issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046 Bug ID: 32046 Summary: When adding a new records from a staged files, there are style issues Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id =2=1=1 OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 30952 To test: * Create order * Stage file of MARC records * Order from staged file * Select file -> now you are on the right page listing records Found issues: - Toolbar has a shadow and background color? - Labels and pulldowns/checkboxes are misaligned - Item form layout on Item tab is broken! - counting information tab: Statistics fields are misaligned - can't save due to JS erorr, filed separately as: bug 32045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32045] New: Cannot order mulitple from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Bug ID: 32045 Summary: Cannot order mulitple from staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To test: * Create order * Stage file of MARC records * Order from staged file * Select file * Select one or more records for ordering using the checkbox * Set the fund on the Accounting page * Save Nothing happens, there is JavaScript error in the console: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31327] Can we add color scheme picker to the OPAC.. especially a 'dark mode'?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327 Martin Renvoize changed: What|Removed |Added Change sponsored?|--- |Seeking sponsor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #127 from Katrin Fischer --- I know it's hard to keep on top of bugs with many comments, but 2 issues found here: 1) Method names are not snake case (see comment84, comment#104) 2) I still don't know what to do here in order to test this (see comment#104) The test plan assumes you know a lot of things about the process already. Maybe a test record with 9xx could be supplied? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #176 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #175)
> Sorry Kyle, I tried to understand what's going wrong here, but failed:
>
> When opening 'Holds to pull':
>
> Can't call method "id" on an undefined value at
> /kohadevbox/koha/circ/pendingreserves.pl line 288
>
> 287: if ( $res_info->item_group ) {
> 288:$hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> $_->item_group->id == $res_info->item_group_id ? $_->barcode : () } @$items
> ];
> 289: }
>
> If you can fix quickly, I'll retest.
*ping*?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #21 from Katrin Fischer ---
1) QA test tools:
OK Koha/Item/Template.pm
FAIL Koha/Item/Templates.pm
FAIL pod
*** WARNING: =head3 without preceding higher level in file
Koha/Item/Templates.pm
*** WARNING: =head3 without preceding higher level in file
Koha/Item/Templates.pm
*** WARNING: =head3 without preceding higher level in file
Koha/Item/Templates.pm
OK Koha/Schema/Result/Borrower.pm
FAIL Koha/Schema/Result/ItemEditorTemplate.pm
FAIL pod coverage
POD is missing for koha_object_class
POD is missing for koha_objects_class
OK cataloguing/additem.pl
OK installer/data/mysql/atomicupdate/bug_24606.pl
FAIL installer/data/mysql/kohastructure.sql
FAIL tinyint_has_boolean_flag
The new column item_editor_templates.is_shared is using
TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/ItemEditorTemplate.pm), see the SQL12 coding guideline
OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
OK koha-tmpl/intranet-tmpl/prog/en/includes/str/cataloging_additem.inc
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
FAIL filters
missing_filter at line 275 ([%
t.name | html %][% IF t.is_shared %] (shared)[% END %])
2) Why the sub in cataloguing/additem.pl instead of a module?
+sub get_item_from_template
3) New cookie alert!
ItemEditorSessionTemplateId
If this gets pushed, please don't forget updating
https://wiki.koha-community.org/wiki/Use_of_Cookies.
4) Translatability
You used the old style here, which is no longer necessary:
+alert(MSG_TEMPLATE_NAME_REQUIRED);
You can just put the message into the .js using the double-underscore: __("")
Not a blocker for me, as it looks like the other messages on this template
haven't been moved yet, but not opposed to a fix either :)
5) The GUI doesn't work well with the new staff interface design. The elements
don't align nicely (especialy the save template one is jumping up and down a
lot with the elements) and we are missing padding. I believe we should not push
without having this sorted or on the way to be sorted. - We want to advertise
and document this feature and then it should look nice!
5) When using "Add multiple items" all other buttons disappear, but the "Save
as template" remains. Should this also be hidden?
6) 'Delete template' is greyed out, when no template is selected, but 'Apply
template' is always active. Should we make 'Apply template' also depend on
having a template selected first?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- (In reply to Katrin Fischer from comment #18) > (In reply to Nick Clemens from comment #17) > > After applying my console has an error: > > Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455 > > I tested on Tools > Calendar. In Firefox I have the same error. In Chromium > I see: > > dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of > undefined (reading '$i') I am sorry, the issue remains for me. Applied patches, restart_all. Tested in a private tab also. Firefox: Uncaught TypeError: t is undefined Chromium: dayjs.min_22.0600075.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '$i') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #23 from Katrin Fischer --- Created attachment 142817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142817=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Adds missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #142396|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 142816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142816=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #142395|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 142815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142815=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #142394|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 142814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142814=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- Hi David, 1) QA scipt Please run the QA tests on your patches before submitting, they are catching lots of the tiny stuff that can otherwise hold things up unnecessarily. If you are using ktd for development, you can just run: qa -v 2 from kshell. OK C4/Circulation.pm FAIL Koha/Patron.pm FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). FAIL pod coverage POD is missing for has_debarring_overdues POD is missing for trim_whitespaces FAIL installer/data/mysql/atomicupdate/bug_29145-modify_AutoRemoveOverduesRestrictions-syspref.pl FAIL file permissions File must have the exec flag FAIL spelling prefernce ==> preference OK installer/data/mysql/atomicupdate/odue-debarment-removal-allow-unrestricted.pl OK installer/data/mysql/mandatory/sysprefs.sql OK misc/cronjobs/overdue_notices.pl FAIL t/db_dependent/Circulation/MarkIssueReturned.t FAIL spelling remaning ==> remaining remaning ==> remaining I am providing a follow-up for the typos, but I'll need you to have a look at the missing POD for has_overdues (trim_whitespace is a false one) and especially the Perlcritic violation. I see that you have written a long comment on has_overdues, so this is about reformatting this into a proper POD entry. 2) Bug number was missing from database update. Fixed together with the typos in a follow-up patch. 3) Changes to Patron.pm We don't have a hard rule here yet, but we should always avoid using SQL. I am not sure if this qualifies as blocker right now as we don't have a written rule, so leaving as a note. Please fix 1)! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #36 from Katrin Fischer --- (In reply to Katrin Fischer from comment #35) > When I tested an earlier version of the updated wiki, I fell in love with > the category editor. I see no way to edit/fix the categories on the pages > now. Ok, maybe just the optics changed a little? you need to edit the page in order to get to it. Will experiment more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 Katrin Fischer changed: What|Removed |Added Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #35 from Katrin Fischer --- When I tested an earlier version of the updated wiki, I fell in love with the category editor. I see no way to edit/fix the categories on the pages now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- This looks pretty good and happy to see this tackled, but I have some comments: 1) This copies an old mistake we made in the beginning by using $a and $t for the title search. This often won't work. We need to split these up ti=t and au=a, like we have done now for 773 and should also correct in other templates: /cgi-bin/koha/catalogue/search.pl?q=ti,phr: 2) We should add this to OPAC and staff interface at the same time. 3) 580 is an issue. a) There can be mulitple 580 and you only display the first. b) It might belong to a totally different 7xx linking field, creating a false display. https://www.loc.gov/marc/bibliographic/bd580.html Description of the complex relationship between the item described in the record and other items that cannot be adequately generated from the linking entry fields 760-787. I am not sure how this is supposed to be done... show only if it actually directly preceeds the first 787 we are looking at here? (is this even possible?) Show the 580 separately? Leave it off for now and deal with it later? 3) I believe there was some change to the separators between fields in OPAC at least sometime ago, or maybe it got stuck? I was not able to find the bug :( I know in our records there are often a lot of 787 so we changed it to a list with separate lines for each entry. A class for the separator would help a lot here. In patch: + + +; + In other instances in the XSLT file: | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 Katrin Fischer changed: What|Removed |Added Severity|minor |normal --- Comment #3 from Katrin Fischer --- Found another 'no border' inside staff client: Edit subfields when editing a MARC framework. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #73 from Katrin Fischer --- I am sorry :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31095: (follow-up) Iterate debarments in batch mod error: sha1 information is lacking or useless (tools/modborrowers.pl). error: could not build fake ancestor Patch failed at 0001 Bug 31095: (follow-up) Iterate debarments in batch mod hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-31095-follow-up-Iterate-debarments-in-batch-mo-J4_1zl.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #112 from Katrin Fischer --- (In reply to Koha Team University Lyon 3 from comment #111) > Hi, > great! There is a nice display ! > > Just a question: this enhancement seems to be only MARC21 compliant? In > unimarc, there are two fields in the authorities format that could be used > at my opinion : 017 > (https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/ > AUTHORITIES/a_017_new2017.pdf) or 033 > (https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/ > AUTHORITIES/3_u-a_033.pdf) > > In fact, I think it could be settable because in France we use often PPN > that idref identifier that is most of the time in a 003 field. > > Thanks, Sonia Hi Sonia, I believe you are right, at the moment this is UNIMARC only. In MARC21 there is 024 used with different sources in $2 that are looked at here for the different identifieres. Maybe you could file a new bug an detail how this could work for UNIMARC? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #90 from Katrin Fischer --- The branch doesn't seem to be linked, can you please remind us where to find the updated patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer changed: What|Removed |Added Attachment #142787|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 142813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142813=edit Bug 31974: (follow-up) Correct some other specificity issues This follow-up makes a couple other minor corrections to label alignment. This allows for correct top-alignment of labels in forms but lets labels in other contexts, especially checkbox or radio button labels, to be aligned "middle." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer changed: What|Removed |Added Attachment #142717|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 142812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142812=edit Bug 31974: Regression: Bug 31813 incorrectly affected labels in the header search This patch adds a specific white-space property to header search labels so that they do not wrap. The change made by Bug 31813 overrode the white-space property incorrectly. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration. - The header search label "Search system preferences" should appear on one line. - Check that labels still wrap correctly on pages like the patron edit screen and the staged MARC record detail view. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 --- Comment #8 from Katrin Fischer --- Very happy to see this fixed, I found it kinda upsetting :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31919] Hovered items in "More" should change background color
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #7 from Katrin Fischer --- I like that this makes it easier visible what you have selected. Love it on the pull downs, not completely sure about the menu items. But I think it's better than the underline that is not as visible by far. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31943] Date inputs wider than other inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943 --- Comment #8 from Katrin Fischer --- I can confirm that the calendar icons stays using yarn build, signing off. Jonathan, do you want to give it another go? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31943] Date inputs wider than other inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943
Katrin Fischer changed:
What|Removed |Added
Attachment #142723|0 |1
is obsolete||
--- Comment #7 from Katrin Fischer ---
Created attachment 142811
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142811=edit
Bug 31943: Date inputs wider than other inputs
This patch sets a width on Flatpickr instances so that they better match
the typical width of a text input field.
The patch also corrects the "X" ("clear date") link color to return it
to the original red color. In doing this I've defined a new
$warning-text-color variable and replaced other instances of #CC
with this variable.
I've also tweaked the appearance of the Flatpickr shortcut links
("Today," "Tomorrow," etc) so that they match other links in Koha.
To test, apply the patch and rebuild the staff interface CSS.
- Go to patrons and locate a patron record.
- Edit the patron.
- In the patron entry form, confirm that the "Date of birth" field
matches the width of the text fields around it.
- The "X" should be red.
- Click the date of birth field to trigger the calendar popup.
- The "Yesterday" and "Today" links should be colored the default green
seen elsewhere in the staff interface.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31919] Hovered items in "More" should change background color
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer changed: What|Removed |Added Attachment #142755|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 142810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142810=edit Bug 31919: Add background-color to a:hover in the header Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31919] Hovered items in "More" should change background color
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 --- Comment #2 from Katrin Fischer --- I like that this makes it easier visible what you have selected. Love it on the pull downs, not completely sure about the menu items. But I think it's better than the underline that is not as visible by far. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31919] Hovered items in "More" should change background color
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #5 from Katrin Fischer --- Please don't forget to set assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32002] Make submit button yellow on administration > Did you mean?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32002 Katrin Fischer changed: What|Removed |Added Attachment #142788|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 142809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142809=edit Bug 32002: Make submit button yellow on administration > Did you mean? This patch corrects the class on the "Did you mean?" page's save button so that it is consistent with other primary submit buttons. To test, apply the patch and go to Administration -> Did you mean? The "Save configuration" button should be yellow. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32002] Make submit button yellow on administration > Did you mean?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32002 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 --- Comment #1 from Katrin Fischer --- My feeling is that we now use a more flat, line-less design, so the buttons should be like that as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What|Removed |Added Blocks||32044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 [Bug 32044] Yellow buttons are styled differently in different spots -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32044] New: Yellow buttons are styled differently in different spots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 Bug ID: 32044 Summary: Yellow buttons are styled differently in different spots Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 30952 Sometimes there is an orange border line around the buttons and other times there is none. (personal preference: no border). 1) Log out of the staff client: the login page has a yellow button without borders. 2) Look at the checkout button in a patron account: orangey border. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014 Katrin Fischer changed: What|Removed |Added Attachment #142785|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 142808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142808=edit Bug 32014: Tweak style of checkout settings panel This patch makes some minor changes to the CSS controlling the way the checkout settings panel displays, as well as the panel showing the last checked-out item. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation and locate a patron to check out to. - On the checkout page, click the "settings" icon in the barcode field. - The checkout settings panel should display. Confirm that the spacing looks good. - Check out an item to the patron. - Confirm that the panel showing the last checked out item information looks correct: A green-bordered box with a white background, no rounded corners. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014 --- Comment #3 from Katrin Fischer --- I am gald you caught this as the transparent look didn't work well for the 'just checked out'. Wondering if choosing a different background color might have made it stand out a little more, but I think we move into an area of personal tastes now (which is good :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What|Removed |Added Blocks||32043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043 [Bug 32043] Circulation alerts can overlap other elements on smaller screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32043] New: Circulation alerts can overlap other elements on smaller screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043 Bug ID: 32043 Summary: Circulation alerts can overlap other elements on smaller screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 30952 Created attachment 142807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142807=edit Screenshot of circulation alert When you work on a smaller screen or with a smaller window, the circulation alerts like in the screenshot can overlap with the other elements a bit. Also: When the element is active, we see a red border and round corners. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What|Removed |Added Depends on||32042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042 [Bug 32042] Add page-section to items tab (cat) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What|Removed |Added Blocks||32042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042 [Bug 32042] Add page-section to items tab (cat) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32042] New: Add page-section to items tab (cat)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042 Bug ID: 32042 Summary: Add page-section to items tab (cat) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 30952 Blocks: 31757 The items tab you reach from the catalog detail page needs some page-sectioning. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer changed: What|Removed |Added Attachment #142789|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 142806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142806=edit Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32038] Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 --- Comment #3 from Katrin Fischer --- It is certainly an improvement! Two things I am not completely sure about: 1) When you open up the filters there is a grey line on the side. I think that one is not really needed. 2) The update options look much better, but it feels like it would be nice to have some kind of separation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #67 from Martin Renvoize --- All works for me.. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142796|0 |1
is obsolete||
--- Comment #66 from Martin Renvoize ---
Created attachment 142805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142805=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data structure be simpler:
_authorised_values => {
attribute_1 => { category => 'some_category_name', description =>
'description' }
}
The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.
Tests are adjusted accordingly, also to reflect the public => 1 use
case.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142795|0 |1
is obsolete||
--- Comment #65 from Martin Renvoize ---
Created attachment 142804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142804=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.
It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Martin Renvoize changed: What|Removed |Added Attachment #142794|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 142803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142803=edit Bug 26635: Add tests for av-expand => 0 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142793|0 |1
is obsolete||
--- Comment #63 from Martin Renvoize ---
Created attachment 142802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142802=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility to expand authorised values when to_api
method is called.
The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following
{
column_name => Koha::AuthorisedValue->unblessed
...
}
This patch will be used in bug 8179, so please test there.
Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Kyle M Hall
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand coded values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Martin Renvoize changed: What|Removed |Added Attachment #142792|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 142801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142801=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t and t/db_dependent/Koha/REST/Plugin/Objects.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
