[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762

--- Comment #10 from quickfir...@gmail.com ---
Still looking for help in this error while upgrading from v20.05 to v22.11.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33479] Add an option to pick a type of library during onboarding

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479

--- Comment #2 from Chris Cormack  ---
Both options would be good.
One for IT, one for the librarians.

Maybe file another big for that one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33479] Add an option to pick a type of library during onboarding

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I've actually been thinking it could be interesting to have a "profile" passed
to koha-create which would reset/override certain settings. 

I was thinking more so for vendors to provide a certain "configuration" to all
their instances at install time, but doing some profiles by library type could
be interesting too. 

I suppose that would be before the onboarding tool though...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33479] New: Add an option to pick a type of library during onboarding

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479

Bug ID: 33479
   Summary: Add an option to pick a type of library during
onboarding
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ch...@bigballofwax.co.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

One of the requests from ICAL 2023 was that if during installation a type of
library (public, school, academic, special, all) could be chosen. This would
then set a bunch of preferences.

Initially it was expressed as a request to have cut down versions of Koha for
libraries that don't need all the features. I explained this is not something
we would do, but that would could perhaps disable/hide some.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] New: Customise the format of notices when they are printed

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Bug ID: 33478
   Summary: Customise the format of notices when they are printed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

A feature to customise the format of notices when they are printed would be
great. Some things we'd like to be able to customise for example are:
- font size
- margins
- letterheads

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This enhancement makes it
  release notes||easy for the library to
   ||view sent notices and
   ||filter by various search
   ||parameters.
   ||
   ||You can also
   ||print sent notices,
   ||individually or in a batch.
   ||
   ||This enhancement uses a
   ||new system preference
   ||NoticesManagement and a new
   ||view_generated_notices user
   ||permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #149009|0   |1
is obsolete||

--- Comment #7 from Aleisha Amohia  ---
Created attachment 149413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149413=edit
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter
by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new
view_generated_notices user permission.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission
checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron
search box works by searching for one of the patrons you generated a notice
for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for
notices. Leaving the search filters empty will return all notices generated.
Confirm the filters work as expected by using different combinations of
filters.
8. Conduct a search so your notices show in a table. Confirm the information
fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up
box.
10. Click one of the Print buttons next to a notice. Confirm the notice is
opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed
has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the
checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to
'Print selected notices'. Confirm the notices have been collated into one
document, separated by horizontal lines, and prints successfully. The statuses
for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the
view_generated_notices permission
15. Confirm the Notices management page is not visible without the
NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user
permission is checked for your logged in patron, you should see a Print button
for each notice. Confirm this works. Confirm this button doesn't show if your
logged in patron does not have the view_generated_notices user permission. It
does not require the NoticesManagement system preference.

Sponsored-by: Colorado Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33435] We're missing sample dev data for ERM

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
Sounds like a great idea but perhaps it should go in the koha-misc4dev repo?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658

Michael Hafen  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #6 from Michael Hafen  ---
Bug 28657 has been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657

Michael Hafen  changed:

   What|Removed |Added

 Attachment #134173|0   |1
is obsolete||

--- Comment #7 from Michael Hafen  ---
Created attachment 149412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149412=edit
ug 28657: expand branches.branchip to allow for multiple ip  ranges.

[rebased 2023-04-10]

change branches.branchip to a mediumtext, and remove '*' from existing branchip
settings.
Change C4/Auth.pm from a regexp to using in_iprange() to check client address
against branchip.  (in_iprange() doesn't work with '*' in branchip.)
Change in_iprange() to default to false (which is what the POD says it should
do).  Also, have it trim '*' in case someone adds some back later.
Change note in admin/branches.tt under branchip field to reflect changes to
branchip handling.

Test plan:

1. Turn on AutoLocation system preference
2. Change a branches branchip to multiple ip ranges seperated by a space,
   making sure one of the ranges includes your computers address.
3. Log out and try logging in.  The location check will fail.
4. Apply patch.  Restart plack if necessary.
5. Try logging in again.  The location check will succeed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

--- Comment #8 from Katrin Fischer  ---
Starting here:

1) QA test tools:

Ohoh!

FAILKoha/Template/Plugin/Notices.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
   FAIL   filters
missing_filter at line 36 ( Print [% notice.name
%] slip)
missing_filter at line 36 ( Print [% notice.name
%] slip)
   FAIL   forbidden patterns
forbidden pattern: tab char (line 35)
forbidden pattern: tab char (line 37)

 OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 236)

 OK koha-tmpl/intranet-tmpl/prog/js/members-menu.js
 FAIL   members/printslip.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 101)
forbidden pattern: tab char (line 102)
forbidden pattern: tab char (line 103)
forbidden pattern: tab char (line 104)
forbidden pattern: tab char (line 105)
forbidden pattern: tab char (line 106)


Not finished with testing yet, but follow-ups welcome :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33208] When a recalled item is checked-in there is no indication of that the item is recalled and the recall status is not updated from requested

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33208

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #149379|0   |1
is obsolete||

--- Comment #2 from Emily Lamancusa  ---
Created attachment 149411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149411=edit
Bug 33471: Add validate_pickup_location routine to Koha::Biblio

This patch adds a new routine, similar to pickup_locations except that
it short circuits once a location has been found as acceptable.

To test:
1 - Attempt placing a hold for an acceptable pickup location via the API
2 - Attempt to change pickup location to an invalid location, you are blocked
3 - Attempt to place a another hold via API for an invalid locatoin, you are
blocked
4 - Apply patch
5 - Repeat
6 - Results should be the same

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33477] New: POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33477

Bug ID: 33477
   Summary: POST /holds/ allows invalid item-level hold if
biblio_id and item_id are both specified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emily.lamanc...@montgomerycountymd.gov
CC: tomasco...@gmail.com

To reproduce:

1. Locate or create a bib with multiple items
2. Set one item to type "Reference" and the rest to type "Book"
3. Go to the Circulation and Fines Rules > "Default holds policy by item type"
   section, and add a line specifying No Holds Allowed for Reference item type
4. Attempt to place an item-level hold on the Reference-type item via the REST
API,
   specifying only the parameters:
   patron_id, item_id, and pickup_library_id
5. Confirm expected error message: Hold cannot be placed. Reason: notReservable
6. Attempt to place an item-level hold on the Reference-type item via the REST
API,
   specifying only the parameters:
   patron_id, item_id, biblio_id, and pickup_library_id
7. Observe that an item-level hold has been placed on the Reference-type item,
even
   though it should not be holdable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470

--- Comment #3 from Emily Lamancusa  ---
Testing notes:
Step 0 - Set AllowHoldPolicyOverride to "Allow"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #149378|0   |1
is obsolete||

--- Comment #2 from Emily Lamancusa  ---
Created attachment 149410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149410=edit
Bug 33470: Don't calculate overridden hold limits

This patch can largely be checked in the code to ensure it makes sense, it
moves a conditional up one level for the two different checks that could
prevent holds

To test:
1 - Attempt to place a hold via the REST API with an invalid pickup location
Set pickup location as no in branches to make this easy
2 - Confirm you get an error
3 - Attempt again with header (bug 27760):
x-koha-override: any
4 - Hold is placed
5 - Repeat 1-4 above but with an item that cannot be held
6 - Apply patch
7 - Repeat 1-4 above
8 - Results should be the same

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from David Nind  ---
The tests don't pass after applying the patches:

prove t/db_dependent/api/v1/authorities.t
t/db_dependent/api/v1/authorities.t .. 1/3 
#   Failed test '409 Conflict'
#   at t/db_dependent/api/v1/authorities.t line 204.
#  got: '201'
# expected: '409'

#   Failed test 'Location header is only set when the new resource is
created'
#   at t/db_dependent/api/v1/authorities.t line 204.

#   Failed test 'similar match for JSON Pointer "/error"'
#   at t/db_dependent/api/v1/authorities.t line 204.
#   undef
# doesn't match '(?^u:Duplicate record (\d*))'

#   Failed test 'exact match for JSON Pointer "/error_code"'
#   at t/db_dependent/api/v1/authorities.t line 204.
#  got: undef
# expected: 'duplicate'
# Looks like you failed 4 tests of 19.
t/db_dependent/api/v1/authorities.t .. 3/3 
#   Failed test 'post() tests'
#   at t/db_dependent/api/v1/authorities.t line 227.
# Looks like you failed 1 test of 3.
t/db_dependent/api/v1/authorities.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/3 subtests 

Test Summary Report
---
t/db_dependent/api/v1/authorities.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
Files=1, Tests=3,  4 wallclock secs ( 0.02 usr  0.00 sys +  3.67 cusr  0.14
csys =  3.83 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356

--- Comment #7 from David Nind  ---
(In reply to Katrin Fischer from comment #6)
> What do you think?

I like your alternative Katrin!

I have tested both patches and they work.

Once it is decided, I am happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33476] Tracking notices other than patron notices

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33476

--- Comment #1 from Christopher Brannon  ---
Perhaps there should be an Admin notices tab on the admin page so that we could
track notices that go to a specified generic address can be tracked as well? 
That could be an option when setting up emails like KohaAdminEmailAddress
rather than inputing a manual address.  The email address could be defined on
that tab?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33476] New: Tracking notices other than patron notices

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33476

Bug ID: 33476
   Summary: Tracking notices other than patron notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

It is extremely easy to view all notices sent to patrons.  But it is not as
easy to see system generated emails to libraries.

Would it be possible to create a notices tab for libraries, and then wherever
we define where internal notices go to, we can select either a patron account
(for staff) or a library account (as long as it has an email address defined)? 
We might still retain the ability to put in a manual address.  This would be
the exception where we wouldn't be able to track notices, but being able to
point to a patron account or library account would allow for easier setup and
tracking all around.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 149409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149409=edit
Bug 31795: Fix required permissions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800

--- Comment #6 from Katrin Fischer  ---
Also verified that the deleted records are added to the set now correctly and
show as "Deleted".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148914|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 149408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149408=edit
Bug 32800: Don't embed items for deleted records

To test:
1 - Delete a biblio
2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r
3 - Error:
Can't call method "items" on an undefined value at
/kohadevbox/koha/Koha/Biblio/Metadata.pm line 163.
4 - Apply patch
5 - Repeat
6 - Success!

Signed-off-by: Magnus Enger 
Works as advertised.
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 149407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149407=edit
Bug 31795: (QA follow-up) Use x-koha-override header

Despite its title, this patch does a couple more things.

1. The tests are rewritten to cover more things, and also to avoid
   deleting all authorities inside the transaction. It is really not
   required.
2. It makes the endpoint rely on the already generically implemented
   x-koha-override header, which is intended for the same use case as
   x-confirm-not-duplicate is for.
3. It changes the return codes to match the coding guidelines [1]
4. Only checks for duplicates if no override passed.

To test:
1. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/authorities.t
=> SUCCESS: Tests pass!
2. Apply this follow-up
3. Repeat 1
=> SUCCESS: Tests pass!
4. Sign off :-D

[1]
https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.1_POST

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---
Hi Nick,

this looks quite good, but I think we need some more clean-up:

1) Serials

C4/Serials.pm:  

if ( C4::Context->preference("RenewSerialAddsSuggestion") ) {
require C4::Suggestions;
C4::Suggestions::NewSuggestion(
{   'suggestedby'   => $user,
'title' => $subscription->{bibliotitle},
'author'=> $biblio->{author},
'publishercode' => $biblio->{publishercode},
'note'  => $note,
'biblionumber'  => $subscription->{biblionumber},
'branchcode'=> $branchcode,
}
);
}

2) Export list

C4/Suggestions.pm:  NewSuggestion

Method is still in the list of exports.


I would have fixed 2) but I think it would be better if you check on 1).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

--- Comment #4 from Katrin Fischer  ---
Nice clean-up and improvement! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148974|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 149406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149406=edit
Bug 33281: Improve detail auth links and add to marc preview

This patch adds atuh links tot he marc preview, and makes detial auth links
open in a
new tab/window and consolidates some code

To test:
1 - View a record linked to authorities in staff client
2 - Note links have no hover text, and open in same window
3 - Apply patch
4 - Restart and reload
5 - Note links now have a hint
6 - Note they open in new window
7 -  View marc preview and note there are similar links

Signed-off-by: Michaela Sieber 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

--- Comment #13 from Katrin Fischer  ---
Thx Nick, this now also works with the "Edit search" as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148973|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 149405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149405=edit
Bug 32301: [alternate] Fix default search sorting in advanced search when not
editing a search

Bug 22605 changed the sorting to expect the passed parameter from the
previous search, this broke default when the search page was loaded
fresh.

We should simply fallback from the edited search to the default if it is
not set

To test:
1) Go to staff client
2) Go to Advanced Search
3) Notice the default Sort By value is "Relevance"
4) Go to system preferences
5) Go to "defaultSortField"
6) Change the value of the system preference
7) Go back to Advanced Search and refresh the page
8) Notice that there are no changes, the default Sort By is still
"Relevance"
9) Apply patch
10) Notice that changing the system preference now changes the default
Sort By in Advanced Search
11) Perform a search, change the sorting, then edit the search
12) Confirm the correct sorting from the search is preserved

Signed-off-by: Michaela Sieber 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

--- Comment #26 from Katrin Fischer  ---
Created attachment 149404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149404=edit
Bug 18829: (QA follow-up) I18N, test character and breadcrumbs

* Removes a 'heart' character from the file, probably added for testing
* Corrects breadbrumbs to make QA test tool happy
* Makes JS message translatable (test by manipulating the link to an invalid
record number in DOM)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148760|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 149403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149403=edit
Bug 18829: (follow-up) Don't messup record encoding

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148759|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 149402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149402=edit
Bug 18829: (follow-up) Return 404 when record cannot be loaded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148758|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 149401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149401=edit
Bug 18829: (QA follow-up) Fix punctuation, capitalization and page title

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148757|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 149400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149400=edit
Bug 18829: Elasticsearch - Put a better display for the view of ES indexed
record

To test:
- apply the patch
- go to global sysPref
- make sure that SearchEngine have "ElasticSearch" as value
- Search whatever you want in Search the catalog and select a record
- Search the link (Ctrl f) : "Elasticsearch Record :" , click on the link
- make sure that the pop-up open and you should see the elasticsearch result in
JSON (the pop-up look the same as MARC preview)
- note fields are alphabetized
- from the command line delete the es record:
curl -XDELETE es:9200/koha_kohadev_biblios/data/5
- click the preview link, it syas record not found
- check the logs - you see the error on missing record

Signed-off-by: Fridolin Somers 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148951|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 149399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149399=edit
Bug 32970: (follow-up) Move include to specific job file

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148950|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 149398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149398=edit
Bug 32970: Use KohaTable for display of batch item modification results

This patch updates the code to use KohaTables to provide export of the
batch modification results.

Additionally, searching is added, and the first two columns are made
searchable

To test:
1 - Perform a match item modification on several items
2 - View the results of the background job
3 - Apply patch
4 - Reload page
5 - Note you now have additional controls including 'search' and
  'export'
6 - Test searching and exporting
7 - Confirm all work as expected

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149396|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 149397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149397=edit
Bug 33316: (QA follow-up) Add link to record, fix typo and heading

* h2 h2 directly following each other make no sense. Changed to h2 h3
* ids changed to IDs
* Linked the record ID to the catalog entry
  Note: We also have this link in the batch record mod job details

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #11 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #8)
> I've fixed the test, but I have a problem with the indexing job - it doesn't
> get done, so I can't verify the display. I remain stuck with:
> 
> 3 New null/1  Update Elasticsearch index  04/10/2023 16:25

Turns out, things work better when Elastisearch is actually running...

(In reply to Jonathan Druart from comment #5)
> This should depend on the decision of keeping or removing
> Koha::BackgroundJob::UpdateElasticIndex->process (see bug 32594 comment 41 &
> 43).

I am not sure about this one. Bug 32594 is now pushed to master, the job is
still there. I think this won't hurt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #10 from Katrin Fischer  ---
Created attachment 149396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149396=edit
Bug 33316: (QA follow-up) Add link to record, fix typo and heading

* h2 h2 directly following each other make no sense. Changed to h2 h3
* ids changed to IDs
* Linked the record ID to the catalog entry
  Note: We also have this link in the batch record mod job details

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149394|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 149395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149395=edit
Bug 33316: Improve display of ES indexer jobs

We don't do a lot of processing to the data, but we can still
make the display a bit nicer, to show how many records were
done, and show the record ids.

To test:
1 - Do some batch modifications on a system running ES
2 - Check background jobs to see ES jobs
3 - Note display
4 - Apply patch
5 - Confirm display is improved

Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #8 from Katrin Fischer  ---
I've fixed the test, but I have a problem with the indexing job - it doesn't
get done, so I can't verify the display. I remain stuck with:

3   New null/1  Update Elasticsearch index  04/10/2023 16:25

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148576|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 149394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149394=edit
Bug 33316: Improve display of ES indexer jobs

We don't do a lot of processing to the data, but we can still
make the display a bit nicer, to show how many records were
done, and show the record ids.

To test:
1 - Do some batch modifications on a system running ES
2 - Check background jobs to see ES jobs
3 - Note display
4 - Apply patch
5 - Confirm display is improved

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33316] Improve display of ES indexer jobs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316

--- Comment #6 from Katrin Fischer  ---
Please make sure commit message has a descriptive subject and includes test
plan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20271

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30392

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #25 from Christopher Brannon  ---
This is a good step for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #147488|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 149393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149393=edit
Bug 31448: Replace 'Print' with 'Receipt' dropdown

This patch replaces the 'Print' button with a 'Receipt' menu dropdown
exposing 'Print' and 'Email' options when `UseEmailReceipts` is enabled

Test plan
1. Enable `UseEmailReceipts`
2. Navigate to a patron with paid charges
3. Note the new dropdown 'Receipt' menu
4. Confirm 'Print' works as expected
5. Confirm 'Email' works as expected

Signed-off-by: Sally 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311

--- Comment #15 from Katrin Fischer  ---
Created attachment 149392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149392=edit
Bug 29311: (follow-up) Fix t/db_dependent/selenium/regressions.t

The test was checking for the value of an input field.
But with this patch set, there is no longer an input, but
a link element with the title. This adjusts the patch to look
for the correct element.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311

--- Comment #14 from Katrin Fischer  ---
Created attachment 149391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149391=edit
Bug 29311: (follow-up) Add id to span elements

The input fields in the form have ids, these are useful
for styling, but also for the Selenium tests. This patch
adds the ids from the former inputs to the now spans.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #13 from Katrin Fischer  ---
It looks like this breaks a selenium test:

t/db_dependent/selenium/regressions.t .. 7/8 
STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch
{...} 
/usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try
(eval 549):1 in Selenium::Remote::Driver::__ANON__
(eval 551):2 in Selenium::Remote::Driver::__ANON__
/usr/share/perl5/Selenium/Remote/Driver.pm:1340 in
Selenium::Remote::Driver::_execute_command
/usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval)
t/db_dependent/selenium/regressions.t:358 in
Selenium::Remote::Driver::find_element
/usr/share/perl/5.32/Test/Builder.pm:334 in main::__ANON__
/usr/share/perl/5.32/Test/Builder.pm:334 in (eval)
/usr/share/perl/5.32/Test/More.pm:809 in Test::Builder::subtest
t/db_dependent/selenium/regressions.t:372 in Test::More::subtest

# No tests run!
t/db_dependent/selenium/regressions.t .. 8/8 
#   Failed test 'No tests run for subtest "OPAC - Suggest for purchase"'
#   at t/db_dependent/selenium/regressions.t line 372.
Error while executing command: no such element: Unable to locate element:
//input[@id="title"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.
 at /usr/share/perl5/Selenium/Remote/Driver.pm line 356.
# Looks like your test exited with 11 just after 8.


The test looks for an input field, but with this patch applied, there is no
longer any input, just this:

Title:
E Street shuffle :

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33475] New: Remove Syndetics template variables from Auth.pm

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33475

Bug ID: 33475
   Summary: Remove Syndetics template variables from Auth.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

593 SyndeticsClientCode   =>
C4::Context->preference("SyndeticsClientCode"),
 594 SyndeticsEnabled  =>
C4::Context->preference("SyndeticsEnabled"),
 595 SyndeticsCoverImages  =>
C4::Context->preference("SyndeticsCoverImages"),
 596 SyndeticsTOC  =>
C4::Context->preference("SyndeticsTOC"),
 597 SyndeticsSummary  =>
C4::Context->preference("SyndeticsSummary"),
 598 SyndeticsEditions =>
C4::Context->preference("SyndeticsEditions"),
 599 SyndeticsExcerpt  =>
C4::Context->preference("SyndeticsExcerpt"),
 600 SyndeticsReviews  =>
C4::Context->preference("SyndeticsReviews"),
 601 SyndeticsAuthorNotes  =>
C4::Context->preference("SyndeticsAuthorNotes"),
 602 SyndeticsAwards   =>
C4::Context->preference("SyndeticsAwards"),
 603 SyndeticsSeries   =>
C4::Context->preference("SyndeticsSeries"),
 604 SyndeticsCoverImageSize   =>
C4::Context->preference("SyndeticsCoverImageSize"),


I don't think these need to be in Auth.pm anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33474

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33474] New: Don't create a notice for patrons without email when UseEmailReceipts is used

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33474

Bug ID: 33474
   Summary: Don't create a notice for patrons without email when
UseEmailReceipts is used
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

With UseEmailReceipts set to "Send" it will always create an entry in the
message_queue, even if the user has no email address.

We should not create the notice, when the patron has no email.

I am not sure about falling back to print since the those would probably just
be handed out and not mailed to the patron. There is also already a print
option in Accounting to create a printed receipt.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||33473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473
[Bug 33473] Allow to send email receipts for payments/writeoff manually instead
of automatically
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33473] New: Allow to send email receipts for payments/writeoff manually instead of automatically

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473

Bug ID: 33473
   Summary: Allow to send email receipts for payments/writeoff
manually instead of automatically
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 31448

With bug 31448 it's possible to re-send a failed or lost email receipt. It
would be nice if you could turn off the automatic sending of receipts by email
and send them just manually whenever requested.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448
[Bug 31448] Add option to re-send email receipt when UseEmailReceipts is
enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #149296|0   |1
is obsolete||

--- Comment #4 from Emily Lamancusa  ---
Created attachment 149390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149390=edit
Bug 33447: Adjust tests

Signed-off-by: emlam 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #149295|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 149389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149389=edit
Bug 33447: Add Cache to Biblio->pickup_locations

This is going to have the most effect on records with large numbers of items
held by the same library, serial records and the like

To test:
1 - Add 500 items to a biblio by select myltiple copies on the add item page
2 - Place a hold via the API and note response time, I found ~3-5 seconds
3 - Apply patch
4 - Restart all
5 - Place hold using api again
6 - Note improved response time, less than 1/2 a second in my tests

Signed-off-by: emlam 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041

--- Comment #3 from Lucas Gass  ---
Created attachment 149388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149388=edit
Bug 32041: Enforce SyndeticsCoverImageSize everywhere

This patch add the SyndeticsCoverImageSize to the folling pages:

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt

To test:
1. Turn on SyndeticsCoverImages and SyndeticsEnabled.
2. Check the staff results page and make sure you can change the image size via
SyndeticsCoverImageSize.
3. Check the OPAC results page.
4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within
the shelf browser.
5. Test the OPAC checkout history page. ( opac-readingrecord.tt )
6. Have a checkout and an overdue to test the 2 tables on the OPAC summary
pahe. ( opac-user.tt )

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148155|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 149387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149387=edit
Bug 29046: Change link in EmailFieldPrecedence and add link in
EmailFieldPrimary

This patch modifies the link in EmailFieldPrecedence to reflect the new
name of EmailFieldPrimary. It also adds a note in the latter to set the
'first valid' order in the former.

To test:
1. Go to Administration > Global system preferences
2. Search for EmailFieldPrecedence
3. Click on the link in the description
   --> It should lead to EmailFieldPrimary
4. Read the note in EmailFieldPrimary, make sure the grammar and
   spelling are correct.
5. Click the link to EmailFieldPrecedence
   --> It should lead to EmailFieldPrecedence

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148146|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 149386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149386=edit
Bug 29046: Use EmailFieldPrecedence in first_valid_email_address

This patch update the Koha::Patron->first_valid_email_address method to
use the newly defined EmailFieldPrecedence preference.

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148145|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 149385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149385=edit
Bug 29046: Add 'EmailFieldPrecedence' preference

This patch adds a new EmailFieldPrecidence systempreference to allow
users to set the precicence in which patron email fields should be used
for communications.

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Katrin Fischer  ---
Overall this looks good, but we got one blocker:

1) Unit tests are missing.

2) I wonder if we could simplify the system preference description a little:

Use the following patron email fields in order of highest precedence first
[email|emailpro|B_email] when selecting which email address to use to send
patron notices. 

2 things:
* I think we should list the valid options in the system preference so that
when one was deleted, it can be restored more easily.

* I have no idea how to translate highest precedence... but what it means is
that the first field with an email address will be used, right? Maybe we could
phrase it along the lines of:

When EmailFieldPrimary is set to 'first valid', check the patron email address
fields in the following order and use the first valid email address found:

* Not blocker: For languages we can sort the entries with drag Could this
be a possible option here? Or maybe I could file as a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #149383|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 149384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149384=edit
Bug 33192: (QA follow-up) Fix it-IT sample data and unit tests

To test:
* prove t/db_dependent/Message.t
* Run the it-IT web installer and make sure 'email' is set.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

--- Comment #11 from Katrin Fischer  ---
Created attachment 149383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149383=edit
Bug 33192: Fix it-IT sample data and unit tests

To test:
* prove t/db_dependent/Message.t
* Run the it-IT web installer and make sure 'email' is set.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148140|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 149382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149382=edit
Bug 33192: Update all occurrences of AutoEmailPrimaryAddress

This patch updates all references to AutoEmailPrimaryAddress to refer to
EmailFieldPrimary instead.

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #148139|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 149381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149381=edit
Bug 33192: Update AutoEmailPrimaryAddress to EmailFieldPrimary

This patch updates the database to reflect the new name for the
AutoEmailPrimaryAddress system preferences

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041

--- Comment #2 from Lucas Gass  ---
I've had many libraries complain about the small size/blurriness of cover
images on the results page. We should make Syndetics cover images honor the
'SyndeticsCoverImageSize' in any place where they are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Katrin Fischer  ---
I think that the option to immediately "delete circulation history" from the
patron account in the OPAC doesn't work correctly yet. I have no more issues,
but there is still a renewal entry that has the renewer_id of my user.

The immediately deletion should always work, independent of the privacy
setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 149380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149380=edit
Bug 31795: Add REST endpoint to add an authority

To test:
1. Apply patch
2. Set RESTBasicAuth preference to true
3. Make a POST request to /api/v1/authorities with one of the following content
type header
  - application/json
  - application/marcxml+xml
  - application/marc-in-json
  - application/marc
4. If content type is other than application/json, then add the following
header to the request: "x-authority-type: "
5. Check that the authority is created
6. Sign off

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #144750|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #144749|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284

--- Comment #15 from Katrin Fischer  ---
Please remember to add the test plan to the commit messages. I am going to use
Andrew's from comment 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878

--- Comment #19 from Laura Escamilla  ---
Just following up to see if this can be backported to 22.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

--- Comment #99 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #98)
> It looks like this broke Jenkins.

Hey, we need the images rebuilt with the new deps. thanks for reporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #98 from Katrin Fischer  ---
It looks like this broke Jenkins.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

--- Comment #97 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >