[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|dependency  |

--- Comment #87 from Jonathan Druart  ---
(In reply to Mason James from comment #37)
> hi joubu
> i've uploaded a libdata-session-perl pkg to koha-staging/dev, for testing

If we are going with the approach we have now we won't need it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

Summary|Update plugin   |Update plugin
   |unimarc_field_110.pl|unimarc_field_100.pl
   |'Script of title' with 2022 |'Script of title' with 2022
   |values  |values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

--- Comment #4 from Thibaud Guillot  ---
Comment on attachment 150790
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150790
Bug 33686: Update plugin unimarc_field_110.pl with 2022 values

>From 0fc81a34b3ff8e6eaf1b1270282a31cfc8453c8b Mon Sep 17 00:00:00 2001
>From: Thibaud Guillot 
>Date: Fri, 5 May 2023 13:01:23 +0200
>Subject: [PATCH] Bug 33686: Update plugin unimarc_field_100.pl with 2022
> values
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Was missing :
>
>- ib : birman
>- ic : khmer
>- jb : bengali
>- jc : gujurati
>- jd : gurmukhi
>- je : odia (oriya)
>- lb : kannada (kannara)
>- lc : malayalam
>- ld : singhalais (cinghalais)
>- le : télougou
>- na : éthiopien (guèze)
>
>Sponsored by BibLibre
>
>Signed-off-by: David Nind 
>---
> .../value_builder/unimarc_field_100.tt| 55 +++
> 1 file changed, 55 insertions(+)
>
>diff --git 
>a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt
> 
>b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt
>index 103e8949cc..23e43cff13 100644
>--- 
>a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt
>+++ 
>b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt
>@@ -685,6 +685,16 @@
> [% ELSE %]
> ia- Thai
> [% END %]
>+[% IF ( f15ib ) %]
>+ib- 
>Birman
>+[% ELSE %]
>+ib- Birman
>+[% END %]
>+[% IF ( f15ic ) %]
>+ic- 
>Khmer
>+[% ELSE %]
>+ic- Khmer
>+[% END %]
> [% IF ( f15id ) %]
> id- 
> Laotian
> [% ELSE %]
>@@ -700,6 +710,26 @@
> [% ELSE %]
> ja- Devanagari
> [% END %]
>+[% IF ( f15jb ) %]
>+jb- 
>Bengali
>+[% ELSE %]
>+jb- Bengali
>+[% END %]
>+[% IF ( f15jc ) %]
>+jc- 
>Gujurati
>+[% ELSE %]
>+jc- Gujurati
>+[% END %]
>+[% IF ( f15jd ) %]
>+jd- 
>Gurmukhi
>+[% ELSE %]
>+jd- Gurmukhi
>+[% END %]
>+[% IF ( f15je ) %]
>+je- 
>Odia (oriya)
>+[% ELSE %]
>+je- Odia (oriya)
>+[% END %]
> [% IF ( f15jf ) %]
> jf- 
> Tibetan
> [% ELSE %]
>@@ -720,6 +750,26 @@
> [% ELSE %]
> la- Tamil
> [% END %]
>+[% IF ( f15lb ) %]
>+lb- 
>Kannada (kannara)
>+[% ELSE %]
>+lb- Kannada 
>(kannara)
>+[% END %]
>+[% IF ( f15lc ) %]
>+lc- 
>Malayalam
>+[% ELSE %]
>+lc- Malayalam
>+[% END %]
>+[% IF ( f15ld ) %]
>+ld- 
>Singhalais (cinghalais)
>+[% ELSE %]
>+ld- Singhalais 
>(cinghalais)
>+[% END %]
>+[% IF ( f15le ) %]
>+le- 
>Tégoulou
>+[% ELSE %]
>+le- Tégoulou
>+[% END %]
> [% IF ( f15lf ) %]
> lf- 
> Grantha
> [% ELSE %]
>@@ -735,6 +785,11 @@
> [% ELSE %]
> mb- Armenian
> [% END %]
>+[% IF ( f15na ) %]
>+na- 
>Ethiopien (guèze)
>+[% ELSE %]
>+na- Ethiopien 
>(guèze)
>+[% END %]
>

[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #150790|Bug 33686: Update plugin|Bug 33686: Update plugin
description|unimarc_field_110.pl with   |unimarc_field_100.pl with
   |2022 values |2022 values
 Attachment #150790|Bug-33686-Update-plugin-uni |Bug-33686-Update-plugin-uni
   filename|marcfield110pl-with-202.pat |marcfield100pl-with-202.pat
   |ch  |ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667

Jonathan Druart  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi
   ||,
   ||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Emmi, can you have a look at this one please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...)

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404

--- Comment #62 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #61)
> I tried to use an example from the old help file, but I got:
> 
> +  Display all 245$a and 245$c into the same column:
> +
> +[% FOREACH field IN fields.245 %]
> +[% field.a %] [% field.c %]
> +[% END %]
> +
> +  
> 
> Titel=[% FOREACH field IN fields.245 %][% field.a %] [% field.b %] [%
> field.n %] [% field.p %] [% field.c %][% END %]
> 
> ARRAY(0x5642032a0638) ARRAY(0x564202a832f0) ARRAY(0x564203388d48)
> ARRAY(0x5642033cc020) ARRAY(0x564203439cc0)

field.a contains the list of a's.
The following works:
Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.b.0 %] [%
field.n.0 %] [% field.p.0 %] [% field.c.0 %][% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...)

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404

--- Comment #63 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #62)
> (In reply to Katrin Fischer from comment #61)
> > I tried to use an example from the old help file, but I got:
> > 
> > +  Display all 245$a and 245$c into the same column:
> > +
> > +[% FOREACH field IN fields.245 %]
> > +[% field.a %] [% field.c %]
> > +[% END %]
> > +
> > +  
> > 
> > Titel=[% FOREACH field IN fields.245 %][% field.a %] [% field.b %] [%
> > field.n %] [% field.p %] [% field.c %][% END %]
> > 
> > ARRAY(0x5642032a0638) ARRAY(0x564202a832f0) ARRAY(0x564203388d48)
> > ARRAY(0x5642033cc020) ARRAY(0x564203439cc0)
> 
> field.a contains the list of a's.
> The following works:
> Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.b.0 %] [%
> field.n.0 %] [% field.p.0 %] [% field.c.0 %][% END %]

Ha, there is a follow-up commit:
  commit c33c56028fb39a464a780b2a22e95af0da73585f
  Bug 12404: FIX documentation to join subfield

The correct syntax is:
   Display all 245$a and 245$c into the same column:
 
 [% FOREACH field IN fields.245 %]
   [% field.a.join(' ') %] [% field.c.join(' ') %]
 [% END %]
 
   

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs'

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606

--- Comment #8 from Jonathan Druart  ---
https://irc.koha-community.org/koha/2023-05-09#i_2485635

"""
it could certainly be /config/erm
i.e. constrained to specific modules
and instead of exposing the sysprefs
list enabled modules
or components
in terms of your solution, it is just a matter of naming things more
generically, and consistently
"""

Please be explicit, I don't understand.
I am exposing ERMModule and ERMProviders. Why should I make the code obscure
and hide that behind an other config key? Having the syspref names in tt/vue to
grep make things easy.

If it's really important for you, I am suggesting
/config/erm
{
enabled => 1|0,
providers => ['local', 'ebsco'],
}

For now.

Then we will add the permission list later (for bug 32968), and it could be
something like:
{
enabled => 1|0,
providers => ['local', 'ebsco'],
permissions => ['agreements.write', 'eholdings.write'], etc.
}

Would that work for everybody?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #24 from Katrin Fischer  ---
I think we should do both. 

1) Web installer: It will help with SQL reporting where you can't use the
includes. I have translated ours in the database for this reason and it has no
bad side effects.

2) Template fixes: These are great, because they fix what I initially had
reported.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #25 from Katrin Fischer  ---
Actually, I think we might need some more template fixes, but are on a good
road here. 

Looking at my original test plan:

To test:
- Make sure a language with a complete translation is installed
- Switch to the language
- Go to any user account
- Add a manual invoice
- Pay it off fully or partially
- Click on "issue refund"
- Verify the list of "Transaction types" is not translated
- Check the information in the patron account. It will show:

I'll try to test this now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667

--- Comment #2 from Emmi Takkinen  ---
Modifying holidays only affects to existing holidays and since holiday created
and edited in branch A doesn't exists in branches B, C etc. "Copy changes to
all libraries" has no effect. 

Maybe we could call "isHoliday" before calling e.g. "ModDaymonthholiday" and
then add holiday if it doesn't exists?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

--- Comment #5 from Thibaud Guillot  ---
Created attachment 150933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150933&action=edit
Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info

MySQL 8 returns this additional information for a timestamp such
as the timestamp2 in the Commenter test.
Which results in the following alter:
ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2`
timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT
'Column_5'
And that statement fails again on that keyword.
For now, it seems sufficient to ignore this keyword when building the alter
statement.

Test plan:
Run t/db_dependent/Koha/Database/Commenter.t

Signed-off-by: Marcel de Rooy 
Did test it now under MySQL 8.
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

--- Comment #6 from Thibaud Guillot  ---
Created attachment 150934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150934&action=edit
Bug 33686: Correction of existing terms related to 'Script of title'

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Jonathan Druart  ---
There is something broken.

Uncaught (in promise) Error: Missing required param "license_id"

To recreate:
1. Create a license
2. Go to /cgi-bin/koha/erm/licenses
3. Click on a license's name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #150790|0   |1
is obsolete||
 Attachment #150933|0   |1
is obsolete||

--- Comment #7 from Thibaud Guillot  ---
Created attachment 150935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150935&action=edit
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #150934|0   |1
is obsolete||

--- Comment #8 from Thibaud Guillot  ---
Created attachment 150936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150936&action=edit
Bug 33686: Correction of existing terms related to 'Script of title'

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #150935|0   |1
is obsolete||
 Attachment #150936|0   |1
is obsolete||

--- Comment #9 from Thibaud Guillot  ---
Created attachment 150937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150937&action=edit
Bug 33686: Update plugin unimarc_field_100.pl with 2022 values

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf


 Current status: Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

--- Comment #10 from Thibaud Guillot  ---
Created attachment 150938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150938&action=edit
Bug 33686: Correction of existing terms related to 'Script of title'

According to
https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686

--- Comment #11 from Thibaud Guillot  ---
(In reply to David Nind from comment #3)
> I've signed off, as this adds the new values in the 2022 UNIMARC update.
> 
> However, I do have a question: should the script of title name values match
> exactly with the UNIMARC definitions (see references)?
> 
> For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba),
> but in Koha it is shown as eg Dongba (Naxi).
> 
> If they should, I'm happy to create a bug for that.
> 
> References:
> 1. UNIMARC Bibliographic (3rd ed.) Updates
> https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-
> updates/
> 2. Tag 100 values (see page 8 for 'Script of title')
> https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
> 
> Testing notes (using KTD):
> 1. Before starting KTD, edit your .env file to change
> KOHA_MARC_FLAVOUR=unimarc
> 2. Edit a record and view the values for tag 100 and the 'Script of title'
> dropdown list.
> 3. Codes and names for values being added by this bug are not listed.
> 4. Apply the patch.
> 5. Restart everything (flush_memcached, restart_all, clear browser cache).
> 6. Repeat step 2.
> 7. New codes and values are now lsited.

Hello David, 

Indeed there are some terms which are not exactly the same as those of the ifla
document, I propose a correction of those in a differentiated commit (only
concerning the section "Script of title" to be precise with the BZ title).

I took the opportunity to change the title of the BZ, there was an error
concerning the value builder, it is 100 and not 110 as previously indicated.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33358] Do not use editorconfig for vue files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Jonathan Druart  ---
I finally found what caused the original problem (vscodium not taking into
account its own config). There is a "Prettier: Use Editor Config" that was set. 

I removed it and now it's working without any changes in Koha.

I think that's the best solution for now, as nobody else seems to have
problems. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33358] Do not use editorconfig for vue files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_23_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33358] Do not use editorconfig for vue files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358

--- Comment #6 from Jonathan Druart  ---
Another solution would be to have our prettier options defined in a
.prettierrc. For ts, vue and js files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #26 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #25)
> Actually, I think we might need some more template fixes, but are on a good
> road here. 
> 
> Looking at my original test plan:
> 
> To test:
> - Make sure a language with a complete translation is installed
> - Switch to the language
> - Go to any user account
> - Add a manual invoice
> - Pay it off fully or partially
> - Click on "issue refund"
> - Verify the list of "Transaction types" is not translated

Only Cash stands out there, the other entries are translated now. This will be
fixed by Caroline's adding Cash to the web installer files, because this list
is part hard coded and part coming from AV:

[% FOREACH pt IN payment_types %]
  [% pt.lib | html %]
[% END %]

> - Check the information in the patron account. It will show:

Some debit and credit types are missing from the includes. I'll provide a
follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447

--- Comment #21 from Jonathan Druart  ---
(In reply to Jacob O'Mara from comment #20)
> Nice work, thanks everyone!
> 
> Pushed to 22.11.x for the next release.

You broke Jenkins
  Can't locate Koha/Exceptions/Checkin.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33642] Typo: No log found .

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33642] Typo: No log found .

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642

--- Comment #1 from Jonathan Druart  ---
Created attachment 150940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150940&action=edit
Bug 33642: Fix 'No log found.' in viewlog

It should ease translatability and remove an extra space.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33642] Typo: No log found .

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

Mengu Yazicioglu  changed:

   What|Removed |Added

 CC||me...@devinim.com.tr

--- Comment #55 from Mengu Yazicioglu  ---
Hi all,

Does this patch only change row format of table "tags" ?

I've manually changed that table but didn't pass the installation phase.
I've found some other tables like biblioitems,branches,borrowers,etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150912|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 150941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150941&action=edit
Bug 26403: Move credit and debit types into translatable YAML files

This patch moves account debit and credit types, as well as the CASH
payment type, into YAML files under
installer/data/en/mandatory. This should make the debit and credit types
translatable (for new installations only).

To test:
1. Apply patch
2. Update po files
   ./misc/translator/translate update xx-XX
3. View the xx-XX-installer.po file
   -->The default account debit and credit types (and cash payment type)
  should be available to be translated
4. Translate the strings
5. Apply the translations
   ./misc/translator/translate install xx-XX
6. Load the new translated YAML files (with a fresh install, or by deleting
   the values in the db and using ./misc/load_yaml.pl to load the files)
7. In the staff interface, go to Administration > Credit types
   --> They should be translated
8. Go to Administration > Debit types
   --> They should be translated

Signed-off-by: Magnus Enger 
Signed-off-by: Katrin Fischer 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150913|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 150942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150942&action=edit
Bug 26403: (follow-up) Deleted old SQL files

Signed-off-by: Magnus Enger 
Followed the test plan. Works as advertised.
Signed-off-by: Katrin Fischer 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Which display do you suggest?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150932|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 150943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150943&action=edit
Bug 26403: Use accounts include in account management pages

This patch updates the credit and debit types management pages to use
the proper includes for handling system type translations.  This is how
it should have been done in the first place on the original bugs that
introduced the management of these types but for some reason I think it
got dropped during the QA process leading to confusion around these
system types with their fixed descriptions.

To test:
1. Apply patch
2. Apply the translations
   ./misc/translator/translate install xx-XX
3. In the staff interface, go to Administration > Credit types
   --> They should be translated
4. Go to Administration > Debit types
   --> They should be translated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #30 from Katrin Fischer  ---
Created attachment 150944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150944&action=edit
Bug 26403: (QA follow-up) Add missing debit and credit types to includes

This adds the missing debit and credit types to the includes, namely:
DISCOUNT, PURCHASE, PAYOUT, and VOID.

I sorted them as they appear in the GUI (alphabetically) so it's a little
easier to spot missing ones.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

Summary|Move debit and credit types |Move debit and credit types
   |to YAML files to make them  |to YAML files and fix other
   |translatable for use in |related translation issues
   |reports |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

--- Comment #1 from Jonathan Druart  ---
Created attachment 150945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150945&action=edit
Bug 33658: Fix capitalization 'To Reproduce'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||31028
   Keywords||rel_23_05_candidate


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33658


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658
[Bug 33658] Capitalization: **To Reproduce**
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||32072
 Blocks|32072   |
Version|22.11   |unspecified


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072
[Bug 32072] Consistent classes for primary buttons: Cataloging
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32072] Consistent classes for primary buttons: Cataloging

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33655
 Depends on|33655   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655
[Bug 33655] z39.50 search no longer shows search in progress
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150944|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 150946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150946&action=edit
Bug 26403: (QA follow-up) Add missing debit and credit types to includes

This adds the missing debit and credit types to the includes, namely:
DISCOUNT, PURCHASE, PAYOUT, and VOID.

I sorted them as they appear in the GUI (alphabetically) so it's a little
easier to spot missing ones.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||With this patch the
  release notes||descriptions of system
   ||internal credit and debit
   ||types will be translated
   ||into the selected language
   ||at installation time. This
   ||will only affect new
   ||installations and SQL
   ||reporting. If you are
   ||building your own SQL
   ||reports, you'll be able to
   ||pull the descriptions from
   ||the tables.
   ||
   ||It also makes
   ||sure, that all system
   ||internal debit and credit
   ||types appear translated in
   ||the GUI. This now also
   ||includes the administration
   ||pages for managing credit
   ||and debit types. Some
   ||descriptions for discount,
   ||payout, purchase, and void
   ||were missing. These have
   ||now also been added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

--- Comment #7 from Martin Renvoize  ---
Created attachment 150947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150947&action=edit
Bug 23336: Unit tests

This patch adds unit tests for the new checkout availability endpoint
we're going to introduce in this patchset.

Signed-off-by: Helen Oliver 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

--- Comment #8 from Martin Renvoize  ---
Created attachment 150948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150948&action=edit
Bug 23336: Add checkout API's

This patch adds API's to allow for a checkout flow using the RESTful
API.

We add an availability endpoint to check an items current availability
status. The endpoint can be found at `/checkouts/availability` and is
a GET request that requires item_id and patron_id passed as parameters.

We return an availability object that includes blockers, confirms,
warnings and a confirmation token to be used for checkout.

We also add a corresponding checkout method to the `/checkouts` endpoint.
The method accepts a POST request with checkout details including item_id
, patron_id and the confirmation token in the body.

Future work: We should properly migrate CanBookBeIssued into Koha::* and
use that here instead of refering to C4::Circulation.

Signed-off-by: Helen Oliver 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

--- Comment #9 from Martin Renvoize  ---
Created attachment 150949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150949&action=edit
Bug 23336: Fix inconsistent return of AddIssue

AddIssue can on occasion create a renewal instead of a fresh issue and
in such a case we currently return undefined. We should be consistent
and return the existing issue object for the renewal.

Signed-off-by: Helen Oliver 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #91634|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #56 from Jonathan Druart  ---
(In reply to Mengu Yazicioglu from comment #55)
> Hi all,
> 
> Does this patch only change row format of table "tags" ?
> 
> I've manually changed that table but didn't pass the installation phase.
> I've found some other tables like biblioitems,branches,borrowers,etc.

This patch does not modify the DB, it only displays a warning on the about
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663

--- Comment #1 from Jonathan Druart  ---
Created attachment 150950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150950&action=edit
Bug 33663: Don't hide Suggestions link in side navigation when suggestion
preference is disabled

We don't want to depend on the pref for the staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663

--- Comment #2 from Jonathan Druart  ---
Created attachment 150951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150951&action=edit
Bug 33663: Pass 'suggestion' to the OPAC templates only

We don't need it for the staff interface. The previous patch is removing
the only occurrence using it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||29146, 30250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146
[Bug 29146] Default values from the framework should only be applied at
biblio/item creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250
[Bug 30250] Configure when to apply framework defaults when cataloguing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33670


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670
[Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record
suspected
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33670


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670
[Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record
suspected
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||27839


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839
[Bug 27839] koha-worker missing tab-completion in bash
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677
[Bug 33677] Remove --verbose from koha-worker manpage
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

--- Comment #1 from Jonathan Druart  ---
Created attachment 150952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150952&action=edit
Bug 33677: Remove verbose option from koha-worker man

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33695] Audio alerts in the OPAC broken?

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16732
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
It's not implemented, only for sco.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33695

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677

Magnus Enger  changed:

   What|Removed |Added

 Attachment #150952|0   |1
is obsolete||

--- Comment #2 from Magnus Enger  ---
Created attachment 150953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150953&action=edit
Bug 33677: Remove verbose option from koha-worker man

Signed-off-by: Magnus Enger 
No more mention of verbose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

--- Comment #10 from Martin Renvoize  ---
This is a complete rework based on the implementation I did for bug 30979

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||30979


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979
[Bug 30979] Add ability for OPAC users to checkout to themselves
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336
[Bug 23336] Add an API endpoint for issuing an item to a patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33587] "Save" button in modifying "News" entry is not working in Russian localization

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33587

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|NEW |RESOLVED

--- Comment #2 from Jonathan Druart  ---
Confirmed on 22.11.05

Uncaught SyntaxError: missing ) after argument
listadditional-contents.pl:1055:59


It's coming from
  alert(_("Укажите название для "По умолчанию""));


You should surround the string with simple quote. Please fix on pootle at
translate.koha-community.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||12461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
[Bug 12461] Add patron clubs feature
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553
[Bug 33553] Unecessary GetCategories calls in template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150947|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 150954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150954&action=edit
Bug 23336: Unit tests

This patch adds unit tests for the new checkout availability endpoint
we're going to introduce in this patchset.

Signed-off-by: Silvia Meakins 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150948|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 150955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150955&action=edit
Bug 23336: Add checkout API's

This patch adds API's to allow for a checkout flow using the RESTful
API.

We add an availability endpoint to check an items current availability
status. The endpoint can be found at `/checkouts/availability` and is
a GET request that requires item_id and patron_id passed as parameters.

We return an availability object that includes blockers, confirms,
warnings and a confirmation token to be used for checkout.

We also add a corresponding checkout method to the `/checkouts` endpoint.
The method accepts a POST request with checkout details including item_id
, patron_id and the confirmation token in the body.

Future work: We should properly migrate CanBookBeIssued into Koha::* and
use that here instead of refering to C4::Circulation.

Signed-off-by: Silvia Meakins 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150949|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 150956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150956&action=edit
Bug 23336: Fix inconsistent return of AddIssue

AddIssue can on occasion create a renewal instead of a fresh issue and
in such a case we currently return undefined. We should be consistent
and return the existing issue object for the renewal.

Signed-off-by: Silvia Meakins 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33578] Cannot edit patron restriction types

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33578] Cannot edit patron restriction types

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578

--- Comment #5 from Jonathan Druart  ---
Created attachment 150957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150957&action=edit
Bug 33578: Fix patron restriction types edition

When editing an existing patron restriction type you'll always get an error on
saving:

Label is already in use

To test:
* Activate use of patron restriction types
* Edit any of the system types
* Create new ones

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33578] Cannot edit patron restriction types

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||23681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Make patron restrictions user definable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Make patron restrictions user definable

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33578


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578
[Bug 33578] Cannot edit patron restriction types
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150880|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150881|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150882|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667

--- Comment #3 from Katrin Fischer  ---
I think it would be great to at least have some visual clue or not to provide
the option if the holiday is not present in all other branches.

I believe the use case here is:

* add a new holiday
* realize I forgot to set the checkbox
* try to fix it with editing (because it looks like it will work)

So either we make it work... or make it somehow clear it won't and you need to
delete first.

I don't know the code well enough to make a recommendation or helpful comment
in that part. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33709] New: Add override options to checkouts

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709

Bug ID: 33709
   Summary: Add override options to checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
CC: tomasco...@gmail.com
Depends on: 23336

I stripped out the local overrides when creating a checkouts POST route.. we
should add them back in using the accepted x-koha-overrides method.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336
[Bug 23336] Add an API endpoint for issuing an item to a patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||33709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709
[Bug 33709] Add override options to checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33709] Add override options to checkouts

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709

--- Comment #1 from Martin Renvoize  ---
There's things in the original patch I didn't understand so will need a bit of
help unpicking.

* ? inprocess ?
* due_date override
* ignore_reserves
* cancel_reserves
* issue_date
* sipmode

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33710] New: Ignore howto files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710

Bug ID: 33710
   Summary: Ignore howto files
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Related to https://gitlab.com/koha-community/koha-testing-docker/-/issues/378

If we merge it we will want to hide how-to.pl and how-to.ptt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33710] Ignore howto files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710

--- Comment #1 from Jonathan Druart  ---
Created attachment 150958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150958&action=edit
Bug 33710: Ignore how-to related files

Related to https://gitlab.com/koha-community/koha-testing-docker/-/issues/378

If we merge it we will want to hide how-to.pl and how-to.ptt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33710] Ignore howto files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33710] Ignore howto files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33449] Marc Overlay rules screen is broken

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33449

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #3 from Jonathan Druart  ---
Duplicate of bug 5?
Reopen if not.

*** This bug has been marked as a duplicate of bug 5 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-"

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

Jonathan Druart  changed:

   What|Removed |Added

 CC||ruchi.agarwal@avidreaders.i
   ||n

--- Comment #8 from Jonathan Druart  ---
*** Bug 33449 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421

--- Comment #1 from Jonathan Druart  ---
Created attachment 150959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150959&action=edit
Bug 33421: Fix filtering suggestions by status

If the display is by status and a specific status is selected in the
filter, the filter won't have any effects.

Test plan:
Create several suggestions, with different status, for different
libraries.
Use the "display by status" view and filter on a given status
=> Result must be relevant

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33358] Do not use editorconfig for vue files

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358

--- Comment #7 from Paul Derscheid  ---
I really like the idea of a prettierrc file.
Let's do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #150954|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 150960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150960&action=edit
Bug 23336: Unit tests

This patch adds unit tests for the new checkout availability endpoint
we're going to introduce in this patchset.

Signed-off-by: Silvia Meakins 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   5   >