[Koha-bugs] [Bug 35172] Order receiving error

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es

--- Comment #4 from Hugo Agud  ---
Good morning, I have suffer the same issue... 

I have checked that this only happens in some orders, then it must be some
metadata issue (my point of view)

I have dumped database and restored in koha 23.11 and worked fine...caming back
to 22.05

I have checked logs in koha 22.05.*


[2024/01/05 01:18:13] [ERROR] GET /api/v1/acquisitions/orders: unhandled
excepti
  on (Mojo::Exception)<>
Koha::REST::Plugin::Exceptions::__ANON 
 __
/usr/share/koha/lib/Koha/REST/Plugin/Exceptions.pm (73)

I suspect it is an issue with metadata of the orders, checimg the code

sub to_api {
my ($self, $args) = @_;

my $response = $self->SUPER::to_api($args);
my $biblioitem = $self->biblioitem;

I suspect it could be the biblioitem data, not presented in some recordS?

I have added a else condition to ignore if there is no biblioitem


I have edited the code and add a log warn [2024/01/05 01:43:10] [WARN] Biblio
with biblionumber 13250 does not have a valid biblioitem object at
/usr/share/koha/lib/Koha/Biblio.pm line 1108.

And it works... I can confirm that there is no biblioitem with that
biblionumber.. then it is a metadata issue

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

--- Comment #19 from Julian Maurice  ---
Should we add a followup here or on a new bug report ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #18 from Jonathan Druart  ---
t/db_dependent/selenium/00-onboarding.t is failing

I am seeing this in the logs:
   
DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_kohadev.plugin_data'
doesn't exist at /kohadevbox/koha/Koha/Plugins.pm line 122  
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
DBIx::Class::Exception::throw('DBIx::Class::Exception', 'Table
\'koha_kohadev.plugin_data\' doesn\'t exist', 0) called at
/usr/share/perl5/DBIx/Class/Schema.pm line 1118
  
DBIx::Class::Schema::throw_exception('Koha::Schema=HASH(0x55fc8aec4730)',
'Table \'koha_kohadev.plugin_data\' doesn\'t exist') called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Michal Dudzik  changed:

   What|Removed |Added

 CC||dudzikmic...@wp.pl
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #159656|0   |1
is obsolete||

--- Comment #2 from PTFS Europe Sandboxes  ---
Created attachment 160564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160564=edit
Bug 35514: Fix costs update when adding multiple items from staged file

Test plan:

1) Stage a file with records
2) Create a basket and add order line from imported records to go on
   neworderempty.pl
3) Choose to add one item and repeat the operation
4) See on form that the total cost is updated without update vendor
   price
5) Now add multiple items, for example, "2" you will see that the total
   cost is not updated and if you save "0" price will be set
6) Apply this patch and repeat step 5

Signed-off-by: Michał Dudzik 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35263] Cannot update patron categories

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35556


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556
[Bug 35556] selenium/administration_tasks.t failing if too many patron
categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35556] selenium/administration_tasks.t failing if too many patron categories

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 Depends on||35263

--- Comment #5 from Jonathan Druart  ---
It's not needed on 23.05 actually.

Bug 35263 introduced some additional code in this block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263
[Bug 35263] Cannot update patron categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

--- Comment #13 from Jonathan Druart  ---
you have 500 in conf and 5000 in pm, is that expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506

--- Comment #19 from Jonathan Druart  ---
(In reply to Victor Grousset/tuxayo from comment #18)
> So it's almost done. Questions:
> 1. What is DT_delay for?

We want to make sure the AJAX request is there. In some cases (see bug 35284),
the wait_for_ajax was called but the AJAX request was not triggered yet, so we
didn't wait for it to finished.

> 2. I only though of it just now: instead of having the flag
> window._pageFullyReady, should the problematic buttons be hidden in the
> HTML? (and maybe have a dummy button with a loading icon in place to show
> the user that stuff it loading) And then the stuff in $(document).ready()
> makes them visible after setting the onclick callback. And the test just
> waits for the button to be visible instead of the flag to be set.

We should not need more than wait_for_ajax here IMO. If it takes more than 10
sec then there is something wrong somewhere else. We could extend the delay
specifically for this call.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430

Felicity Brown  changed:

   What|Removed |Added

 CC||felicity.brown@montgomeryco
   ||untymd.gov

--- Comment #3 from Felicity Brown  ---
Would it be possible to have batch changes made by queuing them, like we have
for batch item modification? So we could continue to work on other purchase
suggestions while the last set of edits are updating? I find it grinds
particularly badly when I'm trying to update several records from a page to
assign a manager to them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
This does fix the issue, and I have signed off.

However, some comments - not sure how hard these are to do or whether it
depends on the ILL plugin (I'm assuming this is the case):

1. If the "Destination library" is not selected, then the message at the top
says: "Please Note: Branch is a mandatory field.". In my view the error should
match the UI, that is, instead of "Branch" it should say "Destination library
is required"

2. The normal UI for forms in the OPAC (from what I can see) is to have
"Required" under the field name, and then a message if mandatory fields are not
completed. I assume that this depends on how the ILL plugin works/coded though.

Testing notes (using KTD):

1. Make the ILL request using the OPAC!
   . Go to the OPAC
   . Log in as a patron
   . Make the request using the "Interlibrary loan requests" tab/section

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

David Nind  changed:

   What|Removed |Added

 Attachment #160456|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 160563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160563=edit
Bug 35685: Fix after creation actions

Test plan:

1) Install FreeForm and enable ILLModule, run:
  bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Configure ILLModuleDisclaimerByType, visit:
 
/cgi-bin/koha/admin/preferences.pl?tab==search=ILLModuleDisclaimerByType
  Click "edit" and paste the example code into the sys pref value
3) Create a new OPAC ILL request, visit:
  /cgi-bin/koha/opac-illrequests.pl?method=create=FreeForm
4) Dont put a type or branch, click 'Create', on the next screen click 'Submit'
5) Notice it explodes
6) Apply patch and repeat. It no longer explodes and now shows an error
message.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Suzanne  changed:

   What|Removed |Added

 CC||smhodson123ex...@yahoo.com

--- Comment #52 from Suzanne  ---
Wow! There has been a lot of work on this! We are interested in being able to
have the patron record show "Preferred Name" in quotation marks in the first
position followed by first and middle names and then last name. So, for
example, it might show as "Sammy" Suzanne Michelle Hodson, with everything
being searchable and all showing up on the patron record side bar. My idea
would be to let registering patrons fill in the first and middle name field and
also the preferred name field and have them show up in that order on Koha, or
let libraries choose how they would like the names to show up or whether to
have them hidden, if that is possible. Thanks for the great efforts on this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506

--- Comment #18 from Victor Grousset/tuxayo  ---
> Created attachment
> Just a guess, we should wait for the ajax response before looking for
> the element in the table.

Wait, I'm really on this! Yes, that's one of things, at this same place. What
is DT_delay for?


(In reply to Jonathan Druart from comment #16)
> (In reply to Victor Grousset/tuxayo from comment #14)
> > Found some tactics that seem effective on test 'Encoding in session
> > variables'
> > and test 'Display circulation table correctly'
> 
> Which ones?

https://gitlab.com/tuxayo/Koha/-/commits/bug-35506-selenium-regressions.t-failing-randomly

Here is a summary of what my WIP patch has:
- After asking in Selenium and JavaScript chats, there must be added a way to
know if a button is ready to be clicked on. Because $(document).ready() content
is long enough so that Selenium can be faster to click on the button before it
has it's callback set. The proper thing is something telling the users that the
page is still loading or visibly showing that the button isn't ready. For lack
of time to go for something on the UI side with a lot of uncertainties, setting
a flag at the end of $(document).ready() is one line way to cover a whole page
regardless of how many problematic buttons there are.
So the idea is to set in the JS window._pageFullyReady and having the tests
wait (with wait_for_page_fully_ready()) for it like wait_for_ajax does. And
that can be used on other page by adding the same flag in their
$(document).ready() callback.
- Next, so yes wait_for_ajax is needed, but in the +2000 runs I did, dozens of
times I got way more than 10 sec wait (noted in the comments next to the
calls). For this I had to make max_retries a variable and not a constant so I
started doing a getter/setter and messed things up with confusing various ways
to do it in Perl and finally noticed that we had __PACKAGE__->mk_accessors ^^"
- A weird thing about having to reload the checkouts page because it's not
refreshed after doing a checkout! (more details in the code comment)
- Needing wait_for_ajax to output a stack trace (can't even know which call
fail otherwise) and take a screenshot on timeout

So it's almost done. Questions:
1. What is DT_delay for?
2. I only though of it just now: instead of having the flag
window._pageFullyReady, should the problematic buttons be hidden in the HTML?
(and maybe have a dummy button with a loading icon in place to show the user
that stuff it loading) And then the stuff in $(document).ready() makes them
visible after setting the onclick callback. And the test just waits for the
button to be visible instead of the flag to be set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #131582|0   |1
is obsolete||

--- Comment #9 from Aleisha Amohia  ---
Comment on attachment 131582
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131582
Bug 30260: [GLOBAL REPO] Implement is_indexer_working check

This patch has now been pushed to the global repo, so the other patch can be
pushed to Koha.

https://git.koha-community.org/Koha-community/global/commit/72308768457017c3ff48543c9a52295a064a7253

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

--- Comment #12 from David Nind  ---
Here are the list of jobs from testing using a freshly started KTD:

-1316 - Before patch, for both item modification and authority 
record changes
1317-1318 - After patch, no chunking, item modifications
1319-2632 - After patch, no chunking, authority record changes
==> no change (as expected) to number of jobs after patch
applied and no chunking set
2633-2635 - After patch, chunking (250), item modifications
. 1 job for batch item modifications, 2 jobs for elastic search
  updates (1 batch of 250 and 1 batch of 161)
2636-3955 - After patch, chunking (250), authority record changes
. 2636 - Batch authority record modification
. 2637-3948 - Elasticsearch index updates for 1,312 individual
  bibliographic record updates
. 3949-3955 - 6 batches of 250, 1 batch of 206

I'm assuming this is what is expected, feel free to change the bug status if it
isn't.


Testing notes:

1. I tested using ES8 (ktd --es8 up).

2. For the modification of bibliographic records, I updated the 'z - Public
note' with some text.

3. For the modification of authority records, I had a rule to add some text to
680$i subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Attachment #160532|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 160562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160562=edit
Bug 35086: Tidy tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Attachment #160531|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 160561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160561=edit
Bug 35086: Also split chunks when indexing from background job

The es background indexer is designed to combine background jobs when started
based on the 'batch_size' option.

While this is helpful for combining individual updates, it can be problematic
when there are several large batch modifications, or when worker has stopped
and is restarted.

This patch uses the same logic as in the indexer to split the chunks that are
sent directly for indexing.

To test:
1 - Follow test plan on previous patch
2 - Confirm items are correctly indexed and jobs marked

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Attachment #160530|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 160560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160560=edit
Bug 35086: Add chunk_size option to elasticsearch configuration

Whne performing batch operations we can send a large numebr of records for
reindexing at once.
Currently this can create requetss that are too large for Elasticsearch to
process. We need
to break these requests into chunks/

This patch adds a chunk_size configuration to the elasticsearch stanza in
koha-conf.xml

If blank we default to 5000.

To test:
0 - Have Koha using Elasticsearch
1 - Create and download a report of all barcodes:
SELECT barcode FROM items
2 - Batch modify these items
3 - Note a single ESindexing job is created
4 - Create and download a report of all authority ids:
SELECT auth_header.authid FROM auth_header
5 - Setup a marc modification template, and batch modify all the authorities
6 - Again note a single ES backgorund job is created
7 - Apply patch
8 - Repeat the modifications above - you still get a single job
9 - Edit koha-conf.xml and add 250 to elasticsearch
stanza
10 - Repeat modifications - you now get several background ES jobs
11 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35705] Add option to force patrons to receive digested notices

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35705

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35705] New: Add option to force patrons to receive digested notices

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35705

Bug ID: 35705
   Summary: Add option to force patrons to receive digested
notices
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org

We'd like to require all of our patrons who elect to receive due, pre-due, or
hold available notices to receive the digested versions of those notices. It's
currently possible to use jQuery to force the "Digest Only" box to be checked
on patron edits, but it'd be better to have this defined in a system preference
or something more formal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324

Lisette Scheer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35704

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35704] Parent and child itemtype hold limits not enforced as expected

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704

Lisette Scheer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30324

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35704] New: Parent and child itemtype hold limits not enforced as expected

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704

Bug ID: 35704
   Summary: Parent and child itemtype hold limits not enforced as
expected
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Similar to bug 30324, the hold limits aren't enforced for parent/child item
types. 

A parent limit doesn't seem to matter at all in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #35 from Caroline Cyr La Rose  ---
There is nothing to add to the manual for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35557] LoadResultsCovers is not used (staff)

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35557

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Lucas Gass  changed:

   What|Removed |Added

 Depends on|35547   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547
[Bug 35547] When using "Add to a list" button with more than 10 lists, "staff
only" does not show up
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547

Lucas Gass  changed:

   What|Removed |Added

 Blocks|33722   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722
[Bug 33722] Cannot see existing public lists from
virtualshelves/addbybiblionumber.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #9 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35547] When using "Add to a list" button with more than 10 lists, "staff only" does not show up

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
*** Bug 33722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #14 from Lucas Gass  ---


*** This bug has been marked as a duplicate of bug 35547 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35619] Change password form in patron account has misaligned validation errors

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #6 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527
Bug 35527 depends on bug 35529, which changed state.

Bug 35529 Summary: Avoid 'click' for links in library administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Lucas Gass  ---
Doesn't apply clean to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Needs documenting

--- Comment #34 from Lucas Gass  ---
Missing dependencies for 23.05.08, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34644] Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34644

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #19 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35600] Prevent checkouts table to flicker

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35600

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #11 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35592] Missing closing div tag in bookings alert in circulation.tt

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #8 from Lucas Gass  ---
Missing dependencies for 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #27 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Nick Clemens  changed:

   What|Removed |Added

 Attachment #160551|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 160559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160559=edit
Bug 22567: Add transfer details to stockrotation page

This patch adds any pending/current transfer details into the
stockrotation item management page.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100

--- Comment #5 from Nick Clemens  ---
To recreate:
1 - Create a rota, CPL->FFL->IPT
2 - Add an item from Midway to the rota
3 - perl misc/cronjobs/stockrotation.pl -x
4 - Check the db - you have a stock roation transfer to CPL
5 - Place a hold for pickup at Union
6 - Check the item in at midway, confirm the hold and transfer
7 - Note there are 2 transfers in the DB, one for the and one for stock
rotation

I am signing this off as it does fix the problem, there are 2 issues to note
though:
 - The pop for the holds transfer correctly shows where to transfer the item,
however, it shows the reason as 'StockRotation' when it should be 'Reserve'
 - After the transfer is created for the hold, 2 transfers exist - the original
stock rotation, and the hold transfer. The detail page seems to look at the
earliest, so the item shows it is in transit to the rotation branch, rather
than the branch of the request we are trying to fill - this will cause
confusion and delay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #55 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #8 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100

--- Comment #4 from Nick Clemens  ---
Created attachment 160558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160558=edit
Bug 35100: Prevent StockrotationAdvance transfers from being cancelled

ModItemTransfer is still very heavy handed and outright overrules
existing transfers in the queue.

For StockrotationAdvance transfers it's important that they remain in
the queue to get actioned later, even if a higher precident transfer is
actions in the interim.

This patch adds a clause to the cancellation call within
request_transfer such that StockrationAdvance transfers are left in tact
for the next time the item is checked in.

Test plan
1) Item is added to stock rotation
2) The cronjob creates a 'StockRotationAdvance' transfer
3) The item is checked in, which initiates the transfer, however, a hold is
triggered
4) The hold is confirmed, which replaces the StockRotationAdvance
5) The item is checked out
6) The item is checked in, which initiates the transfer again
6) The item is checked in at it's destination and the StockrotationAdvance
transfer
   has the proper date arrived date set.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100

Nick Clemens  changed:

   What|Removed |Added

 Attachment #160514|0   |1
is obsolete||
 Attachment #160515|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 160557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160557=edit
Bug 35100: Unit tests

This patch adds a unit test to ensure StockrotationAdvance transfers are
not cancelled from request_transfer when called with 'replace'.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #30 from Lucas Gass  ---
Doesn't apply clean to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35405] MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202.

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #16 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
Please rebase this for 23.05.x if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35574] Bookings page should require only manage_bookings permissions

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35574

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting
 CC||lu...@bywatersolutions.com

--- Comment #24 from Lucas Gass  ---
Missing dependencies for 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35413] Terminology: differentiate issues for vendor issues and serials

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #10 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527
Bug 35527 depends on bug 35528, which changed state.

Bug 35528 Summary: Avoid 'click' for links in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #6 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Lucas Gass  ---
Doesn't apply cleanly in 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED

--- Comment #8 from Lucas Gass  ---
Not needed in 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Lucas Gass  ---
Not needed in 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting
 CC||lu...@bywatersolutions.com

--- Comment #35 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, will not backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35507] Fix handling plugins in unit tests causing random failures on Jenkins

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #69 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport. If needed please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

--- Comment #9 from Alex Buckley  ---
(In reply to Nick Clemens from comment #7)
> (In reply to Alex Buckley from comment #6)
> > Hi Nick, 
> > 
> > There is one difference between this and bug 35293 (the patchset I wrote)
> > and that is 35293 re-adds the reference to ONLYMESSAGE into the
> > UpdateNotForLoanStatusOnCheckin system preference which was also lost
> > between bug 30407 and bug 25560 :
> > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361
> > 
> > Would you like me to copy that patch over to your bug report here?
> > 
> > Thanks,
> > Alex
> 
> Hi Alex, either way works, you could also just copy my unit test over to the
> other and then mark them duplicate. I didn't see yours initially because the
> depends on wasn't marked :-)

Thanks so much Nick for making those changes! 

Apologies for not marking the depends on for bug 35293

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35684] Koha XSLT material type icons documentation needs updating

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35684

--- Comment #2 from Esther Melander  ---
Some additional documentation is needed to also explain how to trigger Article,
and Sets Material Type.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35293


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293
[Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template
changes to bug 25560
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35293


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293
[Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template
changes to bug 25560
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

Nick Clemens  changed:

   What|Removed |Added

 Depends on||30407, 25560


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560
[Bug 25560] Define itemtype specific rules in the
UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407
[Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #19 from Nick Clemens  ---
*** Bug 35692 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Signed Off  |RESOLVED

--- Comment #8 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 35293 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

--- Comment #18 from Nick Clemens  ---
Created attachment 160556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160556=edit
Bug 35293: Unit test

Signed-off-by: David Nind 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

--- Comment #17 from Nick Clemens  ---
Created attachment 160555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160555=edit
Bug 35293: (follow-up) Handle all rules as well

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

--- Comment #16 from Nick Clemens  ---
Created attachment 160554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160554=edit
Bug 35293: Re-implement bug 30407 functionality

To test:
1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride
system preference to 'Allow'
2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the
formatting and indentation is important to keep):

BK:
 -1: ONLYMESSAGE

3. Check a book item out for patron.
4. Check book item in.
=> Description of notforloan status should be displayed under 'Check in
message'.
=> Confirm notforloan status HAS changed.

5. Apply patch and update database if needed
6. Set book items notforloan status as -1 (or create new one)
7. Check book item out for patron.
8. Check book item in.
=> Description of notforloan status should be displayed under 'Check in
message'.
=> Confirm notforloan status HAS NOT changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: Anneli Österman 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

Nick Clemens  changed:

   What|Removed |Added

 Attachment #160361|0   |1
is obsolete||
 Attachment #160362|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 160553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160553=edit
Bug 35293: Add ONLYMESSAGE back into UpdateNotForLoanStatusOnCheckin syspref
description

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: Anneli Österman 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Nick Clemens  changed:

   What|Removed |Added

 Attachment #160002|0   |1
is obsolete||

--- Comment #39 from Nick Clemens  ---
Created attachment 160552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160552=edit
Bug 33960: Tidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #8 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35468] Bookings permission mismatch

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #27 from Lucas Gass  ---
Dependencies missing for 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35556] selenium/administration_tasks.t failing if too many patron categories

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35556

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #4 from Lucas Gass  ---
Jonathan,

It looks like this code already exists on 23.05? But how could that be? Please
advise. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35694] Give pages the option to be a page or modal

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694

--- Comment #2 from Christopher Brannon  ---
You could, if you want the modal on top of that page.  But if you want the
modal to pop up on some pre-existing page, it would need a little more work. 
Like if I was going to add some information that pops up from the Circulation
page or Cataloging page, where I don't want to navigate away, and instead just
have that information come up wherever that link was, that would be a little
more complex.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #14 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 CC||lu...@bywatersolutions.com

--- Comment #41 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.07.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #38 from Nick Clemens  ---
(In reply to Owen Leonard from comment #37)
> I'm getting a couple warnings and a fail from the qa tool. Can you check?

You can ignore the fail, the warnings should be cleared by tidy patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...)

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #3 from Katrin Fischer  ---
(In reply to Aude Charillon from comment #2)
> I've seen the term "Linked accounts" used elsewhere and it works.
> 
> I quite like "relatives" because I tend to interpret it in a wider sense -
> people who have some relation to each other - rather than as "blood
> relatives". But a native English speaker may have a different point of view!

Hi Aude, that's interesting! I didn't look at it like that, as I automatically
"translate" it to another term in German. Maybe we should consider using a
different German translation :) I'd also be interested to get some native
speaker opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

--- Comment #7 from Nick Clemens  ---
(In reply to Alex Buckley from comment #6)
> Hi Nick, 
> 
> There is one difference between this and bug 35293 (the patchset I wrote)
> and that is 35293 re-adds the reference to ONLYMESSAGE into the
> UpdateNotForLoanStatusOnCheckin system preference which was also lost
> between bug 30407 and bug 25560 :
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361
> 
> Would you like me to copy that patch over to your bug report here?
> 
> Thanks,
> Alex

Hi Alex, either way works, you could also just copy my unit test over to the
other and then mark them duplicate. I didn't see yours initially because the
depends on wasn't marked :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25446] Terminology: Replace relatives by other term? (family members, group members...)

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25446

--- Comment #2 from Aude Charillon  ---
I've seen the term "Linked accounts" used elsewhere and it works.

I quite like "relatives" because I tend to interpret it in a wider sense -
people who have some relation to each other - rather than as "blood relatives".
But a native English speaker may have a different point of view!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35673] A booking impacts due date of other checked out items

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35673

Esther Melander  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #3 from Esther Melander  ---
After further testing, it appears the behavior I was seeing was due to a
library specific circulation rule with 0 days for loan length. Removing that
rule removed the behavior. Marking this as resolved for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Martin Renvoize  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Martin Renvoize  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >