[Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from David Cook --- There's a few things here: 1. We do need the referrer for the staff interface too, since people might be using bookmarks, have expired sessions when clicking on an old search result, manually going to a URL written by hand, etc. 2. The session variable is different between the googleopenidconnect and the REST client. I think it'd be best to use the same meaningful name. (I also think referer as used in the REST client is too generic. That could cause problems down the line if we started tracking refer for other reasons. I think the one you used for googleopenidconnect could work (ie "auth-refer-uri"), so I think just harmonize those. 3. It would make more sense to validate the referrer input before setting it as a session variable. 4. Instead of "if (defined $referrer_url) && ($referrer_url ne '')", I think we could just do (if $referrer_url) in Perl. This syntax reminds me more of Python/Ruby. -- Overall, it's looking good, and I'm really looking forward to having this feature in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36304] Add ability to have an external list of trusted proxies, for services such as CloudFlare.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36304 David Cook changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #5 from David Cook --- (In reply to Nicholas van Oudtshoorn from comment #4) > Created attachment 163973 [details] [review] > Support for externally updated proxy lists > > Thanks for the feedback, David! Thanks for being receptive! > It makes sense to move it into the koha-conf.xml file, and this updated > patch has done so. It includes a sample bash script that can be used to keep > an external list file up to date. This can also easily be extended to > automatically update other providers, hence I have taken away the cloudflare > name, although cloudflare is referenced in a comment in koha-conf.xml You'll want to add the config block to "debian/templates/koha-conf-site.xml.in" as well. (I think it could be worthwhile to say in the comment that the list is a plain-text with an IP (range) per line, but not a blocker.) > Currently, RealIP was re-generating the trusted_proxies list on every call > to get_real_ip. This patch also uses Koha's caching system to prevent > reloading from the config file and from the external list on every call, > which should speed things up just a little bit. Oh yikes. I remember reading through this recently, and I saw "$self->trusted_proxy()" in prepare_app(), and that list is passed to get_real_ip(), so I figured it was just determining the list at startup time, but it looks like it's unused currently and it really is fetching it on every call! Double yikes... I think we'd want to split the changes here. I think a new ticket to fix RealIP.pm to use the $self->trusted_proxy() set up in "prepare_app", and we could also set that up to use the cache to further improve performance. The change to RealIP.pm looks like it has some copy/pasted code. I'd suggest adding the list IPs to @trusted_proxies() rather than having 2 separate blocks calling Net::Netmask->new2(). > The sample bash script will restart koha-common if it is running, and also > clear the caches of all koha-instances. Since this one is Cloudflare specific, I think it would be worthwhile including that in the script name (e.g. "update_cloudflare_proxies_list.sh). I think it might be overkill restarting the whole koha-common service, since we really just need to restart the Plack in this case. You'd want to clear the cache first before running koha-plack --reload/--restart as well I believe. -- Overall, I think it's looking pretty good though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548 --- Comment #2 from Aleisha Amohia --- *** Bug 30260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 Aleisha Amohia changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #10 from Aleisha Amohia --- I don't think we need this fix anymore, with a combination of the following fixes instead: * Bug 36548 (the bug solved here was the believed cause for this fix) * https://git.koha-community.org/Koha-community/global/commit/704060f4ff5497b545b9d807e2ea57c5cc7a85b9 *** This bug has been marked as a duplicate of bug 36548 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548 --- Comment #1 from Aleisha Amohia --- Created attachment 164525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164525=edit Bug 36548: koha-zebra should fix ownership on /var/run/koha/instancename files This patch ensures the /var/run/koha/instancename/* files are owned by instancename-koha so zebra can start and stop as expected. To test, confirm that: 1. starting and stopping zebra using `koha-zebra` works as expected 2. all files in /var/run/koha/instancename/ are owned by instancename-koha Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36550] New: koha-elasticsearch commit default should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Bug ID: 36550 Summary: koha-elasticsearch commit default should be configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au It can be easy to forget the --commit option when running koha-elasticsearch especially across teams. It would be good if we could specify a different default value (rather than 5000) say in /etc/default/koha-common for instance. On a system with memory restrictions, 5000 is way too high, and will lead to incomplete ES indexing, which is quite bothersome to rectify after the fact. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36549] New: es_indexer_daemon.pl leaks memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36549 Bug ID: 36549 Summary: es_indexer_daemon.pl leaks memory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org background_jobs_worker.pl runs its tasks in child processes which return their memory to the OS when they complete. es_indexer_daemon.pl runs everything in itself which means if it needs to allocate a large amount of memory for an indexing job, it will hold on to that memory allocation for its entire process life. -- I've got an es_indexer_daemon.pl which is using over 1GB of memory. Once it's done with its indexing activity, I'm going to restart it to get it back down to a more reasonable amount of allocated memory. I reckon we should be forking off child processes to do the worker. We don't need many. We just need 1 that is short lived so that it can return the memory back to the OS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36548] New: koha-zebra should fix ownership on /var/run/koha/instancename files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548 Bug ID: 36548 Summary: koha-zebra should fix ownership on /var/run/koha/instancename files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com koha-zebra is unable to stop and start a zebra process if ownership on /var/run/koha/instancename is wrong it already checks permissions on the relevant log files, it should also check on this directory -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36509] Add option to search authority records by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36509 --- Comment #1 from Aleisha Amohia --- Created attachment 164524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164524=edit [WIP] Bug 36509: Add Search ID tab to authorities search on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36547] Add 'Checked out on' column to Overdues table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36547 --- Comment #1 from Laura Escamilla --- Created attachment 164523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164523=edit Bug 36547: Added checked out column to Overdue table To test: 1. Make sure you have some overdue checkouts in your installation. 2. Go to Circulation > Overdues 3. Verify the ‘Checked out on’ column is visible by default, but can be hidden using the column settings 4. Verify that the export to CSV via the link on top of the table and includes the ‘Checked out on’ field. 5. Sign off and have an incredible day :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36547] Add 'Checked out on' column to Overdues table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36547 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36137] update_totalissues.pl should always skip_holds_queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36137
Emily Lamancusa changed:
What|Removed |Added
CC||emily.lamancusa@montgomeryc
||ountymd.gov
QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
|y.org |ountymd.gov
Status|Signed Off |Failed QA
--- Comment #4 from Emily Lamancusa ---
(In reply to Lucas Gass from comment #1)
> I don't see why an if/else is needed here. We can just pass the value
> $incremental to UpdateTotalIssues
>
> -my $ret;
> -if ( $incremental && $totalissues > 0 ) {
> -$ret = UpdateTotalIssues( $biblionumber, $totalissues );
> -}
> -else {
> -$ret = UpdateTotalIssues( $biblionumber, 0, $totalissues );
> -}
>
> Instead this should work just as good:
>
> +my $ret = UpdateTotalIssues( $biblionumber, $incremental,
> $totalissues, 1 );
The if/else is necessary. In the if branch, $totalissues is being passed as the
$increase parameter (i.e. the amount to increment the existing value by). In
the else branch, $totalissues is being passed as the $value parameter (i.e. the
value to overwrite the existing value).
Providing a defined $value parameter causes UpdateTotalIssues to ignore the
$increment parameter, so if the --incremental flag is set, the third parameter
needs to be undef. Otherwise UpdateTotalIssues will overwrite the existing
value instead of incrementing it as desired.
That being said...if the --incremental flag is set, but $totalissues is 0 for a
particular biblio, the else clause will still trigger, and wipe out the
totalissues value for that biblio! So the if/else isn't correct to begin with -
those conditions need to be checked separately.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36547] New: Add 'Checked out on' column to Overdues table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36547 Bug ID: 36547 Summary: Add 'Checked out on' column to Overdues table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: laura.escami...@bywatersolutions.com Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23705 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31791 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31109] Add ability to lock bibliographic record or alert staff when another user is in the same bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23705 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31109 CC||vic...@tuxayo.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 ByWater Sandboxes changed: What|Removed |Added Attachment #164507|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 164522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164522=edit Bug 33832: Allow updating username without changing password on member-password.pl This patch updates the change password page on the staff interface to allow for changing the patron's username without changing the password. If the new password is an empty string we can skip setting the patron's password and sending the new password to the template. Test plan: 1. From a patron record tool bar click 'Change password' 2. Notice that if you try to change the user's name without also changing the password the page just reloads and nothing happens 3. Apply patch and restart_all 4. From the patron record click 'Change password' again 5. Set the user's new username and password eg. '1234Abc' and click 'Save' 6. Confirm that you can log in to the OPAC with the user 7. Return to the patron record and click 'Change password' again 8. This time change just the 'New username field' and click 'Save' 6. Notice that the username is updated 7. Confirm you can log into the OPAC with the new username and the original password '1234Abcd' 8. Make sure that the change password form still validates passwords for length and matching errors etc Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 --- Comment #12 from Hammat wele --- Created attachment 164521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164521=edit Bug 33237: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36545] Use select2 in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #2 from Michaela Sieber --- (In reply to Magnus Enger from comment #1) > What are the advantages of this new approach over the old one? The multiselect option is more intuitive, you can start typing and only relevant values are displayed in the drop down, you have less scrolling,... And all other advantages of select2 :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #43 from Julian Maurice --- It looks like CSRF validation does not work: if I manually change the token in the deletion form and then try to delete the corresponding OAI repository, the repository is deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #1 from Julian Maurice --- Created attachment 164520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164520=edit Flamegraph of debian/templates/plack.psgi I also noticed that startup time was really long and ran debian/templates/plack.psgi with Devel::NYTProf to see what was happening. And indeed the YAML parsing/validation is what takes the most time (95% of the startup is spent into Koha::REST::V1::startup Here's the flamegraph to give an idea of the problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for API searches across joined extended attributes when several terms are passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 --- Comment #26 from Pedro Amorim --- (In reply to Jonathan Druart from comment #9) > (In reply to Pedro Amorim from comment #6) > > Joubu can you please rebase your test patch? > > Done. Sorry Joubu, can you please rebase your test patch again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa changed: What|Removed |Added QA Contact|emily.lamancusa@montgomeryc |testo...@bugs.koha-communit |ountymd.gov |y.org Assignee|stalkern...@gmail.com |emily.lamancusa@montgomeryc ||ountymd.gov Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for API searches across joined extended attributes when several terms are passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Pedro Amorim changed: What|Removed |Added Attachment #161528|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164510|0 |1 is obsolete|| --- Comment #27 from Matthias Le Gac --- Created attachment 164519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164519=edit Bug 9762: Test CanBookBeIssued.pm Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162097|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize --- Created attachment 164518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164518=edit Bug 6796: (follow-up) QA test tool fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162096|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize --- Created attachment 164517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164517=edit Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162095|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 164516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164516=edit Bug 6796: Don't add a day if hourly loan period pushes due date If ConsiderLibraryHoursWhenIssuing is set to shorten the loan period to the closing time, if the loan period initially pushes the due date to the following day, the day still gets added when calculating the due date. We simply need to hardcode the due time here as the due day is the same as the issue day. We only need to calculate a due date if ConsiderLibraryHoursWhenIssuing is set to extend the loan period to the next opening day, as we'll need to consider holidays/closed days. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162094|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 164515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164515=edit Bug 6796: Fix saving of libraries and tests Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162093|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 164514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164514=edit Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] New: API yaml validation is slow.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546
Bug ID: 36546
Summary: API yaml validation is slow.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: didier.gauthe...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
From an strace it can take up to 6 sec on our servers.
Ex:
First stat:
07:48:46.941069 (+ 0.000129) brk(0x5641224ad000) = 0x5641224ad000
<0.18>
07:48:46.941340 (+ 0.15)
stat("/home/koha/src/api/v1/swagger/swagger.yaml", {st_mode=S_IFREG|0644,
st_size=30696, ...}) = 0 <0.10>
...
last one
07:48:53.453980 (+ 0.30)
lstat("/home/koha/src/api/v1/swagger/swagger.yaml", {st_mode=S_IFREG|0644,
st_size=30696, ...}) = 0 <0.15>
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162092|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 164513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164513=edit Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursInCirculation' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursInCirculation. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162091|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 164512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164512=edit Bug 6796: ConsiderLibraryHoursInCirculation system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Attachment #162090|0 |1 is obsolete|| --- Comment #125 from Martin Renvoize --- Created attachment 164511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164511=edit Bug 6796: Add library_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Philip Orr changed: What|Removed |Added CC||philip@lmscloud.de Documentation||Philip Orr contact|| --- Comment #47 from Philip Orr --- Documenting this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #26 from Matthias Le Gac --- Rebase to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164426|0 |1 is obsolete|| --- Comment #25 from Matthias Le Gac --- Created attachment 164510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164510=edit Bug 9762: Test CanBookBeIssued.pm To test: 1) Apply the patch 2) run prove t/db_dependent/Circulation/CanBookBeIssued.t --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164387|0 |1 is obsolete|| --- Comment #24 from Matthias Le Gac --- Created attachment 164509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164509=edit Bug 9762: Change how to pass the param -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164068|0 |1 is obsolete|| --- Comment #23 from Matthias Le Gac --- Created attachment 164508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164508=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Pedro Amorim changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #41 from Pedro Amorim --- Update to the test plan: When installing the pluginBackend, please install version 2.0.5 here: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 It contains the latest CSRF compatibility changes required to create an ILL request on master for this backend. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Brendan Lawlor changed: What|Removed |Added Attachment #164506|0 |1 is obsolete|| --- Comment #5 from Brendan Lawlor --- Created attachment 164507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164507=edit Bug 33832: Allow updating username without changing password on member-password.pl This patch updates the change password page on the staff interface to allow for changing the patron's username without changing the password. If the new password is an empty string we can skip setting the patron's password and sending the new password to the template. Test plan: 1. From a patron record tool bar click 'Change password' 2. Notice that if you try to change the user's name without also changing the password the page just reloads and nothing happens 3. Apply patch and restart_all 4. From the patron record click 'Change password' again 5. Set the user's new username and password eg. '1234Abc' and click 'Save' 6. Confirm that you can log in to the OPAC with the user 7. Return to the patron record and click 'Change password' again 8. This time change just the 'New username field' and click 'Save' 6. Notice that the username is updated 7. Confirm you can log into the OPAC with the new username and the original password '1234Abcd' 8. Make sure that the change password form still validates passwords for length and matching errors etc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36477] We should use JSDoc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36477 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #42 from Julian Maurice --- Side note: Koha::OAI::Client::Harvester uses cronlogaction, which makes it tied to the script using it (misc/cronjobs/harvest_oai.pl). As this script is the only way to use the harvester, I think it's okay to keep it like that for now, but it will have to be changed if we want to use the harvester elsewhere (a background job for instance) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Brendan Lawlor changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org |ity.org | CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 --- Comment #4 from Brendan Lawlor --- Created attachment 164506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164506=edit Bug 33832: Allow updating username without changing password on member-password.pl This patch updates the change password page on the staff interface to allow for changing the patron's username without changing the password. If the new password is an empty string we can skip setting the patron's password and sending the new password to the template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Brendan Lawlor changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
--- Comment #41 from Julian Maurice ---
Comment on attachment 162693
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162693
Bug 35659: OAI Harvester
Review of attachment 162693:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=35659=162693)
-
Overall this is working really well. OAI repositories mentioned in the test
plan can take some time to respond (or fail with a timeout) but this is handled
well.
However, there are some minor things to fix (see the rest of the review).
::: Koha/OAI/Client/Harvester.pm
@@ +79,5 @@
> +C<$force> force harvesting (ignore records datestamps)
> +
> +=cut
> +
> +sub new {
The `new` method doesn't instantiate an object. Instead it sets global
variables and returns the class name.
I think it's confusing, as all other `new` methods in Koha instantiate an
object.
@@ +142,5 @@
> +
> +if ($days) {
> +
> +# Change this to -mm-dd
> +my $dt_today = dt_from_string();
This variable is not used anywhere.
@@ +312,5 @@
> +$imported_record->update(
> +{
> +datestamp => $imported_record->datestamp,
> +}
> +);
This looks like it does nothing (set "record's datestamp" to "record's
datestamp").
Shouldn't it be $oai_record->datestamp (or now if incoming oai record does not
have a datestamp) ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #35 from Martin Renvoize --- Well implemented, clear code and unit tests present. Current tests pass, new tests also passing. QA script happy, Passing QA NOTE: New dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36531] Koha should serve text/javascript compressed, like application/javascript is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36531 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36531] Koha should serve text/javascript compressed, like application/javascript is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36531 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36379] Authorities search is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36379] Authorities search is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Attachment #163645|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 164505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164505=edit Bug 35826: Make copy of cost matrix when substituting inf Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Attachment #163644|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 164504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164504=edit Bug 35826: Add unit tests. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Attachment #163643|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 164503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164503=edit Bug 35826: Keep items on retry. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Attachment #163642|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 164502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164502=edit Bug 35826: Fix errors in transport cost optimization Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 Martin Renvoize changed: What|Removed |Added Attachment #163641|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 164501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164501=edit Bug 35826: optimize on transport cost when building holds queue Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36545] Use select2 in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #1 from Magnus Enger --- What are the advantages of this new approach over the old one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36474] updatetotalissues.pl should not modify the record when the total issues has not changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36474 Nick Clemens changed: What|Removed |Added Status|BLOCKED |ASSIGNED --- Comment #5 from Nick Clemens --- We are working on adding a unit test here, and adjusting the existing/dependent tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36473] updatetotalissues.pl should not die on a bad record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36473
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #12 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #8)
> if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) {
> UpdateTotalIssues( $item_object->biblionumber, 1, undef, {
> skip_holds_queue => 1 } );
> }
>
> IIUC AddIssue will no longer crash on an invalid metadata record, right? Is
> that really what we want?
This was an unintended consequence, however, I do think this is what we want -
there will be a warning in the logs - but why should we prevent checking out an
item with a bad record? We should be handling that on creation or editing of a
record.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36545] Use select2 in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber changed: What|Removed |Added Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36545] New: Use select2 in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Bug ID: 36545 Summary: Use select2 in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sie...@kit.edu QA Contact: testo...@bugs.koha-community.org As discussed in Marseille (Hackfest 2024) we provide a patch for item seach using select2. To test: - Apply patch - check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched - Check that the search is working well - Sign off :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Nick Clemens --- I tested again, I couldn't get email working but the dumped email looks correct to me, could you test again? And maybe send the emails to my email so I see the problem ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 164500
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164500=edit
Bug 36505: Add support for `extended_attributes` in PUT /patrons/:patron_id
This patch does what the title says. With it, you will be able to PUT on
the already existing endpoint, but also pass:
```json
[ { "type": "THE_TYPE", "value": "a" }, ... ]
```
Bonus: to ease testing I added `x-koha-embed: extended_attributes`
support.
To test:
1. Apply the unit tests
2. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: This is not implemented!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Exhaustive testes pass!
5. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 164499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164499=edit Bug 36505: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Summary|Cannot update patron|Allow updating patron |attributes via PUT request |attributes via PUT |on Patrons endpoint | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Philip Orr changed: What|Removed |Added CC||philip@lmscloud.de --- Comment #38 from Philip Orr --- Hmm, I was just documenting this and noticed that the new syspref is in the Subgroup "Printing" of the Acquisitions system preferences. Why "Printing"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36544] Add option to choose a delimiter for patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36544 Philip Orr changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23668 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23668] Manual on patron import: Information on syntax for patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668 Philip Orr changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36544 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23668] Manual on patron import: Information on syntax for patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668 --- Comment #6 from Philip Orr --- New bug for delimiter selection: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36544 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36544] New: Add option to choose a delimiter for patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36544 Bug ID: 36544 Summary: Add option to choose a delimiter for patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: philip@lmscloud.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com By default the patron import tool (accessed by going to Tools -> Import Patrons) uses commas to separate fields. This is fine in most cases, but there is one problem: If you have patron attributes enabled and are importing patrons with values in the patron attribute fields, it could happen that the value of a patron attribute field to be imported contains a comma. For instance, your patron attribute field could be "Names of family members" and the value could be "John Doe, Jane Doe". In that case the attribute will not be imported correctly due to the comma and the patron import could also fail. In this case it would be good to have the choice to use a different delimiter. To replicate: - First to set up a new patron attribute type called "FAMILY": - navigate to Administration -> Patron Attribute Types - Click on "New patron attribute type" - Patron attribute type code: "FAMILY", description "Names of family members" - save - Then create a .csv file with the following content: cardnumber,surname,branchcode,categorycode,patron_attributes 123123123,Testuser,MPL,S,FAMILY:John Doe,Jane Doe - Go to Tools -> Import patrons - Import your file - Under Feedback, it will contain: "attribute string : FAMILY:John Doe " - Everything after the comma is missing The help text next to patron import suggests using double quotes wrapped around patron attribute field values that contain commas, but that didn't work for me either. If you want to replicate that, do everything as above but in your .csv file use the following content: cardnumber,surname,branchcode,categorycode,patron_attributes 123123123,Testuser,MPL,S,"FAMILY:John Doe,Jane Doe" Should then fail to be imported due to an unexpected format. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36531] Koha should serve text/javascript compressed, like application/javascript is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36531 Nick Clemens changed: What|Removed |Added Attachment #164465|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 164498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164498=edit Bug 36531: Serve text/javascript compressed, like application/javascript is Koha serves static .js files as application/javascript (if /etc/mime.types says to) and serves them compressed, but output_with_http_headers uses the currently-correct text/javascript mimetype, and Koha doesn't compress that. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable. 2. Open the browser Web Developer Tools to the Network tab 3. Load Cataloging - Advanced editor 4. Click on the line for the framework?frameworkcode==define load 5. Note the content-type text/javascript, no Content-Encoding line, and the size of 1.9MB 6. Apply the patches from bug 36463 if they haven't been pushed, then this patch, and reset_all 7. Repeat steps 1-4, and note a Content-Encoding: gzip header and a Transferred size around 160KB Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36531] Koha should serve text/javascript compressed, like application/javascript is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36531 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Nice improvement.. works and is clean Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Martin Renvoize changed: What|Removed |Added Attachment #164139|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 164497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164497=edit Bug 36463: (follow-up) Adjust other occurence (intranet) Signed-off-by: Frédéric Demians Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Martin Renvoize changed: What|Removed |Added Attachment #164137|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 164496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164496=edit Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34902] decreaseLoanHighHolds does not reduce loan period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34902 Philip Orr changed: What|Removed |Added Attachment #163481|0 |1 is obsolete|| --- Comment #3 from Philip Orr --- Created attachment 164495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164495=edit Bug 34902: decreaseLoanHighHolds does not reduce loan period See the bug for a description of the problem. Settings: - decreaseLoanHighHolds = Enable - decreaseLoanHighHoldsDuration = 7 - decreaseLoanHighHoldsValue = 1 - decreaseLoanHighHoldsControl = over the number of holdable items on the record - decreaseLoanHighHoldsIgnoreStatuses = [none selcted] Set a default loan period of 28 days under Administration > Circulation and fine rules To reproduce: - Find a record with one item - Add three holds on the record, for three different patrons - Check out the item to the first patron on the waiting list - Verify that the item is issued without any shortened loan time To test: - Return the loan you made above, and ignore the holds on the record - Add another hold to the record - Apply the patch - Restart all the things - Check out the item to the first patron on the waiting list - Verify that there is now a warning about a shortened loan time Signed-off-by: Philip Orr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34902] decreaseLoanHighHolds does not reduce loan period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34902 Philip Orr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36313] Check out/check in leads to error 500 in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313 --- Comment #21 from Emmi Takkinen --- (In reply to Emmi Takkinen from comment #20) > Did some testing on that "Undefined subroutine > ::Circulation::CheckReserves" error: > > - this happens also with old database > - doesn't happen with latest 23.11 release or with sandboxes, only with > master > - tests using CheckReserves (without C4::Reserves:: before it) pass as far > as I can tell > - I made a simple test script that calls CheckReserves and it works > > It seems there is something in bug 27595 patch "Bug 27595: Add place_hold > method to Koha::Suggestion" that causes this. Before that patch check in > works as is should, after it 500 error occurs. If I remove line >use C4::Reserves qw( AddReserve ); from Suggestion.pm checkin/checkout starts to work again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36313] Check out/check in leads to error 500 in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313 --- Comment #20 from Emmi Takkinen --- Did some testing on that "Undefined subroutine ::Circulation::CheckReserves" error: - this happens also with old database - doesn't happen with latest 23.11 release or with sandboxes, only with master - tests using CheckReserves (without C4::Reserves:: before it) pass as far as I can tell - I made a simple test script that calls CheckReserves and it works It seems there is something in bug 27595 patch "Bug 27595: Add place_hold method to Koha::Suggestion" that causes this. Before that patch check in works as is should, after it 500 error occurs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
Mark Hofstetter changed:
What|Removed |Added
CC||k...@trust-box.at
--- Comment #2 from Mark Hofstetter ---
Hi Raphael,
you don't need to check if the plugins are enabled ie the if statement should
be removed
if ( C4::Context->config('enable_plugins') ) {
..
}
and could you please provide a rudimentary example plugin to test the hook
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
