[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 --- Comment #6 from David Cook --- (In reply to Andreas Jonsson from comment #5) > 1. I believe 30 is sufficient, although even smaller might be possible? I don't mind erring on the side of caution using 30. > 2. I think restricting to ascii makes sense for values that are only > accessed programatically although I don't know exactly much the overhead is > for utf8mb4. I think I follow. I just wanted to make sure that it was an intentional change. > 3. It should default to the general collation. But setting it explicitly > would not hurt. I don't believe the collation is very important for these > columns, though. Well, my point is that the kohastructure.sql and the database update are different. Regardless of the collation used, they need to be consistent/the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #11 from David Cook --- (In reply to Martin Renvoize from comment #8) > As for $$ vs POSIX... I honestly had just forgotten that $$/$PID/$PROCESS_ID > existed.. having said that I feel like the POSIX import makes it very clear > what we're doing... I could see devs not immediately understanding the use > of $$. Yeah, I think so too. While Perl shorthand can be handy, I do like clarity more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #10 from David Cook --- (In reply to Martin Renvoize from comment #9) > Do you have a method in mind for the double check we're starman/plack you > mention? > > I'm struggling to think of a reliable one I was hoping that we could check $0 but it looks like one of the Plack components possibly relating to Plack::App::CGIBin changes it to the CGI script being emulated, so that won't work. I think we'll probably just have to check the environment in that case. C4::Context->psgi_env() will probably be good enough. Another thought about this one... rather than putting it into the InstallPlugins(), we could have a different method for resetting the parent process, and just invoke it in the web controller. That would be safer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 --- Comment #5 from Andreas Jonsson --- 1. I believe 30 is sufficient, although even smaller might be possible? 2. I think restricting to ascii makes sense for values that are only accessed programatically although I don't know exactly much the overhead is for utf8mb4. 3. It should default to the general collation. But setting it explicitly would not hurt. I don't believe the collation is very important for these columns, though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #9 from Martin Renvoize --- Do you have a method in mind for the double check we're starman/plack you mention? I'm struggling to think of a reliable one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #8 from Martin Renvoize --- As for $$ vs POSIX... I honestly had just forgotten that $$/$PID/$PROCESS_ID existed.. having said that I feel like the POSIX import makes it very clear what we're doing... I could see devs not immediately understanding the use of $$. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #7 from Martin Renvoize --- Thanks for your review David :). I had a feeling we'd want to wrap it to check we were running as plack but then totally forgot to add it.. follow-up added. Though we might also want to somehow try to let this happen for background workers and I'm not entirely sure how to identify those yet (I think we can probably handle that on another bug). As for the recursive lookup, I must put my hands up here and say I followed some google example from somewhere.. we may well only need to get the single parent.. I can't see that we allow children to spawn more children anywhere here in plack so we're probably safe to reduce that code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 --- Comment #6 from Martin Renvoize --- Created attachment 164654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164654&action=edit Bug 30897: Limit to plack environments I had a feeling we'd want to do this when I submitted the proof of concept, though I hadn't appreciated the wider issues that have now been highlighted.. it makes a lot of sense to limit to the plack scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #21 from Martin Renvoize --- Thanks for the cleanup work here Tomas, and apologies it seems I was guilty of introducing a few of the issues. Great to see a unit test to help prevent these in the future. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164647|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 164653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164653&action=edit Bug 36565: EDI files API docs fixes (bug 30070 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164646|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 164652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164652&action=edit Bug 36565: Preservation module API docs fixes (bug 30708 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164645|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 164651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164651&action=edit Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164644|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 164650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164650&action=edit Bug 36565: ILL requests API docs fixes (bug 22440 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164643|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 164649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164649&action=edit Bug 36565: Bookings API docs fixes (bug 29002 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added Attachment #164642|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 164648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164648&action=edit Bug 36565: Unit tests This patch introduces tests on the OpenAPI spec so that all tags used in path definitions have their corresponding entry at the top level 'tags' section. This it important for correctly rendering the API documentation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36511] Some scripts missing a dependency following Bug 24879
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36511 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- We just bumped into this as well for 23.11.04. Will need to backport this one pretty widely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164617|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 164647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164647&action=edit Bug 36565: EDI files API docs fixes (bug 30070 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164616|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 164646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164646&action=edit Bug 36565: Preservation module API docs fixes (bug 30708 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164615|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 164645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164645&action=edit Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164614|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 164644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164644&action=edit Bug 36565: ILL requests API docs fixes (bug 22440 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164613|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 164643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164643&action=edit Bug 36565: Bookings API docs fixes (bug 29002 follow-up) Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Attachment #164612|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 164642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164642&action=edit Bug 36565: Unit tests This patch introduces tests on the OpenAPI spec so that all tags used in path definitions have their corresponding entry at the top level 'tags' section. This it important for correctly rendering the API documentation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36570] OAI-PMH - Hide items non-public notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36570 --- Comment #3 from David Cook --- I've also been wondering about adding a system preference like that. I suppose another option would be in the OAI config file. For instance, defaulting to honouring the OPAC visibility with an ability to override it on a per metadata format basis. That might actually be the best way to do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Nice one. Small but important change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 David Cook changed: What|Removed |Added Attachment #164629|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 164641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164641&action=edit Bug 36568: Fix id parameter in template Fix missed case of changing parameter name from "reports" to "id" To test: 1. Find or create an SQL report that will return more than 20 rows 2. Run the report 3. Change the "Rows per page" drop-down to a new value --> An empty page is displayed! 4. Apply patch 5. Repeat steps 2-3 --> The report is displayed with the appropriate number of results Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36570] OAI-PMH - Hide items non-public notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36570 --- Comment #2 from Pablo AB --- Right! Likewise, I notice data leakage (particularly through 9xx) while using marcxml, since Bug 19353 is relatively recent. Maybe a new syspref could define if the subfield OAI visibility state should honor the OPAC visibility flag (before passing through the XSLT (i.e., any metadataPrefix)). Usually, if the subfield should not be seen by humans, should not be seen by machines also. Could be OAI-PMH:HonorOPACVisibilityFlag. Or maybe rename the ancient visibility flag "Flagged" to "OAI" (no one knows its purpose, Bug 14772). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5807] Add collection code to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5807 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #1) > Itemtypes can now be grouped to make things a little easier for end users. > Overall I am not sure if using a 4th dimension would make circulation rules > still managemable: library - patron category - itemtype - collection Agreed. They're already borderline unmanageable. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36517] Fix output from install_plugins.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36517 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 --- Comment #4 from David Cook --- Once you answer my questions, I'll have a look at testing this. Even if I don't think it's ready for QA, I think I'd be willing to sign it off, if it works. Just to keep it moving... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- First, I think this is awesome. Lately, we've been talking at the office a lot about this exact topic, so this is great to see. However, I think we'll want to be very careful with this change. For instance, I don't think it should be backported, since any library with a large action_logs table will take a long time to upgrade. Or - as you note - they could have a volume full if they don't have enough disk space. I wonder if this is a case where we should update kohastructure.sql so that new databases have a good default, but not have an automatic upgrade of the action_logs. We are working on displaying a database audit in about.pl so that could be a good place to give people information about how to manually fix the action_logs indexes at a better time of their choosing... I suppose another option would be to have an arbitrary threshold where an automatic database fix does happen for action_logs tables under a certain size... I don't know. Maybe we should put this one to the koha-devel listserv... -- Questions: 1. How did you decide on 30 for the character length? I think SYSTEMPREFERENCE should be the longest "module" officially, and that's only 16 letters, so 30 seems pretty good. I suppose we're relying on plugins and customizations not having added any "module" longer than 30 characters... I'm tempted to do query some prod databases to see if I can find anything unexpected in those columns. 2. Is the use of "CHARACTER SET ascii COLLATE ascii_general_ci" designed to keep the bytes allocated as small as possible? I think there's merit to that. We default to utf8mb4 which is going to be overkill for those columns, which should never be anything but ASCII, so I think it's good thinking. It might be worth adding a comment to kohastructure explaining why the choice of ASCII so that someone in the future doesn't undo it by accident. 3. The collation is missing in the "bug_36569-compact-action_logs-indices.pl" update. I haven't tested, but is that OK? Is it implied in MySQL from the charset? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36570] OAI-PMH - Hide items non-public notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36570 --- Comment #1 from David Cook --- I noticed this a few months ago as well. Basically, the OAI-PMH isn't respecting the bibliographic frameworks in general, so other hidden fields would also be shown. This does need a fix... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36570] OAI-PMH - Hide items non-public notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36570 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36090 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #46 from David Cook --- PS I don't mean to be a buzz kill and I very much appreciate your contributions, Martin! :D <3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #45 from David Cook --- (In reply to Martin Renvoize from comment #44) > I've added an alternative approach to bug 30897 that uses the proposed > getppid and kill approach. > > It's not tested yet, but hopefully can get this one moving again. Martin, I think you've gone with a pretty good approach. I did find some problems with it, but they should be fairly easily fixed I think. Personally, I'd probably never want to automatically restart Starman, but I think it would be a very useful feature for a lot of people, and really essential for people with minimal sysadmin support. (We might find that we add this to the Identity Provider section as well, since that requires Koha restarts in some cases.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from David Cook --- Thanks for looking into this, Martin. I had forgotten that I'd raised this issue! I'll have to mark it as Failed QA for a few reasons. 1a. If you run install_plugins.pl from the CLI, your bash session will be killed, since that's the parent process. I think that's an unintended consequence. (However, we can probably work around this by checking if we're running in a Plack environment first.) root@kohadevbox:koha$ koha-shell kohadev $ /kohadevbox/koha/misc/devel/install_plugins.pl No plugins found at /var/lib/koha/kohadev/plugins Hangup root@kohadevbox:koha$ 1b. Like 1a, this will cause problems when running unit tests: kohadev-koha@kohadevbox:koha(bug30897)$ perl t/db_dependent/Koha/Plugins/Circulation_hooks.t 1..4 ok 1 - use Koha::Plugins; ok 2 - use Koha::Plugins::Handler; ok 3 - use Koha::Plugin::Test; # Subtest: after_circ_action() hook tests 1..3 Hangup root@kohadevbox:koha$ 2. I think we should wrap this with some configuration. Restarting the Starman on plugin installation is a significant change, so I think we'll want to be able to quickly and easily change between behaviours - at least in the short-term. I think we'll also probably want to default to off at least initially just to be on the safe side. 3. This restart runs even if there are no changes to make to the plugins, which would lead to unnecessary restarts. I think we'd want to be more careful in initiating the restarts. -- Additional questions/comments: 1. Could you speak to why you need to look for the parent pid recursively? I don't see the reason for it. As an aside, do we want to use POSIX::getpid instead of $$ for getting the pid? I suppose POSIX::getpid is easier to read. 2. Relating to my first failure point, do you think perhaps we should interrogate the process we're looking to restart just to be extra careful? At a minimum, I think we'd want to double-check that it is really Starman. I wanted to say we shouldn't try to "kill" pid 1, but I suppose if someone has managed to get Starman running in Docker as the only process, then it could have a pid of 1, and that would be OK... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #164637|0 |1 is obsolete|| --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 164640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164640&action=edit Bug 32256: (follow-up) Use correct patron category This patch ensures we check the categorycode of the patron trying to issue the items is valid (based on BatchCheckoutsValidCategories), rather than the categorycode of the AutoSelfCheckAllowed patron. To test: 1 - Enable BatchCheckouts, select nothing in BatchCheckoutsValidCategories 2 - confirm AutoSelfCheckAllowed is allowed and contains the username and password for the self_check user. Confirm self_check user is in category Staff 3 - log into SCO with a user in category Patron, confirm you can only check out 1 item at a time 4 - select Patron in BatchCheckoutsValidCategories 5 - log into SCO with your Patron user again, confirm you can check out multiple items at a time Sponsored-by: Koha-US Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #164572|0 |1 is obsolete|| --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 164639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164639&action=edit Bug 32256: Add message to SCO that batch checkouts works for checkouts only Not yet handling renewals, returns, or items that are impossible to check out. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #164571|0 |1 is obsolete|| --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 164638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164638&action=edit Bug 32256: Enable batch checkout using self-checkout This patch allows more than one item to be scanned and processed at once in Koha's self-checkout module. The items in the batch will still be handled one-by-one, so if any item in the batch requires confirmation (i.e. to be renewed or returned) or is impossible to check out, the process will stop at that item. Any items earlier in the list will be processed, but any items coming after in the list will be ignored. This feature uses the existing BatchCheckouts and BatchCheckoutsValidCategories system preferences to determine if batch checkouts should be allowed. To test: 1) Open the staff interface. Go to Koha Administration -> Global system preferences. Search for "BatchCheckouts". Confirm BatchCheckouts syspref is disabled, and no categories are selected for the BatchCheckoutsValidCategories syspref. 2) In another tab, open the OPAC self checkout (found out OPACBaseURL/cgi-bin/koha/sco/sco-main.pl) and log in 3) Confirm the self-checkout works as normal for checking out, returning or renewing one item at a time 4) Go back to the staff interface tab (you may need to log back in). Enable the BatchCheckouts syspref but leave the BatchCheckoutsValidCategories syspref empty. 5) Refresh the OPAC self checkout tab. The barcode input field will now be bigger to support a list of barcodes. Enter a list of barcodes separated by newlines and Submit. 6) Only the first barcode should be processed. This is because no categories are valid for BatchCheckouts. 7) Go back to the staff interface tab (you may need to log back in). Select at least your patron category for the BatchCheckoutsValidCategories syspref and Save. 8) Refresh the OPAC self checkout tab. Enter a list of barcodes separated by newlines and Submit. Confirm all valid items are checked out as expected. 9) Test with a few items that are notforloan or would not be valid checkouts. Confirm they are not checked out, but other valid items in the batch are checked out successfully. 10) Test with a batch where one of the items is already checked out to the patron. The batch should get blocked at this item as the self-checkout asks for confirmation. 11) Test with both renewing and returning of items that are already checked out to the patron. This will only work with one item at a time and later items in the list will be ignored. Sponsored-by: Koha-US Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688 Joe Sikowitz changed: What|Removed |Added CC||j...@flo.org Assignee|koha-b...@lists.koha-commun |j...@flo.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Passed QA --- Comment #13 from Emily Lamancusa --- I agree with keeping the ELSE as a fallback - it doesn't hurt and it does make the code more robust. I squashed a capitalization fix into the follow-up, but otherwise it looks good, and passes the QA script. Setting to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Aleisha Amohia changed: What|Removed |Added Attachment #164573|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 164637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164637&action=edit Bug 32256: (follow-up) Use correct patron category This patch ensures we check the categorycode of the patron trying to issue the items is valid (based on BatchCheckoutsValidCategories), rather than the categorycode of the AutoSelfCheckAllowed patron. To test: 1 - Enable BatchCheckouts, select nothing in BatchCheckoutsValidCategories 2 - confirm AutoSelfCheckAllowed is allowed and contains the username and password for the self_check user. Confirm self_check user is in category Staff 3 - log into SCO with a user in category Patron, confirm you can only check out 1 item at a time 4 - select Patron in BatchCheckoutsValidCategories 5 - log into SCO with your Patron user again, confirm you can check out multiple items at a time Sponsored-by: Koha-US -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Emily Lamancusa changed: What|Removed |Added Attachment #163774|0 |1 is obsolete|| --- Comment #12 from Emily Lamancusa --- Created attachment 164636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164636&action=edit Bug 35969: (follow-up) Improve wording As suggested by David Nind. Thanks! Signed-off-by: Marcel de Rooy Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969 Emily Lamancusa changed: What|Removed |Added Attachment #163773|0 |1 is obsolete|| --- Comment #11 from Emily Lamancusa --- Created attachment 164635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164635&action=edit Bug 35969: Add error code in opac-sendbasket.pl No need to carp about empty basket or no reply address. Just add a simple explanation on the form. Note that it makes no sense to show the form if the patron has no email address. We need it as reply-to. Test plan: Try opac-sendbasket.pl?bib_list=null Remove email address from your account, try again. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447 Evelyn Hartline changed: What|Removed |Added CC||eve...@bywatersolutions.com --- Comment #5 from Evelyn Hartline --- Would it be possible to backport this for 23.11? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36570] New: OAI-PMH - Hide items non-public notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36570 Bug ID: 36570 Summary: OAI-PMH - Hide items non-public notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org After enabling the expose of items (`include_items: 1` on `OAI-PMH:ConfFile`) the info of 952$x Non-public note (items.itemnotes_nonpublic) is shown, potentially exposing sensitive information. Not sure how a solution to this issue may interact with OpacHiddenItems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 Janusz Kaczmarek changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 Janusz Kaczmarek changed: What|Removed |Added Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 Janusz Kaczmarek changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 --- Comment #2 from Janusz Kaczmarek --- Created attachment 164634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164634&action=edit Bug 33407: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 --- Comment #1 from Janusz Kaczmarek --- Created attachment 164633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164633&action=edit Bug 33407: With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results With ES and QueryAutoTruncate on, a search with punctuation surrounded by spaces (like ISBD punctuation copied from other catalogue or bibliography) returns no results. E.g.: in a search for "Maria Stuart ; Die Jungfrau von Orleans / Schiller" (coded in record as 245 10 $a Maria Stuart ; $b Die Jungfrau von Orleans / $c Schiller) -- both semicolon and slash cause problems. One had to remove them manually to get results which is not what is desired. Test plan = 1. Use ktd with Elasticsearch and ktd's test data (http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1): 2. Make a search for the first ISBD zone taken verbatim from the first record: E Street shuffle : the glory days of Bruce Springsteen & the E Street Band / Clinton Heylin There should be no result. 3. Apply teh patch, restart plack. 4. Repeat the search. You should get the record (and onother one). Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 Janusz Kaczmarek changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36497] Cancel unfilled holds should be a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36497 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36424] Database update 22.06.00.078 breaks update process (II)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #8 from Pablo AB --- In the broken state `SHOW CREATE TABLE item_groups;` also.. ERROR 1146 (42S02): Table 'koha_myinstance.item_groups' doesn't exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 Andreas Jonsson changed: What|Removed |Added Attachment #164631|0 |1 is obsolete|| --- Comment #2 from Andreas Jonsson --- Created attachment 164632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164632&action=edit Bug 36569: Compact action log/combined index With cataloguing logging enabled on the action_logs table it will become large. The module and action columns in action_logs are MEDIUMTEXT (max ~16 million bytes) with 196 first characters used for the index. Since these columns holds names that are only used programatically we could reduce the size of these columns to make the index more compact. Since module and action is often used together we can instead create a combined index and still have a smaller table. Test plan: * Start koha-testing-docker without patch applied (ku) * Apply patch * Run the command: sudo koha-upgrade-schema kohadev * Verify database schema: > sudo koha-mysql kohadev -t -e 'SHOW CREATE TABLE action_logs' | \ grep -E '`action`|`module`' The output should be (truncated long lines here): `module` varchar(30) CHARACTER SET ascii COLLATE ascii_general_ci ... `action` varchar(30) CHARACTER SET ascii COLLATE ascii_general_ci ... KEY `module_idx` (`module`), KEY `action_idx` (`action`), KEY `module_action_idx` (`module`,`action`), * Run unit test: prove t/db_dependent/Koha/ActionLogs.t * Stop koha-testing-docker and delete the containers (kd) * Start koha-testing-docker with patch applied * Verify database schema: > sudo koha-mysql kohadev -t -e 'SHOW CREATE TABLE action_logs' | \ grep -E '`action`|`module`' The output should be same as above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 Andreas Jonsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 --- Comment #1 from Andreas Jonsson --- Created attachment 164631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164631&action=edit Bug 36569: Compact action log/combined index With cataloguing logging enabled on the action_logs table it will become large. The module and action columns in action_logs are MEDIUMTEXT (max ~16 million bytes) with 196 first characters used for the index. Since these columns holds names that are only used programatically we could reduce the size of these columns to make the index more compact. Since module and action is often used together we can instead create a combined index and still have a smaller table. Test plan: * Start koha-testing-docker without patch applied (ku) * Apply patch * Run the command: sudo koha-upgrade-schema kohadev * Verify database schema: > sudo koha-mysql kohadev -t -e 'SHOW CREATE TABLE action_logs' | \ grep -E '`action`|`module`' The output should be (truncated long lines here): `module` varchar(30) CHARACTER SET ascii COLLATE ascii_general_ci ... `action` varchar(30) CHARACTER SET ascii COLLATE ascii_general_ci ... KEY `module_idx` (`module`), KEY `action_idx` (`action`), KEY `module_action_idx` (`module`,`action`), * Run unit test: prove t/db_dependent/Koha/ActionLogs.t * Stop koha-testing-docker and delete the containers (kd) * Start koha-testing docher with patch applied * Verify database schema: > sudo koha-mysql kohadev -t -e 'SHOW CREATE TABLE action_logs' | \ grep -E '`action`|`module`' The output should be same as above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 --- Comment #6 from Owen Leonard --- This patch is incomplete in that custom cover images (the CustomCoverImages system preference) will not display in search results. opac-detail.tt has access to biblio.custom_cover_image_url, but the same information isn't available in search results as far as I can tell. I could use help exposing that information to the template. I had originally tried to implement this feature by creating a common include file and common JS file so that both search results and the detail page could share code. I think that should still be a future change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 --- Comment #5 from Owen Leonard --- Created attachment 164630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164630&action=edit Bug 26933: Improve handling of multiple covers on catalog search results in the OPAC This patch implements a book cover slider widget for cover images in search results, matching the way we show covers on the detail page. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - OpenLibrary - Baker & Taylor - Google Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36569] New: Compact action_logs indicies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569 Bug ID: 36569 Summary: Compact action_logs indicies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jons...@kreablo.se QA Contact: testo...@bugs.koha-community.org With cataloguing logging enabled on the action_logs table it will become large. The module and action columns in action_logs are MEDIUMTEXT (max ~16 million bytes) with 196 first characters used for the index. Since these columns holds names that are only used programatically we could reduce the size of these columns to make the index more compact. Since module and action is often used together we can instead create a combined index and still have a smaller table. > SELECT module, action, count(*) FROM action_logs GROUP BY module, action; +--++--+ | module | action | count(*) | +--++--+ | CATALOGUING | ADD| 543638 | | CATALOGUING | DELETE | 573712 | | CATALOGUING | MODIFY | 6264928 | . . . | SYSTEMPREFERENCE | MODIFY | 554 | +--++--+ 33 rows in set (6 min 49,652 sec) -rw-rw 1 mysql mysql 27439136768 10 apr 16.45 action_logs.ibd -rw-rw 1 mysql mysql 24368906240 10 apr 17.33 action_logs.ibd (/ (- 27439136768 24368906240) 27439136768.0) (/ (- 27439136768 24914165760) 27439136768.0) Changing the column sizes to 30 bytes each reduce the size of the action_logs table by 11%. > ALTER TABLE action_logs MODIFY COLUMN module VARCHAR(30) CHARSET ascii, > MODIFY COLUMN action VARCHAR(30) CHARSET ascii; Query OK, 8725398 rows affected (18 min 32,541 sec) Records: 8725398 Duplicates: 0 Warnings: 0 After creating a combined index the size is still 9% less than before: CREATE INDEX IF NOT EXISTS module_action_idx ON action_logs(module, action); Performance improvement 22024%: +--++--+ | module | action | count(*) | +--++--+ | CATALOGUING | ADD| 543638 | | CATALOGUING | DELETE | 573712 | | CATALOGUING | MODIFY | 6264928 | . . . | SYSTEMPREFERENCE | MODIFY | 554 | +--++--+ 33 rows in set (1,860 sec) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 Emily Lamancusa changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 Emily Lamancusa changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 --- Comment #1 from Emily Lamancusa --- Created attachment 164629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164629&action=edit Bug 36568: Fix id parameter in template Fix missed case of changing parameter name from "reports" to "id" To test: 1. Find or create an SQL report that will return more than 20 rows 2. Run the report 3. Change the "Rows per page" drop-down to a new value --> An empty page is displayed! 4. Apply patch 5. Repeat steps 2-3 --> The report is displayed with the appropriate number of results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Emily Lamancusa changed: What|Removed |Added Blocks||36568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 [Bug 36568] Changing rows per page on a custom report is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36568] New: Changing rows per page on a custom report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 Bug ID: 36568 Summary: Changing rows per page on a custom report is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: emily.lamanc...@montgomerycountymd.gov Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org Depends on: 34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28655] new ideas/proposal to enhance pluggability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28173 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28655 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #5 from Clemens Tubach --- Hi Marc, if plugins are disabled and the if statement does not exist, we get following error message: "There was an error authenticating to external identity provider Can't call method "GetPlugins" on an undefined value at /kohadevbox/koha/Koha/Auth/Client.pm line 70." So the if statement is necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose changed: What|Removed |Added Status|In Discussion |BLOCKED --- Comment #129 from Caroline Cyr La Rose --- Blocked by bug 25870 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Pedro Amorim changed: What|Removed |Added CC||k...@trust-box.at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28655] new ideas/proposal to enhance pluggability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655 Pedro Amorim changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #4 from Clemens Tubach --- Created attachment 164628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164628&action=edit Plugin to test the hook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #3 from Clemens Tubach --- Hi Marc, we have added a test plugin, see attached file. This plugins write "Bug 36503: Hook test" into field "OPAC note" from the user currently logging in. To test: 1) Install and configure SSO with OIDC, see https://wiki.koha-community.org/wiki/Testing_SSO#SAML 2) Install the attached plugin AfterLogin-458d2ef.kpz 3) Login to OPAC Using SSO with user kohadev 4) Check to see "Messages for you: Bug 36503: Hook test" after Login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33538] Allow for independent shibboleth autocreate and sync mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #1 from Brendan Lawlor --- At one point we had autocreate and sync both working for our use case, but since some Koha upgrade, possibly 23.05, it stopped working the way that we expected it to and have had to turn off sync. In our use case we are using SSO for library staff accounts. We had autocreate set some default level of permissions so that staff could login to the staff interface and do some basic circ when they first logged in. Then we managed elevating permissions in Koha. We had sync turned on and our SAML so that we could update staff attributes like branchcode and name in the IdP and the Koha account would update the next time the staff logged in. Originally the sync allowed for updating the user's attributes sent by SAML, but allowed for the elevated permissions to be retained. We had to turn off sync because Shibboleth started syncing the permission flags to the default and all staff lost their permissions. We don't store and send permission flags in our IdP, but to get this working again without a patch we would have to do that. I think Shibboleth's sync should only update attributes that are explicitly passed from the SAML app, so that you could configure defaults for other fields in autocreate. This is particularly useful for setting default permissions for new staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26811] Accessibility: Improve staff client usability for non-mouse users by changing order of page elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26811 claire.hernan...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Component|Staff interface |Accessibility CC||claire.hernandez@biblibre.c ||om, ||martin.renvoize@ptfs-europe ||.com, ||matt.blenkinsop@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Thibaud Guillot changed: What|Removed |Added Attachment #163546|0 |1 is obsolete|| --- Comment #9 from Thibaud Guillot --- Created attachment 164627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164627&action=edit Bug 36271 : Add circulation rules for booking Welcome to 3 new circulation rules :) - Bookings allowed (total) / bookings_allowed_total - Bookings per item (total) / bookings_per_item - Bookings period length (day) / bookings_period_length Test plan: 1) Apply this patch 2) Set values for these new rules 3) Define a total to 2, 1 per item with 2 days for example for booking period. 4) Book an item and retry on the same item, normally an error message is showing in the pop up. 6) Book another item, and again another one, on the third an error message is showing (always in pop up) 7) You can also try to test with a longer period than bookings period length rule, an another error will be displayed. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Andrew Fuerste-Henry --- The category code limits are now working as intended, everything in the test plan worked. I typo-ed my way into finding another issue. Self-check login dies with the following error if self-check login is unsuccessful while BatchCheckouts is set to Allow: "Can't call method 'categorycode' on an undefined value at /kohadevbox/koha/opac/sco/sco-main.pl" I was testing this bug with SelfCheckoutByLogin set to cardnumber, so entering a nonexistent cardnumber caused the SCO to die. When I switched SelfCheckoutByLogin to username and password, it died on an incorrect username/password combo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36559] Transport Cost Matrix update helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- +1 Good ideas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #76 from Arthur Suzuki --- @David, I rebased the patch on latest master but reproduce what you've seen. I cannot place holds from OPAC with opacitemholds rule set to "Don't Allow" : should be able to place a record-level hold. Same with value "Force", although I should be able to place item-level holds. This patch needs rework... working on it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Matthias Meusburger changed: What|Removed |Added Keywords||roadmap_24_05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28532] [Omnibus] Accessibility: Staff interface - add legends to forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 claire.hernan...@biblibre.com changed: What|Removed |Added Component|Staff interface |Accessibility Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC||claire.hernandez@biblibre.c ||om, ||martin.renvoize@ptfs-europe ||.com, ||matt.blenkinsop@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 claire.hernan...@biblibre.com changed: What|Removed |Added Component|Staff interface |Accessibility CC||claire.hernandez@biblibre.c ||om, ||martin.renvoize@ptfs-europe ||.com, ||matt.blenkinsop@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 claire.hernan...@biblibre.com changed: What|Removed |Added Component|Staff interface |Accessibility CC||claire.hernandez@biblibre.c ||om, ||martin.renvoize@ptfs-europe ||.com, ||matt.blenkinsop@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om, ||matt.blenkinsop@ptfs-europe ||.com, oleon...@myacpl.org Component|Staff interface |Accessibility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36517] Fix output from install_plugins.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36517 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | Status|Signed Off |Passed QA --- Comment #5 from Emily Lamancusa --- Good catch - thanks, Mangus! Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36517] Fix output from install_plugins.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36517 Emily Lamancusa changed: What|Removed |Added Attachment #164493|0 |1 is obsolete|| --- Comment #4 from Emily Lamancusa --- Created attachment 164626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164626&action=edit Bug 36517: Fix output from install_plugins.pl When misc/devel/install_plugins.pl does not find any plugins, it prints the list of pluginsdir, but with a literal \n separating the dirs, and no newline at the end. To test: - Edit koha-conf.xml and add a second entry for , so there are two entries. The second one could just be a copy of the original. - Run "perl misc/devel/install_plugins.pl" - Note the output looks something like this: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ - Apply the patch and run the script again. Output should be: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins root@kohadevbox:koha(master)$ - Sign off Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5807] Add collection code to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5807 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #4 from Magnus Enger --- If we do add collection code to the circ rules, we should probably add location too. I have a hunch different libraries use those two fields in similar ways. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36179] "Quick add" patron form should be a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36179 Pedro Amorim changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35980] Add message to patron needs permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Julian Maurice --- Patches work as expected and pass QA checks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35980] Add message to patron needs permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Julian Maurice changed: What|Removed |Added Attachment #164489|0 |1 is obsolete|| --- Comment #10 from Julian Maurice --- Created attachment 164625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164625&action=edit Bug 35980: Check for CAN_user_borrowers_edit_borrowers in patron-toolbar.inc This patch removes the 'New patron' and 'Quick add new patron' buttons from the patron tool bar that's included on members-home.pl To test: 1. Log in with a user with only 'catalogue', 'list_borrowers' and 'manage_patron_lists' permissions 2. From the main page click on Patrons 3. Notice there are 'New patron' and 'Quick add new patron' buttons in the members-home.pl page that lead to permissions errors 4. Apply patch, restart all, reload the page 5. Notice the buttons to add new patrons are gone, but the button to manage patron lists is still there Signed-off-by: Esther Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35980] Add message to patron needs permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Julian Maurice changed: What|Removed |Added Attachment #164488|0 |1 is obsolete|| --- Comment #9 from Julian Maurice --- Created attachment 164624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164624&action=edit Bug 35980: Check for CAN_user_borrowers_edit_borrowers in more-member.tt This patch removes edit buttons and add buttons from the more member page if the user does not have CAN_user_borrowers_edit_borrowers To test: 1. Log in with a user with only 'catalogue' and 'list_borrowers' permissions 2. Search for a patron 3. Notice there are edit and add (pecil and plus icon) buttons in the patron details page 4. You may have to enable some system prefereences like HouseboundModule to fully test 5. Test that things like Additional attributes and identifiers are still displayed 3. Apply patch, restart all, reload the page 4. Notice the edit and add buttons in the patron details page are gone Signed-off-by: Esther Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35980] Add message to patron needs permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35980 Julian Maurice changed: What|Removed |Added Attachment #164433|0 |1 is obsolete|| --- Comment #8 from Julian Maurice --- Created attachment 164623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164623&action=edit Bug 35980: Check for CAN_user_borrowers_edit_borrowers in members-toolbar.inc This patch removes the message button and more links from the members toolbar if the user does not have CAN_user_borrowers_edit_borrowers To test: 1. Log in with a user with only 'catalogue' and 'list_borrowers' permissions 2. Search for a patron 3. Notice the 'Add message' and 'More' buttons in the toolbar only link to permissions errors 3. Apply patch, restart all, reload the page 4. Notice the buttons in the toolbar are gone Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
