[Koha-bugs] [Bug 37147] If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

--- Comment #4 from David Cook  ---
I've got the file, and tried it again in my dev environment, which should be
pretty much the same as the backup system it's not working on... but in local
dev the background job is correctly marked as "Failed", although the batch is
still marked as "Staged" instead of failed...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37147] If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

--- Comment #3 from David Cook  ---
Interestingly it seems easier to sneak bad bytes into Koha through MARC records
rather than MARCXML records... especially when you provide multiple records
with some of the records being 100% OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37147] If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

--- Comment #2 from David Cook  ---
Tricky trying to reproduce the scenario. Haven't yet received the real MARC
file with the problem, and my attempts to re-create one yield either a MARC
file that succeeds or fails to stage...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #102 from David Cook  ---
I'm curious if the code for failed imports was tested, as I'm not sure that
I've seen it work... see bug 37147

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

David Cook  changed:

   What|Removed |Added

 Blocks||37147


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147
[Bug 37147] If the MARC import chokes on bad record, it does not fail
background job or import
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37147] If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

David Cook  changed:

   What|Removed |Added

 Depends on||27421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37147] If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

--- Comment #1 from David Cook  ---
This is so bizarre...

I've added all this debugging code, and according to the code it is updating...
but it's not actually updating the database.

It looks a lot like a transaction related issue... but DBIx::Class's
transaction handling leaves a lot to be desired...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37147] New: If the MARC import chokes on bad record, it does not fail background job or import

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37147

Bug ID: 37147
   Summary: If the MARC import chokes on bad record, it does not
fail background job or import
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

I've had a library accidentally try to import a record with bad data, and the
MARC import is silently stopping. 

The background job stays stuck as "Started" and the batch stays stuck as
"Staged".

Glancing at the code... it looks like it should work. Going to spend a couple
minutes trying to figure this one out...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

--- Comment #36 from David Cook  ---
(In reply to Pedro Amorim from comment #35)
> What do others think about this?

I'm not sure at the moment. I find the whole situation to be a confusing and
unintuitive. 

Of course, any changes to how it processes now will cause potential breaking
changes for anyone who expects it to work as it works at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

Chris Cormack  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs Signoff   |RESOLVED
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
This was fixed by bug 37043 (which has been pushed to main already)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36996] Add a system preference to mark items unavailable in z9350 responder

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36996] Add a system preference to mark items unavailable in z9350 responder

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #167864|0   |1
is obsolete||

--- Comment #7 from Phil Ringnalda  ---
Created attachment 167943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167943&action=edit
Bug 36996: Add z3950Status system preference

This bug adds a new system preference 'z3950Status' which takes a yaml block
and marks any items matching
the conditions as unavailable via z3950 results

It obeys the existing z3950 extra fields, adding item ststus to field $k

To test:
0 - Apply patch, update database
1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU
servers:
host: localhost
port 2100
database: biblios
syntax: MARC21 (or UNIMARC if applicable)
2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml
Also make sure to remove the backslashes escaping the hyphens
3 - Restart all
4 - Cataloging - New from Z3950
5 - Search your records, view the marc to confirm status subfield $k is
included
6 - Add items to a record with various statuses (lost,damaged,withdrawn) and
itemtypes
7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k
8 - Search for record above - confirm statuses show as expected
9 - Edit new syspref z3950Status - confirm the language of the pref makes sense
itype: [BK]
ccode: [REF]
10 - Search z39 again and confirm items and collection codes are marked
'SYSPREF' in $k
11 - Edit Authorized values - add category Z3950_STATUS
12 - Add authorized vlaue: SYSPREF with Description: System preferenced
13 - Restart all
14 - Search z39 again and confirm statuses show new description

Sponsored by: Northeast Kansas Library System 
Sponsored by: South East Kansas Library System 

Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36996] Add a system preference to mark items unavailable in z9350 responder

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996

Phil Ringnalda  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34286] UpdateNotForLoanStatusOnCheckin doesn't update when there are holds or transfers

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34286

Chanel Wheeler  changed:

   What|Removed |Added

 CC||chanel.whee...@yavapaiaz.go
   ||v

--- Comment #1 from Chanel Wheeler  ---
+1 We have libraries using their AMH to check all the new items in. We really
need this to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37127] Authorized value select not working on authority forms.

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37127] Authorized value select not working on authority forms.

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #167892|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 167942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167942&action=edit
Bug 37127: Authorized value select not working on authority forms

Linking an authority subfield to an authorized value just leaves a blank
in the form rather than creating a , because there's a stray cud-
in the type returned from build_authorized_values_list.

Test plan:
 1. Without the patch, Administration - Authority types - Actions menu for
Default - MARC Structure
 2. Actions menu for 040 - Subfields
 3. Edit subfields - Tab b - Authorized value - set to LANG - Save changes
 4. Authorities - New authority - Default
 5. In 040 tag, click CATALOGING SOURCE to expand the tag
 6. Note that subfield b has a blank space rather than a dropdown menu
 7. Apply patch, restart_all
 8. Authorities - New authority - Default
 9. In 040 tag, click CATALOGING SOURCE to expand the tag
10. Note that subfield b has a dropdown menu listing language names

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37129] Patron attributes linked to an authorized value don't show a select menu in batch modification

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
   Patch complexity|--- |Trivial patch
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Passed QA

--- Comment #5 from Emily Lamancusa  ---
Thanks for the quick fix! Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37129] Patron attributes linked to an authorized value don't show a select menu in batch modification

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37129

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #167894|0   |1
is obsolete||

--- Comment #4 from Emily Lamancusa  ---
Created attachment 167941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167941&action=edit
Bug 37129: Patron attributes linked to an authorized value don't show a select
menu in batch modification

Test plan:
1. In Administration - Patron attribute types verify you have the default
   SHOW_BCODE using the YES_NO authorized value
2. Tools - Batch patron modification, add a patron card number or
   borrowernumber and continue
3. For Patron attribute select Show barcode on the summary screen item
   listings, and note that you get a blank text input rather than a select
   menu with Yes and No choices
4. Apply patch, restart_all
5. Repeat step 2 and 3, but note that you now get a Yes/No select menu

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36291] Scrolling glitch on ILL batches table

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36987] Add preference for which fields to prefill when copying a patron

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36987

he...@bywatersolutions.com changed:

   What|Removed |Added

 CC||he...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26649] Authorized Value suggest_status doesn't respect branch limitation

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649

Laura Escamilla  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu
   |ity.org |tions.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31719] Course name should enforce non-white-space character requirement

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31719

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37014] "Item was not checked in" printed on next POST because of missing supplementary form

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014

Lucas Gass  changed:

   What|Removed |Added

 Attachment #167341|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 167940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167940&action=edit
Bug 37014: Fix after-modal-POST to transmit "not_returned" message

The bug report addresses an issue where the message "Item was not checked in"
erroneously appears during the second POST after a manual or modal check-in
process.

1. In circ/returns.pl:
   - Introduced a new hash `%rinot_returned` to track items not returned across
pages.
   - Updated the logic to capture the "not returned" status from the query
parameters.
   - Adjusted the input processing loop to include `not_returned` status.
   - Modified the section handling barcode check-ins to appropriately
initialize and update the `not_returned` status.

2. returns.tt:
   - Added hidden input fields in the template to include `not_returned` status
in the form submissions.

The changes ensure that the "not_returned" status is correctly tracked and
displayed, preventing the erroneous message from appearing on subsequent POST
requests.

1. Perform a manual check-in of an item, but make some warning modal appear:
for ex., transfer: check-in the item in not home library.
2. Press OK on the modal. There will be a POST transition again to redraw the
checked-in items list.
3. Verify that the "Item was not checked in" message appears erroneously near
the item's row.
4. Apply the patch.
5. Repeat steps 1-3 and check that there will be no erroneous "Item was not
checked in" message.

Signed-off-by: Tadeusz „tadzik” Sośnierz 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37014] "Item was not checked in" printed on next POST because of missing supplementary form

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37014] "Item was not checked in" printed on next POST because of missing supplementary form

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014

Lucas Gass  changed:

   What|Removed |Added

Version|23.11   |Main
   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36460] When lost item payment is voided or refunded prompt librarian for new status

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36460

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

--- Comment #1 from Kyle M Hall  ---
Created attachment 167939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167939&action=edit
Bug 37145: Koha ERM data provider name search broken

This is broken because the FQDN for the service has changed and we do not
handle the 301 gracefully.

Test Plan:
1) Browser to ERM / eUsage / Data roviders
2) Click "New data provider"
3) Start typing anything into "Data provider name"
4) Note the error: "Something went wrong: Error: Internal Server Error."
5) Apply this patch
6) Restart all the things!
7) Repeat step 3
8) No error!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

Kelly McElligott  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
   ||,
   ||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@gmail.com   |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37145] New: Koha ERM data provider name search broken

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37145

Bug ID: 37145
   Summary: Koha ERM data provider name search broken
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.dru...@gmail.com
  Reporter: k...@bywatersolutions.com
CC: jonathan.dru...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
matt.blenkin...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com

This is broken because the FQDN for the service has changed and we do not
handle the 301 gracefully.

To test:
1) Browser to ERM / eUsage / Data roviders
2) Click "New data provider"
3) Start typing anything into "Data provider name"
4) Note the error: "Something went wrong: Error: Internal Server Error."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37065] Bookings tab should filter out completed bookings by default

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37065

Martin Renvoize  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26649] Authorized Value suggest_status doesn't respect branch limitation

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649

Jillian Rutledge  changed:

   What|Removed |Added

 CC||jrutledge@waterloopubliclib
   ||rary.org

--- Comment #3 from Jillian Rutledge  ---
Another vote to fix this bug! Thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #8 from Martin Renvoize  ---
I'm still not especially happy with the /kinds endpoint but at least with this
patch it responds something.. I think we should handle cleaning it up properly
in another bug.

I am fairly happy with the end result of the follow-up however. Please let me
know what you think Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #7 from Martin Renvoize  ---
Created attachment 167938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167938&action=edit
Bug 36641: (follow-up) Requested changes

This patch does a few things:

1) Moves /circulation-rules to /circulation_rules
2) Adds a the missing permission to /circulation_rules/kinds
3) Updates the circ-rule-kind definition to allow for the new fields
   added since the route was first defined
4) Adds a 'render_invalid_parameter_value' helper to ::Responses
5) Uses the above helper to render a 400 when an invalid branchcode,
   itemtype or patron category code is used for filtering
6) Converts from required path based parameters to optional query based
   parameters.
7) Refined the definition for the 'rules' response so we now only allow
   for 'string' or 'integer' values for the keys in the response.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165086|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 167937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167937&action=edit
Bug 36641: Add endpoint for fetching circulation rules

This patch is a proof of concept for an API endpoint that returns a list
of circulation rules for the specified itemtype, branchcode and patron
category combination.  You can also add a list of `rules` as a query
parameter to limit the response to only the rules you are interested in
for this combination.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36875] SQL injection in additional content pages

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36875

--- Comment #49 from Katrin Fischer  ---
Pushed for 24.11!
Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36818] Remote-Code-Execution (RCE) in upload-cover-image.pl (CVE-2024-36057)

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36818

--- Comment #32 from Katrin Fischer  ---
Missed the wrong commit message... Bug: ...

Pushed for 24.11!
Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36520] SQL Injection in opac-sendbasket.pl (CVE-2024-36058)

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36520

--- Comment #65 from Katrin Fischer  ---
Pushed for 24.11!
Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36575] Wrong patron can be returned for API validation route

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36575

--- Comment #51 from Katrin Fischer  ---
Pushed for 24.11!
Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37144] New: Add a subpermission for hiding patron contact information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37144

Bug ID: 37144
   Summary: Add a subpermission for hiding patron contact
information
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: laura.escami...@bywatersolutions.com
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently, Koha lacks a subpermission feature that allows libraries, especially
those in correctional facilities utilizing inmate volunteers, to hide patron
contact information (e.g., addresses) from certain users like volunteers. This
privacy gap poses a significant risk, potentially exposing sensitive inmate
data to unauthorized personnel. Implementing a subpermission feature would
ensure that only authorized staff can access such sensitive information,
addressing critical privacy concerns within these specialized library
environments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15495] Change Browse Shelf Display

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15495

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

--- Comment #1 from Koha collecto  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

--- Comment #35 from Pedro Amorim  ---
Thank you, Esther, for the detailed instructions and sample file.
I believe that for the stage file import scenario, the setting 'How to process
items:' being 'Always add items' (default) is what is causing each new MARC
item entry (952 for MARC21) to forcibly create a new item.

Imo, the ideal solution here would be to also have a 'How to process items'
option in the MARC modification template tool UI (the screen that shows after
you select 'Modify record using template') from a bib record. This would work
around/with the actions coming from the modification template in the same way
the stage import flow currently does, ideally using the same code, for
consistency.

In conclusion, I believe the behavior differs because the 'stage MARC record
file for import' has additional logic on top of the MARC modification template
actions, whereas the 'Modify record using template' only considers the actions
from the MARC modification template and nothing else.

Would the suggestion above be better handled in a follow-up bug or here?

What do others think about this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

--- Comment #4 from Lucas Gass  ---
Created attachment 167936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167936&action=edit
Bug 37143: Do not allow required fields with only whitespace to be submitted

To test:
1. Make some fields for OPAC self registration required.
2. Create a new patron via self reg.
3. Fill out those required fields as an empty string like "  ".
4. Submit the form, it succeeds.
5. APPLY PATCH, restart_all
6. Try again. Required fields with only whitespace are treated as if they were
empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

--- Comment #3 from Lucas Gass  ---
For example:

1. Do a patron search in the staff interface for all patrons. In k-t-d this
works fine.
2. Self register a patron. For the required firstname and surname fields use an
empty string like "  ".
3. You can successfully register.
4. Go back to the staff client and do the same patron search, it never
completes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 32742] Add sorting options to patron list export

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32742

Alexandre Noel  changed:

   What|Removed |Added

 CC||alexandre.n...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
This is true for staff interface patron reg as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
"difficulties" = 500 error searching for patrons where the erroneous patron is
part of the result set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #5 from Martin Renvoize  ---
(In reply to Martin Renvoize from comment #4)
> OK, so you'd like me to update the existing endpoint to
> `/circulation_rules/kinds` and add mine as `/circulation_rules`. I can do
> that.. though do we know if anyone out there is using the /kinds route
> already?

Consider in testing now, it's already broken I think we're safe to change it
now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37136] Google Books - catalog books using Google Books data

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37136

--- Comment #3 from Katrin Fischer  ---
If a feature was added to pull information from Google Books it would still
have to be transformed into a basic MARC record. It's possible. I was more
trying to say you should try other options too as neither the LOC nor Google
Books are the only ones. There are a lot of big library catalogs that might
have nicer data already, saving you even more work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37078] Damaged Status not showing in detail.pl

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078

ho...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ho...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37143] New: Patron registration allows for saving required fields with a single space instead of information

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143

Bug ID: 37143
   Summary: Patron registration allows for saving required fields
with a single space instead of information
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When creating a patron or self registration a single space (or series of
spaces) can be saved instead of required information in fields. This can cause
difficulties in finding patrons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36520] SQL Injection in opac-sendbasket.pl (CVE-2024-36058)

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36520

--- Comment #64 from Katrin Fischer  ---
(In reply to Karolis Narvilas from comment #63)
> Thanks - is there an approximate timeline for when these fixes will be
> published ?

The security releases have gone out now with these fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37136] Google Books - catalog books using Google Books data

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37136

--- Comment #2 from antian...@gmail.com ---
Thank you Katrin.

I also wanted to ask kindly:

What’s the rationale of limiting Koha to MARC records only?  I mean, I
understand that some libraries want their resources discoverable on Worldcat
and to have library of congress call numbers etc.  We want this too.  But there
also also the immediate utilities and needs of a library to be able to
catalogue a book quickly so it can make it available to it’s users sooner, and
if Google Books is providing such quick but incomplete records, at least the
books can be used right away and additional info added later.

Would adding a Google Books option require a completely different system?  Is
there an automatic clash with MARC and Z39 if an option like that is enabled? 
Like can’t I sometimes catalogue MARC and sometimes use a Google Books option
knowing that it will give me a more basic record?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36488] Flatpickr creates invalid date entries

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488

Katrin Fischer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

--- Comment #10 from Katrin Fischer  ---
*** Bug 37142 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37142] Self registration allows for invalid birthdate

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37142

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
We are seeing the same since the update, I filed as:
Bug 36488 - Flatpickr creates invalid date entries

*** This bug has been marked as a duplicate of bug 36488 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37142] New: Self registration allows for invalid birthdate

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37142

Bug ID: 37142
   Summary: Self registration allows for invalid birthdate
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The self-registration on the OPAC allows for invalid dob to be saved, such as
with spaces instead of numbers. This breaks patron search for searches
involving that patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured per library on the command line

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596

ho...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ho...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #4 from Martin Renvoize  ---
I'm looking to come back to this now.

OK, so you'd like me to update the existing endpoint to
`/circulation_rules/kinds` and add mine as `/circulation_rules`. I can do
that.. though do we know if anyone out there is using the /kinds route already?

I did think about the order of parameters, though I not wed to it.  I had them
as path params as I felt it made it clearer that the endpoint expects all of
them to be filled.. however we could just have them as query params and then
order is inherently meaningless and in fact we don't actually always needs all
of them really.

Yes, I said the return structure is underspecified.. but it's also a bit
variable.. I'll try to see what I can come up with.

Are you saying you want the 'kinds' param to be an enum of all rule kinds..  I
was sort of trying to avoid having to list those again..  I wish it was simple
to build this particular list from code to embed into the spec.. maybe I can..
I'll investigate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Isabel Pineda  changed:

   What|Removed |Added

 CC||isabel.pin...@ds.edu.sv

--- Comment #10 from Isabel Pineda  ---
I updated from 23.11 to 24.05 a few days ago, but now the renewal for a
specific date is not working anymore. Although I give a specific date for a
specific renewal, the system takes automatically the hard due date from the
circulation rules. 

e.g.
In "Administration > Circulation rules" I save "15.08.2024" as hard due date
for a specific item type and patron category.
Then I go to one patron of the above category to renew his borrowed items, and
manually select "30.07.2024" as due date.
-> The system renews the items until 15.08.24. It ought to prioritize the
manual due date for this specific patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37014] "Item was not checked in" printed on next POST because of missing supplementary form

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014

ho...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ho...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33801] Holds API doesn't follow holds policies like the staff/OPAC UIs

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33801

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #167794|0   |1
is obsolete||

--- Comment #15 from Thibaud Guillot  ---
Created attachment 167935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167935&action=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
OPAC search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind 
Signed-off-by: Thibaud Guillot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37141] Add option to display completed bookings from patron page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37141] Add option to display completed bookings from patron page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141

--- Comment #1 from Martin Renvoize  ---
Created attachment 167934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167934&action=edit
Bug 37141: Add 'Include completed' option to bookings tab

This patch adds the 'Include completed' filter toggle option to the
bookings display tab on both the patron details and circulation pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37141


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141
[Bug 37141] Add option to display completed bookings from patron page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37141] Add option to display completed bookings from patron page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||37047


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047
[Bug 37047] Patron Bookings not visible from Patrons Checkout page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37141] Add option to display completed bookings from patron page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37141] New: Add option to display completed bookings from patron page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141

Bug ID: 37141
   Summary: Add option to display completed bookings from patron
page
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently on the bookings tab of the patron pages, we always filter to active
bookings.

We should add the option to display completed bookings too; This would match
the functionality introduced in the biblio details view for bookings in bug
37065

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36915] Send email notification when a booking is cancelled

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
I like this, and it was indeed on my enhancements list ;)

Couple of comments, however.. 

1) Could we pass the bookings object into GetPreparedLetter instead of passing
various individual pieces. (Bug 19966 adds this functionality to
GetPreperaredLetter, you'd want to pass the object and then call delete at the
end of the method after GetPreparredLetter has returned)
2) Could we add a sample notice template too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36956] ERM eUsage reports : only the first 20 data providers are listed when creating a new report

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #167221|0   |1
is obsolete||

--- Comment #3 from Pedro Amorim  ---
Created attachment 167933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167933&action=edit
Bug 36956: Allow all providers to be displayed in reports

This patch fixes an incorrect usage of the API which was only returning 20
results.

Test plan:
1) Go to ERM module and make sure you have more than 20 data providers stored
in your database.
1) (Optional) Run the following command (k-t-d) to create 21 data providers:
  perl -MKoha::Database -e '
  my $schema = Koha::Database->schema;

  $schema->resultset("ErmUsageDataProvider")->create({
  name => "name ".$_
  }) for (1..21)
  '
2) Go to eUsage / reports and create new report
(cgi-bin/koha/erm/eusage/reports)
3) Check that only the first 20 data providers are displayed in the drop down
4) Apply patch
5) yarn build or reset_all to rebuild the javascript
6) Repeat steps 1-3, all providers should now be displayed

PA amended patch: Updated commit message test plan

Signed-off-by: Michaela Sieber 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36956] ERM eUsage reports : only the first 20 data providers are listed when creating a new report

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956

Pedro Amorim  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37065] Bookings tab should filter out completed bookings by default

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37065

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37065] Bookings tab should filter out completed bookings by default

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37065

--- Comment #1 from Martin Renvoize  ---
Created attachment 167932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167932&action=edit
Bug 37065: Filter completed bookings by default

This patch adds a default filter for the bookings table on the bookings
tab of a biblio.  We also add the option to turn off the filtering after
initial page load.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36956] ERM eUsage reports : only the first 20 data providers are listed when creating a new report

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956

Pedro Amorim  changed:

   What|Removed |Added

 QA Contact||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37058] Issue data provider form

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37058

--- Comment #1 from Michaela Sieber  ---

> In the Koha_ERM module, we cannot fetch usage stats using SUSHI because it
> requires a field to mention the platform, e.g., ScienceDirect and Scopus.
> Kindly resolve the issue.

Your Screenshot is about Elsevier via ScienceDirect

Have you already tried :

ScienceDirect as Data provider (from registry)

https://registry.countermetrics.org/platform/ab4d3560-1165-491d-a67e-9359d02c2a96

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37065] Bookings tab should filter out completed bookings by default

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37065

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37065] Bookings tab should filter out completed bookings by default

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37065

Martin Renvoize  changed:

   What|Removed |Added

Summary|Bookings tab should filter  |Bookings tab should filter
   |out ocmpleted bookings by   |out completed bookings by
   |default |default

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36428] Current bookings are not counted in record side bar

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36428

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Martin Renvoize  ---
Thanks all, glad to see this fixed.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36428] Current bookings are not counted in record side bar

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36428

--- Comment #8 from Martin Renvoize  ---
Created attachment 167931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167931&action=edit
Bug 36428: (QA follow-up) Add bookings_count class to patron details

Somewhere along the line we lost the 'bookings_count' class in the
bookings tab display on the patron details and circulation page.

This patch restores is and as such also restores the correct count
numbers on 'place booking' and 'cancel booking' actions on those pages.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36428] Current bookings are not counted in record side bar

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36428

--- Comment #7 from Martin Renvoize  ---
Created attachment 167930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167930&action=edit
Bug 36428: (QA follow-up) Remove filter_by_future

I actually already started to remove this in another bug, but it makes
sense to do it here where we're introducing the 'active' filter.  I'm in
agreement that this should probably always have been an 'active' rather
than 'future' filtering.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36428] Current bookings are not counted in record side bar

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36428

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #167694|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 167929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167929&action=edit
Bug 36428: Add Bookings->filter_by_active and use it for display

Currently the bookings tab on a biblio details and patron details use
'filter_by_future'
which lists upcoming bookings.

Libraries would like to see upcoming, and active bookings in these cases, and
we should add a filter
for bookings that have not ended.

NOTE: This removes the only uses of filter_by_future, but I preserve this for
Martin's decision as the creator
of the bookings module

To test:
 1 - Make an item bookable from the items tab on a record details
 2 - Return to details view and place a booking
 3 - Note sidebar says "Bookings (1)"
 4 - Make the booking current from the DB:
 UPDATE bookings SET start_date=NOW() WHERE biblio_id={biblionumber};
 5 - Reload the page
 6 - Note the count is now "Bookings (0)"
 7 - View the patron's details page - note "Bookings (0)" and none listed
 8 - Apply patch
 9 - Reload biblio details, note Bookings(1)
10 - Reload patron details, note Bookings(1) and booking is listed
11 - End the booking:
 UPDATE bookings SET end_date=NOW() WHERE biblio_id={biblionumber};
12 - Confirm booking no longer listed on biblio or patron details

Signed-off-by: Sam Lau 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36428] Current bookings are not counted in record side bar

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36428

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #19 from Martin Renvoize  ---
All working well including with QA follow-ups.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

--- Comment #18 from Martin Renvoize  ---
Created attachment 167928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167928&action=edit
Bug 37047: (QA follow-up) Remove nesting of document ready function

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #167745|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 167927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167927&action=edit
Bug 37047: (QA follow-up) Move non-bookings code back

We inadvertantly adding a little more than just the bookings table js
into it's own asset. This patch moves that code back and also renames
the asset file to /tables/bookings.js from /bookings-table.js as is the
scheme we're attempting to follow now (see '/modals/').

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #167744|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 167926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167926&action=edit
Bug 37047: Make use of DRY bookings-table.js in moremember.tt

Test plan:
No functionality change, follow the original test plan and make sure the
table is displayed correctly on both screens:
/cgi-bin/koha/circ/circulation.pl?borrowernumber=
/cgi-bin/koha/members/moremember.pl?borrowernumber=1

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #167743|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 167925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167925&action=edit
Bug 37047: Move bookings table JS table to its own file

For reusability

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37047] Patron Bookings not visible from Patrons Checkout page

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #167742|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 167924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167924&action=edit
Bug 37047: Make Patron Bookings table visible from Patrons Checkout page

This patch makes it so that the patron bookings table loads properly from teh
checkout page. Previously, it was only loading correctly from the details page.

To test:
1. Create an item bookable.
2. Book an item for a patron.
3. Go to the patron's checkout page.
4. See they have a Booking (1) in their tab.
5. Click this tab, but nothing appears.
6. Apply patch, restart_all
7. See they still have a Booking (1) in their tab.
8. Click this tab, table loads as expected.

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34668] Notify staff with a pop-up about waiting holds for a patron when checking out

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668

Saija Pyhtilä  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 CC||saija.pyht...@metropolia.fi

--- Comment #37 from Saija Pyhtilä  ---
Tested this test plan: If there is item1 waiting for user A and other available
item2 connected to same biblio is going to be checked out by user B, also user
B gets this pop-up "this patron has waiting holds" even if the user B doesn't
have any items to be picked up.  

So this setting is maybe not functioning as it should: so all users get the
notification when checking out same book title (different items) until user A
picks up and check outs the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36392] Only 20 vendors in ERM dropdown

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392

Michaela Sieber  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36956

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 36956] ERM eUsage reports : only the first 20 data providers are listed when creating a new report

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36956

Michaela Sieber  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36392

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37007] Should we move vendors out of the acq module?

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37007

--- Comment #2 from Michaela Sieber  ---
I think it doesn't matter in which module the vendors are managed, acquistion
is ok for us. It is more important to have more granular permissions, the
vendors_manage is not enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8137] Checkout limit for all libraries

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #167208|0   |1
is obsolete||

--- Comment #111 from Thibaud Guillot  ---
Created attachment 167923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167923&action=edit
Bug 8137: Add 'global' has_priority rules for checkouts

I tried to review the desired behavior through this bug.
The goal would be to be able to have a general 'override' rule.
Currently, if you set a max_checkouts_allowed of 5 (regardless of itemtype) in
one library, for example, and do the same in another, it adds up to 10.

By giving checkout rules priority, you "overwrite" other local rules per
branchcode.

Test plan:

1) Set for library "A"  a max_checkouts_allowed to 3 for any type of user
   and item type.
2) On main rules set the same rule to 2
3) Do a few checkouts with a user belonging to library A, normally you'll be
able to do 3.
4) Apply this patch and run updatedatabase.pl and also rebuild your
   schema by updating dbix class files
5) See now the Has priority checkboxes on "Default checkout, hold and return
policy" and "Default checkout, hold policy by patron category"
6) You can set here you new rule for "Total current checkouts allowed"
   to 2
7) Repeat step 3 and normally you won't be able to make the third

Sponsored-by: BibLibre

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8137] Checkout limit for all libraries

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35938] Add lots of biblios to a list causes a URL too long error

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35938

--- Comment #4 from Katrin Fischer  ---
(In reply to Mathieu Saby from comment #3)
> I thought there was a REST API for managing virtualsheves. It seems it is
> not yet the case ?

Not yet I think, looking at api.koha-community.org.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/