[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Text to go in the||Part of the ongoing effort release notes||to improve the ||maintainability of our ||codebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Component|Acquisitions|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Severity|minor |enhancement Patch complexity|--- |Trivial patch Resolution|--- |FIXED --- Comment #16 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #14 from Josef Moravec --- Created attachment 87082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87082=edit Bug 10577: (QA follow-up) Remove tab chars Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added Attachment #87010|0 |1 is obsolete|| --- Comment #13 from Josef Moravec --- Created attachment 87081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87081=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec changed: What|Removed |Added Attachment #87009|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 87080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87080=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Attachment #86566|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 87010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87010=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Attachment #86565|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 87009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87009=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11578 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Attachment #86564|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 86566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86566=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Attachment #86563|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #8 from Martin Renvoize --- Created attachment 86565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86565=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Patch rescued and tested.. Signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Attachment #19578|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 86563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86563=edit bug 10577: improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #6 from Martin Renvoize --- Created attachment 86564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86564=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|In Discussion |Needs Signoff --- Comment #4 from Martin Renvoize --- This is still the case but I think the issue with it that Katrin found was resolved in bug 11578, setting back to NSO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #3 from Galen Charlton gmcha...@gmail.com --- (In reply to Katrin Fischer from comment #2) Galen, I think I found a problem with this - you said it's never used, but from the description I thought about the funds page and spotted a problem there: - Apply the patch - Go to the funds page - The heading is missing the budget information now - it shows: Funds for '' I think this is a design issue of the funds page really. Maybe we just should add a budget column to the table and reword the heading so it can deal with funds from multiple budgets? But not sure how that would affect other functionality on that page. Good catch. The funds page appears to still partially reflect an (old?) assumption that there would be only one active budget at a time. That assumption is nonsense nowadays, so I still believe that I'm on the right track with the change I made to GetBudgetPeriod(). Of course, it does need to be accompanied by a follow-up so that we don't have the Funds for '' situation. My proposal: - add a column for the parent budget (should it always be displayed, or only when no specific budget_period_id is passed?) - adjust the code that generates the hover to make sure that the parent budget is supplied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Created attachment 19578 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19578action=edit bug 10577: improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get the active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of the active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||10535 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Galen, I think I found a problem with this - you said it's never used, but from the description I thought about the funds page and spotted a problem there: - Apply the patch - Go to the funds page - The heading is missing the budget information now - it shows: Funds for '' I think this is a design issue of the funds page really. Maybe we just should add a budget column to the table and reword the heading so it can deal with funds from multiple budgets? But not sure how that would affect other functionality on that page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
